[PATCH] IPv6 - Add missing initializations of the new nl_info.nl_net field

2008-02-25 Thread Benjamin Thery
Here is an updated version of the patch without the initializations to "zero". Add some more missing initializations of the new nl_info.nl_net field in IPv6 stack. This field will be used when network namespaces are fully supported. Signed-off-by: Benjamin Thery <[EMAIL PROTECT

[PATCH] IPv6 Add more initializations of the new nl_info.nl_net field

2008-02-21 Thread benjamin . thery
Add more missing initializations of the new nl_info.nl_net field in IPv6 stack. This field will be used when network namespaces are fully supported. Signed-off-by: Benjamin Thery <[EMAIL PROTECTED]> --- net/ipv6/addrconf.c |9 + net/ipv6/route.c|6 ++ 2 files c

Re: [BUG] IPv6 recursive locking

2008-02-17 Thread Benjamin Thery
On Feb 17, 2008 7:30 PM, Daniel Lezcano <[EMAIL PROTECTED]> wrote: > Kristof Provost wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > Hi, > > > > I'm running the current git (1309d4e68497184d2fd87e892ddf14076c2bda98) > > without problems. While I was toying with IPv6 on my local

Re: [2.6.25-rc2] System freezes ca. 1 minute after logging into KDE

2008-02-17 Thread Benjamin Thery
On Feb 17, 2008 11:39 AM, Frans Pop <[EMAIL PROTECTED]> wrote: > (resend a third time because previous attempts never reached the lists > due to a bug in my MUA; my apologies to David for spamming his inbox) > > Linus Torvalds wrote: > > But hey, you can try to prove me wrong. I dare you. > Me too

Re: [PATCH][RFC] race in generic address resolution

2008-02-14 Thread Benjamin Thery
ted_tty_write+0x0/0x72 [] vfs_write+0x8c/0x108 [] sys_write+0x3b/0x60 [] syscall_call+0x7/0xb === On Thu, Feb 14, 2008 at 5:56 PM, Benjamin Thery <[EMAIL PROTECTED]> wrote: > Hi, > > It seems this patch hangs my machine very quickly when there are some >

Re: [PATCH][RFC] race in generic address resolution

2008-02-14 Thread Benjamin Thery
Hi, It seems this patch hangs my machine very quickly when there are some ICMPv6 traffic. I'm using net-2.6, pulled today (14th Feb). I had some unexpected hangs on my SMP test machines and I bisected the problem to 69cc64d8d92bf852f933e90c888dfff083bd4fc9 "[NDISC]: Fix race in generic address

[PATCH 1/1][NETNS] Add missing initialization of nl_info.nl_net in rtm_to_fib6_config()

2008-01-24 Thread Benjamin Thery
Add missing initialization of the new nl_info.nl_net field in rtm_to_fib6_config(). This will be needed the store network namespace associated to the fib6_config struct. Signed-off-by: Benjamin Thery <[EMAIL PROTECTED]> --- net/ipv6/route.c |1 + 1 file changed, 1 insertion(+) Inde

Re: [PROCFS] [NETNS] issue with /proc/net entries

2008-01-11 Thread Benjamin Thery
Eric W. Biederman wrote: Benjamin Thery <[EMAIL PROTECTED]> writes: Hi Eric, While testing the current network namespace stuff merged in net-2.6.25, I bumped into the following problem with the /proc/net/ entries. It doesn't always display the actual data of the current nam

[PROCFS] [NETNS] issue with /proc/net entries

2008-01-10 Thread Benjamin Thery
Hi Eric, While testing the current network namespace stuff merged in net-2.6.25, I bumped into the following problem with the /proc/net/ entries. It doesn't always display the actual data of the current namespace, but sometime displays data from other namespaces. I bisected the problem to the co

Re: [patch 5/9][NETNS][IPV6] make bindv6only sysctl per namespace

2008-01-07 Thread Benjamin Thery
Daniel, The kernel fails to build with this patch applied when CONFIG_SYSCTL=n See comment below. Daniel Lezcano wrote: This patch moves the bindv6only sysctl to the network namespace structure. Until the ipv6 protocol is not per namespace, the sysctl variable is always from the initial network

Re: 2.6.24-rc5-mm1

2007-12-13 Thread Benjamin Thery
The problem comes from the new macro UDPX_INC_STATS_BH introduced by Herbert, which was a nice addition to increment the correct UDP MIB depending on the socket family, but unfortunately the use of this macro from kernel code (I mean code not compiled as module) requires that IPv6 is also compil

Re: [PATCH 1/2] Convert /proc/net/ipv6_route to seq_file interface

2007-10-30 Thread Benjamin Thery
Cosmetic comment: I forgot to say there are a few indentation "errors" when I apply your patch. See below. Benjamin Thery wrote: > Alexey Dobriyan wrote: >> One proc_net_create() user less. > > Funny, I was working on a similar patch. > > See comment below.

Re: [PATCH 1/2] Convert /proc/net/ipv6_route to seq_file interface

2007-10-30 Thread Benjamin Thery
Alexey Dobriyan wrote: > One proc_net_create() user less. Funny, I was working on a similar patch. See comment below. > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> > --- > > net/ipv6/route.c | 70 > +++ > 1 file changed, 25 inserti

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-26 Thread Benjamin Thery
hen initialized the module tries to register its pernet operations and add them in the pernet_list. Unfortunately this list is corrupted as its first entries have been freed at the end of the boot sequence. Signed-off-by: Benjamin Thery <[EMAIL PROTECTED]> --- drivers/net/loopback.c

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Benjamin Thery
Eric W. Biederman wrote: > Benjamin Thery <[EMAIL PROTECTED]> writes: > >> Denis V. Lunev wrote: >>> The patch attached should help. The idea is simple. The "init" should be >>> called only once without NETNS. Period. No need for any lists. >>

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Benjamin Thery
send it to Dave after the ACK. Tested on x86_64 with CONFIG_NET_NS=n and y. It fixes the issue we observed. Acked-by: Benjamin Thery <[EMAIL PROTECTED]> > Regards, > Den > > Benjamin Thery wrote: >> Hello Pavel, >> >> I've found a problem with o

[NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Benjamin Thery
Hello Pavel, I've found a problem with one of your patch related to netns: * [NETNS] Move some code into __init section when CONFIG_NET_NS=n (v2) http://www.spinics.net/lists/netdev/msg43310.html This patch introduces the __net_init/__net_exit/__net_initdata defines to save some memory when C

[PATCH] [IPv6]: use container_of() macro in fib6_clean_node()

2007-10-08 Thread Benjamin Thery
x27;w' field in struct fib6_cleaner_t, (and to improve readability), this patch uses the container_of() macro. Patch for net-2.6.24 Signed-off-by: Benjamin Thery <[EMAIL PROTECTED]> --- net/ipv6/ip6_fib.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net

[PATCH 1/1][NET] : Fix dev_put() and dev_hold() comments

2007-10-02 Thread Benjamin Thery
Trivial fix: Swap comments for dev_put() and dev_hold() to get them at the right place. Typo introduced by 4fa57c9ea9f36f9ca852f3a88ca5d2f1aebbc960. Signed-of-by: Benjamin Thery <[EMAIL PROTECTED]> --- include/linux/netdevice.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH] Rename struct net to struct netns

2007-09-17 Thread Benjamin Thery
Daniel Lezcano wrote: > Pavel Emelyanov wrote: >> The name struct net is too generic. There already were >> some people who wanted to have some better name (for >> easier grep for example). I propose the struct netns one. >> >> The patch is (already) huge (sorry), but it's nothing but >> sed -e s

Re: [PATCH 1/1] net/core: Fix crash in dev_mc_sync()/dev_mc_unsync()

2007-08-22 Thread Benjamin Thery
mc_unsync(). Signed-off-by: Benjamin Thery <[EMAIL PROTECTED]> --- net/core/dev_mcast.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) Index: linux-2.6.23-rc2/net/core/dev_mcast.c === --- linux-2.6.23-rc

[PATCH 0/1] net/core: Crash in dev_mc_sync() when putting macvlan interface up

2007-08-21 Thread Benjamin Thery
Hi, My kernel crashed while testing macvlan interfaces on 2.6.23-rc2. (See kernel panic below) The culprit is dev_mc_sync(). In this routine, we delete elements from 'from->mc_list' unsafely. While going through the list, we may delete one of the element (__dev_addr_delete(from->mc_list,...)),

[PATCH 1/1] net/core: Fix crash in dev_mc_sync()/dev_mc_unsync()

2007-08-21 Thread Benjamin Thery
This patch fixes a crash that may occur when the routine dev_mc_sync() deletes an address from the list it is currently going through. It saves the pointer to the next element before deleting the current one. The problem may also exist in dev_mc_unsync(). Signed-off-by: Benjamin Thery <[EM

Re: [RFC] restore netdev_priv optimization

2007-08-20 Thread Benjamin Thery
Hi, David Miller wrote: From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 17 Aug 2007 15:40:22 -0700 Compile tested only!!! Obviously. The first loopback transmit is guarenteed to crash. [...] And this also breaks loopback again, which uses a static struct netdev in the kernel image,

L2 network namespaces + macvlan performances

2007-07-06 Thread Benjamin Thery
Following a discussion we had at OLS concerning L2 network namespace performances and how the new macvlan driver could potentially improve them, I've ported the macvlan patchset on top of Eric's net namespace patchset on 2.6.22-rc4-mm2. A little bit of history: Some months ago, when we ran some

Re: [Devel] Re: [PATCH] Virtual ethernet tunnel

2007-06-07 Thread Benjamin Thery
David Miller wrote: From: Kirill Korotaev <[EMAIL PROTECTED]> Date: Thu, 07 Jun 2007 12:14:29 +0400 David Miller wrote: From: Pavel Emelianov <[EMAIL PROTECTED]> Date: Wed, 06 Jun 2007 19:11:38 +0400 Veth stands for Virtual ETHernet. It is a simple tunnel driver that works at the link layer

Re: L2 network namespace benchmarking (resend with Service Demand)

2007-04-06 Thread Benjamin Thery
Eric W. Biederman wrote: Daniel Lezcano <[EMAIL PROTECTED]> writes: Hi, as suggested Rick, I added the Service Demand results to the matrix. A couple of random thoughts in trying to understand the numbers you are seeing. - Checksum offloading? You have noted that with the bridge netfilte

Re: L2 network namespace benchmarking

2007-03-28 Thread Benjamin Thery
Eric W. Biederman wrote: Daniel Lezcano <[EMAIL PROTECTED]> writes: [...] * When do you expect to have the network namespace into mainline ? My current goal is to finish my rebase against 2.6.linus_lastest in the next couple of days after having figured out how to deal with sysfs. Great ne

Re: [PATCH RFC 17/31] net: Factor out __dev_alloc_name from dev_alloc_name

2007-03-05 Thread Benjamin Thery
Hello Eric, See comments about __dev_alloc_name() below. Regards, Benjamin Eric W. Biederman wrote: From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted When forcibly changing the network namespace of a device I need something that can generate a name for the device in the new namespace wit

Re: Lost packets after switching Wi-Fi AP

2006-10-31 Thread Benjamin Thery
Jiri Benc wrote: On Mon, 30 Oct 2006 15:55:57 +0100, Benjamin Thery wrote: When I switch my Mobile Node between 2 Wi-Fi Access Points, there is a period of time where all the packets I send are lost, although I got the netlink event SIOCGIWAP 'up' for the new AP. The device is supp

Lost packets after switching Wi-Fi AP

2006-10-30 Thread Benjamin Thery
Hello, I work on an extension of the mobility protocol for IPv6 (FMIPv6-RFC4068) and I've noticed the following problem: When I switch my Mobile Node between 2 Wi-Fi Access Points, there is a period of time where all the packets I send are lost, although I got the netlink event SIOCGIWAP 'up