Re: [Xen-devel] [PATCH] xen-netfront: Fix hang on device removal

> > Signed-off-by: Jason Andryuk <jandr...@gmail.com> > Cc: Eduardo Otubo <ot...@redhat.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com>

Re: [PATCH 2/2] xen-netfront: Fix race between device setup and open

ssibility that we fail to recreate the queues so check for this > in the open function. > > Signed-off-by: Ross Lagerwall <ross.lagerw...@citrix.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com>

Re: [Xen-devel] [PATCH] xen-netfront: enable device after manual module load

ould communicate the netback to create its > device and establish the connection between them. > > Signed-off-by: Eduardo Otubo <ot...@redhat.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Should this go to stable trees as well? -boris > --- > drivers/net/

Re: [PATCH] xen-netfront, xen-netback: Use correct minimum MTU values

igned-off-by: Mohammed Gamal <mga...@redhat.com> > Acked-by: Wei Liu <wei.l...@citrix.com> > > CC netfront maintainers Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> I can take it via Xen tree unless there are objections. -boris

Re: [Xen-devel] [PATCH 29/29] drivers, xen: convert grant_map.users from atomic_t to refcount_t

;keesc...@chromium.org> >>> Signed-off-by: David Windsor <dwind...@gmail.com> >>> --- >>> drivers/xen/gntdev.c | 11 ++- >>> 1 file changed, 6 insertions(+), 5 deletions(-) >> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> &g

Re: [Xen-devel] [PATCH 29/29] drivers, xen: convert grant_map.users from atomic_t to refcount_t

++- > 1 file changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com>

Re: BUG due to "xen-netback: protect resource cleaning on XenBus disconnect"

On 03/02/2017 06:56 AM, Juergen Gross wrote: > With commits f16f1df65 and 9a6cdf52b we get in our Xen testing: > > [ 174.512861] switch: port 2(vif3.0) entered disabled state > [ 174.522735] BUG: sleeping function called from invalid context at > /home/build/linux-linus/mm/vmalloc.c:1441 > [

Re: [PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect_backend()

On 02/03/2017 04:38 AM, Juergen Gross wrote: On 30/01/17 18:45, Boris Ostrovsky wrote: rx_refill_timer should be deleted as soon as we disconnect from the backend since otherwise it is possible for the timer to go off before we get to xennet_destroy_queues(). If this happens we may

Re: [PATCH] xen-netfront: Rework the fix for Rx stall during OOM and network stress

etfront: Fix Rx stall during network stress and OOM) > Reported-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com>

Re: [PATCH v3] xen-netfront: Improve error handling during initialization

;queues); > + info->queues = NULL; > + goto out; > + } I think it might be better to kfree() in xennet_create_queues() (and set num_queues to zero, while at it). But either way: Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> > >

Re: [PATCH v2] xen-netfront: Improve error handling during initialization

On 02/07/2017 09:55 AM, Ross Lagerwall wrote: > This fixes a crash when running out of grant refs when creating many > queues across many netdevs. > > * If creating queues fails (i.e. there are no grant refs available), > call xenbus_dev_fatal() to ensure that the xenbus device is set to the >

Re: [PATCH] xen-netfront: Improve error handling during initialization

On 02/02/2017 09:54 AM, Ross Lagerwall wrote: > On 02/01/2017 06:54 PM, Boris Ostrovsky wrote: >> On 02/01/2017 10:50 AM, Ross Lagerwall wrote: >>> Improve error handling during initialization. This fixes a crash when >>> running out of grant refs when creating many que

Re: [PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect_backend()

On 01/31/2017 12:47 PM, Boris Ostrovsky wrote: > On 01/30/2017 02:31 PM, Boris Ostrovsky wrote: >> On 01/30/2017 02:06 PM, Eric Dumazet wrote: >>> On Mon, 2017-01-30 at 13:23 -0500, Boris Ostrovsky wrote: >>> >>>> We do netif_carrier_off() f

Re: [PATCH] xen-netfront: Improve error handling during initialization

On 02/01/2017 10:50 AM, Ross Lagerwall wrote: > Improve error handling during initialization. This fixes a crash when > running out of grant refs when creating many queues across many netdevs. > > * Delay timer creation so that if initializing a queue fails, the timer > has not been setup yet. > *

Re: [PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect_backend()

On 01/30/2017 02:31 PM, Boris Ostrovsky wrote: > On 01/30/2017 02:06 PM, Eric Dumazet wrote: >> On Mon, 2017-01-30 at 13:23 -0500, Boris Ostrovsky wrote: >> >>> We do netif_carrier_off() first thing in xennet_disconnect_backend() and >>> the only

Re: [PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect_backend()

On 01/30/2017 02:06 PM, Eric Dumazet wrote: > On Mon, 2017-01-30 at 13:23 -0500, Boris Ostrovsky wrote: > >> We do netif_carrier_off() first thing in xennet_disconnect_backend() and >> the only place where the timer is rearmed is xennet_alloc_rx_buffers(), >> which is gua

Re: [PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect_backend()

On 01/30/2017 01:07 PM, Eric Dumazet wrote: > On Mon, 2017-01-30 at 12:45 -0500, Boris Ostrovsky wrote: >> rx_refill_timer should be deleted as soon as we disconnect from the >> backend since otherwise it is possible for the timer to go off before >> we get to

[PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect_backend()

rx_refill_timer should be deleted as soon as we disconnect from the backend since otherwise it is possible for the timer to go off before we get to xennet_destroy_queues(). If this happens we may dereference queue->rx.sring which is set to NULL in xennet_disconnect_backend(). Signed-off-by: Bo

Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

On 01/30/2017 11:47 AM, Vineeth Remanan Pillai wrote: > >> 2. It tickles a latent bug during resume where the timer triggers >> before we re-connect. The trouble is that we now try to dereference >> queue->rx.sring which is NULL since we disconnect in >> netfront_resume(). (Curiously, I only

Re: [PATCH 0/2] xen/net: limit number of tx/rx queues

On 01/10/2017 08:32 AM, Juergen Gross wrote: The Xen network frontend/backend supports multiple tx/rx queues for one virtual interface. The number of queues supported by the backend is set to the number of cpus of the backend driver domain (usually dom0) and the number of queues requested by

Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

On 01/19/2017 11:35 AM, Vineeth Remanan Pillai wrote: From: Vineeth Remanan Pillai During an OOM scenario, request slots could not be created as skb allocation fails. So the netback cannot pass in packets and netfront wrongly assumes that there is no more work to be done

Re: [PATCH 5/6] treewide: use kv[mz]alloc* rather than opencoded variants

ze * sizeof(*new_ring), GFP_KERNEL); > if (!new_ring) > return -ENOMEM; > Xen bits: Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com>

Re: [PATCH 1/2] xen/netfront: set default upper limit of tx/rx queues to 8

s many queues as there are CPUs if user has not > + /* Allow as many queues as there are CPUs inut max. 8 if user has not Based on comment change in the second patch: s/inut/but/ ? Also, comment style in both patches. Other than that, for both: Reviewed-by: Boris Ostrovsk

Re: [PATCH 2/3] xen: modify xenstore watch event interface

); > + if (count_strings(body, msg->hdr.len) != 2) { > + err = -EINVAL; xenbus_write_watch() returns -EILSEQ when this type of error is encountered so perhaps for we should return the same error here. Either way Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com>

Re: [PATCH v2 1/1] xen-netfront: update num_queues to real created

On 10/19/2015 01:37 AM, Joe Jin wrote: Sometimes xennet_create_queues() may failed to created all requested queues, we need to update num_queues to real created to avoid NULL pointer dereference. Signed-off-by: Joe Jin <joe@oracle.com> Cc: Boris Ostrovsky <boris.ostrov...@oracl

Re: [PATCH 1/1] xen-netfront: update num_queues to real created

On 10/16/2015 06:56 AM, Wei Liu wrote: CC David and Boris (Konrad was already a recipient). On Thu, Oct 15, 2015 at 10:34:15AM +0800, Joe Jin wrote: Sometimes xennet_create_queues() may failed to created all requested queues, we need to update num_queues to real created to avoid NULL pointer

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

On 08/05/2015 06:51 AM, Julien Grall wrote: diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c index 09dc447..25e3cce 100644 --- a/drivers/video/fbdev/xen-fbfront.c +++ b/drivers/video/fbdev/xen-fbfront.c @@ -539,7 +539,7 @@ static int xenfb_remove(struct

Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

On 08/05/2015 08:33 AM, Julien Grall wrote: On 05/08/15 13:19, Boris Ostrovsky wrote: On 08/05/2015 06:51 AM, Julien Grall wrote: diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c index 09dc447..25e3cce 100644 --- a/drivers/video/fbdev/xen-fbfront.c +++ b

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

On 08/04/2015 02:12 PM, Julien Grall wrote: /* * We detect special mappings in one of two ways: @@ -217,9 +232,13 @@ static inline unsigned long bfn_to_local_pfn(unsigned long mfn) /* VIRT - MACHINE conversion */ #define virt_to_machine(v)(phys_to_machine(XPADDR(__pa(v

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

On 07/29/2015 10:23 AM, Julien Grall wrote: On 29/07/15 15:14, Boris Ostrovsky wrote: static inline unsigned long pfn_to_gfn(unsigned long pfn) { if (xen_feature(XENFEAT_autotranslated_physmap)) return pfn; else return pfn_to_mfn(pfn); } But you'd still say

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

On 07/29/2015 07:25 AM, Julien Grall wrote: Hi Boris, On 28/07/15 20:12, Boris Ostrovsky wrote: On 07/28/2015 11:02 AM, Julien Grall wrote: Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

On 07/28/2015 11:02 AM, Julien Grall wrote: Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This brough some misimplementation of helpers on ARM and make the developper confused the expected behavior.

Re: [PATCHv1] xen-netfront: properly destroy queues when removing device

instances) before freeing the netdevice. Signed-off-by: David Vrabel david.vra...@citrix.com Reviewed-by: Boris Ostrovsky boris.ostrov...@oracle.com --- drivers/net/xen-netfront.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/net/xen