Re: fib_frontend: Add network specific broadcasts, when it takes a sense

2016-12-12 Thread Brandon Philips
On Mon, Dec 12, 2016 at 9:30 AM, Jiri Benc <jb...@redhat.com> wrote: > On Fri, 9 Dec 2016 15:41:52 -0800, Brandon Philips wrote: >> The issue we have: when creating the VXLAN interface and assigning it >> an address we see a broadcast route being added by the Kernel. For

fib_frontend: Add network specific broadcasts, when it takes a sense

2016-12-09 Thread Brandon Philips
Hello- A number of us are working on an OSS overlay network system called flannel. It is used in a variety of Linux container systems and one of the backends is VXLAN. The issue we have: when creating the VXLAN interface and assigning it an address we see a broadcast route being added by the

fib_frontend: Add network specific broadcasts, when it takes a sense

2016-12-09 Thread Brandon Philips
Hello- A number of us are working on an OSS overlay network system called flannel. It is used in a variety of Linux container systems and one of the backends is VXLAN. The issue we have: when creating the VXLAN interface and assigning it an address we see a broadcast route being added by the

Re: ixgbe: ksoftirqd consumes 100% CPU w/ ~50 TCP conns

2016-05-24 Thread Brandon Philips
Hello Everyone- So we tracked it down to IOMMU causing CPU affinity getting broken[1]. Can we provide any further details or is this a known issue? Thank You, Brandon [1] https://github.com/coreos/bugs/issues/1275#issuecomment-219866601 On Tue, May 17, 2016 at 12:44 PM, Brandon Philips <b

[PATCH] e1000e: Update e1000e driver to use devres

2007-08-17 Thread Brandon Philips
Conversion of e1000e probe() and remove() to devres. Depends on [patch 1/4] Update net core to use devres. Signed-off-by: Brandon Philips [EMAIL PROTECTED] --- drivers/net/e1000e/netdev.c | 70 ++-- 1 file changed, 17 insertions(+), 53 deletions

Re: [patch 2/4] Update e100 driver to use devres.

2007-08-16 Thread Brandon Philips
On 20:34 Thu 16 Aug 2007, Tejun Heo wrote: Brandon Philips wrote: @@ -2554,8 +2547,10 @@ static int __devinit e100_probe(struct p struct net_device *netdev; struct nic *nic; int err; + void __iomem **iomap; + int bar; - if(!(netdev = alloc_etherdev(sizeof

Re: [patch 4/4] Update e1000 driver to use devres.

2007-08-16 Thread Brandon Philips
On 01:38 Thu 16 Aug 2007, Waskiewicz Jr, Peter P wrote: - err = -ENOMEM; - netdev = alloc_etherdev(sizeof(struct e1000_adapter)); + netdev = devm_alloc_etherdev(pdev-dev, sizeof(struct +e1000_adapter)); if (!netdev) - goto err_alloc_etherdev; + return

[patch 0/4] Update network drivers to use devres

2007-08-15 Thread Brandon Philips
These patches update the network driver core, e100 and e1000 driver to use devres. Devres is a simple resource manager for device drivers, see Documentation/driver-model/devres.txt for more information. The use of devres will continue to be optional with this patch set and can be applied to

[patch 1/4] Update net core to use devres.

2007-08-15 Thread Brandon Philips
* netdev_pci_remove_one() can replace simple pci device remove functions * devm_alloc_netdev() is like alloc_netdev but allocates memory using devres. Signed-off-by: Brandon Philips [EMAIL PROTECTED] --- include/linux/etherdevice.h |5 ++ include/linux/netdevice.h |7 ++ net/core

[patch 2/4] Update e100 driver to use devres.

2007-08-15 Thread Brandon Philips
removed. Signed-off-by: Brandon Philips [EMAIL PROTECTED] --- drivers/net/e100.c | 78 + 1 file changed, 20 insertions(+), 58 deletions(-) Index: linux-2.6/drivers/net/e100.c

[patch 3/4] Implement devm_kcalloc

2007-08-15 Thread Brandon Philips
devm_kcalloc is a simple wrapper around devm_kzalloc for arrays. This is needed because kcalloc is often used in network devices. Signed-off-by: Brandon Philips [EMAIL PROTECTED] --- drivers/base/devres.c | 16 include/linux/device.h |2 ++ 2 files changed, 18

[patch 4/4] Update e1000 driver to use devres.

2007-08-15 Thread Brandon Philips
Conversion of e1000 probe() and remove() to devres. Signed-off-by: Brandon Philips [EMAIL PROTECTED] --- drivers/net/e1000/e1000.h |1 drivers/net/e1000/e1000_main.c | 92 - 2 files changed, 28 insertions(+), 65 deletions(-) Index: linux-2.6

Re: [patch 1/5][RFC] NET: Change pci_enable_device topci_reenable_device to keep device enable balance

2007-08-09 Thread Brandon Philips
- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Brandon Philips Sent: Thursday, August 02, 2007 3:44 PM To: netdev@vger.kernel.org Cc: [EMAIL PROTECTED]; Brandon Philips Subject: [patch 1/5][RFC] NET: Change pci_enable_device topci_reenable_device to keep device

[PATCH] NET: Change pci_enable_device to pci_reenable_device to keep device enable balance

2007-08-08 Thread Brandon Philips
I sent this last week as part of my devres patches but it is purely a bug fix and can be merged now. On a slot_reset event pci_disable_device() is never called so calling pci_enable_device() will unbalance the enable count. Signed-off-by: Brandon Philips [EMAIL PROTECTED] Acked-by: Tejun Heo

Re: [E1000-devel] [PATCH] NET: Change pci_enable_device to pci_reenable_device to keep device enable balance

2007-08-08 Thread Brandon Philips
On 10:36 Wed 08 Aug 2007, Kok, Auke wrote: Brandon Philips wrote: I sent this last week as part of my devres patches but it is purely a bug fix and can be merged now. On a slot_reset event pci_disable_device() is never called so calling pci_enable_device() will unbalance the enable count

Re: [patch 2/5][RFC] Update net core to use devres.

2007-08-03 Thread Brandon Philips
On 18:13 Fri 03 Aug 2007, Tejun Heo wrote: + p = devres_alloc(devm_free_netdev, 0, GFP_KERNEL); s/0/sizeof(*p)/ Oops! It should have read like this: +static void * register_netdev_devres(struct device *gendev, + struct net_device *dev) +{ +

Re: [patch 0/5][RFC] Update network drivers to use devres

2007-08-03 Thread Brandon Philips
On 14:44 Fri 03 Aug 2007, Stephen Hemminger wrote: On Fri, 03 Aug 2007 20:33:04 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Devres makes low level drivers simpler, easier to get right and maintain. Writing new drivers becomes easier too. So, why not? Network devices seem to work fine

[patch 5/5][RFC] Update e1000 driver to use devres.

2007-08-02 Thread Brandon Philips
Conversion of e1000 probe() and remove() to devres. Signed-off-by: Brandon Philips [EMAIL PROTECTED] --- drivers/net/e1000/e1000.h |1 drivers/net/e1000/e1000_main.c | 79 - 2 files changed, 26 insertions(+), 54 deletions(-) Index: linux-2.6

[patch 2/5][RFC] Update net core to use devres.

2007-08-02 Thread Brandon Philips
* netdev_pci_remove_one() can replace simple pci device remove functions * devm_alloc_netdev() is like alloc_netdev but allocates memory using devres. Signed-off-by: Brandon Philips [EMAIL PROTECTED] --- include/linux/etherdevice.h |5 ++ include/linux/netdevice.h |7 ++ net/core

[patch 0/5][RFC] Update network drivers to use devres

2007-08-02 Thread Brandon Philips
This patch set adds support for devres in the net core and converts the e100 and e1000 drivers to devres. Devres is a simple resource manager for device drivers, see Documentation/driver-model/devres.txt for more information. The use of devres will remain optional for drivers with this patch

[patch 1/5][RFC] NET: Change pci_enable_device to pci_reenable_device to keep device enable balance

2007-08-02 Thread Brandon Philips
On a slot_reset event pci_disable_device() is never called so calling pci_enable_device() will unbalance the enable count. Signed-off-by: Brandon Philips [EMAIL PROTECTED] --- drivers/net/e100.c |2 +- drivers/net/e1000/e1000_main.c |2 +- drivers/net/ixgb/ixgb_main.c

[patch 3/5][RFC] Update e100 driver to use devres.

2007-08-02 Thread Brandon Philips
, e100_remove() has been deleted and replaced with a much simpler netdev_pci_remove_one() function that can handle PCI net devices that don't require teardown besides resource deallocation. Signed-off-by: Brandon Philips [EMAIL PROTECTED] --- drivers/net/e100.c | 70

[patch 4/5][RFC] Implement devm_kcalloc

2007-08-02 Thread Brandon Philips
devm_kcalloc is a simple wrapper around devm_kzalloc for arrays. This is needed because kcalloc is often used in network devices. Signed-off-by: Brandon Philips [EMAIL PROTECTED] --- drivers/base/devres.c | 16 include/linux/device.h |1 + 2 files changed, 17

Re: [PATCH 1/2][RFC] Update net core to use devres.

2007-07-24 Thread Brandon Philips
On 00:09 Wed 25 Jul 2007, Al Viro wrote: On Tue, Jul 24, 2007 at 11:51:34PM +0100, Al Viro wrote: On Tue, Jul 24, 2007 at 03:39:52PM -0700, [EMAIL PROTECTED] wrote: * netdev_pci_remove_one() can replace simple pci device remove functions * devm_alloc_netdev() is like alloc_netdev

[PATCH] TCP YeAH selects TCP Vegas with Kconfig

2007-05-17 Thread Brandon Philips
I tried building TCP YeAH into my kernel with TCP Vegas as a module and the build failed because TCP YeAH depends on Vegas. This patch makes Kconfig aware of the YeAH dependency on Vegas. --- net/ipv4/Kconfig |1 + 1 file changed, 1 insertion(+) Index: linux-2.6/net/ipv4/Kconfig