Re: [PATCH 1/2] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

2016-02-03 Thread ByeoungWook Kim
Hi David, 2016-02-03 23:41 GMT+09:00 David Laight : > From: Byeoungwook Kim >> Sent: 03 February 2016 02:00 >> Conditional codes in rtl_addr_delay() were improved in readability and >> performance by using switch codes. >> ... >> void rtl_addr_delay(u32 addr

Re: [PATCH v3] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

2016-02-03 Thread ByeoungWook Kim
herjee : > On Wed, Feb 03, 2016 at 02:21:46PM +0900, Byeoungwook Kim wrote: >> Conditional codes in rtl_addr_delay() were improved in readability and >> performance by using switch codes. >> >> Reviewed-by: Julian Calaby >> Signed-off-by: Byeoungwook Kim >>

[PATCH v3] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

2016-02-02 Thread Byeoungwook Kim
Conditional codes in rtl_addr_delay() were improved in readability and performance by using switch codes. Reviewed-by: Julian Calaby Signed-off-by: Byeoungwook Kim Signed-off-by: Fengguang Wu --- V3 remove unneeded semicolon. V2 split in separate patchs. drivers/net/wireless/realtek/rtlwifi

Re: [PATCH 2/2] rtlwifi: Fix reusable codes in core.c

2016-02-02 Thread ByeoungWook Kim
Hi Julian, I sent to modify the patch again. Thanks for your assists! Regards, Byeoungwook 2016-02-03 11:06 GMT+09:00 Julian Calaby : > Hi Byeoungwook, > > On Wed, Feb 3, 2016 at 1:01 PM, Byeoungwook Kim wrote: >> rtl_*_delay() functions were reused same codes about addr variabl

[PATCH v2 2/2] rtlwifi: Fix reusable codes in core.c

2016-02-02 Thread Byeoungwook Kim
rtl_*_delay() functions were reused same codes about addr variable. So i have converted to rtl_addr_delay() from code about addr variable. Signed-off-by: Byeoungwook Kim Reviewed-by: Julian Calaby --- V2 split in separate patchs. drivers/net/wireless/realtek/rtlwifi/core.c | 28

[PATCH v2 1/2] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

2016-02-02 Thread Byeoungwook Kim
Conditional codes in rtl_addr_delay() were improved in readability and performance by using switch codes. Signed-off-by: Byeoungwook Kim Reviewed-by: Julian Calaby --- V2 split in separate patchs. drivers/net/wireless/realtek/rtlwifi/core.c | 20 ++-- 1 file changed, 14

[PATCH 2/2] rtlwifi: Fix reusable codes in core.c

2016-02-02 Thread Byeoungwook Kim
rtl_*_delay() functions were reused same codes about addr variable. So i have converted to rtl_addr_delay() from code about addr variable. Signed-off-by: Byeoungwook Kim Reviewed-by: Julian Calaby --- drivers/net/wireless/realtek/rtlwifi/core.c | 28 1 file changed

[PATCH 1/2] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

2016-02-02 Thread Byeoungwook Kim
Conditional codes in rtl_addr_delay() were improved in readability and performance by using switch codes. Signed-off-by: Byeoungwook Kim Reported-by: Julian Calaby --- drivers/net/wireless/realtek/rtlwifi/core.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff

[PATCH] rtlwifi: Fix reusable codes in core.c

2016-02-02 Thread Byeoungwook Kim
rtl_*_delay() functions were reused same codes about addr variable. So i have converted to rtl_addr_delay() from code about addr variable. Conditional codes in rtl_addr_delay() were improved in readability and performance by using switch codes. Signed-off-by: Byeoungwook Kim --- drivers/net