[PATCH] bnxt_en: Fix sources of spurious netpoll warnings

we increment rx_pkts on -ENOMEM and -EIO, resulting in rx_pkts > 0. Fix this by only bumping rx_pkts if we were actually given a non-zero budget. Signed-off-by: Calvin Owens <calvinow...@fb.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH net-next] nfnetlink_log: Use GFP_NOWARN for skb allocation

Since the code explicilty falls back to a smaller allocation when the large one fails, we shouldn't complain when that happens. Signed-off-by: Calvin Owens <calvinow...@fb.com> --- net/netfilter/nfnetlink_log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/net

[PATCH v2 net-next] mlx5: Add ndo_poll_controller() implementation

This implements ndo_poll_controller in net_device_ops callbacks for mlx5, which is necessary to use netconsole with this driver. Acked-By: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Calvin Owens <calvinow...@fb.com> --- Changes in v2: * Only iterate channels to avo

[PATCH v2] mlx5: Add ndo_poll_controller() implementation

This implements ndo_poll_controller in net_device_ops callback for mlx5, which is necessary to use netconsole with this driver. Cc: Saeed Mahameed <sae...@dev.mellanox.co.il> Signed-off-by: Calvin Owens <calvinow...@fb.com> --- Changes in v2: * Only iterate channels to avo

[PATCH] mlx5: Add ndo_poll_controller() implementation

This implements ndo_poll_controller in net_device_ops for mlx5, which is necessary to use netconsole with this driver. Signed-off-by: Calvin Owens <calvinow...@fb.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 20 1 file changed, 20 insertions(+) diff

Re: [PATCH] netconsole: Initialize after all core networking drivers

On Thursday 12/17 at 17:46 -0800, Calvin Owens wrote: > On Thursday 12/17 at 17:08 -0800, Eric Dumazet wrote: > > On Thu, 2015-12-17 at 15:52 -0800, Calvin Owens wrote: > > > With built-in netconsole and IXGBE, configuring netconsole via the kernel > > > cmdline res

[PATCH] netconsole: Initialize after all core networking drivers

+0x3f/0x70 [] ? rest_init+0x80/0x80 This happens because IXGBE assumes that vxlan has already been initialized. The cleanest way to fix this is to just initialize netconsole after all the other core networking stuff has completed. Signed-off-by: Calvin Owens <calvinow...@fb.com> --- drive

Re: [PATCH] netconsole: Initialize after all core networking drivers

On Thursday 12/17 at 17:08 -0800, Eric Dumazet wrote: > On Thu, 2015-12-17 at 15:52 -0800, Calvin Owens wrote: > > With built-in netconsole and IXGBE, configuring netconsole via the kernel > > cmdline results in the following panic at boot: > > > > netpoll: netcons

Re: [PATCH] netconsole: Initialize after all core networking drivers

On Thursday 12/17 at 17:10 -0800, Stephen Hemminger wrote: > On Thu, 17 Dec 2015 15:52:39 -0800 > Calvin Owens <calvinow...@fb.com> wrote: > > > With built-in netconsole and IXGBE, configuring netconsole via the kernel > > cmdline results in the following panic at

[PATCH] Revert net: limit tcp/udp rmem/wmem to SOCK_{RCV,SND}BUF_MIN

...@gmail.com Cc: Sorin Dumitru so...@returnze.ro Signed-off-by: Calvin Owens calvinow...@fb.com --- net/ipv4/sysctl_net_ipv4.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c index 433231c..0330ab2 100644 --- a/net/ipv4

Re: [PATCH] net: Use SK_MEM_QUANTUM as minimum for tcp/udp rmem/wmem

On Wednesday 08/12 at 10:46 -0700, Eric Dumazet wrote: On Wed, 2015-08-12 at 20:00 +0300, Sorin Dumitru wrote: Would clamping the values to a min value, like setsockopt(SO_SNDBUF) does, be an option? I still find it odd that SO_SNDBUF limits you, while the /proc interface doesn't. If

[PATCH] net: Use SK_MEM_QUANTUM as minimum for tcp/udp rmem/wmem

anybody's sysctl configurations. Fixes: 8133534c760d4083 (net: limit tcp/udp rmem/wmem to SOCK_MIN...) Signed-off-by: Calvin Owens calvinow...@fb.com --- net/ipv4/sysctl_net_ipv4.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4

Re: [PATCH] net: Unbreak resetting default values for tcp_wmem/udp_wmem_min

On Sunday 08/09 at 22:41 -0700, David Miller wrote: From: Calvin Owens calvinow...@fb.com Date: Wed, 5 Aug 2015 13:26:54 -0700 Commit 8133534c760d4083 (net: limit tcp/udp rmem/wmem to SOCK_{RCV,SND}BUF_MIN) modified four sysctls to enforce that the values written to them are not less

[PATCH] net: Unbreak resetting default values for tcp_wmem/udp_wmem_min

...) Signed-off-by: Calvin Owens calvinow...@fb.com --- net/ipv4/sysctl_net_ipv4.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c index 433231c..a214b6a 100644 --- a/net/ipv4/sysctl_net_ipv4.c +++ b/net/ipv4