Re: [PATCH iproute2 v2] bridge: add batch command support

2015-10-12 Thread Christophe Gouault
2015-10-11 23:03 GMT+02:00 Roopa Prabhu : > From: Wilson Kok > > This patch adds support to batch bridge commands. > Follows ip batch code. > > Signed-off-by: Wilson Kok > Signed-off-by: Roopa Prabhu > Acked-by: Christophe Gouault > --- > v2 - change tab to sp

[PATCH iproute2] batch: support quoted strings

2015-10-02 Thread Christophe Gouault
state add src 5.5.5.5 dst 2.2.2.2 proto esp spi 0x2 \ mode tunnel enc cipher_null "" Signed-off-by: Christophe Gouault --- lib/utils.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/lib/utils.c b/lib/utils.c index 29b4f548acf3..107e3f57

Re: [PATCH iproute2] bridge: add batch command support

2015-10-08 Thread Christophe Gouault
ge: bridge [ OPTIONS ] OBJECT { COMMAND | help }\n" " bridge [ -force ] -batch filename\n" ^^^ Except for this detail, Acked-by: Christophe Gouault -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to m

Re: INFO: rcu detected stall in xfrm_hash_rebuild

2018-12-14 Thread Christophe Gouault
Le ven. 14 déc. 2018 à 15:35, Florian Westphal a écrit : > Ok. An alternative would be to remove the support for > policy hash table thresholds (which decide what kinds of policies > go to exact table and which ones go into inexact ones), i.e. > partially revert 880a6fab8f6ba5b5abe59ea6 > ("xfrm:

Re: INFO: rcu detected stall in xfrm_hash_rebuild

2018-12-14 Thread Christophe Gouault
Le ven. 14 déc. 2018 à 17:23, Florian Westphal a écrit : > I won't send a patch to remove your work, at least not at this time. > > In case I'd do this removal (thresholds, hash table, or both) > i will make these tests to see how large the impact is. Perfect, thanks Christophe

Re: [PATCH net-next] xfrm: no-anti-replay protection flag

2020-05-27 Thread Christophe Gouault
Hi Petr, This patch is useful, however I think you should change the name of the option and amend its description: the option does not disable anti-replay in output (it can only be disabled in input), it allows the output sequence number to wrap, and it assumes that the remote peer disabled anti-r

Re: [PATCH net-next v2] xfrm: introduce oseq-may-wrap flag

2020-06-02 Thread Christophe Gouault
gt; if anti-replay is disabled (see note in 3.3.3 section). > (...) Hi Petr, Thank you for taking my comment into account. This new patch looks good to me. Acked-by: Christophe Gouault Regards, Christophe