[PATCH] net: macb: fix the restore of cmp registers

type 2 screeners or not. Fixes: a14d273ba159 ("net: macb: restore cmp registers on resume path") Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/driv

[PATCH 1/1] net: macb: restore cmp registers on resume path

Restore CMP screener registers on resume path. Fixes: c1e85c6ce57ef ("net: macb: save/restore the remaining registers and features") Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/ne

[PATCH] net: phy: micrel: reconfigure the phy on resume

these needs to be restored thus call driver's config_init() on resume. Signed-off-by: Claudiu Beznea --- drivers/net/phy/micrel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 3fe552675dd2..52d3a0480158 100644

[PATCH v3 0/8] net: macb: add support for sama7g5

Hi, This series adds support for SAMA7G5 Ethernet interfaces: one 10/100Mbps and one 1Gbps interfaces. Along with it I also included a fix to disable clocks for SiFive FU540-C000 on failure path of fu540_c000_clk_init(). Thank you, Claudiu Beznea Changed in v3: - use clk_bulk_disable_unprepare

[PATCH v3 1/8] net: macb: add userio bits as platform configuration

This is necessary for SAMA7G5 as it uses different values for PHY interface and also introduces hdfctlen bit. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb.h | 10 ++ drivers/net/ethernet/cadence/macb_main.c | 28

[PATCH v3 6/8] dt-bindings: add documentation for sama7g5 gigabit ethernet interface

Add documentation for SAMA7G5 gigabit ethernet interface. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree

[PATCH v3 4/8] net: macb: unprepare clocks in case of failure

Unprepare clocks in case of any failure in fu540_c000_clk_init(). Fixes: c218ad559020 ("macb: Add support for SiFive FU540-C000") Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletion

[PATCH v3 7/8] net: macb: add support for sama7g5 gem interface

Add support for SAMA7G5 gigabit ethernet interface. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb_main.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet

[PATCH v3 3/8] net: macb: add function to disable all macb clocks

Add function to disable all macb clocks. Signed-off-by: Claudiu Beznea Suggested-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb_main.c | 38 ++-- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b

[PATCH v3 8/8] net: macb: add support for sama7g5 emac interface

Add support for SAMA7G5 10/100Mbps interface. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb_main.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c

[PATCH v3 2/8] net: macb: add capability to not set the clock rate

this capability (the clock rate, in case of generic clock, is set at the boot time via device tree and the driver only enables it). Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb.h | 1 + drivers/net/ethernet/cadence/macb_main.c

[PATCH v3 5/8] dt-bindings: add documentation for sama7g5 ethernet interface

Add documentation for SAMA7G5 ethernet interface. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings

[PATCH v2 4/8] net: macb: unprepare clocks in case of failure

Unprepare clocks in case of any failure in fu540_c000_clk_init(). Fixes: c218ad559020 ("macb: Add support for SiFive FU540-C000") Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletion

[PATCH v2 1/8] net: macb: add userio bits as platform configuration

This is necessary for SAMA7G5 as it uses different values for PHY interface and also introduces hdfctlen bit. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb.h | 10 ++ drivers/net/ethernet/cadence/macb_main.c | 28

[PATCH v2 5/8] dt-bindings: add documentation for sama7g5 ethernet interface

Add documentation for SAMA7G5 ethernet interface. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings

[PATCH v2 7/8] net: macb: add support for sama7g5 gem interface

Add support for SAMA7G5 gigabit ethernet interface. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb_main.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet

[PATCH v2 3/8] net: macb: add function to disable all macb clocks

Add function to disable all macb clocks. Signed-off-by: Claudiu Beznea Suggested-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb_main.c | 62 1 file changed, 32 insertions(+), 30 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b

[PATCH v2 2/8] net: macb: add capability to not set the clock rate

this capability (the clock rate, in case of generic clock, is set at the boot time via device tree and the driver only enables it). Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb.h | 1 + drivers/net/ethernet/cadence/macb_main.c

[PATCH v2 0/8] net: macb: add support for sama7g5

Hi, This series adds support for SAMA7G5 Ethernet interfaces: one 10/100Mbps and one 1Gbps interfaces. Along with it I also included a fix to disable clocks for SiFive FU540-C000 on failure path of fu540_c000_clk_init(). Thank you, Claudiu Beznea Changes in v2: - introduced patch "net:

[PATCH v2 8/8] net: macb: add support for sama7g5 emac interface

Add support for SAMA7G5 10/100Mbps interface. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb_main.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c

[PATCH v2 6/8] dt-bindings: add documentation for sama7g5 gigabit ethernet interface

Add documentation for SAMA7G5 gigabit ethernet interface. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree

[PATCH 7/7] net: macb: add support for sama7g5 emac interface

Add support for SAMA7G5 10/100Mbps interface. Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 22340e55d4b7

[PATCH 2/7] net: macb: add capability to not set the clock rate

this capability (the clock rate, in case of generic clock, is set at the boot time via device tree and the driver only enables it). Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb.h | 1 + drivers/net/ethernet/cadence/macb_main.c | 18 +- 2 files change

[PATCH 6/7] net: macb: add support for sama7g5 gem interface

Add support for SAMA7G5 gigabit ethernet interface. Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index

[PATCH 3/7] net: macb: unprepare clocks in case of failure

Unprepare clocks in case of any failure in fu540_c000_clk_init(). Fixes: c218ad559020 ("macb: Add support for SiFive FU540-C000") Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletion

[PATCH 1/7] net: macb: add userio bits as platform configuration

This is necessary for SAMA7G5 as it uses different values for PHY interface and also introduces hdfctlen bit. Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb.h | 10 ++ drivers/net/ethernet/cadence/macb_main.c | 28 2 files changed

[PATCH 4/7] dt-bindings: add documentation for sama7g5 ethernet interface

Add documentation for SAMA7G5 ethernet interface. Signed-off-by: Claudiu Beznea --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt index

[PATCH 5/7] dt-bindings: add documentation for sama7g5 gigabit ethernet interface

Add documentation for SAMA7G5 gigabit ethernet interface. Signed-off-by: Claudiu Beznea --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt index

[PATCH 0/7] net: macb: add support for sama7g5

Hi, This series adds support for SAMA7G5 Ethernet interfaces: one 10/100Mbps and one 1Gbps interfaces. Along with it I also included a fix to disable clocks for SiFive FU540-C000 on failure path of fu540_c000_clk_init(). Thank you, Claudiu Beznea Claudiu Beznea (7): net: macb: add userio

[PATCH net-next v2 4/4] net: macb: remove is_udp variable

Remove is_udp variable that is used in only one place and use ip_hdr(skb)->protocol == IPPROTO_UDP check instead. Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cade

[PATCH net-next v2 3/4] net: macb: do not initialize queue variable

Do not initialize queue variable. It is already initialized in for loops. Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence

[PATCH net-next v2 2/4] net: macb: use hweight32() to count set bits in queue_mask

Use hweight32() to count set bits in queue_mask. Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index

[PATCH net-next v2 1/4] net: macb: do not set again bit 0 of queue_mask

Bit 0 of queue_mask is set at the beginning of macb_probe_queues() function. Do not set it again after reading DGFG6 but instead use "|=" operator. Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) di

[PATCH net-next v2 0/4] net: macb: few code cleanups

Hi, Patches in this series cleanup a bit macb code. Thank you, Claudiu Beznea Changes in v2: - in patch 2/4 use hweight32() instead of hweight_long() Claudiu Beznea (4): net: macb: do not set again bit 0 of queue_mask net: macb: use hweight32() to count set bits in queue_mask net: macb

[PATCH net-next 4/4] net: macb: remove is_udp variable

Remove is_udp variable that is used in only one place and use ip_hdr(skb)->protocol == IPPROTO_UDP check instead. Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cade

[PATCH net-next 1/4] net: macb: do not set again bit 0 of queue_mask

Bit 0 of queue_mask is set at the beginning of macb_probe_queues() function. Do not set it again after reading DGFG6 but instead use "|=" operator. Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) di

[PATCH net-next 3/4] net: macb: do not initialize queue variable

Do not initialize queue variable. It is already initialized in for loops. Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence

[PATCH net-next 2/4] net: macb: use hweight_long() to count set bits in queue_mask

Use hweight_long() to count set bits in queue_mask. Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index

[PATCH net-next 0/4] net: macb: few code cleanups

Hi, Patches in this series cleanup a bit macb code. Thank you, Claudiu Beznea Claudiu Beznea (4): net: macb: do not set again bit 0 of queue_mask net: macb: use hweight_long() to count set bits in queue_mask net: macb: do not initialize queue variable net: macb: remove is_udp variable

[PATCH] of: of_mdio: count number of regitered phys

registered to avoid the above scenario. Signed-off-by: Claudiu Beznea --- Though I haven't encountered the scenario described in commit message. Just went through this code and seemed to me that it could be enhanved by checking the number of successfuly registered devices. Thank you, Claudiu B

[PATCH v2 1/2] net: macb: call pm_runtime_put_sync on failure path

Call pm_runtime_put_sync() on failure path of at91ether_open. Fixes: e6a41c23df0d ("net: macb: ensure interface is not suspended on at91rm9200") Signed-off-by: Claudiu Beznea --- Changes in v2: - this patch is new in v2 - patch 2/2 in this series is based on this one drivers/ne

[PATCH v2 2/2] net: macb: free resources on failure path of at91ether_open()

: 7897b071ac3b ("net: macb: convert to phylink") Signed-off-by: Claudiu Beznea --- Changes in v2: - none drivers/net/ethernet/cadence/macb_main.c | 116 +++ 1 file changed, 73 insertions(+), 43 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c

[PATCH] net: macb: free resources on failure path of at91ether_open()

: 7897b071ac3b ("net: macb: convert to phylink") Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 116 +++ 1 file changed, 73 insertions(+), 43 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethern

[PATCH v2] net: macb: undo operations in case of failure

Undo previously done operation in case macb_phylink_connect() fails. Since macb_reset_hw() is the 1st undo operation the napi_exit label was renamed to reset_hw. Fixes: 7897b071ac3b ("net: macb: convert to phylink") Signed-off-by: Claudiu Beznea --- Changes in v2: - corrected

[PATCH] net: macb: undo operations in case of failure

Undo previously done operation in case macb_phylink_connect() fails. Since macb_reset_hw() is the 1st undo operation the napi_exit label was renamed to reset_hw. Fixes: b2b041417299 ("net: macb: convert to phylink") Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_

Re: [PATCH v2] net: macb: do not disable MDIO bus at open/close time

t; Signed-off-by: Anssi Hannula > --- Here: v2: Make macb_init_hw() NCR write a single statement. Other than this: Reviewed-by: Claudiu Beznea Checked that link goes up and ping is working on a SAMA5D2 Xplained: Tested-by: Claudiu Beznea > drivers/net/ethernet/cadence/macb_main.c

Re: [PATCH] net: macb: do not disable MDIO bus at open/close time

d again. > > Fix that by only touching the RE and TE bits when enabling and disabling > RX/TX. > > Fixes: 6c36a7074436 ("macb: Use generic PHY layer") > Signed-off-by: Anssi Hannula > --- > > Claudiu Beznea wrote: >> On 10.08.2018 09:22, Anssi Hannula wr

Re: [PATCH] net: macb: do not disable MDIO bus when closing interface

t. So, if you clear only TE and RE bits in macb_reset_hw() please also remove MACB_BIT(MPE) from below line at the end of macb_init_hw(): macb_writel(bp, NCR, MACB_BIT(RE) | MACB_BIT(TE) | MACB_BIT(MPE)); Thank you, Claudiu Beznea >

Re: [PATCH] net: macb: do not disable MDIO bus when closing interface

PE)); Would be better to read the NCR and clear only RX and TX bits, something like: val = macb_readl(bp, NCR); /* Disable TX and RX. */ val &= ~(MACB_BIT(TE) | MACB_BIT(RE)); /* Clear statistics */ val |= MACB_BIT(CLRSTAT); macb_writel(bp, NCR

Re: [RFC PATCH 0/2] net: macb: Disable TX checksum offloading on all Zynq

Hi Harini, On 01.08.2018 15:53, Harini Katakam wrote: > Hi Jennifer, > > On Tue, Jun 5, 2018 at 10:21 AM, Harini Katakam wrote: >> Hi Jeniffer, >> >> On Mon, Jun 4, 2018 at 8:35 PM, Nicolas Ferre >> wrote: >>> Jennifer, >>> >>> On 25/05/2018 at 23:44, Jennifer Dahm wrote: During testi

Re: [RFC PATCH 3/3] net: macb: add support for padding and fcs computation

On 18.07.2018 20:54, David Miller wrote: > From: Claudiu Beznea > Date: Wed, 18 Jul 2018 15:58:09 +0300 > >> >> +static int macb_pad_and_fcs(struct sk_buff **skb, struct net_device *ndev) >> +{ >> +struct sk_buff *nskb; >> +int padlen = ETH_Z

[RFC PATCH 0/3] net: macb: add pad and fcs support

y done [1] https://www.spinics.net/lists/netdev/msg505065.html [2] https://github.com/netoptimizer/network-testing/blob/master/pktgen/pktgen_sample01_simple.sh Claudiu Beznea (3): net: macb: use netdev_tx_t return type for ndo_start_xmit functions net: macb: move checksum clearing outside of spi

[RFC PATCH 2/3] net: macb: move checksum clearing outside of spinlock

Move checksum clearing outside of spinlock. The SKB is protected by networking lock (HARD_TX_LOCK()). Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/cadence

[RFC PATCH 1/3] net: macb: use netdev_tx_t return type for ndo_start_xmit functions

Use netdev_tx_t return type for ndo_start_xmit function of macb driver. Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence

[RFC PATCH 3/3] net: macb: add support for padding and fcs computation

For packets with computed IP/TCP/UDP checksum there is no need to tell hardware to recompute it. For such kind of packets hardware expects the packet to be at least 64 bytes and FCS to be computed. Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 70

Re: [RFC PATCH 5/5] net: macb: Add WOL support with ARP

Hi Harini, On 10.05.2018 13:37, Harini Katakam wrote: > Hi Claudiu, > > On Fri, May 4, 2018 at 5:47 PM, Claudiu Beznea > wrote: >> >> >> On 22.03.2018 15:51, harinikatakamli...@gmail.com wrote: >>> From: Harini Katakam >>> >>> Thi

Re: [RFC PATCH 5/5] net: macb: Add WOL support with ARP

On 22.03.2018 15:51, harinikatakamli...@gmail.com wrote: > From: Harini Katakam > > This patch enables ARP wake event support in GEM through the following: > > -> WOL capability can be selected based on the SoC/GEM IP version rather > than a devictree property alone. Hence add a new capability

Re: [RFC PATCH 3/5] net: macb: Add pm runtime support

On 03.05.2018 14:13, Harini Katakam wrote: > Hi Claudiu, > > On Thu, May 3, 2018 at 3:39 PM, Claudiu Beznea > wrote: >> >> >> On 22.03.2018 15:51, harinikatakamli...@gmail.com wrote: >>> From: Harini Katakam > >> I would use a "goto"

Re: [RFC PATCH 4/5] net: macb: Add support for suspend/resume with full power down

On 03.05.2018 14:20, Harini Katakam wrote: > Hi Claudiu, > > On Thu, May 3, 2018 at 3:39 PM, Claudiu Beznea > wrote: >> >> >> On 22.03.2018 15:51, harinikatakamli...@gmail.com wrote: >>> From: Harini Katakam >>> >>> When macb device is

Re: [RFC PATCH 3/5] net: macb: Add pm runtime support

On 22.03.2018 15:51, harinikatakamli...@gmail.com wrote: > From: Harini Katakam > > Add runtime pm functions and move clock handling there. > Enable clocks in mdio read/write functions. > > Signed-off-by: Shubhrajyoti Datta > Signed-off-by: Harini Katakam > --- > drivers/net/ethernet/cadenc

Re: [RFC PATCH 4/5] net: macb: Add support for suspend/resume with full power down

On 22.03.2018 15:51, harinikatakamli...@gmail.com wrote: > From: Harini Katakam > > When macb device is suspended and system is powered down, the clocks > are removed and hence macb should be closed gracefully and restored > upon resume. Is this a power saving mode which shut down the core?

Re: [RFC PATCH 1/5] net: macb: Check MDIO state before read/write and use timeouts

On 22.03.2018 15:51, harinikatakamli...@gmail.com wrote: > From: Harini Katakam > > Replace the while loop in MDIO read/write functions with a timeout. > In addition, add a check for MDIO bus busy before initiating a new > operation as well to make sure there is no ongoing MDIO operation. > >