Re: [PATCH] aquantia: Fix "ethtool -S" crash when adapter down.

2017-05-04 Thread David Arcari
aq_nic_s *self) > goto err_exit; > > for (i = AQ_DIMOF(self->aq_vec); i--;) { > - if (self->aq_vec[i]) > + if (self->aq_vec[i]) { > aq_vec_free(self->aq_vec[i]); > + self->aq_vec[i] = NULL; > + } > } > > err_exit:; > Resolves the ethtool crash. Tested-by: David Arcari <darc...@redhat.com>

Re: [PATCH] aquantia: Fix "ethtool -S" crash when adapter down.

2017-05-04 Thread David Arcari
On 05/04/2017 01:09 PM, Pavel Belous wrote: > > > On 04.05.2017 19:51, David Miller wrote: >> From: Lino Sanfilippo >> Date: Thu, 4 May 2017 18:48:12 +0200 >> >>> Hi Pavel, >>> >>> On 04.05.2017 18:33, Pavel Belous wrote: From: Pavel Belous

Re: [PATCH] aquantia: Fix "ethtool -S" crash when adapter down.

2017-05-04 Thread David Arcari
Hi Pavel, On 05/04/2017 12:33 PM, Pavel Belous wrote: > From: Pavel Belous > > This patch fixes the crash that happens when driver tries to collect > statistics > from already released "aq_vec" object. > > Fixes: 97bde5c4f909 ("net: ethernet: aquantia: Support for

Re: [PATCH v3 net 2/5] net:ethernet:aquantia: Fix packet type detection (TCP/UDP) for IPv6.

2017-03-23 Thread David Arcari
(ipv6_hdr(skb)->nexthdr == NEXTHDR_UDP) ? > + 1U : 0U; > + } > } > > for (; nr_frags--; ++frag_count) { > Fixes tcp/ipv6 Tested-by: David Arcari <darc...@redhat.com>

Re: [PATCH net 4/5] net:ethernet:aquantia: Fix for LSO with IPv6.

2017-03-22 Thread David Arcari
Hi, On 03/22/2017 01:06 PM, Pavel Belous wrote: > From: Pavel Belous > > Fix Context Command bit: L3 type = "0" for IPv4, "1" for IPv6. > > Signed-off-by: Pavel Belous > --- > drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 3

[PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-13 Thread David Arcari
ere the driver has a ndo_change_mtu routine. Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu") Cc: Pavel Belous <pavel.bel...@aquantia.com> Signed-off-by: David Arcari <darc...@redhat.com> --- drivers/net/ethernet/aquantia/atlantic/aq_main.c

Re: [PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-13 Thread David Arcari
On 03/13/2017 03:56 PM, David Miller wrote: > From: David Arcari <darc...@redhat.com> > Date: Mon, 13 Mar 2017 11:50:50 -0400 > >> On 03/13/2017 02:09 AM, David Miller wrote: >>> From: David Arcari <darc...@redhat.com> >>> Date: Wed, 8 Mar 2017 16:

Re: [PATCH v2] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-13 Thread David Arcari
On 03/10/2017 04:19 PM, Pavel Belous wrote: > > > On 10.03.2017 17:47, David Arcari wrote: >> Hi, >> >> On 03/09/2017 05:43 PM, Lino Sanfilippo wrote: >>> Hi, >>> >>> On 09.03.2017 22:03, David Arcari wrote: >>>>

Re: [PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-13 Thread David Arcari
On 03/13/2017 02:09 AM, David Miller wrote: > From: David Arcari <darc...@redhat.com> > Date: Wed, 8 Mar 2017 16:33:21 -0500 > >> When the aquantia device mtu is changed the net_device structure is not >> updated. As a result the ip command does not properly

Re: [PATCH v2] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-10 Thread David Arcari
Hi, On 03/09/2017 05:43 PM, Lino Sanfilippo wrote: > Hi, > > On 09.03.2017 22:03, David Arcari wrote: >> When the aquantia device mtu is changed the net_device structure is not >> updated. As a result the ip command does not properly reflect the mtu >> change

[PATCH v2] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-09 Thread David Arcari
ere the driver has a ndo_change_mtu routine. Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu") v2: no longer close/open net-device after mtu change Cc: Pavel Belous <pavel.bel...@aquantia.com> Signed-off-by: David Arcari <darc...@redhat.com>

Re: [PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-09 Thread David Arcari
On 03/09/2017 03:01 PM, David Arcari wrote: > On 03/09/2017 02:02 PM, Pavel Belous wrote: >> >> >> On 09.03.2017 00:33, David Arcari wrote: >>> When the aquantia device mtu is changed the net_device structure is not >>> updated. As a result the ip co

Re: [PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-09 Thread David Arcari
On 03/09/2017 02:02 PM, Pavel Belous wrote: > > > On 09.03.2017 00:33, David Arcari wrote: >> When the aquantia device mtu is changed the net_device structure is not >> updated. As a result the ip command does not properly reflect the mtu >> change. >> &

[PATCH] net: ethernet: aquantia: call set_irq_affinity_hint before free_irq

2017-03-09 Thread David Arcari
__dev_close+0x67/0xb0 Fixes: 36a4a50f4048 ("net: ethernet: aquantia: switch to pci_alloc_irq_vectors") Cc: Christoph Hellwig <h...@lst.de> Cc: Pavel Belous <pavel.bel...@aquantia.com> Signed-off-by: David Arcari <darc...@redhat.com> --- drivers/net/ethernet/aquantia/atlantic/

[PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-08 Thread David Arcari
ere the driver has a ndo_change_mtu routine. Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu") Cc: Pavel Belous <pavel.bel...@aquantia.com> Signed-off-by: David Arcari <darc...@redhat.com> --- drivers/net/ethernet/aquantia/atlantic/aq_main.c

Re: [PATCH] net: ethtool: avoid allocation failure for dump_regs

2017-01-19 Thread David Arcari
On 01/18/2017 11:45 AM, David Miller wrote: > From: David Arcari <darc...@redhat.com> > Date: Wed, 18 Jan 2017 08:34:05 -0500 > >> If the user executes 'ethtool -d' for an interface and the associated >> get_regs_len() function returns 0, the user will see a call trace

[PATCH] net: ethtool: avoid allocation failure for dump_regs

2017-01-18 Thread David Arcari
If the user executes 'ethtool -d' for an interface and the associated get_regs_len() function returns 0, the user will see a call trace from the vmalloc() call in ethtool_get_regs(). This patch modifies ethtool_get_regs() to avoid the call to vmalloc when the size is zero. Signed-off-by: David