Re: [PATCH net-next] r8169: add missing Kconfig dependency

2018-08-17 Thread David Miller
From: Florian Fainelli Date: Fri, 17 Aug 2018 11:45:57 -0700 > On 08/17/2018 11:42 AM, Heiner Kallweit wrote: >> Now that we switched the r8169 driver to use phylib, there's a >> dependency on the Realtek PHY drivers. This dependency was missing >> in Kconfig. >> >> Reported-by: Jouni Mettälä

Re: [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts

2018-08-17 Thread David Miller
From: Al Viro Date: Fri, 17 Aug 2018 16:43:20 +0100 > Umm... I thought net-next had been closed until -rc1, hadn't > it? That's correct.

Re: [PATCH net-next] net: dsa: mv88e6xxx: Share main switch IRQ

2018-08-17 Thread David Miller
From: Marek Behún Date: Fri, 17 Aug 2018 12:09:49 +0200 > On some boards the interrupt can be shared between multiple devices. > For example on Turris Mox the interrupt is shared between all switches. > > Signed-off-by: Marek Behun The net-next tree is closed, please resubmit when it opens

Re: mv88e6xxx: question: can switch irq be shared?

2018-08-17 Thread David Miller
From: Marek Behún Date: Fri, 17 Aug 2018 11:30:55 +0200 > -IRQF_ONESHOT | IRQF_TRIGGER_FALLING, > +IRQF_ONESHOT | IRQF_TRIGGER_FALLING > +| IRQF_SHARED, The "|" operator shoudl end a line not start

Re: [PATCH v3] net/mlx5e: Delete unneeded function argument

2018-08-16 Thread David Miller
From: Yuval Shaia Date: Thu, 16 Aug 2018 12:02:20 +0300 > priv argument is not used by the function, delete it. > > Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups") > Signed-off-by: Yuval Shaia > --- > v1 -> v2: > * Remove blank line as pointed by Leon. > > v2 -> v3:

Re: [PATCH] net: dsa: add support for ksz9897 ethernet switch

2018-08-16 Thread David Miller
From: Lad Prabhakar Date: Wed, 15 Aug 2018 16:51:23 +0100 > From: "Lad, Prabhakar" > > ksz9477 is superset of ksz9xx series, driver just works > out of the box for ksz9897 chip with this patch. > > Signed-off-by: Lad, Prabhakar Since this is just adding chip IDs and such, this can go in

Re: [PATCH v3 net-next] veth: Free queues on link delete

2018-08-16 Thread David Miller
From: Toshiaki Makita Date: Wed, 15 Aug 2018 17:07:29 +0900 > David Ahern reported memory leak in veth. ... > veth_rq allocated in veth_newlink() was not freed on dellink. > > We need to free up them after veth_close() so that any packets will not > reference the queues afterwards. Thus free

Re: [Patch net-next] ila: make lockdep happy again

2018-08-16 Thread David Miller
From: Cong Wang Date: Tue, 14 Aug 2018 15:21:31 -0700 > Previously, alloc_ila_locks() and bucket_table_alloc() call > spin_lock_init() separately, therefore they have two different > lock names and lock class keys. However, after commit b893281715ab > ("ila: Call library function

Re: [PATCH net-next] net: sched: act_ife: always release ife action on init error

2018-08-16 Thread David Miller
From: Vlad Buslov Date: Tue, 14 Aug 2018 20:29:56 +0300 > Action init API was changed to always take reference to action, even when > overwriting existing action. Substitute conditional action release, which > was executed only if action is newly created, with unconditional release in >

Re: [PATCH net] cls_matchall: fix tcf_unbind_filter missing

2018-08-16 Thread David Miller
From: Hangbin Liu Date: Tue, 14 Aug 2018 17:28:26 +0800 > Fix tcf_unbind_filter missing in cls_matchall as this will trigger > WARN_ON() in cbq_destroy_class(). > > Fixes: fd62d9f5c575f ("net/sched: matchall: Fix configuration race") > Reported-by: Li Shuang > Signed-off-by: Hangbin Liu

Re: [PATCH][bpf-next] bpf: test: fix spelling mistake "REUSEEPORT" -> "REUSEPORT"

2018-08-14 Thread David Miller
From: Alexei Starovoitov Date: Tue, 14 Aug 2018 10:39:12 -0700 > On Mon, Aug 13, 2018 at 03:00:32PM +0100, Colin King wrote: >> From: Colin Ian King >> >> Trivial fix to spelling mistake in error message >> >> Signed-off-by: Colin Ian King > > Acked-by: Alexei Starovoitov > > Dave, may be

Re: [PATCH] hv/netvsc: Fix NULL dereference at single queue mode fallback

2018-08-14 Thread David Miller
From: Takashi Iwai Date: Tue, 14 Aug 2018 19:10:50 +0200 > The recent commit 916c5e1413be ("hv/netvsc: fix handling of fallback > to single queue mode") tried to fix the fallback behavior to a single > queue mode, but it changed the function to return zero incorrectly, > while the function

Re: [PATCH net] cxgb4: Add new T5 PCI device ids 0x50af and 0x50b0

2018-08-14 Thread David Miller
From: Ganesh Goudar Date: Tue, 14 Aug 2018 16:21:37 +0530 > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH net-next] net: dsa: mv88e6xxx: missing unlock on error path

2018-08-14 Thread David Miller
From: Dan Carpenter Date: Tue, 14 Aug 2018 12:09:05 +0300 > We added a new error path, but we need to drop the lock before we return. > > Fixes: 2d2e1dd29962 ("net: dsa: mv88e6xxx: Cache the port cmode") > Signed-off-by: Dan Carpenter Applied.

Re: [PATCH net-next] net: dsa: mv88e6xxx: bitwise vs logical bug

2018-08-14 Thread David Miller
From: Dan Carpenter Date: Tue, 14 Aug 2018 12:06:43 +0300 > We are trying to test if these flags are set but there are some && vs & > typos. > > Fixes: efd1ba6af93f ("net: dsa: mv88e6xxx: Add SERDES phydev_mac_change up > for 6390") > Signed-off-by: Dan Carpenter Applied.

Re: [PATCH net-next] ieee802154: hwsim: using right kind of iteration

2018-08-14 Thread David Miller
From: Alexander Aring Date: Sun, 12 Aug 2018 16:24:56 -0400 > This patch fixes the error path to unsubscribe all other phy's from > current phy. The actually code using a wrong kind of list iteration may > copied from the case to unsubscribe the current phy from all other > phy's. > > Cc:

Re: [PATCH net 0/2] net_sched: Fix two tc_index filter init issues

2018-08-13 Thread David Miller
From: Hangbin Liu Date: Mon, 13 Aug 2018 18:44:02 +0800 > These two patches fix two tc_index filter init issues. The first one fixes > missing exts info in new filter, which will cause NULL pointer dereference > when delete tcindex filter. The second one fixes missing res info when create > new

Re: [PATCH net] nfp: clean up return types in kdoc comments

2018-08-13 Thread David Miller
From: Jakub Kicinski Date: Mon, 13 Aug 2018 18:31:05 -0700 > Remove 'Return:' information from functions which no longer > return a value. Also update name and return types of nfp_nffw_info > access functions. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Dirk van der Merwe Applied,

Re: [pull request][net-next V2 00/12] Mellanox, mlx5e updates 2018-08-10

2018-08-13 Thread David Miller
From: Saeed Mahameed Date: Mon, 13 Aug 2018 13:44:08 -0700 > This series provides some updates to mlx5e netdevice driver. > > For more information please see tag log below. > > Please pull and let me know if there's any problem. > > v1->v2: > - Use l4_mask local function variable in

Re: [PATCH net-next] net: sched: act_ife: disable bh when taking ife_mod_lock

2018-08-13 Thread David Miller
From: Cong Wang Date: Mon, 13 Aug 2018 12:16:52 -0700 > Your fix doesn't make sense, because what ife_mod_lock protects > is absolutely not touched in BH context, they have no race. It does make sense, the problem is if you acquire ife_mod_lock and take a software interrupt while you hold it.

Re: [PATCH net-next] net: sched: act_ife: disable bh when taking ife_mod_lock

2018-08-13 Thread David Miller
From: Vlad Buslov Date: Mon, 13 Aug 2018 20:20:11 +0300 > Lockdep reports deadlock for following locking scenario in ife action: > > Task one: > 1) Executes ife action update. > 2) Takes tcfa_lock. > 3) Waits on ife_mod_lock which is already taken by task two. > > Task two: > > 1) Executes

Re: pull request: bluetooth-next 2018-08-13

2018-08-13 Thread David Miller
From: Johan Hedberg Date: Mon, 13 Aug 2018 18:00:19 +0300 > There was one pretty bad bug that slipped into the MediaTek HCI driver > in the last bluetooth-next pull request. Would it be possible to get > this one-liner fix pulled to net-next before you make your first 4.19 > pull request for

Re: [PATCH net-next] net: sched: act_ife: disable bh when taking ife_mod_lock

2018-08-13 Thread David Miller
From: Vlad Buslov Date: Mon, 13 Aug 2018 20:26:40 +0300 > Is it okay to submit a fix for issue I uncovered when testing actions > with estimators, or I should resubmit to net when net-next is moved? Yes, this is fine.

net-next is CLOSED...

2018-08-13 Thread David Miller
Please only submit bug fixes at this time, thank you.

Re: pull-request: bpf-next 2018-08-13

2018-08-13 Thread David Miller
From: Daniel Borkmann Date: Mon, 13 Aug 2018 01:49:22 +0200 > The following pull-request contains BPF updates for your *net-next* tree. > > The main changes are: ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git Pulled,

Re: [PATCH net-next] lan743x: lan743x: Remove duplicated include from lan743x_ptp.c

2018-08-13 Thread David Miller
From: Yue Haibing Date: Mon, 13 Aug 2018 06:39:21 + > Remove duplicated include. > > Signed-off-by: Yue Haibing Applied.

Re: [PATCH net-next] virtio_net: remove duplicated include from virtio_net.c

2018-08-13 Thread David Miller
From: YueHaibing Date: Mon, 13 Aug 2018 14:13:15 +0800 > Remove duplicated include linux/netdevice.h > > Signed-off-by: YueHaibing Applied.

Re: [PATCH][net-next][v2] packet: switch kvzalloc to allocate memory

2018-08-13 Thread David Miller
From: Li RongQing Date: Mon, 13 Aug 2018 10:42:46 +0800 > The patches includes following change: > > *Use modern kvzalloc()/kvfree() instead of custom allocations. > > *Remove order argument for alloc_pg_vec, it can get from req. > > *Remove order argument for free_pg_vec, free_pg_vec now

Re: [PATCH net-next 00/13] net: sched: actions rename for grep-ability and consistency

2018-08-13 Thread David Miller
From: Jamal Hadi Salim Date: Sun, 12 Aug 2018 09:34:48 -0400 > Having a structure (example tcf_mirred) and a function with the same name is > not good for readability or grepability. > > This long overdue patchset improves it and make sure there is consistency > across all actions Series

Re: [PATCH net-next v2] cpumask: make cpumask_next_wrap available without smp

2018-08-13 Thread David Miller
From: Willem de Bruijn Date: Sun, 12 Aug 2018 09:14:03 -0400 > From: Willem de Bruijn > > The kbuild robot shows build failure on machines without CONFIG_SMP: > > drivers/net/virtio_net.c:1916:10: error: > implicit declaration of function 'cpumask_next_wrap' > > cpumask_next_wrap is

Re: [PATCH net] r8169: don't use MSI-X on RTL8168g

2018-08-13 Thread David Miller
From: Heiner Kallweit Date: Sun, 12 Aug 2018 13:26:26 +0200 > There have been two reports that network doesn't come back on resume > from suspend when using MSI-X. Both cases affect the same chip version > (RTL8168g - version 40), on different systems. Falling back to MSI > fixes the issue. >

Re: [PATCH net v2] l2tp: use sk_dst_check() to avoid race on sk->sk_dst_cache

2018-08-13 Thread David Miller
From: Wei Wang Date: Fri, 10 Aug 2018 11:14:56 -0700 > From: Wei Wang > > In l2tp code, if it is a L2TP_UDP_ENCAP tunnel, tunnel->sk points to a > UDP socket. User could call sendmsg() on both this tunnel and the UDP > socket itself concurrently. As l2tp_xmit_skb() holds socket lock and call >

Re: [PATCH net-next v3 1/1] net/tls: Combined memory allocation for decryption request

2018-08-13 Thread David Miller
From: Vakul Garg Date: Fri, 10 Aug 2018 20:46:41 +0530 > For preparing decryption request, several memory chunks are required > (aead_req, sgin, sgout, iv, aad). For submitting the decrypt request to > an accelerator, it is required that the buffers which are read by the > accelerator must be

Re: [PATCH net-next v2 0/2] ip: faster in-order IP fragments

2018-08-11 Thread David Miller
From: Peter Oskolkov Date: Sat, 11 Aug 2018 20:27:23 + > Added "Signed-off-by" in v2. Series applied, thank you.

Re: [PATCH net-next] rds: avoid lock hierarchy violation between m_rs_lock and rs_recv_lock

2018-08-11 Thread David Miller
From: Sowmini Varadhan Date: Wed, 8 Aug 2018 13:57:13 -0700 > The following deadlock, reported by syzbot, can occur if CPU0 is in > rds_send_remove_from_sock() while CPU1 is in rds_clear_recv_queue() > >CPU0CPU1 > >

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-08-11 Thread David Miller
From: Jakub Kicinski Date: Thu, 9 Aug 2018 20:26:08 -0700 > It is not immediately clear why this is needed. The memory and > updating two sets of counters won't come for free, so perhaps a > stronger justification than troubleshooting is due? :S > > Netdev has counters for fallback vs

Re: [PATCH net-next,v4] net/tls: Calculate nsg for zerocopy path without skb_cow_data.

2018-08-11 Thread David Miller
From: Doron Roberts-Kedes Date: Thu, 9 Aug 2018 15:43:44 -0700 > Taking a step back, is there an existing solution for what this function > is trying to do? I was surprised to find that there did not seem to > exist a function for determining the number of scatterlist elements > required to map

Re: [PATCH v1 net-next] lan743x: lan743x: Add PTP support

2018-08-11 Thread David Miller
From: Bryan Whitehead Date: Thu, 9 Aug 2018 15:36:10 -0400 > PTP support includes: > Ingress, and egress timestamping. > One step timestamping available. > PTP clock support. > Periodic output support. > > Signed-off-by: Bryan Whitehead Applied to net-next, thank you.

Re: [PATCH net-next 1/1] tc: Update README and add config

2018-08-11 Thread David Miller
From: Keara Leibovitz Date: Fri, 10 Aug 2018 10:09:41 -0400 > Updated README. > > Added config file that contains the minimum required features enabled to > run the tests currently present in the kernel. > This must be updated when new unittests are created and require their own > modules. > >

Re: [PATCH net-next 0/4] new mechanism to ACK immediately

2018-08-11 Thread David Miller
From: Yuchung Cheng Date: Thu, 9 Aug 2018 09:38:08 -0700 > This patch is a follow-up feature improvement to the recent fixes on > the performance issues in ECN (delayed) ACKs. Many of the fixes use > tcp_enter_quickack_mode routine to force immediate ACKs. However the > routine also reset

Re: [PATCH net-next 1/2] ip: add helpers to process in-order fragments faster.

2018-08-11 Thread David Miller
From: Peter Oskolkov Date: Fri, 10 Aug 2018 16:22:45 + > This patch introduces several helper functions/macros that will be > used in the follow-up patch. No runtime changes yet. > > The new logic (fully implemented in the second patch) is as follows: > > * Nodes in the rb-tree will now

Re: [PATCH net-next v2 00/15] Remove rtnl lock dependency from all action implementations

2018-08-11 Thread David Miller
From: Vlad Buslov Date: Fri, 10 Aug 2018 20:51:40 +0300 > The goal of this change is to update specific actions APIs that access > action private state directly, in order to be independent from external > locking. General approach is to re-use existing tcf_lock spinlock (used > by some action

Re: [PATCH v3 0/2] net/sctp: Avoid allocating high order memory with kmalloc()

2018-08-11 Thread David Miller
From: Konstantin Khorenko Date: Fri, 10 Aug 2018 20:11:41 +0300 > Each SCTP association can have up to 65535 input and output streams. > For each stream type an array of sctp_stream_in or sctp_stream_out > structures is allocated using kmalloc_array() function. This function > allocates

Re: [PATCH net-next 0/8] l2tp: rework pppol2tp ioctl handling

2018-08-11 Thread David Miller
From: Guillaume Nault Date: Fri, 10 Aug 2018 13:21:54 +0200 > The current ioctl() handling code can be simplified. It tests for > non-relevant conditions and uselessly holds sockets. Once useless > code is removed, it becomes even simpler to let pppol2tp_ioctl() handle > commands directly,

Re: [net-next, PATCH 0/2 v2] netsec driver improvements

2018-08-11 Thread David Miller
From: Ilias Apalodimas Date: Fri, 10 Aug 2018 09:12:37 +0300 > This patchset introduces some improvements on socionext netsec driver. > - patch 1/2, avoids unneeded MMIO reads on the Rx path > - patch 2/2, is adjusting the numbers of descriptors used > > Changes since v1: > - Move

Re: [PATCH] bonding: avoid repeated display of same link status change

2018-08-11 Thread David Miller
From: rama nichanamatlu Date: Thu, 9 Aug 2018 14:12:57 -0700 > From 9927a1c2a632d9479a80c63b7d9fda59ea8374bc Mon Sep 17 00:00:00 2001 > From: Rama Nichanamatlu > Date: Tue, 31 Jul 2018 07:09:52 -0700 > Subject: [PATCH] bonding: avoid repeated display of same link status > change > > When link

Re: [net-next 03/12] net/mlx5e: Ethtool steering, ip6 support

2018-08-10 Thread David Miller
From: Saeed Mahameed Date: Fri, 10 Aug 2018 15:26:21 -0700 > +static bool is_zero_ip6(__be32 ip6[4]) > +{ > + int i; > + > + for (i = 0; i < 4; i++) > + if (ip6[i] != 0) > + return false; > + return true; > +} This is ipv6_addr_any().

Re: [net-next 01/12] net/mlx5e: Ethtool steering flow validation refactoring

2018-08-10 Thread David Miller
From: Saeed Mahameed Date: Fri, 10 Aug 2018 15:26:19 -0700 > +static int validate_tcpudp4(struct ethtool_rx_flow_spec *fs) > +{ > + struct ethtool_tcpip4_spec *l4_mask = >m_u.tcp_ip4_spec; > + int ntuples = 0; > + > + if (fs->m_u.tcp_ip4_spec.tos)

Re: [PATCH net-next v2] bnxt_en: Fix strcpy() warnings in bnxt_ethtool.c

2018-08-10 Thread David Miller
From: Michael Chan Date: Fri, 10 Aug 2018 18:24:43 -0400 > From: Vasundhara Volam > > This patch fixes following smatch warnings: > > drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2826 > bnxt_fill_coredump_seg_hdr() error: strcpy() '"sEgM"' too large for > 'seg_hdr->signature' (5 vs 4)

Re: [PATCH net-next] liquidio: copperhead LED identification

2018-08-10 Thread David Miller
From: Felix Manlunas Date: Thu, 9 Aug 2018 13:54:12 -0700 > From: Raghu Vatsavayi > > Add LED identification support for liquidio TP copperhead cards. > > Signed-off-by: Raghu Vatsavayi > Acked-by: Derek Chickles > Signed-off-by: Felix Manlunas Applied.

Re: [PATCH net-next] bnxt_en: Fix strcpy() warnings in bnxt_ethtool.c

2018-08-10 Thread David Miller
From: David Miller Date: Fri, 10 Aug 2018 14:35:45 -0700 (PDT) > From: Michael Chan > Date: Fri, 10 Aug 2018 17:02:12 -0400 > >> From: Vasundhara Volam >> >> This patch fixes following smatch warnings: >> >> drivers/net/eth

Re: [PATCH net-next] bnxt_en: Fix strcpy() warnings in bnxt_ethtool.c

2018-08-10 Thread David Miller
From: Michael Chan Date: Fri, 10 Aug 2018 17:02:12 -0400 > From: Vasundhara Volam > > This patch fixes following smatch warnings: > > drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2826 > bnxt_fill_coredump_seg_hdr() error: strcpy() '"sEgM"' too large for > 'seg_hdr->signature' (5 vs 4)

Re: [PATCH net-next 0/4] r8169: smaller improvements

2018-08-10 Thread David Miller
From: Heiner Kallweit Date: Fri, 10 Aug 2018 22:36:03 +0200 > This series includes smaller improvements, no functional change > intended. Series applied, thank you.

Re: [PATCH net-next] r8169: remove version info

2018-08-10 Thread David Miller
From: Heiner Kallweit Date: Fri, 10 Aug 2018 21:27:55 +0200 > The version number hasn't changed for ages and in general I doubt it > provides any benefit. The message in rtl_init_one() may even be > misleading because it's printed also if something fails in probe. > Therefore let's remove the

Re: pull request: bluetooth-next 2018-08-10

2018-08-10 Thread David Miller
From: Johan Hedberg Date: Fri, 10 Aug 2018 22:57:07 +0300 > Here's one more (most likely last) bluetooth-next pull request for the > 4.19 kernel. > > - Added support for MediaTek serial Bluetooth devices > - Initial skeleton for controller-side address resolution support > - Fix

Re: [PATCH net] l2tp: fix missing refcount drop in pppol2tp_tunnel_ioctl()

2018-08-10 Thread David Miller
From: Guillaume Nault Date: Fri, 10 Aug 2018 19:58:38 +0200 > As far as I can see, f664e37dcc52 ("l2tp: fix missing refcount drop in > pppol2tp_tunnel_ioctl()") is still in your -stable queue, but the two > patches it depends on haven't made their way to -stable. I'd suggest to > either drop

Re: [PATCH][net-next] packet: switch kvzalloc to allocate memory

2018-08-10 Thread David Miller
From: Li RongQing Date: Fri, 10 Aug 2018 18:00:00 +0800 > @@ -4275,7 +4259,7 @@ static int packet_set_ring(struct sock *sk, union > tpacket_req_u *req_u, > > err = -ENOMEM; > order = get_order(req->tp_block_size); > - pg_vec = alloc_pg_vec(req, order);

Re: [PATCH net-next] cxgb4: add support to display DCB info

2018-08-10 Thread David Miller
From: Ganesh Goudar Date: Fri, 10 Aug 2018 14:47:01 +0530 > display Data Center bridging information in debug > fs. > > Signed-off-by: Casey Leedom > Signed-off-by: Ganesh Goudar Applied.

Re: pull-request: bpf 2018-08-10

2018-08-10 Thread David Miller
From: Daniel Borkmann Date: Fri, 10 Aug 2018 01:21:49 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git Pulled, thanks

Re: [PATCH net-next] cxgb4: update 1.20.8.0 as the latest firmware supported

2018-08-09 Thread David Miller
From: Ganesh Goudar Date: Thu, 9 Aug 2018 12:32:03 +0530 > Change t4fw_version.h to update latest firmware version > number to 1.20.8.0. > > Signed-off-by: Ganesh Goudar Applied, thank you.

Re: [PATCH net-next v2] net: allow to call netif_reset_xps_queues() under cpus_read_lock

2018-08-09 Thread David Miller
From: Andrei Vagin Date: Wed, 8 Aug 2018 20:07:35 -0700 > From: Andrei Vagin > > The definition of static_key_slow_inc() has cpus_read_lock in place. In the > virtio_net driver, XPS queues are initialized after setting the queue:cpu > affinity in virtnet_set_affinity() which is already

Re: [PATCH net-next v2 1/1] net/tls: Combined memory allocation for decryption request

2018-08-09 Thread David Miller
From: Vakul Garg Date: Thu, 9 Aug 2018 04:56:23 +0530 > For preparing decryption request, several memory chunks are required > (aead_req, sgin, sgout, iv, aad). For submitting the decrypt request to > an accelerator, it is required that the buffers which are read by the > accelerator must be

Re: [PATCH v2 net-next] net: phy: sfp: print debug message with text, not numbers

2018-08-09 Thread David Miller
From: Andrew Lunn Date: Thu, 9 Aug 2018 15:00:20 +0200 > Convert the state numbers, device state, etc from numbers to strings > when printing debug messages. > > Signed-off-by: Andrew Lunn > Acked-by: Florian Fainelli > --- > v2: Fixed typo in subject line. > Add Acked-by from Florian

Re: [patch net-next] net: sched: fix block->refcnt decrement

2018-08-09 Thread David Miller
From: Jiri Pirko Date: Wed, 8 Aug 2018 14:04:13 +0200 > From: Jiri Pirko > > Currently the refcnt is never decremented in case the value is not 1. > Fix it by adding decrement in case the refcnt is not 1. > > Reported-by: Vlad Buslov > Fixes: f71e0ca4db18 ("net: sched: Avoid implicit chain

Re: [PATCH net-next] net: ipv6_gre: Fix GRO to work on IPv6 over GRE tap

2018-08-09 Thread David Miller
From: Tariq Toukan Date: Wed, 8 Aug 2018 11:46:30 +0300 > IPv6 GRO over GRE tap is not working while GRO is not set > over the native interface. ... > This patch removes the override of the hard_header_len, and > assigns the calculated value to needed_headroom. > This way, the comparison in

Re: [PATCH net-next 0/3] qed*: Enhancements

2018-08-09 Thread David Miller
From: Manish Chopra Date: Thu, 9 Aug 2018 11:13:48 -0700 > This patch series adds following support in drivers - > > 1. Egress mqprio offload. > 2. Add destination IP based flow profile. > 3. Ingress flower offload (for drop action). > > Please consider applying this series to "net-next".

Re: [PATCH net-next 0/7] s390/qeth: updates 2018-08-09

2018-08-09 Thread David Miller
From: Julian Wiedmann Date: Thu, 9 Aug 2018 14:47:57 +0200 > one more set of patches for net-next. This is all sorts of cleanups > and more refactoring on the way to using netdev_priv. Please apply. Looks simple enough, series applied, thanks.

Re: [PATCH v4 net-next 0/9] Add support for XGMAC2 in stmmac

2018-08-09 Thread David Miller
From: Jose Abreu Date: Wed, 8 Aug 2018 09:04:28 +0100 > This series adds support for 10Gigabit IP in stmmac. Series applied, thanks Jose.

Re: [PATCH net-next 00/13] More complete PHYLINK support for mv88e6xxx

2018-08-09 Thread David Miller
From: Andrew Lunn Date: Thu, 9 Aug 2018 15:38:36 +0200 > Previous patches added sufficient PHYLINK support to the mv88e6xxx > that it did not break existing use cases, basically fixed-link phys. > > This patchset builds out the support so that SFP modules, up to > 2.5Gbps can be supported, on

Re: [PATCH net-next 0/7] mlxsw: Various updates

2018-08-09 Thread David Miller
From: Ido Schimmel Date: Thu, 9 Aug 2018 11:59:06 +0300 > Patches 1-3 update the driver to use a new firmware version. Due to a > recently discovered issue, the version (and future ones) does not > support matching on VLAN ID at egress. This is enforced in the driver > and reported back to the

Re: [PATCH mlx5-next 0/6] Mellanox, mlx5 next updates 2018-08-09

2018-08-08 Thread David Miller
From: Saeed Mahameed Date: Wed, 8 Aug 2018 16:23:47 -0700 > This series includes mlx5 core driver updates and mostly simple > cleanups. > > From Denis: Use max #EQs reported by firmware to request MSIX vectors. > > From Eli: Trivial cleanups, unused arguments/functions and reduce > command

Re: [PATCH] dsa: slave: eee: Allow ports to use phylink

2018-08-08 Thread David Miller
From: Andrew Lunn Date: Wed, 8 Aug 2018 20:56:40 +0200 > For a port to be able to use EEE, both the MAC and the PHY must > support EEE. A phy can be provided by both a phydev or phylink. Verify > at least one of these exist, not just phydev. > > Fixes: aab9c4067d23 ("net: dsa: Plug in PHYLINK

Re: [PATCH net] net: aquantia: Fix IFF_ALLMULTI flag functionality

2018-08-08 Thread David Miller
From: Igor Russkikh Date: Wed, 8 Aug 2018 14:06:32 +0300 > From: Dmitry Bogdanov > > It was noticed that NIC always pass all multicast traffic to the host > regardless of IFF_ALLMULTI flag on the interface. > The rule in MC Filter Table in NIC, that is configured to accept any > multicast

Re: [PATCH net 0/2] Mellanox, mlx5e fixes 2018-08-07

2018-08-08 Thread David Miller
From: Saeed Mahameed Date: Wed, 8 Aug 2018 15:48:06 -0700 > I know it is late into 4.18 release, and this is why I am submitting > only two mlx5e ethernet fixes. > > The first one from Or, is needed for -stable and it fixes hairpin > for "same device" check. > > The second fix is a non risk

Re: [PATCH net-next] ieee802154: hwsim: fix rcu handling

2018-08-08 Thread David Miller
From: Stefan Schmidt Date: Wed, 8 Aug 2018 22:05:54 +0200 > I would, once again, ask you to apply these three directly to > net-next. Ok, done.

Re: [PATCH net-next,v4] net/tls: Calculate nsg for zerocopy path without skb_cow_data.

2018-08-08 Thread David Miller
From: Doron Roberts-Kedes Date: Tue, 7 Aug 2018 11:09:39 -0700 > +static int __skb_nsg(struct sk_buff *skb, int offset, int len, > + unsigned int recursion_level) > +{ > + int start = skb_headlen(skb); > + int i, copy = start - offset; > + struct sk_buff *frag_iter;

Re: [PATCH net-next] selftests: forwarding: gre_multipath: Update next-hop statistics match criteria

2018-08-07 Thread David Miller
From: Nir Dotan Date: Tue, 7 Aug 2018 19:41:55 +0300 > gre_multipath test was using egress vlan_id matching on flows, for the > purpose of collecting next-hops statistics, later to be compared > against configured weights. > As matching on vlan_id on egress direction is not supported on all HW

Re: [PATCH net-next 1/1] tc-tests: initial version of nat action unit tests

2018-08-07 Thread David Miller
From: Keara Leibovitz Date: Tue, 7 Aug 2018 15:18:43 -0400 > Initial set of nat action unit tests. > > Signed-off-by: Keara Leibovitz Applied, thank you.

Re: [Patch net] llc: use refcount_inc_not_zero() for llc_sap_find()

2018-08-07 Thread David Miller
From: Cong Wang Date: Tue, 7 Aug 2018 12:41:38 -0700 > llc_sap_put() decreases the refcnt before deleting sap > from the global list. Therefore, there is a chance > llc_sap_find() could find a sap with zero refcnt > in this global list. > > Close this race condition by checking if refcnt is

Re: [PATCH net v2] dccp: fix undefined behavior with 'cwnd' shift in ccid2_cwnd_restart()

2018-08-07 Thread David Miller
From: Alexey Kodanev Date: Tue, 7 Aug 2018 20:03:57 +0300 > The shift of 'cwnd' with '(now - hc->tx_lsndtime) / hc->tx_rto' value > can lead to undefined behavior [1]. > > In order to fix this use a gradual shift of the window with a 'while' > loop, similar to what tcp_cwnd_restart() is doing.

Re: [net-next 00/12][pull request] 40GbE Intel Wired LAN Driver Updates 2018-08-07

2018-08-07 Thread David Miller
From: Jeff Kirsher Date: Tue, 7 Aug 2018 12:27:45 -0700 > This series contains updates to i40e and i40evf only. Pulled, thanks Jeff.

Re: [PATCH net-next v3 0/3] qed: Add Multi-TC RoCE support

2018-08-07 Thread David Miller
From: Denis Bolotin Date: Tue, 7 Aug 2018 15:48:07 +0300 > Hi Dave, > This patch series adds support for multiple concurrent traffic classes for > RoCE. > The first three patches enable the required parts of the driver to learn the > TC > configuration, and the last one makes use of it to

Re: [PATCH net-next 0/2] ibmvnic: Update firmware error reporting

2018-08-07 Thread David Miller
From: Thomas Falcon Date: Mon, 6 Aug 2018 21:39:57 -0500 > This patch set cleans out a lot of dead code from the ibmvnic driver > and adds some more. The error ID field of the descriptor is not filled > in by firmware, so do not print it and do not use it to query for > more detailed

Re: [PATCH net-next] liquidio: avoided acquiring post_lock for data only queues

2018-08-07 Thread David Miller
From: Felix Manlunas Date: Mon, 6 Aug 2018 13:09:40 -0700 > From: Intiyaz Basha > > All control commands (soft commands) goes through only Queue 0 > (control and data queue). So only queue-0 needs post_lock, > other queues are only data queues and does not need post_lock > > Added a flag to

Re: [Patch net] vsock: split dwork to avoid reinitializations

2018-08-07 Thread David Miller
From: Cong Wang Date: Mon, 6 Aug 2018 11:06:02 -0700 > syzbot reported that we reinitialize an active delayed > work in vsock_stream_connect(): > > ODEBUG: init active (active state 0) object type: timer_list hint: > delayed_work_timer_fn+0x0/0x90 kernel/workqueue.c:1414 >

Re: [PATCH net-next] ip6_tunnel: collect_md xmit: Use ip_tunnel_key's provided src address

2018-08-07 Thread David Miller
From: Shmulik Ladkani Date: Mon, 6 Aug 2018 15:00:59 +0300 > When using an ip6tnl device in collect_md mode, the xmit methods ignore > the ipv6.src field present in skb_tunnel_info's key, both for route > calculation purposes (flowi6 construction) and for assigning the > packet's final

Re: [PATCH net-next-internal] net: sched: cls_flower: set correct offload data in fl_reoffload

2018-08-07 Thread David Miller
From: Vlad Buslov Date: Mon, 6 Aug 2018 11:27:10 +0300 > fl_reoffload implementation sets following members of struct > tc_cls_flower_offload incorrectly: > - masked key instead of mask > - key instead of masked key > > Fix fl_reoffload to provide correct data to offload callback. > >

Re: [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts

2018-08-07 Thread David Miller
From: Al Viro Date: Sun, 5 Aug 2018 18:22:38 +0100 > Unlike fs.val.lport and fs.val.fport, cxgb4_process_flow_match() > sets fs.val.{l,f}ip to net-endian values without conversion - they come > straight from flow_dissector_key_ipv4_addrs ->dst and ->src resp. So > the assignment in

Re: [PATCH net-next 0/6] nfp: flower: tunnel TTL & TOS, and Geneve options set & match support

2018-08-07 Thread David Miller
From: Simon Horman Date: Tue, 7 Aug 2018 17:35:57 +0200 > this series contains updates for the TC Flower classifier > and the offload facility for it in the NFP driver. > > * Patches 1 & 2: update the NFP driver to allow offload > of matching and setting tunnel ToS/TTL of flows using the TC

Re: [PATCH net-next v2 0/3] net: Support Wake-on-LAN using filters

2018-08-07 Thread David Miller
From: Florian Fainelli Date: Tue, 7 Aug 2018 10:50:19 -0700 > This is technically a v2, but this patch series builds on your feedback > and defines the following: > > - a new WAKE_* bit: WAKE_FILTER which can be enabled alongside other type > of Wake-on-LAN to support waking up on a

Re: pull-request: bpf-next 2018-08-07

2018-08-07 Thread David Miller
From: Daniel Borkmann Date: Tue, 7 Aug 2018 19:57:53 +0200 > The following pull-request contains BPF updates for your *net-next* tree. > > The main changes are: ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git Pulled,

Re: [PATCH net-next,v3] net/tls: Calculate nsg for zerocopy path without skb_cow_data.

2018-08-07 Thread David Miller
From: Doron Roberts-Kedes Date: Tue, 7 Aug 2018 10:55:17 -0700 > On Tue, Aug 07, 2018 at 04:10:50PM +, Vakul Garg wrote: >> >> >> > -Original Message- >> > From: Doron Roberts-Kedes [mailto:doro...@fb.com] >> > Sent: Tuesday, August 7, 2018 1:18 AM >> > To: David S . Miller >> >

Re: [PATCH net-next] ieee802154: hwsim: fix rcu address annotation

2018-08-07 Thread David Miller
From: Stefan Schmidt Date: Tue, 7 Aug 2018 17:28:43 +0200 > Could you apply this patch directly to net-next? Sure, no problem, done.

Re: [PATCH net] packet: refine ring v3 block size test to hold one frame

2018-08-06 Thread David Miller
From: Willem de Bruijn Date: Mon, 6 Aug 2018 10:38:34 -0400 > From: Willem de Bruijn > > TPACKET_V3 stores variable length frames in fixed length blocks. > Blocks must be able to store a block header, optional private space > and at least one minimum sized frame. > > Frames, even for a zero

Re: pull-request: ieee802154-next 2018-08-06

2018-08-06 Thread David Miller
From: Stefan Schmidt Date: Mon, 6 Aug 2018 21:38:50 +0200 > An update from ieee802154 for *net-next* > > Romuald added a socket option to get the LQI value of the received datagram. > Alexander added a new hardware simulation driver modelled after hwsim of the > wireless people. It allows

Re: [PATCH net-next] ipv4: frags: precedence bug in ip_expire()

2018-08-06 Thread David Miller
From: Dan Carpenter Date: Mon, 6 Aug 2018 22:17:35 +0300 > We accidentally removed the parentheses here, but they are required > because '!' has higher precedence than '&'. > > Fixes: fa0f527358bd ("ip: use rb trees for IP frag queue.") > Signed-off-by: Dan Carpenter Ugh, good catch, applied,

Re: [PATCH] mellanox: fix the dport endianness in call of __inet6_lookup_established()

2018-08-06 Thread David Miller
From: Al Viro Date: Sat, 4 Aug 2018 21:41:27 +0100 > __inet6_lookup_established() expect th->dport passed in host-endian, > not net-endian. The reason is microoptimization in __inet6_lookup(), > but if you use the lower-level helpers, you have to play by their > rules... > > Signed-off-by:

Re: [PATCH net-next] tc-testing: fix ip address in u32 test

2018-08-05 Thread David Miller
From: Vlad Buslov Date: Sun, 5 Aug 2018 22:35:56 +0300 > Fix expected ip address to actually match configured ip address. > Fix test to expect single matched filter. > > Signed-off-by: Vlad Buslov > Acked-by: Jamal Hadi Salim Applied.

Re: [PATCH net-next] tc-testing: remove duplicate spaces in skbedit match patterns

2018-08-05 Thread David Miller
From: Vlad Buslov Date: Sun, 5 Aug 2018 22:37:09 +0300 > Match patterns for some skbedit tests contain duplicate whitespace that is > not present in actual tc output. This causes tests to fail because they > can't match required action, even when it was successfully created. > > Signed-off-by:

Re: [PATCH net-next] tc-testing: flush gact actions on test teardown

2018-08-05 Thread David Miller
From: Vlad Buslov Date: Sun, 5 Aug 2018 22:36:25 +0300 > Test 6fb4 creates one mirred and one pipe action, but only flushes mirred > on teardown. Leaking pipe action causes failures in other tests. > > Add additional teardown command to also flush gact actions. > > Signed-off-by: Vlad Buslov

<    7   8   9   10   11   12   13   14   15   16   >