Re: [PATCH 16/29] 8390: Avoid comma separated statements

2020-08-25 Thread David Miller
From: Joe Perches Date: Mon, 24 Aug 2020 21:56:13 -0700 > Use semicolons and braces. > > Signed-off-by: Joe Perches Applied.

Re: [PATCH 27/29] ipv6: fib6: Avoid comma separated statements

2020-08-25 Thread David Miller
From: Joe Perches Date: Mon, 24 Aug 2020 21:56:24 -0700 > Use semicolons and braces. > > Signed-off-by: Joe Perches Applied.

Re: [PATCH 17/29] fs_enet: Avoid comma separated statements

2020-08-25 Thread David Miller
From: Joe Perches Date: Mon, 24 Aug 2020 21:56:14 -0700 > Use semicolons and braces. > > Signed-off-by: Joe Perches Applied.

Re: [PATCH 18/29] wan: sbni: Avoid comma separated statements

2020-08-25 Thread David Miller
From: Joe Perches Date: Mon, 24 Aug 2020 21:56:15 -0700 > Use semicolons and braces. > > Signed-off-by: Joe Perches Applied.

Re: [PATCH 28/29] sunrpc: Avoid comma separated statements

2020-08-25 Thread David Miller
From: Joe Perches Date: Mon, 24 Aug 2020 21:56:25 -0700 > Use semicolons and braces. > > Signed-off-by: Joe Perches Applied.

Re: [PATCH] net: caif: fix error code handling

2020-08-25 Thread David Miller
From: Tong Zhang Date: Mon, 24 Aug 2020 18:08:06 -0400 > cfpkt_peek_head return 0 and 1, caller is checking error using <0 > > Signed-off-by: Tong Zhang Applied, thank you.

Re: [PATCH V4] net: dsa: mt7530: Add of_node_put() before break and return statements

2020-08-25 Thread David Miller
From: Sumera Priyadarsini Date: Tue, 25 Aug 2020 01:33:11 +0530 > Every iteration of for_each_child_of_node() decrements > the reference count of the previous node, however when control > is transferred from the middle of the loop, as in the case of > a return or break or goto, there is no decrem

Re: [PATCH v1] net: phy: leds: Deduplicate link LED trigger registration

2020-08-25 Thread David Miller
From: Andy Shevchenko Date: Mon, 24 Aug 2020 20:09:04 +0300 > Refactor phy_led_trigger_register() and deduplicate its functionality > when registering LED trigger for link. > > Signed-off-by: Andy Shevchenko This doesn't compile: CC [M] drivers/net/phy/phy_led_triggers.o drivers/net/phy/ph

Re: [PATCH net] gtp: add GTPA_LINK info to msg sent to userspace

2020-08-25 Thread David Miller
From: Nicolas Dichtel Date: Tue, 25 Aug 2020 14:59:40 +0200 > During a dump, this attribute is essential, it enables the userspace to > know on which interface the context is linked to. > > Fixes: 459aa660eb1d ("gtp: add initial driver for datapath of GPRS Tunneling > Protocol (GTP-U)") > Signe

Re: [PATCH] net: clean up codestyle for net/ipv4

2020-08-25 Thread David Miller
From: Miaohe Lin Date: Tue, 25 Aug 2020 08:32:11 -0400 > This is a pure codestyle cleanup patch. Also add a blank line after > declarations as warned by checkpatch.pl. > > Signed-off-by: Miaohe Lin Applied to net-next.

Re: [PATCH] net: Remove duplicated midx check against 0

2020-08-25 Thread David Miller
From: Miaohe Lin Date: Tue, 25 Aug 2020 08:10:37 -0400 > Check midx against 0 is always equal to check midx against sk_bound_dev_if > when sk_bound_dev_if is known not equal to 0 in these case. > > Signed-off-by: Miaohe Lin Applied to net-next, thanks.

Re: [PATCH] net: dp83869: Fix RGMII internal delay configuration

2020-08-25 Thread David Miller
From: Daniel Gorsulowski Date: Tue, 25 Aug 2020 14:07:21 +0200 > The RGMII control register at 0x32 indicates the states for the bits > RGMII_TX_CLK_DELAY and RGMII_RX_CLK_DELAY as follows: > > RGMII Transmit/Receive Clock Delay > 0x0 = RGMII transmit clock is shifted with respect to trans

Re: [PATCH] net: Avoid unnecessary inet_addr_type() call when addr is INADDR_ANY

2020-08-25 Thread David Miller
From: Miaohe Lin Date: Tue, 25 Aug 2020 07:40:48 -0400 > We can avoid unnecessary inet_addr_type() call by check addr against > INADDR_ANY first. > > Signed-off-by: Miaohe Lin Applied to net-next.

Re: [PATCH] net: Set ping saddr after we successfully get the ping port

2020-08-25 Thread David Miller
From: Miaohe Lin Date: Tue, 25 Aug 2020 07:33:22 -0400 > We can defer set ping saddr until we successfully get the ping port. So we > can avoid clear saddr when failed. Since ping_clear_saddr() is not used > anymore now, remove it. > > Signed-off-by: Miaohe Lin Applied to net-next, thanks.

Re: [PATCH net-next] cxgb4: add error handlers to LE intr_handler

2020-08-25 Thread David Miller
From: Raju Rangoju Date: Tue, 25 Aug 2020 09:25:46 +0530 > cxgb4 does not look for HASHTBLMEMCRCERR and CMDTIDERR > bits in LE_DB_INT_CAUSE register, but these are enabled > in LE_DB_INT_ENABLE. So, add error handlers to LE > interrupt handler to emit a warning or alert message > for hash table m

Re: [PATCH v2] netlink: remove duplicated nla_need_padding_for_64bit() check

2020-08-25 Thread David Miller
From: Miaohe Lin Date: Mon, 24 Aug 2020 23:25:17 -0400 > The need for padding 64bit is implicitly checked by nla_align_64bit(), so > remove this explicit one. > > Signed-off-by: Miaohe Lin Also applied, thank you.

Re: [PATCH v2] net: gain ipv4 mtu when mtu is not locked

2020-08-25 Thread David Miller
From: Miaohe Lin Date: Mon, 24 Aug 2020 23:20:28 -0400 > When mtu is locked, we should not obtain ipv4 mtu as we return immediately > in this case and leave acquired ipv4 mtu unused. > > Signed-off-by: Miaohe Lin Applied to net-next.

Re: [PATCH net-next 0/6] MAINTAINERS: Remove self from PHY LIBRARY

2020-08-24 Thread David Miller
From: Florian Fainelli Date: Mon, 24 Aug 2020 17:43:37 -0700 > > > On 8/24/2020 4:19 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Sat, 22 Aug 2020 13:11:20 -0700 >> >>> Hi David, Heiner, Andrew, Russell, >>> >>> This pat

Re: [PATCH 0/5] pull request for net-next: batman-adv 2020-08-24

2020-08-24 Thread David Miller
From: Simon Wunderlich Date: Mon, 24 Aug 2020 18:27:36 +0200 > here is a small cleanup pull request of batman-adv to go into net-next. > > Please pull or let me know of any problem! Also pulled, thank you.

Re: [PATCH 0/3] pull request for net: batman-adv 2020-08-24

2020-08-24 Thread David Miller
From: Simon Wunderlich Date: Mon, 24 Aug 2020 18:21:08 +0200 > here are some bugfixes which we would like to have integrated into net. > > Please pull or let me know of any problem! Pulled, thanks.

Re: [PATCH v8 net-next 0/3] Add PTP support for Octeontx2

2020-08-24 Thread David Miller
From: sundeep.l...@gmail.com Date: Mon, 24 Aug 2020 21:19:59 +0530 > This patchset adds PTP support for Octeontx2 platform. > PTP is an independent coprocessor block from which > CGX block fetches timestamp and prepends it to the > packet before sending to NIX block. Patches are as > follows: > >

Re: [PATCH net] sfc: fix boolreturn.cocci warning and rename function

2020-08-24 Thread David Miller
From: Edward Cree Date: Mon, 24 Aug 2020 16:18:51 +0100 > check_fcs() was returning bool as 0/1, which was a sign that the sense > of the function was unclear: false was good, which doesn't really match > a name like 'check_$thing'. So rename it to ef100_has_fcs_error(), and > use proper bool

Re: [PATCH] net: Use helper macro RT_TOS() in __icmp_send()

2020-08-24 Thread David Miller
From: Miaohe Lin Date: Mon, 24 Aug 2020 07:44:37 -0400 > Use helper macro RT_TOS() to get tos in __icmp_send(). > > Signed-off-by: Miaohe Lin Applied to net-next, thanks.

Re: [PATCH] net: Avoid access icmp_err_convert when icmp code is ICMP_FRAG_NEEDED

2020-08-24 Thread David Miller
From: Miaohe Lin Date: Mon, 24 Aug 2020 07:15:04 -0400 > There is no need to fetch errno and fatal info from icmp_err_convert when > icmp code is ICMP_FRAG_NEEDED. > > Signed-off-by: Miaohe Lin Applied to net-next, thanks.

Re: [net-next v4] seg6: using DSCP of inner IPv4 packets

2020-08-24 Thread David Miller
From: Ahmed Abdelsalam Date: Mon, 24 Aug 2020 08:51:24 + > This patch allows copying the DSCP from inner IPv4 header to the > outer IPv6 header, when doing SRv6 Encapsulation. > > This allows forwarding packet across the SRv6 fabric based on their > original traffic class. > > Signed-off-by

Re: [PATCH] net: ocelot: Add of_node_put() before return statement

2020-08-24 Thread David Miller
From: Sumera Priyadarsini Date: Sun, 23 Aug 2020 19:22:45 +0530 > Every iteration of for_each_available_child_of_node() decrements > the reference count of the previous node, however when control > is transferred from the middle of the loop, as in the case of > a return or break or goto, there is

Re: [PATCH] firestream: Fix memleak in fs_open

2020-08-24 Thread David Miller
From: Dinghao Liu Date: Sun, 23 Aug 2020 19:29:35 +0800 > When make_rate() fails, vcc should be freed just > like other error paths in fs_open(). > > Signed-off-by: Dinghao Liu Applied, thank you.

Re: [PATCH] dt-bindings: net: dsa: Fix typo

2020-08-24 Thread David Miller
From: Kurt Kanzenbach Date: Sun, 23 Aug 2020 14:18:36 +0200 > Fix spelling mistake documenation -> documentation. > > Fixes: 5a18bb14c0f7 ("dt-bindings: net: dsa: Let dsa.txt refer to dsa.yaml") > Signed-off-by: Kurt Kanzenbach Applied, thanks.

Re: [PATCH v7 net-next 00/10] qed: introduce devlink health support

2020-08-24 Thread David Miller
From: Igor Russkikh Date: Sun, 23 Aug 2020 14:19:24 +0300 > This is a followup implementation after series > > https://patchwork.ozlabs.org/project/netdev/cover/20200514095727.1361-1-irussk...@marvell.com/ > > This is an implementation of devlink health infrastructure. > > With this we are now

Re: [PATCH] net: arc_emac: Fix memleak in arc_mdio_probe

2020-08-24 Thread David Miller
From: Dinghao Liu Date: Sun, 23 Aug 2020 16:56:47 +0800 > When devm_gpiod_get_optional() fails, bus should be > freed just like when of_mdiobus_register() fails. > > Fixes: 1bddd96cba03d ("net: arc_emac: support the phy reset for emac driver") > Signed-off-by: Dinghao Liu Applied, thank you.

Re: [PATCH] chelsio: switch from 'pci_' to 'dma_' API

2020-08-24 Thread David Miller
From: Christophe JAILLET Date: Sun, 23 Aug 2020 10:36:48 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH net-next 0/7] mlxsw: Misc updates

2020-08-24 Thread David Miller
From: Ido Schimmel Date: Sun, 23 Aug 2020 11:06:21 +0300 > From: Ido Schimmel > > This patch set includes various updates for mlxsw. > > Patches #1-#4 adjust the default burst size of packet trap policers to > conform to Spectrum-{2,3} requirements. The corresponding selftest is > also adjuste

Re: [PATCH] NFC: st95hf: Fix memleak in st95hf_in_send_cmd

2020-08-24 Thread David Miller
From: Dinghao Liu Date: Sun, 23 Aug 2020 15:23:43 +0800 > When down_killable() fails, skb_resp should be freed > just like when st95hf_spi_send() fails. > > Signed-off-by: Dinghao Liu Applied, thank you.

Re: [PATCH] net: atheros: switch from 'pci_' to 'dma_' API

2020-08-24 Thread David Miller
From: Christophe JAILLET Date: Sun, 23 Aug 2020 10:03:53 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] starfire: switch from 'pci_' to 'dma_' API

2020-08-24 Thread David Miller
From: Christophe JAILLET Date: Sun, 23 Aug 2020 08:26:41 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] typhoon: switch from 'pci_' to 'dma_' API

2020-08-24 Thread David Miller
From: Christophe JAILLET Date: Sun, 23 Aug 2020 08:11:50 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] net: ipv4: delete repeated words

2020-08-24 Thread David Miller
From: Randy Dunlap Date: Sat, 22 Aug 2020 16:31:41 -0700 > Drop duplicate words in comments in net/ipv4/. > > Signed-off-by: Randy Dunlap Applied.

Re: [PATCH] net: dccp: delete repeated words

2020-08-24 Thread David Miller
From: Randy Dunlap Date: Sat, 22 Aug 2020 18:07:13 -0700 > Drop duplicated words in /net/dccp/. > > Signed-off-by: Randy Dunlap Applied.

Re: [PATCH] net: netlink: delete repeated words

2020-08-24 Thread David Miller
From: Randy Dunlap Date: Sat, 22 Aug 2020 16:40:15 -0700 > Drop duplicated words in net/netlink/. > > Signed-off-by: Randy Dunlap Applied.

Re: [PATCH 0/7] net: sctp: delete duplicated words + other fixes

2020-08-24 Thread David Miller
From: Randy Dunlap Date: Sat, 22 Aug 2020 16:15:54 -0700 > Drop or fix repeated words in net/sctp/. Series applied to net-next, thanks Randy.

Re: [PATCH 0/8] net: batman-adv: delete duplicated words + other fixes

2020-08-24 Thread David Miller
From: Randy Dunlap Date: Sat, 22 Aug 2020 16:13:27 -0700 > Drop repeated words in net/batman-adv/. I'll let the batman-adv folks integrate this series.

Re: [PATCH net-next 0/6] MAINTAINERS: Remove self from PHY LIBRARY

2020-08-24 Thread David Miller
From: Florian Fainelli Date: Sat, 22 Aug 2020 13:11:20 -0700 > Hi David, Heiner, Andrew, Russell, > > This patch series aims at allowing myself to keep track of the Ethernet > PHY and MDIO bus drivers that I authored or contributed to without > being listed as a maintainer in the PHY library any

Re: [PATCH net-next v3 1/2] io_uring: allow tcp ancillary data for __sys_recvmsg_sock()

2020-08-24 Thread David Miller
From: Luke Hsiao Date: Fri, 21 Aug 2020 21:41:04 -0700 > From: Luke Hsiao > > For TCP tx zero-copy, the kernel notifies the process of completions by > queuing completion notifications on the socket error queue. This patch > allows reading these notifications via recvmsg to support TCP tx > zer

Re: [PATCH net-next v3 2/2] io_uring: ignore POLLIN for recvmsg on MSG_ERRQUEUE

2020-08-24 Thread David Miller
From: Luke Hsiao Date: Fri, 21 Aug 2020 21:41:05 -0700 > From: Luke Hsiao > > Currently, io_uring's recvmsg subscribes to both POLLERR and POLLIN. In > the context of TCP tx zero-copy, this is inefficient since we are only > reading the error queue and not using recvmsg to read POLLIN responses

Re: [PATCH] net: dsa: sja1105: Do not use address of compatible member in sja1105_check_device_id

2020-08-24 Thread David Miller
From: Nathan Chancellor Date: Fri, 21 Aug 2020 15:25:16 -0700 > Clang warns: > > drivers/net/dsa/sja1105/sja1105_main.c:3418:38: warning: address of > array 'match->compatible' will always evaluate to 'true' > [-Wpointer-bool-conversion] > for (match = sja1105_dt_ids; match->compatible;

Re: [PATCH] net: Get rid of consume_skb when tracing is off

2020-08-24 Thread David Miller
From: Herbert Xu Date: Sat, 22 Aug 2020 08:23:29 +1000 > The function consume_skb is only meaningful when tracing is enabled. > This patch makes it conditional on CONFIG_TRACEPOINTS. > > Signed-off-by: Herbert Xu Fair enough, applied, thanks.

Re: [PATCH net v2] drivers/net/wan/lapbether: Added needed_tailroom

2020-08-24 Thread David Miller
From: Xie He Date: Fri, 21 Aug 2020 14:26:59 -0700 > The underlying Ethernet device may request necessary tailroom to be > allocated by setting needed_tailroom. This driver should also set > needed_tailroom to request the tailroom needed by the underlying > Ethernet device to be allocated. > > C

Re: [net PATCH] netlabel: fix problems with mapping removal

2020-08-24 Thread David Miller
From: Paul Moore Date: Fri, 21 Aug 2020 16:34:52 -0400 > This patch fixes two main problems seen when removing NetLabel > mappings: memory leaks and potentially extra audit noise. > > The memory leaks are caused by not properly free'ing the mapping's > address selector struct when free'ing the e

Re: [PATCH net-next 0/2] devlink fixes for port and reporter field access

2020-08-24 Thread David Miller
From: Parav Pandit Date: Fri, 21 Aug 2020 22:12:19 +0300 > These series contains two small fixes of devlink. > > Patch-1 initializes port reporter fields early enough to > avoid access before initialized error. > Patch-2 protects port list lock during traversal. Series applied, thank you.

Re: [PATCH net-next] ibmvnic: Fix use-after-free of VNIC login response buffer

2020-08-24 Thread David Miller
From: Thomas Falcon Date: Fri, 21 Aug 2020 13:39:01 -0500 > The login response buffer is freed after it is received > and parsed, but other functions in the driver still attempt > to read it, such as when the device is opened, causing the > Oops below. Store relevant information in the driver's >

Re: [PATCH net-next] ipvlan: advertise link netns via netlink

2020-08-24 Thread David Miller
From: Taehee Yoo Date: Fri, 21 Aug 2020 17:47:32 + > Assign rtnl_link_ops->get_link_net() callback so that IFLA_LINK_NETNSID is > added to rtnetlink messages. > > Test commands: > ip netns add nst > ip link add dummy0 type dummy > ip link add ipvlan0 link dummy0 type ipvlan >

Re: [PATCHv2 net] sctp: not disable bh in the whole sctp_get_port_local()

2020-08-24 Thread David Miller
From: Xin Long Date: Fri, 21 Aug 2020 14:59:38 +0800 > With disabling bh in the whole sctp_get_port_local(), when > snum == 0 and too many ports have been used, the do-while > loop will take the cpu for a long time and cause cpu stuck: > > [ ] watchdog: BUG: soft lockup - CPU#11 stuck for 22s!

Re: [PATCH] net: Check the expect of skb->data at mac header

2020-08-24 Thread David Miller
From: Miaohe Lin Date: Thu, 20 Aug 2020 08:28:22 -0400 > skb_mpls_push() and skb_mpls_pop() expect skb->data at mac header. Check > this assumption or we would get wrong mac_header and network_header. > > Signed-off-by: Miaohe Lin Both openvswitch and act_mpls.c seem to adhere to this constrai

Re: [PATCH v3] ravb: Fixed to be able to unload modules

2020-08-24 Thread David Miller
From: Yuusuke Ashizuka Date: Thu, 20 Aug 2020 18:43:07 +0900 > When this driver is built as a module, I cannot rmmod it after insmoding > it. > This is because that this driver calls ravb_mdio_init() at the time of > probe, and module->refcnt is incremented by alloc_mdio_bitbang() called > after

Re: [RESEND PATCH] net: dsa: microchip: look for phy-mode in port nodes

2020-08-24 Thread David Miller
From: Helmut Grohne Date: Thu, 20 Aug 2020 08:03:33 +0200 > diff --git a/drivers/net/dsa/microchip/ksz_common.c > b/drivers/net/dsa/microchip/ksz_common.c > index 8d53b12d40a8..d96b7ab6bb15 100644 > --- a/drivers/net/dsa/microchip/ksz_common.c > +++ b/drivers/net/dsa/microchip/ksz_common.c > @@

Re: [PATCH v3 0/8] Hirschmann Hellcreek DSA driver

2020-08-24 Thread David Miller
From: Vladimir Oltean Date: Tue, 25 Aug 2020 01:02:03 +0300 > Just my comment on patch 5/8 about netdev->tc_to_txq. There are 2 > distinct things about that: > - accessing struct net_device directly hurts the DSA model a little bit. > - I think there's some confusion regarding the use of netdev->

Re: [PATCH 1/2] veth: Initialize dev->perm_addr

2020-08-24 Thread David Miller
From: Mira Ressel Date: Mon, 24 Aug 2020 14:38:26 + > Set the perm_addr of veth devices to whatever MAC has been assigned to > the device. Otherwise, it remains all zero, with the consequence that > ipv6_generate_stable_address() (which is used if the sysctl > net.ipv6.conf.DEV.addr_gen_mode

Re: [PATCH net] ipv6: ndisc: adjust ndisc_ifinfo_sysctl_change prototype

2020-08-24 Thread David Miller
From: Tobias Klauser Date: Mon, 24 Aug 2020 13:46:22 +0200 > Commit 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler") > changed ndisc_ifinfo_sysctl_change to take a kernel pointer. Adjust its > prototype in net/ndisc.h as well to fix the following sparse warning: > > net/ipv6/ndisc

Re: [PATCH 0/6] Netfilter fixes for net

2020-08-24 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 24 Aug 2020 13:39:35 +0200 > The following patchset contains Netfilter fixes for net: > > 1) Don't flag SCTP heartbeat as invalid for re-used connections, >from Florian Westphal. > > 2) Bogus overlap report due to rbtree tree rotations, from Stefano Brivio

Re: [PATCH] net: gain ipv4 mtu when mtu is not locked

2020-08-24 Thread David Miller
From: Miaohe Lin Date: Mon, 24 Aug 2020 07:35:28 -0400 > When mtu is locked, we should not obtain ipv4 mtu as we return immediately > in this case and leave acquired ipv4 mtu unused. > > Signed-off-by: Miaohe Lin > --- > net/ipv4/route.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-

Re: [PATCH V3] net: dsa: Add of_node_put() before break and return statements

2020-08-24 Thread David Miller
From: Sumera Priyadarsini Date: Mon, 24 Aug 2020 01:00:54 +0530 > --- > > Signed-off-by: Sumera Priyadarsini > > Signed-off-by: Sumera Priyadarsini You only need one Signed-off-by: You must not put the signoff after the "---" otherwise GIT will remove it from the commit log message when I t

Re: [PATCH v7 net-next 0/3] Add PTP support for Octeontx2

2020-08-24 Thread David Miller
From: David Miller Date: Mon, 24 Aug 2020 06:16:57 -0700 (PDT) > Series applied, thank you. Actually, this doesn't even compile: drivers/net/ethernet/marvell/octeontx2/af/ptp.c: In function ‘get_clock_rate’: drivers/net/ethernet/marvell/octeontx2/af/ptp.c:60:26: error: implicit declar

Re: [PATCH v7 net-next 0/3] Add PTP support for Octeontx2

2020-08-24 Thread David Miller
From: sundeep.l...@gmail.com Date: Mon, 24 Aug 2020 13:25:14 +0530 > This patchset adds PTP support for Octeontx2 platform. > PTP is an independent coprocessor block from which > CGX block fetches timestamp and prepends it to the > packet before sending to NIX block. Patches are as > follows: > >

Re: [PATCH net-next v2 2/3] net: openvswitch: refactor flow free function

2020-08-24 Thread David Miller
From: xiangxia.m@gmail.com Date: Mon, 24 Aug 2020 15:36:01 +0800 > To avoid a bug when deleting flows in the future, add > BUG_ON in flush flows function. BUG_ON() is too severe, I think WARN_ON() or similar are sufficient because the kernel can try to continue operating if this condition is

Re: [PATCH] net: systemport: Fix memleak in bcm_sysport_probe

2020-08-24 Thread David Miller
From: Dinghao Liu Date: Mon, 24 Aug 2020 13:58:31 +0800 > When devm_kcalloc() fails, dev should be freed just > like what we've done in the subsequent error paths. > > Fixes: 7b78be48a8eb6 ("net: systemport: Dynamically allocate number of TX > rings") > Signed-off-by: Dinghao Liu Applied and

Re: [PATCH] net: hns: Fix memleak in hns_nic_dev_probe

2020-08-24 Thread David Miller
From: Dinghao Liu Date: Mon, 24 Aug 2020 13:44:42 +0800 > hns_nic_dev_probe allocates ndev, but not free it on > two error handling paths, which may lead to memleak. > > Fixes: 63434888aaf1b ("net: hns: net: hns: enet adds support of acpi") > Signed-off-by: Dinghao Liu Applied and queued up fo

[GIT] Networking

2020-08-22 Thread David Miller
Nothing earth shattering here, lots of small fixes (f.e. missing RCU protection, bad ref counting, missing memset(), etc.) all over the place: 1) Use get_file_rcu() in task_file iterator, from Yonghong Song. 2) There are two ways to set remote source MAC addresses in macvlan driver, but only

Re: [PATCH net-next] net: Remove unnecessary intermediate variables

2020-08-22 Thread David Miller
From: Joe Perches Date: Sat, 22 Aug 2020 14:03:31 -0700 > The compiler didn't inline the code without it. Then the compiler had a good reason for doing so, or it's a compiler bug that should be reported. I would reject any patch that added inline to a foo.c file, so unless you want to make sugg

Re: [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION

2020-08-22 Thread David Miller
From: Pascal Bouchareine Date: Sat, 22 Aug 2020 13:53:03 -0700 > On Sat, Aug 22, 2020 at 1:19 PM Pascal Bouchareine wrote: >> >> On Sat, Aug 22, 2020 at 12:59 PM Pascal Bouchareine wrote: >> >> > Would it make sense to also make UDIAG_SHOW_NAME use sk_description? >> > (And keep the existing ch

Re: [PATCH net-next] net: Remove unnecessary intermediate variables

2020-08-22 Thread David Miller
From: Joe Perches Date: Sat, 22 Aug 2020 13:39:28 -0700 > It _might_ be slightly faster to use inlines We are not using the inline directive in foo.c files and are letting the compiler decide. Please don't give out advice like this. Thank you.

Re: [PATCH net-next v3 0/5] Move MDIO drivers into there own directory

2020-08-22 Thread David Miller
From: Andrew Lunn Date: Sat, 22 Aug 2020 21:51:44 +0200 > I just got a 0-day warning. I will send a fixup soon. I also get this when I simply type make after your changes: WARNING: unmet direct dependencies detected for PCS_XPCS Depends on [n]: NETDEVICES [=y] && PCS_DEVICE [=n] Selected by

Re: [PATCH net-next v3 0/5] Move MDIO drivers into there own directory

2020-08-22 Thread David Miller
From: Andrew Lunn Date: Sat, 22 Aug 2020 20:06:06 +0200 > The phy subdirectory is getting cluttered. It has both PHY drivers and > MDIO drivers, plus a stray switch driver. Soon more PCS drivers are > likely to appear. > > Move MDIO and PCS drivers into new directories. This requires fixing > up

Re: [PATCH] net: Get rid of consume_skb when tracing is off

2020-08-22 Thread David Miller
From: Neil Horman Neil, you might want to fix this so people can reply to you :-)

Re: [PATCH net-next v2 0/9] l2tp: replace custom logging code with tracepoints

2020-08-22 Thread David Miller
From: Tom Parkin Date: Sat, 22 Aug 2020 15:59:00 +0100 > The l2tp subsystem implemented custom logging macros for debugging > purposes which were controlled using a set of debugging flags in each > tunnel and session structure. > > A more standard and easier-to-use approach is to use tracepoints

Re: [PATCH net v2] net: nexthop: don't allow empty NHA_GROUP

2020-08-22 Thread David Miller
From: Nikolay Aleksandrov Date: Sat, 22 Aug 2020 15:06:36 +0300 > Currently the nexthop code will use an empty NHA_GROUP attribute, but it > requires at least 1 entry in order to function properly. Otherwise we > end up derefencing null or random pointers all over the place due to not > having an

Re: [PATCH] net: dccp: Convert to use the preferred fallthrough macro

2020-08-22 Thread David Miller
From: Miaohe Lin Date: Sat, 22 Aug 2020 04:08:27 -0400 > Convert the uses of fallthrough comments to fallthrough macro. > > Signed-off-by: Miaohe Lin Applied.

Re: [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION

2020-08-22 Thread David Miller
From: Pascal Bouchareine Date: Fri, 21 Aug 2020 20:28:27 -0700 > This command attaches the zero terminated string in optval to the > socket for troubleshooting purposes. The free string is displayed in the > process fdinfo file for that fd (/proc//fdinfo/). > > One intended usage is to allow pro

Re: [PATCH net-next] net: Remove unnecessary intermediate variables

2020-08-22 Thread David Miller
From: Jianlin Lv Date: Sat, 22 Aug 2020 10:04:31 +0800 > It is not necessary to use src/dst as an intermediate variable for > assignment operation; Delete src/dst intermediate variables to avoid > unnecessary variable declarations. > > Signed-off-by: Jianlin Lv It keeps the line lengths within

Re: [PATCH next] net: add option to not create fall-back tunnels in root-ns as well

2020-08-21 Thread David Miller
From: Maciej Żenczykowski Date: Fri, 21 Aug 2020 14:25:20 -0700 > If no kernel command line option is specified, should the default > be to maintain compatibility, or do you think it's okay to make > the default be no extra interfaces? They can AFAICT always be added > manually via 'ip link add'

Re: [PATCH net-next 0/2] crypto/chelsio: Restructure chelsio's inline crypto drivers

2020-08-21 Thread David Miller
From: Vinay Kumar Yadav Date: Wed, 19 Aug 2020 19:31:19 +0530 > This series of patches will move chelsio's inline crypto > drivers (ipsec and chtls) from "drivers/crypto/chelsio/" > to "drivers/net/ethernet/chelsio/inline_crypto/" > for better maintenance. > > Patch1: moves out chtls. > Patch2:

Re: [PATCH] net: bypass ->sendpage for slab pages

2020-08-21 Thread David Miller
From: Christoph Hellwig Date: Thu, 20 Aug 2020 06:37:44 +0200 > If you look at who uses sendpage outside the networking layer itself > you see that it is basically block driver and file systems. These > have no way to control what memory they get passed and have to deal > with everything someone

Re: [PATCH next] net: add option to not create fall-back tunnels in root-ns as well

2020-08-21 Thread David Miller
From: Mahesh Bandewar Date: Tue, 18 Aug 2020 17:51:23 -0700 > The sysctl that was added earlier by commit 79134e6ce2c ("net: do > not create fallback tunnels for non-default namespaces") to create > fall-back only in root-ns. This patch enhances that behavior to provide > option not to create fa

Re: pull-request: bpf 2020-08-21

2020-08-21 Thread David Miller
From: Alexei Starovoitov Date: Fri, 21 Aug 2020 12:49:49 -0700 > The following pull-request contains BPF updates for your *net* tree. > > We've added 11 non-merge commits during the last 5 day(s) which contain > a total of 12 files changed, 78 insertions(+), 24 deletions(-). > > The main change

Re: [PATCH] net: dsa: b53: check for timeout

2020-08-21 Thread David Miller
From: t...@redhat.com Date: Fri, 21 Aug 2020 06:56:00 -0700 > From: Tom Rix > > clang static analysis reports this problem > > b53_common.c:1583:13: warning: The left expression of the compound > assignment is an uninitialized value. The computed value will > also be garbage > ent.p

Re: [PATCH net-next] net: remove redundant variable in vxlan_xmit_one

2020-08-21 Thread David Miller
From: Jianlin Lv Date: Fri, 21 Aug 2020 13:56:36 +0800 > @@ -2614,8 +2613,8 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct > net_device *dev, > info = skb_tunnel_info(skb); > > if (rdst) { > - dst = &rdst->remote_ip; > - if (vxlan_addr_any(dst)) {

Re: [net-next PATCH] netlabel: fix problems with mapping removal

2020-08-21 Thread David Miller
From: Paul Moore Date: Thu, 20 Aug 2020 21:46:14 -0400 > This patch fixes two main problems seen when removing NetLabel > mappings: memory leaks and potentially extra audit noise. These are bug fixes therefore this needs to target the 'net' tree and you must also provide appropriate "Fixes:" tag

Re: [PATCH v3] ravb: Fixed to be able to unload modules

2020-08-20 Thread David Miller
From: Yuusuke Ashizuka Date: Thu, 20 Aug 2020 18:43:07 +0900 > When this driver is built as a module, I cannot rmmod it after insmoding > it. > This is because that this driver calls ravb_mdio_init() at the time of > probe, and module->refcnt is incremented by alloc_mdio_bitbang() called > after

Re: [PATCH net] tipc: call rcu_read_lock() in tipc_aead_encrypt_done()

2020-08-20 Thread David Miller
From: Xin Long Date: Thu, 20 Aug 2020 15:34:47 +0800 > b->media->send_msg() requires rcu_read_lock(), as we can see > elsewhere in tipc, tipc_bearer_xmit, tipc_bearer_xmit_skb > and tipc_bearer_bc_xmit(). > > Syzbot has reported this issue as: > > net/tipc/bearer.c:466 suspicious rcu_derefer

Re: [PATCH net] net/sched: act_ct: Fix skb double-free in tcf_ct_handle_fragments() error flow

2020-08-20 Thread David Miller
From: Alaa Hleihel Date: Wed, 19 Aug 2020 18:24:10 +0300 > tcf_ct_handle_fragments() shouldn't free the skb when ip_defrag() call > fails. Otherwise, we will cause a double-free bug. > In such cases, just return the error to the caller. > > Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct")

Re: [PATCH v2] net: sctp: Fix negotiation of the number of data streams.

2020-08-20 Thread David Miller
From: David Laight Date: Wed, 19 Aug 2020 14:40:52 + > > The number of output and input streams was never being reduced, eg when > processing received INIT or INIT_ACK chunks. > The effect is that DATA chunks can be sent with invalid stream ids > and then discarded by the remote system. > >

Re: [PATCH net-next v2 0/4] refactoring of ibmvnic code

2020-08-20 Thread David Miller
From: Lijun Pan Date: Wed, 19 Aug 2020 17:52:22 -0500 > This patch series refactor reset_init and init functions, > and make some other cosmetic changes to make the code > easier to read and debug. v2 removes __func__ and v1's 1/5. Series applied, thank you.

Re: [PATCH v2] dt-bindings: net: renesas,ether: Improve schema validation

2020-08-20 Thread David Miller
From: Geert Uytterhoeven Date: Wed, 19 Aug 2020 14:45:39 +0200 > - Remove pinctrl consumer properties, as they are handled by core > dt-schema, > - Document missing properties, > - Document missing PHY child node, > - Add "additionalProperties: false". > > Signed-off-by: Geert Uytter

Re: [PATCH net-next] net: ipa: remove duplicate include

2020-08-20 Thread David Miller
From: Wang Hai Date: Wed, 19 Aug 2020 10:46:45 +0800 > Remove linux/notifier.h which is included more than once > > Reported-by: Hulk Robot > Signed-off-by: Wang Hai Applied to net-next, thank you.

Re: [PATCH] gre6: Fix reception with IP6_TNL_F_RCV_DSCP_COPY

2020-08-20 Thread David Miller
From: Mark Tomlinson Date: Wed, 19 Aug 2020 13:53:58 +1200 > When receiving an IPv4 packet inside an IPv6 GRE packet, and the > IP6_TNL_F_RCV_DSCP_COPY flag is set on the tunnel, the IPv4 header would > get corrupted. This is due to the common ip6_tnl_rcv() function assuming > that the inner head

Re: [PATCH net-next] ethtool: allow flow-type ether without IP protocol field

2020-08-20 Thread David Miller
From: Vishal Kulkarni Date: Wed, 19 Aug 2020 00:25:03 +0530 > Set IP protocol mask only when IP protocol field is set. > This will allow flow-type ether with vlan rule which don't have > protocol field to apply. > > ethtool -N ens5f4 flow-type ether proto 0x8100 vlan 0x600\ > m 0x1FFF action 3 l

Re: [PATCH net, 0/2] hv_netvsc: Some fixes for the select_queue

2020-08-20 Thread David Miller
From: Haiyang Zhang Date: Thu, 20 Aug 2020 14:53:13 -0700 > This patch set includes two fixes for the select_queue process. Series applied, thank you.

Re: [PATCH] nfc: st-nci: Remove unnecessary cast

2020-08-20 Thread David Miller
From: Alex Dewar Date: Thu, 20 Aug 2020 19:32:58 +0100 > In st_nci_hci_connectivity_event_received(), the return value of > devm_kzalloc() is unnecessarily cast from void*. Remove cast. > > Issue identified with Coccinelle. > > Signed-off-by: Alex Dewar Applied.

Re: [PATCH] nfc: st21nfca: Remove unnecessary cast

2020-08-20 Thread David Miller
From: Alex Dewar Date: Thu, 20 Aug 2020 19:38:36 +0100 > In st21nfca_connectivity_event_received(), the return value of > devm_kzalloc() is unnecessarily cast from void*. Remove cast. > > Issue identified with Coccinelle. > > Signed-off-by: Alex Dewar Applied.

Re: [PATCH] net: qed: Remove unnecessary cast

2020-08-20 Thread David Miller
From: Alex Dewar Date: Thu, 20 Aug 2020 18:47:25 +0100 > In qed_rdma_destroy_cq() the result of dma_alloc_coherent() is cast from > void* unnecessarily. Remove cast. > > Issue identified with Coccinelle. > > Signed-off-by: Alex Dewar Applied to net-next, thanks.

Re: [PATCH net-next 0/3] tcp_mmap: optmizations

2020-08-20 Thread David Miller
From: Eric Dumazet Date: Thu, 20 Aug 2020 10:11:15 -0700 > This series updates tcp_mmap reference tool to use best pratices. > > First patch is using madvise(MADV_DONTNEED) to decrease pressure > on the socket lock. > > Last patches try to use huge pages when available. Series applied, thanks

<    5   6   7   8   9   10   11   12   13   14   >