erenced.
>
> Signed-off-by: Jon Smirl <[EMAIL PROTECTED]>
Acked-by: Domen Puncer <[EMAIL PROTECTED]>
I can't test it at the moment, but the patch is obviously correct,
mapped buffer should be the _same_ as submitted.
>
> ---
>
> drivers/net/fec_mpc52
void __exit uec_mdio_exit(void) is called from
- static int __init ucc_geth_init(void)
- static void __exit ucc_geth_exit(void)
First one would make error path more than just an error.
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
---
drivers/net/ucc_geth_mii.c |3 ++-
1 file chan
On 29/07/07 00:02 +0200, Jesper Juhl wrote:
> Hi,
>
> Here's a small patch, prompted by a find by the Coverity checker,
> that removes a potential NULL pointer dereference from
> drivers/net/sb1000.c::sb1000_dev_ioctl().
> The checker spotted that we do a NULL test of 'dev', yet we
> dereferenc
Hi!
I've noticed mii-tool doesn't work right for a driver I'm just
developing (it uses generic phy layer).
Driver's ioctl is wired directly to phy_mii_ioctl().
"mii-tool -A something" shows the problem is in
phy_mii_ioctl -> SIOCSMIIREG:
392 case MII_ADVERTISE:
393
Fix a thinko (?) in setting phydev->autoneg.
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
---
This fixes my "mii.h -> ethtool.h advertising #defines". I'm not sure
why and how they're translated, but it does work now.
Maybe they're just ignored, since m
Hi!
Not for merge (yet)! But please do review.
fec_mpc52xx driver (not in-tree, but floating around) isn't in very
good shape, so I tried to change that.
Diff against original is quite big (fec_phy.c is completely rewritten)
and confuzing, so I'm including whole drivers/net/fec_mpc52xx/ .
I stil
On 10/08/07 10:02 -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Aug 10, 2007 at 11:51:53AM +0200, Domen Puncer escreveu:
> > +static u8 null_mac[6];
>
> const
OK.
...
> > +static void fec_set_paddr(struct net_device *dev, u8 *mac)
> > +{
> > + struct
Writing BMCR_RESET bit will reset MII_BMCR to default values. This is
clearly not what we want.
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
---
drivers/net/phy/phy_device.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: work-powerpc.git/drivers/net/phy/phy_de
oC-i.patch)
If there are no objections, I would like this to be merged after
bestcomm (mpc52xx dma engine) patches hit mainline, and that will
hopefully be at the beginning of the 2.6.24 merge window.
--
Driver for ethernet on mpc5200/mpc5200b SoCs (FEC).
Signed-off-by: Domen Puncer <[EM
On 03/09/07 09:57 -0600, Grant Likely wrote:
> On 9/2/07, Domen Puncer <[EMAIL PROTECTED]> wrote:
> > Hi!
> >
> > new in this version:
> > - fixed stuff that was commented on.
> > - added 7-wire support (compile at least, if someone has the hardware,
> >
Export phy_mii_ioctl, so network drivers can use it when built
as modules too.
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
---
On 17/09/07 11:53 +0200, Sven Luther wrote:
> On Sat, Sep 15, 2007 at 02:14:44PM +0200, Domen Puncer wrote:
> > Updated and split version at:
> >
(I edited Cc: -jeff, +sven, hope you don't mind)
On 17/09/07 18:08 -0400, Jon Smirl wrote:
> On 9/17/07, Domen Puncer <[EMAIL PROTECTED]> wrote:
> > Export phy_mii_ioctl, so network drivers can use it when built
> > as modules too.
>
> Domen, do you want to
On 18/09/07 15:17 -0400, Jon Smirl wrote:
> On 9/18/07, Domen Puncer <[EMAIL PROTECTED]> wrote:
> > More testing and getting it to work properly on Phytec pcm030 would
> > be great.
>
> I compiled it as a module:
> CC [M] drivers/net/fec_mpc52xx/fec.o
>
On 02/10/07 14:49 +0200, Sascha Hauer wrote:
>
> Hi Domen,
Hi Sascha!
>
> On Sun, Sep 02, 2007 at 09:41:43AM +0200, Domen Puncer wrote:
> + */
> > +static void fec_start(struct net_device *dev)
> > +{
> > + struct fec_priv *priv = netdev_priv(dev);
> &
Hello!
If there are no objections, I would like to get this merged
when bestcomm goes in (any time now?).
It's split into four parts:
1 - device tree
2 - small bestcomm change
3 - the actual driver
4 - phy part of the driver
Domen
--
Domen Puncer | Research & De
Add masks and fix existing ones to match mpc5200b user's manual.
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
---
arch/powerpc/sysdev/bestcomm/fec.h | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
Index: linux.git/arch/powerpc/sysdev/bes
Add device tree entries for lite5200b's FEC's PHY.
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/lite5200b.dts | 18 +-
1 files changed, 17 insertions(+), 1 deletion(-)
Index: linux.git/arch/powerpc/boot/d
PHY part of the driver for mpc5200(b) ethernet.
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
---
drivers/net/fec_mpc52xx/Kconfig | 13 ++
drivers/net/fec_mpc52xx/Makefile |5
drivers/net/fec_mpc52xx/fec.c | 11 ++
drivers/net/fec_mpc52xx/fec.h |2
drive
Driver for ethernet on mpc5200/mpc5200b SoCs (FEC).
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
---
drivers/net/Kconfig |1
drivers/net/Makefile |1
drivers/net/fec_mpc52xx/Kconfig | 15
drivers/net/fec_mpc52xx/Makefile |2
drive
On 14/10/07 16:05 -0600, Grant Likely wrote:
> On 10/14/07, Domen Puncer <[EMAIL PROTECTED]> wrote:
> > PHY part of the driver for mpc5200(b) ethernet.
>
> Assuming I understand correctly, this comment is not correct and this
> patch just adds an MDIO bus driver. PHY d
Driver for ethernet on mpc5200/mpc5200b SoCs (FEC).
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
---
On 18/10/07 15:14 -0400, Jeff Garzik wrote:
>
> except a resend combining patches 3 and 4 as requested :)
OK, here it goes. Sorry for the delay.
diffstat:
drivers
On 25/10/07 05:29 -0400, Jeff Garzik wrote:
> Domen Puncer wrote:
> >+static int mpc52xx_fec_alloc_rx_buffers(struct bcom_task *rxtsk)
> >+{
> >+while (!bcom_queue_full(rxtsk)) {
> >+struct sk_buff *skb;
> >+struct bcom_fec
On 25/10/07 11:57 -0700, Dale Farnsworth wrote:
> Domen wrote:
> > > use your platform's dma mapping functions, rather than virt_to_phys()
> > >
> > > it might be the exact same implementation, inside the platform
> > > internals, but drivers should not be using this directly.
> >
> > I've repla
On 25/10/07 13:29 -0700, Dale Farnsworth wrote:
> On Thu, Oct 25, 2007 at 09:41:14PM +0200, Domen Puncer wrote:
> > On 25/10/07 11:57 -0700, Dale Farnsworth wrote:
> > > Domen wrote:
> > > > > use your platform's dma mapping functions, rather than virt_to_p
On 26/10/07 07:18 -0700, Dale Farnsworth wrote:
> On Fri, Oct 26, 2007 at 01:59:09PM +0200, Domen Puncer wrote:
> > +static irqreturn_t mpc52xx_fec_tx_interrupt(int irq, void *dev_id)
> > +{
> > + struct net_device *dev = dev_id;
> > + struct mpc52xx_fec_p
25 matches
Mail list logo
