Re: [PATCH 6/7] [DCCP]: Fix setting of packet size in CCID3

2006-09-22 Thread Eddie Kohler
| +case DCCP_SOCKOPT_TX_PACKET_SIZE: | +if (dmsk->dccpms_tx_ccid != DCCPC_CCID3) | +err = -EINVAL; This is unfortunate: it is in the generic dccp code but works only for CCID 3. Same for DCCP_SOCKOPT_RX_PACKET_SIZE. I agree with Gerrit. An average packet s

Re: [PATCH 5/7] [DCCP]: Introduce two new socket options

2006-09-22 Thread Eddie Kohler
Hi, just a couple clarifications and notes. I haven't deeply thought through the new socket options, but disagree with your objections :) Gerrit Renker wrote: | This creates two new socket options DCCP_SOCKOPT_TX_PACKET_SIZE | and DCCP_SOCKOPT_RX_PACKET_SIZE. DCCP_SOCKOPT_PACKET_SIZE doesn't