[PATCH] tehuti: possible leak in bdx_probe

2007-10-13 Thread Florin Malita
If pci_enable_device fails, bdx_probe returns without freeing the allocated pci_nic structure. Coverity CID 1908. Signed-off-by: Florin Malita <[EMAIL PROTECTED]> --- drivers/net/tehuti.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/tehuti.c b/d

Re: [PATCH] libertas: skb dereferenced after netif_rx

2007-05-21 Thread Florin Malita
ieve the following should be OK: Remove inaccurate netif_rx() return value comments. Signed-off-by: Florin Malita <[EMAIL PROTECTED]> --- dev.c |3 --- 1 file changed, 3 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index f2b6111..79f5d90 100644 --- a/net/core/dev.c ++

Re: [PATCH] libertas: skb dereferenced after netif_rx

2007-05-18 Thread Florin Malita
I will send a separate cleanup patch but this might be leaning more on the implementation detail side (planning to extend the functions and make the return code meaningful in the future?) so somebody familiar with the driver should make the call. Thanks, Florin Signed-off-by: Florin Malita <

[PATCH] spidernet: skb used after netif_receive_skb

2007-05-16 Thread Florin Malita
The stats update code in spider_net_pass_skb_up() is touching the skb after it's been passed up to the stack. To avoid that, just update the stats first. Signed-off-by: Florin Malita <[EMAIL PROTECTED]> --- spider_net.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletio

[PATCH] libertas: skb dereferenced after netif_rx

2007-05-16 Thread Florin Malita
- might as well take it out. Signed-off-by: Florin Malita <[EMAIL PROTECTED]> --- rx.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/net/wireless/libertas/rx.c b/drivers/net/wireless/libertas/rx.c index d17924f..5e98055 100644 --- a/drive

[PATCH 15/17] sky2: only disable 88e8056 on some boards

2007-05-13 Thread Florin Malita
Hi Stephen, Stephen Hemminger wrote: Use DMI to add a blacklist of broken board. For now only one is known bad. Gentoo users report driver works on other motherboards (strange). [snip] + .ident = "Gigabyte 965P-S3", + .matches = { + DMI_MATCH(