t (and it seems davem
agrees with me). Vakul's
patch looks good to me for now.
>
>> > If the flag MSG_DONTWAIT is set, we should be returning -EINPROGRESS and
>> > not wait for a response. I had started working on a patch for that, but
>> > it's
>> > pretty tricky to
On Wed, Jan 31, 2018 at 8:10 AM, Gilad Ben-Yossef <gi...@benyossef.com> wrote:
> Hi Vakul,
>
> On Wed, Jan 31, 2018 at 12:36 PM, Vakul Garg <vakul.g...@nxp.com> wrote:
>> Async crypto accelerators (e.g. drivers/crypto/caam) support offloading
>> G
init_completion(_done.comp);
> +
> rc = crypto_aead_encrypt(aead_req);
> + if (rc == -EINPROGRESS) {
> + wait_for_completion(_done.comp);
> + rc = crypto_done.result;
> + }
>
> ctx->sg_encrypted_data[0].offset -= t
Now that -EBUSY return code only indicates backlog queueing
we can safely remove the now redundant check for the
CRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Acked-by: Boris Brezillon <boris.brezil...@free-elec
the change
moving over the algif code which it originated from
to the new API.
- Inline crypto_wait_req().
- Some code indentation fixes.
Gilad Ben-Yossef (20):
crypto: change transient busy return code to -ENOSPC
crypto: ccp: use -ENOSPC for transient busy indication
net: use -ENOSPC for tran
for the
completion of the request any way.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/drbg.c | 36 +---
include/crypto/drbg.h | 3 +--
2 files changed, 10 insertions(+), 29 deletions(-)
diff --git a/crypto/drbg.c b/crypto/drbg.c
testmgr is starting async. crypto ops and waiting for them to complete.
Move it over to generic code doing the same.
This also provides a test of the generic crypto async. wait code.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/testmgr.c
Now that -EBUSY return code only indicates backlog queueing
we can safely remove the now redundant check for the
CRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/ahash.c| 12 +++-
crypto/cts.c
prior to the
async op finishing, should this code ever move to a context
where signals are not masked.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
CC: Mikulas Patocka <mpato...@redhat.com>
---
drivers/md/dm-verity-target.c | 81 +++
d
cifs starts an async. crypto op and waits for their completion.
Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Acked-by: Pavel Shilovsky <pshi...@microsoft.com>
---
fs/cifs/smb2ops.c | 30 --
1 fil
The talitos driver starts several async crypto ops and waits for their
completions. Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Tested-by: Christophe Leroy <christophe.le...@c-s.fr>
---
drivers/crypto/ta
prior to the
async op finishing.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
Documentation/crypto/api-samples.rst | 52 +++-
1 file changed, 10 insertions(+), 42 deletions(-)
diff --git a/Documentation/crypto/api-samples.rst
b/Documentation/cryp
The qce driver starts several async crypto ops and waits for their
completions. Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/crypto/qce/sha.c | 30 --
1 file changed, 4 insertions(+), 26 del
The mediatek driver starts several async crypto ops and waits for their
completions. Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Acked-by: Ryder Lee <ryder@mediatek.com>
---
drivers/crypto/mediatek/mt
tcrypt starts several async crypto ops and waits for their completions.
Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/tcrypt.c | 84 +
1 file changed, 25 insertions(
ima starts several async crypto ops and waits for their completions.
Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Acked-by: Mimi Zohar <zo...@linux.vnet.ibm.com>
---
security/integrity/ima/ima_c
fscrypt starts several async. crypto ops and waiting for them to
complete. Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
fs/crypto/crypto.c | 28
fs/crypto/fname.c
gcm is starting an async. crypto op and waiting for it complete.
Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/gcm.c | 32 ++--
1 file changed, 6 insertions(+), 26 deletions(-)
diff --git a/crypto
algif starts several async crypto ops and waits for their completion.
Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/af_alg.c | 27 ---
crypto/algif_aead.c | 8
crypto/algif_
public_key_verify_signature() is starting an async crypto op and
waiting for it to complete. Move it over to generic code doing
the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/asymmetric_keys/public_key.c | 28
1 file changed, 4 inse
rolled versions.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
CC: Eric Biggers <ebigge...@gmail.com>
CC: Jonathan Cameron <jonathan.came...@huawei.com>
---
crypto/api.c | 13 +
include/linux/crypto.h | 40
2
Replace -EBUSY with -ENOSPC when reporting transient busy
indication in the absence of backlog.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Reviewed-by: Gary R Hook <gary.h...@amd.com>
---
Please squash this patch with the previous one when merging upstream.
drivers/cr
Replace -EBUSY with -ENOSPC when handling transient busy
indication in the absence of backlog.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
Please squash this patch with the previous one when merging upstream.
net/ipv4/ah4.c | 2 +-
net/ipv4/esp4.c | 2 +-
net/ipv6/ah6.
st_flags(req) &
CRYPTO_TFM_REQ_MAY_BACKLOG)))
This patch changes the return code used to indicate a crypto op
failed due to the transformation provider being transiently busy
to -ENOSPC.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
c
On Tue, Oct 17, 2017 at 5:06 PM, Russell King - ARM Linux
<li...@armlinux.org.uk> wrote:
> On Sun, Oct 15, 2017 at 10:19:45AM +0100, Gilad Ben-Yossef wrote:
>> Many users of kernel async. crypto services have a pattern of
>> starting an async. crypto op and than using a
On Sun, Oct 15, 2017 at 6:38 PM, Herbert Xu <herb...@gondor.apana.org.au> wrote:
>
> On Sun, Oct 15, 2017 at 10:19:45AM +0100, Gilad Ben-Yossef wrote:
> >
> > Changes from v8:
> > - Remove the translation of EAGAIN return code to the
> > previous ret
Replace -EBUSY with -EAGAIN when reporting transient busy
indication in the absence of backlog.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Reviewed-by: Gary R Hook <gary.h...@amd.com>
---
Please squash this patch with the previous one when merging upstream.
drivers/cr
sting code and rebase
on top of that patch set.
- Rename 'ecr' to 'wait' in fscrypto code.
- Split patch introducing the new API from the change
moving over the algif code which it originated from
to the new API.
- Inline crypto_wait_req().
- Some code indentation fixes.
Gilad Ben-Yossef (20)
Replace -EBUSY with -EAGAIN when handling transient busy
indication in the absence of backlog.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
Please squash this patch with the previous one when merging upstream.
net/ipv4/ah4.c | 2 +-
net/ipv4/esp4.c | 2 +-
net/ipv6/ah6.
for the
completion of the request any way.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/drbg.c | 36 +---
include/crypto/drbg.h | 3 +--
2 files changed, 10 insertions(+), 29 deletions(-)
diff --git a/crypto/drbg.c b/crypto/drbg.c
rolled versions.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
CC: Eric Biggers <ebigge...@gmail.com>
CC: Jonathan Cameron <jonathan.came...@huawei.com>
---
crypto/api.c | 13 +
include/linux/crypto.h | 40
2
algif starts several async crypto ops and waits for their completion.
Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/af_alg.c | 27 ---
crypto/algif_aead.c | 8
crypto/algif_
ima starts several async crypto ops and waits for their completions.
Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Acked-by: Mimi Zohar <zo...@linux.vnet.ibm.com>
---
security/integrity/ima/ima_c
testmgr is starting async. crypto ops and waiting for them to complete.
Move it over to generic code doing the same.
This also provides a test of the generic crypto async. wait code.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/testmgr.c
prior to the
async op finishing, should this code ever move to a context
where signals are not masked.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
CC: Mikulas Patocka <mpato...@redhat.com>
---
drivers/md/dm-verity-target.c | 81 +++
d
cifs starts an async. crypto op and waits for their completion.
Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Acked-by: Pavel Shilovsky <pshi...@microsoft.com>
---
fs/cifs/smb2ops.c | 30 --
1 fil
fscrypt starts several async. crypto ops and waiting for them to
complete. Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
fs/crypto/crypto.c | 28
fs/crypto/fname.c
prior to the
async op finishing.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
Documentation/crypto/api-samples.rst | 52 +++-
1 file changed, 10 insertions(+), 42 deletions(-)
diff --git a/Documentation/crypto/api-samples.rst
b/Documentation/cryp
The mediatek driver starts several async crypto ops and waits for their
completions. Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Acked-by: Ryder Lee <ryder@mediatek.com>
---
drivers/crypto/mediatek/mt
The talitos driver starts several async crypto ops and waits for their
completions. Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/crypto/talitos.c | 38 +-
1 file changed, 5 insertions(
The qce driver starts several async crypto ops and waits for their
completions. Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/crypto/qce/sha.c | 30 --
1 file changed, 4 insertions(+), 26 del
tcrypt starts several async crypto ops and waits for their completions.
Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/tcrypt.c | 84 +
1 file changed, 25 insertions(
gcm is starting an async. crypto op and waiting for it complete.
Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/gcm.c | 32 ++--
1 file changed, 6 insertions(+), 26 deletions(-)
diff --git a/crypto
public_key_verify_signature() is starting an async crypto op and
waiting for it to complete. Move it over to generic code doing
the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/asymmetric_keys/public_key.c | 28
1 file changed, 4 inse
Now that -EBUSY return code only indicates backlog queueing
we can safely remove the now redundant check for the
CRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/ahash.c| 12 +++-
crypto/cts.c
Now that -EBUSY return code only indicates backlog queueing
we can safely remove the now redundant check for the
CRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Acked-by: Boris Brezillon <boris.brezil...@free-elec
st_flags(req) &
CRYPTO_TFM_REQ_MAY_BACKLOG)))
This patch changes the return code used to indicate a crypto op
failed due to the transformation provider being transiently busy
to -EAGAIN.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
c
On Sat, Oct 7, 2017 at 6:05 AM, Herbert Xu <herb...@gondor.apana.org.au> wrote:
> On Tue, Sep 05, 2017 at 03:38:40PM +0300, Gilad Ben-Yossef wrote:
>>
>> diff --git a/crypto/algif_hash.c b/crypto/algif_hash.c
>> index 5e92bd2..3b3c154 100644
>> --- a/cr
st_flags(req) &
CRYPTO_TFM_REQ_MAY_BACKLOG)))
This patch changes the return code used to indicate a crypto op
failed due to the transformation provider being transiently busy
to -EAGAIN.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto
Now that -EBUSY return code only indicates backlog queueing
we can safely remove the now redundant check for the
CRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/ahash.c| 12 +++-
crypto/cts.c
Now that -EBUSY return code only indicates backlog queueing
we can safely remove the now redundant check for the
CRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Acked-by: Boris Brezillon <boris.brezil...@free-elec
rolled versions.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
CC: Eric Biggers <ebigge...@gmail.com>
CC: Jonathan Cameron <jonathan.came...@huawei.com>
---
crypto/api.c | 13 +
include/linux/crypto.h | 40
2
gcm is starting an async. crypto op and waiting for it complete.
Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/gcm.c | 32 ++--
1 file changed, 6 insertions(+), 26 deletions(-)
diff --git a/crypto
cifs starts an async. crypto op and waits for their completion.
Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Acked-by: Pavel Shilovsky <pshi...@microsoft.com>
---
fs/cifs/smb2ops.c | 30 --
1 fil
testmgr is starting async. crypto ops and waiting for them to complete.
Move it over to generic code doing the same.
This also provides a test of the generic crypto async. wait code.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/testmgr.c
prior to the
async op finishing, should this code ever move to a context
where signals are not masked.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
CC: Mikulas Patocka <mpato...@redhat.com>
---
drivers/md/dm-verity-target.c | 81 +++
d
ima starts several async crypto ops and waits for their completions.
Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Acked-by: Mimi Zohar <zo...@linux.vnet.ibm.com>
---
security/integrity/ima/ima_c
tcrypt starts several async crypto ops and waits for their completions.
Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/tcrypt.c | 84 +
1 file changed, 25 insertions(
The qce driver starts several async crypto ops and waits for their
completions. Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/crypto/qce/sha.c | 30 --
1 file changed, 4 insertions(+), 26 del
prior to the
async op finishing.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
Documentation/crypto/api-samples.rst | 52 +++-
1 file changed, 10 insertions(+), 42 deletions(-)
diff --git a/Documentation/crypto/api-samples.rst
b/Documentation/cryp
The mediatek driver starts several async crypto ops and waits for their
completions. Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Acked-by: Ryder Lee <ryder@mediatek.com>
---
drivers/crypto/mediatek/mt
The talitos driver starts several async crypto ops and waits for their
completions. Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/crypto/talitos.c | 38 +-
1 file changed, 5 insertions(
fscrypt starts several async. crypto ops and waiting for them to
complete. Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
fs/crypto/crypto.c | 28
fs/crypto/fname.c
for the
completion of the request any way.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/drbg.c | 36 +---
include/crypto/drbg.h | 3 +--
2 files changed, 10 insertions(+), 29 deletions(-)
diff --git a/crypto/drbg.c b/crypto/drbg.c
public_key_verify_signature() is starting an async crypto op and
waiting for it to complete. Move it over to generic code doing
the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/asymmetric_keys/public_key.c | 28
1 file changed, 4 inse
algif starts several async crypto ops and waits for their completion.
Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
crypto/af_alg.c | 27 ---
crypto/algif_aead.c | 8
crypto/algif_
Replace -EBUSY with -EAGAIN when handling transient busy
indication in the absence of backlog.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
Please squash this patch with the previous one when merging upstream.
---
net/ipv4/ah4.c | 2 +-
net/ipv4/esp4.c | 2 +-
net/ipv6/ah6.
Replace -EBUSY with -EAGAIN when reporting transient busy
indication in the absence of backlog.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Reviewed-by: Gary R Hook <gary.h...@amd.com>
---
Please squash this patch with the previous one when merging upstream.
---
driver
he new API.
- Inline crypto_wait_req().
- Some code indentation fixes.
Gilad Ben-Yossef (20):
crypto: change transient busy return code to -EAGAIN
crypto: ccp: use -EAGAIN for transient busy indication
net: use -EAGAIN for transient busy indication
crypto: remove redundant backlog check
in a memcpy of the digest failing anyway and thus the security
risk seems minor, performing a memory compare on what might be
uninitialized memory is wrong.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
CC: Alexander Alemayhu <alexan...@alemayhu.com>
---
The change was boot tested on
in a memcpy of the digest failing anyway and thus the security
risk seems minor, performing a memory compare on what might be
uninitialized memory is wrong.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
net/ipv4/ah4.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/ipv4/ah4.c
in a memcpy of the digest failing anyway and thus the security
risk seems minor, performing a memory compare on what might be
uninitialized memory is wrong.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
net/ipv6/ah6.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/ipv6/ah6.c
in a
memcmp of the digest failing anyway and thus the security risk seems
minor, performing a memory compare on what might be uninitialized memory
is wrong.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
CC: Alexander Alemayhu <alexan...@alemayhu.com>
---
The change was boot tes
On Fri, Jan 13, 2017 at 9:45 AM, Alexander Alemayhu
<alexan...@alemayhu.com> wrote:
> On Thu, Jan 12, 2017 at 03:33:22PM +0200, Gilad Ben-Yossef wrote:
>> ah input processing uses the asynchrnous hash crypto API which
>> supplies an error code as part of the operation comple
in a memcpy of the digest failing anyway and thus the security
risk seems minor, performing a memory compare on what might be
uninitialized memory is wrong.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
The change was boot tested on Arm64 but I did not exercise
the specific error cod
On Fri, Jun 26, 2015 at 6:04 PM, Andrew Lunn and...@lunn.ch wrote:
On Thu, Jun 25, 2015 at 04:50:13PM +0300, gil...@ezchip.com wrote:
From: Gilad Ben-Yossef gi...@benyossef.com
DSA master netdev promiscuity counter was not being properly
decremented on slave device open error path
DSA master netdev promiscuity counter was not being properly
decremented on slave device open error path.
Signed-off-by: Gilad Ben-Yossef gi...@benyossef.com
CC: Gilad Ben-Yossef gil...@ezchip.com
CC: David S. Miller da...@davemloft.net
CC: Florian Fainelli f.faine...@gmail.com
CC: Guenter Roeck
Use the correct unregister function matching the register
function on the error path.
Signed-off-by: Gilad Ben-Yossef gi...@benyossef.com
CC: Gilad Ben-Yossef gil...@ezchip.com
CC: Scott Feldman sfel...@gmail.com
CC: Jiri Pirko j...@resnulli.us
---
drivers/net/ethernet/rocker/rocker.c |2
78 matches
Mail list logo
