On Mon, Aug 14, 2017 at 10:17:31AM +0000, David Laight wrote: > From: Jeff Kirsher >> Sent: 09 August 2017 22:48 >> From: Greg Edwards <gedwa...@ddn.com> >> >> This fixes a "scheduling while atomic" splat seen with >> CONFIG_DEBUG_ATOMIC_SLEEP enabled. >> >> Signed-off-by: Greg Edwards <gedwa...@ddn.com> >> Tested-by: Aaron Brown <aaron.f.br...@intel.com> >> Signed-off-by: Jeff Kirsher <jeffrey.t.kirs...@intel.com> >> --- >> drivers/net/ethernet/intel/igbvf/vf.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/intel/igbvf/vf.c >> b/drivers/net/ethernet/intel/igbvf/vf.c >> index 1d3aa9adcaa8..9577ccf4b26a 100644 >> --- a/drivers/net/ethernet/intel/igbvf/vf.c >> +++ b/drivers/net/ethernet/intel/igbvf/vf.c >> @@ -149,7 +149,7 @@ static s32 e1000_reset_hw_vf(struct e1000_hw *hw) >> msgbuf[0] = E1000_VF_RESET; >> mbx->ops.write_posted(hw, msgbuf, 1); >> >> - msleep(10); >> + mdelay(10); > > Spinning for 10ms seems somewhat sub-optimal
Jeff, Do we even need this delay? The subsequent read_posted() will poll for the PF's mailbox reply for up to 1s. Greg
