Re: [PATCH] SUNRPC: Add a check for gss_release_msg

2021-04-20 Thread Greg KH
On Tue, Apr 06, 2021 at 07:16:56PM -0500, Aditya Pakki wrote: > In gss_pipe_destroy_msg(), in case of error in msg, gss_release_msg > deletes gss_msg. The patch adds a check to avoid a potential double > free. > > Signed-off-by: Aditya Pakki > --- > net/sunrpc/auth_gss/auth_gss.c | 3 ++- > 1 fi

Re: [Resend RFC PATCH V2 08/12] UIO/Hyper-V: Not load UIO HV driver in the isolation VM.

2021-04-14 Thread Greg KH
On Wed, Apr 14, 2021 at 10:49:41AM -0400, Tianyu Lan wrote: > From: Tianyu Lan > > UIO HV driver should not load in the isolation VM for security reason. > Return ENOTSUPP in the hv_uio_probe() in the isolation VM. > > Signed-off-by: Tianyu Lan > --- > drivers/uio/uio_hv_generic.c | 5 + >

Re: [PATCH net] r8169: don't advertise pause in jumbo mode

2021-04-14 Thread Greg KH
On Wed, Apr 14, 2021 at 09:56:30AM +0200, Heiner Kallweit wrote: > On 14.04.2021 09:49, Greg KH wrote: > > On Wed, Apr 14, 2021 at 09:40:51AM +0200, Heiner Kallweit wrote: > >> It has been reported [0] that using pause frames in jumbo mode impacts > >> performance

Re: [PATCH net] r8169: don't advertise pause in jumbo mode

2021-04-14 Thread Greg KH
On Wed, Apr 14, 2021 at 09:40:51AM +0200, Heiner Kallweit wrote: > It has been reported [0] that using pause frames in jumbo mode impacts > performance. There's no available chip documentation, but vendor > drivers r8168 and r8125 don't advertise pause in jumbo mode. So let's > do the same, accordi

Re: [PATCH 1/2] kunit: Fix formatting of KUNIT tests to meet the standard

2021-04-13 Thread Greg KH
On Wed, Apr 14, 2021 at 12:33:02AM -0400, Nico Pache wrote: > There are few instances of KUNIT tests that are not properly defined. > This commit focuses on correcting these issues to match the standard > defined in the Documentation. > > Issues Fixed: > - Tests should default to KUNIT_ALL_TE

Re: [PATCH 1/2] kunit: Fix formatting of KUNIT tests to meet the standard

2021-04-13 Thread Greg KH
On Wed, Apr 14, 2021 at 12:33:02AM -0400, Nico Pache wrote: > There are few instances of KUNIT tests that are not properly defined. > This commit focuses on correcting these issues to match the standard > defined in the Documentation. > > Issues Fixed: > - Tests should default to KUNIT_ALL_TE

Re: flexcan introduced a DIV/0 in kernel

2021-04-09 Thread Greg KH
On Fri, Apr 09, 2021 at 03:10:01PM +0200, Marc Kleine-Budde wrote: > On 09.04.2021 14:55:59, Koen Vandeputte wrote: > > > > On 09.04.21 13:21, Marc Kleine-Budde wrote: > > > On 4/9/21 12:18 PM, Koen Vandeputte wrote: > > > > Hi All, > > > > > > > > I just updated kernel 4.14 within OpenWRT from 4

Re: flexcan introduced a DIV/0 in kernel

2021-04-09 Thread Greg KH
On Fri, Apr 09, 2021 at 01:21:05PM +0200, Marc Kleine-Budde wrote: > On 4/9/21 12:18 PM, Koen Vandeputte wrote: > > Hi All, > > > > I just updated kernel 4.14 within OpenWRT from 4.14.224 to 4.14.229 > > Booting it shows the splat below on each run. [1] > > > > > > It seems there are 2 patches r

Re: Re: [PATCH] backports: crypto user - make NETLINK_CRYPTO work

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 07:11:48PM +, Jianmin Wang wrote: > On Mon, Apr 05, 2021 at 16:14 UTC, Greg KH wrote: > > On Mon, Apr 05, 2021 at 01:55:15PM +, Jianmin Wang wrote: > > > There is same problem found in linux 4.19.y as upstream commit. The > > > c

Re: [PATCH 0/5] VDPA mlx5 fixes

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 12:10:42PM +0300, Eli Cohen wrote: > Hi Michael, > > The following series contains fixes to mlx5 vdpa driver. Included first > is Siwei's fix to queried MTU was already reviewed a while ago and is > not in your tree. > > Patches 2 and 3 are required to allow mlx5_vdpa run

Re: [PATCH] net: hso: fix null-ptr-deref during tty device unregistration

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 06:13:59PM +0530, Anirudh Rayabharam wrote: > Multiple ttys try to claim the same the minor number causing a double > unregistration of the same device. The first unregistration succeeds > but the next one results in a null-ptr-deref. > > The get_free_serial_index() functio

Re: [PATCH] net: hso: fix null-ptr-deref during tty device unregistration

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 06:13:59PM +0530, Anirudh Rayabharam wrote: > Multiple ttys try to claim the same the minor number causing a double > unregistration of the same device. The first unregistration succeeds > but the next one results in a null-ptr-deref. > > The get_free_serial_index() functio

Re: linux-next: manual merge of the tty tree with the net-next tree

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 06:48:14PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the tty tree got a conflict in: > > net/nfc/nci/uart.c > > between commit: > > d3295869c40c ("net: nfc: Fix spelling errors in net/nfc module") > > from the net-next tree and commit:

Re: [PATCH] backports: crypto user - make NETLINK_CRYPTO work inside netns

2021-04-05 Thread Greg KH
On Mon, Apr 05, 2021 at 01:55:15PM +, Jianmin Wang wrote: > There is same problem found in linux 4.19.y as upstream commit. The > changes of crypto_user_* and cryptouser.h files from upstream patch are > merged into > crypto/crypto_user.c for backporting. > > Upstream commit: > commit 9

Re: [PATCH net-next v8 2/2] net: Add Qcom WWAN control driver

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 05:41:01PM +0200, Loic Poulain wrote: > On Fri, 2 Apr 2021 at 16:05, Greg KH wrote: > > > > On Fri, Apr 02, 2021 at 04:06:37PM +0200, Loic Poulain wrote: > > > The MHI WWWAN control driver allows MHI QCOM-based modems to expose > > > differ

Re: [PATCH net-next v8 2/2] net: Add Qcom WWAN control driver

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 04:06:37PM +0200, Loic Poulain wrote: > The MHI WWWAN control driver allows MHI QCOM-based modems to expose > different modem control protocols/ports via the WWAN framework, so that > userspace modem tools or daemon (e.g. ModemManager) can control WWAN > config and state (AP

Re: [PATCH net-next v8 1/2] net: Add a WWAN subsystem

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 04:06:36PM +0200, Loic Poulain wrote: > This change introduces initial support for a WWAN framework. Given the > complexity and heterogeneity of existing WWAN hardwares and interfaces, > there is no strict definition of what a WWAN device is and how it should > be represente

Re: [PATCH net-next v6 1/2] net: Add a WWAN subsystem

2021-04-02 Thread Greg KH
On Wed, Mar 31, 2021 at 05:30:50PM +0200, Loic Poulain wrote: > > As it is, the code you have here just implements the misc device layer, > > but with a new major number? why??? > > Right, Instead of creating yet another specific character driver for > WWAN (like usb wdm_class), the goal would be

Re: [PATCH net-next v6 1/2] net: Add a WWAN subsystem

2021-03-31 Thread Greg KH
On Wed, Mar 31, 2021 at 01:35:04PM +0200, Loic Poulain wrote: > Hi Greg, > > On Wed, 31 Mar 2021 at 12:44, Greg KH wrote: > > > > On Wed, Mar 31, 2021 at 12:39:09PM +0200, Loic Poulain wrote: > > > This change introduces initial support for a WWAN subsystem.

Re: [PATCH net-next v6 1/2] net: Add a WWAN subsystem

2021-03-31 Thread Greg KH
On Wed, Mar 31, 2021 at 12:39:09PM +0200, Loic Poulain wrote: > This change introduces initial support for a WWAN subsystem. Given the > complexity and heterogeneity of existing WWAN hardwares and interfaces, > there is no strict definition of what a WWAN device is and how it should > be represente

Re: [PATCH v2] wireless/nl80211.c: fix uninitialized variable

2021-03-30 Thread Greg KH
On Tue, Mar 30, 2021 at 06:37:05PM +0200, Alaa Emad wrote: > This change fix KMSAN uninit-value in net/wireless/nl80211.c:225 , That > because of `fixedlen` variable uninitialized,So I initialized it by zero. > > Reported-by: syzbot+72b99dcf4607e8c77...@syzkaller.appspotmail.com > Signed-off-by:

Re: [PATCH] wireless/nl80211.c: fix uninitialized variable

2021-03-29 Thread Greg KH
On Mon, Mar 29, 2021 at 08:41:38PM +0200, Alaa Emad wrote: > On Mon, 29 Mar 2021 at 20:20, Greg KH wrote: > > > On Mon, Mar 29, 2021 at 06:30:36PM +0200, Alaa Emad wrote: > > > Reported-by: syzbot+72b99dcf4607e8c77...@syzkaller.appspotmail.com > > > Signed-off-by:

Re: [PATCH] wireless/nl80211.c: fix uninitialized variable

2021-03-29 Thread Greg KH
On Mon, Mar 29, 2021 at 06:30:36PM +0200, Alaa Emad wrote: > Reported-by: syzbot+72b99dcf4607e8c77...@syzkaller.appspotmail.com > Signed-off-by: Alaa Emad You need to provide some changelog text here, I know I can not take patches without that, maybe the wireless maintainer is more flexible :) t

Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-03-27 Thread Greg KH
On Fri, Mar 26, 2021 at 02:09:36PM -0700, Don Bollinger wrote: > > You keep missing the point. I always refer to the KAPI. The driver we can > > rework and rework, throw away and reimplement, as much as we want. > > The KAPI cannot be changed, it is ABI. It is pretty much frozen the day > the > > c

Re: [PATCH net-next] net: usb: pegasus: Remove duplicated include from pegasus.c

2021-03-25 Thread Greg KH
On Thu, Mar 25, 2021 at 10:56:52PM +0800, 'Qiheng Lin wrote: > From: Qiheng Lin > > Remove duplicated include. > > Reported-by: Hulk Robot > Signed-off-by: Qiheng Lin > --- > drivers/net/usb/pegasus.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/usb/pegasus.c b/drive

Re: [PATCH 0/4] nfc: fix Resource leakage and endless loop

2021-03-23 Thread Greg KH
On Wed, Mar 03, 2021 at 02:16:50PM +0800, Xiaoming Ni wrote: > fix Resource leakage and endless loop in net/nfc/llcp_sock.c, > reported by "kiyin(尹亮)". > > Link: https://www.openwall.com/lists/oss-security/2020/11/01/1 What happened to this series? Does it need to be resent against the latest n

Re: [PATCH stable 0/6] net: dsa: b53: Correct learning for standalone ports

2021-03-19 Thread Greg KH
On Tue, Mar 16, 2021 at 05:35:43PM -0700, Florian Fainelli wrote: > Hi Greg, Sasha, Jaakub and David, > > This patch series contains backports for a change that recently made it > upstream as f9b3827ee66cfcf297d0acd6ecf33653a5f297ef ("net: dsa: b53: > Support setting learning on port") however tha

Re: [PATCH stable 5.4.y, 4.19.y] net: dsa: tag_mtk: fix 802.1ad VLAN egress

2021-03-19 Thread Greg KH
On Thu, Mar 18, 2021 at 01:29:35PM +0800, DENG Qingfang wrote: > [ Upstream commit 9200f515c41f4cbaeffd8fdd1d8b6373a18b1b67 ] > > A different TPID bit is used for 802.1ad VLAN frames. > > Reported-by: Ilario Gelmetti > Fixes: f0af34317f4b ("net: dsa: mediatek: combine MediaTek tag with VLAN tag"

Re: [PATCH net V2 1/1] net: phy: fix invalid phy id when probe using C22

2021-03-18 Thread Greg KH
On Thu, Mar 18, 2021 at 09:02:22AM -0700, Florian Fainelli wrote: > > > On 3/18/2021 6:25 AM, Heiner Kallweit wrote: > > On 18.03.2021 10:09, Wong Vee Khee wrote: > >> When using Clause-22 to probe for PHY devices such as the Marvell > >> 88E2110, PHY ID with value 0 is read from the MII PHYID re

Re: [PATCH v10 00/20] dlb: introduce DLB device driver

2021-03-16 Thread Greg KH
On Mon, Mar 15, 2021 at 08:18:10PM +, Chen, Mike Ximing wrote: > > From: Dan Williams > > On Fri, Mar 12, 2021 at 1:55 PM Chen, Mike Ximing > > wrote: > > > > > > We support up to 16/32 VF/VDEVs (depending on version) with SRIOV and > > > SIOV. Role of the kernel driver includes VDEV Composi

Re: [BUG] net: rds: rds_send_probe memory leak

2021-03-14 Thread Greg KH
On Sun, Mar 14, 2021 at 03:19:05PM +0300, Fatih Yildirim wrote: > On Sun, 2021-03-14 at 09:36 +0100, Greg KH wrote: > > On Sun, Mar 14, 2021 at 11:23:10AM +0300, Fatih Yildirim wrote: > > > Hi Santosh, > > > > > > I've been working on a memory

Re: [BUG] net: rds: rds_send_probe memory leak

2021-03-14 Thread Greg KH
On Sun, Mar 14, 2021 at 11:23:10AM +0300, Fatih Yildirim wrote: > Hi Santosh, > > I've been working on a memory leak bug reported by syzbot. > https://syzkaller.appspot.com/bug?id=39b72114839a6dbd66c1d2104522698a813f9ae2 > > It seems that memory allocated in rds_send_probe function is not freed.

Re: [PATCH net-next v5 1/2] net: Add a WWAN subsystem

2021-03-12 Thread Greg KH
On Fri, Mar 12, 2021 at 12:11:50PM +0100, Loic Poulain wrote: > Hi Greg, > > On Fri, 12 Mar 2021 at 07:56, Greg KH wrote: > > > > On Thu, Mar 11, 2021 at 09:41:03PM +0100, Loic Poulain wrote: > > > This change introduces initial support for a WWAN subsystem.

Re: [PATCH net-next v5 2/2] net: Add Qcom WWAN control driver

2021-03-12 Thread Greg KH
On Thu, Mar 11, 2021 at 09:41:04PM +0100, Loic Poulain wrote: > The MHI WWWAN control driver allows MHI QCOM-based modems to expose > different modem control protocols/ports to userspace, so that userspace > modem tools or daemon (e.g. ModemManager) can control WWAN config > and state (APN config,

Re: [PATCH net-next v5 1/2] net: Add a WWAN subsystem

2021-03-11 Thread Greg KH
On Thu, Mar 11, 2021 at 09:41:03PM +0100, Loic Poulain wrote: > This change introduces initial support for a WWAN subsystem. Given the > complexity and heterogeneity of existing WWAN hardwares and interfaces, > there is no strict definition of what a WWAN device is and how it should > be represente

Re: [PATCH net-next v4 1/2] net: Add a WWAN subsystem

2021-03-11 Thread Greg KH
On Thu, Mar 11, 2021 at 05:39:05PM +0100, Loic Poulain wrote: > --- /dev/null > +++ b/drivers/net/wwan/Kconfig > @@ -0,0 +1,19 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# Wireless WAN device configuration > +# > + > +menuconfig WWAN > + bool "Wireless WAN" > + help > + Thi

Re: [PATCH net-next v4 1/2] net: Add a WWAN subsystem

2021-03-11 Thread Greg KH
On Thu, Mar 11, 2021 at 05:39:05PM +0100, Loic Poulain wrote: > This change introduces initial support for a WWAN subsystem. Given the > complexity and heterogeneity of existing WWAN hardwares and interfaces, > there is no strict definition of what a WWAN device is and how it should > be represente

Re: [PATCH] net: core: bpf_sk_storage.c: Fix bare usage of unsigned

2021-03-11 Thread Greg KH
On Thu, Mar 11, 2021 at 03:13:49PM +0530, Shubhankar Kuranagatti wrote: > Changed bare usage of unsigned to unsigned int That says _what_ you did, but not _why_ you did it :( thanks, greg k-h

Re: [PATCH net-next 00/15] dpaa2-switch: CPU terminated traffic and move out of staging

2021-03-10 Thread Greg KH
On Thu, Mar 11, 2021 at 08:04:29AM +0100, Greg KH wrote: > On Thu, Mar 11, 2021 at 08:54:37AM +0200, Ioana Ciornei wrote: > > On Wed, Mar 10, 2021 at 03:13:10PM -0800, David Miller wrote: > > > From: Greg KH > > > Date: Wed, 10 Mar 2021 15:12:57 +0100 > > >

Re: [PATCH net-next 00/15] dpaa2-switch: CPU terminated traffic and move out of staging

2021-03-10 Thread Greg KH
On Thu, Mar 11, 2021 at 08:54:37AM +0200, Ioana Ciornei wrote: > On Wed, Mar 10, 2021 at 03:13:10PM -0800, David Miller wrote: > > From: Greg KH > > Date: Wed, 10 Mar 2021 15:12:57 +0100 > > > > > Yes, either I can provide a stable tag to pull from for the netdev

Re: [PATCH net-next 00/15] dpaa2-switch: CPU terminated traffic and move out of staging

2021-03-10 Thread Greg KH
On Wed, Mar 10, 2021 at 03:47:44PM +0200, Ioana Ciornei wrote: > On Wed, Mar 10, 2021 at 01:44:46PM +0100, Greg KH wrote: > > On Wed, Mar 10, 2021 at 02:14:37PM +0200, Ioana Ciornei wrote: > > > From: Ioana Ciornei > > > > > > This patch set adds support fo

Re: [PATCH net-next 00/15] dpaa2-switch: CPU terminated traffic and move out of staging

2021-03-10 Thread Greg KH
On Wed, Mar 10, 2021 at 02:14:37PM +0200, Ioana Ciornei wrote: > From: Ioana Ciornei > > This patch set adds support for Rx/Tx capabilities on DPAA2 switch port > interfaces as well as fixing up some major blunders in how we take care > of the switching domains. The last patch actually moves the

Re: [PATCH v10 00/20] dlb: introduce DLB device driver

2021-03-10 Thread Greg KH
On Wed, Feb 10, 2021 at 11:54:03AM -0600, Mike Ximing Chen wrote: > Intel DLB is an accelerator for the event-driven programming model of > DPDK's Event Device Library[2]. The library is used in packet processing > pipelines that arrange for multi-core scalability, dynamic load-balancing, > and var

Re: [PATCH v10 14/20] dlb: add start domain ioctl

2021-03-10 Thread Greg KH
On Wed, Mar 10, 2021 at 02:45:10AM +, Chen, Mike Ximing wrote: > > > > -Original Message- > > From: Greg KH > > On Wed, Feb 10, 2021 at 11:54:17AM -0600, Mike Ximing Chen wrote: > > > > > > diff --git a/drivers/misc/dlb/dlb_ioctl.c

Re: [PATCH v10 03/20] dlb: add resource and device initialization

2021-03-10 Thread Greg KH
On Wed, Mar 10, 2021 at 01:33:24AM +, Chen, Mike Ximing wrote: > > > -Original Message- > > From: Greg KH > > > > On Wed, Feb 10, 2021 at 11:54:06AM -0600, Mike Ximing Chen wrote: > > > + > > > +#include "dlb_bitmap.h" &

Re: [PATCH net-next v3] net: Add Qcom WWAN control driver

2021-03-09 Thread Greg KH
On Tue, Mar 09, 2021 at 09:01:11AM -0700, Jeffrey Hugo wrote: > On 3/9/2021 3:33 AM, Greg KH wrote: > > On Tue, Mar 09, 2021 at 11:28:49AM +0100, Loic Poulain wrote: > > > Hi Greg, > > > > > > On Tue, 9 Mar 2021 at 10:35, Greg KH wrote: > > > >

Re: [PATCH net-next v3] net: Add Qcom WWAN control driver

2021-03-09 Thread Greg KH
On Tue, Mar 09, 2021 at 11:28:49AM +0100, Loic Poulain wrote: > Hi Greg, > > On Tue, 9 Mar 2021 at 10:35, Greg KH wrote: > > > > On Tue, Mar 09, 2021 at 09:42:16AM +0100, Loic Poulain wrote: > > > The MHI WWWAN control driver allows MHI Qcom based modems to expose

Re: [PATCH net-next v3] net: Add Qcom WWAN control driver

2021-03-09 Thread Greg KH
On Tue, Mar 09, 2021 at 09:42:16AM +0100, Loic Poulain wrote: > The MHI WWWAN control driver allows MHI Qcom based modems to expose > different modem control protocols/ports to userspace, so that userspace > modem tools or daemon (e.g. ModemManager) can control WWAN config > and state (APN config,

Re: [PATCH v10 03/20] dlb: add resource and device initialization

2021-03-09 Thread Greg KH
On Wed, Feb 10, 2021 at 11:54:06AM -0600, Mike Ximing Chen wrote: > --- a/drivers/misc/dlb/dlb_hw_types.h > +++ b/drivers/misc/dlb/dlb_hw_types.h > @@ -5,6 +5,13 @@ > #define __DLB_HW_TYPES_H > > #include > +#include > + > +#include "dlb_bitmap.h" > + > +#define BITS_SET(x, val, mask) (

Re: [PATCH v10 14/20] dlb: add start domain ioctl

2021-03-09 Thread Greg KH
On Wed, Feb 10, 2021 at 11:54:17AM -0600, Mike Ximing Chen wrote: > Add ioctl to start a domain. Once a scheduling domain and its resources > have been configured, this ioctl is called to allow the domain's ports to > begin enqueueing to the device. Once started, the domain's resources cannot > be

Re: [PATCH v10 05/20] dlb: add scheduling domain configuration

2021-03-09 Thread Greg KH
On Wed, Feb 10, 2021 at 11:54:08AM -0600, Mike Ximing Chen wrote: > +/** > + * dlb_bitmap_clear_range() - clear a range of bitmap entries > + * @bitmap: pointer to dlb_bitmap structure. > + * @bit: starting bit index. > + * @len: length of the range. > + * > + * Return: > + * Returns 0 upon success

Re: [PATCH v10 04/20] dlb: add device ioctl layer and first three ioctls

2021-03-09 Thread Greg KH
On Wed, Feb 10, 2021 at 11:54:07AM -0600, Mike Ximing Chen wrote: > +/* > + * DLB_CMD_CREATE_SCHED_DOMAIN: Create a DLB 2.0 scheduling domain and > reserve > + * its hardware resources. This command returns the newly created domain > + * ID and a file descriptor for accessing the domain. > + *

Re: [PATCH v2] bus: mhi: Add Qcom WWAN control driver

2021-03-09 Thread Greg KH
On Mon, Mar 08, 2021 at 09:59:27PM +0100, Loic Poulain wrote: > The MHI WWWAN control driver allows MHI Qcom based modems to expose > different modem control protocols to userspace, so that userspace > modem tools or daemon (e.g. ModemManager) can control WWAN config > and state (APN config, SMS, p

Re: [PATCH net] docs: networking: drop special stable handling

2021-03-03 Thread Greg KH
On Tue, Mar 02, 2021 at 06:46:43PM -0800, Jakub Kicinski wrote: > Leave it to Greg. > > Signed-off-by: Jakub Kicinski Acked-by: Greg Kroah-Hartman

Re: [PATCH stable 0/8] net: dsa: b53: Correct learning for standalone ports

2021-02-25 Thread Greg KH
On Thu, Feb 25, 2021 at 08:53:22AM -0800, Florian Fainelli wrote: > > > On 2/25/2021 12:15 AM, Greg KH wrote: > > On Wed, Feb 24, 2021 at 05:08:53PM -0800, Florian Fainelli wrote: > >> From: Florian Fainelli > >> > >> Hi Greg, Sasha, Jaakub and D

Re: [PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log message

2021-02-25 Thread Greg KH
On Thu, Feb 25, 2021 at 09:54:06AM +0900, Punit Agrawal wrote: > From: Corinna Vinschen > > commit 2643e6e90210e16c978919617170089b7c2164f7 upstream > > TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP > every 1100 secs on 80580/i350/i354 (40 bit SYSTIM) and every 35000 > secs

Re: [PATCH stable-5.9.y] net: dsa: b53: Correct learning for standalone ports

2021-02-25 Thread Greg KH
On Wed, Feb 24, 2021 at 05:09:54PM -0800, Florian Fainelli wrote: > Standalone ports should not have learning enabled since all the frames > are always copied to the CPU port. This is particularly important in > case an user-facing port intentionally spoofs the CPU port's MAC > address. With learni

Re: [PATCH stable 0/8] net: dsa: b53: Correct learning for standalone ports

2021-02-25 Thread Greg KH
On Wed, Feb 24, 2021 at 05:08:53PM -0800, Florian Fainelli wrote: > From: Florian Fainelli > > Hi Greg, Sasha, Jaakub and David, > > This patch series contains backports for a change that recently made it > upstream as: > > commit f3f9be9c58085d11f4448ec199bf49dc2f9b7fb9 > Merge: 18755e270666 f

Re: Stable request: iwlwifi: mvm: don't send RFH_QUEUE_CONFIG_CMD with no queues

2021-02-08 Thread Greg KH
On Sun, Feb 07, 2021 at 09:19:07AM -0500, Jason Andryuk wrote: > Hi, > > commit 64f55156f7adedb1ac5bb9cdbcbc9ac05ff5a724 upstream > > The requested patch allows the iwlwifi driver to work with newer AX200 > wifi cards when MSI-X interrupts are not available. Without it, > bringing an interface "

Re: Where is this patch buried?

2021-02-08 Thread Greg KH
On Mon, Feb 08, 2021 at 09:24:11AM +, Schmid, Carsten wrote: > >> Hi Greg, > >> > >> in kernel 4.14 i have seen a NULL pointer deref in > >> [65064.613465] RIP: 0010:ip_route_output_key_hash_rcu+0x755/0x850 > >> (i have a core dump and detailed analysis) > >> > >> That looks like this patch cou

Re: Where is this patch buried?

2021-02-08 Thread Greg KH
On Mon, Feb 08, 2021 at 08:12:29AM +, Schmid, Carsten wrote: > Hi Greg, > > in kernel 4.14 i have seen a NULL pointer deref in > [65064.613465] RIP: 0010:ip_route_output_key_hash_rcu+0x755/0x850 > (i have a core dump and detailed analysis) > > That looks like this patch could have prevented i

Re: [PATCH v1 1/1] Firstly, as Andy mentioned, this should be smp_rmb() instead of rmb(). considering that TSYNC is a cross-thread situation, and rmb() is a mandatory barrier which should not be used

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 06:13:07PM +0800, wanghongzhe wrote: > Secondly, the smp_rmb() should be put between reading SYSCALL_WORK_SECCOMP > and reading Your subject line of the patch is a bit odd :)

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-01 Thread Greg KH
On Mon, Feb 01, 2021 at 04:25:49PM +0530, Manivannan Sadhasivam wrote: > Hi Greg, > > On Wed, Jan 27, 2021 at 04:15:42PM +0100, Greg KH wrote: > > On Wed, Jan 13, 2021 at 08:56:25PM +0530, Manivannan Sadhasivam wrote: > > > Hi Greg, > > > > > > On Wed

Re: [PATCH stable v5.4 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2021-01-30 Thread Greg KH
On Sat, Jan 30, 2021 at 05:24:52PM +0530, Aviraj CJ wrote: > From: Hangbin Liu > > commit 2efdaaaf883a143061296467913c01aa1ff4b3ce upstream. > > Based on RFC 8200, Section 4.5 Fragment Header: > > - If the first fragment does not include all headers through an > Upper-Layer header, then

Re: [Internal review][PATCH stable v5.4 1/2] ICMPv6: Add ICMPv6 Parameter Problem, code 3 definition

2021-01-30 Thread Greg KH
On Sat, Jan 30, 2021 at 11:31:11AM +, Aviraj Cj (acj) wrote: > > > On 30/01/21, 2:06 PM, "Greg KH" wrote: > > On Sat, Jan 30, 2021 at 12:57:40AM +0530, Aviraj CJ wrote: > > From: Hangbin Liu > > > > commit b59e286be280fa3c2e94a0716ddcee6ba

Re: [Internal review][PATCH stable v5.4 1/2] ICMPv6: Add ICMPv6 Parameter Problem, code 3 definition

2021-01-30 Thread Greg KH
On Sat, Jan 30, 2021 at 12:57:40AM +0530, Aviraj CJ wrote: > From: Hangbin Liu > > commit b59e286be280fa3c2e94a0716ddcee6ba02bc8ba upstream. > > Based on RFC7112, Section 6: > >IANA has added the following "Type 4 - Parameter Problem" message to >the "Internet Control Message Protocol v

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-01-27 Thread Greg KH
On Wed, Jan 13, 2021 at 08:56:25PM +0530, Manivannan Sadhasivam wrote: > Hi Greg, > > On Wed, Jan 06, 2021 at 10:44:13AM -0800, Hemant Kumar wrote: > > This patch series adds support for UCI driver. UCI driver enables userspace > > clients to communicate to external MHI devices like modem. UCI dri

Re: [PATCH net-next 1/2] net: usb: qmi_wwan: add qmap id sysfs file for qmimux interfaces

2021-01-27 Thread Greg KH
On Mon, Jan 25, 2021 at 04:22:34PM +0100, Daniele Palmas wrote: > Add qmimux interface sysfs file qmap/mux_id to show qmap id set > during the interface creation, in order to provide a method for > userspace to associate QMI control channels to network interfaces. > > Signed-off-by: Daniele Palmas

Re: Duplicate crash reports related with smsc75xx/smsc95xx and root cause analysis

2021-01-23 Thread Greg KH
On Sat, Jan 23, 2021 at 01:40:30PM +0800, 慕冬亮 wrote: > Dear kernel developers, > > I found that on the syzbot dashboard, “KMSAN: uninit-value in > smsc75xx_read_eeprom (2)” [1], > "KMSAN: uninit-value in smsc95xx_read_eeprom (2)" [2], "KMSAN: > uninit-value in smsc75xx_bind" [3], > "KMSAN: uninit-

Re: "KMSAN: uninit-value in rt2500usb_bbp_read" and "KMSAN: uninit-value in rt2500usb_probe_hw" should be duplicate crash reports

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 04:47:37PM +0800, 慕冬亮 wrote: > Dear kernel developers, > > I found that on the syzbot dashboard, “KMSAN: uninit-value in > rt2500usb_bbp_read” [1] and "KMSAN: uninit-value in > rt2500usb_probe_hw" [2] should share the same root cause. > > ## Duplication > > The reasons fo

Re: [PATCH] rt2x00: reset reg earlier in rt2500usb_register_read

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 06:52:46PM +0800, Dongliang Mu wrote: > In the function rt2500usb_register_read(_lock), reg is uninitialized > in some situation. Then KMSAN reports uninit-value at its first memory > access. To fix this issue, initialize reg with zero in the function > rt2500usb_register_re

Re: [PATCH] rt2x00: reset reg earlier in rt2500usb_register_read

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 06:59:08PM +0800, 慕冬亮 wrote: > On Thu, Jan 21, 2021 at 5:49 PM Greg KH wrote: > > > > On Thu, Jan 21, 2021 at 05:20:26PM +0800, Dongliang Mu wrote: > > > In the function rt2500usb_register_read(_lock), reg is uninitialized > > > in some sit

Re: [PATCH] rt2x00: reset reg earlier in rt2500usb_register_read

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 06:59:08PM +0800, 慕冬亮 wrote: > > > rt2x00usb_vendor_request_buff(rt2x00dev, USB_MULTI_READ, > > > USB_VENDOR_REQUEST_IN, offset, > > > ®, sizeof(reg)); > > > > Are you sure this is valid to call th

Re: [PATCH] rt2x00: reset reg earlier in rt2500usb_register_read

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 05:20:26PM +0800, Dongliang Mu wrote: > In the function rt2500usb_register_read(_lock), reg is uninitialized > in some situation. Then KMSAN reports uninit-value at its first memory > access. To fix this issue, add one reg initialization in the function > rt2500usb_register_

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-01-19 Thread Greg KH
On Tue, Jan 19, 2021 at 03:12:50PM +0530, Manivannan Sadhasivam wrote: > Hi Greg, > > On Wed, Jan 13, 2021 at 08:56:25PM +0530, Manivannan Sadhasivam wrote: > > Hi Greg, > > > > On Wed, Jan 06, 2021 at 10:44:13AM -0800, Hemant Kumar wrote: > > > This patch series adds support for UCI driver. UCI

Re: [PATCH mlx5-next v1 2/5] PCI: Add SR-IOV sysfs entry to read number of MSI-X vectors

2021-01-18 Thread Greg KH
On Sun, Jan 10, 2021 at 05:07:24PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > Some SR-IOV capable devices provide an ability to configure specific > number of MSI-X vectors on their VF prior driver is probed on that VF. > > In order to make management easy, provide new read-only s

Re: [PATCH] nt: usb: USB_RTL8153_ECM should not default to y

2021-01-13 Thread Greg KH
On Wed, Jan 13, 2021 at 03:43:09PM +0100, Geert Uytterhoeven wrote: > In general, device drivers should not be enabled by default. > > Fixes: 657bc1d10bfc23ac ("r8153_ecm: avoid to be prior to r8152 driver") > Signed-off-by: Geert Uytterhoeven > --- > drivers/net/usb/Kconfig | 1 - > 1 file chan

Re: [PATCH v3] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-11 Thread Greg KH
On Tue, Jan 12, 2021 at 01:36:29PM +0800, Cindy Lu wrote: > In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. > this cb.private will finally use in vhost_vdpa_config_cb as > vhost_vdpa. Fix this issue. > > Fixes: 776f395004d82 ("vhost_vdpa: Support config interrupt in vdpa") > Ac

Re: [PATCH v2] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-11 Thread Greg KH
On Tue, Jan 12, 2021 at 01:32:27PM +0800, Cindy Lu wrote: > In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. > this cb.private will finally use in vhost_vdpa_config_cb as > vhost_vdpa. Fix this issue. > > Signed-off-by: Cindy Lu > --- > drivers/vhost/vdpa.c | 2 +- > 1 file ch

Re: [RESEND PATCH 2/2] misc: add support for retimers interfaces on Intel MAX 10 BMC

2021-01-07 Thread Greg KH
On Fri, Jan 08, 2021 at 10:05:26AM +0800, Xu Yilun wrote: > On Thu, Jan 07, 2021 at 10:26:12AM +0100, Greg KH wrote: > > On Thu, Jan 07, 2021 at 02:07:08PM +0800, Xu Yilun wrote: > > > This driver supports the ethernet retimers (C827) for the Intel PAC > > > (Programmab

Re: [PATCH] neighbour: Disregard DEAD dst in neigh_update

2021-01-07 Thread Greg KH
On Thu, Jan 07, 2021 at 09:36:37PM -0500, Your Real Name wrote: > On Tue, Jan 05, 2021 at 04:05:21PM -0800, David Miller wrote: > > > > > > From: Tong Zhu > > Date: Wed, 30 Dec 2020 17:54:23 -0500 > > > > > In 4.x kernel a dst in DST_OBSOLETE_DEAD state is associated > > > with loopback net_de

Re: [RESEND PATCH 2/2] misc: add support for retimers interfaces on Intel MAX 10 BMC

2021-01-07 Thread Greg KH
On Thu, Jan 07, 2021 at 02:07:08PM +0800, Xu Yilun wrote: > This driver supports the ethernet retimers (C827) for the Intel PAC > (Programmable Acceleration Card) N3000, which is a FPGA based Smart NIC. > > C827 is an Intel(R) Ethernet serdes transceiver chip that supports > up to 100G transfer. O

Re: [PATCH 2/2] ethernet: igb: e1000_phy: Check for ops.force_speed_duplex existence

2021-01-05 Thread Greg KH
On Tue, Jan 05, 2021 at 06:16:59PM +0100, Paul Menzel wrote: > Dear Jakub, dear Greg, > > > Am 03.11.20 um 19:39 schrieb Jakub Kicinski: > > On Tue, 3 Nov 2020 08:35:09 +0100 Paul Menzel wrote: > > > According to *Developer's Certificate of Origin 1.1* [3], it’s my > > > understanding, that it is

Re: [PATCH] staging: qlge: Removed duplicate word in comment.

2020-12-28 Thread Greg KH
On Fri, Dec 18, 2020 at 05:48:29PM -0800, Daniel West wrote: > This patch fixes the checkpatch warning: > > WARNING: Possible repeated word: 'and' > > Signed-off-by: Daniel West signed-off-by does not match From: line, so I can't take this :( Please fix up and resend. thanks, greg k-h

Re: [PATCH] CDC-NCM: remove "connected" log message

2020-12-23 Thread Greg KH
On Wed, Dec 23, 2020 at 07:21:16PM -0800, Roland Dreier wrote: > The cdc_ncm driver passes network connection notifications up to > usbnet_link_change(), which is the right place for any logging. > Remove the netdev_info() duplicating this from the driver itself. > > This stops devices such as my

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-17 Thread Greg KH
On Thu, Dec 17, 2020 at 10:19:37PM +0100, Alexandre Belloni wrote: > Hello, > > On 05/12/2020 16:51:36+0100, Greg KH wrote: > > > To me, the documentation was written, and reviewed, more from the > > > perspective of "why not open code a custom bus instead".

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-12-13 Thread Greg KH
On Sun, Dec 13, 2020 at 03:58:20PM +0100, Miguel Ojeda wrote: > > The key here is "if nobody complains". I would argue that it is _your_ > > responsibility to do those builds, and not the reponsibility of others > > to do it for you. > > Testing allmodconfig for a popular architecture, agreed, it

Re: [PATCH v17 3/3] bus: mhi: Add userspace client interface driver

2020-12-10 Thread Greg KH
On Thu, Dec 10, 2020 at 11:04:11PM -0800, Hemant Kumar wrote: > This MHI client driver allows userspace clients to transfer > raw data between MHI device and host using standard file operations. > Driver instantiates UCI device object which is associated to device > file node. UCI device object ins

Re: [PATCH v16 4/4] bus: mhi: Add userspace client interface driver

2020-12-10 Thread Greg KH
On Wed, Dec 09, 2020 at 11:21:25PM -0800, Hemant Kumar wrote: > This MHI client driver allows userspace clients to transfer > raw data between MHI device and host using standard file operations. > Driver instantiates UCI device object which is associated to device > file node. UCI device object ins

Re: [PATCH net-next] tcp: optimise receiver buffer autotuning initialisation for high latency connections

2020-12-07 Thread Greg KH
On Mon, Dec 07, 2020 at 04:34:57PM +, Mohamed Abuelfotoh, Hazem wrote: > 100ms RTT > > >Which exact version of linux kernel are you using ? > On the receiver side I could see the issue with any mainline kernel > version >=4.19.86 which is the first kernel version that has patches > [1] & [2] i

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-05 Thread Greg KH
On Fri, Dec 04, 2020 at 08:41:09AM -0800, Dan Williams wrote: > On Fri, Dec 4, 2020 at 3:41 AM Greg KH wrote: > > > > On Wed, Dec 02, 2020 at 04:54:24PM -0800, Dan Williams wrote: > > > From: Dave Ertman > > > > > > Add support for the Auxiliary

Re: [PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage

2020-12-05 Thread Greg KH
On Sat, Dec 05, 2020 at 01:20:18PM +0200, Vladimir Oltean wrote: > On Wed, Dec 02, 2020 at 01:49:53PM +0100, Enrico Weigelt, metux IT consult > wrote: > > Remove MODULE_VERSION(), as it isn't needed at all: the only version > > making sense is the kernel version. > > > > Signed-off-by: Enrico Weig

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-05 Thread Greg KH
On Fri, Dec 04, 2020 at 09:10:34AM -0800, Ranjani Sridharan wrote: > On Fri, 2020-12-04 at 13:59 +0100, Greg KH wrote: > > On Fri, Dec 04, 2020 at 02:32:07PM +0200, Leon Romanovsky wrote: > > > On Fri, Dec 04, 2020 at 12:42:46PM +0100, Greg KH wrote: > > > > On W

Re: [PATCH 04/11] drivers: staging: goldfish: remove unneeded MODULE_VERSION() call

2020-12-04 Thread Greg KH
On Thu, Dec 03, 2020 at 01:47:56PM +0100, Enrico Weigelt, metux IT consult wrote: > Remove MODULE_VERSION(), as it doesn't seem to have much practical purpose. > For in-kernel drivers, the kernel version matters. The driver received lots > of changes, but version number has remained the same since

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-04 Thread Greg KH
On Fri, Dec 04, 2020 at 02:32:07PM +0200, Leon Romanovsky wrote: > On Fri, Dec 04, 2020 at 12:42:46PM +0100, Greg KH wrote: > > On Wed, Dec 02, 2020 at 04:54:24PM -0800, Dan Williams wrote: > > > From: Dave Ertman > > > > > > Add support for the

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-04 Thread Greg KH
On Wed, Dec 02, 2020 at 04:54:24PM -0800, Dan Williams wrote: > From: Dave Ertman > > Add support for the Auxiliary Bus, auxiliary_device and auxiliary_driver. > It enables drivers to create an auxiliary_device and bind an > auxiliary_driver to it. > > The bus supports probe/remove shutdown and

[PATCH v2 3/3] driver core: auxiliary bus: minor coding style tweaks

2020-12-04 Thread Greg KH
From: Greg Kroah-Hartman For some reason, the original aux bus patch had some really long lines in a few places, probably due to it being a very long-lived patch in development by many different people. Fix that up so that the two files all have the same length lines and function formatting styl

Re: [PATCH 3/3] driver core: auxiliary bus: minor coding style tweaks

2020-12-04 Thread Greg KH
On Fri, Dec 04, 2020 at 12:44:24PM +0100, Greg KH wrote: > From: Greg Kroah-Hartman > > For some reason, the original aux bus patch had some really long lines > in a few places, probably due to it being a very long-lived patch in > development by many different people. Fix that

[PATCH 3/3] driver core: auxiliary bus: minor coding style tweaks

2020-12-04 Thread Greg KH
From: Greg Kroah-Hartman For some reason, the original aux bus patch had some really long lines in a few places, probably due to it being a very long-lived patch in development by many different people. Fix that up so that the two files all have the same length lines and function formatting styl

[PATCH 2/3] driver core: auxiliary bus: make remove function return void

2020-12-04 Thread Greg KH
From: Greg Kroah-Hartman There's an effort to move the remove() callback in the driver core to not return an int, as nothing can be done if this function fails. To make that effort easier, make the aux bus remove function void to start with so that no users have to be changed sometime in the fut

  1   2   3   4   5   6   7   8   >