Re: [PATCH net-next] virtio-net: restrict build_skb() use to some arches

2021-04-20 Thread Guenter Roeck
56b16ad ("virtio-net: page_to_skb() use build_skb when there's > sufficient tailroom") > Signed-off-by: Eric Dumazet > Reported-by: Guenter Roeck > Cc: Xuan Zhuo > Cc: Jason Wang > Cc: "Michael S. Tsirkin" > Cc: virtualizat...@lists.linux-foundation.org Tested-by: Guenter Roeck on alpha, sh4 (little endian). Thanks! Guenter

Re: [PATCH net-next] virtio-net: fix use-after-free in page_to_skb()

2021-04-20 Thread Guenter Roeck
On 4/20/21 9:31 AM, Eric Dumazet wrote: > On Tue, Apr 20, 2021 at 5:42 PM Guenter Roeck wrote: >> >> On Tue, Apr 20, 2021 at 04:00:07PM +0200, Eric Dumazet wrote: >>> On Tue, Apr 20, 2021 at 3:48 PM Guenter Roeck wrote: >>>> >>

Re: [PATCH net-next] virtio-net: fix use-after-free in page_to_skb()

2021-04-20 Thread Guenter Roeck
On Tue, Apr 20, 2021 at 04:00:07PM +0200, Eric Dumazet wrote: > On Tue, Apr 20, 2021 at 3:48 PM Guenter Roeck wrote: > > > > On 4/20/21 2:43 AM, Eric Dumazet wrote: > > > > > > > > Unfortunately that doesn't fix the problem for me. With this patch appl

Re: [PATCH net-next] virtio-net: fix use-after-free in page_to_skb()

2021-04-20 Thread Guenter Roeck
gt; common_interrupt+0xa4/0xd0 arch/x86/kernel/irq.c:240 > > Fixes: fb32856b16ad ("virtio-net: page_to_skb() use build_skb when there's > sufficient tailroom") > Signed-off-by: Eric Dumazet > Reported-by: syzbot > Reported-by: Guenter Roeck > Reported-by: Mat Marti

Re: [net-next, v2] virtio-net: page_to_skb() use build_skb when there's sufficient tailroom

2021-04-19 Thread Guenter Roeck
On Wed, Apr 14, 2021 at 09:52:21AM +0800, Xuan Zhuo wrote: > In page_to_skb(), if we have enough tailroom to save skb_shared_info, we > can use build_skb to create skb directly. No need to alloc for > additional space. And it can save a 'frags slot', which is very friendly > to GRO. > > Here, if t

Re: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

2021-04-19 Thread Guenter Roeck
On 4/18/21 9:27 PM, Alice Guo (OSS) wrote: > From: Alice Guo > > Update all the code that use soc_device_match because add support for > soc_device_match returning -EPROBE_DEFER. > > Signed-off-by: Alice Guo > --- [ ... ] > drivers/watchdog/renesas_wdt.c| 2 +- > 48 files chan

Re: [PATCH net] gro: ensure frag0 meets IP header alignment

2021-04-13 Thread Guenter Roeck
On 4/13/21 5:41 AM, Eric Dumazet wrote: > From: Eric Dumazet > > After commit 0f6925b3e8da ("virtio_net: Do not pull payload in skb->head") > Guenter Roeck reported one failure in his tests using sh architecture. > > After much debugging, we have been able to spot

Re: Linux 5.12-rc7

2021-04-12 Thread Guenter Roeck
On 4/12/21 10:38 AM, Eric Dumazet wrote: [ ... ] > Yes, I think this is the real issue here. This smells like some memory > corruption. > > In my traces, packet is correctly received in AF_PACKET queue. > > I have checked the skb is well formed. > > But the user space seems to never call poll()

Re: Linux 5.12-rc7

2021-04-12 Thread Guenter Roeck
On 4/12/21 9:31 AM, Eric Dumazet wrote: > On Mon, Apr 12, 2021 at 6:28 PM Linus Torvalds > wrote: >> >> On Sun, Apr 11, 2021 at 10:14 PM Guenter Roeck wrote: >>> >>> Qemu test results: >>> total: 460 pass: 459 fail: 1 >>> Failed

Re: [PATCH net] virtio_net: Do not pull payload in skb->head

2021-04-11 Thread Guenter Roeck
Hi Eric, On Mon, Apr 12, 2021 at 07:53:43AM +0200, Eric Dumazet wrote: > On Mon, Apr 12, 2021 at 7:48 AM Eric Dumazet wrote: > > > > > give a verdict. > > > > Please post the whole strace output. > > > > Thanks. > > Also please add -tt option to strace so that we have an idea of time > delays j

Re: [PATCH net] virtio_net: Do not pull payload in skb->head

2021-04-11 Thread Guenter Roeck
On 4/11/21 2:43 PM, Eric Dumazet wrote: > On Sun, Apr 11, 2021 at 11:32 PM Guenter Roeck wrote: >> >> On 4/11/21 2:23 PM, Eric Dumazet wrote: >>> On Sun, Apr 11, 2021 at 10:37 PM Guenter Roeck wrote: >>>> >>>> On 4/11/21 8:06 AM, Eric Dumazet wrot

Re: [PATCH net] virtio_net: Do not pull payload in skb->head

2021-04-11 Thread Guenter Roeck
On 4/11/21 2:43 PM, Eric Dumazet wrote: > On Sun, Apr 11, 2021 at 11:32 PM Guenter Roeck wrote: >> >> On 4/11/21 2:23 PM, Eric Dumazet wrote: >>> On Sun, Apr 11, 2021 at 10:37 PM Guenter Roeck wrote: >>>> >>>> On 4/11/21 8:06 AM, Eric Dumazet wrot

Re: [PATCH net] virtio_net: Do not pull payload in skb->head

2021-04-11 Thread Guenter Roeck
On 4/11/21 2:23 PM, Eric Dumazet wrote: > On Sun, Apr 11, 2021 at 10:37 PM Guenter Roeck wrote: >> >> On 4/11/21 8:06 AM, Eric Dumazet wrote: >>> On Sun, Apr 11, 2021 at 3:43 PM Guenter Roeck wrote: >>> >>>> This patch causes a virtio-net interface

Re: [PATCH net] virtio_net: Do not pull payload in skb->head

2021-04-11 Thread Guenter Roeck
On 4/11/21 8:06 AM, Eric Dumazet wrote: > On Sun, Apr 11, 2021 at 3:43 PM Guenter Roeck wrote: > >> This patch causes a virtio-net interface failure when booting sh4 images >> in qemu. The test case is nothing special: Just try to get an IP address >> using udhcpc. If

Re: [PATCH net] virtio_net: Do not pull payload in skb->head

2021-04-11 Thread Guenter Roeck
Hi, On Fri, Apr 02, 2021 at 06:26:02AM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > Xuan Zhuo reported that commit 3226b158e67c ("net: avoid 32 x truesize > under-estimation for tiny skbs") brought a ~10% performance drop. > > The reason for the performance drop was that GRO was forced

Re: [PATCH v3 08/15] arm64: socfpga: merge Agilex and N5X into ARCH_INTEL_SOCFPGA

2021-04-06 Thread Guenter Roeck
On Thu, Mar 11, 2021 at 04:25:38PM +0100, Krzysztof Kozlowski wrote: > Agilex, N5X and Stratix 10 share all quite similar arm64 hard cores and > SoC-part. Up to a point that N5X uses the same DTSI as Agilex. From > the Linux kernel point of view these are flavors of the same > architecture so the

[PATCH] pcnet32: Use pci_resource_len to validate PCI resource

2021-04-05 Thread Guenter Roeck
0x-0x001f] ... pcnet32: card has no PCI IO resources, aborting Use pci_resouce_len() instead. Signed-off-by: Guenter Roeck --- drivers/net/ethernet/amd/pcnet32.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers

Re: [PATCH] ptp_qoriq: fix overflow in ptp_qoriq_adjfine() u64 calcalation

2021-03-25 Thread Guenter Roeck
On Thu, Mar 25, 2021 at 03:23:07AM -0700, Guenter Roeck wrote: > On Tue, Mar 23, 2021 at 04:02:29PM +0800, Yangbo Lu wrote: > > Current calculation for diff of TMR_ADD register value may have > > 64-bit overflow in this code line, when long type scaled_ppm is > > large. >

Re: [PATCH] ptp_qoriq: fix overflow in ptp_qoriq_adjfine() u64 calcalation

2021-03-25 Thread Guenter Roeck
On Tue, Mar 23, 2021 at 04:02:29PM +0800, Yangbo Lu wrote: > Current calculation for diff of TMR_ADD register value may have > 64-bit overflow in this code line, when long type scaled_ppm is > large. > > adj *= scaled_ppm; > > This patch is to resolve it by using mul_u64_u64_div_u64(). > > Signe

Re: [PATCH v2 net-next 2/2] net: socket: change MSG_CMSG_COMPAT to BIT(21)

2021-03-21 Thread Guenter Roeck
cvmsg functions: > > static int packet_recvmsg(struct socket *sock, struct msghdr *msg, > size_t len, > int flags) > > If MSG_CMSG_COMPAT is set in 'flags', it's value will be negative. > Once it perform bit o

Re: [PATCH v2 net-next 1/2] net: socket: use BIT() for MSG_*

2021-03-21 Thread Guenter Roeck
On 3/21/21 6:43 AM, menglong8.d...@gmail.com wrote: > From: Menglong Dong > > The bit mask for MSG_* seems a little confused here. Replace it > with BIT() to make it clear to understand. > > Signed-off-by: Menglong Dong With this patch sent as patch 1/2, any code trying to bisect a compat rela

Re: [PATCH] watchdog: Remove MV64x60 watchdog driver

2021-03-18 Thread Guenter Roeck
Christophe Leroy Reviewed-by: Guenter Roeck > --- > drivers/watchdog/Kconfig | 4 - > drivers/watchdog/Makefile | 1 - > drivers/watchdog/mv64x60_wdt.c | 324 - > include/linux/mv643xx.h| 8 - > 4 files changed, 337 de

Re: [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG_*

2021-03-17 Thread Guenter Roeck
On Wed, Mar 17, 2021 at 09:53:23PM +0800, Menglong Dong wrote: > On Wed, Mar 17, 2021 at 5:36 PM Andy Shevchenko > wrote: > > > ... > > > > The problematic code is negation of the flags when it's done in > > operations like &. > > It maybe fixed by swapping positions of the arguments, i.e. ~(FOO |

Re: [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG_*

2021-03-17 Thread Guenter Roeck
On 3/17/21 2:40 AM, Andy Shevchenko wrote: > On Wed, Mar 17, 2021 at 11:36 AM Andy Shevchenko > wrote: >> On Wed, Mar 17, 2021 at 10:21 AM Menglong Dong >> wrote: > > ... > >> It maybe fixed by swapping positions of the arguments, i.e. ~(FOO | >> BAR) & flags. > > ...and type casting will be

Re: [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG_*

2021-03-16 Thread Guenter Roeck
On Wed, Mar 17, 2021 at 01:02:51AM +0200, Andy Shevchenko wrote: > On Wednesday, March 17, 2021, Guenter Roeck wrote: > > > Hi, > > > > On Tue, Mar 09, 2021 at 05:51:35PM -0800, menglong8.d...@gmail.com wrote: > > > From: Menglong Dong > > > > >

Re: [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG_*

2021-03-16 Thread Guenter Roeck
On 3/16/21 4:02 PM, Andy Shevchenko wrote: > > > On Wednesday, March 17, 2021, Guenter Roeck <mailto:li...@roeck-us.net>> wrote: > > Hi, > > On Tue, Mar 09, 2021 at 05:51:35PM -0800, menglong8.d...@gmail.com > <mailto:menglong8.d...@gmail.com

Re: [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG_*

2021-03-16 Thread Guenter Roeck
Hi, On Tue, Mar 09, 2021 at 05:51:35PM -0800, menglong8.d...@gmail.com wrote: > From: Menglong Dong > > The bit mask for MSG_* seems a little confused here. Replace it > with BIT() to make it clear to understand. > > Signed-off-by: Menglong Dong I must admit that I am a bit puzzled, but with

Re: [net-next V2 12/17] net/mlx5e: Extract tc tunnel encap/decap code to dedicated file

2021-02-09 Thread Guenter Roeck
On Fri, Feb 05, 2021 at 09:02:35PM -0800, Saeed Mahameed wrote: > From: Vlad Buslov > > Following patches in series extend the extracted code with routing > infrastructure. To improve code modularity created a dedicated > tc_tun_encap.c source file and move encap/decap related code to the new > f

Re: [PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart

2021-02-08 Thread Guenter Roeck
On Tue, Dec 15, 2020 at 10:53:52PM +0530, Youghandhar Chintala wrote: > Currently in case of target hardware restart, we just reconfig and > re-enable the security keys and enable the network queues to start > data traffic back from where it was interrupted. > > Many ath10k wifi chipsets have sequ

Re: [PATCH v1 2/2] mei: bus: change remove callback to return void

2021-02-07 Thread Guenter Roeck
rs/misc/mei/bus.c | 5 ++--- > drivers/misc/mei/hdcp/mei_hdcp.c | 7 +-- > drivers/nfc/microread/mei.c | 4 +--- > drivers/nfc/pn544/mei.c | 4 +--- > drivers/watchdog/mei_wdt.c | 4 +--- Acked-by: Guenter Roeck > include/linux/mei_cl_bus.h

Re: [PATCH] net: fec: Silence M5272 build warnings

2021-02-02 Thread Guenter Roeck
gt; dev_get_platdata(&fep->pdev->dev); > |^ > > Fix this by moving the variable declarations inside the existing #ifdef > blocks. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Guenter Roeck > --- > drivers/net/eth

Re: [PATCH] dt-bindings: Cleanup standard unit properties

2021-01-28 Thread Guenter Roeck
fined an enum of arrays. While a valid > schema, it is simpler as a whole to only define scalar constraints. > > Cc: Jean Delvare > Cc: Guenter Roeck > Cc: Jonathan Cameron > Cc: Lars-Peter Clausen > Cc: Alexandre Torgue > Cc: Dmitry Torokhov > Cc: Ulf Hansson >

Re: [PATCH 01/10] MIPS: TX49xx: Drop support

2021-01-05 Thread Guenter Roeck
| 2 +- Acked-by: Guenter Roeck Guenter

Re: [patch 02/30] genirq: Move status flag checks to core

2020-12-27 Thread Guenter Roeck
On Thu, Dec 10, 2020 at 08:25:38PM +0100, Thomas Gleixner wrote: > These checks are used by modules and prevent the removal of the export of > irq_to_desc(). Move the accessor into the core. > > Signed-off-by: Thomas Gleixner Yes, but that means that irq_check_status_bit() may be called from mod

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-12-21 Thread Guenter Roeck
On 12/20/20 10:18 PM, Masahiro Yamada wrote: > On Mon, Dec 14, 2020 at 12:27 AM Miguel Ojeda > wrote: >> >> On Sun, Dec 13, 2020 at 4:16 PM Greg KH wrote: >>> >>> Because if you get a report of something breaking for your change, you >>> need to work to resolve it, not argue about it. Otherwise

Re: [PATCH] dt-bindings: Fix JSON pointers

2020-12-18 Thread Guenter Roeck
ot; > Cc: Jakub Kicinski > Cc: Andrew Lunn > Cc: Florian Fainelli > Cc: Sebastian Reichel > Cc: Greg Kroah-Hartman > Cc: Mark Brown > Cc: netdev@vger.kernel.org > Signed-off-by: Rob Herring > --- > .../bindings/hwmon/moortec,mr75203.yaml | 2 +- > .../bindings/hwmon/sensirion,shtc1.yaml | 4 +- > .../devicetree/bindings/hwmon/ti,tmp513.yaml | 2 +- Acked-by: Guenter Roeck

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-12-13 Thread Guenter Roeck
On 12/12/20 9:04 PM, Miguel Ojeda wrote: > On Sat, Dec 12, 2020 at 5:18 PM Guenter Roeck wrote: >> >> This patch results in: >> >> arch/sh/kernel/cpu/sh4a/smp-shx3.c: In function 'shx3_prepare_cpus': >> arch/sh/kernel/cpu/sh4a/smp-shx3.c:76:3: error

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-12-12 Thread Guenter Roeck
On Sun, Nov 29, 2020 at 04:33:35AM +0900, Masahiro Yamada wrote: > Revert commit cebc04ba9aeb ("add CONFIG_ENABLE_MUST_CHECK"). > > A lot of warn_unused_result warnings existed in 2006, but until now > they have been fixed thanks to people doing allmodconfig tests. > > Our goal is to always enabl

Re: [PATCH v2 0/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring

2020-11-18 Thread Guenter Roeck
On Wed, Nov 18, 2020 at 05:01:19PM -0800, Guenter Roeck wrote: > On Wed, Nov 18, 2020 at 03:42:53PM -0800, Tao Ren wrote: > > On Thu, Nov 19, 2020 at 12:27:19AM +0100, Andrew Lunn wrote: > > > On Wed, Nov 18, 2020 at 03:09:27PM -0800, rentao.b...@gmail.com wrote: >

Re: [PATCH v2 0/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring

2020-11-18 Thread Guenter Roeck
On Wed, Nov 18, 2020 at 03:42:53PM -0800, Tao Ren wrote: > On Thu, Nov 19, 2020 at 12:27:19AM +0100, Andrew Lunn wrote: > > On Wed, Nov 18, 2020 at 03:09:27PM -0800, rentao.b...@gmail.com wrote: > > > From: Tao Ren > > > > > > The patch series adds hardware monitoring driver for the Maxim MAX127

Re: [PATCH 1/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring driver

2020-11-16 Thread Guenter Roeck
On Mon, Nov 16, 2020 at 05:09:43PM -0800, rentao.b...@gmail.com wrote: > From: Tao Ren > > Add hardware monitoring driver for the Maxim MAX127 chip. > > MAX127 min/max range handling code is inspired by the max197 driver. > > Signed-off-by: Tao Ren > --- > drivers/hwmon/Kconfig | 9 ++ > d

Re: [PATCH] hwmon: pmbus: shrink code and remove pmbus_do_remove()

2020-10-26 Thread Guenter Roeck
On Mon, Oct 26, 2020 at 11:53:52AM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The only action currently performed in pmbus_do_remove() is removing the > debugfs hierarchy. We can schedule a devm action at probe time and remove > pmbus_do_remove() entirely from all pmbus dri

Re: [PATCH] dt-bindings: Another round of adding missing 'additionalProperties'

2020-10-02 Thread Guenter Roeck
o > Cc: Bjorn Andersson > Cc: Baolin Wang > Cc: Guenter Roeck > Cc: Jonathan Cameron > Cc: Mauro Carvalho Chehab > Cc: Laurent Pinchart > Cc: Lee Jones > Cc: Ulf Hansson > Cc: "David S. Miller" > Cc: Bjorn Helgaas > Cc: Vinod Koul > Cc: Liam Gird

skb_under_panic with corrupt (?) head/data pointers

2020-09-23 Thread Guenter Roeck
Hi, we are seeing situations where skb_under_panic is reported with bad data pointers. A recent example is [1], but we have seen more of the same. Some random examples: skb_under_panic: text:39ea4f04 len:272 put:48 head:bdd3f564 data:f70d12b8 tail:0x102 end:0x2c0

Re: [PATCH NET] net: atlantic: Use readx_poll_timeout() for large timeout

2020-08-19 Thread Guenter Roeck
voytov > Cc: Igor Russkikh > Signed-off-by: Sebastian Andrzej Siewior Fixes: 8dcf2ad39fdb2 ("net: atlantic: add hwmon getter for MAC temperature") Acked-by: Guenter Roeck As in: This patch does not cause any additional trouble and will fix the observed compile failure. However, t

Re: [PATCH net] sfc: fix ef100 design-param checking

2020-08-12 Thread Guenter Roeck
gt; design-param. Fix both by checking for 0 and for a granularity bigger > than our min-size; if the granularity <= EFX_MIN_DMAQ_SIZE then it fits > in 32 bits, so we can cast it to u32 for the divide. > > Reported-by: kernel test robot > Signed-off-by: Edward Cree Reviewed-by

Re: [linux-next:master 13398/13940] drivers/net/ethernet/sfc/ef100_nic.c:610: undefined reference to `__umoddi3'

2020-08-10 Thread Guenter Roeck
On Thu, Aug 06, 2020 at 07:17:43PM +0100, Edward Cree wrote: > On 06/08/2020 00:48, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > master > > head: d15fe4ec043588beee823781602ddb51d0bc84c8 > > commit: adcfc3482813fa2c34e5902005853

Re: [PATCH v3 net-next 03/11] sfc_ef100: read Design Parameters at probe time

2020-08-10 Thread Guenter Roeck
On Mon, Aug 10, 2020 at 09:15:20AM +0100, Edward Cree wrote: > On 09/08/2020 01:29, Guenter Roeck wrote: > > On Mon, Aug 03, 2020 at 09:33:20PM +0100, Edward Cree wrote: > >> + if (EFX_MIN_DMAQ_SIZE % reader->value) { > > This is a 64-bit operation (value i

Re: [PATCH v3 net-next 03/11] sfc_ef100: read Design Parameters at probe time

2020-08-08 Thread Guenter Roeck
On Mon, Aug 03, 2020 at 09:33:20PM +0100, Edward Cree wrote: > Several parts of the EF100 architecture are parameterised (to allow > varying capabilities on FPGAs according to resource constraints), and > these parameters are exposed to the driver through a TLV-encoded > region of the BAR. > For

Re: [PATCH 16/20] dt-bindings: watchdog: renesas,wdt: Document r8a774e1 support

2020-07-19 Thread Guenter Roeck
On Wed, Jul 15, 2020 at 12:09:06PM +0100, Lad Prabhakar wrote: > RZ/G2H (a.k.a. R8A774E1) watchdog implementation is compatible > with R-Car Gen3, therefore add the relevant documentation. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Geert Uytterhoeven Reviewed-by

Re: [Patch net v2] cgroup: fix cgroup_sk_alloc() for sk_clone_lock()

2020-07-14 Thread Guenter Roeck
On Thu, Jul 09, 2020 at 11:59:09AM -0700, Cong Wang wrote: > On Thu, Jul 9, 2020 at 11:51 AM Cong Wang wrote: > > > > On Thu, Jul 9, 2020 at 10:10 AM Guenter Roeck wrote: > > > > > > Something seems fishy with the use of skcd->val on big endian sy

Re: [Patch net v2] cgroup: fix cgroup_sk_alloc() for sk_clone_lock()

2020-07-10 Thread Guenter Roeck
On Thu, Jul 09, 2020 at 11:59:09AM -0700, Cong Wang wrote: > On Thu, Jul 9, 2020 at 11:51 AM Cong Wang wrote: > > > > On Thu, Jul 9, 2020 at 10:10 AM Guenter Roeck wrote: > > > > > > Something seems fishy with the use of skcd->val on big endian sy

Re: [Patch net v2] cgroup: fix cgroup_sk_alloc() for sk_clone_lock()

2020-07-09 Thread Guenter Roeck
On 7/9/20 11:51 AM, Cong Wang wrote: > On Thu, Jul 9, 2020 at 10:10 AM Guenter Roeck wrote: >> >> Something seems fishy with the use of skcd->val on big endian systems. >> >> Some debug output: >> >> [ 22.643703] sock: # sk_alloc(sk=

Re: [Patch net v2] cgroup: fix cgroup_sk_alloc() for sk_clone_lock()

2020-07-09 Thread Guenter Roeck
On 7/8/20 12:32 PM, Cong Wang wrote: > On Wed, Jul 8, 2020 at 12:07 PM Guenter Roeck wrote: >> >> On 7/8/20 11:34 AM, Cong Wang wrote: >>> Hi, >>> >>> On Wed, Jul 8, 2020 at 8:33 AM Guenter Roeck wrote: >>>> This patch causes all my s390 bo

Re: [Patch net v2] cgroup: fix cgroup_sk_alloc() for sk_clone_lock()

2020-07-08 Thread Guenter Roeck
On 7/8/20 12:32 PM, Cong Wang wrote: > On Wed, Jul 8, 2020 at 12:07 PM Guenter Roeck wrote: >> >> On 7/8/20 11:34 AM, Cong Wang wrote: >>> Hi, >>> >>> On Wed, Jul 8, 2020 at 8:33 AM Guenter Roeck wrote: >>>> This patch causes all my s390 bo

Re: [Patch net v2] cgroup: fix cgroup_sk_alloc() for sk_clone_lock()

2020-07-08 Thread Guenter Roeck
On 7/8/20 11:34 AM, Cong Wang wrote: > Hi, > > On Wed, Jul 8, 2020 at 8:33 AM Guenter Roeck wrote: >> This patch causes all my s390 boot tests to crash. Reverting it fixes >> the problem. Please see bisect results and and crash log below. >> > ... >> Crash lo

Re: [Patch net v2] cgroup: fix cgroup_sk_alloc() for sk_clone_lock()

2020-07-08 Thread Guenter Roeck
Hi, On Thu, Jul 02, 2020 at 11:52:56AM -0700, Cong Wang wrote: > When we clone a socket in sk_clone_lock(), its sk_cgrp_data is > copied, so the cgroup refcnt must be taken too. And, unlike the > sk_alloc() path, sock_update_netprioidx() is not called here. > Therefore, it is safe and necessary to

Re: [PATCH] hwmon: (pmbus) fix a typo in Kconfig SENSORS_IR35221 option

2020-07-02 Thread Guenter Roeck
On Thu, Jul 02, 2020 at 03:13:49PM -0700, rentao.b...@gmail.com wrote: > From: Tao Ren > > Fix a typo in SENSORS_IR35221 option: module name should be "ir35221" > instead of "ir35521". > > Fixes: 8991ebd9c9a6 ("hwmon: (pmbus) Add client driver for IR35221") > > Cc: Samuel Mendoza-Jonas > Signe

Re: [PATCH v4 05/11] thermal: remove get_mode() operation of drivers

2020-06-02 Thread Guenter Roeck
the mode from struct tzd. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Guenter Roeck > --- > drivers/acpi/thermal.c| 9 -- > .../ethernet/mellanox/mlxsw/core_thermal.c| 19 > drivers/platform/x86/acerhdf.c

Re: [PATCH v4 04/11] thermal: Store device mode in struct thermal_zone_device

2020-06-02 Thread Guenter Roeck
On Thu, May 28, 2020 at 09:20:44PM +0200, Andrzej Pietrasiewicz wrote: > Prepare for eliminating get_mode(). > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Guenter Roeck > --- > drivers/acpi/thermal.c| 18 ++-- > .../ether

Re: [PATCH v4 06/11] thermal: Add mode helpers

2020-06-01 Thread Guenter Roeck
On 6/1/20 4:16 AM, Andrzej Pietrasiewicz wrote: > Hi Guenter, > > W dniu 29.05.2020 o 17:52, Guenter Roeck pisze: >> On Thu, May 28, 2020 at 09:20:46PM +0200, Andrzej Pietrasiewicz wrote: >>> Prepare for making the drivers not access tzd's private members. &

Re: [PATCH v4 05/11] thermal: remove get_mode() operation of drivers

2020-05-29 Thread Guenter Roeck
the mode from struct tzd. > > Signed-off-by: Andrzej Pietrasiewicz Based on separate feedback/dscussion: Reviewed-by: Guenter Roeck Guenter > --- > drivers/acpi/thermal.c| 9 -- > .../ethernet/mellanox/mlxsw/core_thermal.c| 19 --

Re: [PATCH v4 04/11] thermal: Store device mode in struct thermal_zone_device

2020-05-29 Thread Guenter Roeck
On Thu, May 28, 2020 at 09:20:44PM +0200, Andrzej Pietrasiewicz wrote: > Prepare for eliminating get_mode(). > > Signed-off-by: Andrzej Pietrasiewicz Based on discussion: Reviewed-by: Guenter Roeck Guenter > --- > drivers/acpi/thermal.c

Re: [PATCH v4 04/11] thermal: Store device mode in struct thermal_zone_device

2020-05-29 Thread Guenter Roeck
On 5/29/20 10:21 AM, Andrzej Pietrasiewicz wrote: > Hi again, > > W dniu 29.05.2020 o 18:08, Andrzej Pietrasiewicz pisze: >> Hi Guenter, >> >> W dniu 29.05.2020 o 17:42, Guenter Roeck pisze: >>> On Thu, May 28, 2020 at 09:20:44PM +0200, Andrzej Pietrasiewicz

Re: [PATCH v4 06/11] thermal: Add mode helpers

2020-05-29 Thread Guenter Roeck
On Thu, May 28, 2020 at 09:20:46PM +0200, Andrzej Pietrasiewicz wrote: > Prepare for making the drivers not access tzd's private members. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/thermal/thermal_core.c | 53 ++ > include/linux/thermal.h| 13

Re: [PATCH v4 05/11] thermal: remove get_mode() operation of drivers

2020-05-29 Thread Guenter Roeck
On Thu, May 28, 2020 at 09:20:45PM +0200, Andrzej Pietrasiewicz wrote: > get_mode() is now redundant, as the state is stored in struct > thermal_zone_device. > > Consequently the "mode" attribute in sysfs can always be visible, because > it is always possible to get the mode from struct tzd. > >

Re: [PATCH v4 04/11] thermal: Store device mode in struct thermal_zone_device

2020-05-29 Thread Guenter Roeck
On Thu, May 28, 2020 at 09:20:44PM +0200, Andrzej Pietrasiewicz wrote: > Prepare for eliminating get_mode(). > Might be worthwhile to explain (not only in the subject) what you are doing here. > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/acpi/thermal.c| 18

Re: [PATCH v4 02/11] thermal: Store thermal mode in a dedicated enum

2020-05-29 Thread Guenter Roeck
On 5/29/20 8:13 AM, Andrzej Pietrasiewicz wrote: > Hi Guenter, > > W dniu 29.05.2020 o 16:48, Guenter Roeck pisze: >> On Thu, May 28, 2020 at 09:20:42PM +0200, Andrzej Pietrasiewicz wrote: >>> Prepare for storing mode in struct thermal_zone_device. >>> >>

Re: [PATCH v4 02/11] thermal: Store thermal mode in a dedicated enum

2020-05-29 Thread Guenter Roeck
On 5/29/20 8:08 AM, Andrzej Pietrasiewicz wrote: > W dniu 29.05.2020 o 17:05, Guenter Roeck pisze: >> On Thu, May 28, 2020 at 09:20:42PM +0200, Andrzej Pietrasiewicz wrote: >>> Prepare for storing mode in struct thermal_zone_device. >>> >>> Signed-off-by: Andr

Re: [PATCH v4 02/11] thermal: Store thermal mode in a dedicated enum

2020-05-29 Thread Guenter Roeck
On Thu, May 28, 2020 at 09:20:42PM +0200, Andrzej Pietrasiewicz wrote: > Prepare for storing mode in struct thermal_zone_device. > > Signed-off-by: Andrzej Pietrasiewicz What is the baseline for this series ? I can't get this patch to apply on top of current mainline, nor on v5.6, nor on top of

Re: [PATCH v4 03/11] thermal: Add current mode to thermal zone device

2020-05-29 Thread Guenter Roeck
tzd. The > get_mode() methods will become redundant. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Guenter Roeck > --- > include/linux/thermal.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/thermal.h b/include/linux/thermal.h > ind

Re: [PATCH v4 01/11] acpi: thermal: Fix error handling in the register function

2020-05-29 Thread Guenter Roeck
On Thu, May 28, 2020 at 09:20:41PM +0200, Andrzej Pietrasiewicz wrote: > The acpi_thermal_register_thermal_zone() is missing any error handling. > This needs to be fixed. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Guenter Roeck > --- > drivers/a

Re: [PATCH v4 02/11] thermal: Store thermal mode in a dedicated enum

2020-05-29 Thread Guenter Roeck
On Thu, May 28, 2020 at 09:20:42PM +0200, Andrzej Pietrasiewicz wrote: > Prepare for storing mode in struct thermal_zone_device. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/acpi/thermal.c| 27 +-- > drivers/platform/x86/acerhdf.c

Re: [PATCH 16/17] dt-bindings: watchdog: renesas,wdt: Document r8a7742 support

2020-05-22 Thread Guenter Roeck
m Sang > Reviewed-by: Geert Uytterhoeven Reviewed-by: Guenter Roeck > --- > Documentation/devicetree/bindings/watchdog/renesas,wdt.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/renesas,wdt.txt > b/Documentation/de

Re: [PATCH 2/2] Fix a NULL-ptr-deref bug in ath10k_usb_alloc_urb_from_pipe

2019-10-17 Thread Guenter Roeck
On Sun, Sep 01, 2019 at 11:06:05AM +0300, Kalle Valo wrote: > Guenter Roeck writes: > > > Hi, > > > > On Sat, Aug 03, 2019 at 08:31:01PM -0400, Hui Peng wrote: > >> The `ar_usb` field of `ath10k_usb_pipe_usb_pipe` objects > >> are initialized to p

Re: [PATCH v2 1/2] net: phy: realtek: Add rtl8211e rx/tx delays config

2019-05-12 Thread Guenter Roeck
Hi, On Sat, Apr 27, 2019 at 12:21:11AM +0300, Serge Semin wrote: > There are two chip pins named TXDLY and RXDLY which actually adds the 2ns > delays to TXC and RXC for TXD/RXD latching. Alas this is the only > documented info regarding the RGMII timing control configurations the PHY > provides. I

Re: [PATCH] bpf: enable program stats

2019-03-01 Thread Guenter Roeck
On Fri, Mar 01, 2019 at 02:17:40PM -0800, Eric Dumazet wrote: > > > On 03/01/2019 02:03 PM, Guenter Roeck wrote: > > Hi, > > > > On Mon, Feb 25, 2019 at 02:28:39PM -0800, Alexei Starovoitov wrote: > >> JITed BPF programs are indistinguishable from kernel fu

Re: [PATCH] bpf: enable program stats

2019-03-01 Thread Guenter Roeck
Hi, On Mon, Feb 25, 2019 at 02:28:39PM -0800, Alexei Starovoitov wrote: > JITed BPF programs are indistinguishable from kernel functions, but unlike > kernel code BPF code can be changed often. > Typical approach of "perf record" + "perf report" profiling and tuning of > kernel code works just as

Re: [PATCH] bpfilter: re-add header search paths to tools include to fix build error

2019-02-21 Thread Guenter Roeck
uild error fixed by commit ae40832e53c3 ("bpfilter: fix a build err"). Apology for the breakage, and thanks to Guenter for reporting this. Fixes: 303a339f30a9 ("bpfilter: remove extra header search paths for bpfilter_umh") Reported-by: Guenter Roeck Signed-off-by: Masahiro Yama

Re: [PATCH] bpfilter: remove extra header search paths for bpfilter_umh

2019-02-21 Thread Guenter Roeck
On Fri, Feb 22, 2019 at 12:54:47AM +0900, Masahiro Yamada wrote: > On Thu, Feb 21, 2019 at 11:46 PM Guenter Roeck wrote: > > > > On Thu, Jan 31, 2019 at 12:15:35PM +0900, Masahiro Yamada wrote: > > > Currently, the header search paths -Itools/include and > > >

Re: [PATCH] bpfilter: remove extra header search paths for bpfilter_umh

2019-02-21 Thread Guenter Roeck
On Thu, Jan 31, 2019 at 12:15:35PM +0900, Masahiro Yamada wrote: > Currently, the header search paths -Itools/include and > -Itools/include/uapi are not used. Let's drop the unused code. > > We can remove -I. too by fixing up one C file. > This patch reintroduces the problem last fixed with comm

Re: [PATCH net-next 09/12] mlxsw: core: Extend hwmon interface with fan fault attribute

2019-02-14 Thread Guenter Roeck
On 2/13/19 11:06 PM, Vadim Pasternak wrote: -Original Message- From: Guenter Roeck On Behalf Of Guenter Roeck Sent: Wednesday, February 13, 2019 5:03 PM To: Andrew Lunn ; Ido Schimmel Cc: netdev@vger.kernel.org; da...@davemloft.net; Jiri Pirko ; mlxsw ; Vadim Pasternak Subject: Re

Re: [PATCH net-next 09/12] mlxsw: core: Extend hwmon interface with fan fault attribute

2019-02-13 Thread Guenter Roeck
On 2/13/19 5:53 AM, Andrew Lunn wrote: On Wed, Feb 13, 2019 at 11:28:53AM +, Ido Schimmel wrote: From: Vadim Pasternak Add new fan hwmon attribute for exposing fan faults (fault indication is read from Fan Out of Range Event Register). Signed-off-by: Vadim Pasternak Reviewed-by: Jiri Pir

Re: [PATCH ghak90 (was ghak32) V4 01/10] audit: collect audit task parameters

2019-01-04 Thread Guenter Roeck
On Fri, Jan 04, 2019 at 09:57:35AM -0500, Richard Guy Briggs wrote: > On 2019-01-03 18:50, Guenter Roeck wrote: > > Hi Richard, > > > > On Tue, Jul 31, 2018 at 04:07:36PM -0400, Richard Guy Briggs wrote: > > > The audit-related parameters in struct task_struct sho

Re: [PATCH ghak90 (was ghak32) V4 01/10] audit: collect audit task parameters

2019-01-03 Thread Guenter Roeck
Hi Richard, On Tue, Jul 31, 2018 at 04:07:36PM -0400, Richard Guy Briggs wrote: > The audit-related parameters in struct task_struct should ideally be > collected together and accessed through a standard audit API. > > Collect the existing loginuid, sessionid and audit_context together in a > new

Re: [PATCH ghak90 (was ghak32) V4 00/10] audit: implement container identifier

2019-01-03 Thread Guenter Roeck
Hi Richard, On Thu, Jan 03, 2019 at 12:36:13PM -0500, Richard Guy Briggs wrote: > On 2019-01-03 08:15, Guenter Roeck wrote: > > Hi, > > > > On Tue, Jul 31, 2018 at 04:07:35PM -0400, Richard Guy Briggs wrote: > > > Implement kernel audit container identifier. &g

Re: [PATCH ghak90 (was ghak32) V4 00/10] audit: implement container identifier

2019-01-03 Thread Guenter Roeck
Hi, On Tue, Jul 31, 2018 at 04:07:35PM -0400, Richard Guy Briggs wrote: > Implement kernel audit container identifier. > I don't see a follow-up submission of this patch series. Has it been abandoned, or do I use the wrong search terms ? Thanks, Guenter > This patchset is a fourth based on the

Re: [PATCH net-next] staging: octeon: fix build failure with XFRM enabled

2018-12-21 Thread Guenter Roeck
On Fri, Dec 21, 2018 at 09:57:26PM +0100, Florian Westphal wrote: > skb->sp doesn't exist anymore in the next-next tree, so mips defconfig > no longer builds. Use helper instead to reset the secpath. > > Not even compile tested. > It does fix the build error. Tested-b

Re: [PATCH] netfilter: check if the socket netns is correct.

2018-09-27 Thread Guenter Roeck
On Thu, Sep 27, 2018 at 07:58:24PM -0300, Flavio Leitner wrote: > On Thu, Sep 27, 2018 at 01:46:29PM -0700, Guenter Roeck wrote: > > Hi Flavio, > > > > On Wed, Jun 27, 2018 at 10:34:25AM -0300, Flavio Leitner wrote: > > > Netfilter assumes that if the socket is pre

Re: [PATCH] netfilter: check if the socket netns is correct.

2018-09-27 Thread Guenter Roeck
Hi Flavio, On Wed, Jun 27, 2018 at 10:34:25AM -0300, Flavio Leitner wrote: > Netfilter assumes that if the socket is present in the skb, then > it can be used because that reference is cleaned up while the skb > is crossing netns. > > We want to change that to preserve the socket reference in a f

Re: [PATCH bpf-next] tools: include reallocarray feature test in FEATURE_TESTS_BASIC

2018-07-13 Thread Guenter Roeck
bpf: make use of reallocarray") added reallocarray use to libbpf, make perf also perform the reallocarray feature check. Fixes: 531b014e7a2f ("tools: bpf: make use of reallocarray") Reported-by: Guenter Roeck Signed-off-by: Jakub Kicinski Tested-by: Guenter Roeck --- tools/b

Re: [bpf-next,v3,11/13] tools: bpf: make use of reallocarray

2018-07-13 Thread Guenter Roeck
On 07/13/2018 05:07 PM, Jakub Kicinski wrote: On Fri, 13 Jul 2018 16:53:05 -0700, Guenter Roeck wrote: Hi, On Tue, Jul 10, 2018 at 02:43:05PM -0700, Jakub Kicinski wrote: reallocarray() is a safer variant of realloc which checks for multiplication overflow in case of array allocation. Since

Re: [bpf-next,v3,11/13] tools: bpf: make use of reallocarray

2018-07-13 Thread Guenter Roeck
Hi, On Tue, Jul 10, 2018 at 02:43:05PM -0700, Jakub Kicinski wrote: > reallocarray() is a safer variant of realloc which checks for > multiplication overflow in case of array allocation. Since it's > not available in Glibc < 2.26 import kernel's overflow.h and > add a static inline implementation

Re: [net] bpfilter: include bpfilter_umh in assembly instead of using objcopy

2018-06-27 Thread Guenter Roeck
've discussed to switch to something like klibc and keep it > as part of the kernel to avoid relying on glibc and cc-can-link.sh. > At the very least it fixes the build issue when building i386 images on x86_64 systems. (Build-)Tested-by: Guenter Roeck > net/bpfilter/Makefile

Re: [patch net-next RFC 11/12] mlxsw: core: Extend hwmon interface with FAN fault attribute

2018-06-26 Thread Guenter Roeck
On Tue, Jun 26, 2018 at 04:47:05PM +, Vadim Pasternak wrote: > > > > -Original Message- > > From: Guenter Roeck [mailto:li...@roeck-us.net] > > Sent: Tuesday, June 26, 2018 7:33 PM > > To: Vadim Pasternak > > Cc: Andrew Lunn ; da...@davemloft.net

Re: [patch net-next RFC 03/12] mlxsw: core: Add core environment module for port temperature reading

2018-06-26 Thread Guenter Roeck
On Tue, Jun 26, 2018 at 04:22:38PM +0200, Andrew Lunn wrote: > On Tue, Jun 26, 2018 at 12:10:28PM +, Vadim Pasternak wrote: > > Adding the linux...@vger.kernel.org list. > > > Add new core_env module to allow port temperature reading. This > > information has most critical impact on system's

Re: [patch net-next RFC 11/12] mlxsw: core: Extend hwmon interface with FAN fault attribute

2018-06-26 Thread Guenter Roeck
On Tue, Jun 26, 2018 at 02:47:01PM +, Vadim Pasternak wrote: > > > > -Original Message- > > From: Andrew Lunn [mailto:and...@lunn.ch] > > Sent: Tuesday, June 26, 2018 5:29 PM > > To: Vadim Pasternak > > Cc: da...@davemloft.net; netdev@vger.kernel.org; li...@roeck-us.net; > > rui.zh..

Re: [PATCH v0 03/12] mlxsw: core: Add core environment module for port temperature reading

2018-06-21 Thread Guenter Roeck
On Thu, Jun 21, 2018 at 08:34:40PM +0200, Andrew Lunn wrote: > > Hi Andrew, > > Adding Guenter Roeck, the HWMON maintainer. > > > The temperature of each individual module can be obtained > > through ethtool. > > You mean via --module-info? > > FYI: I

Re: [net] vhost: Use kzalloc() to allocate vhost_msg_node

2018-05-29 Thread Guenter Roeck
On 05/29/2018 08:01 PM, Michael S. Tsirkin wrote: On Tue, May 29, 2018 at 03:19:08PM -0700, Guenter Roeck wrote: On Fri, Apr 27, 2018 at 11:45:02AM -0400, Kevin Easton wrote: The struct vhost_msg within struct vhost_msg_node is copied to userspace, so it should be allocated with kzalloc() to

Re: [net 1/1] net/mlx5: Fix build break when CONFIG_SMP=n

2018-05-15 Thread Guenter Roeck
5/driver.h: In function ‘mlx5_get_vector_affinity_hint’: > include/linux/mlx5/driver.h:1299:13: error: > ‘struct irq_desc’ has no member named ‘affinity_hint’ > > Fixes: 6082d9c9c94a ("net/mlx5: Fix mlx5_get_vector_affinity function") > Signed-off-by: Saeed Mahameed > CC: Randy Dunlap &

  1   2   3   >