[PATCH] tipc: fix integer as NULL pointer sparse warnings in tipc

2008-02-24 Thread Harvey Harrison
net/tipc/cluster.c:145:2: warning: Using plain integer as NULL pointer net/tipc/link.c:3254:36: warning: Using plain integer as NULL pointer net/tipc/ref.c:151:15: warning: Using plain integer as NULL pointer net/tipc/zone.c:85:2: warning: Using plain integer as NULL pointer Signed-off-by: Harvey

New sparse warning in net/mac80211/debugfs_sta.c

2008-02-21 Thread Harvey Harrison
commit 0795af5729b18218767fab27c44b1384f72dc9ad Author: Joe Perches [EMAIL PROTECTED] Date: Wed Oct 3 17:59:30 2007 -0700 [NET]: Introduce and use print_mac() and DECLARE_MAC_BUF() This is nicer than the MAC_FMT stuff. Signed-off-by: Joe Perches [EMAIL PROTECTED]

Re: New sparse warning in net/mac80211/debugfs_sta.c

2008-02-21 Thread Harvey Harrison
On Thu, 2008-02-21 at 01:57 -0800, David Miller wrote: From: Harvey Harrison [EMAIL PROTECTED] Date: Thu, 21 Feb 2008 01:34:27 -0800 commit 0795af5729b18218767fab27c44b1384f72dc9ad Author: Joe Perches [EMAIL PROTECTED] Date: Wed Oct 3 17:59:30 2007 -0700 [NET]: Introduce

Re: New sparse warning in net/mac80211/debugfs_sta.c

2008-02-21 Thread Harvey Harrison
On Thu, 2008-02-21 at 02:05 -0800, David Miller wrote: From: Harvey Harrison [EMAIL PROTECTED] Date: Thu, 21 Feb 2008 02:01:19 -0800 In this case, it's being passed to a debugfs create function, could it instead use sysfs_format_mac? Just assigning print_mac() to a local variable

Re: New sparse warning in net/mac80211/debugfs_sta.c

2008-02-21 Thread Harvey Harrison
On Thu, 2008-02-21 at 02:12 -0800, David Miller wrote: From: Harvey Harrison [EMAIL PROTECTED] Date: Thu, 21 Feb 2008 02:08:18 -0800 Really, that should have read: Sparse warning introduced since -rc2: ..etc Harvey's best guess is this commit... I think the commit you

Re: New sparse warning in net/mac80211/debugfs_sta.c

2008-02-21 Thread Harvey Harrison
On Thu, 2008-02-21 at 02:03 -0800, David Miller wrote: From: Johannes Berg [EMAIL PROTECTED] Date: Thu, 21 Feb 2008 10:54:59 +0100 It modifies the buffer, and I think it's more likely that the warning was introduced by ... [NET]: Elminate spurious print_mac() calls. Right and

ni52.c warnings explosion

2008-02-20 Thread Harvey Harrison
Dave, Somewhere between 2.6.25-rc1 and -rc2 something changed that produces a few hundred sparse warnings in ni52.c. I see Alan touched it last. drivers/net/ni52.c:219:15: warning: incorrect type in argument 1 (different address spaces) drivers/net/ni52.c:219:15:expected void const

[PATCH] tlan: add static to function definitions

2008-02-18 Thread Harvey Harrison
/net/tlan.c:3306:5: warning: symbol 'TLan_EeReadByte' was not declared. Should it be static? Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- Kept the style consistent with the rest of the file, checkpatch will complain. drivers/net/tlan.c | 64

[PATCH] [NET]: Remove FASTCALL/fastcall macros

2007-12-16 Thread Harvey Harrison
X86_32 was the last user of the FASTCALL/fastcall macros, now that it uses regparm(3) by default, these macros expand to nothing. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- Dave, this is a wrap-up of my patch in your net-2.6.25.git with the build breakage fix from Andrew Morton included

[PATCH] NET: ns83820.c remove fastcall macro

2007-12-16 Thread Harvey Harrison
Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- Dave, this is the remainder of the FASTCALL/fastcall removal patch that is not already in your tree. Generated against net-2.6.25.git drivers/net/ns83820.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git

[PATCH] Net: Remove FASTCALL macro

2007-12-12 Thread Harvey Harrison
X86_32 was the last user of the FASTCALL macro, now that it uses regparm(3) by default, this macro expands to nothing. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- Should this be coordinated with the FASTCALL() removal in the x86 git tree? drivers/net/ns83820.c |5

[PATCH] net: remove fastcall

2007-12-12 Thread Harvey Harrison
fastcall is always empty, remove it from net/ Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- net/bluetooth/rfcomm/core.c |4 ++-- net/core/dev.c |2 +- net/core/sock.c |4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/net/bluetooth

[PATCH] net: remove remaining fastcall occurances in drivers/net

2007-12-12 Thread Harvey Harrison
fastcall is always defined to empty, remove it Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/net/ns83820.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ns83820.c b/drivers/net/ns83820.c index 972acc3..5eed99e 100644 --- a/drivers/net