> fixups */
> -#else
> -#define MSG_CMSG_COMPAT 0 /* We never have 32 bit fixups
> */
> -#endif
Shouldn't you add some comment here to stop people from trying to
use BIT(31) in the future?
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
a4
> kernel/kthread.c:292)
> r10:85247e64 r9:898dac80 r8:80269d68 r7: r6:8a9c6000 r5:89a2ee40
> r4:8a97bd00
> [<80271dbc>] (kthread) from [<80200114>] (ret_from_fork+0x14/0x20
> arch/arm/kernel/entry-common.S:158)
> Exception stack(0x8a9c7fb0 to 0x8a9c7ff8)
&
2qgg@e107158-lin/
> Signed-off-by: Jiri Olsa
> ---
> drivers/crypto/bcm/cipher.c | 2 +-
> drivers/crypto/bcm/cipher.h | 4 ++--
> drivers/crypto/bcm/util.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
on the side of the caller. Maybe there is a way to reuse that here.
> Herbert?
Yes this was one of the reasons I was persuing the continuation
work. It should allow us to kill the special case for CTS in the
krb5 code.
Hopefully I can get some time to restart work on this soon.
Cheers,
--
PI the underlying
implementataions would just have to do the same thing.
Since this is particular to your use-case it's better to leave
the complexity where it's needed rather than propagting it to
all the crypto drivers.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org
hat we can pass in an offset into the output sg as well?
Couldn't you just change the output sg to include the offset?
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> be required to wrap it up in the autoloading, module-handling mechanisms.
I don't have any problems with it living under crypto. However,
I'd like to see what the sunrpc code looks like before going one
way or another.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.o
are actually sharing this code with
sunrpc, am I missing something?
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
27;re
trying to enable a feature on the virtual device unconditionally.
> We might ask Herbert Xu if we :
>
> 1) Need to comment the function, or change its name to be more descriptive.
> 2) Change the behavior (as you suggested)
> 3) Other choice.
I think Tariq's patch is fine, al
On Fri, Nov 13, 2020 at 08:44:40AM -0800, Jakub Kicinski wrote:
>
> SGTM, actually everything starting from patch 4 is in drivers/crypto,
> so we can merge the first 3 into net-next and the rest via crypto?
Yes of course.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apa
512),ecb(cipher_null)),
> > rfc4106(gcm(aes)).
>
> Herbert, could someone who knows about crypto take a look at this,
> if the intention is to merge this via net-next?
This patch seems to be quite large but it is self-contained. How
about waiting a release cycle and then resubmit
6-over-v4 in transport mode? Isn't that
the whole point of BEET mode?
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
do the comparison on flow you must use
the original family and not some other value.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[net/xfrm/xfrm_compat.ko] undefined!
Is this with a recent kernel? Because they should be exported:
commit fd7cb5753ef49964ea9db5121c3fc9a4ec21ed8e
Author: Daniel Vetter
Date: Mon Mar 23 15:49:00 2020 +0100
mm/sl[uo]b: export __kmalloc_track(_node)_caller
Cheers,
--
Email: He
ifite loop.
>
> To fix the race, x->id.spi = htonl(spi) in the xfrm_alloc_spi() is moved
> to the back of spin_lock_bh, sothat state_hash_work thread no longer add x
> which id.spi is zero into the hash_list.
>
> Fixes: f034b5d4efdf ("[XFRM]: Dynamic xfrm_state hash table
this was introduced
with the dynamic resizing in f034b5d4efdfe0fb9e2a1ce1d95fa7914f24de49.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
es*/
> hlist_add_head_rcu(&x->byspi)
>
> So the same xfrm_stame (x) is added into the same list_hash
> (net->xfrm.state_byspi)2 times that makes the list_hash become
> a inifite loop.
Your explanation makes no sense. Prior to obtaining the spin lock
on the LHS,
27;d
make sense.
Otherwise a library helper would be more appropriate.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
you request MAY_BACKLOG.
However, you must then ensure that when you get EBUSY that you
stop issuing new requests until the Crypto API signals through
the callback that you can start again.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org
mode you wish to use.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Mon, Oct 05, 2020 at 10:36:34PM +0200, Fabian Frederick wrote:
> use new helper for netstats settings
>
> Signed-off-by: Fabian Frederick
> ---
> net/xfrm/xfrm_interface.c | 9 +
> 1 file changed, 1 insertion(+), 8 deletions(-)
Acked-by: Herbert Xu
--
Email: Her
On Wed, Sep 30, 2020 at 09:09:20AM +1000, James Morris wrote:
>
> I'm not keen on adding a parameter which nobody is using. Perhaps a note
> in the header instead?
Please at least change to the struct flowi to flowi_common if we're
not adding a family field.
Thanks,
--
Emai
ed-by: syzbot+577fbac3145a6eb2e...@syzkaller.appspotmail.com
Fixes: 48b8d78315bf ("[XFRM]: State selection update to use inner...")
Signed-off-by: Herbert Xu
diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
index 69520ad3d83b..9b5f2c2b9770 100644
--- a/net/xfrm/xfrm_state.c
+++
Reported-by: syzbot+577fbac3145a6eb2e...@syzkaller.appspotmail.com
Fixes: 48b8d78315bf ("[XFRM]: State selection update to use inner...")
Signed-off-by: Herbert Xu
diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
index 69520ad3d83b..9b5f2c2b9770 100644
--- a/net/xf
with a family. This
appears to have been lost with 8444cf712c5f71845cba9dc30d8f530ff0d5ff83.
I'm working on a fix.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Thu, Sep 24, 2020 at 09:30:03AM +0200, pet...@infradead.org wrote:
> On Thu, Sep 24, 2020 at 06:44:12AM +0200, Dmitry Vyukov wrote:
> > On Thu, Sep 24, 2020 at 6:36 AM Herbert Xu
> > wrote:
> > > > (k-slock-AF_INET6){+.-.}-{2:2}
>
> That's a seqlock
e commit
question because this commit is specific to seqlocks. There is
another syzbot report in this pile that mixed the SCTP socket lock
with the TCP socket lock and those are not seqlocks.
It's almost as if when a spinlock is freed and reallocated lockdep
is not clearing the existing state.
C
/lockdep.c:5398
> seqcount_lockdep_reader_access+0x139/0x1a0 include/linux/seqlock.h:103
> xfrm_policy_lookup_inexact_addr+0x57/0x200 net/xfrm/xfrm_policy.c:1909
And this is a completely different seqlock.
Again lockdep is creating a bogus report by lumping two unrelated
locks (but of th
#syz dup: inconsistent lock state in xfrm_policy_lookup_inexact_addr
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
51
> spin_lock include/linux/spinlock.h:354 [inline]
> sctp_rcv+0xd96/0x2d50 net/sctp/input.c:231
What's going on with all these bogus lockdep reports?
These are two completely different locks, one is for TCP and the
other is for SCTP. Why is lockdep suddenly beoming c
#syz dup: inconsistent lock state in xfrm_policy_lookup_inexact_addr
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#syz dup: inconsistent lock state in xfrm_policy_lookup_inexact_addr
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#syz dup: inconsistent lock state in xfrm_policy_lookup_inexact_addr
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#syz dup: inconsistent lock state in xfrm_policy_lookup_inexact_addr
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
+), 1 deletion(-)
Acked-by: Herbert Xu
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> - add a Kconfig option to en/disable obsolete algorithms that are only kept
> around to prevent breaking users that rely on it via the socket interface
> - add a patch to clean up some bogus Kconfig dependencies
> - add acks to patches #1, #2 and #3
>
> [0]
> https://l
On Mon, Aug 31, 2020 at 06:16:49PM +0300, Ard Biesheuvel wrote:
>
> @@ -12,6 +12,7 @@
> #include
> #include
> #include
> +#include
This needs kernel.h too for the pr_warn_ratelimited. I'll add
it when I apply the series.
Thanks,
--
Email: Herb
n then
be shared by both your crypto driver and your network driver so
you don't duplicate this everywhere.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ompile-test.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
lg.
CRYPTO_USER is the configuration interface which has nothing to
do with af_alg.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Sat, Aug 22, 2020 at 01:54:19PM -0400, Neil Horman wrote:
>
> Wouldn't it be better to make this:
> #define consume_skb(x) kfree_skb(x)
Either way is fine but I prefer inline functions over macros.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
gt; We want the following to be supported.
>
> perf probe consume_skb
That should continue to work as this patch does not change anything
when CONFIG_TRACEPOINTS is enabled.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
The function consume_skb is only meaningful when tracing is enabled.
This patch makes it conditional on CONFIG_TRACEPOINTS.
Signed-off-by: Herbert Xu
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 46881d902124..e8bca74857a3 100644
--- a/include/linux/skbuff.h
+++ b/include
_set_dma_mask(e1, e2)
> +dma_set_mask(&e1->dev, e2)
>
> @@
> expression e1, e2;
> @@
> -pci_set_consistent_dma_mask(e1, e2)
> +dma_set_coherent_mask(&e1->dev, e2)
>
> Signed-off-by: Christophe JAILLET
> ---
> If needed, see post from Christoph Hellwig on the kernel-janitors ML:
>https://marc.info/?l=kernel-janitors&m=158745678307186&w=4
> ---
> drivers/crypto/hifn_795x.c | 21 -
> 1 file changed, 12 insertions(+), 9 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
opping new users from coming in
after you've finished the test.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
lease work out a way with the ARM folks
to fix this without adding assembly code in a driver.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
line = lf->lmtline;
> + long ret;
> +
> + /*
> + * Make sure memory areas pointed in CPT_INST_S
> + * are flushed before the instruction is sent to CPT
> + */
> + smp_wmb();
Why should this be a NOOP on UP?
Cheers,
--
Email: Herbert Xu
H
r at compile or via proc, it can not be disabled.
> Redacting secret is a FIPS 140-2 requirement.
Couldn't you use the existing fips_enabled sysctl?
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#x27;m happy to continue taking anything that touches
chcr_algo.c as that resides wholly within the Crypto API.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
This patch restores the RCU marking on bucket_table->buckets as
it really does need RCU protection. Its removal had led to a fatal
bug.
Signed-off-by: Herbert Xu
diff --git a/include/linux/rhashtable.h b/include/linux/rhashtable.h
index e3def7bbe932..83ad875a7ea2 100644
--- a/include/li
huai"
Signed-off-by: Herbert Xu
diff --git a/include/linux/rhashtable.h b/include/linux/rhashtable.h
index 70ebef866cc8..e3def7bbe932 100644
--- a/include/linux/rhashtable.h
+++ b/include/linux/rhashtable.h
@@ -349,11 +349,11 @@ static inline void rht_unlock(struct bucket_table *tbl
,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
This patch restores the RCU marking on bucket_table->buckets as
it really does need RCU protection. Its removal had led to a fatal
bug.
Signed-off-by: Herbert Xu
diff --git a/include/linux/rhashtable.h b/include/linux/rhashtable.h
index e3def7bbe932..9a8d4b9dde50 100644
--- a/include/li
huai"
Signed-off-by: Herbert Xu
diff --git a/include/linux/rhashtable.h b/include/linux/rhashtable.h
index 70ebef866cc8..e3def7bbe932 100644
--- a/include/linux/rhashtable.h
+++ b/include/linux/rhashtable.h
@@ -349,11 +349,11 @@ static inline void rht_unlock(struct bucket_table *tbl
This patch series fixes an unprotected dereference in __rht_ptr.
The first patch is a minimal fix that does not use the correct
RCU markings but is suitable for backport, and the second patch
cleans up the RCU markings.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert
its callers. Everything else is just juggling RCU markings.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
.
Fixes: 4e481908c51b ("flow_offload: move tc indirect block to...")
Signed-off-by: Herbert Xu
diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
index f2c8311a0433..1075369d21d3 100644
--- a/include/net/flow_offload.h
+++ b/include/net/flow_offload.h
@@ -5,7 +5,6 @@
ble. Let me see what I can do.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
quot;)
> Signed-off-by: Eric Dumazet
> Cc: Mathieu Desnoyers
> Cc: Herbert Xu
> Cc: Marco Elver
> ---
> net/ipv4/tcp.c | 8
> net/ipv4/tcp_ipv4.c | 19 ++++++-
> 2 files changed, 18 insertions(+), 9 deletions(-)
Acked-by: Herbert Xu
T
alized bytes,
> if key->keylen is increased. (initial content of key->key[] is garbage)
>
> Something like this :
LGTM. Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
mb. If they
already exist in the code then I agree it's not a big deal. But
adding a new pair of bogus smp_Xmb's is bad for maintenance.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
E()/WRITE_ONCE(), but ACCESS_ONCE() instead.
If it's the double-read that you're protecting against, you should
just use barrier() and the comment should say so too.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
() in tcp_md5_hash_key() */
> +
>key->keylen = newkeylen;
>return 0;
>}
This doesn't make sense. Your smp_rmb only guarantees that you
see a version of key->key that's newer than keylen. What if the
key got changed twice? You coul
> > @@ -26,6 +26,7 @@
> > > #include
> > > #include
> > > #include
> > > +#include
> > >
> > > #include "remoteproc_internal.h"
> > > #include "qcom_common.h"
> >
> > I have applied those 2 by hand for today.
>
> I am still applying the above patch.
Hi Al:
Could you please fold these changes into your tree?
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Mon, Jun 22, 2020 at 12:43:53PM -0500, Eric W. Biederman wrote:
>
> Adding Herbert Xu who added support for failing notifications in
> fcc5a03ac425 ("[NET]: Allow netdev REGISTER/CHANGENAME events to fail").
>
> He might have some insight but 2007 wa
include
diff --git a/drivers/remoteproc/qcom_q6v5_mss.c
b/drivers/remoteproc/qcom_q6v5_mss.c
index feb70283b6a2..903b2bb97e12 100644
--- a/drivers/remoteproc/qcom_q6v5_mss.c
+++ b/drivers/remoteproc/qcom_q6v5_mss.c
@@ -26,6 +26,7 @@
#include
#include
#include
+#include
#include "remoteproc_internal.h"
#include "qcom_common.h"
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
x 32b7a30b2485..eb382ceaa116 100644
--- a/arch/s390/lib/test_unwind.c
+++ b/arch/s390/lib/test_unwind.c
@@ -9,6 +9,7 @@
#include
#include
#include
+#include
#include
#include
#include
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
405722adfe1..c4f273e2fe78 100644
--- a/drivers/mtd/nand/raw/cadence-nand-controller.c
+++ b/drivers/mtd/nand/raw/cadence-nand-controller.c
@@ -17,6 +17,7 @@
#include
#include
#include
+#include
/*
* HPNFC can work in 3 modes:
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~h
a forward
declaration in linux/socket.h for struct file.
Reported-by: Stephen Rothwell
Fixes: f0187db056dc ("iov_iter: Move unnecessary inclusion of...")
Signed-off-by: Herbert Xu
diff --git a/drivers/dma/st_fdma.c b/drivers/dma/st_fdma.c
index 67087dbe2f9f..962b6e05287b 100644
--- a
detected by build failures.
Also skbuff.h was relying on this to provide a declaration for
ahash_request. This patch adds a forward declaration instead.
Signed-off-by: Herbert Xu
diff --git a/drivers/dma/sf-pdma/sf-pdma.c b/drivers/dma/sf-pdma/sf-pdma.c
index 6d0bec947636..e237d6038407 100644
n is how do you want to deal with the
exception. IOW do you want to leave the algorithm still registered?
If you can keep the algorithm registered you might as well never
unregister it in the first place.
If it has to go then this code path must wait for the users to
disappear first.
Cheers,
-
On Wed, Jun 10, 2020 at 05:05:43PM -0700, David Miller wrote:
>
> Maybe we can start handling these changes via the crypto tree at some
> point?
Yes that's good point Dave. How about we push changes for chcr_algo
via the crypto tree and the rest via netdev?
Thanks,
--
Email: He
s is not the case for your driver because of the existence
of a path of unregistration that is not tied to module removal.
To support that properly, we need to add code to the Crypto API
to handle this, as opposed to adding hacks to the driver.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
yption algorithms require "seqiv"
> -- and RFC 8221 lists AES-GCM as "MUST" be implemented.
>
> Just make XFRM_ESP select CRYPTO_SEQIV.
>
> Fixes: f23efcbcc523 ("crypto: ctr - no longer needs CRYPTO_SEQIV") made
> Cc: Corentin Labbe
> Cc: Greg Kr
>
> Also improve the help text.
>
> Suggested-by: Herbert Xu
> Suggested-by: Steffen Klassert
> Cc: Corentin Labbe
> Cc: Greg Kroah-Hartman
> Signed-off-by: Eric Biggers
> ---
> net/ipv4/Kconfig | 21 +++--
> net/ipv6/Kconfig | 21 +
and make these be
> selected by the corresponding INET* options.
>
> Suggested-by: Herbert Xu
> Cc: Corentin Labbe
> Cc: Greg Kroah-Hartman
> Cc: Steffen Klassert
> Signed-off-by: Eric Biggers
> ---
> net/ipv4/Kconfig | 16 ++--
> net/ipv6/Kconfig |
select CRYPTO_SEQIV?
OK, let's just go with the unconditional select on SEQIV since
Steffen recommended RFC8221 which lists GCM and CBC as MUST and
GCM requires SEQIV to work.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
x27;t be on it. We probably should
add AES, SHA256 and GCM to the list.
Another potential improvement is to merge the two select lists
between ESP and ESP6. Perhaps move them to a new tristate say
XFRM_ESP that would then be selected by ESP and ESP6.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Fri, Jun 05, 2020 at 10:28:58AM +1000, Herbert Xu wrote:
>
> Hmm, the selection list doesn't include CTR so just adding SEQIV
> per se makes no sense. I'm not certain that we really want to
> include every algorithm under the sun. Steffen, what do you think?
Or how
eds CRYPTO_SEQIV")
> Cc: Corentin Labbe
> Cc: Greg Kroah-Hartman
> Cc: Herbert Xu
> Cc: Steffen Klassert
> Signed-off-by: Eric Biggers
> ---
> net/ipv4/Kconfig | 1 +
> net/ipv6/Kconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/net/ipv4/
don't need RCU protection when we're freeing a nested RCU
table because by this stage we've long passed a memory barrier
when anyone could change the nested table.
Signed-off-by: Herbert Xu
diff --git a/lib/rhashtable.c b/lib/rhashtable.c
index bdb7e4cadf05..9f6890aedd1a 100644
--
78 deletions(-)
You should also revert commit 798b2cbf9227 in your patch:
commit 798b2cbf9227b1bd7d37ae9af4d9c750e6f4de9c
Author: David S. Miller
Date: Tue Sep 4 14:20:14 2012 -0400
net: Add INET dependency on aes crypto for the sake of TCP fastopen.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
CC: Anirudh Gupta
> Signed-off-by: Nicolas Dichtel
Acked-by: Herbert Xu
Sorry for not catching this!
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
hy you need them and why the code would be
buggy if you don't use them.
In this case the code doesn't need them because an implicit
barrier() (which is *stronger* than READ_ONCE/WRITE_ONCE) already
exists in both places.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org
in_lock
shared_var = 1 spin_lock
spin_unlock if (shared_var == 1)
...
spin_unlock
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
in order to
not confuse future readers of this code. Comments have been added
in their places.
Signed-off-by: Herbert Xu
diff --git a/net/ipv4/inet_fragment.c b/net/ipv4/inet_fragment.c
index 2b816f1ebbb4..35e9784fab4e 100644
--- a/net/ipv4/inet_fragment.c
+++ b/net/ipv4/inet_fragment.c
@@ -193,1
This patch moves common code between rht_ptr and rht_ptr_exclusive
into __rht_ptr. It also adds a new helper rht_ptr_rcu exclusively
for the RCU case. This way rht_ptr becomes a lock-only construct
so we can use the lighter rcu_dereference_protected primitive.
Signed-off-by: Herbert Xu
? If it's
meant to separate the setting of dead and the subsequent destruction
work then it doesn't work because the barrier only protects the code
preceding it, not after.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
e address prefix lengths in the xfrm
> selector.")
> Signed-off-by: Anirudh Gupta
Acked-by: Herbert Xu
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
rimitive then yes that what
it should do. But it isn't relevant to this patch.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
As cmpxchg is a non-RCU mechanism it will cause sparse warnings
when we use it for RCU. This patch adds explicit casts to silence
those warnings. This should probably be moved to RCU itself in
future.
Signed-off-by: Herbert Xu
---
lib/rhashtable.c |5 +++--
1 file changed, 3 insertions
unnecessary RCU checking.
Signed-off-by: Herbert Xu
---
include/linux/rhashtable.h | 58 -
lib/rhashtable.c | 28 ++---
2 files changed, 46 insertions(+), 40 deletions(-)
diff --git a/include/linux/rhashtable.h b/include
This patch series fixes all the sparse warnings.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#x27;m working on a fix to this.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
replace rcu_assign_pointer() with cmpxchg() - which has equivalent
> barrier properties.
> If it the cmp fails, free the table that was just allocated.
>
> Signed-off-by: NeilBrown
Acked-by: Herbert Xu
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
xlat...")
Signed-off-by: Herbert Xu
diff --git a/net/ipv6/ila/ila_xlat.c b/net/ipv6/ila/ila_xlat.c
index 79d2e43c05c5..5fc1f4e0c0cf 100644
--- a/net/ipv6/ila/ila_xlat.c
+++ b/net/ipv6/ila/ila_xlat.c
@@ -417,6 +417,7 @@ int ila_xlat_nl_cmd_flush(struct sk_buff *skb, struct
genl_info *inf
proto in validate_tmpl()")
> Reported-by: syzbot+0bf0519d6e0de1591...@syzkaller.appspotmail.com
> Cc: Steffen Klassert
> Cc: Herbert Xu
> Signed-off-by: Cong Wang
> ---
> include/net/xfrm.h | 17 +
> net/ipv6/xfrm6_tunnel.c | 2 +-
> net/key/af_key.c|
in the
first case and allowed in the second case.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
em.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
rproto == IPSEC_PROTO_ANY && xfrm_id_proto_valid(proto)));
> }
This does not look right. IPSEC_PROTO_ANY should only be allowed
in userproto and your patch is going to let it pass when it's in
proto. Whether IPPROTO_ROUTING/IPPROTO_DSTOPTS should be allowed
in this context is also n
1 - 100 of 2505 matches
Mail list logo
