Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a me
ds are only included in the audit message
> when the netmask/prefix-length is less than the address length, i.e. the SPD
> entry applies to a network address and not a host address.
Any reason why we don't just always include them?
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email:
thop == NULL\n");
Space in indent is followed by a tab.
/home/gondolin/herbert/p:254: }
fatal: corrupt patch at line 269
$
There seems to be a line missing at the end. Please fix the white space
errors and resend.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{P
plies with fuzzes, but seems to
> compile)?
I guess I've answered this question :)
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pub
at we're changing in the
patches that aren't clean-ups.
> Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
> Signed-off-by: Wang Chen <[EMAIL PROTECTED]>
Who's the author? Andi or you? Please make this obvious with a From
header when you resubmit.
Thanks,
--
Vis
is enough.
>
> FYI:
> http://www.mail-archive.com/netdev@vger.kernel.org/msg13817.html
Excellent. They now do a recvmsg first with no buffer to get
meta-information, which just happens to increment the counters.
Could you please resubmit the patch then?
Thanks,
--
Visit Openswan at http:
Emelyanov <[EMAIL PROTECTED]>
Applied to net-2.6.25. Thanks Pavel!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe fr
It's not in the routing cache because IPsec lookups are done through the
flow cache.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pub
e with Rusty now: if a symbol is needed by more than one
in-tree module chances are we want it to be exported for all.
Although I admit I haven't examined your examples elsewhere.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTEC
make a lot of sense.
OK, short of making IPv4 a module (which would be a worthy task :)
do you have an example where a symbol is used by more than one module
but needs to be put into a namespace?
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
nction.
That is,
if (veth->h_vlan_proto != htons(ETH_P_8021Q) ||
VLAN_DEV_INFO(dev)->flags & VLAN_FLAG_REORDER_HDR) {
Otherwise you'll miss AF_PACKET packets when REORDER is off.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} &l
be an
> issue.
Patch applied. Thanks a lot Patrick!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list:
On Tue, Nov 27, 2007 at 11:03:41AM +0800, Herbert Xu wrote:
> On Mon, Nov 26, 2007 at 04:33:31PM +, chas williams - CONTRACTOR wrote:
> > if you are lucky (unlucky?) enough to have shared interrupts, the
> > interrupt handler can be called before the tasklet and lock are re
n at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTE
cache (for IPv4 anyway,
there is no cache at all for IPv6).
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscri
e if the admin deletes the
SA while the timer is running it'll go up in smoke too.
If you look in the history you'll find that the same patch
that removed the ref count on the timer introduced the call
to del_timer_sync :)
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbe
destruction.
>
> This is visible when looking at the xfrm[46]_mode_{tunnel,transport}
> module reference counts, they climb higher and higher over time.
Oh I see. How about just removing those double underscores then?
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbe
Even though the ref count on x may now drop to zero, it
won't be freed until del_timer_sync returns which should be
sufficient, no?
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~he
cept me build
> > just SMP kernels :-).
>
> Thank you! UP is for sissies anyway :-P
>
> Acked-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
Ilpo, you need a new machine :)
Thanks for fixing this! Patch applied to net-2.6.25.
--
Visit Openswan at http://www.openswan.org/
Ema
On Mon, Nov 26, 2007 at 10:24:03AM +, Joonwoo Park wrote:
> fib_hash: kmalloc + memset conversion to kzalloc
> fix to avoid memset entirely.
Patch applied.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gond
On Mon, Nov 26, 2007 at 10:24:03AM +, Joonwoo Park wrote:
> fib_semantics: kmalloc + memset conversion to kzalloc
> fix to avoid memset entirely.
Also applied.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gond
m_hash: kmalloc + memset conversion to kzalloc
> fix to avoid memset entirely.
Patch applied. Thanks everyone!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~
below.
Thanks Adrian. Patch applied to net-2.6.
Do we need this for stable too?
Chers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pub
ding this problem and posting a patch for
it.
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~
>
> Boring explanation, I know... Patch explains it better.
>
> Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
Good catch! Applied to net-2.6. Thanks.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gond
>
> Besides, symbolic names are read better than magic constants.
>
> Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
Applied to net-2.6.25. Thanks!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gond
>
> Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
I like this but I admit I'm no good with names either :)
Patch applied to net-2.6.25. Thanks Pavel!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: ht
gt; I'm afraid, queued packet before vconfig set_flag would do that.
Yes, AF_PACKET would do that. So you should check both.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: h
On Mon, Nov 26, 2007 at 11:18:45AM +0800, Herbert Xu wrote:
>
> I'm just going to revert this patch for 2.6.24 since we've lived
> with this race for so long anyway.
Actually, instead of reverting it completely I'm just going to
remove the newly added locks which sho
On Fri, Nov 23, 2007 at 09:26:31PM +0800, Herbert Xu wrote:
> On Fri, Nov 23, 2007 at 12:09:22AM +, Daniel Drake wrote:
> > David Miller found a problem in a wireless driver where I was using
> > compare_ether_addr() on potentially unaligned data. Document that
> > compar
Anybody
who wants to contribute to either of this is most welcome since
my plate's pretty full already.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.o
e :)
This is where it's used. Look harder.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this
is not
> talking about disabling the send checksum, but the receive checksum. He
> knows that he does not need it.
You must be in some other thread because this one started with
a patch to disable sender checksums.
Oh and please do keep CCs on this list.
Cheers,
--
Visit Openswan at http://www
it Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [E
4
> boundary. And you'll have all packets from stations come in aligned and
> all response packets from wherever come in as WPS.
OK, sounds like you'll just have to fix them up after DMA.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~}
ame hardware header length modulo 4?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send
IP etc.) packets?
If so then you can do the skb_reserve based on that and the fix-up
in the wireless core would be minimised.
Since I know next to nothing about the wireless transport layer,
one of you experts will need to tell me whether such a prediction
could work :)
Cheers,
--
Visit Openswan
what hardware header
length that you're going to get (e.g., based on what mode you're
in) then do the skb_reserve accordingly.
It's a good thing these things aren't running at 10Gb :)
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMA
the CPU requires
> alignment.
Luckily all sky2 users have been on x86 so far :)
Here's an idea. Put the data of the packet into the page frags
where alignment is not an issue but copy the header so that it
is aligned.
Would that work?
Cheers,
--
Visit Openswan at http://www.opensw
ecause those addresses are now
bigger (0x394/0x39c/0x3a8 vs. 0x2** earlier).
So please try the following patch (instead of the original one)
which should fix all the unailgned accesses in do_rx.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL
/www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EM
On Sat, Nov 24, 2007 at 09:33:36AM +0100, Johannes Berg wrote:
>
> We still require four-byte alignment, no?
Not at all. If NET_IP_ALIGN is zero then it won't be four-byte
aligned (since the Ethernet header is 14 bytes long).
Cheers,
--
Visit Openswan at http://www.openswan.org/
Ema
s up the platform code to fix up any exceptions should they
show up.
Daniel, what's the specific case that you had in mind with this
patch?
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~her
is the whole point, IPv6 unlike IPv4 does not have IP header
checksums so the high-level needs to protect it by checksumming
the pseudo-header.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herber
here are some
> other similar functions in tcp.h as well which currently have only a
> single caller. Please don't undo that work while DaveM is away for a short
> while :-).
Thanks for the explanation! I'll apply this patch.
--
Visit Openswan at http://www.openswan.org/
Email:
will create net-2.6 in the
same place as my net-2.6.25 tree.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from t
;
> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
Hmm, why don't we just get rid of tcp_advance_send_head?
Or are you planning to start using it again?
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://go
Order of Pedantry :)
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe net
n that works regardless of alignment.
>
> Signed-off-by: Daniel Drake <[EMAIL PROTECTED]>
Patch applied to net-2.6. Thanks.
I presume there will be some follow-on work to use this function?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} &l
elpers to where they really
> belong, i.e. closer to proc code under the #ifdef CONFIG_PROC_FS
> option.
>
> Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
Patch applied. Thanks Pavel!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~}
dropped by the path even though an oversize
> probe would be.
Thanks for the explanation!
I'll apply both patches to net-2.6.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
git://git.kernel.org/pub/scm/linux/kernel/git/herbert/net-2.6.25.git/
while Dave is away.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~he
val.
>
> The reason it is being held:
>
> Post by non-member to a members-only list
>
> Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]>
>
> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Applied.
--
Visit Openswan at http://www.opens
;
> Cc: "David S. Miller" <[EMAIL PROTECTED]>
> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Applied.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: htt
Applied.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
th
L PROTECTED]>
> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Applied to net-2.6. Thanks Andrew.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au
:)
>
> Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
Not too pedantic yet, please keep trying :)
Applied to net-2.6. Thanks!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~he
is one looks pretty straightforward. I'll put it in once
we resolve the other patch.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubk
n an under-estimate.
Also should that be Tcprexmtthresh segments at the current MTU
or the probed MTU?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au
On Tue, Nov 20, 2007 at 08:29:21PM -0800, David Miller wrote:
>
> During this time Herbert Xu (CC:'d) will take care of both the net-2.6
> stable tree and the net-2.6.25 devel tree.
For this duration please use the net-2.6.25 tree at this location
for basing your patches:
git://
s. Hardware
> checksumming is fine, as long as its "free."
No matter how strong your underlying checksumming is it's not
going to protect the IPv6 header is it :)
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http:
27;ve fixed.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev"
sented,
> > based on a reading of net/ipv4/udp.c.
>
> Disagree. UDP checksum is mandatory in IPv6.
Right, IPv6 doesn't have a header checksum so the UDP checksum
must be there.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECT
2.6.23 at this stage.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscri
l, ...
>
> when cpu1 return from dev_close(),__LINK_STATE_RX_SCHED is still set, the
> testing maybe of no use.
Can you please check whether this still happens with the current
kernel since RX_SCHED no longer exists there?
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email:
problem with the option in general
that Dave raised. That is this may cause the proliferation of
TCP receiver behaviour that may be undesirable.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apan
core networking stack.
I'm particular unhappy about 2) because I don't want be in a
situation down the track where every driver is going to add this
option so that they're not left behind in the arms race.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herb
d authenc.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev&quo
reason :)
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netd
to increment the counters itself.
Of course if someone could merge that code so that NFS uses more
generic code then it's even better.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana
le that defaults to off?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubsc
otected, but rather that the SA may not be present on
input. It's only used for IPComp where we may skip the IPComp
if the data is not compressible.
In other words the optional flag is really only meaningful on
inbuond policy checks.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Em
packets
for each socket in it.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line &qu
re usually rare. However, perhaps that is no longer the case
on today's Internet :)
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pub
UDP users."
::= { udp 1 }
So I think incrementing it in recvmsg is acceptable.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/
all the current
callers are from TCP. If and when we get a non-TCP caller we
can always create a TCP wrapper for this function and move the
alignment over there.
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{
pt_enable() \
do { \
preempt_enable_no_resched(); \
barrier(); \
preempt_check_resched(); \
} while (0)
when CONFIG_PREEMPT is enabled. So at least in this case the
cond_resched call is superfluous.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Her
them
are already in process context.
However, since you're already working on this as your next step
I can wait :)
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondo
If not we can get rid of the softirq special case.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from thi
t all? It's using
skb->cb to carry the tags but then calls dev_queue_xmit. Once
you do that packet schedulers can scribble all over skb->cb.
Also vlan_skb_recv should be moved out-of-line. It's absolutely
humongous. It'll generate tail-calls anyway so performance-wise
it'
Pv6 which is probably needed here as well.
Hmm, we really need to spend more time on merging stuff between
IPv4 and IPv6 to save all this duplication of effort.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.
es a global counter, using sk_forward_alloc
would mean that for most packets you only update a per-socket counter
which then would feed into the global counter at points such as socket
creation and destruction.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~}
on how many buckets to process is black
magic.
IMHO preemption is the answer :) But failing that, a resched
is the next best thing.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.o
ink assumes one message per sendmsg() call.
Actually netlink packets come with headers so we do allow chaining.
See netlink_rcv_skb for details.
We don't make use of that on recvmsg() though although theoretically
user-space is supposed to be ready to handle that too.
Cheers,
--
Visit Openswan at
ourage people from using high-order
allocations which IMHO is a good thing :)
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To
return DIV_ROUND_UP((unsigned int)amt, SK_DATAGRAM_MEM_QUANTUM);
> +}
> +
Thanks, this looks OK to me.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~h
ich is being unregistered? Was this made deliberately?
I think it's more of an oversight :)
Although it has no real impact because the only user that matters
here is IPv6 and it can't be unloaded.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI
> Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
Good catch. Thanks Pavel!
Acked-by: Herbert Xu <[EMAIL PROTECTED]>
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: htt
o
the payload head room. TSO doesn't need this either, all it wants
is the guarantee that there is no tail room.
So this patch fixes this by adjusting the skb_reserve call so that
exactly the requested amount (which all callers have calculated in
a precise way) is made available as tail room.
;nf_post_routing
>
> After changeset:
>
> [NETFILTER]: Introduce NF_INET_ hook values
>
> It always evaluates to NF_INET_POST_ROUTING.
>
> Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
Thank you!
--
Visit Openswan at http://www.openswan.org/
Email:
orking on that :)
I'm not just converting ESP over to async, I'm also changing
it to use the AEAD interface which is needed for it to properly
support algorithms such as CCM.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]&
t the loop executes properly and we
don't end up nesting too deep and overrun the stack.
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.a
[2]: *** [net/ipv4/xfrm4_input.o] Error 1
> make[1]: *** [net/ipv4] Error 2
> make: *** [net] Error 2
No netfilter, surely not :)
Does this patch help?
[IPSEC]: Fix build problem with netfilter off
The function xfrm4_rcv_encap_finish is now used even with NETFILTER
off. So we need to r
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a me
process for async crypto.
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
---
include/net/xfrm.h |1 -
net/ipv4/xfrm4_input.c | 11 +++
net/ipv4/xfrm4_output.c |2 ++
net/ipv4/xfrm4_state.c |1 -
net/ipv6/xfrm6_input.c |4 +++-
net/ipv6/xfrm6_output.c |
[IPSEC]: Add async resume support on input
This patch adds support for async resumptions on input. To do so, the
transform would return -EINPROGRESS and subsequently invoke the function
xfrm_input_resume to resume processing.
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
---
inclu
On Tue, Nov 13, 2007 at 10:27:13PM -0500, Hideo AOKI wrote:
>
> Herbert Xu wrote:
> >>
> >>+#define SK_DATAGRAM_MEM_QUANTUM ((int)PAGE_SIZE)
> >>+
> >>+static inline int sk_datagram_pages(int amt)
> >>+{
> >>+ return DIV_ROUND_UP(a
unt but that feels a
bit fragile.
Perhaps those who want to push this patch should be encouraged
to convert e1000 to the new interface :)
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP
enswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
read/written
atomically on all architectures. David Miller observed that the value
stored in it is only an unsigned long which is always atomic.
So based on his suggestion this patch changes the internal representation
from u64 to unsigned long while the user-interface still refers to it as
u64.
Sig
1001 - 1100 of 2505 matches
Mail list logo
