[patch 1/2] ipvs: Bind connections on stanby if the destination exists

2007-11-04 Thread horms
->state = ntohs(s->state); + cp->flags = flags | IP_VS_CONN_F_HASHED; + } else + atomic_dec(&dest->refcnt); } /* Note that we don't touch its state and flags if it is a n

[patch 0/2] ipvs: avoid overcommit on the standby, take III

2007-11-04 Thread horms
to my previous attempt, which happily showed the bogus bits that I know about have been fixed. -- -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL

[patch 2/2] ipvs: Syncrhonise Closing of Connections

2007-11-04 Thread horms
Bogdanovski <[EMAIL PROTECTED]> Signed-off-by: Simon Horman <[EMAIL PROTECTED]> --- Thu, 01 Nov 2007 18:25:10 +0900, Horms * Redifed for net-2.6 * Ran through scripts/checkpatch.pl and fixed up everything that it complains about except the use of volatile, as its in keeping with other

Re: [patch] ipvs: force read of atomic_t in while loop

2007-08-08 Thread Horms
7 +909,7 @@ ip_vs_edit_dest(struct ip_vs_service *sv > write_lock_bh(&__ip_vs_svc_lock); > > /* Wait until all other svc users go away */ > - while (atomic_read(&svc->usecnt) > 1) {}; > + IP_VS_WAIT_WHILE(atomic_read(&svc->usecnt) > 1

Re: [ipvs] BUG: soft lockup detected on CPU#3!

2007-05-28 Thread Horms
On Mon, May 28, 2007 at 04:20:32PM +0200, Sebastien Estienne wrote: > On 5/28/07, Horms <[EMAIL PROTECTED]> wrote: > >On Sat, May 26, 2007 at 11:22:40AM +0900, Horms wrote: > >> On Fri, May 25, 2007 at 09:30:52AM +, Sebastien Estienne wrote: > >> > >

Re: [ipvs] BUG: soft lockup detected on CPU#3!

2007-05-28 Thread Horms
On Sat, May 26, 2007 at 11:22:40AM +0900, Horms wrote: > On Fri, May 25, 2007 at 09:30:52AM +, Sebastien Estienne wrote: > > > > I didn't try 2.6.21 yet, but using ubuntu dapper kernel (2.6.15) i > > can't reproduce the bug. > > When i was using feisty ker

Re: [ipvs] BUG: soft lockup detected on CPU#3!

2007-05-25 Thread Horms
onfig, as the locking deatails to change a little with different configs. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [ipvs] BUG: soft lockup detected on CPU#3!

2007-05-25 Thread Horms
do_IRQ+0xd9/0x100 > [mwait_idle+0/80] mwait_idle+0x0/0x50 > [ret_from_intr+0/10] ret_from_intr+0x0/0xa >[tcp_poll+0/336] tcp_poll+0x0/0x150 > [mwait_idle+66/80] mwait_idle+0x42/0x50 > [cpu_idle+155/208] cpu_idle+0x9b/0xd0 > [start_kernel+586/608] start_kernel+0x24a/0x260

[PATCH] LVS: Send ICMP unreachable responses to end-users when real-servers are removed

2007-02-10 Thread Horms
Hi, this is a small patch by Janusz Krzysztofik to ip_route_output_slow() that allows VIP-less LVS linux director to generate packets originating >From VIP if sysctl_ip_nonlocal_bind is set. In a nutshell, the intention is for an LVS linux director to be able to send ICMP unreachable responses t

Re: [PATCH] [IPVS] replace if .. goto with while

2007-01-03 Thread Horms
On Tue, Jan 02, 2007 at 12:38:39AM -0800, David Miller wrote: > From: Horms <[EMAIL PROTECTED]> > Date: Mon, 18 Dec 2006 12:11:11 +0900 > > > I guess that this code used to be more complex, but replacing > > the goto with a while seems to make things a bit more read

[PATCH] [IPVS] replace if .. goto with while

2006-12-17 Thread Horms
I guess that this code used to be more complex, but replacing the goto with a while seems to make things a bit more readable. Or in other words, two fairly gratuitous goto are removed. On a related note, I wonder if there should be a limit to how many times it tries. Signed-Off-By: Simon Horman <

Re: [PATCH] [IPVS] transparent proxying

2006-12-17 Thread Horms
On Wed, Nov 29, 2006 at 11:46:22PM +0900, Horms wrote: > On Wed, Nov 29, 2006 at 03:15:23PM +0100, Thomas Graf wrote: [split] > > This patch seems to be based on an old tree, I've renamed nfmark > > to mark in net-2.6.20. The term fwmark and nfmark shouldn't be > &

Re: [PATCH] [IPVS] transparent proxying

2006-11-29 Thread Horms
On Wed, Nov 29, 2006 at 03:15:23PM +0100, Thomas Graf wrote: > * Horms <[EMAIL PROTECTED]> 2006-11-29 15:21 > > This seems to be a pretty clean solution to a real problem. > > > > Ultimately I would like to see IPVS move into the forward chain. > > This seems

[PATCH] [IPVS] transparent proxying

2006-11-28 Thread Horms
This seems to be a pretty clean solution to a real problem. Ultimately I would like to see IPVS move into the forward chain. This seems to be a nice way to explore that, without breaking any existing setups. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ [IPVS

[IPVS] make ip_vs_sync.c <= 80col wide

2006-11-28 Thread Horms
Make ip_vs_sync.c <= 80col wide Signed-off-by: Simon Horman <[EMAIL PROTECTED]> Index: linux-2.6/net/ipv4/ipvs/ip_vs_sync.c === --- linux-2.6.orig/net/ipv4/ipvs/ip_vs_sync.c 2006-11-29 09:53:51.0 +0900 +++ linux-2.6/net/ip

Re: [PATCH] [IPVS] use msleep_interruptable() instead of ssleep() aka msleep()

2006-11-28 Thread Horms
On Tue, Nov 28, 2006 at 10:35:01AM +0200, Julian Anastasov wrote: > > Hello, > > On Tue, 28 Nov 2006, Horms wrote: > > > Dean Manners notices that when an IPVS synchonisation daemons are > > started the system load slowly climbs up to 1. This seems to be relate

[PATCH] [IPVS] use msleep_interruptable() instead of ssleep() aka msleep()

2006-11-27 Thread Horms
Dean Manners notices that when an IPVS synchonisation daemons are started the system load slowly climbs up to 1. This seems to be related to the call to ssleep(1) (aka msleep(1000) in the main loop. Replacing this with a call to msleep_interruptable() seems to make the problem go away. Though I'm n

Re: [patch 0/2] [IPVS]: Make sure ip_vs_ftp ports are valid (again)

2006-09-28 Thread Horms
On Wed, Sep 27, 2006 at 10:53:54PM -0700, David Miller wrote: > From: Horms <[EMAIL PROTECTED]> > Date: Wed, 20 Sep 2006 23:44:57 +0900 > > > there are two patches floating around for this problem. > > It seems that the first incarntation has been commi

Re: ipvs locahost client patch for 2.6?

2006-09-20 Thread Horms
k for 2.6 with little effort. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 3/4] Make sure ip_vs_ftp ports are valid

2006-09-20 Thread Horms
On Wed, Sep 20, 2006 at 12:29:45PM +0200, Patrick McHardy wrote: > Horms wrote: > > Here is the revised patch. > > > > > > [IPVS] Make sure ip_vs_ftp ports are valid > > > > I'm not entirely sure what happens in the case of a valid port, > > at

Re: [patch 3/4] Make sure ip_vs_ftp ports are valid

2006-09-03 Thread Horms
On Mon, Sep 04, 2006 at 09:44:02AM +0900, Horms wrote: > On Mon, Sep 04, 2006 at 01:09:59AM +0200, Patrick McHardy wrote: > > Horms wrote: > > > I'm not entirely sure what happens in the case of a valid port, > > > at best it'll be silently ignored. This p

Re: [patch 3/4] Make sure ip_vs_ftp ports are valid

2006-09-03 Thread Horms
On Mon, Sep 04, 2006 at 01:09:59AM +0200, Patrick McHardy wrote: > Horms wrote: > > I'm not entirely sure what happens in the case of a valid port, > > at best it'll be silently ignored. This patch ignores them a little > > more verbosely. > > > > Si

[patch 3/4] Make sure ip_vs_ftp ports are valid

2006-09-01 Thread Horms
if (ret) break; -- -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch 1/4] Document the ports option to ip_vs_ftp in kernel-parameters.txt

2006-09-01 Thread Horms
[HW] When an interrupt is not handled search all handlers for it. Intended to get systems with badly broken -- -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To unsubscribe from this list: send the line "unsubscribe netdev&q

[patch 4/4] remove the debug option go ip_vs_ftp

2006-09-01 Thread Horms
0); @@ -382,8 +374,8 @@ ret = register_ip_vs_app_inc(app, app->protocol, ports[i]); if (ret) break; - IP_VS_DBG(1-debug, "%s: loaded support on port[%d] = %d\n", - app->name, i, ports[i]);

[patch 2/4] auto-help for ip_vs_ftp

2006-09-01 Thread Horms
Debug level -- -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch 0/4] ip_vs_ftp cleanups

2006-09-01 Thread Horms
Hi, This series of four patches has several minor cleanups for the options to the ip_vs_ftp modules. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL

Re: [PATCH] ipvs: Add sysctl documentation

2006-07-03 Thread Horms
On Mon, Jul 03, 2006 at 07:36:47PM -0700, David Miller wrote: > From: Horms <[EMAIL PROTECTED]> > Date: Mon, 3 Jul 2006 11:31:30 +0900 > > > * Derived from http://www.linuxvirtualserver.org/docs/sysctl.html, v1.4 > > maintained by Wensong Zhang > > &g

[PATCH] ipvs: Add sysctl documentation

2006-07-02 Thread Horms
-levels.txt from IPVS source tree into description of ipvs_debug * Minor spelling fixes * Further editing more than welcome * DaveM, do you need a 2.4 version of this document, it will likely be a slightly different list of options? Signed-Off-By: Horms <[EMAIL PROTECTED]> Documen

Re: IPVS Sysctl Variables

2006-07-02 Thread Horms
On Fri, Jun 30, 2006 at 02:20:45PM -0700, David Miller wrote: > From: Horms <[EMAIL PROTECTED]> > Date: Fri, 30 Jun 2006 15:19:41 +0900 > > > there are quite a number of entries under /proc/sys/net/ipv4/vs, > > I swear that they were documented in Documentation/network

IPVS Sysctl Variables

2006-06-30 Thread Horms
and what they do, you don't have to check if you don't want to), is it appropriate for inclusion in Documentation/networking/, and if so, should it be in ip-sysctl.txt, or elsewhere? http://www.linuxvirtualserver.org/docs/sysctl.html -- Horms

Re: [rfc][patch] ipvs: use proper timeout instead of fixed value

2006-05-08 Thread Horms
On Sun, May 07, 2006 at 11:13:33PM -0400, Andy Gospodarek wrote: > On Sun, May 07, 2006 at 01:38:40PM +0900, Horms wrote: > > On Fri, May 05, 2006 at 02:57:26PM -0400, Andy Gospodarek wrote: > > > On Fri, May 05, 2006 at 12:20:54PM +0900, Horms wrote: > > > > > &

Re: [rfc][patch] ipvs: use proper timeout instead of fixed value

2006-05-06 Thread Horms
On Fri, May 05, 2006 at 02:57:26PM -0400, Andy Gospodarek wrote: > On Fri, May 05, 2006 at 12:20:54PM +0900, Horms wrote: > > > > Sorry, I missunderstood your patch completely the first time around. > > Yes I think this is an excellent idea. Assuming its tested and works >

Re: [rfc][patch] ipvs: use proper timeout instead of fixed value

2006-05-04 Thread Horms
On Thu, May 04, 2006 at 10:51:11PM -0400, Andy Gospodarek wrote: > On Fri, May 05, 2006 at 09:47:56AM +0900, Horms wrote: > > On Thu, May 04, 2006 at 04:11:16PM -0400, Andy Gospodarek wrote: > > > > > > Instead of using the default timeout of 3 minutes, this uses the ti

Re: [rfc][patch] ipvs: use proper timeout instead of fixed value

2006-05-04 Thread Horms
ic_set(&cp->in_pkts, sysctl_ip_vs_sync_threshold[0]); > - cp->timeout = IP_VS_SYNC_CONN_TIMEOUT; > + pp = ip_vs_proto_get(s->protocol); > + cp->timeout = pp->timeout_table[cp->state]; > ip_vs_conn_put(cp); > >

[PATCH] net: ne2k.c won't compile if pci_clone_list is const

2006-03-23 Thread Horms
error: pci_clone_list causes a section type conflict ~/ gcc --version gcc (GCC) 4.0.3 (Debian 4.0.3-1) ~/ dpkg gcc-4.0 | grep Version Version: 4.0.3-1 Signed-Off-By: Horms <[EMAIL PROTECTED] ne2k-pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) cee0890cc97247b6a9decd94f5dc0719ac8f0b1b diff

Re: [patch 04/39] [PATCH] [BRIDGE]: netfilter missing symbol has_bridge_parent

2006-02-27 Thread Horms
ice-removal.patch in > 2.5.15.4 removed has_bridge_parent, however this symbol is still > called with NETFILTER_DEBUG is enabled. > > This patch uses the already seeded realoutdev value to detect if a parent > exists, and if so, the value of the parent. > > Signed-Off-By: Horm

Re: [PATCH] [BRIDGE]: netfilter missing symbol has_bridge_parent

2006-02-13 Thread Horms
On Mon, Feb 13, 2006 at 10:59:07AM -0800, Stephen Hemminger wrote: > Horms patch was the best of the three fixes. Dave, already applied Harald's > version, so this patch converts that to the better one. Thanks, I was working of Linus' i2.6 tree rather than Dave's net-2.6, so

[PATCH] [BRIDGE]: netfilter missing symbol has_bridge_parent

2006-02-12 Thread Horms
1 option. I think that the following patch will resolve this problem. -- Horms [BRIDGE]: netfilter missing symbol has_bridge_parent 5dce971acf2ae20c80d5e9d1f6bbf17376870911 in Linus' tree, otherwise known as bridge-netfilter-races-on-device-removal.patch in 2.5.15.4 removed has_bridge_par

[PATCH,2.4,SECURITY,NET] orinoco: CVE-2005-3180: Information leakage due to incorrect padding

2006-02-08 Thread Horms
; The above is a patch included in 2.6.16 as a fix for CVE-2005-3180. It to be applicable to 2.4. I have made a backport below, with the only semi-significant change being including the ALIGN macro in orinoco.c, as it doesn't exist in 2.4. As yet untested Signed-off-by: Horms <[EMAIL PROT

Re: [PATCH] [IPVS] Shrink ip_vs_*.c includes

2006-02-08 Thread Horms
On Tue, Feb 07, 2006 at 09:07:34PM -0800, David S. Miller wrote: > From: Horms <[EMAIL PROTECTED]> > Date: Wed, 8 Feb 2006 12:09:29 +0900 > > > Unfortunately this seems like it is going to be more tedious than > > we first thought. I would guess writing some sort of

Re: [PATCH] [IPVS] Shrink ip_vs_*.c includes

2006-02-07 Thread Horms
On Wed, Feb 08, 2006 at 01:36:11PM +1100, Herbert Xu wrote: > Horms <[EMAIL PROTECTED]> wrote: > > > >> Looks bogus to me. Why are we removing linux/modules.h from ip_vs_app.c > >> when it uses things like EXPORT_SYMBOL? > > > > Given that the co

Re: [PATCH] [IPVS] Shrink ip_vs_*.c includes

2006-02-07 Thread Horms
On Wed, Feb 08, 2006 at 12:19:32PM +1100, Herbert Xu wrote: > Horms <[EMAIL PROTECTED]> wrote: > > Dave, > > > > please apply. > > Looks bogus to me. Why are we removing linux/modules.h from ip_vs_app.c > when it uses things like EXPORT_SYMBOL? Given t

[PATCH] [IPVS] Shrink ip_vs_*.c includes

2006-02-06 Thread Horms
Dave, please apply. -- Horms Hello, This patch against the latest GIT HEAD reduces the includes to the necessary ones. I've compile-tested it against following (and s/y/m/) configuration on x86: CONFIG_IP_VS=y CONFIG_IP_VS_DEBUG=y CONFIG_IP_VS_TAB_BITS=12 CONFIG_IP_VS_PROTO_

Re: [PATCH][RFC] Shrink ip_vs_*.c includes

2006-02-06 Thread Horms
half of it needed >> to be built. > > Well, it does not happen so ofter that a core network related header is > touched to my avail. That I would tend to agree with. But Dave seemed to think it is worth the effort to break the headers out in IPVS, as they currently are. And I think it

Re: [PATCH][RFC] Shrink ip_vs_*.c includes

2006-02-06 Thread Horms
it. The problem with that approach, is that while its less work to maintain the headers by hand, it will likely result in uneeded includes in some cases. So all of LVS will get built when a given header is touched, where perhaps only half of it needed to be built. So with that in mind, could you con

Re: [PATCH][RFC] Shrink ip_vs_*.c includes

2006-02-06 Thread Horms
nn.c:759: error: 'THIS_MODULE' undeclared here (not in a function) net/ipv4/ipvs/ip_vs_conn.c:761: error: 'seq_read' undeclared here (not in a function) net/ipv4/ipvs/ip_vs_conn.c:762: error: 'seq_lseek' undeclared here (not in a function) net/ipv4/ipvs/ip_vs_conn.c:76

[PATCH] [IPV4] Document icmp_errors_use_inbound_ifaddr sysctl

2006-02-01 Thread Horms
about the ordering of the options in sysctl.txt, so I took a wild guess about where it fits. Signed-Off-By: Horms <[EMAIL PROTECTED]> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt index 2b7cf19..26364d0 100644 --- a/Documentation/ne

[PATCH] Remove suprious use of goto out: in icmp_reply

2006-01-31 Thread Horms
this function. This patch removes out. Signed-Off-By: Horms <[EMAIL PROTECTED]> diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c index be5a519..eadbd55 100644 --- a/net/ipv4/icmp.c +++ b/net/ipv4/icmp.c @@ -385,7 +385,7 @@ static void icmp_reply(struct icmp_bxm * u32 daddr;

Re: [2.6 patch] fix ipvs compilation

2006-01-05 Thread Horms
me > >to time clean it up a bit when adding new abstractions :-) > > Go for it, some of the headers are remnants of the 2.4 kernel and said > new abstractions. I will try to move some functionality into ip_vs.h, > which should be the only place with a large number of includes a

Re: [2.6 patch] fix ipvs compilation

2006-01-05 Thread Horms
d. > > > >Acked-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> > > Thanks for the heads-up and Adrian for the fix. Indeed. I notice that its now in Linus' tree, which is more than fine by me. -- Horms - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH-2.6] cleanup IP_VS_DBG statements

2005-12-29 Thread Horms
Dave, please apply. -- Horms tree 60d9ec661356d90c826b9e95d9d1feac04df0ceb parent d7ba5e23dc0661bc1e79593e0a6fbd424def3dcb author Horms <[EMAIL PROTECTED]> Fri, 30 Dec 2005 12:58:16 +0900 committer Horms <[EMAIL PROTECTED]> Fri, 30 Dec 2005 12:58:16 +0900 [PATCH-2.6] clean

[IPVS] remove dead code

2005-12-05 Thread Horms
ip_vs_app.c | 28 ip_vs_lblc.c | 27 --- ip_vs_lblcr.c | 27 --- ip_vs_proto_tcp.c | 22 -- 4 files changed, 104 deletions(-) Please apply -- Horms [IPVS] remove dead code

Re: Bug#337089: linux-image-2.6.14-1-powerpc: add CONFIG_TCP_CONG_BIC=y

2005-11-06 Thread Horms
t; > > If you want BIC as default then do as suggested here. My personal > opinion is that is the correct thing to do for a standard > distribution. Thanks, the suggestion above will be incporated into the next release. -- Horms - To unsubscribe from this list: send th