[PATCH v6] net: tcp: Fix a PTO timing granularity issue

2015-05-28 Thread Ido Yariv
this by setting the timeout to at least 2 jiffies on such systems. The 10ms figure was originally selected based on tests performed with the current implementation and HZ = 1000. Thus, leave the behavior on systems with HZ 100 unchanged. Signed-off-by: Ido Yariv idox.ya...@intel.com --- include/net/tcp.h

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-27 Thread Ido Yariv
Hi Eric, On Wed, May 27, 2015 at 10:24:16AM -0700, Eric Dumazet wrote: On Wed, 2015-05-27 at 12:54 -0400, Ido Yariv wrote: Hi Eric, That's a nice optimization ;) However, I think that with Nicholas Mc Guire's recent changes to msecs_to_jiffies (http://marc.info/?l=linux-kernelm

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-27 Thread Ido Yariv
Hi Eric, On Wed, May 27, 2015 at 07:56:25AM -0700, Eric Dumazet wrote: On Wed, 2015-05-27 at 10:40 -0400, Ido Yariv wrote: HZ=100 is used on some embedded platforms, so it's still something we have to deal with unfortunately.. Since the '2' here is a lower bound, and msecs_to_jiffies

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-27 Thread Ido Yariv
Hi Eric, On Wed, May 27, 2015 at 06:41:17AM -0700, Eric Dumazet wrote: On Wed, 2015-05-27 at 11:36 +, David Laight wrote: From: Of Ido Yariv Sent: 26 May 2015 21:17 The Tail Loss Probe RFC specifies that the PTO value should be set to max(2 * SRTT, 10ms), where SRTT

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-27 Thread Ido Yariv
Hi Eric, On Wed, May 27, 2015 at 09:23:36AM -0700, Eric Dumazet wrote: On Wed, 2015-05-27 at 11:23 -0400, Ido Yariv wrote: Signed-off-by: Ido Yariv idox.ya...@intel.com --- include/net/tcp.h | 9 + net/ipv4/tcp_output.c | 2 +- 2 files changed, 10 insertions(+), 1

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-27 Thread Ido Yariv
Hi Eric, On Wed, May 27, 2015 at 03:15:26PM -0400, Ido Yariv wrote: Hi Eric, On Wed, May 27, 2015 at 10:24:16AM -0700, Eric Dumazet wrote: On Wed, 2015-05-27 at 12:54 -0400, Ido Yariv wrote: Hi Eric, That's a nice optimization ;) However, I think that with Nicholas Mc

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-26 Thread Ido Yariv
Hi Eric, On Tue, May 26, 2015 at 10:13:40AM -0700, Eric Dumazet wrote: On Tue, 2015-05-26 at 13:02 -0400, Ido Yariv wrote: Hi Eric, On Tue, May 26, 2015 at 09:23:55AM -0700, Eric Dumazet wrote: Have you really hit an issue, or did you send this patch after all these msecs_to_jiffies

[PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-26 Thread Ido Yariv
this by setting the timeout to at least 2 jiffies on such systems. The 10ms figure was originally selected based on tests performed with the current implementation and HZ = 1000. Thus, leave the behavior on systems with HZ 100 unchanged. Signed-off-by: Ido Yariv idox.ya...@intel.com --- net/ipv4

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-26 Thread Ido Yariv
Hi Eric, On Tue, May 26, 2015 at 11:25:21AM -0700, Eric Dumazet wrote: On Tue, 2015-05-26 at 13:55 -0400, Ido Yariv wrote: The platform this was tested on was an embedded platform with a wifi module (11n, 20MHZ). The other end was a computer running Windows, and the benchmarking

[PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-26 Thread Ido Yariv
this issue, increase the number of jiffies by one, ensuring that the timeout won't expire in less than 10ms. Signed-off-by: Ido Yariv idox.ya...@intel.com --- net/ipv4/tcp_output.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-26 Thread Ido Yariv
Hi Eric, On Tue, May 26, 2015 at 09:23:55AM -0700, Eric Dumazet wrote: On Tue, 2015-05-26 at 10:25 -0400, Ido Yariv wrote: The Tail Loss Probe RFC specifies that the PTO value should be set to max(2 * SRTT, 10ms), where SRTT is the smoothed round-trip time. The PTO value is converted