Re: [PATCH] vmxnet3: fix LRO feature check

2018-03-20 Thread Igor Pylypiv
The 03/20/2018 10:57, David Miller wrote: > From: kbuild test robot > Date: Sun, 18 Mar 2018 14:37:35 +0800 > > > All warnings (new ones prefixed by >>): > > > >drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_rq_rx_complete': > >>>

[PATCH] net: gemini: fix memory leak

2018-03-19 Thread Igor Pylypiv
cppcheck report: [drivers/net/ethernet/cortina/gemini.c:543]: (error) Memory leak: skb_tab Signed-off-by: Igor Pylypiv <igor.pyly...@gmail.com> --- drivers/net/ethernet/cortina/gemini.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/cortina/gemini.c b/drive

[PATCH] vmxnet3: remove unused flag "rxcsum" from struct vmxnet3_adapter

2018-03-17 Thread Igor Pylypiv
Signed-off-by: Igor Pylypiv <ipyly...@silver-peak.com> --- drivers/net/vmxnet3/vmxnet3_int.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h index 018375f5d108..3de4cecda35a 100644 --- a/drivers/net/vmxnet3/vmxnet3

Re: [PATCH] vmxnet3: fix LRO feature check

2018-03-17 Thread Igor Pylypiv
The 03/17/2018 20:20, David Miller wrote: > From: Igor Pylypiv <ipyly...@silver-peak.com> > Date: Sat, 17 Mar 2018 00:58:52 -0700 > > > rxcsum and lro fields were deleted in commit a0d2730c9571 ("net: vmxnet3: > > convert to hw_features"). With upgradi

[PATCH] vmxnet3: fix LRO feature check

2018-03-17 Thread Igor Pylypiv
ges for vmxnet3 adapter version 2 (fwd)") Signed-off-by: Igor Pylypiv <ipyly...@silver-peak.com> --- drivers/net/vmxnet3/vmxnet3_drv.c | 4 +++- drivers/net/vmxnet3/vmxnet3_int.h | 3 --- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_dr

[PATCH] net: fix description of skb_find_text() according to removed functionality

2017-02-07 Thread Igor Pylypiv
I am not planning to to add a new user of this functions. Use of skb_find_text() was a part of my Linux study and its description informed me that I can use textsearch_next() which I cannot. Just want to fix this. On Tue, Feb 7, 2017 at 7:02 PM, David Miller wrote: > > How

[PATCH] net: fix description of skb_find_text() according to removed functionality

2017-02-07 Thread Igor Pylypiv
Textsearch state parameter was moved to local scope of the function. This eliminates usage of textsearch_next() to find subsequent occurrences. Fixes: 59a2440fd3cf ("net: Remove state argument from skb_find_text()") Signed-off-by: Igor Pylypiv <igor.pyly...@gmail.com> --- net/c

[PATCH] Revert "net: Remove state argument from skb_find_text()"

2017-02-04 Thread Igor Pylypiv
This reverts commit 059a2440fd3cf4ec57735db2c0a90401cde84fca. Textsearch state parameter should be passed by pointer because its resulting value is needed for call to textsearch_next(). Signed-off-by: Igor Pylypiv <igor.pyly...@gmail.com> --- include/linux/skbuff.h | 3 ++