Following are the changes.
-This patch enables auto-negotiation.
-Loading firmware is done when spidernet_open() is called.
-And this patch adds other several small changes for Celleb.
-This patch is not tested on CellBlade.
Signed-off-by: Kou Ishizaki
---
Dear everyone,
This is the patch (be
Christoph-san,
Thanks for your comments.
>On Tue, Dec 12, 2006 at 02:25:50PM +0900, Ishizaki Kou wrote:
>>
>> Following are the changes.
>> -This patch enables auto-negotiation.
>> -Loading firmware is done when spidernet_open() is called.
>> -And this patch add
Dear everyone,
This is a revised version of the patch set for spider_net driver
that works on Toshiba Cell Refererence Set (aka Celleb).
This patch set is based on netdev-2.6.git#upstream.
Best regards,
Kou Ishizaki
Toshiba
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
t
This patch enables spider_net driver to use auto negotiation on
Celleb. This driver also tries traditional link methods(setup_force()
and enable_fibre()). This driver is designed so as to work a PHY that
is not able to negotiate automatically, but we didn't test on it.
Signed-off-by: Kou Ishizaki
This patch moves calling init_firmware() from spider_net_probe() to
spider_net_open() so as to use the driver by built-in.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
--- org-linux-powerpc-git/drivers/net/spider_net.c 2007-01-15
10:57:23.0 +0900
+++ linux-powerpc-git/drivers
This patch adds or changes some HW specific settings for spider_net on
Celleb.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
--- org-linux-powerpc-git/drivers/net/Kconfig 2007-01-15 10:37:30.0
+0900
+++ linux-powerpc-git/drivers/net/Kconfig 2007-01-15 11:06:57.0
+0
This patches removes logging for SPIDER_NET_GTMFLLINT interrupts.
Since the interrupts are not irregular, and they happen frequently
when using 100Mbps network switches.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
--- org-linux-powerpc-git/drivers/net/spider_net.c 2007-01-15
11:16:1
We intend this patch to improve spidernet interrupt handling to be
more strict. We had following problem and this patch solves it.
-when CONFIG_DEBUG_SHIRQ=y, request_irq() calls handler().
-when spider_net_open() is called, it calls request_irq() which calls
spider_net_interrupt().
-if some
GDTDCEIDIS flag is defined that it is for debug and should not be used.
We met some troubles on Celleb platform by setting this flag.
-network does not recover after ifconfig down, then up operations.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/drivers/net/spider
Linas-san,
> On Mon, Jul 09, 2007 at 05:48:08PM +0900, Ishizaki Kou wrote:
> > We intend this patch to improve spidernet interrupt handling to be
> > more strict. We had following problem and this patch solves it.
>
> Looks reasonable to me. I'll forward it upstream.
Linas-san,
> > GDTDCEIDIS flag is defined that it is for debug and should not be
used.
>
> !? Certainly, my spec doesn't say anything like this;
First, I'm sorry to say that GDTDCEDIS is for debug. It's my
misunderstanding.
My HW manual of SCC simply said that GDTDCEDIS must not be set(Is
it s
Linas-san,
> p.s. I tested ifdown/ifup, and didn't see any problems.
> Does your bug happen immediately, or does it take many attempts
> to trigger it?
Thanks for your testing.
It happens immediately in our environment. It may be celleb specific.
Best regards,
Kou Ishizaki
-
To unsubscribe fro
This patch removes unnecessary accesses to phy registers.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/drivers/net/spider_net.c
diff -u linux-powerpc-git/drivers/net/spider_net.c:1.1.1.9
linux-powerpc-git/drivers/net/spider_net.c:1.14
--- linux-powerpc-git/drivers
This patch solves a problem that the spidernet driver sometimes fails
to handle IRQ.
The problem happens because,
- In Cell architecture, interrupts may arrive at an interrupt
controller, even if they are masked by the setting on registers of
devices. It happens when interrupt packets are sent
Linas Vepstas wrote:
> On Mon, Aug 20, 2007 at 10:13:27PM +0900, Ishizaki Kou wrote:
> > Please apply this to 2.6.23.
>
> I'll review and forward shortly. Kick me if you don't see a formal
> reply in a few days.
>
> > And also, please apply the follow
We must not call netif_poll_enable after enabling interrupts,
because an interrupt might come in and set the __LINK_STATE_RX_SCHED
bit before we get to clear that bit again. If that happens,
the next call to the ->poll() function will oops.
Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]>
Signed-o
Linas-san,
Ishizaki Kou wrote:
> Linas Vepstas wrote:
> > On Mon, Aug 20, 2007 at 10:13:27PM +0900, Ishizaki Kou wrote:
> > > Please apply this to 2.6.23.
> >
> > I'll review and forward shortly. Kick me if you don't see a formal
> > reply in a f
Jens-san,
> > > This is a revised version of the patch set for spider_net driver
> > > that works on Toshiba Cell Refererence Set (aka Celleb).
> > >
> > > This patch set is based on netdev-2.6.git#upstream.
> >
> > Jens, can you give that a go on our blades see if it doesn't break
> > anything ?
I apologize if you received this mail many times.
Jens-san
> This patch modifies the patch submitted by Kou Ishizaki to make it
work on the
> blade
(http://marc.theaimsgroup.com/?l=linux-netdev&m=116593424505539&w=2).
> Unfortunately I dont have access to a Celleb so I cannot test it
there.
Tha
Jens-san,
Thanks for your comments.
>Ishizaki-san,
>
>> This patch partially works on celleb but remains
>> following several problems.
>> 1. It doesn't recover once an ethernet cable which is
>>connected to a spider_net card is unpluged.
>
>My understanding is that you are using the LINK i
Add auto negotiation support for Celleb.
This patch is just for a test. Please try this, if you can.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
--- org-linux-powerpc-git/drivers/net/spider_net.h 2007-02-02
14:24:26.0 +0900
+++ linux-powerpc-git/drivers/net/spider_net.h 2
This patch moves calling init_firmware() from spider_net_probe() to
spider_net_open() so as to use the driver by built-in.
This patch is just for a test. Please try this, if you can.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
--- org-linux-powerpc-git/drivers/net/spider_net.c 2007-
This patch adds or changes some HW specific settings for spider_net on
Celleb.
This patch is just for a test. Please try this, if you can.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
--- org-linux-powerpc-git/drivers/net/Kconfig 2007-02-02 14:34:19.0
+0900
+++ linux-powerpc-gi
This patches removes logging for SPIDER_NET_GTMFLLINT interrupts.
Since the interrupts are not irregular, and they happen frequently
when using 100Mbps network switches.
This patch is just for a test. Please try this if you can.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
--- org-linux-p
Ben-san, Jens-san
Thanks for your comments and advices.
First, we should apologize to you that some troubles which we informed
about spidernet auto-negotiation are caused by our mistake.
We used wrong MACRO for "advertise" variable to
phy->def->ops->setup_aneg().
We will post the revised patch f
This is a revised spidernet patch set based on
netdev-2.6.git#upstream.
This patch set is merged Jens-san's spidernet patch and works on
Toshiba Cell reference set (aka Celleb).
It requires Jens-san's phy patch
(http://ozlabs.org/pipermail/linuxppc-dev/2007-February/030987.html).
Ignore our prev
Add auto negotiation support for Celleb.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
--- org-linux-powerpc-git/drivers/net/spider_net.h 2007-02-06
20:24:35.0 +0900
+++ linux-powerpc-git/drivers/net/spider_net.h 2007-02-06 20:30:35.0
+0900
@@ -50,6 +50,8 @@
#defi
This patch moves calling init_firmware() from spider_net_probe() to
spider_net_open() so as to use the driver by built-in.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
--- org-linux-powerpc-git/drivers/net/spider_net.c 2007-02-06
20:35:55.0 +0900
+++ linux-powerpc-git/drivers
This patch adds or changes some HW specific settings for spider_net on
Celleb.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
--- org-linux-powerpc-git/drivers/net/Kconfig 2007-02-06 20:41:01.0
+0900
+++ linux-powerpc-git/drivers/net/Kconfig 2007-02-06 20:41:44.0
+0
This patches removes logging for SPIDER_NET_GTMFLLINT interrupts.
Since the interrupts are not irregular, and they happen frequently
when using 100Mbps network switches.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
--- org-linux-powerpc-git/drivers/net/spider_net.c 2007-02-06
20:44:4
Jeff-san,
> Jens Osterkamp wrote:
> > We forget to call spider_net_free_rx_chain_contents which does the
> > actual dev_kfree_skb. New skbs are allocated from skbuff_head_cache
> > on each "ifconfig up" letting the cache grow infinitely.
> >
> > This patch fixes it.
> >
> > Signed-off-by: Jens O
Linas-san, Jens-san,
> Tested this series of patches together with Jen's "version 3" patch,
> it worked for me. Code looks reasonable. Thus
We tried Jens-san's v3 patch on Celleb, and it works for us.
We also need Linas-san's patch set which includes bug-fix and makes
the code compilable etc. B
This moves calling init_firmware() from spider_net_probe() to
spider_net_open() so as to use the driver by built-in.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Linas Vepstas <[EMAIL PROTECTED]>
Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
---
--- org-linux-powerpc-git/drive
This adds or changes some HW specific settings for spider_net on
Celleb.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Linas Vepstas <[EMAIL PROTECTED]>
Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
---
--- org-linux-powerpc-git/drivers/net/Kconfig 2007-02-14 13:33:09.000
This removes logging for SPIDER_NET_GTMFLLINT interrupts.
Since the interrupts are not irregular, and they happen frequently
when using 100Mbps network switches.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Linas Vepstas <[EMAIL PROTECTED]>
Acked-by: Benjamin Herrenschmidt <[EMAIL PRO
Jeff-san,
This is a revised patch set for spider_net to work on Celleb.
This patch set is based on Jens-san's v3 phy patch and Linas-san's
spider_net patch.
Please apply our patch set with them.
Note: You need not apply Jens-san's spidernet patch because our patch
set includes it.
Best regard
Add auto negotiation support for Celleb.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Linas Vepstas <[EMAIL PROTECTED]>
Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
---
--- org-linux-powerpc-git/drivers/net/spider_net.h 2007-02-14
11:56:03.0 +0900
+++ linux-pow
This patch extends the timeout for spidernet auto-negotiation.
Auto-negotiation often fails to finish in 2 seconds.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/drivers/net/spider_net.h
===
--- linux-p
This patch revises the logging for link informations of spidernet.
- The link down message is too verbose because auto-negotiation timeout
occurs periodically while an ethernet cable is not connected.
- We want to see the link result, and we think it should be displayed.
Signed-off-by:
This patch fixes initialization of "aneg_count" and "medium" fields in
spider_net_card to make spidernet driver correctly sets "link status".
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/drivers/net/spider_net.c
=
This patch changes spidernet interrupt masks.
- unmask GDAINVAINT. There is an operation to do by spidernet
interrupt handler.
- mask some interrupts. There are no operations in the interrupt handler.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/drivers/net/s
In addition to the value of GHIINT0STS, spidernet interrupt handler
should check the values of GHIINT1STS/GHIINT2STS registers at the
beginning of spider_net_interrupt() so as not to drop error
interrupts.
GHIINT1STS/GHIINT2STS registers indicates some of erroneous conditions
in spidernet, and a f
Jens-san,
> Hi Ishizaki,
>
> Linas has left the company and is no longer doing kernel related stuff,
> so I suggest, given Jeff is ok with that, that the two of us take over
> spidernet maintainership.
(snip)
> Change maintainership for spidernet.
>
> Signed-off-by: Jens Osterkamp <[EMAIL PROTECT
43 matches
Mail list logo
