It is possible to address another chip on same MDIO bus. The case is
correctly handled for media advertising. It is taken into account
only if mii_data->phy_id == phydev->addr. However, this condition
was missing for reset case.
Signed-off-by: Jérôme Pouiller
---
drivers/net/phy/phy
it would be an unnecessary effort?
[1]
https://lore.kernel.org/driverdev-devel/20190919142527.31797-1-jerome.pouil...@silabs.com/
or commits a7a91ca5a23d^..40115bbc40e2
--
Jérôme Pouiller
On Friday 9 October 2020 20:52:47 CEST Kalle Valo wrote:
> Jerome Pouiller writes:
>
> > From: Jérôme Pouiller
> >
> > Smatch complains:
> >
> >drivers/staging/wfx/hif_rx.c:177 hif_scan_complete_indication() warn:
> > potential NULL parameter der
On Friday 9 October 2020 20:51:01 CEST Kalle Valo wrote:
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you recognize the sender and know the
> content is safe.
>
>
> Jerome Pouiller writes:
>
>
On Saturday 10 October 2020 14:40:34 CEST Greg Kroah-Hartman wrote:
> On Sat, Oct 10, 2020 at 02:22:13PM +0200, Jérôme Pouiller wrote:
> > On Friday 9 October 2020 20:52:47 CEST Kalle Valo wrote:
> > > Jerome Pouiller writes:
> > >
> > > > From: Jérôme Pou
commented out).
Anyway, if we choose to rely on the DT, should we also check the VID/PID?
Personally, I am in favor to probe the device only if VID/PID match and if
a DT node is found, even if it is not the usual way.
--
Jérôme Pouiller
On Tuesday 13 October 2020 18:49:35 CEST Rob Herring wrote:
> On Mon, Oct 12, 2020 at 12:46:26PM +0200, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
[...]
> > + Note that in add of the properties below, the WFx driver also supports
> > + `mac-address` and `local-mac-add
On Wednesday 14 October 2020 14:43:34 CEST Pali Rohár wrote:
> On Wednesday 14 October 2020 13:52:15 Jérôme Pouiller wrote:
> > On Tuesday 13 October 2020 22:11:56 CEST Pali Rohár wrote:
> > > On Monday 12 October 2020 12:46:32 Jerome Pouiller wrote:
> > > >
Hello Ulf,
On Friday 16 October 2020 13:30:30 CEST Ulf Hansson wrote:
> On Mon, 12 Oct 2020 at 12:47, Jerome Pouiller
> wrote:
> >
> > From: Jérôme Pouiller
>
> Please fill out this commit message to explain a bit more about the
> patch and the HW it enables support
On Tuesday 12 May 2020 09:43:34 CEST Geert Uytterhoeven wrote:
> Hi Jerome,
>
> On Mon, May 11, 2020 at 5:53 PM Jerome Pouiller
> wrote:
> > From: Jérôme Pouiller
> >
> > The struct hif_msg is received from the hardware. So, it declared as
> > little endia
On Friday 15 May 2020 15:53:59 CEST Greg Kroah-Hartman wrote:
> On Fri, May 15, 2020 at 10:33:11AM +0200, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > The function hif_scan() return the timeout for the completion of the
> > scan request. It is the only
t; + */
> >
> > This sounds very hacky to me, I have understood that you should never
> > use stack with DMA.
>
> You should never do that because some platforms do not support it, so no
> driver should ever try to do that as they do not know what platform they
>
t; +#include
> > +#else
> > +#include
> > +#include
> > +#define __packed __attribute__((__packed__))
> > +#endif
>
> Why check for __KERNEL__ and redefined __packed? These don't belong to a
> wireless driver.
In the old days, this file was shared with other projects. I though I had
cleaned all these things.
--
Jérôme Pouiller
On Tuesday 22 December 2020 16:02:38 CET Kalle Valo wrote:
> Jerome Pouiller writes:
>
> > From: Jérôme Pouiller
> >
> > Signed-off-by: Jérôme Pouiller
>
> [...]
>
> > +wfx-$(CONFIG_SPI) += bus_spi.o
> > +wfx-$(subst m,y,$(CONFIG_MMC)) += bus_sdi
nning on.
Just to be curious, why these platforms don't support DMA in a stack
allocated area? If the memory is contiguous (= not vmalloced), correctly
aligned and in the first 4GB of physical memory, it should be sufficient,
shouldn't?
--
Jérôme Pouiller
ing to add this comment:
The device need data about the antenna configuration. This information in
provided by PDS (Platform Data Set, this is the wording used in WF200
documentation) files. For hardware integrators, the full process to create
PDS files is described here:
https://github.com/SiliconLabs/wfx-firmware/blob/master/PDS/README.md
So this function aims to send PDS to the device. However, the PDS file is
often bigger than Rx buffers of the chip, so it has to be sent in multiple
parts.
In add, the PDS data cannot be split anywhere. The PDS files contains tree
structures. Braces are used to enter/leave a level of the tree (in a JSON
fashion). PDS files can only been split between root nodes.
--
Jérôme Pouiller
Hi Leon,
On Monday 15 March 2021 16:11:52 CET Leon Romanovsky wrote:
> On Mon, Mar 15, 2021 at 02:24:40PM +0100, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > Signed-off-by: Jérôme Pouiller
> > ---
> > drivers/net/wireless/silabs/wfx/Kconfig
"genirq: Reject bogus threaded irq requests")
> threaded IRQs without a primary handler need to be requested with
> IRQF_ONESHOT, otherwise the request will fail.
>
> So pass the IRQF_ONESHOT flag in this case.
>
> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
>
On Wednesday 4 November 2020 20:15:54 CET Rob Herring wrote:
> On Wed, 04 Nov 2020 16:51:45 +0100, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > Signed-off-by: Jérôme Pouiller
> > ---
> > .../bindings/net/wireless/silabs,wfx.yaml | 131 ++
Hello Ulf,
On Monday 22 March 2021 13:20:35 CET Ulf Hansson wrote:
> On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller
> wrote:
> >
> > From: Jérôme Pouiller
> >
> > Signed-off-by: Jérôme Pouiller
> > ---
> > drivers/net/wireless/silabs/wfx/bus_sdio
On Tuesday 23 March 2021 15:11:56 CET Ulf Hansson wrote:
> On Mon, 22 Mar 2021 at 18:14, Jérôme Pouiller
> wrote:
> > On Monday 22 March 2021 13:20:35 CET Ulf Hansson wrote:
> > > On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller
> > > wrote:
> &g
rs/net/wireless. Also do note
> that we have special rules for nl80211 vendor commands:
>
> https://wireless.wiki.kernel.org/en/developers/documentation/nl80211#vendor-specific_api
I hoped to suggest the move of this driver outside of staging in some
weeks (the last items in TODO list are either non-essential or easy to
fix). So, you suggest me to resend these patches after that change?
--
Jérôme Pouiller
On Monday 24 August 2020 11:50:42 CEST Dan Carpenter wrote:
> On Thu, Aug 20, 2020 at 05:58:47PM +0200, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > The protection of the management frames is mainly done by mac80211.
> > However, frames for the management o
23 matches
Mail list logo
