Re: [ldv-project] [net] libertas: potential race condition

2016-06-14 Thread James Cameron
On Tue, Jun 14, 2016 at 05:16:11PM +0400, Pavel Andrianov wrote: > 08.06.2016 02:51, James Cameron пишет: > >On Tue, Jun 07, 2016 at 09:39:55AM -0500, Dan Williams wrote: > >>On Tue, 2016-06-07 at 13:30 +0400, Pavel Andrianov wrote: > >>>Hi! > >>>

Re: [ldv-project] [net] libertas: potential race condition

2016-06-07 Thread James Cameron
eal race or I have missed something? > > Yeah, it looks like it should be grabbing priv->driver_lock before > clearing priv->currenttxskb in lbs_mac_event_disconnected().  Care to > submit a patch after testing?  Do you have any of that hardware? I've hardware, with serial console. Can test any patch, on USB (8388) or SDIO (8686). -- James Cameron http://quozl.netrek.org/

Re: [PATCH] net: mark DECnet as broken

2016-04-07 Thread James Cameron
.nos...@oracle.com> > Link: https://lkml.org/lkml/2015/12/17/666 > Cc: Eric Dumazet <eric.duma...@gmail.com> > Cc: Sasha Levin <sasha.le...@oracle.com> > Cc: David Miller <da...@davemloft.net> Reviewed-by: James Cameron <qu...@laptop.org> (An old DECnet

Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

2016-03-28 Thread James Cameron
resting, we're back to this symptom again. Nice to see this fix. Heavy memory pressure on 3.5 caused dev_alloc_skb failure in this driver. Tracked at OLPC as #12694. -- James Cameron http://quozl.netrek.org/

Re: question about potential integer truncation in mwifiex_set_wapi_ie and mwifiex_set_wps_ie

2015-09-29 Thread James Cameron
s_802_11_key_material aes_key; struct host_cmd_ds_802_11_key_material_v2 aes_key_v2; u8 wapi_ie[256]; - u8 wapi_ie_len; + u16 wapi_ie_len; u8 *wps_ie; - u8 wps_ie_len; + u16 wps_ie_len; u8 wmm_required; u8 wmm_enabled; u8 wmm_qosinfo;

[PATCH] sis900 Foxconn 661FX7MI-S PHY support

2006-05-10 Thread James Cameron
This patch is required to get sis900 ethernet working well on a Foxconn 661FX7MI-S motherboard which uses the SiS 661FX chipset. The patch adds an entry to mii_chip_info for the transceiver. Signed-off-by: James Cameron [EMAIL PROTECTED] Acked-by: Daniele Venzano [EMAIL PROTECTED] --- diff -puN

[PATCH] sis900 Foxconn 661FX7MI-S PHY support

2006-05-09 Thread James Cameron
://marc.theaimsgroup.com/?l=linux-netdevm=114297516729079w=2 I'm not sure, but I wonder if it means the default behaviour should be changed, so as to better handle future transceivers. Diff is against 2.6.16.13. Signed-off-by: James Cameron [EMAIL PROTECTED] --- sis900.c.orig 2006-05-09 10:36