Re: [PATCH rdma-next 0/3] Packet based credit mode

On Fri, Dec 07, 2018 at 08:04:26AM +0200, Leon Romanovsky wrote: > On Thu, Dec 06, 2018 at 08:27:06PM -0700, Jason Gunthorpe wrote: > > On Fri, Nov 30, 2018 at 01:22:03PM +0200, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > >From Dani

Re: [PATCH rdma-next 0/3] Packet based credit mode

On Fri, Nov 30, 2018 at 01:22:03PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > >From Danit, > > Packet based credit mode is an alternative end-to-end credit mode for QPs > set during their creation. Credits are transported from the responder > to the requester to optimize the use

Re: [PATCH rdma-next 0/7] Enrich DEVX support

On Tue, Dec 4, 2018 at 12:02 PM Doug Ledford wrote: > > On Mon, 2018-11-26 at 08:28 +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > From Yishai, > > --- > > This series enriches DEVX support in few aspects: it enables > > interoperability > >

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

On Wed, Nov 28, 2018 at 04:21:48PM -0600, Steve Wise wrote: > >> It does make sense to not require type.  The name must be unique so that > >> should be enough.  I'll have to respin the kernel side though... > > The delete_link really should be an operation on the ib_device, not > > the link_ops

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

On Wed, Nov 28, 2018 at 02:18:55PM -0600, Steve Wise wrote: > > > On 11/28/2018 2:13 PM, Leon Romanovsky wrote: > > On Wed, Nov 28, 2018 at 02:07:29PM -0600, Steve Wise wrote: > >> > >> On 11/28/2018 2:04 PM, Leon Romanovsky wrote: > >>> On Wed, Nov 28, 2018 at 01:08:05PM -0600, Steve Wise

Re: [PATCH V2 mlx5-next 00/12] mlx5 core generic EQ API for RDMA ODP

On Tue, Nov 20, 2018 at 11:11:16AM -0700, Leon Romanovsky wrote: > On Mon, Nov 19, 2018 at 10:52:30AM -0800, Saeed Mahameed wrote: > > Hi, > > > > This patchset is for mlx5-next shared branch, and will be applied there > > once the review is done. > > > > This patchset introduces mostly

Re: [PATCH V2 mlx5-next 11/12] {net,IB}/mlx5: Move Page fault EQ and ODP logic to RDMA

include/linux/mlx5/eq.h | 21 ++ > 10 files changed, 308 insertions(+), 381 deletions(-) Acked-by: Jason Gunthorpe Can you let me know when these land in the shared branch please? Thanks, Jason

Re: [PATCH mlx5-next 00/10] Collection of ODP fixes

On Mon, Nov 12, 2018 at 01:43:15PM -0700, Leon Romanovsky wrote: > On Thu, Nov 08, 2018 at 09:10:07PM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Hi, > > > > This is collection of fixes to mlx5_core and mlx5_ib ODP logic. > > There are two main reasons why we decided to

Re: [PATCH mlx5-next 11/12] {net,IB}/mlx5: Move Page fault EQ and ODP logic to RDMA

On Fri, Nov 16, 2018 at 01:59:00PM -0800, Saeed Mahameed wrote: > Use the new generic EQ API to move all ODP RDMA data structures and logic > form mlx5 core driver into mlx5_ib driver. > > Signed-off-by: Saeed Mahameed > Reviewed-by: Leon Romanovsky > Reviewed-by: Tariq Toukan >

Re: [PATCH mlx5-next 08/10] IB/mlx5: Call PAGE_FAULT_RESUME command asynchronously

On Fri, Nov 09, 2018 at 06:26:22PM +0200, Leon Romanovsky wrote: > On Thu, Nov 08, 2018 at 07:49:03PM +0000, Jason Gunthorpe wrote: > > On Thu, Nov 08, 2018 at 09:10:15PM +0200, Leon Romanovsky wrote: > > > From: Moni Shoua > > > > > > Telling the HCA that pa

Re: [PATCH mlx5-next 08/10] IB/mlx5: Call PAGE_FAULT_RESUME command asynchronously

On Thu, Nov 08, 2018 at 09:10:15PM +0200, Leon Romanovsky wrote: > From: Moni Shoua > > Telling the HCA that page fault handling is done and QP can resume > its flow is done in the context of the page fault handler. This blocks > the handling of the next work in queue without a need. > Call the

Re: [PATCH mlx5-next 00/10] Collection of ODP fixes

On Thu, Nov 08, 2018 at 09:10:07PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi, > > This is collection of fixes to mlx5_core and mlx5_ib ODP logic. > There are two main reasons why we decided to forward it to mlx5-next > and not to rdma-rc or net like our other fixes. > > 1.

Re: [PATCH mlx5-next 02/10] IB/mlx5: Avoid hangs due to a missing completion

On Thu, Nov 08, 2018 at 09:10:09PM +0200, Leon Romanovsky wrote: > From: Moni Shoua > > Fix 2 flows that may cause a process to hang on wait_for_completion(): > > 1. When callback for create MKEY command returns with bad status > 2. When callback for create MKEY command is called before

Re: [PATCH rdma] net/mlx5: Fix XRC SRQ umem valid bits

On Wed, Nov 07, 2018 at 09:34:34AM +0200, Leon Romanovsky wrote: > On Tue, Nov 06, 2018 at 03:11:53PM -0700, Jason Gunthorpe wrote: > > On Tue, Nov 06, 2018 at 05:10:53PM -0500, Doug Ledford wrote: > > > On Tue, 2018-11-06 at 22:02 +0000, Jason Gunthorpe wrote: > > > &

Re: [PATCH rdma] net/mlx5: Fix XRC SRQ umem valid bits

On Tue, Nov 06, 2018 at 05:10:53PM -0500, Doug Ledford wrote: > On Tue, 2018-11-06 at 22:02 +0000, Jason Gunthorpe wrote: > > On Tue, Nov 06, 2018 at 04:31:08PM -0500, Doug Ledford wrote: > > > On Wed, 2018-10-31 at 12:20 +0200, Leon Romanovsky wrote: > >

Re: [PATCH rdma] net/mlx5: Fix XRC SRQ umem valid bits

On Tue, Nov 06, 2018 at 04:31:08PM -0500, Doug Ledford wrote: > On Wed, 2018-10-31 at 12:20 +0200, Leon Romanovsky wrote: > > From: Yishai Hadas > > > > Adapt XRC SRQ to the latest HW specification with fixed definition > > around umem valid bits. The previous definition relied on a bit which >

Re: [PATCH rdma-next 3/4] IB/mlx5: Verify that driver supports user flags

On Sun, Oct 07, 2018 at 12:03:36PM +0300, Leon Romanovsky wrote: > From: Yonatan Cohen > > Flags sent down from user might not be supported by > running driver. > This might lead to unwanted bugs. > To solve this, added macro to test for unsupported flags. > > Signed-off-by: Yonatan Cohen >

Re: [PATCH rdma-next v1 0/7] Preparation to DevX extension series

On Thu, Sep 20, 2018 at 09:35:19PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Changelog v0->v1: > * Update commit messages > * Split DevX series to small sub-series. > * Change static initialization from {0} to be {} > > > Set uid as part of various IB commands so that the

Re: [PATCH rdma-next 0/4] mlx5 vport loopback

eon will respond with the branch commits. Depending on need I've been doing either a 'series merge' which looks like this: commit 8193abb6a8171c775503acd041eb957cc7e9e7f4 Merge: c1dfc0114c901b 25bb36e75d7d62 Author: Jason Gunthorpe Date: Wed Jul 4 13:19:46 2018 -0600 Merge branch 'm

Re: [PATCH rdma-next 1/5] RDMA/core: Provide getter and setter to access IB device name

On Thu, Sep 20, 2018 at 07:40:39PM +0300, Leon Romanovsky wrote: > > > The protection is done with global device_lock because it is used in > > > allocation and deallocation phases. At this stage, this lock is not > > > busy and easily can be moved to be per-device, once it will be needed. > > >

Re: [PATCH rdma-next 1/5] RDMA/core: Provide getter and setter to access IB device name

On Thu, Sep 20, 2018 at 02:21:58PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Prepare IB device name field to rename operation by ensuring that all > accesses to it are protected with lock and users don't see part of name. Oh dear, no, that isn't going to work, there is too much

Re: [PATCH mlx5-next 03/25] net/mlx5: Set uid as part of RQ commands

On Wed, Sep 19, 2018 at 11:40:45AM -0700, Saeed Mahameed wrote: > On Wed, Sep 19, 2018 at 10:28 AM Jason Gunthorpe wrote: > > > > On Mon, Sep 17, 2018 at 02:03:56PM +0300, Leon Romanovsky wrote: > > > From: Yishai Hadas > > > > > > Set uid as part of R

Re: [PATCH rdma-next 00/24] Extend DEVX functionality

On Mon, Sep 17, 2018 at 02:03:53PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > From Yishai, > > This series comes to enable the DEVX functionality in some wider scope, > specifically, > - It enables using kernel objects that were created by the verbs > API in the DEVX flow. > -

Re: [PATCH mlx5-next 07/25] net/mlx5: Update mlx5_ifc with DEVX UID bits

On Mon, Sep 17, 2018 at 02:04:00PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Add DEVX information to WQ, SRQ, CQ, TRI, TIS, QP, > RQ, XRCD, PD, MKEY and MCG. > > Signed-off-by: Leon Romanovsky > --- > include/linux/mlx5/mlx5_ifc.h | 67 >

Re: [PATCH mlx5-next 03/25] net/mlx5: Set uid as part of RQ commands

On Mon, Sep 17, 2018 at 02:03:56PM +0300, Leon Romanovsky wrote: > From: Yishai Hadas > > Set uid as part of RQ commands so that the firmware can manage the > RQ object in a secured way. > > That will enable using an RQ that was created by verbs application > to be used by the DEVX flow in case

Re: [PATCH mlx5-next 02/25] net/mlx5: Set uid as part of QP commands

On Mon, Sep 17, 2018 at 02:03:55PM +0300, Leon Romanovsky wrote: > From: Yishai Hadas > > Set uid as part of QP commands so that the firmware can manage the > QP object in a secured way. > > That will enable using a QP that was created by verbs application to > be used by the DEVX flow in case

Re: [PATCH] cxgb4: fix abort_req_rss6 struct

On Fri, Aug 31, 2018 at 11:52:00AM -0700, Steve Wise wrote: > Remove the incorrect WR_HDR field which can cause a misinterpretation > of this CPL by ULDs. > > Fixes: a3cdaa69e4ae ("cxgb4: Adds CPL support for Shared Receive Queues") > Signed-off-by: Steve Wise > --- > > Dave, Doug, and Jason, >

Re: [PATCH v4 3/3] IB/ipoib: Log sysfs 'dev_id' accesses from userspace

On Fri, Sep 07, 2018 at 01:14:51PM -0400, Doug Ledford wrote: > On Fri, 2018-09-07 at 09:43 -0600, Jason Gunthorpe wrote: > > On Thu, Sep 06, 2018 at 05:51:12PM +0300, Arseny Maslennikov wrote: > > > Some tools may currently be using only the deprecated attribute; > > &g

Re: [PATCH v4 3/3] IB/ipoib: Log sysfs 'dev_id' accesses from userspace

On Thu, Sep 06, 2018 at 05:51:12PM +0300, Arseny Maslennikov wrote: > Some tools may currently be using only the deprecated attribute; > let's print an elaborate and clear deprecation notice to kmsg. > > To do that, we have to replace the whole sysfs file, since we inherit > the original one from

Re: [PATCH] cxgb4: fix abort_req_rss6 struct

On Fri, Aug 31, 2018 at 11:52:00AM -0700, Steve Wise wrote: > Remove the incorrect WR_HDR field which can cause a misinterpretation > of this CPL by ULDs. What does that mean? Is this an -rc patch? Jason

Re: [PATCH rdma-next v1 00/15] Flow actions to mutate packets

On Wed, Sep 05, 2018 at 08:14:58AM +0300, Leon Romanovsky wrote: > > This looks OK to me, can you make the shared commit please? > > Thanks, I pushed to mlx5-next > > 50acec06f392 net/mlx5: Export packet reformat alloc/dealloc functions > 31ca3648f01b net/mlx5: Pass a namespace for packet

Re: [PATCH rdma-next v1 12/15] RDMA/mlx5: Add a new flow action verb - modify header

On Wed, Sep 05, 2018 at 08:20:44AM +0300, Leon Romanovsky wrote: > On Tue, Sep 04, 2018 at 03:58:23PM -0600, Jason Gunthorpe wrote: > > On Tue, Aug 28, 2018 at 02:18:51PM +0300, Leon Romanovsky wrote: > > > > > +static int > > > UVERBS_HANDLER(MLX5_IB_METHOD

Re: [PATCH mlx5-next v1 05/15] net/mlx5: Break encap/decap into two separated flow table creation flags

On Wed, Sep 05, 2018 at 08:10:25AM +0300, Leon Romanovsky wrote: > > > - int en_encap_decap = !!(flags & MLX5_FLOW_TABLE_TUNNEL_EN); > > > + int en_encap = !!(flags & MLX5_FLOW_TABLE_TUNNEL_EN_ENCAP); > > > + int en_decap = !!(flags & MLX5_FLOW_TABLE_TUNNEL_EN_DECAP); > > > > Yuk, please don't use

Re: [PATCH rdma-next v1 00/15] Flow actions to mutate packets

On Tue, Aug 28, 2018 at 02:18:39PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > >From Mark, > > This series exposes the ability to create flow actions which can > mutate packet headers. We do that by exposing two new verbs: > * modify header - can change existing packet headers.

Re: [PATCH mlx5-next v1 05/15] net/mlx5: Break encap/decap into two separated flow table creation flags

On Tue, Aug 28, 2018 at 02:18:44PM +0300, Leon Romanovsky wrote: > From: Mark Bloch > > Today we are able to attach encap and decap actions only to the FDB. In > preparation to enable those actions on the NIC flow tables, break the > single flag into two. Those flags control whatever a decap or

Re: [PATCH rdma-next v1 12/15] RDMA/mlx5: Add a new flow action verb - modify header

On Tue, Aug 28, 2018 at 02:18:51PM +0300, Leon Romanovsky wrote: > +static int UVERBS_HANDLER(MLX5_IB_METHOD_FLOW_ACTION_CREATE_MODIFY_HEADER)( > + struct ib_uverbs_file *file, > + struct uverbs_attr_bundle *attrs) > +{ > + struct ib_uobject *uobj = uverbs_attr_get_uobject( > +

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

On Fri, Aug 17, 2018 at 01:03:20PM -0700, Sagi Grimberg wrote: > > > Hey Sagi, > > > > The patch works allowing connections for the various affinity mappings > > below: > > > > One comp_vector per core across all cores, starting with numa-local cores: > > Thanks Steve, is this your "Tested

[PATCH] Revert "net/smc: Replace ib_query_gid with rdma_get_gid_attr"

. Signed-off-by: Jason Gunthorpe --- include/rdma/ib_cache.h | 1 + net/smc/smc_core.c | 19 ++- net/smc/smc_ib.c| 24 ++-- 3 files changed, 21 insertions(+), 23 deletions(-) As discussed before, the above patch to SMC in the rdma.git causes too

Re: [PATCH 0/3] net, IB/ipoib: Use dev_port to disambiguate

On Mon, Aug 13, 2018 at 02:42:21PM +0300, Arseny Maslennikov wrote: > Pre-3.15 userspace had trouble distinguishing different ports of a NIC > on a single PCI bus/device/function. To solve this, a sysfs field `dev_port' > was introduced quite a while ago (commit v3.14-rc3-739-g3f85944fe207), and >

Re: [PATCH rdma-next 00/10] IPoIB uninit

; IB/ipoib: Make ipoib_neigh_hash_uninit fully fence its work > > Jason Gunthorpe (8): > IB/ipoib: Get rid of IPOIB_FLAG_GOING_DOWN > IB/ipoib: Move all uninit code into ndo_uninit > IB/ipoib: Move init code to ndo_init > RDMA/netdev: Use priv_destructor for netdev

Re: [PATCH rdma-next 00/27] Flow actions to mutate packets

On Sun, Jul 29, 2018 at 03:58:38PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi, > > This is PATCH variant of RFC posted in previous week to the ML. > https://patchwork.ozlabs.org/cover/944184/ > > Changelog: > RFC -> v0: > * Patch 1 a new patch which refactors the logic >

Re: [PATCH rdma-next v2 0/8] Support mlx5 flow steering with RAW data

On Thu, Jul 26, 2018 at 07:35:49AM +0300, Leon Romanovsky wrote: > On Wed, Jul 25, 2018 at 08:35:17AM -0600, Jason Gunthorpe wrote: > > On Wed, Jul 25, 2018 at 08:37:03AM +0300, Leon Romanovsky wrote: > > > > > > Also, I would like to keep the specs consi

Re: [PATCH rdma-next v2 0/8] Support mlx5 flow steering with RAW data

On Wed, Jul 25, 2018 at 08:37:03AM +0300, Leon Romanovsky wrote: > > Also, I would like to keep the specs consistently formatted according > > to clang-format with 'BinPackParameters: true', so I reflowed them as > > well. > > I'm using default VIM clang-format.py without anything in

Re: [PATCH rdma-next v2 0/8] Support mlx5 flow steering with RAW data

On Tue, Jul 24, 2018 at 02:13:00PM -0600, Jason Gunthorpe wrote: > diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h > b/drivers/infiniband/hw/mlx5/mlx5_ib.h > index 5f08b69f8a4f60..ec8410d3c4eb2a 100644 > +++ b/drivers/infiniband/hw/mlx5/mlx5_ib.h > @@ -1232,11

Re: [PATCH rdma-next v2 0/8] Support mlx5 flow steering with RAW data

On Tue, Jul 24, 2018 at 08:56:09AM +0300, Leon Romanovsky wrote: > On Mon, Jul 23, 2018 at 08:42:36PM -0600, Jason Gunthorpe wrote: > > On Mon, Jul 23, 2018 at 03:25:04PM +0300, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > Changelog: >

Re: [PATCH rdma-next v2 0/8] Support mlx5 flow steering with RAW data

On Mon, Jul 23, 2018 at 03:25:04PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Changelog: > v1->v2: > * Fix matcher to use the correct size. > * Rephrase commit log of the first patch. > v0->v1: > * Fixed ADD_UVERBS_ATTRIBUTES_SIMPLE macro to pass the real address. > ?*

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

On Fri, Jul 20, 2018 at 04:25:32AM +0300, Max Gurtovoy wrote: > > >>>[ 2032.194376] nvme nvme0: failed to connect queue: 9 ret=-18 > >> > >>queue 9 is not mapped (overlap). > >>please try the bellow: > >> > > > >This seems to work.  Here are three mapping cases:  each vector on its > >own cpu,

Re: [PATCH mlx5-next v1 2/8] net/mlx5: Add support for flow table destination number

On Fri, Jul 13, 2018 at 12:51:10AM +0300, Or Gerlitz wrote: > On Fri, Jul 13, 2018 at 12:26 AM, Jason Gunthorpe wrote: > > On Fri, Jul 13, 2018 at 12:00:41AM +0300, Or Gerlitz wrote: > >> On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: > >> > From: Yishai Ha

Re: [PATCH mlx5-next v1 2/8] net/mlx5: Add support for flow table destination number

On Fri, Jul 13, 2018 at 12:00:41AM +0300, Or Gerlitz wrote: > On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: > > From: Yishai Hadas > > > > Add support to set a destination from a flow table number. > > This functionality will be used in downstream patches from this > > series by the

Re: [PATCH rdma-next 4/9] IB/mlx5: Introduce flow steering matcher object

On Wed, Jul 11, 2018 at 12:32:56PM +0300, Yishai Hadas wrote: > >>+static int UVERBS_HANDLER(MLX5_IB_METHOD_FLOW_MATCHER_CREATE)(struct > >>ib_device *ib_dev, > >>+ struct ib_uverbs_file *file, > >>+ struct uverbs_attr_bundle *attrs) >

Re: [PATCH rdma-next 6/9] IB/mlx5: Introduce vendor create and destroy flow methods

On Sun, Jul 08, 2018 at 01:24:42PM +0300, Leon Romanovsky wrote: > +static int UVERBS_HANDLER(MLX5_IB_METHOD_CREATE_FLOW)(struct ib_device > *ib_dev, > + struct ib_uverbs_file > *file, > + struct

Re: [PATCH rdma-next 4/9] IB/mlx5: Introduce flow steering matcher object

On Sun, Jul 08, 2018 at 01:24:40PM +0300, Leon Romanovsky wrote: > From: Yishai Hadas > > Introduce flow steering matcher object and its create and destroy > methods. > > This matcher object holds some mlx5 specific driver properties that > matches the underlay device specification when an mlx5

Re: [PATCH rdma-next 0/9] Support mlx5 flow steering with RAW data

On Sun, Jul 08, 2018 at 01:24:36PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > >From Yishai: > > This series introduces vendor create and destroy flow methods on the > uverbs flow object by using the KABI infra-structure. > > It's done in a way that enables the driver to get its

Re: [PATCH net-next] qed: Add srq core support for RoCE and iWARP

On Wed, May 30, 2018 at 04:11:37PM +0300, Yuval Bason wrote: > This patch adds support for configuring SRQ and provides the necessary > APIs for rdma upper layer driver (qedr) to enable the SRQ feature. > > Signed-off-by: Michal Kalderon > Signed-off-by: Ariel Elior > Signed-off-by: Yuval Bason

Re: [PATCH rdma-next 0/3] Dump and fill MKEY

On Wed, Jul 04, 2018 at 09:54:59PM +0300, Leon Romanovsky wrote: > On Wed, Jul 04, 2018 at 11:47:39AM -0600, Jason Gunthorpe wrote: > > On Tue, Jun 19, 2018 at 08:47:21AM +0300, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > MLX5 IB HCA o

Re: [PATCH rdma-next 3/3] IB/mlx5: Expose dump and fill memory key

On Tue, Jun 19, 2018 at 08:47:24AM +0300, Leon Romanovsky wrote: > From: Yonatan Cohen > > MLX5 IB HCA offers the memory key, dump_fill_mkey to boost > performance, when used in a send or receive operations. > > It is used to force local HCA operations to skip the PCI bus access, > while

Re: [PATCH rdma-next 0/3] Dump and fill MKEY

On Tue, Jun 19, 2018 at 08:47:21AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > MLX5 IB HCA offers the memory key, dump_fill_mkey to increase > performance, when used in a send or receive operations. > > It is used to force local HCA operations to skip the PCI bus access, > while

Re: [PATCH rdma-next 00/12] RDMA fixes 2018-06-24

On Tue, Jun 26, 2018 at 07:21:26AM +0300, Leon Romanovsky wrote: > On Mon, Jun 25, 2018 at 03:34:38PM -0600, Jason Gunthorpe wrote: > > On Sun, Jun 24, 2018 at 11:23:41AM +0300, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > Hi, > >

Re: [PATCH rdma-next 00/12] RDMA fixes 2018-06-24

On Sun, Jun 24, 2018 at 11:23:41AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi, > > This is bunch of patches trigged by running syzkaller internally. > > I'm sending them based on rdma-next mainly for two reasons: > 1, Most of the patches fix the old issues and it doesn't

Re: [PATCH rdma-next 01/12] RDMA/uverbs: Protect from attempts to create flows on unsupported QP

On Sun, Jun 24, 2018 at 11:23:42AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Flows can be created on UD and RAW_PACKET QP types. Attempts to provide > other QP types as an input causes to various unpredictable failures. > > The reason to it that in order to support all various

Re: [PATCH rdma-next 09/12] RDMA/mlx5: Fix shift overflow in mlx5_ib_create_wq

On Mon, Jun 25, 2018 at 11:10:41AM +0300, Leon Romanovsky wrote: > On Sun, Jun 24, 2018 at 01:56:24PM -0600, Jason Gunthorpe wrote: > > On Sun, Jun 24, 2018 at 11:23:50AM +0300, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > [ 6

Re: [PATCH rdma-next 06/12] RDMA/uverbs: Don't overwrite NULL pointer with ZERO_SIZE_PTR

On Sun, Jun 24, 2018 at 11:23:47AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Number of specs is provided by user and in valid case can be equal to zero. > Such argument causes to call to kcalloc() with zero-length request and in > return the ZERO_SIZE_PTR is assigned. This

Re: [PATCH rdma-next 09/12] RDMA/mlx5: Fix shift overflow in mlx5_ib_create_wq

On Sun, Jun 24, 2018 at 11:23:50AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > [ 61.182439] UBSAN: Undefined behaviour in > drivers/infiniband/hw/mlx5/qp.c:5366:34 > [ 61.183673] shift exponent 4294967288 is too large for 32-bit type > 'unsigned int' > [ 61.185530] CPU: 0

Re: [PATCH rdma-next 0/2] RoCE ICRC counter

On Thu, Jun 21, 2018 at 03:37:54PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi, > > This series exposes RoCE ICRC counter through existing RDMA hw_counters > sysfs interface. > > First patch has all HW definitions in mlx5_ifc.h file and second patch is > actual counter

Re: [PATCH rdma-next 0/2] RoCE ICRC counter

On Thu, Jun 21, 2018 at 03:37:54PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi, > > This series exposes RoCE ICRC counter through existing RDMA hw_counters > sysfs interface. > > First patch has all HW definitions in mlx5_ifc.h file and second patch is > actual counter

Re: [PATCH rdma-next 0/3] Dump and fill MKEY

On Tue, Jun 19, 2018 at 08:47:21AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > MLX5 IB HCA offers the memory key, dump_fill_mkey to increase > performance, when used in a send or receive operations. > > It is used to force local HCA operations to skip the PCI bus access, > while

Re: [PATCH rdma-next v2 00/20] Introduce mlx5 DEVX interface

On Sun, Jun 17, 2018 at 12:59:46PM +0300, Leon Romanovsky wrote: > Leon Romanovsky (2): > drm/i915: Move u64-to-ptr helpers to general header > kernel.h: Reuse u64_to_ptr macro to cast __user pointers I dropped these since they are not needed by this series when using a union. > Matan

Re: [PATCH rdma-next v2 06/20] IB/uverbs: Add PTR_IN attributes that are allocated/copied automatically

On Sun, Jun 17, 2018 at 12:59:52PM +0300, Leon Romanovsky wrote: > From: Matan Barak > > Adding UVERBS_ATTR_SPEC_F_ALLOC_AND_COPY flag to PTR_IN attributes. > By using this flag, the parse automatically allocates and copies the > user-space data. This data is accessible by using

Re: [PATCH rdma-next v2 09/20] IB/core: Improve uverbs_cleanup_ucontext algorithm

On Sun, Jun 17, 2018 at 12:59:55PM +0300, Leon Romanovsky wrote: > +void uverbs_cleanup_ucontext(struct ib_ucontext *ucontext, bool > device_removed) > +{ > /* >* Waits for all remove_commit and alloc_commit to finish. Logically, We >* want to hold this forever as the

Re: [PATCH rdma-next v3 00/14] Verbs flow counters support

On Sat, Jun 02, 2018 at 08:04:19AM +0300, Leon Romanovsky wrote: > On Fri, Jun 01, 2018 at 03:11:49PM -0600, Jason Gunthorpe wrote: > > On Thu, May 31, 2018 at 04:43:27PM +0300, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > Changelog: &g

Re: [PATCH rdma-next v3 00/14] Verbs flow counters support

counters allocation failure > * Added Tested-by > * Minimize time spent holding mutex lock > * Fixed deadlock caused by nested lock in error path > * Protect from handler pointer derefence in the error paths Okay, Acked-by: Jason Gunthorpe I've revised some of the commit messages, fi

Re: [PATCH rdma-next v3 05/14] IB/uverbs: Add create/destroy counters support

> diff --git a/drivers/infiniband/core/uverbs_std_types_counters.c > b/drivers/infiniband/core/uverbs_std_types_counters.c > new file mode 100644 > index ..a5bc50ceee13 > +++ b/drivers/infiniband/core/uverbs_std_types_counters.c > @@ -0,0 +1,100 @@ > +/* SPDX-License-Identifier:

Re: [PATCH mlx5-next v2 11/13] IB/mlx5: Add flow counters binding support

On Wed, May 30, 2018 at 06:24:00PM +0300, Yishai Hadas wrote: > On 5/30/2018 6:06 PM, Jason Gunthorpe wrote: > >On Wed, May 30, 2018 at 03:31:34PM +0300, Yishai Hadas wrote: > >>On 5/29/2018 10:56 PM, Jason Gunthorpe wrote: > >>>On Tue, May 29, 2018 at 04:09:15P

Re: [PATCH mlx5-next v2 11/13] IB/mlx5: Add flow counters binding support

On Wed, May 30, 2018 at 03:31:34PM +0300, Yishai Hadas wrote: > On 5/29/2018 10:56 PM, Jason Gunthorpe wrote: > >On Tue, May 29, 2018 at 04:09:15PM +0300, Leon Romanovsky wrote: > >>diff --git a/include/uapi/rdma/mlx5-abi.h b/include/uapi/rdma/mlx5-abi.h > >>index 508ea8

Re: [PATCH mlx5-next 1/3] net/mlx5: Exposing a new mini-CQE format

On Tue, May 29, 2018 at 03:01:27PM -0600, Saeed Mahameed wrote: > On Sun, 2018-05-27 at 13:42 +0300, Leon Romanovsky wrote: > > From: Yonatan Cohen > > > > The new mini-CQE format includes byte-count, checksum > > and stride index. > > > > Reviewed-by: Yishai Hadas > > Reviewed-by: Guy Levi >

Re: [PATCH rdma-next v2 01/13] IB/uverbs: Add an ib_uobject getter to ioctl() infrastructure

On Tue, May 29, 2018 at 08:49:58PM +, Ruhl, Michael J wrote: > >From: Jason Gunthorpe [mailto:j...@mellanox.com] > >Sent: Tuesday, May 29, 2018 4:21 PM > >To: Ruhl, Michael J > >Cc: Leon Romanovsky ; Doug Ledford > >; Leon Romanovsky ; RDMA > >mailing li

Re: [PATCH rdma-next v2 01/13] IB/uverbs: Add an ib_uobject getter to ioctl() infrastructure

On Tue, May 29, 2018 at 07:31:22PM +, Ruhl, Michael J wrote: > >-struct ib_uverbs_destroy_cq_resp resp; > > struct ib_uobject *uobj = > >-uverbs_attr_get(attrs, > >UVERBS_ATTR_DESTROY_CQ_HANDLE)->obj_attr.uobject; > >-struct ib_ucq_object *obj = container_of(uobj,

Re: [PATCH rdma-next 0/3] Introduce new mlx5 CQE format

On Sun, May 27, 2018 at 01:42:31PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Introduce new internal to mlx5 CQE format - mini-CQE. It is a CQE in > compressed form that holds data needed to extra a single full CQE. > > It stride index, byte count and packet checksum. > > Thanks

Re: [PATCH mlx5-next v2 11/13] IB/mlx5: Add flow counters binding support

On Tue, May 29, 2018 at 04:09:15PM +0300, Leon Romanovsky wrote: > diff --git a/include/uapi/rdma/mlx5-abi.h b/include/uapi/rdma/mlx5-abi.h > index 508ea8c82da7..ef3f430a7050 100644 > +++ b/include/uapi/rdma/mlx5-abi.h > @@ -443,4 +443,18 @@ enum { > enum { > MLX5_IB_CLOCK_INFO_V1

Re: [PATCH rdma-next v1 11/13] IB/mlx5: Add flow counters binding support

On Sun, May 27, 2018 at 01:23:44PM +0300, Leon Romanovsky wrote: > + if (!mcounters->hw_cntrs_hndl) { > + mcounters->hw_cntrs_hndl = > + (void > *)mlx5_fc_create(to_mdev(ibcounters->device)->mdev, > +false); No

Re: [PATCH rdma-next 3/3] IB/mlx5: Introduce a new mini-CQE format

On Mon, May 28, 2018 at 07:52:03PM +0300, Yishai Hadas wrote: > On 5/28/2018 7:11 PM, Jason Gunthorpe wrote: > >On Sun, May 27, 2018 at 01:42:34PM +0300, Leon Romanovsky wrote: > >>From: Yonatan Cohen > >> > >>The new mini-CQE format includes the stride index

Re: [PATCH] IB: Revert "remove redundant INFINIBAND kconfig dependencies"

On Fri, May 25, 2018 at 11:29:59PM +0200, Arnd Bergmann wrote: > Several subsystems depend on INFINIBAND_ADDR_TRANS, which in turn depends > on INFINIBAND. However, when with CONFIG_INIFIBAND=m, this leads to a > link error when another driver using it is built-in. The > INFINIBAND_ADDR_TRANS

Re: [PATCH] IB: Revert "remove redundant INFINIBAND kconfig dependencies"

On Fri, May 25, 2018 at 05:32:52PM -0700, Greg Thelen wrote: > On Fri, May 25, 2018 at 2:32 PM Arnd Bergmann wrote: > > > Several subsystems depend on INFINIBAND_ADDR_TRANS, which in turn depends > > on INFINIBAND. However, when with CONFIG_INIFIBAND=m, this leads to a > > link

Re: [PATCH rdma-next 3/3] IB/mlx5: Introduce a new mini-CQE format

On Sun, May 27, 2018 at 01:42:34PM +0300, Leon Romanovsky wrote: > From: Yonatan Cohen > > The new mini-CQE format includes the stride index, byte count and > packet checksum. > Stride index is needed for striding WQ feature. > This patch exposes this capability and

Re: [net-next] i40iw/i40e: Remove link dependency on i40e

On Wed, May 23, 2018 at 08:03:44AM -0700, Alexander Duyck wrote: > On Tue, May 22, 2018 at 11:19 PM, Christoph Hellwig > wrote: > > On Tue, May 22, 2018 at 02:04:06PM -0700, Jeff Kirsher wrote: > >> > Why would you want to do this? The rdma driver is non-functional > >> >

Re: [net-next] i40iw/i40e: Remove link dependency on i40e

On Tue, May 22, 2018 at 02:50:32PM -0700, Jeff Kirsher wrote: > On Tue, 2018-05-22 at 15:33 -0600, Jason Gunthorpe wrote: > > On Tue, May 22, 2018 at 02:04:06PM -0700, Jeff Kirsher wrote: > > > On Tue, 2018-05-22 at 14:56 -0600, Jason Gunthorpe wrote: > > > > On T

Re: [net-next] i40iw/i40e: Remove link dependency on i40e

On Tue, May 22, 2018 at 02:04:06PM -0700, Jeff Kirsher wrote: > On Tue, 2018-05-22 at 14:56 -0600, Jason Gunthorpe wrote: > > On Tue, May 22, 2018 at 01:38:31PM -0700, Jeff Kirsher wrote: > > > From: Sindhu Devale <sindhu.dev...@intel.com> > > > > > > Cu

Re: [net-next] i40iw/i40e: Remove link dependency on i40e

On Tue, May 22, 2018 at 01:38:31PM -0700, Jeff Kirsher wrote: > From: Sindhu Devale > > Currently i40iw is dependent on i40e symbols > i40e_register_client and i40e_unregister_client due to > which i40iw cannot be loaded without i40e being loaded. > > This patch allows

Re: [pull request][for-next 00/15] Mellanox, mlx5 core and netdev updates 2018-05-17

On Fri, May 18, 2018 at 01:03:51PM -0400, David Miller wrote: > From: Saeed Mahameed > Date: Thu, 17 May 2018 18:22:43 -0700 > > > Below you can find two pull requests, > > > > 1. mlx5 core updates to be shared for both netdev and RDMA, (patches 1..9) > > which is based on

Re: [PATCH v2] {net, IB}/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()'

49,7 @@ static int create_cq_user(struct mlx5_ib_dev *dev, struct > ib_udata *udata, > return 0; > > err_cqb: > - kfree(*cqb); > + kvfree(*cqb); For the infiniband part: Acked-by: Jason Gunthorpe <j...@mellanox.com> Since this is mostly ethernet, can it go through netdev? thanks Jason

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

On Tue, May 15, 2018 at 10:02:08AM -0500, Steve Wise wrote: > > On Tue, May 15, 2018 at 09:31:27AM -0500, Steve Wise wrote: > > > > cap net admin is not high enough privledge to see unhashed kernel > > > > pointers. CAP_RAW_IO? Or follow what printk does? > > > > > > > > > > Do you mean

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

On Tue, May 15, 2018 at 09:31:27AM -0500, Steve Wise wrote: > > cap net admin is not high enough privledge to see unhashed kernel > > pointers. CAP_RAW_IO? Or follow what printk does? > > > > Do you mean CAP_NET_RAW? Here's the comments for it: Nope.. > Func restricted_pointer() from

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

On Tue, May 15, 2018 at 08:18:51AM -0500, Steve Wise wrote: > > > > On Mon, May 14, 2018 at 05:04:26PM -0500, Steve Wise wrote: > > > > > > > > > > > > On 5/14/2018 3:41 PM, Jason Gunthorpe wrote: > > > > > On Mon, May 07, 2018 at

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: > This enhancement allows printing rdma device-specific state, if provided > by the kernel. This is done in a generic manner, so rdma tool doesn't > need to know about the details of every type of rdma device. > > Driver attributes for

[PATCH for-rc] uapi: Fix SPDX tags for files referring to the 'OpenIB.org' license

it links to an obsolete web site that contains a license that matches the BSD-2-Clause SPX. There is no 'three clause' version of the OpenIB.org license. Signed-off-by: Jason Gunthorpe <j...@mellanox.com> --- include/uapi/linux/if_infiniband.h | 2 +- include/uapi/linux/rds.h

Re: [PATCH] net/mlx5: remove some extraneous spaces in indentations

On Tue, Apr 10, 2018 at 05:22:54PM -0600, Jason Gunthorpe wrote: > On Mon, Apr 09, 2018 at 01:43:36PM +0100, Colin Ian King wrote: > > From: Colin Ian King <colin.k...@canonical.com> > > > > There are several lines where there is an extraneous space causing > >

Re: [PATCH] net/mlx5: remove some extraneous spaces in indentations

On Mon, Apr 09, 2018 at 01:43:36PM +0100, Colin Ian King wrote: > From: Colin Ian King > > There are several lines where there is an extraneous space causing > indentation misalignment. Remove them. > > Cleans up Cocconelle warnings: > >

Re: [PATCH v2 net-next] qed*: Utilize FW 8.33.11.0

|4 +- > include/linux/qed/rdma_common.h|2 + > include/linux/qed/roce_common.h|3 + > 14 files changed, 1310 insertions(+), 1147 deletions(-) For drivers/infiniband: Acked-by: Jason Gunthorpe <j...@mellanox.com> Jason

Re: [PATCH net-next] qed*: Utilize FW 8.33.11.0

On Tue, Mar 27, 2018 at 08:50:24PM +0300, Leon Romanovsky wrote: > On Tue, Mar 27, 2018 at 05:41:51PM +, Kalderon, Michal wrote: > > > From: Jason Gunthorpe [mailto:j...@ziepe.ca] > > > Sent: Tuesday, March 27, 2018 12:18 AM > > > > diff --git a/drivers/in

Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

On Tue, Mar 27, 2018 at 06:15:44PM +0300, Leon Romanovsky wrote: > On Tue, Mar 27, 2018 at 08:44:55AM -0600, Jason Gunthorpe wrote: > > On Tue, Mar 27, 2018 at 06:21:41AM +0300, Leon Romanovsky wrote: > > > On Mon, Mar 26, 2018 at 04:30:33PM -0600, Jason Gunthorpe wrote: >

  1   2   3   >