[PATCH Repost to netdev] virtio_net: Fix recursive call to cpus_read_lock()

2020-12-22 Thread Jeff Dike
netif_reset_xps_queues - calls cpus_read_lock() This call chain and potential deadlock happens when the number of TX queues is reduced. This commit the removes netif_set_real_num_[tr]x_queues calls from inside the get/put_online_cpus section, as they don't require that it be held. Signed-off-by: Jeff

Re: [PATCH net V3] Exempt multicast addresses from five-second neighbor lifetime

2020-11-12 Thread Jeff Dike
Hi Jakub, Yes to all your suggestions. Thanks for the review. Jeff On 11/12/20 12:32 PM, Jakub Kicinski wrote: > On Tue, 10 Nov 2020 12:23:05 -0500 Jeff Dike wrote: >> Commit 58956317c8de ("neighbor: Improve garbage collection") >> guarantees neighbour table entri

[PATCH net V4] Exempt multicast addresses from five-second neighbor lifetime

2020-11-12 Thread Jeff Dike
addresses and makes messages to all addresses more reliable in these circumstances. Fixes: 58956317c8de ("neighbor: Improve garbage collection") Signed-off-by: Jeff Dike --- include/net/neighbour.h | 1 + net/core/neighbour.c| 2 ++ net/ipv4/arp.c | 6 ++ net/ipv6/nd

[PATCH net V3] Exempt multicast addresses from five-second neighbor lifetime

2020-11-10 Thread Jeff Dike
addresses and makes messages to all addresses more reliable in these circumstances. Signed-off-by: Jeff Dike --- include/net/neighbour.h | 1 + net/core/neighbour.c| 2 ++ net/ipv4/arp.c | 6 ++ net/ipv6/ndisc.c| 7 +++ 4 files changed, 16 insertions(+) diff --git

Re: [PATCH net V2] Exempt multicast addresses from five-second neighbor lifetime

2020-11-10 Thread Jeff Dike
Hi David, On 11/9/20 10:55 PM, David Ahern wrote: > ipv6_addr_type() and IPV6_ADDR_MULTICAST is the better way to code this. Thanks, will fix. Jeff

Re: [PATCH net V2] Exempt multicast addresses from five-second neighbor lifetime

2020-11-10 Thread Jeff Dike
Hi Jakub, On 11/9/20 2:47 PM, Jakub Kicinski wrote: > This makes sense because mcast L2 addr is calculated, not discovered, > and therefore can be recreated at a very low cost, correct? Yes. > Perhaps it would make sense to widen the API to any "computed" address > rather than implicitly dependi

[PATCH net V2] Exempt multicast addresses from five-second neighbor lifetime

2020-11-08 Thread Jeff Dike
addresses and makes messages to all addresses more reliable in these circumstances. Signed-off-by: Jeff Dike --- include/net/neighbour.h | 1 + net/core/neighbour.c| 2 ++ net/ipv4/arp.c | 6 ++ net/ipv6/ndisc.c| 7 +++ 4 files changed, 16 insertions(+) diff --git

[PATCH net-next] Exempt multicast addresses from five-second neighbor lifetime

2020-11-02 Thread Jeff Dike
addresses and makes messages to all addresses more reliable in these circumstances. Signed-off-by: Jeff Dike --- include/net/neighbour.h | 1 + net/core/neighbour.c| 2 ++ net/ipv4/arp.c | 8 net/ipv6/ndisc.c| 7 +++ 4 files changed, 18 insertions(+) diff --git

Re: [RFC] Exempt multicast address from five-second neighbor lifetime

2020-10-19 Thread Jeff Dike
Hi Jesse, > Your subject should indicate net or net-next as the tree, please see: I was intending more to see if this is an intrinsically bad idea than for it to go directly into a tree right now. > Not sure how many patches you've submitted, but your commit message > should be wrapped at 68 or

[RFC] Exempt multicast address from five-second neighbor lifetime

2020-10-16 Thread Jeff Dike
icast addresses to be thrown out before they've lived out their five seconds. Signed-off-by: Jeff Dike diff --git a/include/net/neighbour.h b/include/net/neighbour.h index 81ee17594c32..22ced1381ede 100644 --- a/include/net/neighbour.h +++ b/include/net/neighbour.h @@ -204,6 +204,7 @@ struct n

Re: drivers/infiniband/mlx/mad.c misplaced ;

2007-08-16 Thread Jeff Dike
On Wed, Aug 15, 2007 at 05:40:11PM -0700, Joe Perches wrote: > fs/hostfs/hostfs_user.c:if(attrs->ia_valid & HOSTFS_ATTR_CTIME) ; This one can be deleted, but I think I did it for documentation reasons, to make it clear that ctime handling wasn't left out by mistake.

Re: [PATCH] Allow group ownership of TUN/TAP devices (fwd)

2007-06-21 Thread Jeff Dike
ership setting of tap devices. The user now is allowed to send packages if either his euid or his egid matches the one specified via tunctl (via -u or -g respecitvely). If both, gid and uid, are set via tunctl, both have to match. Signed-Off-By: Guido Guenther <[EMAIL PROTECTED]> Signed-Of

Re: [PATCH 14/21] uml: enable scsi and add iscsi config

2006-09-11 Thread Jeff Dike
On Wed, Sep 06, 2006 at 03:16:44PM +0200, Peter Zijlstra wrote: > Enable iSCSI on UML, dunno why SCSI was deemed broken, it works like a charm. Acked-by: Jeff Dike <[EMAIL PROTECTED]> Although it would be nice if we didn't have to copy bits of Kconfig fi