Re: [patch 0/6] pasemi_mac updates for 2.6.26

2008-02-26 Thread Jeff Garzik
Olof Johansson wrote: On Tue, Feb 26, 2008 at 08:49:58PM +1100, Paul Mackerras wrote: Olof Johansson writes: Here's a set of updates for pasemi_mac for 2.6.26. Some of them touch the dma_lib in the platform code as well, but it's easier if it's all merged through netdev to avoid dependencies.

Re: [RFC] ethtool netlink interface

2008-02-25 Thread Jeff Garzik
Thomas Graf wrote: Hello, Before I continue to finish this work I'd like to get a few comments on my implementation attempt. The following patch implements the ETHTOOL_SSET and ETHTOOL_GSET command via netlink. The individual commands are implemented as separate functions and hooked into a

Re: [PATCH] de2104x: remove BUG_ON() when changing media type

2008-02-25 Thread Jeff Garzik
Ondrej Zary wrote: When the chip dies (probably because of a bug somewhere in the driver), de_stop_rxtx() fails and changing the media type crashes the whole machine. Replace BUG_ON() in de_set_media() with a warning. Signed-off-by: Ondrej Zary [EMAIL PROTECTED] ---

Re: [git patches] net driver updates

2008-02-25 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray [EMAIL PROTECTED] Date: Wed, 20 Feb 2008 21:57:08 -0800 The driver is cxgb3 here, it uses LLTX. That's extremely unfortunate, hopefully you can update it to use a model like tg3 and others use. LLTX is a lost cause for hardware device drivers, and in fact

Re: [git patches] net driver updates

2008-02-25 Thread Jeff Garzik
Marin Mitov wrote: On Tuesday 26 February 2008 12:59:04 am you wrote: Divy Le Ray wrote: From: Divy Le Ray [EMAIL PROTECTED] Date: Wed, 20 Feb 2008 21:57:08 -0800 The driver is cxgb3 here, it uses LLTX. That's extremely unfortunate, hopefully you can update it to use a model like tg3 and

Re: [git patches] net driver updates

2008-02-25 Thread Jeff Garzik
Divy Le Ray wrote: So, it sounds like Krishna's patch is ok, because the race does not exist anymore in this driver? The first part is right indeed, but the second part is breaking the current usage of txq_stopped and the logic that stops and restarts the Tx queue. I can submit a patch

Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x

2008-02-24 Thread Jeff Garzik
Grant Grundler wrote: ISTR there was a time when tulip would compete with de4x5 for devices. tulip is the preferred driver. That's clearly no longer the case and perhaps both distro's need to revisit this. The only reason why de4x5 still exists is that the /tulip/ driver fails to work on a

Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x

2008-02-24 Thread Jeff Garzik
Grant Grundler wrote: On Mon, Feb 18, 2008 at 05:40:42PM +0100, Ondrej Zary wrote: I think that de2104x driver should be removed (or at least its MODULE_DEVICE_TABLE) and MODULE_DEVICE_TABLE with only 21040 and 21041 PCI IDs added to de4x5. I can send a patch if this is acceptable. It's

Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

2008-02-23 Thread Jeff Garzik
Sebastian Siewior wrote: so select it. Signed-off-by: Sebastian Siewior [EMAIL PROTECTED] --- drivers/net/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index f337800..a116056 100644 --- a/drivers/net/Kconfig +++

Re: [PATCH 2.6.25 2/4]S2io: Multiqueue network device support - FIFO selection based on L4 ports

2008-02-23 Thread Jeff Garzik
David Miller wrote: From: Patrick McHardy [EMAIL PROTECTED] Date: Thu, 21 Feb 2008 00:08:52 +0100 Ramkrishna Vepa wrote: Sreenivasa Honnur wrote: - Resubmit #2 - Transmit fifo selection based on TCP/UDP ports. - Added tx_steering_type loadable parameter for transmit fifo

Re: [PATCH 1/2]via-rhine.c: Use-register-offset-definition-for-WOLcgClr

2008-02-23 Thread Jeff Garzik
Laura Garcia wrote: Use register offset definition for WOLcgClr. This patch does not change the driver behaviour. Signed-off-by: Laura Garcia Liebana [EMAIL PROTECTED] modified: drivers/net/via-rhine.c --- drivers/net/via-rhine.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [PATCH] sky2: fix LED management

2008-02-23 Thread Jeff Garzik
Stephen Hemminger wrote: Fix problems in LED management, so ethtool -p works correctly on Yukon-EC and other chips. The driver was incorrectly setting the PHY LED overide bits. Moral: read the spec sheet, not the vendor driver. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] ---

Re: [PATCH 7/7] e1000e: remove unused read value in ASPM disable code.

2008-02-23 Thread Jeff Garzik
Auke Kok wrote: Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000e/netdev.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c index 7824bc2..fc5c63f 100644 --- a/drivers/net/e1000e/netdev.c +++

Re: [git patches] net driver fixes

2008-02-23 Thread Jeff Garzik
David Miller wrote: Jeff, I really don't want to pull that tree in. Please trust me as your upstream to handle merging issues, as needed. I trust you... Otherwise I wouldn't have volunteered to move my upstream from Linus to you :) My main issues/motivations were: * quite simply, just

Re: [PATCH] ehea: add kdump support

2008-02-20 Thread Jeff Garzik
Thomas Klein wrote: This patch adds kdump support to the ehea driver. As the firmware doesn't free resource handles automatically, the driver has to run an as simple as possible free resource function in case of a crash shutdown. The function iterates over two arrays freeing all resource handles

Re: [PATCH] fs_enet: Don't call phy_mii_ioctl() in atomic context.

2008-02-20 Thread Jeff Garzik
Scott Wood wrote: The lock acquisition in fs_ioctl() does not appear to actually be necessary, and thus is simply removed. Signed-off-by: Scott Wood [EMAIL PROTECTED] --- This fixes the following bug: http://ozlabs.org/pipermail/linuxppc-dev/2008-February/051564.html

Re: [PATCH] igb: fix legacy mode irq issue

2008-02-20 Thread Jeff Garzik
Auke Kok wrote: From: Andy Gospodarek [EMAIL PROTECTED] I booted an igb kernel with the option pci=nomsi and instantly noticed that interrupts no longer worked on my igb device. I took a look at the interrupt initialization and quickly discovered a comment stating: DO NOT USE EIAME or IAME in

Re: [PATCH] update TULIP MAINTAINERS

2008-02-20 Thread Jeff Garzik
Grant Grundler wrote: Jeff, Kyle and I are co-maintaining tulip driver. Normally kyle will review my patchs and submit them. I'll deal with bugzilla.kernel.org bugs and try to resolve those bugs. thanks, grant Signed-off-by: Grant Grundler [EMAIL PROTECTED] applied this and the uli patch

Re: [PATCH resend] virtio_net: Fix oops on early interrupts - introduced by virtio reset code

2008-02-20 Thread Jeff Garzik
Christian Borntraeger wrote: Am Montag, 11. Februar 2008 schrieb Anthony Liguori: The reset support is in Linus's tree so we should try to push it for -rc2. You are right. My repository was borked. will push it to Jeff Garzik. Thanks Jeff can you schedule this fix into your network driver

Re: [patch 1/1] claw: make use of DIV_ROUND_UP

2008-02-20 Thread Jeff Garzik
applied -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] tlan: add static to function definitions

2008-02-20 Thread Jeff Garzik
Harvey Harrison wrote: The forward declarations were already marked static, make the definitions be static as well. Fixes the sparse warnings as well. drivers/net/tlan.c:1403:5: warning: symbol 'TLan_HandleInvalid' was not declared. Should it be static? drivers/net/tlan.c:1435:5: warning:

Re: [PATCH 1/1] sis190: read the mac address from the eeprom first

2008-02-20 Thread Jeff Garzik
Francois Romieu wrote: Reading a serie of zero from the cmos sram area do not work well with is_valid_ether_addr(). Let's read the mac address from the eeprom first as it seems more reliable. Fix for http://bugzilla.kernel.org/show_bug.cgi?id=9831 Signed-off-by: Francois Romieu [EMAIL

Re: [PATCH v2.6.25] gianfar: don't pass NULL dev ptr to DMA ops

2008-02-20 Thread Jeff Garzik
Andy Fleming wrote: From: Becky Bruce [EMAIL PROTECTED] Change all dma op invocations in gianfar.c to actually pass in the device pointer. Currently, the value is ignored, but it will be used going forward as we implement archdata for 32-bit powerpc. Signed-off-by: Becky Bruce [EMAIL

Re: [PATCH] igb: Fix panic with NICs with 1000BASE-SX PHY

2008-02-20 Thread Jeff Garzik
Auke Kok wrote: From: Bill Hayes [EMAIL PROTECTED] This patch eliminates a kernel panic with the igb driver in 2.6.25-rc2 when running on a Intel 82575 Ethernet controller with a 1000BASE-SX PHY. The panic does not happen with the 1000BASE-T PHY, only with a SX connection. Signed-off-by:

Re: [2.6 patch] net/phy/mdio_bus.c: fix a check-after-use

2008-02-20 Thread Jeff Garzik
Adrian Bunk wrote: This patch fixes a check-after-use spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 6beeb3ac577d74d72b2f91bd654eecb904c3c17e diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 6e9f619..963630c 100644 ---

[git patches] net driver fixes

2008-02-20 Thread Jeff Garzik
Note: this is based off of Linus's latest commit (5d9c4a7de64d398604a978d267a6987f1f4025b7), since all my previous submissions are now upstream (thanks!). Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-davem to receive

Re: [git patches] net driver updates

2008-02-20 Thread Jeff Garzik
Divy Le Ray wrote: Jeff Garzik wrote: Mostly fixes, a few cleanups (generally assisting fixes), and an exception for PS3 wireless because it had been posted, reviewed and acked for a while, just not committed. Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel

Re: [PATCH] ixgbe: Correctly obtain protocol information on transmit

2008-02-15 Thread Jeff Garzik
Auke Kok wrote: In reply to RE: [Fwd: [PATCH 2.6.25] ixgbe/igb: correctly obtain protocol information on transmit] from Andy Gospodarek: The driver was incorrectly looking at socket headers for protocol information, needed for checksumming offload. Fix this by not looking at the socket but

Re: [PATCH 2/2] e1000e: PCIe devices do not need to unset MANC_ARP_ENA

2008-02-15 Thread Jeff Garzik
Auke Kok wrote: From: David Graham [EMAIL PROTECTED] Users reported that ARP's were lost with e1000e. The problem is fixed by not enabling this manageability configuration bit. None of the release_manageability code is actually needed as the normal device reset during a shutdown returns

Re: [patch] Fix station address detection in smc

2008-02-15 Thread Jeff Garzik
Chuck Ebbert wrote: Megahertz EM1144 PCMCIA ethernet adapter needs special handling because it has two VERS_1 tuples and the station address is in the second one. Conversion to generic handling of these fields broke it. Reverting that fixes the device.

[git patches] net driver fixes

2008-02-15 Thread Jeff Garzik
Process note: 'upstream-davem' continues the git history that began the previous push. This sometimes happens when I continue to commit locally, working in parallel while waiting for changes to hit Linus upstream. As current net-2.6.git appears to have the same commit ids that I submitted in

Re: [PATCH] e1000e: Fix CRC stripping in hardware context bug

2008-02-15 Thread Jeff Garzik
Auke Kok wrote: CRC stripping was only correctly enabled for packet split recieves which is used when receiving jumbo frames. Correctly enable SECRC also for normal buffer packet receives. Tested by Andy Gospodarek and Johan Andersson, see bugzilla #9940. Signed-off-by: Auke Kok [EMAIL

Re: [PATCH 2.6.25] igb: fix legacy mode irq issue

2008-02-15 Thread Jeff Garzik
Andy Gospodarek wrote: I booted an igb kernel with the option pci=nomsi and instantly noticed that interrupts no longer worked on my igb device. I took a look at the interrupt initialization and quickly discovered a comment stating: DO NOT USE EIAME or IAME in legacy mode It seemed a bit odd

Re: [PATCH][AX25] mkiss: ax_bump() locking fix

2008-02-15 Thread Jeff Garzik
Jarek Poplawski wrote: Hi, This is unchanged patch previously sent here for testing. I think it should be applied. Thanks, Jarek P. Subject: [PATCH][AX25] mkiss: ax_bump() locking fix According to one of OOPSes reported by Jann softirq can break while skb is prepared for

Re: [git patches] net driver fixes

2008-02-15 Thread Jeff Garzik
David Miller wrote: From: Jeff Garzik [EMAIL PROTECTED] Date: Fri, 15 Feb 2008 11:03:14 -0500 Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-davem Pulled and pushed out. As I mentioned to John Linville just now, I'm

Re: [RFC] sky2: don't request unused i/o region

2008-02-13 Thread Jeff Garzik
Stephen Hemminger wrote: The sky2 driver only uses the PCI memory region (0) not the available I/O region. Some users want to use lots of boards, and the I/O space gets exhausted. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/drivers/net/sky2.c2008-02-13 18:58:21.0

Re: [git patches] net driver updates

2008-02-12 Thread Jeff Garzik
Ben Dooks wrote: These two where meant to be from Laurent Pinchart, they do have the correct signed-off lines in for him and start with Patch from:. Is there any chance of fixing the authour attribution now? The first line of the changeset mentions it. Other than that, nope. Jeff

Re: [Bug 9750] [patch 2.6.25] dev: avoid a race that triggers assertion failure

2008-02-12 Thread Jeff Garzik
Matti Linnanvuori wrote: From: Matti Linnanvuori [EMAIL PROTECTED] There is a race in Linux kernel file net/core/dev.c, function dev_close. The function calls function dev_deactivate, which calls function dev_watchdog_down that deletes the watchdog timer. However, after that, a driver can call

Re: [PATCH 3/5 v3] Tsi108_eth: remove not needed code

2008-02-11 Thread Jeff Garzik
Alex Bounine wrote: Code clean-up for tsi108_eth network driver. This patch removes not needed dummy read and the corresponding comment. The PHY logic requires two reads from the status register to get current link status. This is done correctly inside mii_check_media(). Signed-off-by:

Re: [PATCH 1/5 v2] Tsi108_eth: add missing linking to driver data

2008-02-11 Thread Jeff Garzik
Alexandre Bounine wrote: Bug fix for tsi108_eth network driver. This patch adds missing linking to driver data. Signed-off-by: Alexandre Bounine [EMAIL PROTECTED] --- diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c linux-2.6.24-fix/drivers/net/tsi108_eth.c ---

Re: [PATCH 2/5] resend forcedeth: tx collision fix

2008-02-11 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch supports a new fix in hardware regarding tx collisions. In the cases where we are in autoneg mode and the link partner is in forced mode, we need to setup the tx deferral register differently in order to reduce collisions on the wire. Signed-off-by: Ayaz

Re: [PATCH 2.6.25] cxgb3: Handle ARP completions that mark neighbors stale.

2008-02-11 Thread Jeff Garzik
Steve Wise wrote: cxgb3: Handle ARP completions that mark neighbors stale. When ARP completes due to a request rather than a reply the neighbor is marked NUD_STALE instead of reachable (see arp_process()). The handler for the resulting netevent needs to check also for NUD_STALE. Failure to

Re: [patch 1/3] drivers/s390/net: Kconfig brush up

2008-02-11 Thread Jeff Garzik
applied 1-3 to #upstream (2.6.26) Even the initial revision was outside the merge window, so it was never going to make 2.6.25, thus I waited a bit for further comments and revisions -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH 10/10] atl1: reduce forward declarations

2008-02-11 Thread Jeff Garzik
applied 1-10 to #upstream (2.6.26) -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [2.6 patch] remove the obsolete xircom_tulip_cb driver

2008-02-11 Thread Jeff Garzik
Adrian Bunk wrote: The xircom_tulip_cb driver has been replaced the xircom_cb driver, and since it depended on BROKEN_ON_SMP it e.g. was no longer present in many distribution kernels. This patch therefore removes it. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] ---

Re: [PATCH] sk98lin: remove obsolete driver

2008-02-11 Thread Jeff Garzik
applied to #upstream (2.6.26) -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] tulip: hardware mitigation simplify

2008-02-11 Thread Jeff Garzik
Stephen Hemminger wrote: The hardware mitigation in tulip can be simpified. 1. The budget with new NAPI will always be less than RX_RING_SIZE because RX_RING_SIZE is 128 and weight is 16. 2. The received counter is redundunt, just use the work_done value. 3. Only one value is used from the

Re: [PATCH 1/7] PS3: gelic: Fix the wrong dev_id passed

2008-02-11 Thread Jeff Garzik
Masakazu Mokuno wrote: PS3: gelic: Fix the wrong dev_id passed The device id for lv1_net_set_interrupt_status_indicator() is wrong. This path would be invoked only in the case of an initialization failure. Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED] --- drivers/net/ps3_gelic_net.c |2

Re: [PATCH 2.6.24] pcnet32: use NET_IP_ALIGN instead of 2

2008-02-11 Thread Jeff Garzik
Don Fry wrote: Change hard coded 2 to NET_IP_ALIGN. Added new #define with comments. Tested amd_64 Signed-off-by: Don Fry [EMAIL PROTECTED] applied both -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 1/6] [NET] replace code with FIELD_SIZEOF

2008-02-11 Thread Jeff Garzik
Auke Kok wrote: From: Julia Lawall [EMAIL PROTECTED] Signed-off-by: Julia Lawall [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_ethtool.c |2 +- drivers/net/igb/igb_ethtool.c |2 +- drivers/net/ixgb/ixgb_ethtool.c |2 +- 3 files

Re: [patch 1/5] claw: removal of volatile variables

2008-02-11 Thread Jeff Garzik
applied 1-5 to #upstream-fixes (2.6.25) -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Patch 2.6.24 1/3]S2io: Support for vlan_rx_kill_vid entry point

2008-02-11 Thread Jeff Garzik
Sreenivasa Honnur wrote: - Added s2io_vlan_rx_kill_vid entry point function for unregistering vlan. - Fix to aggregate vlan packets. IP offset is incremented by 4 bytes if the packet contains vlan header. - resubmit for 2.6.24 kernel Signed-off-by: Surjit Reang [EMAIL PROTECTED]

Re: [patch] pegasus.c

2008-02-11 Thread Jeff Garzik
Petko Manolov wrote: Hi Jeff, Attached you'll find a patch that is fixing a driver bug triggered when malformed string is passed to the 'devid' module parameter. The expected format is: device_name:vendor_id:device_id:flags but it turned out people often type: somename::0

Re: [PATCH 1/5] Tsi108_eth: add missing linking to driver data

2008-02-11 Thread Jeff Garzik
Alexandre Bounine wrote: Bug fix for tsi108_eth network driver. This patch adds missing linking to driver data. Signed-off-by: Alexandre Bounine [EMAIL PROTECTED] --- diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c linux-2.6.24-fix/drivers/net/tsi108_eth.c ---

Re: [PATCH 4/5] resend forcedeth: tx pause watermarks

2008-02-11 Thread Jeff Garzik
Ayaz Abdulla wrote: New chipsets introduced variant Rx FIFO sizes that need to be taken into account when setting up the tx pause watermarks. This patch introduces the new device feature flags based on a version and implements the new watermarks. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED]

Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table

2008-02-11 Thread Jeff Garzik
Josh Boyer wrote: On Wed, 6 Feb 2008 13:21:59 +0100 Stefan Roese [EMAIL PROTECTED] wrote: With the removal the the rgmii-interface device_type property from the dts files, the newemac driver needs an update to only rely on compatible property. Signed-off-by: Stefan Roese [EMAIL PROTECTED]

Re: Pull request for 'r6040' branch

2008-02-11 Thread Jeff Garzik
Francois Romieu wrote: Please pull from branch 'r6040' in repository git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git r6040 to get the changes below. I have simply rebased the r6040 branch from december on top of Linus's latest head and given each patch a compile test. The

Re: [patch 1/2] qeth: new qeth device driver

2008-02-11 Thread Jeff Garzik
please resend on top of the ctc driver update... -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] tulip: hardware mitigation simplify

2008-02-11 Thread Jeff Garzik
Jeff Garzik wrote: Stephen Hemminger wrote: The hardware mitigation in tulip can be simpified. 1. The budget with new NAPI will always be less than RX_RING_SIZE because RX_RING_SIZE is 128 and weight is 16. 2. The received counter is redundunt, just use the work_done value. 3. Only one value

Re: [PATCH 01/24 for-2.6.25] DM9000: Fix endian-ness of data accesses. Patch from: Laurent Pinchart [EMAIL PROTECTED]

2008-02-07 Thread Jeff Garzik
Laurent Pinchart wrote: On Wednesday 06 February 2008 12:46, Jeff Garzik wrote: two comments: 1) you should be using __le16 type 2) seems like you should do the same for RxStatus, rather than splitting it The DM9000 datasheet (or rather the application notes) describes two distinct fields

Re: [PATCH 1/5] forcedeth: restart tx/rx

2008-02-06 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch fixes the issue where the transmitter and receiver must be restarted when applying new changes to certain registers. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] applied -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH 2/5] forcedeth: tx collision fix

2008-02-06 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch supports a new fix in hardware regarding tx collisions. In the cases where we are in autoneg mode and the link partner is in forced mode, we need to setup the tx deferral register differently in order to reduce collisions on the wire. Signed-off-by: Ayaz

Re: [PATCH 3/5] forcedeth: phy status fix

2008-02-06 Thread Jeff Garzik
Ayaz Abdulla wrote: The driver needs to ack only the phy status bits that it is currently handling and preserve the other bits for the other handlers. For example, when reading/writing from the phy, it should not clear the link change interrupt bit. This will cause a missing link change

Re: [PATCH 4/5] forcedeth: tx pause watermarks

2008-02-06 Thread Jeff Garzik
Ayaz Abdulla wrote: New chipsets introduced variant Rx FIFO sizes that need to be taken into account when setting up the tx pause watermarks. This patch introduces the new device feature flags based on a version and implements the new watermarks. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED]

Re: [PATCH 5/5] forcedeth: preserve registers

2008-02-06 Thread Jeff Garzik
Ayaz Abdulla wrote: Various registers need to be preserved before resetting the device. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] applied -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] Fix PHY Lib support for gianfar and ucc_geth

2008-02-06 Thread Jeff Garzik
Andy Fleming wrote: The PHY Lib now uses mutexes instead of spin_locks. ucc_geth and gianfar both grab the locks in their mdio_reset functions, so they need to use mutex_(un)lock instead. This was not caught until someone tested it on an SMP system. Signed-off-by: Andy Fleming [EMAIL

[git patches] net driver updates

2008-02-06 Thread Jeff Garzik
Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-davem to receive the following updates: drivers/net/forcedeth.c | 49 +- drivers/net/gianfar_mii.c |4 +- drivers/net/iseries_veth.c|

Re: [PATCH] [NET] phy/broadcom: add support for BCM5481 PHY

2008-02-06 Thread Jeff Garzik
Anton Vorontsov wrote: This patch adds support for BCM5481 PHY. Unfortunately it's hard to get specifications for this PHY, so its special register 0x18 isn't annotated properly (but we know it's used to set up the delays). I've kept the magic numbers, so we'll not forget to fix it at the first

Re: [PATCH] virtio_net: Fix open - interrupt race

2008-02-06 Thread Jeff Garzik
Christian Borntraeger wrote: Jeff, Rusty is (supposed to be) on vacation. Can you send this fix against virtio_net with your next network driver fixes for 2.6.25? Thank you - I got the following oops during interface ifup. Unfortunately its not easily reproducable so I cant say for sure

Re: [PATCH 01/24 for-2.6.25] DM9000: Fix endian-ness of data accesses. Patch from: Laurent Pinchart [EMAIL PROTECTED]

2008-02-06 Thread Jeff Garzik
two comments: 1) you should be using __le16 type 2) seems like you should do the same for RxStatus, rather than splitting it -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table

2008-02-06 Thread Jeff Garzik
Josh Boyer wrote: On Thu, 31 Jan 2008 10:14:58 +1100 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Wed, 2008-01-30 at 07:16 +0100, Stefan Roese wrote: On Wednesday 16 January 2008, Josh Boyer wrote: On Wed, 16 Jan 2008 20:53:59 +1100 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On

Re: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources

2008-02-06 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: The e1000 driver stores the content of the PCI resources into unsigned long's before ioremapping. This breaks on 32 bits platforms that support 64 bits MMIO resources such as ppc 44x. This fixes it by removing those temporary variables and passing directly the

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Jeff Garzik
. The included patch fixes the MAC address detection on my system. Interestingly, the MAC address appears to be in the range reserved for my motherboard manufacturer (Gigabyte) and not nVidia. Signed-off-by: Michael J. Pyne [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Cc: Ayaz Abdulla [EMAIL PROTECTED

Re: [PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set.

2008-02-05 Thread Jeff Garzik
Rami Rosen wrote: Hi, When CONFIG_PROC_FS is not set and CONFIG_PPPOL2TP is set, we have the following warning in build: drivers/net/pppol2tp.c: In function 'pppol2tp_init': drivers/net/pppol2tp.c:2472: warning: label 'out_unregister_pppox_proto' defined but not used This patches fixes

Re: [PATCH] [POWERPC] iSeries: fix section mismatch in iseries_veth

2008-02-05 Thread Jeff Garzik
Stephen Rothwell wrote: WARNING: vmlinux.o(.text+0x25dca0): Section mismatch in reference from the function .veth_probe() to the function .init.text:.veth_probe_one() Signed-off-by: Stephen Rothwell [EMAIL PROTECTED] --- drivers/net/iseries_veth.c |2 +- 1 files changed, 1 insertions(+),

Re: [patch 3/4] mv643xx_eth: fix byte order when checksum offload is enabled

2008-02-05 Thread Jeff Garzik
. Signed-off-by: Byron Bradley [EMAIL PROTECTED] Cc: Dale Farnsworth [EMAIL PROTECTED] Cc: Manish Lachwani [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Cc: Al Viro [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/mv643xx_eth.c | 11 --- 1 file changed

Re: [PATCH] xircom_cb should return NETDEV_TX_BUSY when there are no descriptors available

2008-02-05 Thread Jeff Garzik
Erik Mouw wrote: Hi, Changes in other networking paths uncovered a bug in the xircom_cb driver which made the kernel spew lots of the following error messages: BUG eth1 code -5 qlen 0 It turned out that the driver returned -EIO when there was no descriptor available for sending packets. It

Re: [PATCH 8/8] ixgbe: add real-time traffic counters

2008-02-05 Thread Jeff Garzik
Auke Kok wrote: From: Ayyappan Veeraiyan [EMAIL PROTECTED] Just like our other drivers before we can switch ixgbe to provide real-time packet/byte counters to the stack easily. Signed-off-by: Ayyappan Veeraiyan [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] ---

Re: [PATCH 1/3] Generic HDLC - fix kernel panic

2008-02-05 Thread Jeff Garzik
Krzysztof Halasa wrote: Fixes kernel panic in Frame Relay mode Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED] applied 1-3 -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] sky2: fix for Yukon FE (regression in 2.6.25)

2008-02-05 Thread Jeff Garzik
Stephen Hemminger wrote: The Yukon FE chip has a ram buffer therefore it needs the alignment restriction and hang check workarounds. Therefore: * Autodetect the prescence/absence of ram buffer * Rename the flag value to reflect this * Use it consistently (ie don't reread register)

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Jeff Garzik
H. Peter Anvin wrote: Jeff Garzik wrote: Signed-off-by: Andrew Morton [EMAIL PROTECTED] NAK - this fixes one set of users, and breaks a working set of users. Need to add DMI check for the specific motherboard (dmi_check_system), and flip flag according to success/failure of that check

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Jeff Garzik
Andrew Morton wrote: On Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Signed-off-by: Andrew Morton [EMAIL PROTECTED] NAK - this fixes one set of users, and breaks a working set of users. Need to add DMI check for the specific motherboard (dmi_check_system), and flip

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Jeff Garzik
Ayaz Abdulla wrote: Andrew Morton wrote: On Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Signed-off-by: Andrew Morton [EMAIL PROTECTED] NAK - this fixes one set of users, and breaks a working set of users. Need to add DMI check for the specific motherboard

Re: [PATCH] xircom_cb should return NETDEV_TX_BUSY when there are no descriptors available

2008-02-04 Thread Jeff Garzik
Erik Mouw wrote: On Mon, Feb 04, 2008 at 06:56:54PM +0100, Erik Mouw wrote: Changes in other networking paths uncovered a bug in the xircom_cb driver which made the kernel spew lots of the following error messages: BUG eth1 code -5 qlen 0 It turned out that the driver returned -EIO when

Re: [PATCH] [RFC] 3c509: convert to isa_driver and pnp_driver v2

2008-02-02 Thread Jeff Garzik
Ondrej Zary wrote: Hello, this is second version of the patch. Autoloading using udev works fine with PnP card. Hibernation now works both in PnP and ISA modes. The I/O address used for non-pnp ISA card detection is now not released as it's needed to wake up the card. Manual irq and

Re: [PATCH] [POWERPC][NET][SERIAL] UCCs: replace device-id with cell-index

2008-02-01 Thread Jeff Garzik
Anton Vorontsov wrote: On Fri, Feb 01, 2008 at 09:32:38AM -0600, Kumar Gala wrote: On Feb 1, 2008, at 9:01 AM, Anton Vorontsov wrote: It isn't used anywhere, so remove it. If we'll ever need something like this, we'll use compatible property instead. Signed-off-by: Anton Vorontsov [EMAIL

Re: [PATCH 1/5] ehea: fix ehea.h checkpatch complaints

2008-02-01 Thread Jeff Garzik
Doug Maxey wrote: Cc: Jan-Bernd Themann [EMAIL PROTECTED] Signed-off-by: Doug Maxey [EMAIL PROTECTED] --- drivers/net/ehea/ehea.h|3 +++ drivers/net/ehea/ehea_hw.h |8 2 files changed, 7 insertions(+), 4 deletions(-) applied 1-5 -- To unsubscribe from this list: send

Re: [PATCH for 2.6.25 1/2] [NET] ucc_geth: fix module removal

2008-02-01 Thread Jeff Garzik
Anton Vorontsov wrote: - uccf should be set to NULL to not double-free memory on subsequent calls; - ind_hash_q and group_hash_q lists should be initialized in the probe() function, instead of struct_init() (called by open()), otherwise there will be an oops if ucc_geth_driver removed

Re: [PATCH] ehea: fix sysfs link compile problem

2008-02-01 Thread Jeff Garzik
Jan-Bernd Themann wrote: Due to changes in the struct device_driver there is no direct access to its kobj any longer. The kobj was used to create sysfs links between eHEA ethernet devices and the driver. This patch removes the affected sysfs links to resolve the build problems. Signed-off-by:

Re: NET: AX88796 use dev_dbg() instead of printk()

2008-02-01 Thread Jeff Garzik
applied -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [2.6 patch] via-rhine.c:rhine_hw_init() must be __devinit

2008-02-01 Thread Jeff Garzik
applied the net driver portion of these patches... -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: rtl8150: use default MTU of 1500

2008-02-01 Thread Jeff Garzik
Lennert Buytenhek wrote: The RTL8150 driver uses an MTU of 1540 by default, which causes a bunch of problems -- it prevents booting from NFS root, for one. Signed-off-by: Lennert Buytenhek [EMAIL PROTECTED] Cc: Petko Manolov [EMAIL PROTECTED] ---

Re: [PATCH] macb: Fix section mismatch and shrink runtime footprint

2008-02-01 Thread Jeff Garzik
Haavard Skinnemoen wrote: macb devices are only found integrated on SoCs, so they can't be hotplugged. Thus, the probe() and exit() functions can be __init and __exit, respectively. By using platform_driver_probe() instead of platform_driver_register(), there won't be any references to the

Re: [PATCH 2.6.24] e1000e: add new wakeup cababilities

2008-02-01 Thread Jeff Garzik
Mitch Williams wrote: Ethtool supports wake-on-ARP and wake-on-link, and so does the hardware supported by e1000e. This patch just introduces the two. Signed-off-by: Mitch Williams [EMAIL PROTECTED] applied -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH] PHYLIB: Add BCM5482 PHY support

2008-02-01 Thread Jeff Garzik
Nate Case wrote: This Broadcom PHY is similar to other bcm54xx devices. Signed-off-by: Nate Case [EMAIL PROTECTED] --- drivers/net/phy/broadcom.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) applied -- To unsubscribe from this list: send the line

Re: [Patch 2.6.24 1/3]S2io: Support for vlan_rx_kill_vid entry point

2008-02-01 Thread Jeff Garzik
Sreenivasa Honnur wrote: - Added s2io_vlan_rx_kill_vid entry point function for unregistering vlan. - Fix to aggregate vlan packets. IP offset is incremented by 4 bytes if the packet contains vlan header. Signed-off-by: Surjit Reang [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL

Re: [PATCH 1/3] pasemi_mac: Add support for changing mac address

2008-02-01 Thread Jeff Garzik
Olof Johansson wrote: Straightforward. It used to be hardcoded and impossible to override with ifconfig. Signed-off-by: Olof Johansson [EMAIL PROTECTED] applied 1-3 -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 1/6] e1000e: make a function static

2008-02-01 Thread Jeff Garzik
applied 1-6 -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [2.6 patch] remove obsolete tokenring maintainer information

2008-02-01 Thread Jeff Garzik
Adrian Bunk wrote: - Peter's email address is bouncing - the project webpage no longer exists - neither Peter nor Mike had a single patch included in the kernel since 2.6.12-rc2 (when the git history begins) Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- MAINTAINERS | 23

Re: [PATCH 1/5] ehea: fix ehea.h checkpatch complaints

2008-02-01 Thread Jeff Garzik
Jeff Garzik wrote: Doug Maxey wrote: Cc: Jan-Bernd Themann [EMAIL PROTECTED] Signed-off-by: Doug Maxey [EMAIL PROTECTED] --- drivers/net/ehea/ehea.h|3 +++ drivers/net/ehea/ehea_hw.h |8 2 files changed, 7 insertions(+), 4 deletions(-) applied 1-5 BTW please do

  1   2   3   4   5   6   7   8   9   10   >