Olof Johansson wrote:
Fix build break:
drivers/net/tsi108_eth.c: In function 'tsi108_init_one':
drivers/net/tsi108_eth.c:1633: error: expected ')' before 'dev'
drivers/net/tsi108_eth.c:1633: warning: too few arguments for format
make[2]: *** [drivers/net/tsi108_eth.o] Error 1
Signed-off-by: Ol
applied
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Randy Dunlap wrote:
[EMAIL PROTECTED] wrote:]
From: Randy Dunlap <[EMAIL PROTECTED]>
Drivers that use lro functions should depend on INET, otherwise they
may not link correctly. Let's not select INET. Select should be used
only for library-like code, not to enable subsystems.
ERROR: "lro_f
Randy Dunlap wrote:
From: Randy Dunlap <[EMAIL PROTECTED]>
Missing MODULE_LICENSE(), loading this module taints the kernel.
Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
---
drivers/net/phy/mdio-bitbang.c |2 ++
1 file changed, 2 insertions(+)
applied this and the NAPI_Howto Kconfig pa
Chris Holvenstot wrote:
I built 2.6.23-git14 this morning - when booted I can not access the
network via my Ethernet connection. Fallback to 2.6.23-git11 works OK.
One interesting message during boot:
[ 37.325760] forcedeth: Reverse Engineered nForce ethernet driver.
[ 37.843618] forcedet
commit aeb16d7836f97576218fae6f3959c415b0fd09f0
Author: Jeff Garzik <[EMAIL PROTECTED]>
Date: Fri Oct 19 03:19:08 2007 -0400
[ATM, CHAR, TOUCHSCREEN] remove needless use of irq handler first arg
Like the vast majority of other drivers, these drivers do not need to
ref
commit e96888518af94d9f607b996f8b90873330dbfc32
Author: Jeff Garzik <[EMAIL PROTECTED]>
Date: Fri Oct 19 03:14:03 2007 -0400
[NETDRVR] lib82596, netxen: delete pointless tests from irq handler
Remove always-false tests in irq handler.
Also a few other minor cl
commit 21b1f26bf54a2ba1e4072db6dd01da128b1f66ef
Author: Jeff Garzik <[EMAIL PROTECTED]>
Date: Fri Oct 19 03:12:20 2007 -0400
[SPARC, XEN, NET/CXGB3] use irq_handler_t where appropriate
Rather than hand-rolling our own prototype, make the code more
future-proof by usi
commit 9739eb5090cc136ab50f2b323b83894c38d1ecb9
Author: Jeff Garzik <[EMAIL PROTECTED]>
Date: Fri Oct 19 03:10:11 2007 -0400
Eliminate pointless casts from void* in a few driver irq handlers.
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
drivers/a
Erez Zadok wrote:
I'm using Linus's git tree as of commit
d85714d81cc0408daddb68c10f7fd69eafe7c213. I built that kernel under vmware
workstation 6.0.1 which emulates a pcnet32 nic. When I only turn on
CONFIG_PCNET32, my network interface doesn't seem to come up fully: my dhcp
server sees a requ
Grant Likely wrote:
On 10/15/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
Domen Puncer wrote:
Hello!
If there are no objections, I would like to get this merged
when bestcomm goes in (any time now?).
It's split into four parts:
1 - device tree
2 - small bestcomm change
3 - the actu
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
to receive the following updates:
drivers/net/3c59x.c|2 +-
drivers/net/forcedeth.c| 27 ++---
drivers/net/fs_enet/fs_enet
Don Fry wrote:
Remove the statistics from the private structure.
Use the net_device_stats in netn_device structure.
Following Jeff Garzik's massive cleanup Sep 01.
pcnet32 was not "low-hanging fruit".
Tested x86_64.
Signed-off-by: Don Fry <[EMAIL PROTECTED]>
applied
-
To unsubscribe from
Badari Pulavarty wrote:
Simple compile warning fix. (against 2.6.23-git12)
Thanks,
Badari
vortex_up() should initialize 'err' for a successful return.
drivers/net/3c59x.c: In function `vortex_up':
drivers/net/3c59x.c:1494: warning: `err' might be used uninitialized in this
function
applied
Don Fry wrote:
Recent changes to the driver for the new napi API broke the reception of
packets when in
non-napi mode. The initialization of napi.weight was removed for the non-napi
case
leaving the value zero.
Tested NAPI and non-NAPI on x86_64.
Signed-off-by: Don Fry <[EMAIL PROTECTED]>
--
Don Fry wrote:
Remove compile warning when in non-napi mode.
Signed-off-by: Don Fry <[EMAIL PROTECTED]>
---
--- linux-2.6.23-git7/drivers/net/napi.pcnet32.c2007-10-17
15:56:15.0 -0700
+++ linux-2.6.23-git7/drivers/net/pcnet32.c 2007-10-17 16:00:44.0
-0700
@@ -442,7
Anton Vorontsov wrote:
Erroneous #ifdef introduced by 293c8513398657f6263fcdb03c87f2760cf61be4
causing NAPI-less ethernet malfunctioning.
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line
Benjamin Herrenschmidt wrote:
The EMAC driver "fix" was merged by mistake before the dust had settled on
the new napi synchronize interface (and before it got merged). The final
version of that function is spelled without underscores.
Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
a
applied 1-2
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Sebastian Siewior wrote:
struct net_device_stats is no longer used in driver's private
struct but in struct net_device.
Cc: Li Yang <[EMAIL PROTECTED]>
Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]>
---
drivers/net/gianfar.h |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff
Scott Wood wrote:
This driver was recently broken by several changes for which this
driver was not (or was improperly) updated:
1. SET_MODULE_OWNER() was removed.
2. netif_napi_add() was only being called when building with
the old CPM binding.
3. The received/budget test was backwards.
4. to_ne
Don Fry wrote:
Recent changes to the driver for the new napi API broke the reception of
packets when in
non-napi mode. The initialization of napi.weight was removed for the non-napi
case
leaving the value zero.
Tested NAPI and non-NAPI on x86_64.
Signed-off-by: Don Fry <[EMAIL PROTECTED]>
--
Jeff Garzik wrote:
These six changes can be found in the 'fe' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
Note the change from the previous 'fe-lock' branch, which is now left
as-is on kernel.org, but not being updated.
-
To unsubs
commit 4f97856cd73ad3ccee06f1856c60cb1ed8f44ceb
Author: Jeff Garzik <[EMAIL PROTECTED]>
Date: Tue Oct 16 19:48:15 2007 -0400
[netdrvr] interrupt handling overhaul
* eliminate the work loops in the interrupt handlers. they are no
longer needed, now that NAPI and
commit a7c00e796597b797ceac3c18e8b85c124196c5ab
Author: Jeff Garzik <[EMAIL PROTECTED]>
Date: Tue Oct 16 17:33:19 2007 -0400
[netdrvr] forcedeth: use NAPI for TX completion
A hand-rolled TX poll & work limit system was already in place, so it
was easy to convert the
commit c6ad879c65e6f91c7f61b86936e2ea39b16711da
Author: Jeff Garzik <[EMAIL PROTECTED]>
Date: Tue Oct 16 11:43:27 2007 -0400
[netdrvr] forcedeth: eliminate some duplicate irq handling code
* nv_nic_irq_optimized() is the exactly same as nv_nic_irq(), save
for three fu
commit 8f61debaeb334bce0ccba1a1384d549a377c1e8e
Author: Jeff Garzik <[EMAIL PROTECTED]>
Date: Tue Oct 16 12:55:08 2007 -0400
[netdrvr] forcedeth: unconditionally enable NAPI
Remove all !CONFIG_FORCEDETH_NAPI code, and the Kconfig option,
enabling NAPI unconditi
commit 160511126b6be7f15da33f7cab7374b12cb5
Author: Jeff Garzik <[EMAIL PROTECTED]>
Date: Tue Oct 16 02:22:39 2007 -0400
[netdrvr] forcedeth: timer overhaul
* remove np->in_shutdown, it mirrors netif_running()
* convert stats timer to delayed
commit 0aeb1f867bc76029f599f73ac757a50f7641ccc5
Author: Jeff Garzik <[EMAIL PROTECTED]>
Date: Tue Oct 16 01:40:30 2007 -0400
[netdrvr] forcedeth: internal simplifications; changelog removal
* remove changelog from source; its kept in git repository
* conso
is hammers out bugs, problems, inconsistencies, mainly with interrupt
handling and locking. This moves the driver towards removing the
disable_irq() usage, but does not actually take that step (yet).
A few changes just went upstream, too:
Ingo Molnar (1):
forcedeth: fix NAPI rx poll fun
Benjamin Herrenschmidt wrote:
net: Add __napi_synchronize() to sync with napi poll
The EMAC driver which needs to handle multiple devices with one
NAPI instance implements its own per-channel disable bit. However,
when setting such a bit, it needs to synchronize with the poller
(that is make sur
ding: two small fixes for IPoIB support
Jeff Garzik (2):
[netdrvr] forcedeth: improved probe info; dev_printk() cleanups
[netdrvr] forcedeth: remove in-driver copy of net_device_stats
Li Yang (1):
gianfar: Fix compile regression caused by 09f75cd7
Marcus Meissner (1):
to
[EMAIL PROTECTED] wrote:
From: Steffen Klassert <[EMAIL PROTECTED]>
Some NICs (3c905B) can not generate PME in power state PCI_D0, while others
like 3c905C can. Call pci_enable_wake() with PCI_D3hot should give proper
WOL for 3c905B.
Signed-off-by: Steffen Klassert <[EMAIL PROTECTED]>
Tested-b
Jay Vosburgh wrote:
Two small fixes to IPoIB support for bonding:
1- copy header_ops from slave to bonding for IPoIB slaves
2- move release and destroy logic to UNREGISTER from GOING_DOWN
notifier to avoid double release
Set bonding to version 3.2.1.
Benjamin Herrenschmidt wrote:
net: Fix new EMAC driver for NAPI changes
This fixes the new EMAC driver for the NAPI updates. The previous patch
by Roland Dreier (already applied) to do that doesn't actually work. This
applies on top of it makes it work on my test Ebony machine.
This patch depen
applied 1-7
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Auke Kok wrote:
From: Adrian Bunk <[EMAIL PROTECTED]>
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
applied all three patches (1-2, and then the singleton)
-
To unsubscribe from this list: send the line "unsubscri
bit-cleared code path.
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
---
This looks like an obvious bug fix to me, but I found it by reading code
rather than hitting it in the field. Review appreciated.
net/sched/sch_generic.c |7 ---
1 file changed, 4 insertions(+), 3 del
Yinghai Lu wrote:
On 10/16/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
Yinghai Lu wrote:
On 10/15/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
Manfred Spraul wrote:
Jeff Garzik wrote:
I think the scenario you outline is an illustration of the approach's
fragility: disable
Yinghai Lu wrote:
On 10/15/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
Manfred Spraul wrote:
Jeff Garzik wrote:
I think the scenario you outline is an illustration of the approach's
fragility: disable_irq() is a heavy hammer that originated with INTx,
and it relies on a chip-speci
ible to
> split the patch into three, one for each maintainer (possibly by
> keeping both old and new interfaces around for a little while)?
>
> If not, then you need to get an Acked-by and an agreement that this
> change can go via the powerpc.git tree from Roland Dreier and Jef
Kumar Gala wrote:
On Fri, 12 Oct 2007, Li Yang wrote:
Signed-off-by: Li Yang <[EMAIL PROTECTED]>
---
drivers/net/gianfar.c |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
this patch got lost.
can someone resend, then?
-
To unsubscribe from this list: send the line "unsu
Manfred Spraul wrote:
Jeff Garzik wrote:
I think the scenario you outline is an illustration of the approach's
fragility: disable_irq() is a heavy hammer that originated with INTx,
and it relies on a chip-specific disable method (kernel/irq/manage.c)
that practically guarantees beh
Jay Vosburgh wrote:
Jeff Garzik <[EMAIL PROTECTED]> wrote:
Jay Vosburgh wrote:
Since I see you've just pushed it, do you want a patch to
correct just the two individual things, or would you rather have new
patches?
On top of what was just pushed, please.
Ok,
Jay Vosburgh wrote:
Since I see you've just pushed it, do you want a patch to
correct just the two individual things, or would you rather have new
patches?
On top of what was just pushed, please.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the
Alejandro Martinez Ruiz wrote:
This will convert remaining non-obvious or naive calculations of array
sizes to use ARRAY_SIZE() macro.
Signed-off-by: Alejandro Martinez Ruiz <[EMAIL PROTECTED]>
---
drivers/net/cassini.c |2 +-
drivers/net/irda/donauboe.c |2 +-
drivers/net/ne-h830
Josh Boyer wrote:
On Mon, 15 Oct 2007 14:53:26 -0400
Jeff Garzik <[EMAIL PROTECTED]> wrote:
Seems sane to me -- ACK -- but we have multiple people sending me
patches for a single driver. That's normal for janitorial cleanups
across the whole tree, but discouraged when multiple
Domen Puncer wrote:
Hello!
If there are no objections, I would like to get this merged
when bestcomm goes in (any time now?).
It's split into four parts:
1 - device tree
2 - small bestcomm change
3 - the actual driver
4 - phy part of the driver
patches #3 and #4 need to be combined together.
Josh Boyer wrote:
On Mon, 15 Oct 2007 14:27:23 -0400
Jeff Garzik <[EMAIL PROTECTED]> wrote:
Valentine Barshak wrote:
This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver.
These PHY chips are used on PowerPC 440EPx boards.
The PHY code is based on the previous w
Emil Medve wrote:
drivers/net/ucc_geth.c: In function 'ucc_geth_rx':
drivers/net/ucc_geth.c:3483: error: 'dev' undeclared (first use in this
function)
drivers/net/ucc_geth.c:3483: error: (Each undeclared identifier is reported
only once
drivers/net/ucc_geth.c:3483: error: for each function it a
Li Yang wrote:
Signed-off-by: Li Yang <[EMAIL PROTECTED]>
---
drivers/net/gianfar.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
applied all three gianfar patches
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
M
Jay Vosburgh wrote:
Convert bonding timers to workqueues. This converts the various
monitor functions to run in periodic work queues instead of timers. This
patch introduces the framework and convers the calls, but does not resolve
various locking issues, and does not stand alone.
Sign
Ralf Baechle wrote:
General cleanups mostly as suggested by checkpatch plus getting rid of
homebrew version of offsetof().
Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
Florin Malita wrote:
If pci_enable_device fails, bdx_probe returns without freeing the
allocated pci_nic structure.
Coverity CID 1908.
Signed-off-by: Florin Malita <[EMAIL PROTECTED]>
---
drivers/net/tehuti.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
applied
-
To unsubscri
Ralf Baechle wrote:
Caused by "[NET]: Introduce and use print_mac() and DECLARE_MAC_BUF()"
aka 0795af5729b18218767fab27c44b1384f72dc9ad.
Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EM
Ralf Baechle wrote:
Fix build breakage by the recent statistics cleanup in cset
09f75cd7bf13720738e6a196cc0107ce9a5bd5a0.
Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
Ralf Baechle wrote:
bea3348eef27e6044b6161fd04c3152215f96411 broke the build of tc35815.c
for the non-NAPI case:
CC drivers/net/tc35815.o
drivers/net/tc35815.c: In function 'tc35815_interrupt':
drivers/net/tc35815.c:1464: error: redefinition of 'lp'
drivers/net/tc35815.c:1443: error: prev
Michael Pyne wrote:
Partially revert a change to mac address detection introduced to the forcedeth
driver. The change was intended to correct mac address detection for newer
nVidia chipsets where the mac address was stored in reverse order. One of
those chipsets appears to still have the mac
Valentine Barshak wrote:
This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver.
These PHY chips are used on PowerPC 440EPx boards.
The PHY code is based on the previous work by Stefan Roese <[EMAIL PROTECTED]>
Signed-off-by: Stefan Roese <[EMAIL PROTECTED]>
Signed-off-by: Va
applied
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Moni Shoua wrote:
This is the 7th version of this patch series. See link to V6 below.
Changes from the previous version
-
* Some patches required modifications to remove offsets so they can be applied
with git-apply
* Patch #3 was first modified by Jay and later
Brice Goglin wrote:
Fix one comment in myri10ge.c and update indendation and white spaces
to match the code generated by indent from upstream CVS.
Signed-off-by: Brice Goglin <[EMAIL PROTECTED]>
---
drivers/net/myri10ge/myri10ge.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions
Jay Vosburgh wrote:
From: Moni Shoua <[EMAIL PROTECTED]>
IPoIB uses a two layer neighboring scheme, such that for each struct neighbour
whose device is an ipoib one, there is a struct ipoib_neigh buddy which is
created on demand at the tx flow by an ipoib_neigh_alloc(skb->dst->neighbour)
call.
Mark Brown wrote:
Unless we have failed to fill the RX ring the timer used by the natsemi
driver is not particularly urgent and can use round_jiffies() to allow
grouping with other timers.
Signed-off-by: Mark Brown <[EMAIL PROTECTED]>
---
Rediffed against current netdev-2.6.git#upstream
driver
David Miller wrote:
From: Brice Goglin <[EMAIL PROTECTED]>
Date: Sat, 13 Oct 2007 12:33:32 +0200
Add skb_is_gso_v6().
Signed-off-by: Brice Goglin <[EMAIL PROTECTED]>
No objections from me:
Acked-by: David S. Miller <[EMAIL PROTECTED]>
Jeff, it's simplest if you just merge this in with the
ACK
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please pull from the 'upstream-davem' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-davem
to receive these changes:
Auke Kok (2):
e1000e: Simple optimizations in e1000_xmit_frame
e1000e: restore flow control settings properly
Jan-Bernd Theman
Jeff Garzik wrote:
applied patches 1-9
the only thing that was a hiccup during submission is that your email
subject lines did not contain a notion of ordering "[PATCH 1/9] ...".
But other than that, the git-send-email went flawlessly.
unfortunately it does not seem to build
Roland Dreier wrote:
The conversion to use netdevice internal stats left an unused variable
in ipoib_neigh_free(), since there's no longer any reason to get
netdev_priv() in order to increment dropped packets. Delete the
unused priv variable.
Signed-off-by: Roland Dreier <[EMAIL PROTECTED]>
---
Mark Brown wrote:
Unless we have failed to fill the RX ring the timer used by the natsemi
driver is not particularly urgent and can use round_jiffies() to allow
grouping with other timers.
Signed-off-by: Mark Brown <[EMAIL PROTECTED]>
---
drivers/net/natsemi.c | 10 +++---
1 files changed
Mark Brown wrote:
The natsemi driver has a define NATSEMI_TIMER_FREQ which looks like it
controls the normal frequency of the chip poll timer but in fact only
takes effect for the first run of the timer. Adjust the value of the
define to match that used by the timer and use the define consistent
Jeremy Fitzhardinge wrote:
Keep tx and rx elements separate on different cachelines to prevent
bouncing.
Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]>
Cc: Stephen Hemminger <[EMAIL PROTECTED]>
Cc: Christoph Hellwig <[EMAIL PROTECTED]>
---
drivers/net/xen-netfront.c | 37
Stephen Hemminger wrote:
Fix warnings from sparse related to shadowed variables and routines
that should be declared static.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PRO
Stephen Hemminger wrote:
Fix problems detected by sparse:
1. whole chunk of MAC code was for defined and never used
2. hook for running ext intr in workqueue wasn't being used
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubs
Jan-Bernd Themann wrote:
eHEA recovery and DLPAR functions are called seldomly. The eHEA workqueues
are replaced by the kernel event queue.
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
---
The patch has been built against upstream git
drivers/net/ehea/ehea.h |3 +--
drivers/n
Stephen Hemminger wrote:
Fix some of the easy warnings in network device drivers.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers/net/acenic.c | 37 +++--
drivers/net/atl1/atl1_main.c |5 +++--
drivers/net/dl2k.c |8 +
Auke Kok wrote:
From: Krishna Kumar <[EMAIL PROTECTED]>
Some simple optimizations in e1000_xmit_frame.
Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]>
---
drivers/net/e1000/e1000_main.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
applied 1-2
-
To unsubscribe from t
David Miller wrote:
From: Roland Dreier <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 15:46:13 -0700
The conversion to use netdevice internal stats left an unused variable
in ipoib_neigh_free(), since there's no longer any reason to get
netdev_priv() in order to increment dropped packets. Delete
David Miller wrote:
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 08:44:25 -0400
David Miller wrote:
From: Krishna Kumar2 <[EMAIL PROTECTED]>
Date: Tue, 9 Oct 2007 16:51:14 +0530
David Miller <[EMAIL PROTECTED]> wrote on 10/09/2007 04:32:55 PM:
Ignore LLTX
Waskiewicz Jr, Peter P wrote:
IMO the net driver really should provide a hint as to what it wants.
8139cp and tg3 would probably prefer multiple TX queue
behavior to match silicon behavior -- strict prio.
If I understand what you just said, I disagree. If your hardware is
running strict prio
Herbert Xu wrote:
On Tue, Oct 09, 2007 at 08:44:25AM -0400, Jeff Garzik wrote:
David Miller wrote:
I can just threaten to do them all and that should get the driver
maintainers going :-)
What, like this? :)
Awsome :)
Note my patch is just to get the maintainers going. :) I'm not
David Miller wrote:
From: Krishna Kumar2 <[EMAIL PROTECTED]>
Date: Tue, 9 Oct 2007 16:51:14 +0530
David Miller <[EMAIL PROTECTED]> wrote on 10/09/2007 04:32:55 PM:
Ignore LLTX, it sucks, it was a big mistake, and we will get rid of
it.
Great, this will make life easy. Any idea how long that
Pavel Emelyanov wrote:
The unregister_netdevice() and dev_change_net_namespace()
both check for dev->flags to be IFF_UP before calling the
dev_close(), but the dev_close() checks for IFF_UP itself,
so remove those unneeded checks.
Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
---
diff
David Miller wrote:
1) A library for transmit load balancing functions, with an interface
that can be made visible to userspace. I can write this and test
it on real multiqueue hardware.
The whole purpose of this library is to set skb->queue_mapping
based upon the load balancing fun
David Miller wrote:
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 10:22:28 -0400
In terms of overall parallelization, both for TX as well as RX, my gut
feeling is that we want to move towards an MSI-X, multi-core friendly
model where packets are LIKELY to be sent and re
jamal wrote:
The challenge to deal with is that netdevices, filters, the queues and
scheduler are closely inter-twined. So it is not just the scheduling
region and QDISC_RUNNING. For example, lets pick just the filters
because they are simple to see: You need to attach them to something -
whateve
jamal wrote:
Ok, so the "concurency" aspect is what worries me. What i am saying is
that sooner or later you have to serialize (which is anti-concurency)
For example, consider CPU0 running a high prio queue and CPU1 running
the low prio queue of the same netdevice.
Assume CPU0 is getting a lot of
David Miller wrote:
From: "Joakim Tjernlund" <[EMAIL PROTECTED]>
Date: Mon, 8 Oct 2007 20:17:33 +0200
David, any chance the second item, Oops while modprobing phy fixed module, in
http://marc.info/?l=linux-kernel&m=119178673421891&w=2
will make it into 2.6.23?
The fix is now in your tree,
ht
jamal wrote:
On Sun, 2007-07-10 at 21:51 -0700, David Miller wrote:
For these high performance 10Gbit cards it's a load balancing
function, really, as all of the transmit queues go out to the same
physical port so you could:
1) Load balance on CPU number.
2) Load balance on "flow"
3) Load bala
Yinghai Lu wrote:
On 10/7/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
Yinghai Lu wrote:
On 10/6/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
commit a606d2a111cdf948da5d69eb1de5526c5c2dafef
Author: Jeff Garzik <[EMAIL PROTECTED]>
Date: Fri Oct 5 22:56:05 2007 -0400
[
Yinghai Lu wrote:
On 10/7/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
Jeff Garzik wrote:
The 'fe-lock' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git fe-lock
OK, I've successfully tested patches 1-5 on an AMD64 system with
00:0a.0 Bridg
Denis V. Lunev wrote:
Jeff Garzik wrote:
Jeff Garzik wrote:
The commit
commit 5f5dace1ce001b24fb8286e09ffd3c4d2b547e09
Author: Denis V. Lunev <[EMAIL PROTECTED]>
Date: Thu Sep 27 12:41:26 2007 -0700
[NET]: Various dst_ifdown routines to catch refcounting bugs
causes
Jeff Garzik wrote:
The 'fe-lock' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git fe-lock
contains the following changes that I would like to get tested:
[netdrvr] forcedeth: make NAPI unconditional
[netdrvr] forcedeth: interrupt handli
Jeff Garzik wrote:
commit abca163a14b28c234df9bf38034bc967ff81c3aa
Author: Jeff Garzik <[EMAIL PROTECTED]>
Date: Sun Oct 7 07:22:14 2007 -0400
[netdrvr] forcedeth: wrap slow path hw manipulation inside hw_mutex
* This makes sure everybody who wants to start/stop the RX
Jeff Garzik wrote:
commit 57cbfacc00d69be2ba02b65d1021442273b76263
Author: Jeff Garzik <[EMAIL PROTECTED]>
Date: Fri Oct 5 23:25:56 2007 -0400
[netdrvr] forcedeth: process TX completions using NAPI
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
drivers/net/forced
Jeff Garzik wrote:
The commit
commit 5f5dace1ce001b24fb8286e09ffd3c4d2b547e09
Author: Denis V. Lunev <[EMAIL PROTECTED]>
Date: Thu Sep 27 12:41:26 2007 -0700
[NET]: Various dst_ifdown routines to catch refcounting bugs
causes a 100% reproducible oops in net-2.6.24.git, in ip6_rou
The commit
commit 5f5dace1ce001b24fb8286e09ffd3c4d2b547e09
Author: Denis V. Lunev <[EMAIL PROTECTED]>
Date: Thu Sep 27 12:41:26 2007 -0700
[NET]: Various dst_ifdown routines to catch refcounting bugs
causes a 100% reproducible oops in net-2.6.24.git, in ip6_route_add().
Platform: x86-64
Andreas Mohr wrote:
I intend to still try to get it up and running with 2.6.23-rc8-mm2 today
(with some workarounds hopefully, maybe even disabling ISDN completely)...
The last running kernel (I didn't have newer ones in between), up for some 110
days was 2.6.19-cks2 (IOW, I cannot quite say tha
Yinghai Lu wrote:
On 10/6/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
commit a606d2a111cdf948da5d69eb1de5526c5c2dafef
Author: Jeff Garzik <[EMAIL PROTECTED]>
Date: Fri Oct 5 22:56:05 2007 -0400
[netdrvr] forcedeth: interrupt handling cleanup
* nv_nic_irq_opt
Ingo Molnar wrote:
* Jeff Garzik <[EMAIL PROTECTED]> wrote:
* I feel TX NAPI is a useful tool, because it provides an independent TX
process control point and system load feedback point.
Thus I felt this was slightly superior to tasklets.
/me agrees violently
btw., when i playe
401 - 500 of 2723 matches
Mail list logo