RE: [RFC net-next] net: stmmac: should not modify RX descriptor when STMMAC resume

2021-04-19 Thread Joakim Zhang
Hi Jon, > -Original Message- > From: Jon Hunter > Sent: 2021年4月19日 23:12 > To: Joakim Zhang ; peppe.cavall...@st.com; > alexandre.tor...@foss.st.com; joab...@synopsys.com; > da...@davemloft.net; k...@kernel.org; mcoquelin.st...@gmail.com; > and...@lunn.ch; f.faine.

[RFC net-next] net: stmmac: should not modify RX descriptor when STMMAC resume

2021-04-19 Thread Joakim Zhang
TX2 boards. It is unreasonable to modify RX descriptors outside of stmmac_rx_refill() function, where it will clear all desc0/desc1/desc2/desc3 fields together. This patch removes RX descriptors modification when STMMAC resume. Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/st

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-14 Thread Joakim Zhang
> -Original Message- > From: Joakim Zhang > Sent: 2021年4月14日 16:07 > To: Thierry Reding > Cc: David S. Miller ; Jakub Kicinski ; > Jon Hunter ; Giuseppe Cavallaro > ; Alexandre Torgue ; > Jose Abreu ; netdev@vger.kernel.org; Linux Kernel > Mailing List ; l

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-14 Thread Joakim Zhang
> -Original Message- > From: Thierry Reding > Sent: 2021年4月14日 15:41 > To: Joakim Zhang > Cc: David S. Miller ; Jakub Kicinski ; > Jon Hunter ; Giuseppe Cavallaro > ; Alexandre Torgue ; > Jose Abreu ; netdev@vger.kernel.org; Linux Kernel > Mailing List ; l

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-13 Thread Joakim Zhang
> -Original Message- > From: Thierry Reding > Sent: 2021年4月14日 0:07 > To: David S. Miller ; Jakub Kicinski > Cc: Joakim Zhang ; Jon Hunter > ; Giuseppe Cavallaro ; > Alexandre Torgue ; Jose Abreu > ; netdev@vger.kernel.org; Linux Kernel Mailing List > ;

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-13 Thread Joakim Zhang
Hi Jon, > -Original Message- > From: Jon Hunter > Sent: 2021年4月13日 16:41 > To: Joakim Zhang ; Giuseppe Cavallaro > ; Alexandre Torgue ; > Jose Abreu > Cc: netdev@vger.kernel.org; Linux Kernel Mailing List > ; linux-tegra ; > Jakub Kicinski > Subject:

RE: [PATCH net-next 0/3] net: add new properties for of_get_mac_address from nvmem

2021-04-11 Thread Joakim Zhang
Hi Jabuk, > -Original Message- > From: Jakub Kicinski > Sent: 2021年4月10日 2:44 > To: Joakim Zhang > Cc: da...@davemloft.net; robh...@kernel.org; and...@lunn.ch; > hkallwe...@gmail.com; li...@armlinux.org.uk; frowand.l...@gmail.com; > netdev@vger.kernel.org; devic

RE: [PATCH net-next 1/3] dt-bindings: net: add new properties for of_get_mac_address from nvmem

2021-04-11 Thread Joakim Zhang
Hi Rob, > -Original Message- > From: Rob Herring > Sent: 2021年4月9日 21:50 > To: Joakim Zhang > Cc: David Miller ; Jakub Kicinski ; > Andrew Lunn ; Heiner Kallweit ; > Russell King ; Frank Rowand > ; netdev ; > devicet...@vger.kernel.org; linux-ker...@vg

RE: flexcan introduced a DIV/0 in kernel

2021-04-11 Thread Joakim Zhang
Best Regards, Joakim Zhang > -Original Message- > From: Koen Vandeputte > Sent: 2021年4月9日 18:18 > To: linux-...@vger.kernel.org > Cc: w...@grandegger.com; m...@pengutronix.de; netdev@vger.kernel.org; > Joakim Zhang ; gre...@linuxfoundation.org > Subject: flexcan introduced

[PATCH] MAINTAINERS: update maintainer entry for freescale fec driver

2021-04-09 Thread Joakim Zhang
Update maintainer entry for freescale fec driver. Suggested-by: Heiner Kallweit Signed-off-by: Joakim Zhang --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1cc3976040d5..efc76153114c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH net-next 3/3] of_net: add property "nvmem-mac-address" for of_get_mac_addr()

2021-04-09 Thread Joakim Zhang
y. Signed-off-by: Fugang Duan Signed-off-by: Joakim Zhang --- drivers/of/of_net.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/of/of_net.c b/drivers/of/of_net.c index 6e411821583e..20c3ae17f95f 100644 --- a/drivers/of/of_net.c +++ b/drivers/of/of_net.c @@ -116,6 +116,10 @@

[PATCH net-next 1/3] dt-bindings: net: add new properties for of_get_mac_address from nvmem

2021-04-09 Thread Joakim Zhang
mac-address" in ethernet node. Update these two properties in the binding documentation. Signed-off-by: Fugang Duan Signed-off-by: Joakim Zhang --- .../bindings/net/ethernet-controller.yaml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/b

[PATCH net-next 2/3] net: ethernet: add property "nvmem_macaddr_swap" to swap macaddr bytes order

2021-04-09 Thread Joakim Zhang
() nvmem_get_mac_address() i.MX6x/7D/8MQ/8MM platforms ethernet MAC address read from nvmem ocotp eFuses, but it requires to swap the six bytes order. The patch add optional property "nvmem_macaddr_swap" to swap macaddr bytes order. Signed-off-by: Fugang Duan Signed-off-by: Joakim Zhang

[PATCH net-next 0/3] net: add new properties for of_get_mac_address from nvmem

2021-04-09 Thread Joakim Zhang
This patch set adds new properties for of_get_mac_address from nvmem. Fugang Duan (3): dt-bindings: net: add new properties for of_get_mac_address from nvmem net: ethernet: add property "nvmem_macaddr_swap" to swap macaddr bytes order of_net: add property "nvmem-mac-address" for of_get_m

RE: [PATCH net-next 0/3] net: add new properties for of_get_mac_address from nvmem

2021-04-09 Thread Joakim Zhang
Hi, Please ignore this patch set version, I will resend it, sorry. Best Regards, Joakim Zhang > -Original Message- > From: Joakim Zhang > Sent: 2021年4月9日 16:38 > To: da...@davemloft.net; k...@kernel.org; robh...@kernel.org; > and...@lunn.ch; hkallwe...@gmail.com; li...@

[PATCH net-next 3/3] of_net: add property "nvmem-mac-address" for of_get_mac_addr()

2021-04-09 Thread Joakim Zhang
y. Signed-off-by: Fugang Duan Signed-off-by: Joakim Zhang --- drivers/of/of_net.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/of/of_net.c b/drivers/of/of_net.c index 6e411821583e..20c3ae17f95f 100644 --- a/drivers/of/of_net.c +++ b/drivers/of/of_net.c @@ -116,6 +116,10 @@

[PATCH net-next 2/3] net: ethernet: add property "nvmem_macaddr_swap" to swap macaddr bytes order

2021-04-09 Thread Joakim Zhang
() nvmem_get_mac_address() i.MX6x/7D/8MQ/8MM platforms ethernet MAC address read from nvmem ocotp eFuses, but it requires to swap the six bytes order. The patch add optional property "nvmem_macaddr_swap" to swap macaddr bytes order. Signed-off-by: Fugang Duan Signed-off-by: Joakim Zhang

[PATCH net-next 1/3] dt-bindings: net: add new properties for of_get_mac_address from nvmem

2021-04-09 Thread Joakim Zhang
mac-address" in ethernet node. Update these two properties in the binding documentation. Signed-off-by: Fugang Duan Signed-off-by: Joakim Zhang --- .../bindings/net/ethernet-controller.yaml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/b

[PATCH net-next 0/3] net: add new properties for of_get_mac_address from nvmem

2021-04-09 Thread Joakim Zhang
This patch set adds new properties for of_get_mac_address from nvmem. Fugang Duan (3): dt-bindings: net: add new properties for of_get_mac_address from nvmem net: ethernet: add property "nvmem_macaddr_swap" to swap macaddr bytes order of_net: add property "nvmem-mac-address" for of_get_m

RE: [PATCH net] net: stmmac: fix MAC WoL unwork if PHY doesn't support WoL

2021-04-09 Thread Joakim Zhang
Hi Andrew, > -Original Message- > From: Andrew Lunn > Sent: 2021年4月7日 20:35 > To: Joakim Zhang > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; k...@kernel.org; > f.faine...@gmail.com; netdev@vger.ker

RE: [PATCH net-next 2/3] net: fec: use mac-managed PHY PM

2021-04-07 Thread Joakim Zhang
> -Original Message- > From: Heiner Kallweit > Sent: 2021年4月8日 14:00 > To: Joakim Zhang ; Andrew Lunn > ; Russell King - ARM Linux ; Jakub > Kicinski ; David Miller ; Fugang > Duan > Cc: netdev@vger.kernel.org > Subject: Re: [PATCH net-next 2/3] net: fec: use

RE: [PATCH net-next 2/3] net: fec: use mac-managed PHY PM

2021-04-07 Thread Joakim Zhang
> -Original Message- > From: Heiner Kallweit > Sent: 2021年4月7日 23:53 > To: Andrew Lunn ; Russell King - ARM Linux > ; Jakub Kicinski ; David Miller > ; Fugang Duan > Cc: netdev@vger.kernel.org; Joakim Zhang > Subject: [PATCH net-next 2/3] net: fec: use mac-man

RE: [PATCH net-next 0/3] net: make PHY PM ops a no-op if MAC driver manages PHY PM

2021-04-07 Thread Joakim Zhang
Hi Heiner, Why not target this patch set to net repo as a bug fixes? Others may also suffer from this. Best Regards, Joakim Zhang > -Original Message- > From: Heiner Kallweit > Sent: 2021年4月7日 23:51 > To: Andrew Lunn ; Russell King - ARM Linux > ; Jakub Kicinski

[PATCH net] net: stmmac: fix MAC WoL unwork if PHY doesn't support WoL

2021-04-07 Thread Joakim Zhang
doesn't support WoL, then MAC will lose wakeup capability. To fix this issue, only overwrite device wakeup capability when MAC doesn't support PMT. Fixes: commit 1d8e5b0f3f2c ("net: stmmac: Support WOL with phy") Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/st

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-07 Thread Joakim Zhang
> -Original Message- > From: Heiner Kallweit > Sent: 2021年4月7日 18:22 > To: Joakim Zhang ; christian.me...@t2data.com; > and...@lunn.ch; li...@armlinux.org.uk; da...@davemloft.net; > k...@kernel.org > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; dl-

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-07 Thread Joakim Zhang
Hi Heiner, > -Original Message- > From: Joakim Zhang > Sent: 2021年4月7日 15:46 > To: Heiner Kallweit ; christian.me...@t2data.com; > and...@lunn.ch; li...@armlinux.org.uk; da...@davemloft.net; > k...@kernel.org > Cc: netdev@vger.kernel.org; linux-ker...@vger.ker

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-07 Thread Joakim Zhang
Hi Heiner, > -Original Message- > From: Heiner Kallweit > Sent: 2021年4月7日 15:12 > To: Joakim Zhang ; christian.me...@t2data.com; > and...@lunn.ch; li...@armlinux.org.uk; da...@davemloft.net; > k...@kernel.org > Cc: netdev@vger.kernel.org; linux-ker...@vger.ker

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-06 Thread Joakim Zhang
Hi Heiner, > -Original Message- > From: Heiner Kallweit > Sent: 2021年4月7日 2:22 > To: Joakim Zhang ; christian.me...@t2data.com; > and...@lunn.ch; li...@armlinux.org.uk; da...@davemloft.net; > k...@kernel.org; Russell King - ARM Linux > Cc: netdev@vger.

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-06 Thread Joakim Zhang
> -Original Message- > From: Heiner Kallweit > Sent: 2021年4月6日 14:29 > To: Joakim Zhang ; christian.me...@t2data.com; > and...@lunn.ch; li...@armlinux.org.uk; da...@davemloft.net; > k...@kernel.org > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; dl-linux

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Joakim Zhang
Hi Heiner, > -Original Message- > From: Heiner Kallweit > Sent: 2021年4月5日 20:10 > To: christian.me...@t2data.com; Joakim Zhang ; > and...@lunn.ch; li...@armlinux.org.uk; da...@davemloft.net; > k...@kernel.org > Cc: netdev@vger.kernel.org; linux-ker...@vger.ker

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Joakim Zhang
Hi Charistian, > -Original Message- > From: Christian Melki > Sent: 2021年4月5日 16:44 > To: Heiner Kallweit ; Joakim Zhang > ; and...@lunn.ch; li...@armlinux.org.uk; > da...@davemloft.net; k...@kernel.org > Cc: netdev@vger.kernel.org; linux-ker...@vger.ker

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Joakim Zhang
Hi Heiner, > -Original Message- > From: Heiner Kallweit > Sent: 2021年4月5日 6:49 > To: Joakim Zhang ; and...@lunn.ch; > li...@armlinux.org.uk; da...@davemloft.net; k...@kernel.org > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; dl-linux-imx > ; chris

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Joakim Zhang
Hi Heiner, Thanks for your comments. > -Original Message- > From: Heiner Kallweit > Sent: 2021年4月4日 22:09 > To: Joakim Zhang ; and...@lunn.ch; > li...@armlinux.org.uk; da...@davemloft.net; k...@kernel.org > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel

[PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-04 Thread Joakim Zhang
complete auto-nego. This patch changes PHY state to PHY_UP when MDIO bus resume back, it should be reasonable after PHY hardware re-initialized. Also give state machine a chance to start/config auto-nego again. Signed-off-by: Joakim Zhang --- drivers/net/phy/phy_device.c | 7 +++ 1 fil

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-31 Thread Joakim Zhang
> -Original Message- > From: Jon Hunter > Sent: 2021年3月31日 19:29 > To: Joakim Zhang ; Giuseppe Cavallaro > ; Alexandre Torgue ; > Jose Abreu > Cc: netdev@vger.kernel.org; Linux Kernel Mailing List > ; linux-tegra ; > Jakub Kicinski > Subject: Re: Regress

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-31 Thread Joakim Zhang
> -Original Message- > From: Joakim Zhang > Sent: 2021年3月31日 15:44 > To: Jon Hunter > Cc: netdev@vger.kernel.org; Linux Kernel Mailing List > ; linux-tegra ; > Jakub Kicinski > Subject: RE: Regression v5.12-rc3: net: stmmac: re-init rx buffer

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-31 Thread Joakim Zhang
> -Original Message- > From: Jon Hunter > Sent: 2021年3月30日 20:51 > To: Joakim Zhang > Cc: netdev@vger.kernel.org; Linux Kernel Mailing List > ; linux-tegra ; > Jakub Kicinski > Subject: Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac > resu

RE: FEC unbind/bind feature

2021-03-29 Thread Joakim Zhang
> -Original Message- > From: Andrew Lunn > Sent: 2021年3月26日 20:34 > To: Joakim Zhang > Cc: Florian Fainelli ; hkallwe...@gmail.com; > netdev@vger.kernel.org > Subject: Re: FEC unbind/bind feature > > > One more add, yes, I am looking the drivers/net/mdi

RE: FEC unbind/bind feature

2021-03-26 Thread Joakim Zhang
> -Original Message- > From: Andrew Lunn > Sent: 2021年3月26日 20:34 > To: Joakim Zhang > Cc: Florian Fainelli ; hkallwe...@gmail.com; > netdev@vger.kernel.org > Subject: Re: FEC unbind/bind feature > > > One more add, yes, I am looking the drivers/net/mdi

RE: FEC unbind/bind feature

2021-03-26 Thread Joakim Zhang
> -Original Message- > From: Joakim Zhang > Sent: 2021年3月26日 16:03 > To: Andrew Lunn > Cc: Florian Fainelli ; hkallwe...@gmail.com; > netdev@vger.kernel.org > Subject: RE: FEC unbind/bind feature > > > Hi Andrew, > > Thanks for your kindly

RE: FEC unbind/bind feature

2021-03-26 Thread Joakim Zhang
Hi Andrew, Thanks for your kindly reply! > -Original Message- > From: Andrew Lunn > Sent: 2021年3月25日 20:45 > To: Joakim Zhang > Cc: Florian Fainelli ; hkallwe...@gmail.com; > netdev@vger.kernel.org > Subject: Re: FEC unbind/bind feature > > On Thu, Mar 2

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-25 Thread Joakim Zhang
> -Original Message- > From: Jon Hunter > Sent: 2021年3月25日 16:01 > To: Joakim Zhang > Cc: netdev@vger.kernel.org; Linux Kernel Mailing List > ; linux-tegra ; > Jakub Kicinski > Subject: Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac > r

FEC unbind/bind feature

2021-03-25 Thread Joakim Zhang
that if we want to implement unbind/bind feature, what need we do? It seems to abstract an independent MDIO bus for dual FEC instances. I look at the MDIO dt bindings, it seems support such case as it has "reg" property. (Documentation/devicetree/bindings/net/mdio.yaml) Is there any implements existing in the Linux kernel for a reference? From your opinions, do you think it is necessary to improve it? Best Regards, Joakim Zhang

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-25 Thread Joakim Zhang
> -Original Message- > From: Jon Hunter > Sent: 2021年3月24日 20:39 > To: Joakim Zhang > Cc: netdev@vger.kernel.org; Linux Kernel Mailing List > ; linux-tegra ; > Jakub Kicinski > Subject: Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac > resu

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-24 Thread Joakim Zhang
> -Original Message- > From: Jon Hunter > Sent: 2021年3月24日 18:51 > To: Joakim Zhang > Cc: netdev@vger.kernel.org; Linux Kernel Mailing List > ; linux-tegra ; > Jakub Kicinski > Subject: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac >

[PATCH V3 repost net-next 3/3] net: stmmac: dwmac-imx: add platform level clocks management for i.MX

2021-03-15 Thread Joakim Zhang
Split clocks settings from init callback into clks_config callback, which could support platform level clocks management. Reviewed-by: Andrew Lunn Signed-off-by: Joakim Zhang --- .../net/ethernet/stmicro/stmmac/dwmac-imx.c | 60 +++ 1 file changed, 36 insertions(+), 24

[PATCH V3 repost net-next 2/3] net: stmmac: add platform level clocks management

2021-03-15 Thread Joakim Zhang
This patch intends to add platform level clocks management. Some platforms may have their own special clocks, they also need to be managed dynamically. If you want to manage such clocks, please implement clks_config callback. Reviewed-by: Andrew Lunn Signed-off-by: Joakim Zhang --- drivers/net

[PATCH V3 repost net-next 1/3] net: stmmac: add clocks management for gmac driver

2021-03-15 Thread Joakim Zhang
functions can be called while the interface it not opened. Reviewed-by: Andrew Lunn Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 1 + .../net/ethernet/stmicro/stmmac/stmmac_main.c | 75 ++-- .../net/ethernet/stmicro/stmmac/stmmac_mdio.c | 111

[PATCH V3 repost net-next 0/3] net: stmmac: implement clocks management

2021-03-15 Thread Joakim Zhang
closed. * reverse Christmass tree. V2->V3: * slightly simple the code according to Andrew's suggesstion and also add tag: Reviewed-by: Andrew Lunn Joakim Zhang (3): net: stmmac: add clocks management for gmac driver net: stmmac: add platform level clocks ma

RE: stmmac driver timeout issue

2021-03-11 Thread Joakim Zhang
> -Original Message- > From: Florian Fainelli > Sent: 2021年3月9日 1:57 > To: Joakim Zhang ; Jakub Kicinski > ; Andrew Lunn > Cc: netdev@vger.kernel.org > Subject: Re: stmmac driver timeout issue > > On 3/8/21 4:45 AM, Joakim Zhang wrote: > > > >

RE: stmmac driver timeout issue

2021-03-08 Thread Joakim Zhang
this behavior? And Linux PHY frame work can handle this case, there is no config_init after resume, will the config be reset? Best Regards, Joakim Zhang > -Original Message- > From: Florian Fainelli > Sent: 2021年3月5日 8:28 > To: Joakim Zhang ; Jakub Kicinski > ; Andrew Lun

stmmac driver timeout issue

2021-03-04 Thread Joakim Zhang
d before accessing VLAN Filter registers, is there ang hints, thanks a lot! We have another board i.MX8DXL which don't need fix mac speed attach to AR8031 PHY, can't reproduce this issue. Best Regards, Joakim Zhang

[RFC V3 net-next 3/3] net: stmmac: dwmac-imx: add platform level clocks management for i.MX

2021-03-03 Thread Joakim Zhang
Split clocks settings from init callback into clks_config callback, which could support platform level clocks management. Reviewed-by: Andrew Lunn Signed-off-by: Joakim Zhang --- .../net/ethernet/stmicro/stmmac/dwmac-imx.c | 60 +++ 1 file changed, 36 insertions(+), 24

[RFC V3 net-next 2/3] net: stmmac: add platform level clocks management

2021-03-03 Thread Joakim Zhang
This patch intends to add platform level clocks management. Some platforms may have their own special clocks, they also need to be managed dynamically. If you want to manage such clocks, please implement clks_config callback. Reviewed-by: Andrew Lunn Signed-off-by: Joakim Zhang --- drivers/net

[RFC V3 net-next 0/3] net: stmmac: implement clocks management

2021-03-03 Thread Joakim Zhang
closed. * reverse Christmass tree. V2->V3: * slightly simple the code according to Andrew's suggesstion and also add tag: Reviewed-by: Andrew Lunn Joakim Zhang (3): net: stmmac: add clocks management for gmac driver net: stmmac: add platform level clocks ma

[RFC V3 net-next 1/3] net: stmmac: add clocks management for gmac driver

2021-03-03 Thread Joakim Zhang
functions can be called while the interface it not opened. Reviewed-by: Andrew Lunn Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 1 + .../net/ethernet/stmicro/stmmac/stmmac_main.c | 75 ++-- .../net/ethernet/stmicro/stmmac/stmmac_mdio.c | 111

RE: [PATCH net 1/1] net: stmmac: fix incorrect DMA channel intr enable setting of EQoS v4.10

2021-03-03 Thread Joakim Zhang
t; > We introduce dwmac410_dma_init_channel() here for both EQoS v4.10 and > above which use different DMA_CH(n)_Interrupt_Enable bit definitions for NIE > and AIE. > > Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx") > Signed-off-by: Ong Boon Leong > Sig

RE: [RFC V2 resend net-next 1/3] net: stmmac: add clocks management for gmac driver

2021-03-02 Thread Joakim Zhang
> -Original Message- > From: Andrew Lunn > Sent: 2021年3月3日 9:24 > To: Joakim Zhang > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; k...@kernel.org; > f.faine...@gmail.com; dl-linux-imx ; > netdev@vger.kernel.or

RE: [PATCH net v4 1/1] can: can_skb_set_owner(): fix ref counting if socket was closed before setting skb ownership

2021-03-02 Thread Joakim Zhang
> -Original Message- > From: Joakim Zhang > Sent: 2021年3月1日 18:57 > To: Oleksij Rempel ; m...@pengutronix.de; David S. > Miller ; Jakub Kicinski ; Oliver > Hartkopp ; Robin van der Gracht > > Cc: Andre Naujoks ; Eric Dumazet > ; ker...@pengutronix.de; linux-..

RE: [PATCH net v4 1/1] can: can_skb_set_owner(): fix ref counting if socket was closed before setting skb ownership

2021-03-01 Thread Joakim Zhang
t;] > | (__qdisc_run+0x4f0/0x534) > > To fix this problem, only set skb ownership to sockets which have still a ref > count > 0. > > Cc: Oliver Hartkopp > Cc: Andre Naujoks > Suggested-by: Eric Dumazet > Fixes: 0ae89beb283a ("can: add destructor for self g

[RFC V2 resend net-next 2/3] net: stmmac: add platform level clocks management

2021-03-01 Thread Joakim Zhang
This patch intends to add platform level clocks management. Some platforms may have their own special clocks, they also need to be managed dynamically. If you want to manage such clocks, please implement clks_config callback. Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac

[RFC V2 resend net-next 3/3] net: stmmac: dwmac-imx: add platform level clocks management for i.MX

2021-03-01 Thread Joakim Zhang
Split clocks settings from init callback into clks_config callback, which could support platform level clocks management. Signed-off-by: Joakim Zhang --- .../net/ethernet/stmicro/stmmac/dwmac-imx.c | 60 +++ 1 file changed, 36 insertions(+), 24 deletions(-) diff --git a

[RFC V2 resend net-next 1/3] net: stmmac: add clocks management for gmac driver

2021-03-01 Thread Joakim Zhang
functions can be called while the interface it not opened. Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 1 + .../net/ethernet/stmicro/stmmac/stmmac_main.c | 75 +-- .../net/ethernet/stmicro/stmmac/stmmac_mdio.c | 123 ++ .../ethernet

[RFC V2 resend net-next 0/3] net: stmmac: implement clocks management

2021-03-01 Thread Joakim Zhang
closed. * reverse Christmass tree. Joakim Zhang (3): net: stmmac: add clocks management for gmac driver net: stmmac: add platform level clocks management net: stmmac: dwmac-imx: add platform level clocks management for i.MX .../net/ethernet/stmicro/stmmac/dwmac-imx.c

RE: [RFC V2 net-next 0/3] net: stmmac: implement clocks management

2021-02-25 Thread Joakim Zhang
Hi All, There is an issue in this patch set version(V2), please stop reviewing. Sorry. I will fix it, and then repost it after testing. Best Regards, Joakim Zhang > -Original Message- > From: Joakim Zhang > Sent: 2021年2月25日 19:51 > To: peppe.cavall...@st.com; alexandre.t

[RFC V2 net-next 2/3] net: stmmac: add platform level clocks management

2021-02-25 Thread Joakim Zhang
This patch intends to add platform level clocks management. Some platforms may have their own special clocks, they also need to be managed dynamically. If you want to manage such clocks, please implement clks_config callback. Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac

[RFC V2 net-next 1/3] net: stmmac: add clocks management for gmac driver

2021-02-25 Thread Joakim Zhang
functions can be called while the interface it not opened. Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 1 + .../net/ethernet/stmicro/stmmac/stmmac_main.c | 74 ++-- .../net/ethernet/stmicro/stmmac/stmmac_mdio.c | 105 ++ .../ethernet

[RFC V2 net-next 3/3] net: stmmac: add platform level clocks management for i.MX

2021-02-25 Thread Joakim Zhang
Split clocks settings from init callback into clks_config callback, which could support platform level clocks management. Signed-off-by: Joakim Zhang --- .../net/ethernet/stmicro/stmmac/dwmac-imx.c | 60 +++ 1 file changed, 36 insertions(+), 24 deletions(-) diff --git a

[RFC V2 net-next 0/3] net: stmmac: implement clocks management

2021-02-25 Thread Joakim Zhang
closed. Joakim Zhang (3): net: stmmac: add clocks management for gmac driver net: stmmac: add platform level clocks management net: stmmac: add platform level clocks management for i.MX .../net/ethernet/stmicro/stmmac/dwmac-imx.c | 60 ++ drivers/net/ethernet/stmicro/stmmac/st

RE: [PATCH V1 net-next 0/3] net: stmmac: implement clocks

2021-02-25 Thread Joakim Zhang
> -Original Message- > From: Andrew Lunn > Sent: 2021年2月25日 10:34 > To: Joakim Zhang > Cc: netdev > Subject: Re: [PATCH V1 net-next 0/3] net: stmmac: implement clocks > > > Hi Andrew, > > > > > I don't have experience with Ethernet sw

[PATCH V5 net 5/5] net: stmmac: re-init rx buffers when mac resume back

2021-02-25 Thread Joakim Zhang
fatal bus error when DMA try to use this descriptor again. To fix this issue, we should re-init all rx buffers when mac resume back. Signed-off-by: Joakim Zhang --- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 84 ++- 1 file changed, 83 insertions(+), 1 deletion(-) diff --git a

[PATCH V5 net 3/5] net: stmmac: fix dma physical address of descriptor when display ring

2021-02-25 Thread Joakim Zhang
() function is broken for various descriptor, it only support normal descriptor(struct dma_desc) now, this patch also extends to support all descriptor types. Signed-off-by: Joakim Zhang --- .../ethernet/stmicro/stmmac/dwmac4_descs.c| 50 +--- .../net/ethernet/stmicro/stmmac

[PATCH V5 net 4/5] net: stmmac: fix wrongly set buffer2 valid when sph unsupport

2021-02-25 Thread Joakim Zhang
: Add Split Header support and enable it in XGMAC cores") Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 9 +++-- drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c | 2 +- drivers/net/ethernet/stmicro/stmmac/hwif.h | 2 +- drivers/ne

[PATCH V5 net 2/5] net: stmmac: fix watchdog timeout during suspend/resume stress test

2021-02-25 Thread Joakim Zhang
b33 ("net: stmmac: adding multiple buffers for rx") Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_

[PATCH V5 net 1/5] net: stmmac: stop each tx channel independently

2021-02-25 Thread Joakim Zhang
If clear GMAC_CONFIG_TE bit, it would stop all tx channels, but users may only want to stop specific tx channel. Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx") Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c | 4 1 file changed, 4

[PATCH V5 net 0/5] ethernet: fixes for stmmac driver

2021-02-25 Thread Joakim Zhang
to support all descriptor types. * while() -> do-while() Joakim Zhang (5): net: stmmac: stop each tx channel independently net: stmmac: fix watchdog timeout during suspend/resume stress test net: stmmac: fix dma physical address of descriptor when display ring net: stmmac: fix w

RE: [PATCH V1 net-next 0/3] net: stmmac: implement clocks

2021-02-24 Thread Joakim Zhang
> -Original Message- > From: Andrew Lunn > Sent: 2021年2月24日 21:02 > To: Jakub Kicinski > Cc: Joakim Zhang ; peppe.cavall...@st.com; > alexandre.tor...@st.com; joab...@synopsys.com; da...@davemloft.net; > netdev@vger.kernel.org; dl-linux-imx > Subject: Re: [PA

RE: [PATCH V1 net-next 0/3] net: stmmac: implement clocks

2021-02-24 Thread Joakim Zhang
> -Original Message- > From: Florian Fainelli > Sent: 2021年2月24日 11:54 > To: Joakim Zhang ; Jakub Kicinski > > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; netdev@vger.kernel.org; > dl-linux-imx > Subject:

RE: [PATCH V1 net-next 0/3] net: stmmac: implement clocks

2021-02-24 Thread Joakim Zhang
> -Original Message- > From: Jakub Kicinski > Sent: 2021年2月24日 10:35 > To: Joakim Zhang > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; netdev@vger.kernel.org; > dl-linux-imx > Subject: Re: [PATCH V1 n

RE: [PATCH V1 net-next 0/3] net: stmmac: implement clocks

2021-02-23 Thread Joakim Zhang
> -Original Message- > From: Jakub Kicinski > Sent: 2021年2月24日 10:35 > To: Joakim Zhang > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; netdev@vger.kernel.org; > dl-linux-imx > Subject: Re: [PATCH V1 n

RE: [PATCH V1 net-next 0/3] net: stmmac: implement clocks

2021-02-23 Thread Joakim Zhang
> -Original Message- > From: Jakub Kicinski > Sent: 2021年2月24日 9:55 > To: Joakim Zhang > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; netdev@vger.kernel.org; > dl-linux-imx > Subject: Re: [PATCH V1 n

RE: [PATCH V1 net-next 1/3] net: stmmac: add clocks management for gmac driver

2021-02-23 Thread Joakim Zhang
> -Original Message- > From: Jakub Kicinski > Sent: 2021年2月24日 0:46 > To: Joakim Zhang > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; netdev@vger.kernel.org; > dl-linux-imx > Subject: Re: [PATCH V1 net-ne

RE: [PATCH V1 net-next 0/3] net: stmmac: implement clocks

2021-02-23 Thread Joakim Zhang
> -Original Message- > From: Jakub Kicinski > Sent: 2021年2月24日 0:45 > To: Joakim Zhang > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; netdev@vger.kernel.org; > dl-linux-imx > Subject: Re: [PATCH V1 n

[PATCH V1 net-next 1/3] net: stmmac: add clocks management for gmac driver

2021-02-23 Thread Joakim Zhang
. Signed-off-by: Joakim Zhang --- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 60 --- 1 file changed, 51 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 26b971cd4da5..35a79c00a477

[PATCH V1 net-next 3/3] net: stmmac: add platform level clocks management for i.MX

2021-02-23 Thread Joakim Zhang
Split clocks settings from init callback into clks_enable callback, which could support platform level clocks management. Signed-off-by: Joakim Zhang --- .../net/ethernet/stmicro/stmmac/dwmac-imx.c | 60 +++ 1 file changed, 36 insertions(+), 24 deletions(-) diff --git a

[PATCH V1 net-next 2/3] net: stmmac: add platform level clocks management

2021-02-23 Thread Joakim Zhang
This patch intends to add platform level clocks management. Some platforms may have their own special clocks, they also need to be managed dynamically. If you want to manage such clocks, please implement clks_enable callback. Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac

[PATCH V1 net-next 0/3] net: stmmac: implement clocks

2021-02-23 Thread Joakim Zhang
In stmmac driver, clocks are all enabled after device probed, this leads to more power consumption. This patch set tries to implement clocks management, and takes i.MX platform as a example. Joakim Zhang (3): net: stmmac: add clocks management for gmac driver net: stmmac: add platform level

RE: [PATCH V4 net 5/5] net: stmmac: re-init rx buffers when mac resume back

2021-02-22 Thread Joakim Zhang
> -Original Message- > From: Jakub Kicinski > Sent: 2021年2月23日 3:48 > To: Joakim Zhang > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; netdev@vger.kernel.org; > dl-linux-imx > Subject: Re: [PATCH V4 net 5/5]

RE: [PATCH V4 net 3/5] net: stmmac: fix dma physical address of descriptor when display ring

2021-02-22 Thread Joakim Zhang
> -Original Message- > From: Jakub Kicinski > Sent: 2021年2月23日 3:46 > To: Joakim Zhang > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; netdev@vger.kernel.org; > dl-linux-imx > Subject: Re: [PATCH V4 net 3

RE: [PATCH V4 net 5/5] net: stmmac: re-init rx buffers when mac resume back

2021-02-19 Thread Joakim Zhang
> -Original Message- > From: Jakub Kicinski > Sent: 2021年2月7日 4:38 > To: Joakim Zhang > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; netdev@vger.kernel.org; > dl-linux-imx > Subject: Re: [PATCH V4 net 5/5]

RE: [PATCH V4 net 3/5] net: stmmac: fix dma physical address of descriptor when display ring

2021-02-19 Thread Joakim Zhang
> -Original Message- > From: Jakub Kicinski > Sent: 2021年2月7日 4:29 > To: Joakim Zhang > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; netdev@vger.kernel.org; > dl-linux-imx > Subject: Re: [PATCH V4 net 3

RE: [PATCH net-next 2/2] net: stmmac: slightly adjust the order of the codes in stmmac_resume()

2021-02-04 Thread Joakim Zhang
> -Original Message- > From: Willem de Bruijn > Sent: 2021年2月4日 21:20 > To: Joakim Zhang > Cc: Giuseppe Cavallaro ; Alexandre Torgue > ; Jose Abreu ; David > Miller ; Jakub Kicinski ; Network > Development ; Andrew Lunn ; > Florian Fainelli ; Willem de Brui

[PATCH V4 net 4/5] net: stmmac: fix wrongly set buffer2 valid when sph unsupport

2021-02-04 Thread Joakim Zhang
: Add Split Header support and enable it in XGMAC cores") Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 9 +++-- drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c | 2 +- drivers/net/ethernet/stmicro/stmmac/hwif.h | 2 +- drivers/ne

[PATCH V4 net 1/5] net: stmmac: stop each tx channel independently

2021-02-04 Thread Joakim Zhang
If clear GMAC_CONFIG_TE bit, it would stop all tx channels, but users may only want to stop specific tx channel. Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx") Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c | 4 1 file changed, 4

[PATCH V4 net 3/5] net: stmmac: fix dma physical address of descriptor when display ring

2021-02-04 Thread Joakim Zhang
: Joakim Zhang --- .../ethernet/stmicro/stmmac/dwmac4_descs.c| 7 +-- .../net/ethernet/stmicro/stmmac/enh_desc.c| 7 +-- drivers/net/ethernet/stmicro/stmmac/hwif.h| 3 +- .../net/ethernet/stmicro/stmmac/norm_desc.c | 7 +-- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 54

[PATCH V4 net 5/5] net: stmmac: re-init rx buffers when mac resume back

2021-02-04 Thread Joakim Zhang
fatal bus error when DMA try to use this descriptor again. To fix this issue, we should re-init all rx buffers when mac resume back. Signed-off-by: Joakim Zhang --- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 87 ++- 1 file changed, 86 insertions(+), 1 deletion(-) diff --git a

[PATCH V4 net 2/5] net: stmmac: fix watchdog timeout during suspend/resume stress test

2021-02-04 Thread Joakim Zhang
b33 ("net: stmmac: adding multiple buffers for rx") Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_

[PATCH V4 net 0/5] ethernet: fixes for stmmac driver

2021-02-04 Thread Joakim Zhang
add error handling for stmmac_reinit_rx_buffers() function. V3->V4: * remove patch (net: stmmac: remove redundant null check for ptp clock), reviewer thinks it should target net-next. Joakim Zhang (5): net: stmmac: stop each tx channel independently net: stmmac: fix watchdog ti

[PATCH net-next 1/2] net: stmmac: remove redundant null check for ptp clock

2021-02-04 Thread Joakim Zhang
ll check before clk_disable_unprepare()") Reviewed-by: Andrew Lunn Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac

[PATCH net-next 2/2] net: stmmac: slightly adjust the order of the codes in stmmac_resume()

2021-02-04 Thread Joakim Zhang
Slightly adjust the order of the codes in stmmac_resume(), remove the check "if (!device_may_wakeup(priv->device) || !priv->plat->pmt)". Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 14 ++ 1 file changed, 6 insertions(+), 8

  1   2   3   4   >