On Mon, 2020-06-01 at 13:33 -0600, Jason A. Donenfeld wrote:
> Hi Dave,
>
> On Mon, Jun 1, 2020 at 12:00 PM David Miller wrote:
> > This is going to make nearly every -stable backport not apply cleanly,
> > which is a severe burdon for everyone having to maintain stable trees.
>
> This possibili
On Mon, 2020-06-01 at 00:29 -0600, Jason A. Donenfeld wrote:
> While this sort of change is typically viewed as "trivial", "cosmetic",
> or even "bikesheddy", I think there's a very serious argument to be made
> about the readability and comprehensibility of the code as a result.
Hey Jason.
I thi
On Fri, 2020-05-29 at 19:23 +0800, Wang Li wrote:
> diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
[]
> @@ -798,7 +798,6 @@ void udp_set_csum(bool nocheck, struct sk_buff *skb,
> } else if (skb_is_gso(skb)) {
> uh->check = ~udp_v4_check(len, saddr, daddr, 0);
> } else if (sk
On Tue, 2020-05-19 at 01:35 +, Kirsher, Jeffrey T wrote:
> > -Original Message-
> > From: Joe Perches
> > Sent: Monday, May 18, 2020 18:22
> > To: Kirsher, Jeffrey T ; da...@davemloft.net
> > Cc: Guedes, Andre ; netdev@vger.kernel.org;
> > nho
On Mon, 2020-05-18 at 18:03 -0700, Jeff Kirsher wrote:
> This patch converts all dev_* calls to netdev_*.
[]
> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> b/drivers/net/ethernet/intel/igc/igc_ethtool.c
[]
> @@ -1904,7 +1905,7 @@ static void igc_diag_test(struct net_device *netdev,
On Sun, 2020-05-17 at 04:47 +0200, Marek Vasut wrote:
> On 5/17/20 4:37 AM, Joe Perches wrote:
> > On Sun, 2020-05-17 at 04:28 +0200, Marek Vasut wrote:
> > > On 5/17/20 4:01 AM, Joe Perches wrote:
> > > > On Sun, 2020-05-17 at 02:33 +0200, Marek Vasut wrote:
> &g
On Sun, 2020-05-17 at 04:28 +0200, Marek Vasut wrote:
> On 5/17/20 4:01 AM, Joe Perches wrote:
> > On Sun, 2020-05-17 at 02:33 +0200, Marek Vasut wrote:
> > > Drop those debug statements from both drivers. They were there since
> > > at least 2011 and enabled by defau
On Sun, 2020-05-17 at 02:33 +0200, Marek Vasut wrote:
> Drop those debug statements from both drivers. They were there since
> at least 2011 and enabled by default, but that's likely wrong.
[]
> diff --git a/drivers/net/ethernet/micrel/ks8851_par.c
> b/drivers/net/ethernet/micrel/ks8851_par.c
[]
>
On Thu, 2020-05-14 at 17:09 -0700, Alexei Starovoitov wrote:
> On Thu, May 14, 2020 at 04:43:24PM -0700, Joe Perches wrote:
> > The ``BTF_INT_BITS()`` specifies the number of actual bits held by this int
> > type. For example, a 4-bit bitfield encodes ``BTF_INT_BITS()`` equals
On Wed, 2020-05-13 at 16:22 -0700, Joe Perches wrote:
> On Wed, 2020-05-13 at 16:07 -0700, Alexei Starovoitov wrote:
> > On Wed, May 13, 2020 at 4:05 PM Joe Perches wrote:
> > > On Tue, 2020-05-12 at 06:56 +0100, Alan Maguire wrote:
> > > > printk supports multiple
On Thu, 2020-05-14 at 12:30 +0200, Christoph Hellwig wrote:
> On Wed, May 13, 2020 at 02:00:43PM -0700, Joe Perches wrote:
> > On Wed, 2020-05-13 at 08:26 +0200, Christoph Hellwig wrote:
> > > Add a helper to directly set the IP_RECVERR sockopt from kernel space
> > > w
On Wed, 2020-05-13 at 15:50 -0700, Alexei Starovoitov wrote:
> On Wed, May 13, 2020 at 3:48 PM Joe Perches wrote:
> > On Wed, 2020-05-13 at 15:24 -0700, Alexei Starovoitov wrote:
> > > On Tue, May 12, 2020 at 06:56:38AM +0100, Alan Maguire wrote:
> > > > The prin
On Wed, 2020-05-13 at 16:07 -0700, Alexei Starovoitov wrote:
> On Wed, May 13, 2020 at 4:05 PM Joe Perches wrote:
> > On Tue, 2020-05-12 at 06:56 +0100, Alan Maguire wrote:
> > > printk supports multiple pointer object type specifiers (printing
> > > netdev features
On Tue, 2020-05-12 at 06:56 +0100, Alan Maguire wrote:
> printk supports multiple pointer object type specifiers (printing
> netdev features etc). Extend this support using BTF to cover
> arbitrary types. "%pT" specifies the typed format, and the pointer
> argument is a "struct btf_ptr *" where s
On Wed, 2020-05-13 at 15:24 -0700, Alexei Starovoitov wrote:
> On Tue, May 12, 2020 at 06:56:38AM +0100, Alan Maguire wrote:
> > The printk family of functions support printing specific pointer types
> > using %p format specifiers (MAC addresses, IP addresses, etc). For
> > full details see Docume
On Wed, 2020-05-13 at 08:26 +0200, Christoph Hellwig wrote:
> Add a helper to directly set the IP_RECVERR sockopt from kernel space
> without going through a fake uaccess.
This seems used only with true as the second arg.
Is there reason to have that argument at all?
> diff --git a/include/net/ip
On Wed, 2020-05-13 at 08:26 +0200, Christoph Hellwig wrote:
> this series removes the kernel_setsockopt and kernel_getsockopt
> functions, and instead switches their users to small functions that
> implement setting (or in one case getting) a sockopt directly using
> a normal kernel function call w
dd a link to recent discussion,
> - don't match when scanning files, not patches to avoid sudden
>influx of conversion patches.
> https://lore.kernel.org/netdev/20200511165319.2251678-1-k...@kernel.org/
>
> v1:
> https://lore.kernel.org/netdev/20200510185148.223076
ey type
> ENOTSUPP.
> +# Similarly to ENOSYS warning a small number of false positives is expected.
> + if (~$file && $line =~ /\bENOTSUPP\b/) {
It's probably my typo or my brain thinking "not" and hitting
the tilde and not the bang, b
On Sun, 2020-05-10 at 11:51 -0700, Jakub Kicinski wrote:
> ENOTSUPP often feels like the right error code to use, but it's
> in fact not a standard Unix error. E.g.:
It is SUSv3 though.
> $ python
> > > > import errno
> > > > errno.errorcode[errno.ENOTSUPP]
> Traceback (most recent call last):
>
On Sat, 2020-05-09 at 16:32 -0700, David Miller wrote:
> From: Joe Perches
> Date: Sat, 09 May 2020 15:42:36 -0700
>
> > David, maybe I missed some notification about Jakub's role.
> >
> > What is Jakub's role in relation to the networking tree?
>
>
On Sat, 2020-05-09 at 11:13 -0700, Jakub Kicinski wrote:
> On Sat, 9 May 2020 18:47:08 +0200 Christophe JAILLET wrote:
> > Le 09/05/2020 à 03:54, Jakub Kicinski a écrit :
> > > On Fri, 8 May 2020 19:25:57 +0200 Christophe JAILLET wrote:
> > > > @@ -527,8 +531,9 @@ static int mac_sonic_platform_r
On Fri, 2020-05-08 at 18:48 -0700, Jakub Kicinski wrote:
> On Sat, 9 May 2020 00:31:03 +0100 Colin Ian King wrote:
> > > My preference would be for
> > >
> > > {
> > > int i;
> > > u32 off = 0;
> > >
> > > for (i = 0; i < TG3_SD_NUM_RECS; i++) {
> > > tg3_ape_scratchpad_read(tp, (
On Fri, 2020-05-08 at 23:53 +0100, Colin King wrote:
> From: Colin Ian King
>
> Currently the value for 'off' is computed using a multiplication and
> a couple of statements later off is being incremented by len and
> this value is never read. Clean up the code by removing the
> multiplication a
On Wed, 2020-05-06 at 22:16 +0300, Leon Romanovsky wrote:
> On Tue, May 5, 2020 at 5:03 PM Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski
> >
> > This adds the driver for the MediaTek Ethernet MAC used on the MT8* SoC
> > family. For now we only support full-duplex.
[]
> > diff --git a
On Wed, 2020-05-06 at 16:51 +0300, Luciano Coelho wrote:
> On Tue, 2020-05-05 at 20:19 -0700, Joe Perches wrote:
> > On Wed, 2020-05-06 at 11:07 +0800, Samuel Zou wrote:
> > > This silences the following coccinelle warning:
> > >
> > > "WARNING: sum of
On Wed, 2020-05-06 at 11:07 +0800, Samuel Zou wrote:
> This silences the following coccinelle warning:
>
> "WARNING: sum of probable bitmasks, consider |"
I suggest instead ignoring bad and irrelevant warnings.
PREFIX_LEN is 32 not 0x20 or BIT(5)
PCI_DUMP_SIZE is 352
> diff --git a/drivers/net/
On Mon, 2020-05-04 at 13:37 +0200, Björn Töpel wrote:
> Update MAINTAINERS to correctly mirror the current AF_XDP socket file
> layout. Also, add the AF_XDP files of libbpf.
[]
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -18451,8 +18451,12 @@ R: Jonathan Lemon
> L: netdev@vger.kernel.org
On Mon, 2020-05-04 at 19:55 +0200, Uwe Kleine-König wrote:
> Hi Sam,
>
> On Mon, May 04, 2020 at 07:45:22PM +0200, Sam Ravnborg wrote:
> > On Mon, May 04, 2020 at 11:30:20AM +0200, Mauro Carvalho Chehab wrote:
> > > There are some new broken doc links due to yaml renames
> > > at DT. Developers sh
On Mon, 2020-05-04 at 11:30 +0200, Mauro Carvalho Chehab wrote:
> There are some new broken doc links due to yaml renames
> at DT. Developers should really run:
>
> ./scripts/documentation-file-ref-check
>
> in order to solve those issues while submitting patches.
> This tool can even fix m
On Thu, 2020-04-30 at 03:03 -0700, Alan Maguire wrote:
> On Mon, 20 Apr 2020, Joe Perches wrote:
> > Here as well the individual field types don't contain
> > enough information to determine if a field should be
> > output as %x or %u.
> Right, we could add some mo
On Thu, 2020-04-30 at 12:38 +0300, Dan Carpenter wrote:
> On Wed, Apr 29, 2020 at 09:33:04PM -0400, Rylan Dmello wrote:
> > As suggested by Joe Perches, this patch removes the 'exit' label
> > from the ql_set_mac_addr_reg function and replaces the goto
> > s
On Wed, 2020-04-29 at 21:31 -0400, Rylan Dmello wrote:
> This patchset fixes some indentation- and style-related issues in qlge_main.c
> reported by checkpatch.pl, such as:
>
> WARNING: Avoid multiple line dereference
> WARNING: line over 80 characters
> WARNING: suspect code indent for cond
On Wed, 2020-04-29 at 00:04 -0400, Rylan Dmello wrote:
> Fix checkpatch.pl warnings:
>
> WARNING: Avoid multiple line dereference - prefer 'qdev->func'
> WARNING: Avoid multiple line dereference - prefer 'qdev->flags'
Assuming you are doing this for exercise:
It'd be better to unindent all t
On Wed, 2020-04-29 at 11:15 +0800, Zou Wei wrote:
> fix coccinelle warning, use ARRAY_SIZE
>
> drivers/net/ethernet/huawei/hinic/hinic_sriov.c:713:43-44: WARNING: Use
> ARRAY_SIZE
>
> Reported-by: Hulk Robot
> Signed-off-by: Zou Wei
> ---
> drivers/net/ethernet/huawei/hinic/hinic_sriov.c | 3
On Mon, 2019-10-07 at 13:44 -0700, Jeff Kirsher wrote:
> On Sun, 2019-10-06 at 10:19 -0700, Joe Perches wrote:
> > This got converted from strncpy to strlcpy but it's
> > now not necessary to use one character less than the
> > actual size.
> >
> > Perhaps t
This got converted from strncpy to strlcpy but it's
now not necessary to use one character less than the
actual size.
Perhaps the sizeof() - 1 is now not correct and it
should use strscpy and a normal sizeof.
from:
commit 7eb74ff891b4e94b8bac48f648a21e4b94ddee64
Author: Mitch Williams
Date: M
On Mon, 2019-08-12 at 12:43 -0500, Thomas Falcon wrote:
> The ibm,mac-address-filters property defines the maximum number of
> addresses the hypervisor's multicast filter list can support. It is
> encoded as a big-endian integer in the OF device tree, but the virtual
> ethernet driver does not conv
On Thu, 2019-08-01 at 12:51 -0400, David Miller wrote:
> From: Hangbin Liu
> Date: Thu, 1 Aug 2019 17:03:47 +0800
>
> > When setting lots of multicast list on ibmveth, e.g. add 3000 membership on
> > a
> > multicast group, the following error message flushes our log file
> >
> > 8507[ 901
On Thu, 2019-08-01 at 22:10 +0800, Hangbin Liu wrote:
> On Thu, Aug 01, 2019 at 03:28:43AM -0700, Joe Perches wrote:
> > Perhaps add the netdev__ratelimited variants and use that instead
> >
> > Somthing like:
>
> Yes, that looks better. Do you mind if I take your cod
On Thu, 2019-08-01 at 17:03 +0800, Hangbin Liu wrote:
> When setting lots of multicast list on ibmveth, e.g. add 3000 membership on a
> multicast group, the following error message flushes our log file
>
> 8507[ 901.478251] ibmveth 3003 env3: h_multicast_ctrl rc=4 when
> adding an entry
On Fri, 2019-06-28 at 15:49 -0700, Jeff Kirsher wrote:
> This aligns the iavf_debug() macro with the other Intel drivers.
>
> Add the bus number, bus_id field to i40e_bus_info so output shows
> each physical port(i.e func) in following format:
> ]:]]:][][.[]]
> domains are numbered from 0 to
On Sun, 2019-06-23 at 08:37 -0700, David Miller wrote:
> From: Daniele Venzano
> Date: Sun, 23 Jun 2019 11:13:28 +0200
>
> > Hello,
> >
> > I think it is good to know just by looking at the sources that the
> > driver is still kept up-to-date, so I am in favor of this patch.
>
> I absolutely, s
On Sun, 2019-06-23 at 09:47 +0200, Sergej Benilov wrote:
> Increment revision number to 1.08.11 (TX completion fix).
Better not to bother as the last increment was in 2006.
The driver version gets the kernel version in any case.
> diff --git a/drivers/net/ethernet/sis/sis900.c
> b/drivers/net/et
On Mon, 2019-06-03 at 14:50 +0100, Kevin Darbyshire-Bryant wrote:
> ctinfo is an action restoring data stored in conntrack marks to various
> fields. At present it has two independent modes of operation,
> restoration of DSCP into IPv4/v6 diffserv and restoration of conntrack
> marks into packet s
On Fri, 2019-05-31 at 12:29 -0500, Larry Finger wrote:
> On 5/31/19 9:14 AM, Colin King wrote:
> > From: Colin Ian King
> >
> > The assignment of 0 to variable k is never read once we break out of
> > the loop, so the assignment is redundant and can be removed.
> >
> > Addresses-Coverity: ("Unus
On Fri, 2019-05-31 at 01:15 -0700, Jeff Kirsher wrote:
> From: Nathan Chancellor
> We can convert from gnu_printf to printf without any side effects
[]
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_osdep.h
> b/drivers/net/ethernet/intel/iavf/iavf_osdep.h
[]
> @@ -46,7 +46,7 @@ struct iavf_v
On Tue, 2019-05-21 at 12:42 +0300, Dan Carpenter wrote:
> We used a script to indent this code back in 2012, but I guess it got
> confused by the ifdefs and added some extra tabs. This patch removes
> them.
Yup, thanks Dan.
Emacs indent-region made a mess of it.
> drivers/isdn/mISDN/dsp_cmx.c |
On Thu, 2019-03-28 at 15:36 +0300, Mika Westerberg wrote:
> Now that the driver can handle every possible tunnel types there is no
> point to log everything as info level so turn these to happen at debug
> level instead.
trivia:
> diff --git a/drivers/thunderbolt/path.c b/drivers/thunderbolt/path
On Mon, 2019-03-04 at 13:12 -0600, Dan Murphy wrote:
> On 3/4/19 12:13 PM, Wolfgang Grandegger wrote:
> > Am 04.03.19 um 18:22 schrieb Dan Murphy:
> > > > > + int pm_clock_support;
> > > >
> > > > A "bool" would be more appropriate, I think.
> > >
> > > I was abiding by this checkpatch warnin
On Sat, 2019-03-02 at 14:31 -0600, Aditya Pakki wrote:
> kmalloc can fail in rsi_register_rates_channels but memcpy still attempts
> to write to channels. The patch checks and avoids such a situation.
[]
> diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> b/drivers/net/wireless/rsi/rsi_91
On Fri, 2019-03-01 at 21:46 -0800, David Miller wrote:
> From: Andy Shevchenko
> Date: Thu, 28 Feb 2019 23:34:29 +0300
>
> > @@ -1554,7 +1554,7 @@ static int enc28j60_probe(struct spi_device *spi)
> > {
> > struct net_device *dev;
> > struct enc28j60_net *priv;
> > - const void *
Make logging of an ethernet address more consistent with
the rest of the kernel.
Miscellanea:
The %02hx use also did not quite match the u8 definition
of addr though that did not actually matter given normal
integer promotion rules.
Signed-off-by: Joe Perches
---
drivers/net/ethernet
On Thu, 2019-02-28 at 11:36 +, Matthias Maennich wrote:
> According to Documentation/core-api/printk-formats.rst, size_t should be
> printed with %zu, rather than %Zu.
>
> In addition, using %Zu triggers a warning on clang (-Wformat-extra-args):
[]
> diff --git a/net/sctp/chunk.c b/net/sctp/ch
On Tue, 2019-02-26 at 22:09 -0800, Robert Eshleman wrote:
> This patch replaces a pci_alloc_consistent and memset(,0) call
> with a single call to pci_zalloc_consistent.
[]
> diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c
[]
> @@ -845,17 +845,16 @@ static int tlan_init
On Mon, 2019-02-25 at 09:39 +0100, Jesper Dangaard Brouer wrote:
> On Sat, 23 Feb 2019 01:47:00 +0100
> Daniel Borkmann wrote:
>
> > On 02/22/2019 10:45 PM, Jakub Kicinski wrote:
> > > On Fri, 22 Feb 2019 12:14:57 -0800, Joe Perches wrote:
> > > > On F
would like to use it for debugging.
> >
> > Signed-off-by: Yafang Shao
> > Suggested-by: Joe Perches
>
> Sorry, I'm not applying this.
>
> You are forcing everyone who wants to use this to add a curstom local
> source code change into their build.
That
On Fri, 2019-02-22 at 12:01 -0800, Jakub Kicinski wrote:
> Hi!
>
> Seems like something funny is going on with get_maintainer.pl since XDP
> entry got added. We seem to have been CCed on:
I suggest removing the MAINTAINERS line with
K: xdp
as xdp is a pretty generic file/patch con
On Tue, 2019-02-12 at 19:51 -0800, Florian Fainelli wrote:
> On February 12, 2019 6:39:49 PM PST, tristram...@microchip.com wrote:
> > > > +static void ksz9477_freeze_mib(struct ksz_device *dev, int port,
> > > > + bool freeze)
> > > > +{
> > > > + struct ksz_por
r tracepoint, for this kind
> of debugging purpose.
> So we'd better disable it by default.
> The reason why I don't remove it comepletely is that someone may still
> would like to use it for debugging.
>
> Signed-off-by: Yafang Shao
> Suggested-by: Joe Perches
>
On Fri, 2019-02-15 at 10:22 -0800, Eric Dumazet wrote:
> On Fri, Feb 15, 2019 at 10:13 AM Cong Wang wrote:
> > On Fri, Feb 15, 2019 at 8:26 AM Eric Dumazet wrote:
> > > On Fri, Feb 15, 2019 at 6:50 AM Yafang Shao wrote:
> > > > As SOCK_DEBUG() isn't used any more, we can get ride of it now.
> >
On Thu, 2019-02-07 at 18:40 -0600, Gustavo A. R. Silva wrote:
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes, in particular in the
> context in which this code is being used.
>
> So, change the following form:
>
> sizeof(*ev
On Thu, 2019-02-07 at 18:28 -0600, Gustavo A. R. Silva wrote:
> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
>
> struct foo {
>
On Tue, 2019-02-05 at 12:04 -0800, Eric Dumazet wrote:
>
> On 02/05/2019 10:42 AM, Joe Perches wrote:
> > It's declared after a pointer so it is already is 2 byte aligned.
> >
> > A lot of drivers wouldn't work otherwise.
>
> Maybe these drivers are
On Tue, 2019-02-05 at 11:14 -0800, David Miller wrote:
> From: Joe Perches
> Date: Tue, 05 Feb 2019 10:42:54 -0800
>
> > On Mon, 2019-02-04 at 19:20 -0800, David Miller wrote:
> >> From: Thierry Reding
> >> Date: Mon, 4 Feb 2019 17:42:13 +0100
> >>
On Mon, 2019-02-04 at 19:20 -0800, David Miller wrote:
> From: Thierry Reding
> Date: Mon, 4 Feb 2019 17:42:13 +0100
>
> > @@ -7316,7 +7325,7 @@ static int rtl_get_ether_clk(struct rtl8169_private
> > *tp)
> > static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id
> > *ent)
Add __cold to the netdev_ logging functions similar to
the use of __cold in the generic printk function.
Using __cold moves all the netdev_ logging functions
out-of-line possibly improving code locality and runtime
performance.
Signed-off-by: Joe Perches
---
include/linux/netdevice.h | 16
On Wed, 2019-01-30 at 18:38 -0600, Gustavo A. R. Silva wrote:
> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
>
> struct foo {
>
On Mon, 2019-01-28 at 14:44 +0800, YueHaibing wrote:
> Use struct_size() in kzalloc instead of the 'regd_to_copy'
There is also the use above that in the same function
that could also be converted.
/* build a regdomain rule for every valid channel */
size_of_regd =
On Sat, 2019-01-26 at 20:42 +0800, YueHaibing wrote:
> Use kmemdup rather than duplicating its implementation
[]
> diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c
> b/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c
[]
> @@ -1196,13 +1196,9 @@ iwl_parse_nvm_mcc_info(struct device
On Thu, 2019-01-17 at 13:33 -0600, Larry Finger wrote:
> On 1/17/19 1:29 PM, Joe Perches wrote:
> > On Thu, 2019-01-17 at 15:28 +, Colin King wrote:
> > > From: Colin Ian King
> > >
> > > There is a statement that is indented too deeply. Fix this.
>
On Thu, 2019-01-17 at 15:28 +, Colin King wrote:
> From: Colin Ian King
>
> There is a statement that is indented too deeply. Fix this.
Thanks.
> diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c
> b/drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c
[]
> @@ -803,7 +803,7 @@
On Thu, 2019-01-17 at 00:13 +, Colin King wrote:
> From: Colin Ian King
>
> There is an if statement and a return statement that are incorrectly
> indented. Fix these.
[]
> diff --git a/drivers/net/sb1000.c b/drivers/net/sb1000.c
[]
> @@ -540,12 +540,12 @@ sb1000_activate(const int ioaddr[],
On Sat, 2019-01-12 at 12:45 -0800, Jakub Kicinski wrote:
> "IPv6: " prefix is already added by pr_fmt, no need to include
> it again in the pr_warn() format.
[]
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
[]
> @@ -4256,7 +4256,7 @@ static void ip6_print_replace_route_err(struct
> list_head
On Thu, 2019-01-10 at 07:28 +0100, Greg Kroah-Hartman wrote:
> l2cap_get_conf_opt can handle a "default" message type, but it needs to
> be verified that it really is the correct type (CONF_EFS or CONF_RFC)
> before passing it back to the caller. To do this we need to check the
> return value of t
On Mon, 2019-01-07 at 16:25 -0700, Jason Gunthorpe wrote:
> On Mon, Jan 07, 2019 at 02:10:22PM -0800, Joe Perches wrote:
> > On Mon, 2019-01-07 at 14:11 -0700, Jason Gunthorpe wrote:
> > > There has been some confusion since checkpatch started warning about bool
> > > us
and and Ack if
you want one:
Acked-by: Joe Perches
> diff --git a/Documentation/process/coding-style.rst
> b/Documentation/process/coding-style.rst
[]
> @@ -921,7 +921,37 @@ result. Typical examples would be functions that return
> pointers; they use
> NULL or the ERR_PTR mech
On Thu, 2018-12-20 at 20:31 -0700, Jason Gunthorpe wrote:
> On Thu, Dec 20, 2018 at 06:25:05PM -0800, Joe Perches wrote:
>
> > I agree it's not a very good message nor is bool use
> > of structure members a real problem except in very
> > few cases.
>
> I
Nevermind that this for bool vs bitfield. A int is worse in
> > every respect in the criteria used in that mail.
>
> (+Joe Perches)
>
> Hi Joe,
Hi all.
> This is the second time that I see that the checkpatch complaint about using
> bool in a structure leads kernel
On Tue, 2018-12-11 at 02:11 +0300, Darya Litvintseva wrote:
> Signed-off-by: Darya Litvintseva
Hello.
Most maintainers want some patch description
and not a blank commit message.
Whitespace only changes are sometimes not taken.
First kernel patches are best done in drivers/staging.
And some a
On Mon, 2018-12-03 at 08:40 -0500, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Thanks.
Are you doing these manually or using some script?
On Fri, 2018-11-30 at 23:51 -0500, Qian Cai wrote:
> netif_napi_add() could report an error like this below due to it allows
> to pass a format string for wildcarding before calling
> dev_get_valid_name(),
>
> "netif_napi_add() called with weight 256 on device eth%d"
>
> For example, hns_enet_drv
On Wed, 2018-11-07 at 14:48 -0800, Jeff Kirsher wrote:
> From: Sasha Neftin
>
> Address few community comments.
> Remove unused code, will be added per demand.
> Remove blank lines and unneeded includes.
>
> Signed-off-by: Sasha Neftin
> Tested-by: Aaron Brown
> Signed-off-by: Jeff Kirsher
>
On Tue, 2018-10-30 at 09:21 +0800, tanhuazhong wrote:
>
> On 2018/10/30 1:44, Joe Perches wrote:
> > On Mon, 2018-10-29 at 21:54 +0800, Huazhong Tan wrote:
> > > When hns3_nic_init_vector_data() fails to map ring to vector,
> > > it should cancel the netif_napi_ad
On Mon, 2018-10-29 at 21:54 +0800, Huazhong Tan wrote:
> When hns3_nic_init_vector_data() fails to map ring to vector,
> it should cancel the netif_napi_add() that has been successfully
> done and then exits.
[]
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> b/drivers/net/etherne
On Tue, 2018-10-23 at 16:28 +0800, zhong jiang wrote:
> radiob_array_table' and 'radiob_arraylen' are not used after setting its
> value.
> It is safe to remove the unused variable. Meanwhile, radio B radio should be
> removed as well. because it will no longer be referenced.
The patch subject is
On Sat, 2018-10-06 at 11:36 +0530, sunil.kovv...@gmail.com wrote:
> Added maintainers entry for Marvell OcteonTX2 SOC's RVU
> admin function driver.
[]
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -8844,6 +8844,15 @@ S: Supported
> F: drivers/mmc/host/sdhci-xenon*
> F: Documentation/d
On Mon, 2018-08-27 at 12:16 -0400, rpj...@crashcourse.ca wrote:
> Quoting David Miller :
>
> > From: "Robert P. J. Day"
> > Date: Mon, 27 Aug 2018 04:55:29 -0400 (EDT)
> >
> > > another pedantic oddity -- is there a reason for these two double
> > > negations in net/core/net-sysfs.c?
> >
> >
On Fri, 2018-08-24 at 11:47 -0700, Jeff Kirsher wrote:
> From: YueHaibing
>
> Use dma_zalloc_coherent instead of dma_alloc_coherent
> followed by memset 0.
Unrelated trivia: above this, perhaps the
size = sizeof(struct ixgb_buffer) * txdr->count;
txdr->buffer_info = vzalloc(siz
On Sun, 2018-08-05 at 08:52 -0700, Linus Torvalds wrote:
> "long unsigned int" isn't _technically_ wrong. But we normally
> call that type "unsigned long".
So add a checkpatch test for it.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 20 +
On Wed, 2018-07-25 at 15:12 +0200, Arnd Bergmann wrote:
> tools/perf/tests/.gitignore:
> LLVM byte-codes, uncompressed
> On Wed, Jul 25, 2018 at 2:55 AM, Andrew Morton
> wrote:
> > On Tue, 24 Jul 2018 17:13:20 -0700 Joe Perches wrote:
> >
>
On Tue, 2018-06-26 at 09:16 +0800, Chengguang Xu wrote:
> sizeof() will return unsigned value so in the error check
> negative error code will be always larger than sizeof().
[]
> diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c
> b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_
On Mon, 2018-06-18 at 16:49 +0930, Joel Stanley wrote:
> This moves all of the netdev_printk(KERN_DEBUG, ...) messages over to
> netdev_dbg. There is no change in behaviour.
Not quite, but I think the patch is fine anyway.
netdev_printk(KERN_DEBUG ... is always emitted as
long as the console leve
On Mon, 2018-06-18 at 16:49 +0930, Joel Stanley wrote:
> In normal operation we see this series of messages as the host drives
> the network device:
>
> ftgmac100 1e66.ethernet eth0: NCSI: LSC AEN - channel 0 state down
> ftgmac100 1e66.ethernet eth0: NCSI: suspending channel 0
[...]
> T
Remove and coalesce formats when there is an unnecessary
character after a logging newline. These extra characters
cause logging defects.
Miscellanea:
o Coalesce formats
Signed-off-by: Joe Perches
---
drivers/net/ethernet/cavium/liquidio/lio_main.c | 2 +-
drivers/net/ethernet
need this line.
> >
> > Hm, looks like this would have to be changed in a lot of places (~782
> > according to `git grep 'default n$'|wc -l` in my slightly outdated linux-
> > next). Do you want to fix it everywhere?
>
> No, but we can at least not add th
On Thu, 2018-05-24 at 13:54 -0500, Gustavo A. R. Silva wrote:
> Remove and refactor some code in order to avoid having identical code
> for different branches.
True and nice tool and patch submittal thanks.
> Notice that the logic has been there since 2014.
But perhaps the original logic is a de
On Thu, 2018-05-24 at 14:03 +0200, Simon Wunderlich wrote:
> From: Marek Lindner
>
> Signed-off-by: Marek Lindner
> Acked-by: Antonio Quartulli
> Signed-off-by: Sven Eckelmann
> Signed-off-by: Simon Wunderlich
> ---
> net/batman-adv/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletio
On Wed, 2018-05-23 at 10:46 -0700, Martin KaFai Lau wrote:
> Sparse warning:
> kernel/bpf/btf.c:1985:34: warning: Variable length array is used.
Perhaps use ARRAY_SIZE directly instead of indirectly via a #define
> diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
[]
> @@ -1970,6 +1970,8 @@ static
On Fri, 2018-05-18 at 09:52 +0200, Alexandre Belloni wrote:
> On 17/05/2018 18:13:25-0700, Joe Perches wrote:
> > On Thu, 2018-05-17 at 21:39 +0200, Alexandre Belloni wrote:
> > > On 17/05/2018 12:28:59-0700, Joe Perches wrote:
> > > > On Thu, 2018-05-17 at 21:23
201 - 300 of 1156 matches
Mail list logo
