On Fri, 2015-08-28 at 13:55 -0700, Eric Dumazet wrote:
On Fri, 2015-08-28 at 13:53 -0700, Joe Perches wrote:
On Fri, 2015-08-28 at 13:33 -0700, Eric Dumazet wrote:
We do not bother for small struct.
Here, the array is big enough that David prefers having an explicit
memset() so
On Fri, 2015-08-28 at 14:14 -0700, Eric Dumazet wrote:
On Fri, 2015-08-28 at 14:09 -0700, Joe Perches wrote:
On Fri, 2015-08-28 at 13:55 -0700, Eric Dumazet wrote:
On Fri, 2015-08-28 at 13:53 -0700, Joe Perches wrote:
It's 288 bytes on stack, maybe a kzalloc would be clearer too
On Fri, 2015-08-28 at 11:24 -0700, David Miller wrote:
From: Raghavendra K T raghavendra...@linux.vnet.ibm.com
Date: Fri, 28 Aug 2015 12:09:52 +0530
On 08/28/2015 12:08 AM, David Miller wrote:
From: Raghavendra K T raghavendra...@linux.vnet.ibm.com
Date: Wed, 26 Aug 2015 23:07:33 +0530
On Fri, 2015-08-28 at 14:28 -0500, cls...@linux.vnet.ibm.com wrote:
From: Carol L Soto cls...@linux.vnet.ibm.com
Seeing this message with mlx4_eni with IPv6: hw csum failure
Changing IPv6 csum calculation to be based on OFED 2.4 code.
When calculate IPv6 csum based also on source and
On Fri, 2015-08-28 at 17:06 -0700, Eric Dumazet wrote:
On Fri, 2015-08-28 at 16:12 -0700, Joe Perches wrote:
Generally true. It's always difficult to know how much
stack has been consumed though and smaller stack frames
are generally better.
[]
So for a _leaf_ function, it is better
On Thu, 2015-08-27 at 17:59 +0200, Jiri Pirko wrote:
When transmit fails, it is an error, not a warning.
[]
diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c
b/drivers/net/ethernet/mellanox/mlxsw/core.c
[]
@@ -376,8 +376,8 @@ static int __mlxsw_emad_transmit(struct mlxsw_core
No pr_dbg method exists.
While this code is #if 0'd, it'd be nicer to
use the generic hex_dump, so use it instead.
Signed-off-by: Joe Perches j...@perches.com
---
Or maybe just delete the driver altogether.
It'd probably be nice to one day create something
like drivers/net/ethernet/obsolete
No pr_dbg method exists.
While this code is #if 0'd, it'd be nicer to
use the generic hex_dump, so use it instead.
Signed-off-by: Joe Perches j...@perches.com
---
snorts no print_hex_dump_dbg method exists either.
V2: Change the uncompilable print_hex_dump_dbg call to
print_hex_dump_debug
On Wed, 2015-08-26 at 15:49 -0700, Jeff Kirsher wrote:
diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
[]
@@ -2106,11 +2106,12 @@ int i40e_ndo_set_vf_port_vlan(struct net_device
*netdev,
[]
On Thu, 2015-08-13 at 16:12 +0300, Igor Plyatov wrote:
* Due to HW bug, LAN8700 sometimes does not detect presence of energy in the
Ethernet cable in Energy Detect Power-Down mode (e.g while EDPWRDOWN bit is
set, the ENERGYON bit does not asserted sometimes). This is a common bug of
On Thu, 2015-08-13 at 20:11 +0300, Igor Plyatov wrote:
On Thu, 2015-08-13 at 16:12 +0300, Igor Plyatov wrote:
* Due to HW bug, LAN8700 sometimes does not detect presence of energy in
the
Ethernet cable in Energy Detect Power-Down mode (e.g while EDPWRDOWN
bit is
set, the
On Tue, 2015-08-11 at 00:14 +0800, yalin wang wrote:
HWM_REVERSE
Is unused and it would be better if removed.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Tue, 2015-08-04 at 17:07 +0200, Jason A. Donenfeld wrote:
The pr_debug family of functions turns into a no-op when -DDEBUG is not
specified, opting instead to call no_printk, which gets compiled to a
no-op (but retains gcc's nice warnings about printf-style arguments).
[]
diff --git
On Mon, 2015-08-03 at 16:05 -0700, David Miller wrote:
From: Joe Perches j...@perches.com
Date: Sun, 02 Aug 2015 21:27:45 -0700
Use macros that don't require fixed argument counts so
format and arguments can be verified by the compiler.
Miscellanea:
o Remove a few #if uses
On Tue, 2015-08-04 at 05:26 +0200, Jason A. Donenfeld wrote:
The pr_debug family of functions turns into a no-op when -DDEBUG is not
specified, opting instead to call no_printk, which gets compiled to a
no-op (but retains gcc's nice warnings about printf-style arguments).
The problem with
On Mon, 2015-08-03 at 20:57 -0700, Joe Perches wrote:
On Tue, 2015-08-04 at 05:26 +0200, Jason A. Donenfeld wrote:
This patch replaces calls to net_dbg_ratelimited when !DEBUG with
no_printk, keeping with the idiom of all the other debug print helpers.
Makes sense, thanks Jason.
Perhaps
Use macros that don't require fixed argument counts so
format and arguments can be verified by the compiler.
Miscellanea:
o Remove a few #if uses to allow dynamic debug to always work
o whitespace neatening
Signed-off-by: Joe Perches j...@perches.com
---
drivers/net/fddi/skfp/cfm.c| 16
Use vsprintf extension %pI4 instead.
Signed-off-by: Joe Perches j...@perches.com
---
net/atm/br2684.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/net/atm/br2684.c b/net/atm/br2684.c
index cc78538..aa0047c 100644
--- a/net/atm/br2684.c
+++ b/net/atm/br2684.c
On Thu, 2015-07-30 at 13:28 +0200, Petr Mladek wrote:
The commit #6fe29354befe4c (printk: implement support for extended console
drivers) added an extra buffer to format messages for extended consoles.
We need to put there also the warning about dropped messages, so it appears
on these
On Thu, 2015-07-30 at 15:30 +0200, Michael Grzeschik wrote:
Add entry for arcnet to MAINTAINERS file and add myself as the
maintainer of the subsystem.
[]
As I have a test coverage of com20020 based arcnet systems
I would like to take the responsibility of maintaining the subsystem.
Best of
On Wed, 2015-07-22 at 19:16 +0300, Madalin Bucur wrote:
Allow the user to tweak the refill threshold and the total number
of buffers in the buffer pool. The provided values are for one CPU.
Any value in making these module parameters instead?
+config FSL_DPAA_ETH_MAX_BUF_COUNT
+ int
On Wed, 2015-07-22 at 19:16 +0300, Madalin Bucur wrote:
This introduces the Freescale Data Path Acceleration Architecture
(DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan,
BMan, PAMU and FMan drivers to deliver Ethernet connectivity on
the Freescale DPAA QorIQ platforms.
On Sun, 2015-07-19 at 11:38 -0700, David Miller wrote:
From: Sowmini Varadhan sowmini.varad...@oracle.com
Date: Sun, 19 Jul 2015 14:01:34 +0200
On 07/18/2015 08:06 PM, Joe Perches wrote:
It seems that this code has had unaligned accesses
on this field even before compare_ether_addr
On Fri, 2015-07-17 at 18:18 -0700, David Miller wrote:
From: Joe Perches j...@perches.com Date: Fri, 17 Jul 2015 16:07:02 -0700
On Fri, 2015-07-17 at 22:00 +0200, Sowmini Varadhan wrote:
__vxlan_find_mac invokes ether_addr_equal on the eth_addr field,
which triggers unaligned access
On Fri, 2015-07-17 at 15:44 +0200, Hagen Paul Pfeifer wrote:
On July 16, 2015 at 9:23 PM Joe Perches j...@perches.com wrote:
It might be useful to have these performance impacting
changes guarded by something like CONFIG_CC_OPTIMIZE_FOR_SIZE
with another static __always_inline __func
On Fri, 2015-07-17 at 22:00 +0200, Sowmini Varadhan wrote:
__vxlan_find_mac invokes ether_addr_equal on the eth_addr field,
which triggers unaligned access messages, so rearrange vxlan_fdb
to avoid this in the most non-intrusive way.
What arch does this?
--
To unsubscribe from this list:
On Thu, 2015-07-16 at 11:17 -0700, David Miller wrote:
From: Tom Herbert t...@herbertland.com
Date: Thu, 16 Jul 2015 08:43:25 -0700
On Thu, Jul 16, 2015 at 5:40 AM, Denys Vlasenko dvlas...@redhat.com wrote:
This patch deinlines jhash, jhash2 and __jhash_nwords.
It also removes
On Fri, 2015-07-03 at 07:51 -0400, Neil Horman wrote:
On Thu, Jul 02, 2015 at 02:54:56PM -0700, Joe Perches wrote:
It's not clear to me that the sctp_fwdtsn_skip array is
always initialized when used.
It is appropriate to initialize the array to 0?
This patch initializes the array
It's not clear to me that the sctp_fwdtsn_skip array is
always initialized when used.
It is appropriate to initialize the array to 0?
This patch initializes the array too 0 and moves the
local variables into the blocks where used.
It also does some miscellaneous neatening by using
continue; and
On Wed, 2015-07-01 at 12:56 +0200, Eric Dumazet wrote:
On Tue, 2015-06-30 at 20:25 +0300, Nicolae Rosia wrote:
diff --git a/drivers/net/ethernet/cadence/macb.c
b/drivers/net/ethernet/cadence/macb.c
[]
@@ -2554,9 +2554,9 @@ static void at91ether_rx(struct net_device *dev)
while
On Thu, 2015-07-02 at 00:13 +0200, Eric Dumazet wrote:
On Wed, 2015-07-01 at 10:06 -0700, Joe Perches wrote:
On Wed, 2015-07-01 at 12:56 +0200, Eric Dumazet wrote:
On Tue, 2015-06-30 at 20:25 +0300, Nicolae Rosia wrote:
diff --git a/drivers/net/ethernet/cadence/macb.c
b/drivers/net
On Tue, 2015-06-30 at 20:16 +, Fujinaka, Todd wrote:
Sorry for the top-posting, but I'm provided with the tools they give me
and bottom posting from Outlook just confuses email threads. Plus, this
was crossposted all over creation and cc-ed to anyone with an intel
address.
Not quite. It
On Tue, 2015-06-30 at 22:25 +, Fujinaka, Todd wrote:
I've submitted a version to intel-wired-lan that addresses the original
issue as well as Joe Perches's suggestion to just delete the define.
Please cc netdev next time too.
--
To unsubscribe from this list: send the line unsubscribe
On Thu, 2015-06-25 at 12:24 -0400, Paul Gortmaker wrote:
On Wed, Jun 24, 2015 at 7:38 PM, Linus Torvalds
torva...@linux-foundation.org wrote:
I'm getting *real* tired of that BUG_ON() shit.
[]
Killing the machine for idiotic things like that is truly offensive,
and truly horrible horrible
On Wed, 2015-06-24 at 11:55 +0900, Taku Izumi wrote:
This patch adds the basic code of FUJITSU Extended Socket
Network Device driver.
trivial notes:
diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
[]
+static int fjes_acpi_add(struct acpi_device *device)
+{
[]
+
On Thu, 2015-06-18 at 09:49 +0900, Taku Izumi wrote:
This patch adds update_zone_task.
diff --git a/drivers/platform/x86/fjes/fjes_hw.c
b/drivers/platform/x86/fjes/fjes_hw.c
[]
+static void fjes_hw_update_zone_task(struct work_struct *work)
+{
Some of the line length can be removed here by
On Thu, 2015-06-18 at 09:49 +0900, Taku Izumi wrote:
This patch adds the basic code of FUJITSU Extended Socket
Network Device driver.
[]
diff --git a/drivers/platform/x86/fjes/fjes_main.c
b/drivers/platform/x86/fjes/fjes_main.c
[]
+static acpi_status fjes_get_acpi_resource(struct
On Thu, 2015-06-18 at 09:49 +0900, Taku Izumi wrote:
This patch adds hardware initialization routine to be
invoked at driver's .probe routine.
Trivial notes:
Please run all your patches through scripts/checkpatch.pl and
fix whatever messages it emits as you think appropriate.
diff --git
On Tue, 2015-06-16 at 23:07 +0300, Sergei Shtylyov wrote:
On 06/16/2015 10:10 PM, Julien Grall wrote:
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.
[]
@@ -874,7 +874,7 @@ static inline void xenvif_grant_handle_set(struct
xenvif_queue
On Wed, 2015-06-17 at 01:29 +0300, Sergei Shtylyov wrote:
Hello.
On 06/17/2015 01:09 AM, Joe Perches wrote:
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.
[]
@@ -874,7 +874,7 @@ static inline void xenvif_grant_handle_set(struct
On Thu, 2015-06-11 at 11:43 +0200, Ivan Vecera wrote:
On 06/10/2015 10:29 PM, Joe Perches wrote:
On Wed, 2015-06-10 at 18:43 +0200, Ivan Vecera wrote:
Signed-off-by: Ivan Vecera ivec...@redhat.com
There should be some indication a few messages have
been deleted in the commit log
On Wed, 2015-06-10 at 18:43 +0200, Ivan Vecera wrote:
Signed-off-by: Ivan Vecera ivec...@redhat.com
Have you verified that all of these are __aligned(2)?
I haven't, but you should verify that you have in the
commit log.
btw: this use looks odd to me:
static int
bnad_set_mac_address(struct
On Wed, 2015-06-10 at 18:33 +0200, Fabian Frederick wrote:
Use kernel.h macro definition.
Thanks to Julia Lawall for Coccinelle scripting support.
[]
diff --git a/drivers/net/wireless/ath/ath5k/phy.c
b/drivers/net/wireless/ath/ath5k/phy.c
[]
@@ -1566,17 +1566,13 @@ static s16
On Wed, 2015-06-10 at 18:43 +0200, Ivan Vecera wrote:
Signed-off-by: Ivan Vecera ivec...@redhat.com
There should be some indication a few messages have
been deleted in the commit log and a reason why too.
diff --git a/drivers/net/ethernet/brocade/bna/bnad.c
On Fri, 2015-06-05 at 13:34 +0100, Julien Grall wrote:
On 04/06/15 17:25, Joe Perches wrote:
On Thu, 2015-06-04 at 13:52 +0100, Julien Grall wrote:
On 04/06/15 13:46, David Vrabel wrote:
On 04/06/15 13:45, Julien Grall wrote:
On 03/06/15 18:06, Joe Perches wrote:
On Wed, 2015-06-03
On Thu, 2015-06-04 at 13:52 +0100, Julien Grall wrote:
On 04/06/15 13:46, David Vrabel wrote:
On 04/06/15 13:45, Julien Grall wrote:
On 03/06/15 18:06, Joe Perches wrote:
On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote:
rx-status is an int16_t, print it using %d rather than %u
On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote:
rx-status is an int16_t, print it using %d rather than %u in order to
have a meaningful value when the field is negative.
[]
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
[]
@@ -733,7 +733,7 @@ static int
On Wed, 2015-06-03 at 15:40 +0200, Antonio Murdaca wrote:
Did I make some mistakes with this patch? Seeking help|info since this is
one my very first contribution to the kernel..
Please be patient and wait for the review process
to take place.
It can take weeks before you get a reply.
--
To
On Tue, 2015-06-02 at 13:59 +0530, Hariprasad Shenai wrote:
Adds NIC driver related changes for T6 adapter. Register related
changes, MC related changes, VF related changes, doorbell related
changes, debugfs changes, etc
trivial notes:
diff --git
Several of these goto exit; uses should be direct returns
as skb is not yet initialized by nci_hci_get_param().
Miscellanea:
o Use !memcmp instead of memcmp() == 0
o Remove unnecessary goto from if () {... goto exit;} else {...} exit:
Signed-off-by: Joe Perches j...@perches.com
---
net/nfc/nci
On Thu, 2015-05-28 at 11:42 -0700, David Miller wrote:
I've applied the following to net-next, thanks for your report.
[PATCH] treewide: Add missing vmalloc.h inclusion.
All of these files were only building on non-x86 because of
the indirect of inclusion of vmalloc.h
On Wed, 2015-05-27 at 21:14 -0400, Nicholas Krause wrote:
This makes the function,process_ipsec have a return true
of bool now due to only returning 1 or 0. In additon this
changes this function's return statements to return true
and false rather then 1 and 0 respectfully.
The patch subject
On Thu, 2015-05-28 at 00:00 -0400, Nicholas Krause wrote:
This converts the function, process_ipsec to the
return type of bool due to only returning either
one or zero.
v2
Change incorrect patch subject and make commit message
clearer
Signed-off-by: Nicholas Krause xerofo...@gmail.com
On Tue, 2015-05-26 at 07:14 -0700, Greg KH wrote:
On Mon, May 25, 2015 at 10:07:59PM -0700, Joe Perches wrote:
As far as I understand, the Eudyptula Challenge list has
internal mechanisms to nominally review patches before some
patch is submitted to lkml.
No it does not.
That's
On Tue, 2015-05-26 at 09:35 -0700, Greg KH wrote:
On Tue, May 26, 2015 at 07:48:59AM -0700, Joe Perches wrote:
The main point is that patches shouldn't be applied without
being submitted to a more widely read list.
I take the blame for any problems with Outreachy patches
On Mon, 2015-05-25 at 12:17 +0300, Dan Carpenter wrote:
These are special intern patches that
dont' go through the normal review process. The intern process is over
this year. The lack of normal review introduced a number of bugs this
year. I always complain to Greg about it and he says
On Mon, 2015-05-25 at 23:25 +0530, Shailendra Verma wrote:
The variable translate is bool type.So assigning true instead of 1.
There are a lot these in the kernel.
$ git grep -P ^[ \t]*(?:static[ \t]+)?(?:const\s+)?bool\s+\w+\s*=\s*[01]\s*;
* | wc -l
161
Are you going to submit patches for
On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote:
On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote:
It'd be better if the approved patches from the intern list
(no idea what that is) were sent to lkml/devel@driverdev lists
for review before actually being applied.
Its
On Tue, 2015-05-26 at 10:32 +0530, Sudip Mukherjee wrote:
On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote:
On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote:
On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote:
It'd be better if the approved patches from
These two uses seem to have had carriage returns removed.
Make these entries like all the others in this file.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/net/ethernet/neterion/s2io.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet
On Thu, 2015-05-14 at 11:01 +0300, Dan Carpenter wrote:
On Wed, May 13, 2015 at 10:34:51AM -0700, Joe Perches wrote:
In case the patches you found weren't of this type,
there are other possibly suspicious uses with like:
drivers/usb/host/ehci-tegra.c: set_bit((wIndex 0xff
On Tue, 2015-05-12 at 14:22 -0500, Tom Lendacky wrote:
Add support for the network interface message level settings for
determining whether to issue some of the driver messages.
[]
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-dcb.c
b/drivers/net/ethernet/amd/xgbe/xgbe-dcb.c
[]
@@ -150,9
On Tue, 2015-05-05 at 19:20 -0400, David Miller wrote:
From: Joe Perches j...@perches.com Date: Mon, 04 May 2015 13:32:30 -0700
On Mon, 2015-05-04 at 13:05 -0700, Joe Perches wrote:
unsigned char * return values are sometimes awkward to work with.
Changing the return to void * is sometimes
--fix option to eth_zero/broadcast_addr checks
- All new warnings are multi-line aware (fixes work on single lines only)
Acked-by: Joe Perches j...@perches.com
Thanks Mateusz
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
On Sat, 2015-04-25 at 19:54 +0300, Sergei Shtylyov wrote:
Parens around the *return* expression are not necessary. :-)
Yeah, what Sergei said...
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Sat, 2015-04-25 at 10:26 +0100, Ian Morris wrote:
Try to improve coding readability by adding spaces in line layouts. No
changes to functionality. No changes according to objdiff.
trivia:
diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c
[]
@@ -44,13 +44,13 @@
On Sat, 2015-04-25 at 10:26 +0100, Ian Morris wrote:
Remove braces from a few if statements where not required.
trivia:
diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c
[]
@@ -151,9 +151,8 @@ ip6_packet_match(const struct sk_buff *skb,
On Sat, 2015-04-25 at 10:27 +0100, Ian Morris wrote:
Remove else branch of if statements where a return is always done
when the condition is true.
trivia:
diff --git a/net/ipv6/netfilter/ip6t_hbh.c b/net/ipv6/netfilter/ip6t_hbh.c
[]
@@ -95,70 +95,67 @@ hbh_mt6(const struct sk_buff *skb,
On Fri, 2015-04-24 at 22:52 +, Simon Xiao wrote:
From: Joe Perches [mailto:j...@perches.com]
On Fri, 2015-04-24 at 11:34 -0700, six...@microsoft.com wrote:
From: Simon Xiao six...@microsoft.com
1. Introduce netif-msg to netvsc to control debug logging output and
keep msg_enable
On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote:
The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK
and ADIAGSTATUS are unnecessary indirections to the use of registers.
This patch removes them and improves the readability of the code.
This breaks compilation.
On Fri, 2015-04-24 at 23:58 -0400, David Miller wrote:
From: Marc Kleine-Budde m...@pengutronix.de
Date: Fri, 24 Apr 2015 23:14:41 +0200
On 04/24/2015 08:47 PM, Joe Perches wrote:
On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote:
This patch series tries to reanimate the ARCNET
On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote:
Hi!
Hello.
This patch series tries to reanimate the ARCNET hardware layer to be
somehow readable and maintainable again. It includes a lot of cleanup
patches. It also adds some fixes which leads the layer to become usable
again.
On Fri, 2015-04-24 at 11:34 -0700, six...@microsoft.com wrote:
From: Simon Xiao six...@microsoft.com
1. Introduce netif-msg to netvsc to control debug logging output
and keep msg_enable in netvsc_device_context so that it is
kept persistently.
2. Only call dump_rndis_message() when
On Thu, 2015-04-23 at 16:54 -0700, Joe Perches wrote:
On Thu, 2015-04-23 at 21:53 +0200, Mateusz Kulikowski wrote:
I noticed funny behavior about $stat matches -
it reports the same error several times (including as scope whole file)
Is it feature or feature or I missed something?
You
On Thu, 2015-04-23 at 21:53 +0200, Mateusz Kulikowski wrote:
On 22.04.2015 00:27, Joe Perches wrote:
On Tue, 2015-04-21 at 23:44 +0200, Mateusz Kulikowski wrote:
On 21.04.2015 23:22, Joe Perches wrote:
On Tue, 2015-04-21 at 22:57 +0200, Mateusz Kulikowski wrote:
(...)
(...)
True, True
On Wed, 2015-04-22 at 14:56 +0200, Ivan Vecera wrote:
The driver unlike other drivers does not log link state changes.
[]
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/drivers/net/ethernet/emulex/benet/be_main.c
[]
@@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapter
On Wed, 2015-04-22 at 15:43 +0200, Ivan Vecera wrote:
The driver unlike other drivers does not log link state changes.
Why add all the speed stuff, why not add a query instead?
I think it'd be simpler to add a line like:
status = be_cmd_link_status_query(adapter, speed, status, 0);
On Tue, 2015-04-21 at 23:44 +0200, Mateusz Kulikowski wrote:
On 21.04.2015 23:22, Joe Perches wrote:
On Tue, 2015-04-21 at 22:57 +0200, Mateusz Kulikowski wrote:
(...)
Perhaps it would be smarter to use (for both patches) $stat instead.
This applies also to existing checks (like
On Tue, 2015-04-21 at 22:57 +0200, Mateusz Kulikowski wrote:
Hi Joe,
On 20.04.2015 03:13, Joe Perches wrote:
On Mon, 2015-04-20 at 00:16 +0200, Mateusz Kulikowski wrote:
Suggest using eth_zero_addr() or eth_broadcast_addr() instead of memset().
Hi again Mateusz
diff --git
On Sun, 2015-04-19 at 21:04 +0200, Mateusz Kulikowski wrote:
Check if memcmp() is used to compare ethernet addresses and suggest using
ether_addr_equal() or ether_addr_equal_unaligned()
Hi again Mateusz.
This is OK with me.
If you ever submit that ether_addr_copy_unaligned patch,
please
On Sun, 2015-04-19 at 21:04 +0200, Mateusz Kulikowski wrote:
Suggest using eth_zero_addr() or eth_broadcast_addr() if memset is used
instead.
Hi Mateusz, this is OK but here are some notes:
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
@@ -5042,6 +5042,22 @@ sub process {
[]
On Mon, 2015-04-20 at 00:16 +0200, Mateusz Kulikowski wrote:
Suggest using eth_zero_addr() or eth_broadcast_addr() instead of memset().
Hi again Mateusz
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
@@ -5042,6 +5042,22 @@ sub process {
Prefer
On Wed, 2015-04-15 at 21:54 +, Hubbe, Allen wrote:
I ran with the --fix option, and it changed every rejected indent to
match the column of the open paren. That's probably what you want,
since it's the most consistent with the previous behavior. The
difference is that it does not fix
On Wed, 2015-04-15 at 20:34 +, Hubbe, Allen wrote:
Hello Andy, Joe,
Hello Allen.
As this is a discussion better suited for linux
development lists I've cc'd LKML and netdev.
I would like to find the origin of the decision to align to the open
paren in Linux.
Mostly it's a style decision
On Mon, 2008-02-25 at 10:53 +0100, Johannes Berg wrote:
Maybe we should just add a new printf modifier like %M for MAC
addresses? Then we could use sprintf, snprintf, printk and whatever we
please without any of the macro stuff...
Could gcc validate the printf %M arguments?
Another
On Mon, 2008-02-25 at 12:47 +0100, Patrick McHardy wrote:
It would be good if Joe could go through the remaining print_mac users
and convert the remaining unintended function calls in fastpaths back
to MAC_FMT. Grepping for start_xmit in commit 0795af5729b shows that
at least 10
On Mon, 2008-02-25 at 09:47 -0600, Hawkes Steve-FSH016 wrote:
How about this?
line wrapped, but seems better.
Signed-off-by: Steve Hawkes [EMAIL PROTECTED]
diff -uprN linux-2.6.24/include/linux/kernel.h
linux-2.6.24-printk_ratelimit/include/linux/kernel.h
---
.
There are many other debug printk wrappers
#ifdef DEBUG
#define printk_wrapper
#else
#define printk_wrapper printk
#endif
that should be converted as well.
Signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/include/linux/device.h b/include/linux/device.h
index
to print_mac by using
struct print_mac_buf * instead of char *.
Signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/include/linux/if_ether.h b/include/linux/if_ether.h
index 42dc6a3..2f8df76 100644
--- a/include/linux/if_ether.h
+++ b/include/linux/if_ether.h
@@ -129,9 +129,16 @@ extern
On Wed, 2008-02-20 at 17:02 +0300, Pavel Emelyanov wrote:
There are tree places, which declare the char buf[...] on the stack
to push it later into dprintk(). Since the dprintk sometimes (if the
CONFIG_SYSCTL=n) becomes an empty do { } while (0) stub, these buffers
cause gcc to produce
On Wed, 2008-02-20 at 07:29 -0800, Joe Perches wrote:
fs/nfsd/nfsproc.c: char buf[RPC_MAX_ADDRBUFLEN];
Perhaps there should be a DECLARE_RPC_BUF(buf) macro?
#define DECLARE_RPC_BUF(var) char var[MAC_BUF_SIZE] __maybe_unused
Make that:
#define DECLARE_RPC_BUF(var) char var
Sigh... Why is that better than a strait declaration with attribute?
If at some point there's a gcc'ism to remove a maybe_unused
variable from the stack declaration, you only have change
the macro.
cheers, Joe
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a
On Wed, 2008-02-20 at 16:35 +0100, Patrick McHardy wrote:
Alternatively change the dprintk macro to behave similar like
pr_debug() and mark things like svc_print_addr() __pure, which
has the advantage that is still performs format checking even
if debugging is disabled.
I think it's better to
On Wed, 2008-02-20 at 12:02 -0500, Trond Myklebust wrote:
#ifdef DEBUG
#define some_print_wrapper(fmt, arg...) \
do { if (0) printk(KERN_DEBUG fmt, ##arg); } while (0)
#else
#define some_print_wrapper(fmt, arg...) \
printk(KERN_DEBUG fmt, ##arg)
#endif
Have you actually
On Wed, 2008-02-20 at 12:37 +0100, Johannes Berg wrote:
There's no need to have two variables called 'i' when one
suffices.
Additional minor cleanups: tabs and style
Signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/drivers/net/sungem.c b/drivers/net/sungem.c
index 9721279..8d52d20
Make sungem.c checkpatch error clean
gem_rx: reuse dma_addr temporary
gem_clean_rings: remove an indentation level
80 columns (not function definitions)
Remove spaces before tabs
__inline__ to inline
labels in column 1
printk cleanup
begnign/benign typo
Signed-off-by: Joe Perches
diff --git
On Wed, 2008-02-20 at 22:32 -0800, David Miller wrote:
+ if (lost) {
+ printk(KERN_WARNING
+ printk: %d %s%smessage%s suppressed.\n,
+ lost,
+ (state-facility == 0 ? :
On Mon, 2008-02-18 at 16:19 +0100, Patrick McHardy wrote:
@@ -404,11 +405,8 @@ static int vlan_dev_hard_start_xmit(struct sk_buff
*skb, struct net_device *dev)
pr_debug(%s: about to send skb: %p to dev: %s\n,
__FUNCTION__, skb, skb-dev-name);
- pr_debug( MAC_FMT
On Mon, 2008-02-18 at 16:50 -0800, David Miller wrote:
Actually it seems the 'pure' attribute is more important
here. Although it's not semantically a perfect match,
what we need to tell the compiler is basically that:
1) the return value depends upon the inputs
2) if the input is not
MAC_FMT is no longer used
Signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/include/linux/if_ether.h b/include/linux/if_ether.h
index e157c13..7a1e011 100644
--- a/include/linux/if_ether.h
+++ b/include/linux/if_ether.h
@@ -130,7 +130,6 @@ extern ssize_t sysfs_format_mac(char *buf, const
601 - 700 of 864 matches
Mail list logo
