Re: [PATCH v19 06/23] LSM: Use lsmblob in security_secctx_to_secid

2020-07-28 Thread John Johansen
On 7/28/20 4:41 PM, Casey Schaufler wrote: > On 7/28/2020 4:11 AM, John Johansen wrote: >> On 7/24/20 1:32 PM, Casey Schaufler wrote: >>> Change security_secctx_to_secid() to fill in a lsmblob instead >>> of a u32 secid. Multiple LSMs may be able to interpret the >

Re: [PATCH v19 15/23] LSM: Use lsmcontext in security_secid_to_secctx

2020-07-28 Thread John Johansen
On 7/24/20 1:32 PM, Casey Schaufler wrote: > Replace the (secctx,seclen) pointer pair with a single > lsmcontext pointer to allow return of the LSM identifier > along with the context and context length. This allows > security_release_secctx() to know how to release the > context. Callers have been

Re: [PATCH v19 06/23] LSM: Use lsmblob in security_secctx_to_secid

2020-07-28 Thread John Johansen
t() to use a > lsmblob instead of a u32 secid. In some other cases there is > scaffolding where interfaces have yet to be converted. > > Reviewed-by: Kees Cook > Signed-off-by: Casey Schaufler > Cc: netdev@vger.kernel.org one comment below, but its a nice to have so Reviewed-by: Joh

Re: [PATCH v18 05/23] net: Prepare UDS for security module stacking

2020-07-09 Thread John Johansen
On 7/9/20 9:11 AM, Stephen Smalley wrote: > On Wed, Jul 8, 2020 at 8:23 PM Casey Schaufler wrote: >> >> Change the data used in UDS SO_PEERSEC processing from a >> secid to a more general struct lsmblob. Update the >> security_socket_getpeersec_dgram() interface to use the >> lsmblob. There is a s

Re: bpf: Massive skbuff_head_cache memory leak?

2018-09-26 Thread John Johansen
On 09/26/2018 02:22 PM, Daniel Borkmann wrote: > On 09/26/2018 11:09 PM, Tetsuo Handa wrote: >> Hello, Alexei and Daniel. >> >> Can you show us how to run testcases you are testing? > > Sorry for the delay; currently quite backlogged but will definitely take a > look > at these reports. Regarding

Re: [PATCH 10/12] apparmorfs: Replace CURRENT_TIME with current_time()

2017-06-02 Thread John Johansen
have no objections to it being merged for 4.12. If it isn't this change is already queued up for the apparmor 4.13 merge Acked-by: John Johansen > --- > security/apparmor/apparmorfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/apparmor