* @dnode: address of destination node
Acked-by: Jon Maloy
;lock#2);
lock(&tn->nametbl_lock);
lock(&n->lock#2);
lock(&tn->nametbl_lock);
*** DEADLOCK ***
Regards,
Hoang
Ok. So although your solution is not optimal, we know it is safe.
Again:
Acked-by: Jon Maloy
-Original Message-
F
On 10/8/20 1:25 PM, Jakub Kicinski wrote:
On Thu, 8 Oct 2020 14:31:56 +0700 Hoang Huu Le wrote:
diff --git a/net/tipc/name_distr.c b/net/tipc/name_distr.c
index 2f9c148f17e2..fe4edce459ad 100644
--- a/net/tipc/name_distr.c
+++ b/net/tipc/name_distr.c
@@ -327,8 +327,13 @@ static struct sk_buf
On 7/12/20 7:15 PM, Andrew Lunn wrote:
Simple fixes which require no deep knowledge of the code.
Cc: Jon Maloy
Cc: Ying Xue
Signed-off-by: Andrew Lunn
---
net/tipc/bearer.c| 2 +-
net/tipc/discover.c | 5 ++---
net/tipc/link.c | 6 +++---
net/tipc/msg.c | 2 +-
net
L);
- print_uint(PRINT_ANY, "ratio", " ratio:%u%\n",
+ print_uint(PRINT_ANY, "ratio", " ratio:%u\n",
mnl_attr_get_u32(props[prop_ratio]));
break;
default:
Acked-by: Jon Maloy
we add another 'is_not_legacy' bit
to all new messages so that those can be distinguished from legacy
messages and the latter delivered directly.
Signed-off-by: Hoang Huu Le
Acked-by: Jon Maloy
---
net/tipc/bcast.c | 6 +--
net/tipc/bcast.h | 4 +-
net/tipc/l
On 5/22/20 4:10 PM, Eric Dumazet wrote:
On 5/22/20 12:47 PM, Jon Maloy wrote:
On 5/22/20 11:57 AM, Eric Dumazet wrote:
On 5/22/20 8:01 AM, Jon Maloy wrote:
On 5/22/20 2:18 AM, Xin Long wrote:
On Fri, May 22, 2020 at 1:55 PM Eric Dumazet wrote:
Resend to the list in non HTML form
On
On 5/22/20 11:57 AM, Eric Dumazet wrote:
On 5/22/20 8:01 AM, Jon Maloy wrote:
On 5/22/20 2:18 AM, Xin Long wrote:
On Fri, May 22, 2020 at 1:55 PM Eric Dumazet wrote:
Resend to the list in non HTML form
On Thu, May 21, 2020 at 10:53 PM Eric Dumazet wrote:
On Thu, May 21, 2020 at 10
0033:0x45ca29
Fixes: e9c1a793210f ("tipc: add dst_cache support for udp media")
Cc: Xin Long
Cc: Jon Maloy
Signed-off-by: Eric Dumazet
Reported-by: syzbot
---
net/tipc/udp_media.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/net/tipc/udp_media.c b/net/t
Acked. Thanks Jiri.
///jon
> -Original Message-
> From: Jiri Pirko
> Sent: 8-Oct-19 07:02
> To: netdev@vger.kernel.org
> Cc: da...@davemloft.net; Jon Maloy ;
> ying@windriver.com; johannes.b...@intel.com; mkube...@suse.cz;
> ml...@mellanox.com
> Subject: [p
s
where we incorrectly access the spinlock on the send/error path.
This patch also reverts commit d12cffe9329f ("tipc: ensure head->lock
is initialised") which has now become redundant.
CC: Eric Dumazet
Reported-by: Chris Packham
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
> -Original Message-
> From: netdev-ow...@vger.kernel.org On
> Behalf Of Xin Long
> Sent: 15-Aug-19 01:58
> To: Jon Maloy
> Cc: da...@davemloft.net; netdev@vger.kernel.org; Tung Quang Nguyen
> ; Hoang Huu Le
> ; shu...@redhat.com; ying xue
> ; eduma...@
s
where we incorrectly access the spinlock on the send/error path.
This patch also reverts commit d12cffe9329f ("tipc: ensure head->lock
is initialised") which has now become redundant.
CC: Eric Dumazet
Reported-by: Chris Packham
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
ne
ther
down in tipc_sk_filter_rcv() as it should be.
Reported-by: Li Shuang
Signed-off-by: Jon Maloy
---
net/tipc/socket.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index dd8537f..83ae41d 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket
e risk of user starvation during link congestion")
Reported-by: Tung Nguyen
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
net/tipc/link.c | 29 +
1 file changed, 21 insertions(+), 8 deletions(-)
diff --git a/net/tipc/link.c b/net/tipc/link.c
index 2c27477..dd3155
t the packet is erroneously perceived as already validated by TIPC.
We fix this by initializing the said field to 'false' before performing
the initial validation.
Signed-off-by: Jon Maloy
---
net/tipc/node.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/tipc/node.c b/net/
The macro TIPC_BC_RETR_LIM is always used in combination with 'jiffies',
so we can just as well perform the addition in the macro itself. This
way, we get a few shorter code lines and one less line break.
Signed-off-by: Jon Maloy
---
net/tipc/link.c | 9 -
1 file changed, 4
We rename the inline function msg_get_wrapped() to the more
comprehensible msg_inner_hdr().
Signed-off-by: Jon Maloy
---
net/tipc/bcast.c | 4 ++--
net/tipc/link.c | 2 +-
net/tipc/msg.h | 4 ++--
net/tipc/node.c | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/net
We increase the allocated headroom for the buffer copies to be
retransmitted. This eliminates the need for the lower stack levels
(UDP/IP/L2) to expand the headroom in order to add their own headers.
Signed-off-by: Jon Maloy
---
net/tipc/link.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
e original, additional criteria of 99 failed retransmissions
is now redundant, and may in some cases lead to failure detection
times in the order of minutes instead of the expected 1.5 sec link
tolerance value.
We now remove this criteria altogether.
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
s and
> > send the clones to the loopback interface. The clones are dropped at
> > reception and have no functional role except making the traffic visible.
> >
> > The feature is turned on/off by enabling/disabling the loopback "bearer"
> > "eth:lo"
Acked-by: Jon Maloy
> -Original Message-
> From: netdev-ow...@vger.kernel.org On
> Behalf Of Xin Long
> Sent: 20-Jun-19 07:04
> To: network dev
> Cc: da...@davemloft.net; Jon Maloy ; Ying Xue
> ; tipc-discuss...@lists.sourceforge.net; Paolo
> Abeni
> Sub
Acked-by: Jon Maloy
> -Original Message-
> From: netdev-ow...@vger.kernel.org On
> Behalf Of Xin Long
> Sent: 20-Jun-19 06:39
> To: network dev
> Cc: da...@davemloft.net; Jon Maloy ; Ying Xue
> ; tipc-discuss...@lists.sourceforge.net
> Subject: [PATCH
Yet another duplicate of syzbot+a25307ad099309f1c...@syzkaller.appspotmail.com
A fix has been posted.
///jon
> -Original Message-
> From: netdev-ow...@vger.kernel.org
> On Behalf Of syzbot
> Sent: 23-Mar-19 19:03
> To: da...@davemloft.net; Jon Maloy ;
> kuz...@ms
From: Erik Hugne
Fix regression bug introduced in
commit 365ad353c256 ("tipc: reduce risk of user starvation during link
congestion")
Only signal -EDESTADDRREQ for RDM/DGRAM if we don't have a cached
sockaddr.
Signed-off-by: Erik Hugne
Signed-off-by: Jon Maloy
---
net/ti
Acked-by: Jon Maloy
Thank you, Cong.
///jon
> -Original Message-
> From: Cong Wang
> Sent: 17-Dec-18 02:25
> To: netdev@vger.kernel.org
> Cc: Cong Wang ; Ying Xue
> ; Jon Maloy
> Subject: [Patch net] tipc: check group dests after tipc_wait_for_cond()
&
> -Original Message-
> From: netdev-ow...@vger.kernel.org
> On Behalf Of Eric Dumazet
> Sent: 14-Dec-18 10:15
> To: Jon Maloy ; Cong Wang
> ; Dmitry Vyukov
> Cc: syzbot+c56449ed3652e6720...@syzkaller.appspotmail.com; Ying Xue
> ; tipc-discuss...@lists.sourcef
> -Original Message-
> From: Cong Wang
> Sent: 12-Dec-18 01:17
> To: Dmitry Vyukov
> Cc: syzbot+c56449ed3652e6720...@syzkaller.appspotmail.com; Jon Maloy
> ; Ying Xue ; tipc-
> discuss...@lists.sourceforge.net; David Miller ;
> Alexey Kuznetsov ; LKML ker...
> -Original Message-
> From: Dmitry Vyukov
> Sent: 13-Dec-18 04:47
> To: Jon Maloy
> Cc: syzbot+9845fed98688e01f4...@syzkaller.appspotmail.com; David Miller
> ; LKML ; netdev
> ; syzkaller-bugs b...@googlegroups.com>; tipc-discuss...@lists.sourceforge.net; Y
> -Original Message-
> From: Dmitry Vyukov
> Sent: 12-Dec-18 06:03
> To: syzbot+aab62b9c7b12e7c6a...@syzkaller.appspotmail.com; Jon Maloy
> ; Ying Xue ; David
> Miller ; tipc-discuss...@lists.sourceforge.net
> Cc: Alexey Kuznetsov ; LKML ker...@vger.kernel.org>;
> -Original Message-
> From: syzbot
> Sent: 12-Dec-18 06:11
> To: da...@davemloft.net; Jon Maloy ; linux-
> ker...@vger.kernel.org; netdev@vger.kernel.org; syzkaller-
> b...@googlegroups.com; tipc-discuss...@lists.sourceforge.net;
> ying@windriver.com
> S
> -Original Message-
> From: Cong Wang
> Sent: 10-Dec-18 18:24
> To: netdev@vger.kernel.org
> Cc: Cong Wang ; Ying Xue
> ; Jon Maloy
> Subject: [Patch net] tipc: compare remote and local protocols in
> tipc_udp_enable()
>
> When TIPC_NLA_UDP_REMOT
Acked.
Thank you for both your quick fixes, Cong.
///jon
> -Original Message-
> From: Cong Wang
> Sent: 10-Dec-18 15:46
> To: netdev@vger.kernel.org
> Cc: Cong Wang ; Ying Xue
> ; Jon Maloy
> Subject: [Patch net] tipc: fix a double kfree_skb()
>
> tipc_udp
timer cleanup function use spin_trylock()
instead of just spin_lock(), and when it fails to grab the lock it
just returns so that the timer handler can terminate its execution.
This is safe to do, since tipc_node_stop() anyway is about to
delete both the timer and the node instance.
Fixes: 6a939f36
Acked-by: Jon Maloy
///jon
> -Original Message-
> From: Ying Xue
> Sent: October 11, 2018 7:58 AM
> To: Jon Maloy ; dvyu...@google.com
> Cc: da...@davemloft.net; parthasarathy.bhuvara...@ericsson.com;
> netdev@vger.kernel.org; linux-ker...@vger.kernel.or
Hi Dmitry,
Yes, we are aware of this, the kernel test robot warned us about this a few
days ago.
I am looking into it.
///jon
> -Original Message-
> From: Dmitry Vyukov
> Sent: October 11, 2018 3:55 AM
> To: parthasarathy.bhuvara...@ericsson.com; Jon Maloy
> ; David Mi
> -Original Message-
> From: netdev-ow...@vger.kernel.org
> On Behalf Of David Miller
> Sent: Saturday, May 19, 2018 23:00
> To: ying@windriver.com
> Cc: netdev@vger.kernel.org; Jon Maloy ;
> syzkaller-b...@googlegroups.com; tipc-discuss...@lists.sourcefo
from David Ahern
v3: Fixed leaking socket as per comment from David Ahern
Signed-off-by: Jon Maloy
---
tipc/misc.c | 20
tipc/misc.h | 1 +
tipc/nametable.c | 18 ++
tipc/node.c | 19 ---
tipc/peer.c | 4
5 files ch
David Ahern
Signed-off-by: Jon Maloy
---
tipc/misc.c | 18 ++
tipc/misc.h | 1 +
tipc/nametable.c | 18 ++
tipc/node.c | 19 ---
tipc/peer.c | 4
5 files changed, 41 insertions(+), 19 deletions(-)
diff --git a/tipc/
Acked-by: Jon Maloy
Thank you Eric.
> -Original Message-
> From: Eric Dumazet [mailto:eduma...@google.com]
> Sent: Wednesday, May 09, 2018 09:50
> To: David S . Miller
> Cc: netdev ; Eric Dumazet
> ; Eric Dumazet ; Jon
> Maloy ; Ying Xue
> Subject: [PATCH net]
kup the tipc_service
-> service_range -> publication items in the correct hierarchical
order.
In this commit we try to make this right, and as a side effect obtain
some code simplification.
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
net/tipc/name_table.c | 103 ++-
ormer potentially is much
longer than the latter, we make room for it by eliminating the (to the
user) irrelevant publication key. We also reorder some of the columns
so that the node id comes last, since this looks nicer and more logical.
Signed-off-by: Jon Maloy
---
tipc/misc.c | 18
Acked-by: Jon Maloy
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-
> ow...@vger.kernel.org] On Behalf Of Paolo Abeni
> Sent: Monday, May 07, 2018 06:06
> To: netdev@vger.kernel.org
> Cc: David S. Miller
> Subject: [PATCH net-next] flow_d
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Thursday, May 03, 2018 15:22
> To: syzbot+df0257c92ffd4fcc5...@syzkaller.appspotmail.com
> Cc: Jon Maloy ; linux-ker...@vger.kernel.org;
> netdev@vger.kernel.org; syzkaller-b...@goog
> -Original Message-
> From: Wenwen Wang [mailto:wang6...@umn.edu]
> Sent: Tuesday, May 01, 2018 00:26
> To: Wenwen Wang
> Cc: Kangjie Lu ; Jon Maloy ; Ying
> Xue ; David S. Miller ;
> open list:TIPC NETWORK LAYER ; open list:TIPC
> NETWORK LAYER ; open list
particularly useful when we extend some of the commands in the
'tipc' tool, but we also expect regular user applications to need
this feature.
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
include/uapi/linux/tipc.h | 12
net/tipc/node.c | 21 +
he missing part.
Fixes: 36a50a989ee8 ("tipc: fix infinite loop when dumping link monitor
summary")
Signed-off-by: Jon Maloy
---
net/tipc/node.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tipc/node.c b/net/tipc/node.c
index 6f98b56..baaf93f 100644
--- a/n
. This solution also caters for the case
where there may be gaps in the bearer array.
Signed-off-by: Tung Nguyen
Signed-off-by: Jon Maloy
---
net/tipc/monitor.c | 2 +-
net/tipc/node.c| 11 ---
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/net/tipc/monitor.c b/net/
e delete of the service range item outside
the said function. Instead, we now let the two functions calling it
test if the list is empty and perform the removal when that is the
case.
Reported-by: syzbot+d64b64afc55660106...@syzkaller.appspotmail.com
Signed-off-by: Jon Maloy
---
net/tipc/na
Acked-by: Jon Maloy
Thank you, Eric.
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-
> ow...@vger.kernel.org] On Behalf Of Eric Dumazet
> Sent: Monday, April 16, 2018 11:30
> To: David S . Miller
> Cc: netdev ; Eric Dumazet
> ; Eric Dumaz
the named function if the given address
type is illegal.
Reported-by: syzbot+b0975ce9355b347c1...@syzkaller.appspotmail.com
Signed-off-by: Jon Maloy
---
net/tipc/socket.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index 1fd1c8b..252a5
plies
back to the commit shown below. Given the low risk of this happening
we believe this to be sufficient.
Fixes: commit 218527fe27ad ("tipc: replace name table service range
array with rb tree")
Reported-by: syzbot+aa245f26d42b8305d...@syzkaller.appspotmail.com
Signed-off-by: Jon
> -Original Message-
> From: Ying Xue [mailto:ying@windriver.com]
> Sent: Wednesday, April 11, 2018 06:27
> To: Jia-Ju Bai ; Jon Maloy
> ; da...@davemloft.net
> Cc: netdev@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux-
> ker...@vger.kernel.org
>
#syz dup: general protection fault in __list_del_entry_valid (3)
> -Original Message-
> From: syzbot
> [mailto:syzbot+4859fe19555ea87c4...@syzkaller.appspotmail.com]
> Sent: Monday, April 02, 2018 02:01
> To: da...@davemloft.net; Jon Maloy ; linux-
> ker...@vger.
ation functions"), which is still in net-next.
We fix this for that commit by initializing the two lists properly.
Fixes: 242e82cc95f6 ("tipc: collapse subscription creation functions")
Reported-by: syzbot+0bb443b74ce09197e...@syzkaller.appspotmail.com
Signed-off-by: Jon Maloy
---
net/tip
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-
> ow...@vger.kernel.org] On Behalf Of David Ahern
> Sent: Thursday, March 29, 2018 13:59
> To: Jon Maloy ; da...@davemloft.net;
> netdev@vger.kernel.org
> Cc: Mohan Krishna Ghanta Krishn
The function tipc_nametbl_translate() function is ugly and hard to
follow. This can be improved somewhat by introducing a stack variable
for holding the publication list to be used and re-ordering the if-
clauses for selection of algorithm.
Signed-off-by: Jon Maloy
---
net/tipc/name_table.c
safe side we also replace the sprintf() call with
snprintf().
Fixes: 25b0b9c4e835 ("tipc: handle collisions of 32-bit node address
hash values")
Reported-by: Arnd Bergmann
Signed-off-by: Jon Maloy
---
include/uapi/linux/tipc.h | 2 +-
net/tipc/link.c | 3 ++-
2 files changed, 3
improving cache hit rate.
Signed-off-by: Jon Maloy
---
net/tipc/core.h |1 +
net/tipc/link.c |2 +-
net/tipc/name_table.c | 1032 ++---
net/tipc/name_table.h |2 +-
net/tipc/node.c |4 +-
net/tipc/subscr.h |4
ication/withdrawal item
from a peer node never will be rejected, and make it possible to
eliminate the problematic backlog functionality we currently have for
handling such cases.
Signed-off-by: Jon Maloy
---
net/tipc/name_distr.c | 90 +--
ed-off-by: Jon Maloy
---
include/uapi/linux/tipc.h | 57 +++
1 file changed, 33 insertions(+), 24 deletions(-)
diff --git a/include/uapi/linux/tipc.h b/include/uapi/linux/tipc.h
index 4ac9f1f..156224a 100644
--- a/include/uapi/linux/tipc.h
+++ b/inc
replaced a few more macros to get a consistent
terminology in the API.
#5: Added new commit to fix a potential string overflow bug (it
is still only in net-next) reported by Arnd Bergmann
Jon Maloy (5):
tipc: replace name table service range array with rb tree
tipc: ref
same operations. For compatibility the old 'netid' commands are
retained, -we just remove them from the help texts.
Acked-by: GhantaKrishnamurthy MohanKrishna
Signed-off-by: Jon Maloy
---
include/uapi/linux/tipc_netlink.h | 2 +
tipc/misc.c | 78 ++
1: We introduce ability to set/get 128-bit node identities
2: We rename 'net id' to 'cluster id' in the command API,
of course in a compatible way.
3: We print out all 32-bit node addresses as an integer in hex format,
i.e., we remove the assumption about an internal s
Since a node address now per definition is only an unstructured 32-bit
integer it makes no sense print it out as a structured string.
In this commit, we replace all occurrences of "" printouts with
just an "%x".
Acked-by: GhantaKrishnamurthy MohanKrishna
Signed-off-by:
uct tipc_socket_addr
struct tipc_name -> struct tipc_service_addr
struct tipc_name_seq -> struct tipc_service_range
For compatibility, we add macros that map the old names to the new ones.
Signed-off-by: Jon Maloy
---
include/uapi/linux/tipc.h | 32 ++--
1 fil
ication/withdrawal item
from a peer node never will be rejected, and make it possible to
eliminate the problematic backlog functionality we currently have for
handling such cases.
Signed-off-by: Jon Maloy
---
net/tipc/name_distr.c | 90 +--
The function tipc_nametbl_translate() function is ugly and hard to
follow. This can be improved somewhat by introducing a stack variable
for holding the publication list to be used and re-ordering the if-
clauses for selection of algorithm.
Signed-off-by: Jon Maloy
---
net/tipc/name_table.c
improving cache hit rate.
Signed-off-by: Jon Maloy
---
net/tipc/core.h |1 +
net/tipc/link.c |2 +-
net/tipc/name_table.c | 1032 ++---
net/tipc/name_table.h |2 +-
net/tipc/node.c |4 +-
net/tipc/subscr.h |4
We clean up and improve the name binding table:
- Replace the memory consuming 'sub_sequence/service range' array with
an RB tree.
- Introduce support for overlapping service sequences/ranges
Jon Maloy (4):
tipc: replace name table service range array with rb tree
tipc: ref
> -Original Message-
> From: Arnd Bergmann [mailto:a...@arndb.de]
> Sent: Wednesday, March 28, 2018 10:02
> To: Jon Maloy ; Ying Xue
> ; David S. Miller
> Cc: Arnd Bergmann ; Parthasarathy Bhuvaragan
> ; netdev@vger.kernel.org; tipc-
> discuss...@lists.so
Acked-by: Jon Maloy
Thanks
///jon
> -Original Message-
> From: Wei Yongjun [mailto:weiyongj...@huawei.com]
> Sent: Monday, March 26, 2018 10:33
> To: Jon Maloy ; Ying Xue
>
> Cc: Wei Yongjun ; netdev@vger.kernel.org;
> tipc-discuss...@lists.sourcefo
Acked-by: Jon Maloy
Thank you, Wei.
> -Original Message-
> From: Wei Yongjun [mailto:weiyongj...@huawei.com]
> Sent: Monday, March 26, 2018 10:33
> To: Jon Maloy ; Ying Xue
>
> Cc: Wei Yongjun ; netdev@vger.kernel.org;
> tipc-discuss...@lists.sourcefo
Acked-by: Jon Maloy jon.ma...@ericsson.com
Thanks, Fengguang
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-
> ow...@vger.kernel.org] On Behalf Of kbuild test robot
> Sent: Friday, March 23, 2018 15:48
> To: Jon Maloy
> Cc: kbuild-
-
> From: Mohan Krishna Ghanta Krishnamurthy
> Sent: Friday, March 23, 2018 10:01
> To: tipc-discuss...@lists.sourceforge.net; Jon Maloy
> ; ma...@donjonn.com;
> ying@windriver.com; Mohan Krishna Ghanta Krishnamurthy
> ;
> netdev@vger.kernel.org; step...@networkplumber.o
As a preparation for the next commits we try to reduce the footprint of
the function tipc_enable_bearer(), while hopefully making is simpler to
follow.
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
net/tipc/bearer.c | 136 --
1 file changed
s the address explicitly, there will be no trial period and
messages, so this protocol addition is completely backwards compatible.
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
net/tipc/addr.c | 3 +-
net/tipc/bearer.c | 3 +-
net/tipc/core.c | 2 +
net/tipc/core.h | 2 +
address in the case of an L2 bearer, IPv4/IPv6 address in the case
of a UDP bearer.
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
net/tipc/bearer.c| 24 +++-
net/tipc/net.h | 1 +
net/tipc/udp_media.c | 13 +
3 files changed, 29 insertions(+), 9
As a preparation to changing the addressing structure of TIPC we replace
all direct accesses to the tipc_net::own_addr field with the function
dedicated for this, tipc_own_addr().
There are no changes to program logics in this commit.
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
net/tipc
Xue
Signed-off-by: Jon Maloy
---
net/tipc/bearer.c | 8 +-
net/tipc/bearer.h | 2 +-
net/tipc/discover.c | 303 +---
net/tipc/discover.h | 8 +-
4 files changed, 155 insertions(+), 166 deletions(-)
diff --git a/net/tipc/bearer.c b/net
en a legacy user
indicates a zero lookup domain 'closest-first' is selected, and in all
other cases we use 'round-robin'.
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
net/tipc/addr.c | 12 +++-
net/tipc/addr.h | 2 +-
net/tipc/core.h | 3 ++-
net
epted, provided
both peers have the same network id.
This secures backwards compatibility for users who have been using zone
or cluster identities as cluster separators, instead of the intended
'network id'.
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
net/tipc/addr.c |
.
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
include/uapi/linux/tipc_netlink.h | 2 +
net/tipc/addr.c | 81 ---
net/tipc/addr.h | 28 +++---
net/tipc/core.c | 4 +-
net/tipc/core.h
or IP address.
Jon Maloy (8):
tipc: refactor function tipc_enable_bearer()
tipc: some cleanups in the file discover.c
tipc: remove restrictions on node address values
tipc: allow closest-first lookup algorithm when legacy address is
configured
tipc: remove direct accesses to own_addr fie
No, it won't. I just moved those functions and #defines to the bottom of the
same file, and marked them as 'deprecated'.
BR
///jon
> -Original Message-
> From: Jiri Pirko [mailto:j...@resnulli.us]
> Sent: Thursday, March 15, 2018 12:11
> To: Jon Maloy
> C
As a consequence of the previous commit we nan now eliminate zone scope
related lists in the name table. We start with name_table::publ_list[3],
which can now be replaced with two lists, one for node scope publications
and one for cluster scope publications.
Acked-by: Ying Xue
Signed-off-by: Jon
onal changes in this commit.
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
net/tipc/name_distr.c | 12 ++---
net/tipc/name_distr.h | 2 +-
net/tipc/name_table.c | 143 --
net/tipc/name_table.h | 38 --
net/tipc/socket.c |
e' which
reflects what it really is.
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
net/tipc/name_distr.c | 20 ++--
net/tipc/name_table.h | 5 ++---
2 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/net/tipc/name_distr.c b/net/tipc/name_distr.c
index 11ce205.
e of those lists, since
they don't serve any purpose.
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
net/tipc/name_table.c | 101 ++
net/tipc/name_table.h | 5 +--
2 files changed, 30 insertions(+), 76 deletions(-)
diff --git a/net/tipc/nam
Functionality related to the 'zone' concept was never implemented in
TIPC. In this series we eliminate the remaining traces of it in the
code, and can hence take a first step in reducing the footprint and
complexity of the binding table.
Jon Maloy (5):
tipc: obsolete TIPC_ZONE_SC
for use during lookup, with the same meaning as ZONE_SCOPE/CLUSTER_SCOPE.
We now permit it even as binding scope, but for compatibility reasons we
choose to not change the value of TIPC_CLUSTER_SCOPE.
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
include/uapi/linux/tipc.h | 102
Functionality related to the zone concept was never implemented in TIPC.
In this series we eliminate the remaining traces of it in the code, and
can hence take a first step in reducing the footprint and complexity of
the binding table.
Jon Maloy (5):
tipc: obsolete TIPC_ZONE_SCOPE
tipc
From: Hoang Le
We introduce a set/getsockopt for setting socket receive buffer per
individual socket. This has turned out to sometimes be necessary for
anycast and multicast receivers when used without flow control.
Signed-off-by: Hoang Le
Signed-off-by: Jon Maloy
---
include/uapi/linux
y request so.
This commit corrects this bug.
Reported-by: Hoang Le
Signed-off-by: Jon Maloy
---
net/tipc/group.c | 1 +
net/tipc/socket.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/net/tipc/group.c b/net/tipc/group.c
index 03086cc..d7a7bef 100644
--- a/net/tipc/group.c
+++ b/net
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-
> ow...@vger.kernel.org] On Behalf Of Paolo Abeni
> Sent: Monday, February 19, 2018 19:02
> To: netdev@vger.kernel.org
> Cc: Jon Maloy ; Ying Xue
> ; David S. Miller
> Subject: [PATCH ne
> -Original Message-
> From: David Laight [mailto:david.lai...@aculab.com]
> Sent: Monday, February 19, 2018 14:30
> To: Jon Maloy
> Cc: netdev@vger.kernel.org; Mohan Krishna Ghanta Krishnamurthy
> ; Tung Quang Nguyen
> ; Hoang Huu Le
> ; Canh Duc Luu
> ;
com]
> Sent: Saturday, February 17, 2018 23:23
> To: Dmitry Vyukov ; syzbot
> ; Jon Maloy
> ; Ying Xue
> Cc: Andrei Vagin ; David Miller
> ; Eric W. Biederman ;
> Florian Westphal ; LKML ;
> netdev ; Nicolas Dichtel
> ; roman.k...@sysgo.com; syzkaller-
In commit cc1ea9ffadf7 ("tipc: eliminate struct tipc_subscriber") we
re-introduced an old bug on the error path in the function
tipc_topsrv_kern_subscr(). We now re-introduce the correction too.
Reported-by: syzbot+f62e0f2a0ef578703...@syzkaller.appspotmail.com
Signed-off-by: Jon Maloy
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Friday, February 16, 2018 21:33
> To: Jon Maloy
> Cc: netdev@vger.kernel.org; Mohan Krishna Ghanta Krishnamurthy
> ; Tung Quang Nguyen
> ; Hoang Huu Le
> ; Canh Duc Luu
> ;
alue of
the buffer clones to be the truesize of the clone itself plus a
calculated fraction of the base buffer's overhead. This change
eliminates the overaccounting and at least mitigates the occurrence
of unnecessary buffer copying.
Reported-by: Hoang Le
Acked-by: Ying Xue
Signed-off-by: Jon Mal
1 - 100 of 443 matches
Mail list logo
