[PATCH net-next v5 2/2] gtp: support SGSN-side tunnels

at GTP-link creation time to specify whether we are on the GGSN or SGSN side of the tunnel; this flag is then used to determine which part of the IP packet to use in determining the PDP context. Signed-off-by: Jonas Bonn <jo...@southpole.se> Acked-by: Pablo Neira Ayuso <pa...@netfilter.org&

[PATCH net-next v5 1/2] gtp: rename SGSN netlink attribute

Renaming the parameter makes the relationship clearer. The legacy name is maintained as a define in the header file in order to not break existing code. Signed-off-by: Jonas Bonn <jo...@southpole.se> Acked-by: Pablo Neira Ayuso <pa...@netfilter.org> Acked-by: Harald Welte <lafo...@gnumonks.or

[PATCH net-next v5 0/2] GTP SGSN-side tunnel

Changes since v4: * Respin the series on top of net-next; the conflicts were trivial, amounting to just code having been shifted about Jonas Bonn (2): gtp: rename SGSN netlink attribute gtp: support SGSN-side tunnels drivers/net/gtp.c| 64

Re: [PATCH net-next v3 0/2] GTP SGSN-side tunnels

On 03/24/2017 11:41 AM, Pablo Neira Ayuso wrote: On Fri, Mar 24, 2017 at 10:33:56AM +0100, Jonas Bonn wrote: Changes since v2: * Move #define of legacy netlink attribute into enum * Added note to commit message about load-testing use-case * Ack from Pablo Thanks a lot Jonas! David, please

[PATCH net-next v4 2/2] gtp: support SGSN-side tunnels

at GTP-link creation time to specify whether we are on the GGSN or SGSN side of the tunnel; this flag is then used to determine which part of the IP packet to use in determining the PDP context. Signed-off-by: Jonas Bonn <jo...@southpole.se> Acked-by: Pablo Neira Ayuso <pa...@netfilter.org&

[PATCH net-next v4 1/2] gtp: rename SGSN netlink attribute

Renaming the parameter makes the relationship clearer. The legacy name is maintained as a define in the header file in order to not break existing code. Signed-off-by: Jonas Bonn <jo...@southpole.se> Acked-by: Pablo Neira Ayuso <pa...@netfilter.org> Acked-by: Harald Welte <lafo...@gnumonks.or

[PATCH net-next v4 0/2] GTP SGSN-side tunnels

Changes from v3: * Coding style fixup: remove extraneous braces on if-statement * Ack from Harald Jonas Bonn (2): gtp: rename SGSN netlink attribute gtp: support SGSN-side tunnels drivers/net/gtp.c| 62 +--- include/uapi/linux/gtp.h

Re: [PATCH net-next v3 0/2] GTP SGSN-side tunnels

Hi Harald, On 03/24/2017 11:15 AM, Harald Welte wrote: Hi Jonas, looks fine to me, but I haven't tested it. Did you manually test it using the extended libgtpnl + tools? I have tested it against your libgtpnl branch laforge/sgsn-role. Creating an interface with tools/gtp-link works fine.

[PATCH net-next v3 1/2] gtp: rename SGSN netlink attribute

Renaming the parameter makes the relationship clearer. The legacy name is maintained as a define in the header file in order to not break existing code. Signed-off-by: Jonas Bonn <jo...@southpole.se> Acked-by: Pablo Neira Ayuso <pa...@netfilter.org> --- drivers/net/gtp.c| 22 +

[PATCH net-next v3 2/2] gtp: support SGSN-side tunnels

at GTP-link creation time to specify whether we are on the GGSN or SGSN side of the tunnel; this flag is then used to determine which part of the IP packet to use in determining the PDP context. Signed-off-by: Jonas Bonn <jo...@southpole.se> Acked-by: Pablo Neira Ayuso <pa...@netfilte

[PATCH net-next v3 0/2] GTP SGSN-side tunnels

Changes since v2: * Move #define of legacy netlink attribute into enum * Added note to commit message about load-testing use-case * Ack from Pablo Jonas Bonn (2): gtp: rename SGSN netlink attribute gtp: support SGSN-side tunnels drivers/net/gtp.c| 63

Re: [PATCH 1/1] gtp: support SGSN-side tunnels

Hi Harald, On 03/15/2017 05:39 PM, Harald Welte wrote: Hi Jonas, are you working on the review feedback that was provided back in early February? I think there were some comments like * remove unrelated cosmetic change in comment * change from FLAGS to a dedicated MODE netlink attribute * add

[PATCH v2 2/2] gtp: support SGSN-side tunnels

ation time to specify whether we are on the GGSN or SGSN side of the tunnel; this flag is then used to determine which part of the IP packet to use in determining the PDP context. Signed-off-by: Jonas Bonn <jo...@southpole.se> --- drivers/net/gtp.c

[PATCH v2 1/2] gtp: rename SGSN netlink attribute

Renaming the parameter makes the relationship clearer. The legacy name is maintained as a define in the header file in order to not break existing code. Signed-off-by: Jonas Bonn <jo...@southpole.se> --- drivers/net/gtp.c| 22 +++--- include/uapi/linux/gtp.h | 3 ++- 2 f

Re: [PATCH v2 1/2] gtp: rename SGSN netlink attribute

On 03/21/2017 04:07 PM, Pablo Neira Ayuso wrote: On Tue, Mar 21, 2017 at 04:04:29PM +0100, Jonas Bonn wrote: diff --git a/include/uapi/linux/gtp.h b/include/uapi/linux/gtp.h index 72a04a0..c51ebb0 100644 --- a/include/uapi/linux/gtp.h +++ b/include/uapi/linux/gtp.h @@ -19,7 +19,7 @@ enum

Re: [PATCH 1/1] gtp: support SGSN-side tunnels

Hi Pablo, On 02/06/2017 12:08 PM, Pablo Neira Ayuso wrote: Hi Jonas, On Fri, Feb 03, 2017 at 10:12:31AM +0100, Jonas Bonn wrote: The GTP-tunnel driver is explicitly GGSN-side as it searches for PDP contexts based on the incoming packets _destination_ address. If we want to write an SGSN

[PATCH 1/1] gtp: support SGSN-side tunnels

ation time to specify whether we are on the GGSN or SGSN side of the tunnel; this flag is then used to determine which part of the IP packet to use in determining the PDP context. Signed-off-by: Jonas Bonn <jo...@southpole.se> --- drivers/net/gtp.c

[PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst

Signed-off-by: Jonas Bonn [EMAIL PROTECTED] --- drivers/net/sk98lin/skge.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/sk98lin/skge.c b/drivers/net/sk98lin/skge.c index 20890e4..eedcbeb 100644 --- a/drivers/net/sk98lin/skge.c +++ b/drivers/net/sk98lin

[PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst

Signed-off-by: Jonas Bonn [EMAIL PROTECTED] --- drivers/net/starfire.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/starfire.c b/drivers/net/starfire.c index c49214f..a67bac5 100644 --- a/drivers/net/starfire.c +++ b/drivers/net/starfire.c @@ -337,7 +337,7

[PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst

Signed-off-by: Jonas Bonn [EMAIL PROTECTED] --- drivers/net/skfp/skfddi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/skfp/skfddi.c b/drivers/net/skfp/skfddi.c index 7cf9b9f..2a8386b 100644 --- a/drivers/net/skfp/skfddi.c +++ b/drivers/net/skfp/skfddi.c

[PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst

Signed-off-by: Jonas Bonn [EMAIL PROTECTED] --- drivers/net/wan/dscc4.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wan/dscc4.c b/drivers/net/wan/dscc4.c index c6f26e2..16d3a4c 100644 --- a/drivers/net/wan/dscc4.c +++ b/drivers/net/wan/dscc4.c @@ -2048,7

[PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst

Signed-off-by: Jonas Bonn [EMAIL PROTECTED] --- drivers/net/niu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/niu.c b/drivers/net/niu.c index e98ce1e..ab8148a 100644 --- a/drivers/net/niu.c +++ b/drivers/net/niu.c @@ -62,7 +62,7 @@ static void writeq(u64

[PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst

Signed-off-by: Jonas Bonn [EMAIL PROTECTED] --- drivers/net/wan/lmc/lmc_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c index 6635ece..e85cfe7 100644 --- a/drivers/net/wan/lmc/lmc_main.c +++ b/drivers

[PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst

Signed-off-by: Jonas Bonn [EMAIL PROTECTED] --- drivers/net/hamachi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/hamachi.c b/drivers/net/hamachi.c index b53f6b6..d8056e9 100644 --- a/drivers/net/hamachi.c +++ b/drivers/net/hamachi.c @@ -1987,7 +1987,7

[PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst

Signed-off-by: Jonas Bonn [EMAIL PROTECTED] --- drivers/net/amd8111e.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/amd8111e.c b/drivers/net/amd8111e.c index 85f7276..a4ad2fb 100644 --- a/drivers/net/amd8111e.c +++ b/drivers/net/amd8111e.c @@ -113,7 +113,7

[PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst

Signed-off-by: Jonas Bonn [EMAIL PROTECTED] --- drivers/net/arcnet/com20020-pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/arcnet/com20020-pci.c index b8c0fa6..87ee0db 100644 --- a/drivers/net/arcnet/com20020-pci.c

pci_device_id cleanups

The PCI_DEVICE_TABLE patch I sent earlier doesn't necessarily make much sense by itself... here is a set of patches that apply this macro, in turn moving a lot of this data into __devinitconst which is discardable in certain situations. Hopefully the benefit of this approach is a bit clearer

[PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst

Signed-off-by: Jonas Bonn [EMAIL PROTECTED] --- drivers/net/tlan.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/tlan.c b/drivers/net/tlan.c index 3af5b92..bea59c6 100644 --- a/drivers/net/tlan.c +++ b/drivers/net/tlan.c @@ -253,7 +253,7 @@ static struct

[PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst

Signed-off-by: Jonas Bonn [EMAIL PROTECTED] --- drivers/net/defxx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/defxx.c b/drivers/net/defxx.c index ddc30c4..84a3ce5 100644 --- a/drivers/net/defxx.c +++ b/drivers/net/defxx.c @@ -3630,7 +3630,7 @@ static

[PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst

Signed-off-by: Jonas Bonn [EMAIL PROTECTED] --- drivers/net/sunhme.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/sunhme.c b/drivers/net/sunhme.c index b4e7f30..beb0d27 100644 --- a/drivers/net/sunhme.c +++ b/drivers/net/sunhme.c @@ -3247,7 +3247,7

[PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst

Signed-off-by: Jonas Bonn [EMAIL PROTECTED] --- drivers/net/pasemi_mac.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/pasemi_mac.c b/drivers/net/pasemi_mac.c index 2e39e02..069fa7c 100644 --- a/drivers/net/pasemi_mac.c +++ b/drivers/net/pasemi_mac.c

[PATCH] Add PCI_DEVICE_TABLE macro

The definitions of struct pci_device_id arrays should generally follow the same pattern across the entire kernel. This macro defines this array as const and puts it into the __devinitconst section. Signed-off-by: Jonas Bonn [EMAIL PROTECTED] --- include/linux/pci.h |9 + 1 files

[PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst

Signed-off-by: Jonas Bonn [EMAIL PROTECTED] --- drivers/net/3c59x.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c index 6f8e7d4..d2045d4 100644 --- a/drivers/net/3c59x.c +++ b/drivers/net/3c59x.c @@ -372,7 +372,7 @@ static

Re: pci_device_id cleanups

Sam Ravnborg wrote: On Wed, Feb 20, 2008 at 01:53:36PM +0100, Jonas Bonn wrote: The PCI_DEVICE_TABLE patch I sent earlier doesn't necessarily make much sense by itself... here is a set of patches that apply this macro, in turn moving a lot of this data into __devinitconst which is discardable

Re: PowerPC toolchain for x86 [Was: pci_device_id cleanups]

Sam Ravnborg wrote: On Wed, Feb 20, 2008 at 02:27:19PM +0100, Jonas Bonn wrote: Sam Ravnborg wrote: On Wed, Feb 20, 2008 at 01:53:36PM +0100, Jonas Bonn wrote: The PCI_DEVICE_TABLE patch I sent earlier doesn't necessarily make much sense by itself... here is a set of patches that apply

[PATCH] [SIS190] Constify data marked as __devinitdata

This fixes build error as gcc complains about a section type conflict due to the const __devinitdata in sis190_get_mac_addr_from_apc(). --- drivers/net/sis190.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index

[PATCH] [SIS190] Use _devinitconst for const data

This fixes build error as gcc complains about a section type conflict due to the mixing of const and non-const data in same section. --- drivers/net/sis190.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

instead? Because AFAIK, const *and* __sectionmarker does not mix. You're right... it's documented in linux/init.h that const and __sectionmarker do not mix. The compile error is due to the use of const and __section marker in the function sis190_get_mac_addr_from_apc(). -- To unsubscribe

[PATCH] [SIS190] Use __devinitconst for const devinit data

Mixing const and __section was previously not allowed. New __devinitconst tag allows this. This fixes a gcc section type mismatch build error. --- drivers/net/sis190.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index