Re: [PATCH] can: enable multi-queue for SocketCAN devices

2018-03-15 Thread Jonas Mark (BT-FIR/ENG1)
Hello Marc, > > The driver consists of two layers because the HW is accessed via SPI. > > Normal SPI? Yes, normal SPI (CLK, MOSI, MISO, SEL) plus two GPIOs for flow control. The CAN peripheral (SPI slave) asserts the additional signals to request a transfer and to signal that it is busy. > > I

Re: [PATCH] can: enable multi-queue for SocketCAN devices

2018-03-14 Thread Jonas Mark (BT-FIR/ENG1)
Hello Marc, > >> Do you have a driver or a patch to make a driver mq aware? > > > > Yes, we have CAN hardware with multiple queues and we also have a > > SocketCAN driver for it. > > > > IMHO the driver will be of very little use for the Linux community > > because the HW is proprietary. > > That

Re: [PATCH] can: enable multi-queue for SocketCAN devices

2018-03-14 Thread Jonas Mark (BT-FIR/ENG1)
Hello Marc, > > The existing SocketCAN implementation provides alloc_candev() to > > allocate a CAN device using a single Tx and Rx queue. This can lead to > > priority inversion in case the single Tx queue is already full with low > > priority messages and a high priority message needs to be sent