Is netif_rx_ni safe from interrupt context? (Re: [PATCH] batman-adv: bla: use netif_rx_ni when not in interrupt context)

2020-08-19 Thread Jussi Kivilinna
Hello, +CC netdev mailing-list On 18.8.2020 23.12, Antonio Quartulli wrote: > Hi, > > On 18/08/2020 16:46, Jussi Kivilinna wrote: >> batadv_bla_send_claim() gets called from worker thread context through >> batadv_bla_periodic_work(), thus netif_rx_ni needs to be used

Re: [patch 2.6.25-rc2-git] rndis_host: fix transfer size negotiation

2008-02-25 Thread Jussi Kivilinna
On Mon, 2008-02-25 at 13:29 -0500, John W. Linville wrote: > On Fri, Feb 22, 2008 at 05:31:16PM -0800, David Brownell wrote: > > From: Jean-Christophe Dubois <[EMAIL PROTECTED]> > > > > This patch should resolve a problem that's troubled support for > > some RNDIS peripherals. It seems to have bo

[PATCH 12/14 v2] [rndis_host] Add RNDIS physical medium checking into generic_rndis_bind()

2008-01-27 Thread Jussi Kivilinna
Add RNDIS physical medium checking into generic_rndis_bind() and also make rndis_host to be only bind on every medium except wireless. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c | 36 +--- drivers/net/usb/rndis_

Re: [PATCH 10/14] [rndis_host] Add early_init function pointer to 'struct rndis_data'.

2008-01-27 Thread Jussi Kivilinna
On Sun, 2008-01-27 at 08:14 -0800, David Brownell wrote: > On Friday 25 January 2008, Jussi Kivilinna wrote: > > Function pointer is for 'subminidrivers' that need to do work on device > > right after minidriver has initialized hardware. > > > > For exampl

Re: [PATCH 12/14] [rndis_host] Add RNDIS physical medium checking into generic_rndis_bind()

2008-01-27 Thread Jussi Kivilinna
x27; to those patches? Should I even repost all of these patches as patchset or just ones that have been fixed? Should I post new 'physical medium' patch as reply to this post and then repost patchset with your ack just to mailing list? - Jussi Kivilinna -- To unsubscribe from this list

Re: [PATCH 00/14][v3]: Driver for Wireless RNDIS USB devices.

2008-01-26 Thread Jussi Kivilinna
On Fri, 2008-01-25 at 15:09 -0800, David Brownell wrote: > If they're the same, my ack (as maintainer for that infrastructure > and, for now, rndis_host) still stands. I won't look at them again. > Ah, ok. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a mes

[PATCH 13/14] Move usbnet.h and rndis_host.h to include/linux/usb

2008-01-25 Thread Jussi Kivilinna
Move headers usbnet.h and rndis_host.h to include/linux/usb and fix includes for drivers/net/usb modules. Headers are moved because rndis_wlan will be outside drivers/net/usb in drivers/net/wireless and yet need these headers. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drive

[PATCH 11/14] [rndis_host] Add link_change function pointer to 'struct rndis_data'.

2008-01-25 Thread Jussi Kivilinna
Callback to signal link state changes from minidriver to 'subminidrivers'. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c | 24 drivers/net/usb/usbnet.h |4 2 files changed, 24 insertions(+), 4 de

[PATCH 12/14] [rndis_host] Add RNDIS physical medium checking into generic_rndis_bind()

2008-01-25 Thread Jussi Kivilinna
Add RNDIS physical medium checking into generic_rndis_bind() and also make rndis_host to be only bind on every medium except wireless. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c | 34 +++--- drivers/net/usb/rndis_

[PATCH 10/14] [rndis_host] Add early_init function pointer to 'struct rndis_data'.

2008-01-25 Thread Jussi Kivilinna
RNDIS_INIT. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c |6 ++ drivers/net/usb/usbnet.h |5 + 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/net/usb/rndis_host.c b/drivers/net/usb/rndis_host.c index 1d6bf0a

[PATCH 08/14] [rndis_host] export functions

2008-01-25 Thread Jussi Kivilinna
Export rndis_host functions and also rename rndis_bind() to generic_rndis_bind() for modules using rndis_host as base. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c | 20 +--- drivers/net/usb/rndis_host.h |9 + 2 files c

[PATCH 09/14] [usbnet] add driver_priv pointer to 'struct usbnet'

2008-01-25 Thread Jussi Kivilinna
Add a private data pointer to usbnet for rndis_wlan module to use. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drivers/net/usb/usbnet.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/usb/usbnet.h b/drivers/net/usb/usbnet.h index 29ab92e..0

[PATCH 07/14] [rndis_host] Split up rndis_host.c

2008-01-25 Thread Jussi Kivilinna
Split up rndis_host.c into rndis_host.h and rndis_base.c. This is done so that rndis_wlan can reuse common parts with rndis_host. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c | 223 -- drivers/net/usb/rndis_

[PATCH 06/14] [usbnet] Use wlan device name for RNDIS wireless devices

2008-01-25 Thread Jussi Kivilinna
Use wlan device name for RNDIS wireless devices. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]> --- drivers/net/usb/usbnet.c |3 +++ drivers/net/usb/usbnet.h |2 ++ 2 files changed, 5 insertions(+), 0 deletions(-)

[PATCH 05/14] [rndis_host] Fix rndis packet filter flags.

2008-01-25 Thread Jussi Kivilinna
RNDIS packet filter flags are not exactly the same as CDC flags so we cannot reuse them. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c | 23 ++- 1 files changed, 22 inse

[PATCH 04/14] [rndis_host] Halt device if rndis_bind fails.

2008-01-25 Thread Jussi Kivilinna
When bind fails after device was initialized, shutdown device properly by sending RNDIS_MSG_HALT. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c | 12 +--- 1 files changed, 9 inse

[PATCH 03/14] [rndis_host] Use 1KB buffer in rndis_unbind

2008-01-25 Thread Jussi Kivilinna
rndis_command requires the caller to pass in a buffer of at least 1KB. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dri

[PATCH 02/14] [cdc_ether] Hardwire CDC descriptors when missing

2008-01-25 Thread Jussi Kivilinna
jkstra <[EMAIL PROTECTED]> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drivers/net/usb/cdc_ether.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index a42acc3..97c17bb 100644 ---

[PATCH 01/14] Fix sparse warning: returning void-valued expression

2008-01-25 Thread Jussi Kivilinna
From: Bjorge Dijkstra <[EMAIL PROTECTED]> rndis_unbind and usbnet_cdc_unbind don't return anything. Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c |2 +- 1 files changed, 1 ins

[PATCH 00/14][v3]: Driver for Wireless RNDIS USB devices.

2008-01-25 Thread Jussi Kivilinna
ntested: - WPA PSK with CCMP - WPA2 PSK with TKIP - WPA/WPA2 Enterprise Patches should be applied in order, series apply cleanly to 2.6.24-git1. - Jussi Kivilinna -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/14] RFC: Driver for Wireless RNDIS USB devices.

2008-01-25 Thread Jussi Kivilinna
On Thu, 2008-01-24 at 17:19 -0800, David Brownell wrote: > > 13. [rndis_host] blacklist known wireless RNDIS devices > > That will be a headache over time though ... can't you just > let the probe succeed enough to recogize it's wireless (using > the media flag) and then bail, so the next driver c

Re: [PATCH 10/14] [rndis_host] Add rndis_early_init function pointer to 'struct rndis_data'.

2008-01-25 Thread Jussi Kivilinna
On Thu, 2008-01-24 at 17:10 -0800, David Brownell wrote: > Could this -- and #11/14 -- instead be generalized a bit, > so they're not RNDIS-specific? At least in name; the > only user for now would be the rndis_host code. > > The generalization would presumably be "early_init" and > "link_change"

[PATCH 12/14] Move usbnet.h and rndis_host.h to include/linux/usb

2008-01-19 Thread Jussi Kivilinna
Move headers usbnet.h and rndis_host.h to include/linux/usb and fix includes for drivers/net/usb modules. Headers are moved because rndis_wext will be outside drivers/net/usb in drivers/net/wireless and yet need these headers. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drive

[PATCH 13/14] [rndis_host] blacklist known wireless RNDIS devices

2008-01-19 Thread Jussi Kivilinna
Blacklist known wireless RNDIS devices that will be handled by rndis_wext module. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c | 104 ++ 1 files changed, 104 insertions(+), 0 deletions(-) diff --git a/drive

[PATCH 11/14] [rndis_host] Add rndis_link_change function pointer to 'struct rndis_data'.

2008-01-19 Thread Jussi Kivilinna
Callback to signal link state changes to rndis_wext. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c | 24 drivers/net/usb/usbnet.h |3 +++ 2 files changed, 23 insertions(+), 4 deletions(-) diff --git a/drivers/n

[PATCH 10/14] [rndis_host] Add rndis_early_init function pointer to 'struct rndis_data'.

2008-01-19 Thread Jussi Kivilinna
Function pointer is for rndis minidrivers that need to do work on device right after RNDIS_INIT. For example setting device specific configuration parameters with OID_GEN_RNDIS_CONFIG_PARAMETER. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c

[PATCH 09/14] [usbnet] add driver_priv pointer to 'struct usbnet'

2008-01-19 Thread Jussi Kivilinna
Add a private data pointer to usbnet for rndis_wext module to use. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drivers/net/usb/usbnet.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/usb/usbnet.h b/drivers/net/usb/usbnet.h index 29ab92e..0

[PATCH 07/14] [rndis_host] Split up rndis_host.c

2008-01-19 Thread Jussi Kivilinna
Split up rndis_host.c into rndis_host.h and rndis_base.c. This is done so that rndis_wext can reuse common parts with rndis_host. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c | 223 -- drivers/net/usb/rndis_

[PATCH 08/14] [rndis_host] export functions

2008-01-19 Thread Jussi Kivilinna
Export rndis_host functions and also rename rndis_bind() to generic_rndis_bind() for modules using rndis_host as base. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c | 20 +--- drivers/net/usb/rndis_host.h |9 + 2 files c

[PATCH 05/14] [rndis_host] Fix rndis packet filter flags.

2008-01-19 Thread Jussi Kivilinna
RNDIS packet filter flags are not exactly the same as CDC flags so we cannot reuse them. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c | 23 ++- 1 files changed, 22 inse

[PATCH 06/14] [usbnet] Use wlan device name for RNDIS wireless devices

2008-01-19 Thread Jussi Kivilinna
Use wlan device name for RNDIS wireless devices. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]> --- drivers/net/usb/usbnet.c |3 +++ drivers/net/usb/usbnet.h |2 ++ 2 files changed, 5 insertions(+), 0 deletions(-)

[PATCH 02/14] [cdc_ether] Hardwire CDC descriptors when missing

2008-01-19 Thread Jussi Kivilinna
jkstra <[EMAIL PROTECTED]> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drivers/net/usb/cdc_ether.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index a42acc3..97c17bb 100644 ---

[PATCH 03/14] [rndis_host] Use 1KB buffer in rndis_unbind

2008-01-19 Thread Jussi Kivilinna
rndis_command requires the caller to pass in a buffer of at least 1KB. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dri

[PATCH 04/14] [rndis_host] Halt device if rndis_bind fails.

2008-01-19 Thread Jussi Kivilinna
When bind fails after device was initialized, shutdown device properly by sending RNDIS_MSG_HALT. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c | 12 +--- 1 files changed, 9 inse

[PATCH 00/14] RFC: Driver for Wireless RNDIS USB devices.

2008-01-19 Thread Jussi Kivilinna
host.h to include/linux/usb 13. [rndis_host] blacklist known wireless RNDIS devices 14. Add new driver 'rndis_wext' for wireless RNDIS devices. Patches should be applied in order, series apply cleanly to 2.6.24-rc8. - Jussi Kivilinna -- To unsubscribe from this list: send the line "un

[PATCH 01/14] Fix sparse warning: returning void-valued expression

2008-01-19 Thread Jussi Kivilinna
From: Bjorge Dijkstra <[EMAIL PROTECTED]> rndis_unbind and usbnet_cdc_unbind don't return anything. Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c |2 +- 1 files changed, 1 ins

Re: [PATCH 6/8] [PATCH] Split up rndis_host.c

2008-01-17 Thread Jussi Kivilinna
I have new patchset that prepares rndis_host/usbnet for separate rndis_wext but not sure should I submit (I haven't managed to get into contact with Bjorge Dijkstra for 3,5 weeks now to have him decide how to proceed). - Jussi Kivilinna -- To unsubscribe from this list: send the line &q

Re: [PATCH 6/8] [PATCH] Split up rndis_host.c

2008-01-02 Thread Jussi Kivilinna
, with rndis_wext if OID isn't supported or type isn't wireless. Should this be ok? Should separate rndis_wext be located in drivers/net/wireless instead of drivers/net/usb? - Jussi Kivilinna On Sat, 2007-12-22 at 17:17 -0800, David Brownell wrote: > > From: Bjorge Dijkstra &