[PATCH] net/ncsi: Fix the payload copying for the request coming from Netlink

The request coming from Netlink should use the OEM generic handler. The standard command handler expects payload in bytes/words/dwords but the actual payload is stored in data if the request is coming from Netlink. Signed-off-by: Justin Lee --- net/ncsi/ncsi-cmd.c | 11 +-- 1 file chan

RE: [PATCH net-next v3 6/6] net/ncsi: Configure multi-package, multi-channel modes with failover

Hi Samuel, I have tested your new patch. The failover function works as expected. Thanks, Justin > On Fri, 2018-11-09 at 21:58 +, justin.l...@dell.com wrote: > > Hi Samuel, > > > > After running more testing, I notice that the extra patch causing failover > > function > > to fail. Also, o

[PATCH net-next v7] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

The new command (NCSI_CMD_SEND_CMD) is added to allow user space application to send NC-SI command to the network card. Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and response. The work flow is as below. Request: User space application -> Netlink interface (msg)

[PATCH net-next v6] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

The new command (NCSI_CMD_SEND_CMD) is added to allow user space application to send NC-SI command to the network card. Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and response. The work flow is as below. Request: User space application -> Netlink interface (msg)

RE: [PATCH net-next v5] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

> On Wed, 2018-10-10 at 18:11 +, justin.l...@dell.com wrote: > > > + > > + len = nla_len(info->attrs[NCSI_ATTR_DATA]); > > + if (len < sizeof(struct ncsi_pkt_hdr)) { > > + netdev_info(ndp->ndev.dev, "NCSI: no command to send %u\n", > > + package_id); > > +

[PATCH net-next v5] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

The new command (NCSI_CMD_SEND_CMD) is added to allow user space application to send NC-SI command to the network card. Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and response. The work flow is as below. Request: User space application -> Netlink interface (msg)

RE: [PATCH net-next v4] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

Hi Vijay, I will address the comment and send out the v5. Thanks, Justin > Hi Justin, > Please see minor comments below. > > Regards > -Vijay > > On 10/10/18, 9:01 AM, "justin.l...@dell.com" wrote: > > The new command (NCSI_CMD_SEND_CMD) is added to allow user space > application >

[PATCH net-next v4] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

The new command (NCSI_CMD_SEND_CMD) is added to allow user space application to send NC-SI command to the network card. Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and response. The work flow is as below. Request: User space application -> Netlink interface (msg)

RE: [PATCH net-next v3] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

Hi Samual, I will address the comment and send out the v4. Thanks, Justin > On Mon, 2018-10-08 at 23:13 +, justin.l...@dell.com wrote: > > The new command (NCSI_CMD_SEND_CMD) is added to allow user space > > application to send NC-SI command to the network card. > > Also, add a new attribu

[PATCH net-next v3] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

The new command (NCSI_CMD_SEND_CMD) is added to allow user space application to send NC-SI command to the network card. Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and response. The work flow is as below. Request: User space application -> Netlink interface (msg

RE: [PATCH v3] net/ncsi: Add NCSI OEM command support

> This patch adds OEM commands and response handling. It also defines OEM > command and response structure as per NCSI specification along with its > handlers. > > ncsi_cmd_handler_oem: This is a generic command request handler for OEM > commands > ncsi_rsp_handler_oem: This is a generic response

RE: [PATCH v2] net/ncsi: Add NCSI OEM command support

Hi Vijay, Please see the comments below. Thanks, Justin > Hi Justin, > Thanks for response. Please see my comments below. > > -Vijay > > > > diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c > > > index 7567ca63aae2..2f98533eba46 100644 > > > --- a/net/ncsi/ncsi-cmd.c > > > +++ b/net

RE: [PATCH net v2] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

Hi Sam, Sure, I will generate v3 after Vijay's patch is approved. Thanks, Justin > On Fri, 2018-09-28 at 18:15 +, justin.l...@dell.com wrote: > > The new command (NCSI_CMD_SEND_CMD) is added to allow user space > > application > > to send NC-SI command to the network card. > > Also, add a

RE: [PATCH v2] net/ncsi: Add NCSI OEM command support

Hi Vijay, Looks good. Please see my comment below. Thanks, Justin > On Fri, 2018-09-28 at 18:06 -0700, Vijay Khemka wrote: > > This patch adds OEM commands and response handling. It also defines OEM > > command and response structure as per NCSI specification along with its > > handlers. > > >

[PATCH net v2] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

The new command (NCSI_CMD_SEND_CMD) is added to allow user space application to send NC-SI command to the network card. Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and response. The work flow is as below. Request: User space application -> Netlink interface (msg)

RE: [PATCH net] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

Hi Samuel, Please see my comment below. Thanks, Justin > On Thu, 2018-09-27 at 21:08 +, justin.l...@dell.com wrote: > > The new command (NCSI_CMD_SEND_CMD) is added to allow user space > > application > > to send NC-SI command to the network card. > > Also, add a new attribute (NCSI_ATTR_

[PATCH net] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

The new command (NCSI_CMD_SEND_CMD) is added to allow user space application to send NC-SI command to the network card. Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and response. The work flow is as below. Request: User space application -> Netlink interface (msg)

RE: [PATCH] net/ncsi: Add NCSI OEM command for FB Tiogapass

> Thanks for the overview. We look forward to your patches; please > include the same cc list as this series. > I think it makes sense to have some OEM NCSI handing purely in the > kenrel. This would allow eg. the MAC address of an interface to be > correct at boot, without requiring userspace to

RE: [PATCH] net/ncsi: Add NCSI OEM command for FB Tiogapass

> > As I understand Justin's version adds a generic handler, using the NCSI > > Netlink interface to pass OEM commands and responses to and from > > userspace, which does the actual packet handling. > Thanks for the direction Sam! Justin, if you don't mind, can you share the > patches you have