Re: [PATCH] mwifiex: Use put_unaligned_le32

n this case, the key is CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. It >> seems that asm-generic/unaligned.h is set up to include different >> headers, based on the expected architecture behavior. >> > Yes, asm-generic/unaligned.h looks more appopriate and is most generic >

Re: [PATCH] mwifiex: Use put_unaligned_le32

oplevel header file which includes header files based on arch configuration. Also grepping the sources support that, nobody from drivers/ include access_ok.h directly. But I can't say that I fully understand how the header files work so please do correct me if I have mistaken. -- Kalle Valo

Re: [PATCH] mwifiex: Use put_unaligned_le32

vers/net/wireless/marvell/mwifiex/cmdevt.c > index 0edc5d6..e28e119 100644 > --- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c > +++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c > @@ -17,6 +17,7 @@ > * this warranty disclaimer. > */ > > +#include I don't think this is correct. Should it be asm/unaligned.h? -- Kalle Valo

Re: [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

; >>> > >>> > 于 2017年10月4日 GMT+08:00 下午5:02:17, Kalle Valo <kv...@codeaurora.org> >>写到: >>> > > Icenowy Zheng <icen...@aosc.io> writes: >>> > > >>> > > > Allwinner XR819 is a SDIO Wi-Fi chip, which ha

Re: ath9k: make const array reg_hole_list static, reduces object code size

18 15248 0 72766 11c3e debug.o > > After: >text data bss dec hex filename > 57218 15344 0 72562 11b72 debug.o > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Signed-off-by: Kalle Valo <kv.

Re: [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

ere is no upstream xr819 wireless driver in drivers/net/wireless directory. Do we still accept bindings like this for out-of-tree drivers? -- Kalle Valo

Re: [v4,2/9] brcmsmac: split up wlc_phy_workarounds_nphy

Arnd Bergmann wrote: > The stack consumption in this driver is still relatively high, with one > remaining warning if the warning level is lowered to 1536 bytes: > > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:17135:1: error: > the frame size of 1880 bytes is

Re: [v4, 1/9] brcmsmac: make some local variables 'static const' to reduce stack size

Arnd Bergmann wrote: > With KASAN and a couple of other patches applied, this driver is one > of the few remaining ones that actually use more than 2048 bytes of > kernel stack: > > broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function > 'wlc_phy_workarounds_nphy_gainctrl': >

Re: [PATCH 05/18] net: use ARRAY_SIZE

13 files changed, 177 insertions(+), 413 deletions(-) We have a tree for wireless so usually it's better to submit wireless changes on their own but here I assume Dave will apply this to his tree. If not, please resubmit the wireless part in a separate patch. -- Kalle Valo

Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

rnel.org/r/20170925041153.26574-1-dr...@endlessm.com -- Kalle Valo

Re: usb/wireless/rsi_91x: use-after-free write in __run_timers

Andrey Konovalov <andreyk...@google.com> writes: > On Mon, Sep 25, 2017 at 6:26 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> Andrey Konovalov <andreyk...@google.com> writes: >> >>> I've got the following report while fuzzing th

pull-request: wireless-drivers 2017-09-25

Kalle Valo (2): Merge tag 'iwlwifi-for-kalle-2017-09-15' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Merge ath-current from ath.git Luca Coelho (4): iwlwifi: mvm: use IWL_HCMD_NOCOPY for MCAST_FILTER_CMD iwlwifi: mvm: handle FIF_ALLMULTI when setting multicast

Re: b43: make const arrays static, reduces object code size

Colin Ian King wrote: > From: Colin Ian King > > Don't populate const arrays on the stack, instead make them static. > Makes the object code smaller by over 60 bytes: > > Before: >text data bss dec hex filename >

Re: iwlegacy: make const array static to shink object code size

Colin Ian King wrote: > From: Colin Ian King > > Don't populate const array ac_to_fifo on the stack in an inlined > function, instead make it static. Makes the object code smaller > by over 800 bytes: > >text data bss

Re: mwifiex: make const array tos_to_ac static, reduces object code size

Colin Ian King wrote: > From: Colin Ian King > > Don't populate the read-only const array tos_to_ac on the stack, > instead make it static. Makes the object code smaller by 250 bytes: > > Before: >text data bss dec

Re: [v2] rtl8xxxu: Don't printk raw binary if serial number is not burned in.

Adam Borowski wrote: > I assume that a blank efuse comes with all ones, thus I did not bother > recognizing other possible junk values. This matches 100% of dongles > I've seen (a single Gembird 8192eu). > > Signed-off-by: Adam Borowski Patch applied

Re: brcmsmac: make const array ucode_ofdm_rates static, reduces object code size

Colin Ian King wrote: > From: Colin Ian King > > Don't populate const array ucode_ofdm_rates on the stack, instead make it > static. Makes the object code smaller by 100 bytes: > > Before: >text data bss dec hex

Re: [2/2] ath9k: Avoid a potential deadlock

816] > [ 19.096816] do_IRQ+0x5c/0x120 > [ 19.096816] common_interrupt+0x36/0x3c > [ 19.096816] EIP: _raw_spin_unlock_irqrestore+0x57/0x70 > [ 19.096816] EFLAGS: 0286 CPU: 0 > [ 19.096816] EAX: f60a3600 EBX: 0286 ECX: 0006 EDX: 0001 > [ 19.096816] ESI: f46c9e6

Re: ath10k: make ath10k_hw_ce_regs const

l <bhumi...@gmail.com> > Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> Patch applied to ath-next branch of ath.git, thanks. 496cbf3ebb6b ath10k: make ath10k_hw_ce_regs const -- https://patchwork.kernel.org/patch/9951901/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [8/10] ath9k: Use ARRAY_SIZE macro

s*\[\s*0\s*\]\s*\) > /ARRAY_SIZE(\1)/g' and manual check/verification. > > Signed-off-by: Thomas Meyer <tho...@m3y3r.de> > Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> Patch applied to ath-next branch of ath.git, thanks. 896cbefadf62 ath9k: Use ARRAY_SIZE

Re: [PATCH v4 1/9] brcmsmac: make some local variables 'static const' to reduce stack size

ble backports. > > The other two patches do not need to be backported. > > Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> > Signed-off-by: Arnd Bergmann <a...@arndb.de> I'll queue this and the two following brcmsmac patches for 4.14. Also I'll add (only for this patch): Cc: <sta...@vger.kernel.org> -- Kalle Valo

Re: usb/wireless/rsi_91x: use-after-free write in __run_timers

setup. Apparently you are running syzkaller on QEMU but what I don't understand is how the rsi device comes into the picture. Did you have a rsi usb device connected to the virtual machine or what? Or does syzkaller do some kind of magic here? -- Kalle Valo

Re: [PATCH] brcm80211: make const array ucode_ofdm_rates static, reduces object code size

Arend van Spriel <arend.vanspr...@broadcom.com> writes: > Please use 'brcmsmac:' as prefix instead of 'brcm80211:'. I can fix that. -- Kalle Valo

Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

committing the patch. Yeah, I'll fix that when I commit this. But very good that you pointed it out, I might miss stuff like this. I'll also remove the "wireless:" prefix from the title. -- Kalle Valo

Re: [PATCH] ath10: mark PM functions as __maybe_unused

the #ifdef, this just marks both functions > as __maybe_unused, which is a more robust way to do this. > > Fixes: 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Applied to ath-current branch in ath.git, thanks. (Having problems with my patchwork script so sending this manually) -- Kalle Valo

Re: RTL8192EE PCIe Wireless Network Adapter crashed with linux-4.13

ing > CONFIG_INTEL_IOMMU_DEFAULT_ON also breaks my system. But not all systems have iommu so check from dmesg that iommu is really enabled. -- Kalle Valo

Re: mwifiex: make const arrays static to shink object code size

Colin Ian King wrote: > From: Colin Ian King > > Don't populate const arrays on the stack, instead make them static > Makes the object code smaller by nearly 300 bytes: > > Before: >text data bss dec hex filename >

Re: mwifiex: remove unnecessary call to memset

Himanshu Jha wrote: > call to memset to assign 0 value immediately after allocating > memory with kzalloc is unnecesaary as kzalloc allocates the memory > filled with 0 value. > > Semantic patch used to resolve this issue: > > @@ > expression e,e2; constant c; >

Re: [1/2] b43: fix unitialized reads of ret by initializing the array to zero

Colin Ian King wrote: > From: Colin Ian King > > The u8 char array ret is not being initialized and elements outside > the range start to end contain just garbage values from the stack. > This results in a later scan of the array to read

Re: rsi: fix a dereference on adapter before it has been null checked

Colin Ian King wrote: > From: Colin Ian King > > The assignment of dev is dereferencing adapter before adapter has > been null checked, potentially leading to a null pointer dereference. > Fix this by simply moving the assignment of dev to a

pull-request: wireless-drivers 2017-09-08

Hi Dave, few fixes to net tree for 4.14. Note that this pull request contains the iwlwifi fix Linus hopes to have by end of the merge window. Please let me know if there are any problems. Kalle The following changes since commit 8e0deed92406d93ae0365cb8a6134db5721e7aca: tipc: remove

Re: iwlwifi: mvm: only send LEDS_CMD when the FW supports it

Luciano Coelho wrote: > From: Luca Coelho > > The LEDS_CMD command is only supported in some newer FW versions > (e.g. iwlwifi-8000C-31.ucode), so we can't send it to older versions > (such as iwlwifi-8000C-27.ucode). > > To fix this, check for a new

Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it

Linus Torvalds <torva...@linux-foundation.org> writes: > On Thu, Sep 7, 2017 at 5:39 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> >> Linus, do you want to apply this directly or should we take it via the >> normal route (wireless-drivers -> net)? If your pr

Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it

<luciano.coe...@intel.com> Linus, do you want to apply this directly or should we take it via the normal route (wireless-drivers -> net)? If your prefer the latter when I'm planning to submit this to Dave in a day or two and expecting it to get to your tree in about a week, depending of course what is Dave's schedule. -- Kalle Valo

Re: [PATCH] ath10: mark PM functions as __maybe_unused

the #ifdef, this just marks both functions > as __maybe_unused, which is a more robust way to do this. > > Fixes: 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks. But the title should have "ath10k:", I'll fix that. -- Kalle Valo

stable-kernel-rules: wireless and netdev-FAQ

(adding netdev and lkml) Stanislaw Gruszka <sgrus...@redhat.com> writes: > On Fri, Sep 01, 2017 at 05:31:57PM +0300, Kalle Valo wrote: >> Stanislaw Gruszka <sgrus...@redhat.com> writes: >> >> > On Thu, Aug 31, 2017 at 10:33:28AM -0500, Larry Finger wrote

pull-request: wireless-drivers-next 2017-09-01

memcpy Kalle Valo (2): Merge tag 'iwlwifi-next-for-kalle-2017-08-30' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from git://git.kernel.org/.../kvalo/ath.git Lazar Alexei (1): wil6210: align to latest auto generated wmi.h Liad Kaufman (1): iwlwifi: fix

Re: rtlwifi: rtl8723be: fix duplicated code for different branches

"Gustavo A. R. Silva" wrote: > Refactor code in order to avoid identical code for different branches. > > Addresses-Coverity-ID: 1248728 > Signed-off-by: Gustavo A. R. Silva > Acked-by: Larry Finger Patch applied to

Re: [GIT] Networking

(Adding linux-wireless) Pavel Machek <pa...@ucw.cz> writes: > On Thu 2017-08-31 07:44:58, Kalle Valo wrote: >> David Miller <da...@davemloft.net> writes: >> >> > From: Kalle Valo <kv...@codeaurora.org> >> > Date: Wed, 30 Aug 2017 20:3

Re: [GIT] Networking

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Wed, 30 Aug 2017 20:31:31 +0300 > >> AFAICS the bug was introduced by 9df86e2e702c6 back in 2010. If the bug >> has been there for 7 years so waiting for a

Re: [GIT] Networking

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Wed, 30 Aug 2017 17:45:31 +0300 > >> Pavel Machek <pa...@ucw.cz> writes: >> >>> Could we get this one in? >>> >>> wl1251 miss

Re: rsi: remove memset before memcpy

Himanshu Jha wrote: > calling memcpy immediately after memset with the same region of memory > makes memset redundant. > > Signed-off-by: Himanshu Jha Patch applied to wireless-drivers-next.git, thanks. 66a3479e1217 rsi: remove memset

Re: [GIT] Networking

ext and will be in 4.14-rc1: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=6e9aae179f290f1a44fce7ef8e9a8e2dd68ed1e4 -- Kalle Valo

pull-request: wireless-drivers-next 2017-08-28

useless condition in LED code iwlwifi: mvm: use firmware LED command where applicable João Paulo Rechi Vita (1): iwlwifi: Demote messages about fw flags size to info Kalle Valo (4): Merge tag 'iwlwifi-next-for-kalle-2017-08-11' of git://git.kernel.org/.../iwlwifi/iwlwifi-next

pull-request: wireless-drivers 2017-08-25

Hi Dave, here's pull request to net tree for 4.13, more info in the signed tag below. Please let me know if there are any problems. Kalle The following changes since commit e9bf53ab1ee34bb05c104bbfd2b77c844773f8e6: brcmfmac: feature check for multi-scheduled scan fails on bcm4343x devices

Re: wireless: ipw2x00: make iw_handler_def const

Bhumika Goyal wrote: > Make these const as they are only stored in the const field of a > net_device structure. > > Signed-off-by: Bhumika Goyal Patch applied to wireless-drivers-next.git, thanks. 2c1dca3c6b22 wireless: ipw2x00: make iw_handler_def

Re: [1/3] net: rtlwifi: constify rate_control_ops

Arvind Yadav wrote: > rate_control_ops are not supposed to change at runtime. All functions > working with rate_control_ops provided by work with > const rate_control_ops. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav

Re: [RESEND,v12,7/8] wireless: ipw2200: Replace PCI pool old API

Romain Perier wrote: > The PCI pool API is deprecated. This commit replaces the PCI pool old > API by the appropriate function with the DMA pool API. > > Signed-off-by: Romain Perier > Reviewed-by: Peter Senna Tschudin

Re: rtlwifi: rtl8821ae: fix spelling mistake: "faill" -> "failed"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in RT_TRACE message > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 2cc8918eb987 rtlwifi:

Re: [v2] mt7601u: check memory allocation failure

Christophe Jaillet wrote: > Check memory allocation failure and return -ENOMEM in such a case, as > already done a few lines below. > > As 'dev->tx_q' can be NULL, we also need to check for that in > 'mt7601u_free_tx()', and return early. > > Signed-off-by:

Re: rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches

"Gustavo A. R. Silva" wrote: > Refactor code in order to avoid identical code for different branches. > > This issue was detected with the help of Coccinelle. > > Addresses-Coverity-ID: 1415177 > Signed-off-by: Gustavo A. R. Silva Patch applied

Re: [PATCH v2] at76c50x-usb: check memory allocation failure

ges and the current error handling looks the correct approach. There is not much anything else we can do than just skip the message printout. -- Kalle Valo

Re: [PATCH 3/3 v2] net: netlink: constify genl_ops

1da tipc: fix nametbl deadlock at tipc_nametbl_unsubscribe cdfbabfb2f0c net: Work around lockdep limitation in sockets that use sockets 174cd4b1e5fb sched/headers: Prepare to move signal wakeup & sigpending methods from into -- Kalle Valo

Re: [PATCH 3/3] net: rsi: netlink: constify genl_ops

l.com> > --- > net/tipc/netlink_compat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Using the prefix "rsi:" looks wrong for this patch. -- Kalle Valo

Re: [PATCH] drivers: net: wireless: atmel: check memory allocation failure

tation/submittingpatches#commit_title_is_wrong -- Kalle Valo

Re: [PATCH v12 7/8] wireless: ipw2200: Replace PCI pool old API

hence it's not on my queue. Please resend. [1] https://patchwork.kernel.org/project/linux-wireless/list/ -- Kalle Valo

pull-request: wireless-drivers 2017-08-15

race happens in A-MPDU Gregory Greenman (2): iwlwifi: mvm: set A-MPDU bit upon empty BA notification from FW iwlwifi: mvm: rs: fix TLC statistics collection Haim Dreyfuss (1): iwlwifi: fix fw_pre_next_step to apply also for C step Kalle Valo (2): Merge tag 'iwlwifi-for-kalle

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

Kalle Valo <kv...@codeaurora.org> writes: > Andreas Born <futur.a...@googlemail.com> writes: > >> Earlier today I submitted the patch (bonding: require speed/duplex >> only for 802.3ad, alb and tlb) [2] that only partially reverts what is >> a regressi

Re: [v2,02/20] ath6kl: constify usb_device_id

rvind.yadav...@gmail.com> > Reviewed-by: Steve deRosier <deros...@gmail.com> > Tested-by: Steve deRosier <deros...@gmail.com> > Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> 2 patches applied to ath-next branch of ath.git, thanks. e881a6584941 ath6kl: constify us

Re: [v3,06/20] brcm80211: constify usb_device_id

Arvind Yadav wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

he patch submission and that's why I'm asking. -- Kalle Valo

Re: [v2,06/20] brcm80211: constify usb_device_id

Arvind Yadav wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav

Re: [v2,01/20] ar5523: constify usb_device_id

Arvind Yadav wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav 17

Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

release. -- Kalle Valo

Re: [PATCH 00/35] constify net usb_device_id

[PATCH 16/35] ar5523: constify usb_device_id [PATCH 17/35] ath6kl: constify usb_device_id [PATCH 18/35] ath9k: constify usb_device_id Please resubmit the wireless patches separately in their own patchset. -- Kalle Valo

Re: [1/2] wlcore: add const to bin_attribute structure

Bhumika Goyal wrote: > Add const to bin_attribute structure as it is only passed to the > functions sysfs_{remove/create}_bin_file. The corresponding arguments > are of type const, so declare the structure to be const. > > Signed-off-by: Bhumika Goyal

Re: [v2] rtlwifi: constify rate_control_ops structure

Bhumika Goyal wrote: > rate_control_ops structure is only passed as an argument to the > function ieee80211_rate_control_{register/unregister}. This argument > is of type const, so declare the structure as const. > > Signed-off-by: Bhumika Goyal Patch

Re: ath9k: make ath_ps_ops structures as const

Bhumika Goyal <bhumi...@gmail.com> wrote: > ath_ps_ops structures are only stored as a reference in the ps_ops > field of a ath_common structure. This field is of type const, so make > the structures as const. > > Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> >

Re: wcn36xx: Introduce mutual exclusion of fw configuration

to be ensured with > sta_remove(). > > This is done by introducing a mutex to cover firmware configuration > changes, which is made to also ensure mutual exclusion between other > operations changing the state or configuration of the firmware. With > this we can drop the rcu r

Re: [v3] ath10k: ath10k_htt_rx_amsdu_allowed() use ath10k_dbg()

k_dbg() here too. > > Signed-off-by: Gabriel Craciunescu <nix.or....@gmail.com> > Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> Patch applied to ath-next branch of ath.git, thanks. 984eb9053280 ath10k: ath10k_htt_rx_amsdu_allowed() use ath10k_dbg() -- https://patchwork.kerne

pull-request: wireless-drivers-next 2017-08-07

lwifi: mvm: require AP_LINK_PS for TVQM iwlwifi: mvm: simplify bufferable MMPDU check iwlwifi: mvm: remove non-DQA mode Kalle Valo (3): ath10k: fix indenting in ath10k_wmi_update_noa() Merge ath-next from git://git.kernel.org/.../kvalo/ath.git Merge tag 'iwlwif

Re: [049/102] ath10k: explicitly request exclusive reset control

t; control behavior. Convert all drivers requesting exclusive resets to the > explicit API call so the temporary transition helpers can be removed. > > No functional changes. > > Cc: Kalle Valo <kv...@qca.qualcomm.com> > Cc: ath...@lists.infradead.org > Cc: linux-wirel..

Re: [10/11] net: qtnfmac: constify pci_device_id.

Arvind Yadav wrote: > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav >

Re: qtfnmac: Tidy up DMA mask setting

Robin Murphy wrote: > As the only caller of dma_supported() outside of DMA API internals, the > qtfnmac driver stands out and invites scrutiny. Thankfully, it's not > being used for evil, but it is entirely redundant, since it open-codes a > check that the DMA mask setting

Re: [net] hostap: Fix outdated comment about dev->destructor

Stefano Brivio wrote: > After commit cf124db566e6 ("net: Fix inconsistent teardown and > release of private netdev state."), setting > 'dev->needs_free_netdev' ensures device data is released, and > 'dev->destructor' is not used anymore. > > Fixes: cf124db566e6 ("net: Fix

Re: [01/11] rtlwifi: rtl8192de: constify pci_device_id.

Arvind Yadav wrote: > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. > > File size before: >text data bss dec

Re: qtnfmac: Tidy up DMA mask setting

Robin Murphy wrote: > As the only caller of dma_supported() outside of DMA API internals, the > qtfnmac driver stands out and invites scrutiny. Thankfully, it's not > being used for evil, but it is entirely redundant, since it open-codes a > check that the DMA mask setting

Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function

pery slope and best to clean that up before adding any new API. > > That and also Greg recently stated he would like to see at least 3 users of > a feature before adding it. Although I think that's pretty arbitrary, and > considering that request_firmware_into_buf() only has *one* user -- its what > he wishes. ath10k at least needs a way to silence the warning for missing firmware and I think iwlwifi also. -- Kalle Valo

Re: [v3,04/10] ipw2200: constify attribute_group structures

Kalle Valo <kv...@codeaurora.org> writes: > Kalle Valo <kv...@codeaurora.org> writes: > >> Arvind Yadav <arvind.yadav...@gmail.com> wrote: >> >>> attribute_group are not supposed to change at runtime. All functions >>> working with attribute_

Re: rt2x00: make const array glrt_table static

Kalle Valo <kv...@codeaurora.org> writes: > Colin Ian King <colin.k...@canonical.com> wrote: > >> From: Colin Ian King <colin.k...@canonical.com> >> >> Don't populate array glrt_table on the stack but make it static. >> Makes the object code a smal

Re: [v3,04/10] ipw2200: constify attribute_group structures

Kalle Valo <kv...@codeaurora.org> writes: > Arvind Yadav <arvind.yadav...@gmail.com> wrote: > >> attribute_group are not supposed to change at runtime. All functions >> working with attribute_group provided by work >> with const attribute_group. So

Re: wl3501_cs: fix spelling mistake: "Insupported" -> "Unsupported"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in printk message > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. fcc870d76a2c wl3501_cs: fix

Re: [v3,04/10] ipw2200: constify attribute_group structures

Arvind Yadav wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by work > with const attribute_group. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav

Re: [11/11] brcmfmac: constify pci_device_id

Arvind Yadav wrote: > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav >

Re: zd1211rw: fix spelling mistake 'hybernate' -> 'hibernate'

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in PDEBUG debug message. > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. af643fe9bbe0

Re: rt2x00: make const array glrt_table static

Colin Ian King wrote: > From: Colin Ian King > > Don't populate array glrt_table on the stack but make it static. > Makes the object code a smaller by over 670 bytes: > > Before: >text data bss dec hex filename >

Re: mwifiex: fix spelling mistake: "Insuffient" -> "Insufficient"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in mwifiex_dbg debug message > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 17830147c40a

Re: mwifiex: usb: fix spelling mistake: "aggreataon"-> "aggregation"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in aggr_ctrl module parameter > message text. > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks.

Re: [v2] mwifiex: uninit wakeup info in the error handling

Jeffy Chen wrote: > We inited wakeup info at the beginning of mwifiex_add_card, so we need > to uninit it in the error handling. > > It's much the same as what we did in: > 36908c4 mwifiex: uninit wakeup info when removing device > > Signed-off-by: Jeffy Chen

Re: mwifiex: fix compile warning of unused variable

Shawn Lin wrote: > We got a compile warning shows below: > > drivers/net/wireless/marvell/mwifiex/sdio.c: In function > 'mwifiex_sdio_remove': > drivers/net/wireless/marvell/mwifiex/sdio.c:377:6: warning: variable > 'ret' set but not used [-Wunused-but-set-variable] >

Re: pull-request: wireless-drivers-next 2017-07-28

Kalle Valo <kv...@codeaurora.org> writes: > Hi Dave, > > here's a pull request for net, more info the signed tag below. Please > let me know if there are any problems. > > Kalle > > The following changes since commit d755cbc26e8295ae8e5d30425364e093b4247a85: >

pull-request: wireless-drivers-next 2017-07-28

Hi Dave, here's a pull request for net, more info the signed tag below. Please let me know if there are any problems. Kalle The following changes since commit d755cbc26e8295ae8e5d30425364e093b4247a85: Merge tag 'iwlwifi-for-kalle-2017-07-21' of

Re: [net] wl1251: add a missing spin_lock_init()

start_xmit+0x454/0x8c8) > [ 5668.776824] [] (__ieee80211_subif_start_xmit) from > [] (ieee80211_subif_start_xmit+0x30/0x2fc) > [ 5668.777343] [] (ieee80211_subif_start_xmit) from > [] (dev_hard_start_xmit+0x80/0x118) > ... > > by adding the missing spin_lock_init(). > >

Re: [-next] rtlwifi: kfree entry until after entry->bssid has been accessed

Colin Ian King wrote: > From: Colin Ian King > > The current code kfree's entry and then dereferences it by accessing > entry->bssid. Avoid the dereference-after-free by moving the kfree > after the access to entry->bssid. > > Detected by

Re: [PATCH] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

ed. > + - interrupts : specifies attributes for the out-of-band interrupt > (host-wake). > + When not specified the device will use in-band SDIO interrupts. Where is the driver which uses this? I don't see it in drivers/net/wireless but I guess that's not a blocker for the bindings? -- Kalle Valo

Re: [PATCH v2 00/10] Constify attribute_group structures

structures. > [PATCH v2 10/10] net: chelsio: cxgb3: constify attribute_group structures. Via which tree were you planning to push these? Is it ok if I take the wireless patches to my tree? -- Kalle Valo

Re: [PATCH] mwifiex: fix compile warning of unused variable

h accordingly. (W=1 warnings are not that important so they go automatically to -next) -- Kalle Valo

pull-request: wireless-drivers 2017-07-21

dereference of error in recovery iwlwifi: fix tracing when tx only is enabled Johannes Berg (1): iwlwifi: mvm: defer setting IWL_MVM_STATUS_IN_HW_RESTART Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2017-07-21' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Larry Finger (1

Re: [Patch net] wl1251: add a missing spin_lock_init()

, .owner: /-1, >> .owner_cpu: 0 > ... >> by adding the missing spin_lock_init(). >> >> Reported-by: Pavel Machek <pa...@ucw.cz> >> Cc: Kalle Valo <kv...@codeaurora.org> >> Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com> > >

Re: ath10k: ret used but uninitialized

* through the loop again due to updated lookaheads. Set @@ -721,11 +725,7 @@ static int ath10k_sdio_mbox_rxmsg_pending_handler(struct ath10k *ar, *done = false; } - if (ret && (ret != -ECANCELED)) - ath10k_warn(ar, "failed to get pending recv messages: %d\n", - ret); - - return ret; + return 0; } static int ath10k_sdio_mbox_proc_dbg_intr(struct ath10k *ar) -- Kalle Valo

<    1   2   3   4   5   6   7   8   9   10   >