Re: [PATCH 27/29] ath9k: ar5008_initvals: Move ar5416Bank{0,1,2,3,7} to where they are used

2020-09-10 Thread Kalle Valo
> | ^~~ > drivers/net/wireless/ath/ath9k/ar5008_initvals.h:462:18: warning: > ‘ar5416Bank0’ defined but not used [-Wunused-const-variable=] > 462 | static const u32 ar5416Bank0[][2] = { > | ^~~ > > Cc: QCA ath9k Development > Cc: Kalle Valo > Cc:

Re: [PATCH 26/29] ath9k: ar5008_initvals: Remove unused table entirely

2020-09-10 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/ath/ath9k/ar5008_initvals.h:553:18: warning: > ‘ar5416Bank6’ defined but not used [-Wunused-const-variable=] > > Cc: QCA ath9k Development > Cc: Kalle Valo > Cc: "

Re: [PATCH 25/29] ath9k: ar9001_initvals: Remove unused array 'ar5416Bank6_9100'

2020-09-10 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/ath/ath9k/ar9001_initvals.h:462:18: warning: > ‘ar5416Bank6_9100’ defined but not used [-Wunused-const-variable=] > > Cc: QCA ath9k Development > Cc: Kalle Valo > Cc: "

Re: [PATCH 24/29] ath9k: ar9002_initvals: Remove unused array 'ar9280PciePhy_clkreq_off_L1_9280'

2020-09-10 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/ath/ath9k/ar9002_initvals.h:900:18: warning: > ‘ar9280PciePhy_clkreq_off_L1_9280’ defined but not used > [-Wunused-const-variable=] > > Cc: QCA ath9k Development > Cc: Ka

Re: [PATCH 23/29] ath6kl: wmi: Remove unused variable 'rate'

2020-09-10 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/ath/ath6kl/wmi.c: In function > ‘ath6kl_wmi_bitrate_reply_rx’: > drivers/net/wireless/ath/ath6kl/wmi.c:1204:6: warning: variable ‘rate’ set > but not used [-Wunused-but-set-variab

pull-request: wireless-drivers-2020-09-09

2020-09-09 Thread Kalle Valo
Hi, here's a pull request to net tree, more info below. Please let me know if there are any problems. Kalle The following changes since commit 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5: Linux 5.9-rc1 (2020-08-16 13:04:57 -0700) are available in the git repository at: git://git.kernel.org/p

Re: [PATCH v2] rtlwifi: switch from 'pci_' to 'dma_' API

2020-09-09 Thread Kalle Valo
Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > The only file where some GFP_ flags ar

Re: [PATCH v2] brcmsmac: fix memory leak in wlc_phy_attach_lcnphy

2020-09-09 Thread Kalle Valo
Keita Suzuki wrote: > When wlc_phy_txpwr_srom_read_lcnphy fails in wlc_phy_attach_lcnphy, > the allocated pi->u.pi_lcnphy is leaked, since struct brcms_phy will be > freed in the caller function. > > Fix this by calling wlc_phy_detach_lcnphy in the error handler of > wlc_phy_txpwr_srom_read_lcnp

Re: [PATCH] mwifiex: remove function pointer check

2020-09-09 Thread Kalle Valo
t...@redhat.com wrote: > From: Tom Rix > > clang static analyzer reports this problem > > init.c:739:8: warning: Called function pointer > is null (null dereference) > ret = adapter->if_ops.check_fw_status( ... > ^ > > In mwifiex_dnld_fw,

Re: [PATCH] rtl8xxxu: prevent potential memory leak

2020-09-09 Thread Kalle Valo
Chris Chiu wrote: > Free the skb if usb_submit_urb fails on rx_urb. And free the urb > no matter usb_submit_urb succeeds or not in rtl8xxxu_submit_int_urb. > > Signed-off-by: Chris Chiu Patch applied to wireless-drivers-next.git, thanks. 86279456a4d4 rtl8xxxu: prevent potential memory leak -

Re: [PATCH 16/28] wireless: marvell: mwifiex: init: Move 'tos_to_tid_inv' to where it's used

2020-09-08 Thread Kalle Valo
Lee Jones writes: > On Mon, 31 Aug 2020, Kalle Valo wrote: > >> Lee Jones wrote: >> >> > 'tos_to_tid_inv' is only used in 2 of 17 files it's current being >> > included into. >> > >> > Fixes the following W=1 kernel bui

Re: [PATCH] ath11k: fix a double free and a memory leak

2020-09-07 Thread Kalle Valo
_free > misses releasing ar->mac.sbands[NL80211_BAND_6GHZ].channels > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Signed-off-by: Tom Rix > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks.

Re: [PATCH 01/16] wireless: ath5k: convert tasklets to use new tasklet_setup() API

2020-09-07 Thread Kalle Valo
pass the tasklet pointer explicitly. >> > >> > Signed-off-by: Romain Perier >> > Signed-off-by: Allen Pais >> > Signed-off-by: Kalle Valo >> >> Patch applied to ath-next branch of ath.git, thanks. >> >> c068a9ec3c94 ath5k:

Re: [PATCH v3 1/3] brcmfmac: increase F2 watermark for BCM4329

2020-09-07 Thread Kalle Valo
Dmitry Osipenko wrote: > This patch fixes SDHCI CRC errors during of RX throughput testing on > BCM4329 chip if SDIO BUS is clocked above 25MHz. In particular the > checksum problem is observed on NVIDIA Tegra20 SoCs. The good watermark > value is borrowed from downstream BCMDHD driver and it's m

Re: Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver"

2020-09-07 Thread Kalle Valo
Mauro Carvalho Chehab wrote: > This patch causes a regression betwen Kernel 5.7 and 5.8 at wlcore: > with it applied, WiFi stops working, and the Kernel starts printing > this message every second: > >wlcore: PHY firmware version: Rev 8.2.0.0.242 >wlcore: firmware booted (Rev 8.9.0.0.79)

Re: [PATCH] Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver"

2020-09-07 Thread Kalle Valo
Mauro Carvalho Chehab wrote: > This patch causes a regression betwen Kernel 5.7 and 5.8 at wlcore: > with it applied, WiFi stops working, and the Kernel starts printing > this message every second: > >wlcore: PHY firmware version: Rev 8.2.0.0.242 >wlcore: firmware booted (Rev 8.9.0.0.79)

Re: [PATCH] mwifiex: sdio: Fix -Wunused-const-variable warnings

2020-09-07 Thread Kalle Valo
YueHaibing wrote: > These variables only used in sdio.c, move them to .c file > can silence these warnings: > > In file included from drivers/net/wireless/marvell/mwifiex//main.h:59:0, > from drivers/net/wireless/marvell/mwifiex//cfp.c:24: > drivers/net/wireless/marvell/mwifiex/

Re: [PATCH] mwifiex: pcie: Fix -Wunused-const-variable warnings

2020-09-07 Thread Kalle Valo
YueHaibing wrote: > These variables only used in pcie.c, move them to .c file > can silence these warnings: > > In file included from drivers/net/wireless/marvell/mwifiex/main.h:57:0, > from drivers/net/wireless/marvell/mwifiex/init.c:24: > drivers/net/wireless/marvell/mwifiex/p

Re: [PATCH] mwifiex: wmm: Fix -Wunused-const-variable warnings

2020-09-07 Thread Kalle Valo
YueHaibing wrote: > In file included from drivers/net/wireless/marvell/mwifiex//cmdevt.c:26:0: > drivers/net/wireless/marvell/mwifiex//wmm.h:41:17: warning: ‘tos_to_tid_inv’ > defined but not used [-Wunused-const-variable=] > static const u8 tos_to_tid_inv[] = { > ^

Re: [PATCH][next] mt7601u: Use fallthrough pseudo-keyword

2020-09-07 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highl

Re: [PATCH] mwifiex: Remove unnecessary braces from HostCmd_SET_SEQ_NO_BSS_INFO

2020-09-07 Thread Kalle Valo
Nathan Chancellor wrote: > A new warning in clang points out when macro expansion might result in a > GNU C statement expression. There is an instance of this in the mwifiex > driver: > > drivers/net/wireless/marvell/mwifiex/cmdevt.c:217:34: warning: '}' and > ')' tokens terminating statement ex

Re: [EXTERNAL] Re: [PATCH] Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver"

2020-09-01 Thread Kalle Valo
"Bouganim, Raz" writes: > We are going to release a new FW version 8.9.0.0.83 that contains > support with the new IGTK key. > > In addition, we also going to release a new patch that mandates the > driver to work with an 8.9.0.0.83 FW version or above. > > We going to push it today/tomorrow. Yo

Re: [11/30] zd1211rw: zd_chip: Correct misspelled function argument

2020-09-01 Thread Kalle Valo
ip.c:1385: warning: Excess function > parameter 'rx_status' description in 'zd_rx_rate' > > Cc: Daniel Drake > Cc: Ulrich Kunitz > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: linux-wirel...@vger.kernel.org > Cc: netdev

Re: [27/30] brcmsmac: phy_lcn: Remove a bunch of unused variables

2020-09-01 Thread Kalle Valo
less/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c: In function > ‘wlc_phy_txpwr_srom_read_lcnphy’: > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:4919:7: > warning: variable ‘opo’ set but not used [-Wunused-but-set-variable] > > Cc: Arend van Spriel > Cc: Franky Lin

Re: [PATCH] libertas_tf: Remove unused macro QOS_CONTROL_LEN

2020-09-01 Thread Kalle Valo
YueHaibing wrote: > There is no caller in tree. > > Signed-off-by: YueHaibing Patch applied to wireless-drivers-next.git, thanks. 2c92790b1203 libertas_tf: Remove unused macro QOS_CONTROL_LEN -- https://patchwork.kernel.org/patch/11744379/ https://wireless.wiki.kernel.org/en/developers/doc

Re: [24/30] mwifiex: wmm: Mark 'mwifiex_1d_to_wmm_queue' as __maybe_unused

2020-09-01 Thread Kalle Valo
wifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 > }; > | ^~~ > > NB: Many entries - snipped for brevity. > > Cc: Amitkumar Karwar > Cc: Ganapathi Bhat > Cc: Xinming Hu > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Ki

Re: [01/30] mwifiex: pcie: Move tables to the only place they're used

2020-09-01 Thread Kalle Valo
ot used [-Wunused-const-variable=] > 292 | static const struct mwifiex_pcie_device mwifiex_pcie8766 = { > | ^~~~ > > NB: Repeats 10's of times - snipped for brevity. > > Cc: Amitkumar Karwar > Cc: Ganapathi Bhat > Cc: Xinming Hu > Cc: Kalle Valo &

Re: [PATCH] ath6kl: wmi: remove set but not used 'rate'

2020-09-01 Thread Kalle Valo
Jason Yan writes: > This addresses the following gcc warning with "make W=1": > > drivers/net/wireless/ath/ath6kl/wmi.c: In function > ‘ath6kl_wmi_bitrate_reply_rx’: > drivers/net/wireless/ath/ath6kl/wmi.c:1204:6: warning: variable ‘rate’ > set but not used [-Wunused-but-set-variable] > 1204 |

Re: [PATCH v2 1/2] ath10k: Keep track of which interrupts fired, don't poll them

2020-09-01 Thread Kalle Valo
Doug Anderson writes: > On Wed, Aug 26, 2020 at 7:51 AM Kalle Valo wrote: >> >> Douglas Anderson wrote: >> >> > If we have a per CE (Copy Engine) IRQ then we have no summary >> > register. Right now the code generates a summary register by >> &g

Re: [PATCH v2 1/2] ath10k: Keep track of which interrupts fired, don't poll them

2020-09-01 Thread Kalle Valo
t keep track > of the IRQs that fire. Then we can effectively generate our own > summary without ever needing to read the Copy Engines. > > Tested-on: WCN3990 SNOC WLAN.HL.3.2.2-00490-QCAHLSWMTPL-1 > > Signed-off-by: Douglas Anderson > Reviewed-by: Rakesh Pillai > Reviewed-by:

Re: [PATCH][next] rtlwifi: Use fallthrough pseudo-keyword

2020-09-01 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH] rtlwifi: switch from 'pci_' to 'dma_' API

2020-09-01 Thread Kalle Valo
Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > The only file where some GFP_ flags ar

Re: [PATCH] rtl818x_pci: switch from 'pci_' to 'dma_' API

2020-09-01 Thread Kalle Valo
Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When memory is allocated in 'rtl8180_i

Re: p54: avoid accessing the data mapped to streaming DMA

2020-09-01 Thread Kalle Valo
Jia-Ju Bai wrote: > In p54p_tx(), skb->data is mapped to streaming DMA on line 337: > mapping = pci_map_single(..., skb->data, ...); > > Then skb->data is accessed on line 349: > desc->device_addr = ((struct p54_hdr *)skb->data)->req_id; > > This access may cause data inconsistency between

Re: [PATCH] Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver"

2020-09-01 Thread Kalle Valo
Mauro Carvalho Chehab wrote: > This patch causes a regression betwen Kernel 5.7 and 5.8 at wlcore: > with it applied, WiFi stops working, and the Kernel starts printing > this message every second: > >wlcore: PHY firmware version: Rev 8.2.0.0.242 >wlcore: firmware booted (Rev 8.9.0.0.79)

Re: [PATCH][next] mediatek: Use fallthrough pseudo-keyword

2020-09-01 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highl

Re: [PATCH 12/16] wireless: mediatek: convert tasklets to use new tasklet_setup() API

2020-09-01 Thread Kalle Valo
Allen Pais wrote: > From: Allen Pais > > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-off-by: Romain Perier > Signed-of

Re: [16/32] brcmfmac: btcoex: Update 'brcmf_btcoex_state' and demote others

2020-09-01 Thread Kalle Valo
cm80211/brcmfmac/btcoex.c:453: warning: > Excess function parameter 'cfg' description in 'brcmf_btcoex_set_mode' > > Cc: Arend van Spriel > Cc: Franky Lin > Cc: Hante Meuleman > Cc: Chi-Hsien Lin > Cc: Wright Feng > Cc: Kalle Valo > Cc: "Da

Re: [02/32] rsi: Add description for function param 'sta'

2020-09-01 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/rsi/rsi_91x_mac80211.c:1021: warning: Function > parameter or member 'sta' not described in 'rsi_mac80211_set_key' > > Cc: Amitkumar Karwar > Cc: Siva Rebb

Re: [PATCH 01/32] wireless: marvell: mwifiex: sdio: Move 'static const struct's into their own header file

2020-09-01 Thread Kalle Valo
were 100's of these - snipped for brevity. > > Cc: Amitkumar Karwar > Cc: Ganapathi Bhat > Cc: Xinming Hu > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: linux-wirel...@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-of

Re: [PATCH 00/32] Set 2: Rid W=1 warnings in Wireless

2020-09-01 Thread Kalle Valo
Lee Jones writes: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > There are quite a few W=1 warnings in the Wireless. My plan > is to work through all of them over the next few weeks.

Re: [15/28] mt7601u: phy: Fix misnaming when documented function parameter 'dac'

2020-09-01 Thread Kalle Valo
hy.c:1216: warning: Excess function > parameter 'path' description in 'mt7601u_set_tx_dac' > > Cc: Jakub Kicinski > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Matthias Brugger > Cc: Felix Fietkau > Cc: linux-wirel...@vger.kernel.org > Cc

Re: [01/28] hostap: Mark 'freq_list' as __maybe_unused

2020-09-01 Thread Kalle Valo
et/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ > defined but not used [-Wunused-const-variable=] > > Cc: Jouni Malinen > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: linux-wirel...@vger.kernel.org > Cc: netdev@vger.kernel

Re: [PATCH 16/28] wireless: marvell: mwifiex: init: Move 'tos_to_tid_inv' to where it's used

2020-08-31 Thread Kalle Valo
ariable=] > 41 | static const u8 tos_to_tid_inv[] = { > > NB: Snipped for brevity > > Cc: Amitkumar Karwar > Cc: Ganapathi Bhat > Cc: Xinming Hu > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: linux-wirel...@vger.kernel.org &g

Re: [PATCH v2 08/30] net: wireless: ath: carl9170: Convert 'ar9170_qmap' to inline function

2020-08-31 Thread Kalle Valo
lots of these repeat > > Cc: Christian Lamparter > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Johannes Berg > Cc: linux-wirel...@vger.kernel.org > Cc: netdev@vger.kernel.org > Suggested-by: Rasmus Villemoes > Signed-off-by: Lee

Re: [PATCH][next] ath10k: wmi: Use struct_size() helper in ath10k_wmi_alloc_skb()

2020-08-31 Thread Kalle Valo
fixed manually. > > Signed-off-by: Gustavo A. R. Silva > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. e96eecdb290a ath10k: wmi: Use struct_size() helper in ath10k_wmi_alloc_skb() -- https://patchwork.kernel.org/patch/11608745/ https://w

Re: [PATCH v2 25/32] wireless: ath: wil6210: wmi: Fix formatting and demote non-conforming function headers

2020-08-31 Thread Kalle Valo
not described in 'wmi_evt_ignore' > drivers/net/wireless/ath/wil6210/wmi.c:1876: warning: Function parameter or > member 'd' not described in 'wmi_evt_ignore' > drivers/net/wireless/ath/wil6210/wmi.c:1876: warning: Function parameter or > member 'l

Re: [PATCH][next] ath11k: fix spelling mistake "moniter" -> "monitor"

2020-08-31 Thread Kalle Valo
Colin King wrote: > There is a spelling mistake in an ath11k_warn warning message. Fix it. > > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. bd5dd7aaa4c0 ath11k: fix spelling mistake "moniter" -

Re: [PATCH][next] ath11k: fix missing error check on call to ath11k_pci_get_user_msi_assignment

2020-08-31 Thread Kalle Valo
check after the call. > > Addresses-Coverity: ("Division or modulo by zero") > Fixes: d4ecb90b3857 ("ath11k: enable DP interrupt setup for QCA6390") > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks.

Re: [PATCH 04/16] wireless: ath11k: convert tasklets to use new tasklet_setup() API

2020-08-31 Thread Kalle Valo
Allen Pais wrote: > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-off-by: Allen Pais > Signed-off-b

Re: [PATCH v2 08/30] net: wireless: ath: carl9170: Convert 'ar9170_qmap' to inline function

2020-08-31 Thread Kalle Valo
1:17: warning: >> ‘ar9170_qmap’ defined but not used [-Wunused-const-variable=] >> >> NB: Snipped - lots of these repeat >> >> Cc: Christian Lamparter >> Cc: Kalle Valo >> Cc: "David S. Miller" >> Cc: Jakub Kicinski >> Cc: Joha

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-28 Thread Kalle Valo
Lee Jones writes: > On Fri, 28 Aug 2020, Kalle Valo wrote: > >> Ondrej Zary writes: >> >> > On Thursday 27 August 2020 09:49:12 Kalle Valo wrote: >> >> Ondrej Zary writes: >> >> >> >> > On Monday 17 August 2020 20:27:06 J

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-28 Thread Kalle Valo
Ondrej Zary writes: > On Thursday 27 August 2020 09:49:12 Kalle Valo wrote: >> Ondrej Zary writes: >> >> > On Monday 17 August 2020 20:27:06 Jesse Brandeburg wrote: >> >> On Mon, 17 Aug 2020 16:27:01 +0300 >> >> Kalle Valo wrote: >> >

Re: [PATCH] Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver"

2020-08-28 Thread Kalle Valo
Steve deRosier writes: > On Tue, Aug 25, 2020 at 10:49 PM Mauro Carvalho Chehab > wrote: >> >> This patch causes a regression betwen Kernel 5.7 and 5.8 at wlcore: >> with it applied, WiFi stops working, and the Kernel starts printing >> this message every second: >> >>wlcore: PHY firmware ve

Re: [PATCH][next] ath11k: fix error check on return from call to ath11k_core_firmware_request

2020-08-27 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > The call to ath11k_core_firmware_request is returning a pointer that > can be set to an error code, however, this is not being checked. > Instead ret is being incorrecly checked for the error return. Fix the > error checking. > > Addresses-Coverity:

Re: [PATCH 12/30] wireless: ath: wil6210: wmi: Correct misnamed function parameter 'ptr_'

2020-08-27 Thread Kalle Valo
Lee Jones writes: > On Thu, 27 Aug 2020, Lee Jones wrote: > >> On Wed, 26 Aug 2020, Kalle Valo wrote: >> >> > Lee Jones wrote: >> > >> > > Fixes the following W=1 kernel build warning(s): >> > > >> > > drivers/net/wire

Re: [PATCH 00/30] Set 3: Rid W=1 warnings in Wireless

2020-08-27 Thread Kalle Valo
Lee Jones writes: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > There are quite a few W=1 warnings in the Wireless. My plan > is to work through all of them over the next few weeks.

Re: [PATCH][next] prism54: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH][next] orinoco: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH][next] iwlegacy: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH][next] b43: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH][next] atmel: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH][next] b43legacy: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [05/16] atmel: convert tasklets to use new tasklet_setup() API

2020-08-27 Thread Kalle Valo
Allen Pais wrote: > From: Allen Pais > > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly > and remove .data field. > > Signed-off-by: R

Re: [net] mwifiex: Increase AES key storage size to 256 bits

2020-08-27 Thread Kalle Valo
Maximilian Luz wrote: > Following commit e18696786548 ("mwifiex: Prevent memory corruption > handling keys") the mwifiex driver fails to authenticate with certain > networks, specifically networks with 256 bit keys, and repeatedly asks > for the password. The kernel log repeats the following line

Re: [PATCH][next] brcmfmac: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highl

Re: [PATCH][next] rt2x00: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highl

Re: [PATCH 05/30] atmel: Demote non-kerneldoc header to standard comment block

2020-08-27 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/atmel/atmel.c:4232: warning: Cannot understand This > file is part of net.russotto.AtmelMACFW, hereto referred to > > Cc: Simon Kelley > Cc: Kalle Valo > Cc: "

Re: [PATCH 03/16] wireless: ath: convert tasklets to use new tasklet_setup() API

2020-08-27 Thread Kalle Valo
ed-off-by: Allen Pais > Acked-by: Christian Lamparter > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. de7dbc2dbef7 carl9170: convert tasklets to use new tasklet_setup() API -- https://patchwork.kernel.org/patch/11717455/ https://wireless.wiki.kernel.org/

Re: [PATCH 21/28] wireless: ath: wil6210: debugfs: Fix a couple of formatting issues in 'wil6210_debugfs_init'

2020-08-27 Thread Kalle Valo
; > drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function parameter > or member 'base' not described in 'wil6210_debugfs_init_offset' > drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function parameter > or member 'tbl' not described

Re: [PATCH][next] carl9170: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
hrough > > Signed-off-by: Gustavo A. R. Silva > Acked-by: Christian Lamparter > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 6df74f61e9a2 carl9170: Use fallthrough pseudo-keyword -- https://patchwork.kernel.org/patch/11728239/ https://w

Re: [PATCH] ath11k: return error if firmware request fails

2020-08-27 Thread Kalle Valo
returns for clarity. > > While we are at it, move the call to memset, as variable bd is not used > on all code paths. > > Fixes: 7b57b2ddec21 ("ath11k: create a common function to request all > firmware files") > Signed-off-by: Alex Dewar > Signed-off-by: Ka

Re: [PATCH] ath9k: Do not select MAC80211_LEDS by default

2020-08-27 Thread Kalle Valo
n not needed. > > Signed-off-by: Krzysztof Kozlowski > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 72cdab808714 ath9k: Do not select MAC80211_LEDS by default -- https://patchwork.kernel.org/patch/11727077/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH 17/30] wireless: ath: ath9k: ar9002_initvals: Remove unused array 'ar9280PciePhy_clkreq_off_L1_9280'

2020-08-27 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/ath/ath9k/ar9002_initvals.h:900:18: warning: > ‘ar9280PciePhy_clkreq_off_L1_9280’ defined but not used > [-Wunused-const-variable=] > > Cc: QCA ath9k Development > Cc: Ka

Re: [PATCH 02/16] wireless: ath9k: convert tasklets to use new tasklet_setup() API

2020-08-27 Thread Kalle Valo
ed-off-by: Allen Pais > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. f91a35b46af0 ath9k: convert tasklets to use new tasklet_setup() API -- https://patchwork.kernel.org/patch/11717397/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH] ath9k_htc: Do not select MAC80211_LEDS by default

2020-08-27 Thread Kalle Valo
ling LED trigger when not needed. > > Signed-off-by: Krzysztof Kozlowski > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 197f466e93f5 ath9k_htc: Do not select MAC80211_LEDS by default -- https://patchwork.kernel.org/patch/11726211/ https://wireless.wi

Re: [PATCH 01/16] wireless: ath5k: convert tasklets to use new tasklet_setup() API

2020-08-27 Thread Kalle Valo
ed-off-by: Allen Pais > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. c068a9ec3c94 ath5k: convert tasklets to use new tasklet_setup() API -- https://patchwork.kernel.org/patch/11717393/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH 14/30] wireless: ath: ath6kl: wmi: Remove unused variable 'rate'

2020-08-27 Thread Kalle Valo
le] > > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: linux-wirel...@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Lee Jones > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. e58518499ded a

Re: [PATCH] [v2] wilc1000: Fix memleak in wilc_bus_probe

2020-08-27 Thread Kalle Valo
Dinghao Liu wrote: > When devm_clk_get() returns -EPROBE_DEFER, spi_priv > should be freed just like when wilc_cfg80211_init() > fails. > > Fixes: 854d66df74aed ("staging: wilc1000: look for rtc_clk clock in spi mode") > Signed-off-by: Dinghao Liu > Acked-by: Ajay Singh Patch applied to wirel

Re: [PATCH][next] rtw88: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH] rtw88: switch from 'pci_' to 'dma_' API

2020-08-27 Thread Kalle Valo
Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When memory is allocated in 'rtw_pci_i

Re: [PATCH] [v2] wilc1000: Fix memleak in wilc_sdio_probe

2020-08-27 Thread Kalle Valo
Dinghao Liu wrote: > When devm_clk_get() returns -EPROBE_DEFER, sdio_priv > should be freed just like when wilc_cfg80211_init() > fails. > > Fixes: 8692b047e86cf ("staging: wilc1000: look for rtc_clk clock") > Signed-off-by: Dinghao Liu > Acked-by: Ajay Singh Patch applied to wireless-drivers

Re: [PATCH v2] mwifiex: don't call del_timer_sync() on uninitialized timer

2020-08-27 Thread Kalle Valo
Tetsuo Handa wrote: > syzbot is reporting that del_timer_sync() is called from > mwifiex_usb_cleanup_tx_aggr() from mwifiex_unregister_dev() without > checking timer_setup() from mwifiex_usb_tx_init() was called [1]. > > Ganapathi Bhat proposed a possibly cleaner fix, but it seems that > that fi

Re: [PATCH][next] mwifiex: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH] mwifiex: Clean up some err and dbg messages

2020-08-27 Thread Kalle Valo
Christophe JAILLET wrote: > The error message if 'pci_set_consistent_dma_mask()' fails is misleading. > The function call uses 32 bits, but the error message reports 64. > > Moreover, according to the comment above 'dma_set_mask_and_coherent()' > definition, such an error can never happen. > >

Re: [PATCH] mwifiex: switch from 'pci_' to 'dma_' API

2020-08-27 Thread Kalle Valo
Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When memory is allocated in 'mwifiex_p

Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses

2020-08-27 Thread Kalle Valo
Larry Finger writes: > On 7/27/20 9:52 AM, Joe Perches wrote: >> On Mon, 2020-07-27 at 09:04 +, Pkshih wrote: >>> So, I think you would like to have parenthesis intentionally. >>> If so, >>> test1 ? : (test2 ? :) >>> would be better. >>> >>> >>> If not, >>> test1 ? : test2 ? : >>> may be what

Re: [PATCH] Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver"

2020-08-27 Thread Kalle Valo
Mauro Carvalho Chehab writes: > This patch causes a regression betwen Kernel 5.7 and 5.8 at wlcore: > with it applied, WiFi stops working, and the Kernel starts printing > this message every second: > >wlcore: PHY firmware version: Rev 8.2.0.0.242 >wlcore: firmware booted (Rev 8.9.0.0.79)

Re: [PATCH net] mwifiex: Increase AES key storage size to 256 bits

2020-08-27 Thread Kalle Valo
Brian Norris writes: > Hi, > > On Tue, Aug 25, 2020 at 8:38 AM Maximilian Luz > wrote: >> >> Following commit e18696786548 ("mwifiex: Prevent memory corruption >> handling keys") the mwifiex driver fails to authenticate with certain >> networks, specifically networks with 256 bit keys, and repe

Re: [PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused

2020-08-27 Thread Kalle Valo
Lee Jones writes: > On Mon, 17 Aug 2020, Kalle Valo wrote: > >> Rasmus Villemoes writes: >> >> > On 14/08/2020 17.14, Christian Lamparter wrote: >> >> On 2020-08-14 13:39, Lee Jones wrote: >> >>> 'ar9170_qmap' is used in some s

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-27 Thread Kalle Valo
Ondrej Zary writes: > On Monday 17 August 2020 20:27:06 Jesse Brandeburg wrote: >> On Mon, 17 Aug 2020 16:27:01 +0300 >> Kalle Valo wrote: >> >> > I was surprised to see that someone was using this driver in 2015, so >> > I'm not sure anymore what

Re: [PATCH 07/30] net: wireless: broadcom: b43: main: Add braces around empty statements

2020-08-27 Thread Kalle Valo
Lee Jones writes: > On Fri, 14 Aug 2020, Kalle Valo wrote: > >> Lee Jones writes: >> >> > On Fri, 14 Aug 2020, Kalle Valo wrote: >> > >> >> Lee Jones writes: >> >> >> >> > Fixes the following W=1 kernel build warning

Re: [PATCH 12/30] wireless: ath: wil6210: wmi: Correct misnamed function parameter 'ptr_'

2020-08-26 Thread Kalle Valo
: Excess function > parameter 'ptr' description in 'wmi_buffer_block' > > Cc: Maya Erez > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: linux-wirel...@vger.kernel.org > Cc: wil6...@qti.qualcomm.com > Cc: netdev@vge

Re: [PATCH 25/32] wireless: ath: wil6210: wmi: Fix formatting and demote non-conforming function headers

2020-08-26 Thread Kalle Valo
not described in 'wmi_evt_ignore' > drivers/net/wireless/ath/wil6210/wmi.c:1876: warning: Function parameter or > member 'd' not described in 'wmi_evt_ignore' > drivers/net/wireless/ath/wil6210/wmi.c:1876: warning: Function parameter or > member &#

Re: [PATCH v2 1/2] ath10k: Keep track of which interrupts fired, don't poll them

2020-08-26 Thread Kalle Valo
t keep track > of the IRQs that fire. Then we can effectively generate our own > summary without ever needing to read the Copy Engines. > > Tested-on: WCN3990 SNOC WLAN.HL.3.2.2-00490-QCAHLSWMTPL-1 > > Signed-off-by: Douglas Anderson > Reviewed-by: Rakesh Pillai > Reviewed-by: Br

Re: [PATCH] rndis_wlan: tighten check of rndis_query_oid return

2020-08-18 Thread Kalle Valo
t...@redhat.com wrote: > From: Tom Rix > > clang static analysis reports this problem > > rndis_wlan.c:3147:25: warning: Assigned value is garbage or undefined > wiphy->max_num_pmkids = le32_to_cpu(caps.num_pmkids); > ^ ~

Re: [PATCH] adm8211: switch from 'pci_' to 'dma_' API

2020-08-18 Thread Kalle Valo
Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When memory is allocated in 'adm8211_a

Re: [PATCH] mwifiex: Do not use GFP_KERNEL in atomic context

2020-08-18 Thread Kalle Valo
Christophe JAILLET wrote: > A possible call chain is as follow: > mwifiex_sdio_interrupt(sdio.c) > --> mwifiex_main_process(main.c) > --> mwifiex_process_cmdresp (cmdevt.c) > --> mwifiex_process_sta_cmdresp

Re: [PATCH] rtw88: fix spelling mistake: "unsupport" -> "unsupported"

2020-08-18 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > There are some spelling mistakes in rtw_info messages. Fix these. > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 86c96422a3b3 rtw88: fix spelling mistake: "unsupport" -> "unsupported" -- https://patchwork.

Re: [PATCH] wl1251, wlcore: fix spelling mistake "buld" -> "build"

2020-08-18 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > There are spelling mistakes in warning messages. Fix these. > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. db8655c6299c wl1251, wlcore: fix spelling mistake "buld" -> "build" -- https://patchwork.kernel.or

<    1   2   3   4   5   6   7   8   9   10   >