Re: [PATCH] wlcore/wl18xx: mesh: added initial mesh support for wl8

>> opposed to current implementation that handles STA only). >> 5. Bumped the firmware version to support new Mesh functionality >> >> Signed-off-by: Maital Hahn <mait...@ti.com> >> Signed-off-by: Yaniv Machani <yani...@ti.com> >> --- > > Any comments on this patch ? Can this be pulled ? I'm away this week, will look at it next week. But it's on my queue: https://patchwork.kernel.org/patch/9202707/ -- Kalle Valo

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

out. It looks like just moving some code around.] Another option, but still a bad one I don't like, is that you change the kernel interface to ignore all errors from drivers (like iwlwifi). This way drivers don't need to make ugly workarounds. > The bottom line is that lm-sensors is currently broken with this change in > iwlwifi. AFAICT, no other thermal device returns an error this way, and IMO > that means the iwlwifi driver is doing something new and unexpected wrt to > userspace. I haven't checked but I suspect ath10k has a similar problem when interface is down. -- Kalle Valo

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

Prarit Bhargava <pra...@redhat.com> writes: > On 07/13/2016 02:50 AM, Kalle Valo wrote: >> Prarit Bhargava <pra...@redhat.com> writes: >> >>>> We implement thermal zone because we do support it, but the problem is >>>> that we need t

pull-request: wireless-drivers-next 2016-07-13

Q code iwlwifi: remove useless enum values iwlwifi: change fw.mvm_fw to fw.type iwlwifi: remove iwl_ht_params.smps_mode iwlwifi: store cipher scheme independent of mac80211 iwlwifi: tracing: decouple from mac80211 iwlwifi: decouple PCIe transport from mac80211 Kalle V

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

d like a good idea. I would rather try to fix the thermal interface to handle the cases when the measurement is not available. -- Kalle Valo

Re: iwlwifi: add missing type declaration

Arnd Bergmann wrote: > The iwl-debug.h header relies in implicit inclusion of linux/device.h and > we get a lot of warnings without that: > > drivers/net/wireless/intel/iwlwifi/iwl-debug.h:44:23: error: 'struct device' > declared inside parameter list will not be visible outside

Re: wcn36xx: Silence error about unsupported smd event 188

Bjorn Andersson wrote: > Sometimes the firmware sends a HAL_DEL_BA_IND, the prima driver silently > ignore this message so let's do the same to silence the error message. > > Cc: Nicolas Dechesne > Signed-off-by: Bjorn Andersson

Re: [1/6] wcn36xx: Fold indication payload into message header

Bjorn Andersson wrote: > From: Bjorn Andersson > > Merge the two allocation instead of separately allocating room for the > indication payload. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn

Re: mwifiex: mask PCIe interrupts before removal

Brian Norris wrote: > The PCIe driver didn't mask the host interrupts before trying to tear > down. This causes lockups at reboot or rmmod when using MSI-X on 8997, > since the MSI handler gets confused and locks up the system. > > Also tested on 8897, which does not

Re: [1/2] brcmfmac: delete interface directly in code that sent fw request

Rafał Miłecki wrote: > So far when receiving event about in-firmware-interface removal our > event worker was notifying listener and afterwards it was removing Linux > interface. > > First of all it was resulting in slightly unexpected order. The listener > (del_virtual_intf callback) was

Re: [linux-next] rtlwifi: Fix typo in printk

Masanari Iida wrote: > This patch fix spelling typos found in drivers/net/wireless/realtek. > > Signed-off-by: Masanari Iida > Reviewed-by: Julian Calaby Thanks, 1 patch applied to wireless-drivers-next.git: 8a1902374fa0

Re: [v2] wlcore: time sync : add support for 64 bit clock

"Machani, Yaniv" wrote: > Changed the configuration to support 64bit instead of 32bit > this in order to offload the driver from handling a wraparound. > > Signed-off-by: Yaniv Machani Thanks, 1 patch applied to wireless-drivers-next.git: 585dfe813fa5 wlcore:

Re: rtlwifi: Add missing newlines to RT_TRACE calls

Joe Perches wrote: > RT_TRACE does not add a newline to the end of a message and always > emits at KERN_DEBUG so these are susceptible to message interleaving > from other processes without the newline. > > Signed-off-by: Joe Perches Thanks, 1 patch applied

Re: [PATCH v4] wlcore: spi: add wl18xx support

.c Failed to merge in the changes. Patch failed at 0001 wlcore: spi: add wl18xx support -- Kalle Valo

Re: rtlwifi: Create _rtl_dbg_trace function to reduce RT_TRACE code size

Joe Perches wrote: > This debugging macro can expand to a lot of code. > Make it a function to reduce code size. > > (x86-64 defconfig w/ all rtlwifi drivers and allyesconfig) > $ size drivers/net/wireless/realtek/rtlwifi/built-in.o* >text data bss dec

Re: [1/2] ath10k: remove unused

Chaehyun Lim wrote: > is not used anymore, so just remove it. > > Signed-off-by: Chaehyun Lim Thanks, 1 patch applied to ath-next branch of ath.git: a3dadad73324 ath10k: remove unused -- Sent by pwcli

Re: [PATCH] mwifiex: mask PCIe interrupts before removal

with it, or see it merged. It's on my queue for 4.8: https://patchwork.kernel.org/patch/9209027/ -- Kalle Valo

Re: [v2, 1/3] mwifiex: add a cfg80211 .get_tx_power operation callback

Javier Martinez Canillas wrote: > The mwifiex driver implements a cfg80211 .set_tx_power operation handler > but doesn't have the inverse .get_tx_power callback. > > This not only has the effect that the Tx power can't be reported to user > space tools such as iwconfig

Re: mwifiex: fix unconditional error return in .add_virtual_intf callback

Javier Martinez Canillas wrote: > The commit 7311ea850079 ("mwifiex: fix AP start problem for newly added > interface") attempted to fix an issue when a new AP interface is added. > > But the patch didn't check the return value of the functions doing the > firmware calls

Re: [PATCHv4 wl-drv-next 0/2] register-field manipulation macros

w Morton (CCed). Full patches here: https://patchwork.kernel.org/patch/9214129/ https://patchwork.kernel.org/patch/9214135/ -- Kalle Valo

Re: [PATCHv4 wl-drv-next 2/2] mt7601u: use linux/bitfield.h

uld just remove it entirely. But you can do that in a follow up patch. -- Kalle Valo

Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback

ed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> The fixes line should be: Fixes: 7311ea850079 ("mwifiex: fix AP start problem for newly added interface") I can fix that before I apply the patch. -- Kalle Valo

Re: brcmfmac: add missing break when deleting P2P_DEVICE

Rafał Miłecki wrote: > We obviously don't want to fall through in that switch. With this change > 1) We wait for event (triggered by p2p_disc) as expected > 2) We remove interface manually on timeout > 3) We return 0 on success instead of -ENOTSUPP > > Signed-off-by: Rafał Miłecki

Re: brcmfmac: include also core.h header in cfg80211.h

Rafał Miłecki wrote: > This header provides two inline functions using struct brcmf_if so we > need core.h to avoid: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h: In function > ‘ndev_to_prof’: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h:368:13: error: >

Re: brcmfmac: use const char * for interface name in brcmf_add_if

Rafał Miłecki wrote: > This function can work just fine with const pointer, it only calls > alloc_netdev which take const as well. Moreover it makes this function > more flexible as some cfg80211 callback may provide const char * as > well, e.g. add_virtual_intf. This will be needed for more

Re: [REBASED] brcmfmac: fix lockup when removing P2P interface after event timeout

Rafał Miłecki wrote: > Removing P2P interface is handled by sending a proper request to the > firmware. On success firmware triggers an event and driver's handler > removes a matching interface. > > However on event timeout we remove interface directly from the cfg80211 > callback. Current code

Re: [1/8] wireless: airo: rename 'register' variable

Arnd Bergmann wrote: > 'register' is a keyword in C and cannot be used in place of a > variable name, as shown by this -Wextra warning: > > drivers/net/wireless/cisco/airo.c:1105:29: error: 'register' is not at > beginning of declaration [-Werror=old-style-declaration] > > This

Re: [v2] rtlwifi: use s8 instead of char

Arnd Bergmann wrote: > Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of > incorrect code that results from 'char' being unsigned here, e.g. > > realtek/rtlwifi/rc.c:113:18: error: comparison is always true due to limited > range of data type

Re: libertas: Add spinlock to avoid race condition

Pavel Andrianov wrote: > lbs_mac_event_disconnected may free priv->currenttxskb > while lbs_hard_start_xmit accesses to it. > The patch adds a spinlock for mutual exclusion. > > Tested on OLPC XO-1 (usb8388) and XO-1.5 (sd8686) with v4.7-rc3. > > Confirmed that

Re: wlcore: sdio: Fix crash on wlcore_probe_of when failing to parse/map irq

Bruno Herrera wrote: > pdev_data pointer is being freed with kfree but the pointer is not dynamic > allocated. > > Signed-off-by: Bruno Herrera Thanks, 1 patch applied to wireless-drivers-next.git: 6edc119ed3b5 wlcore: sdio: Fix crash on

Re: libertas_tf: Remove create_workqueue

Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > A dedicated workqueue has been used since the workitem (viz > >cmd_work per priv, which maps to lbtf_cmd_work) is involved in > actual command processing and may be used on a memory

Re: brcmfmac: slightly simplify building interface combinations

Rafał Miłecki wrote: > This change reorders some operations in brcmf_setup_ifmodes in hope to > make it simpler: > 1) It allocates arrays right before filling them. This way it's easier >to follow requested array length as it's immediately followed by >code filling it. It's easier to check

Re: [PATCH] libertas_tf: Remove create_workqueue

Bhaktipriya Shridhar <bhaktipriy...@gmail.com> writes: > Ping! I'm lagging behind, the patch is still on my queue: https://patchwork.kernel.org/patch/9162447/ Please don't top most, it's annoying. -- Kalle Valo

Re: [PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file

I missed them. I did that now so they are back in my queue: https://patchwork.kernel.org/patch/9158855/ https://patchwork.kernel.org/patch/9158851/ Thanks for checking. -- Kalle Valo

pull-request: wireless-drivers-next 2016-06-21

ifiex: use better message and error code when OF node doesn't match Julia Lawall (2): ath6kl: fix typo mwifiex: fix typo Kalle Valo (1): Merge ath-next from ath.git Lauri Kasanen (1): carl9170: Clarify kconfig text Lior David (1): wil6210: abort P2P search when stopping

pull-request: wireless-drivers 2016-06-21

crash related to printing features Colin Ian King (1): rtl8xxxu: fix typo on variable name, compare against correct variable Emmanuel Grumbach (1): iwlwifi: mvm: fix RCU splat in TKIP's update_key Johannes Berg (1): iwlwifi: mvm: fix a few firmware capability checks Kalle Valo (2

Re: [PATCH 0/3] *** Mesh Path Selection Metric Calculation ***

Peter Oh <p...@codeaurora.org> writes: > where is 2/3 ? You can find the patches from patchwork: https://patchwork.kernel.org/patch/9187367/ https://patchwork.kernel.org/patch/9187361/ https://patchwork.kernel.org/patch/9187355/ -- Kalle Valo

Re: mwifiex: fix link error against sdio

Arnd Bergmann wrote: > Calling sdio_claim_host() from the interface independent part of > the mwifiex driver is not only a layering violation, but also causes > a link error if MMC support is disabled, or if CONFIG_MMC=m > and CONFIG_MWIFIEX=y: > > drivers/net/built-in.o: In

Re: [PATCH 4.7 FIX] brcmfmac: fix lockup when removing P2P interface after event timeout

t seems to be there for a long time. Also > applying it to -next will allow avoiding merge conflicts and immediate > development work on -next. Exactly, there is a cost when taking patches to wireless-drivers.git and that's why I try to keep the bar high. Regressions and user reported bugs take priority, other fixes are handled case by case. > I'll resend this patch rebased on -next soon. Thanks. -- Kalle Valo

Re: [PATCH 4.7 FIX] brcmfmac: fix lockup when removing P2P interface after event timeout

Rafał Miłecki <zaj...@gmail.com> writes: > On 16 June 2016 at 17:10, Kalle Valo <kv...@codeaurora.org> wrote: >> Rafał Miłecki <zaj...@gmail.com> writes: >> >>> Removing P2P interface is handled by sending a proper request to the >>> firmware.

Re: [v3,1/2] b43: Remove unused phy_a code

Michael Büsch <m...@bues.ch> writes: > On Thu, 16 Jun 2016 15:23:37 + (UTC) > Kalle Valo <kv...@codeaurora.org> wrote: > >> Guenter Roeck <li...@roeck-us.net> wrote: >> > gcc-6 reports the following error with -Werror=unused-const-variable. >> &

Re: libertas: Remove create_workqueue

Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > In if_sdio.c, the workqueue card->workqueue has workitem > >packet_worker, which is mapped to if_sdio_host_to_card_worker. > The workitem is involved in sending packets to firmware.

Re: brcmfmac: include required headers in cfg80211.h

Rafał Miłecki wrote: > Without this including cfg80211.h in a wrong order could result in: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h:122:24: error: > array type has incomplete element type > struct brcmf_wsec_key key[BRCMF_MAX_DEFAULT_KEYS]; > ^ >

Re: [v3,1/2] b43: Remove unused phy_a code

Guenter Roeck wrote: > gcc-6 reports the following error with -Werror=unused-const-variable. > > drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error: > 'b43_phyops_a' defined but not used > > Per Michael Büsch: "All a-phy code is usused", so remove it all, > and

Re: brcmfmac: drop unused pm_block vif attribute

Rafał Miłecki wrote: > This attribute was added 3 years ago by > commit 3eacf866559c ("brcmfmac: introduce brcmf_cfg80211_vif structure") > but it remains unused since then. It seems we can safely drop it. > > Signed-off-by: Rafał Miłecki Thanks, 1 patch applied to

Re: libertas_tf: Drop unused variable and define

Guenter Roeck wrote: > gcc-6 reports: > > drivers/net/wireless/marvell/libertas_tf/main.c:30:19: error: > 'lbtf_driver_version' defined but not used > > with -Werror=unused-const-variable=. > > Reported-by: Fengguang Wu [0-day test robot] >

Re: rtlwifi: fix error handling in *_read_adapter_info()

Arnd Bergmann wrote: > There are nine copies of the _rtl88ee_read_adapter_info() function, > and most but not all of them cause a build warning in some configurations: > > rtl8192de/hw.c: In function '_rtl92de_read_adapter_info': > rtl8192de/hw.c:1767:12: error: 'hwinfo' may be

Re: [V2, next] brcmfmac: don't remove interface on link down firmware event

Rafał Miłecki wrote: > There are two firmware events we handle similarly in brcmfmac: > BRCMF_E_LINK and BRCMF_E_IF. The difference from firmware point of view > is that the first one means BSS remains present in the firmware. Trying > to (re)create it (e.g. when adding new virtual interface) will

Re: [PATCH 4.7 FIX] brcmfmac: fix lockup when removing P2P interface after event timeout

ed to merge in the changes. Patch failed at 0001 brcmfmac: fix lockup when removing P2P interface after event timeout -- Kalle Valo

Re: [V2] brcmfmac: fix setting AP channel with new firmwares

Rafał Miłecki wrote: > Firmware for new chipsets is based on a new major version of code > internally maintained at Broadcom. E.g. brcmfmac4366b-pcie.bin (used for > BCM4366B1) is based on 10.10.69.3309 while brcmfmac43602-pcie.ap.bin was > based on 7.35.177.56. > > Currently setting AP 5 GHz

Re: wl3501_cs: avoid bogus gcc-6 warning

Arnd Bergmann wrote: > gcc-6 on x86 started warning about wl3501_get_encode when building > with -O2: > > drivers/net/wireless/wl3501_cs.c: In function ‘wl3501_get_encode’: > drivers/net/wireless/wl3501_cs.c:1769:5: warning: ‘implemented’ may be used > uninitialized in this

Re: [1/8] mwifiex: only call mwifiex_sdio_probe_of() if dev has an OF node

Javier Martinez Canillas wrote: > SDIO is an auto enumerable bus so the SDIO devices are matched using the > sdio_device_id table and not using compatible strings from a OF id table. > > However, commit ce4f6f0c353b ("mwifiex: add platform specific wakeup > interrupt

Re: [1/1] brcm80211: simplify assignment

Heinrich Schuchardt wrote: > Simplify assignment in wlc_phy_rxcal_gainctrl_nphy_rev5. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Arend van Spriel Thanks, 1 patch applied to wireless-drivers-next.git: 6b128a01c673

Re: [1/1] mwiflex: avoid possible null pointer dereference

Heinrich Schuchardt wrote: > Do not dereference card before checking against NULL value. > > Signed-off-by: Heinrich Schuchardt Thanks, 1 patch applied to wireless-drivers-next.git: 141bcf099076 mwiflex: avoid possible null pointer dereference -- Sent

Re: brcmfmac: use kmemdup

Muhammad Falak R Wani wrote: > Use kmemdup when some other buffer is immediately copied into allocated > region. It replaces call to allocation followed by memcpy, by a single > call to kmemdup. > > Signed-off-by: Muhammad Falak R Wani > Acked-by:

Re: [V2, 4.8, 1/2] brcmutil: add field storing control channel to the struct brcmu_chan

Rafał Miłecki wrote: > Our d11 code supports encoding/decoding channel info into/from chanspec > format used by firmware. Current implementation is quite misleading > because of the way "chnum" field is used. > When encoding channel info, "chnum" has to be filled by a caller with > *center*

Re: iwlegacy: avoid warning about missing braces

Arnd Bergmann wrote: > gcc-6 warns about code in il3945_hw_txq_ctx_free() being > somewhat ambiguous: > > drivers/net/wireless/intel/iwlegacy/3945.c:1022:5: warning: suggest explicit > braces to avoid ambiguous 'else' [-Wparentheses] > > This adds a set of curly braces to avoid

Re: [1/1] rtlwifi: rtl8192ee: simplify coding

Heinrich Schuchardt wrote: > Simplify _rtl92ee_phy_path_adda_on. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Larry Finger Thanks, 1 patch applied to wireless-drivers-next.git: a81605b14942 rtlwifi: rtl8192ee: simplify

Re: [1/1] mwifiex: illegal assignment

Heinrich Schuchardt wrote: > Variable adapter is incorrectly initialized. > > Fixes: bf00dc22bc7a ("mwifiex: AMSDU Rx frame handling in AP mode") > Signed-off-by: Heinrich Schuchardt > Acked-by: Amitkumar Karwar Thanks, 1 patch

Re: [1/1] rtlwifi: rtl8723be: avoid undefined behavior

Heinrich Schuchardt wrote: > Do not return undefined value for transmission power > if the rate is invalid. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Larry Finger Thanks, 1 patch applied to wireless-drivers-next.git:

Re: [1/1] rsi: eliminate superfluous NULL check

Heinrich Schuchardt wrote: > msg is dereferenced before checking against NULL, e.g. > when assigning pad_bytes. > Remove the superfluous check in function rsi_mgmt_pkt_to_core. > > Signed-off-by: Heinrich Schuchardt Thanks, 1 patch applied to

Re: [PATCH 0/2] register-field manipulation macros

e, since the only existing user is in > drivers/net/wireless/. > > Jakub Kicinski (2): > add basic register-field manipulation macros > mt7601u: use linux/bitfield.h I guess you forgot to CC linux-wireless, adding it now, and hence I don't see these in my patchwork either. So better to resend. -- Kalle Valo

Re: [PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file

atch 2/3. > Is that Ok for you or do you want me to re-resend a v3 > with only patches 1/3 and 3/3? I can drop patch 2, no need to resend. Thanks. -- Kalle Valo

Re: [PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file

_ROLE_ANY); > + return mwifiex_get_tx_power(priv, dbm); > } So in patch 1 you added the patch and in patch 2 you move it to a different location? That doesn't make any sense, can't you just fold the two patches into one so that the function is added only once. -- Kalle Valo

Re: brcmfmac: rework function picking free BSS index

Kalle Valo <kv...@codeaurora.org> writes: > Rafał Miłecki wrote: >> The old implementation was overcomplicated and slightly bugged in some >> corner cases. >> >> Consider following state of BSS-es (limited to 6 for simplification): >> drvr->iflist[0]:

Re: brcmfmac: rework function picking free BSS index

Rafał Miłecki wrote: > The old implementation was overcomplicated and slightly bugged in some > corner cases. > > Consider following state of BSS-es (limited to 6 for simplification): > drvr->iflist[0]: { bsscfgidx:0, ndev->name:wlan1, } > drvr->iflist[1]: (null) > drvr->iflist[2]: {

Re: ath9k gpio request

; > > and maybe a Reported-by tag is also appropriate in this case. Yeah, I add those. Thanks Sudip. -- Kalle Valo

pull-request: wireless-drivers 2016-06-04

Hi Dave, few fixes for 4.7. Please let me know if you have any issues. Kalle The following changes since commit b7e7ad611e24b95b0db2998428ce78370415c086: Merge branch 'qed-fixes' (2016-05-26 12:27:33 -0700) are available in the git repository at:

Re: [7/7] mwifiex: fix typo

Julia Lawall wrote: > firmare -> firmware > > Signed-off-by: Julia Lawall Thanks, 1 patch applied to wireless-drivers-next.git: 47ce90f9f08a mwifiex: fix typo -- Sent by pwcli https://patchwork.kernel.org/patch/9113281/

Re: [v2] carl9170: Clarify kconfig text

Lauri Kasanen wrote: > The previous text was confusing, leading readers to think this > driver was a duplicate, and so didn't need to be enabled. > > After the removal of the older staging driver, this is the only > driver in mainline for these devices. > > Signed-off-by: Lauri

Re: ath9k gpio request

>> Tested-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> > > Done, https://patchwork.kernel.org/patch/9151847/ But the patch 9151847 is different from what Sudip tested above? Why? And if you modify something _after_ the reporter has tested the patch clearly document what you changed and why. I do not want find hidden changes like this, even more so when the patch is going to a 4.7-rc release. Sudip, could you also test patch 9151847, please? You can download the patch from the patchwork link above. -- Kalle Valo

Re: [PATCH] net: wireless: marvell: libertas: Remove create_workqueue

E commands 6d91ff7acc90 libertas: cleanup a variable name 0a38c8e1b592 libertas: check for NULL before use $ -- Kalle Valo

Re: ath9k gpio request

ne AR9485_GPIO_MASK0x07FF >> #define AR9531_GPIO_MASK0x000F >> #define AR9550_GPIO_MASK0x000F >> #define AR9561_GPIO_MASK0x000F > > solves the problem. > >

Re: [PATCH 4.7 FIX] brcmfmac: fix lockup when removing P2P interface after event timeout

;zaj...@gmail.com> Arend, are you ok to push this to 4.7? -- Kalle Valo

ath9k gpio request

void ath9k_hw_gpio_request_in(); void ath9k_hw_gpio_request_out(); void ath9k_hw_gpio_free(); NOTE, the BSP of the SOC chips(AR9340, AR9531, AR9550, AR9561) should set the corresponding MUX registers correctly. Signed-off-by: Miaoqing Pan <miaoq...@codeaurora.org> Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> -- Kalle Valo

Re: wifi: ath6kl: simplify logical condition

Heinrich Schuchardt wrote: > x <= 7 implies x < 8. > > Signed-off-by: Heinrich Schuchardt Thanks, 1 patch applied to ath.git: 93b4a09f0f30 ath6kl: simplify logical condition -- Sent by pwcli https://patchwork.kernel.org/patch/9115691/

Re: [6/7] ath6kl: fix typo

Julia Lawall wrote: > firmare -> firmware > > Signed-off-by: Julia Lawall Thanks, 1 patch applied to ath.git: 8a9a3efa9e77 ath6kl: fix typo -- Sent by pwcli https://patchwork.kernel.org/patch/9113271/

pull-request: wireless-drivers-next 2016-05-13 (take two)

: rtl818x: constify rtl_intf_ops structures Kalle Valo (2): Merge tag 'iwlwifi-next-for-kalle-2016-05-10' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from ath.git Liad Kaufman (4): iwlwifi: mvm: allocate queue for probe response in dqa mode iwlwifi: mvm

Re: [GIT] Networking

Linus Torvalds <torva...@linux-foundation.org> writes: > On Wed, May 18, 2016 at 11:58 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> >> It would be best if you could send a patch either directly to Dave or >> Linus to resolve this quickly. > > I'm comm

Re: [GIT] Networking

"Coelho, Luciano" <luciano.coe...@intel.com> writes: > Kalle, David, what is the status with the fix that is on the way via > your trees? It would be best if you could send a patch either directly to Dave or Linus to resolve this quickly. -- Kalle Valo

Re: pull-request: wireless-drivers-next 2016-05-13

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Tue, 17 May 2016 09:43:34 +0300 > >> I noticed that you had marked this as Superseded in pathwork[1]. I was >> actually hoping that you would pull this with the instru

Re: [PATCH 0/7] fix typo

Julia Lawall <julia.law...@lip6.fr> writes: > On Tue, 17 May 2016, Kalle Valo wrote: > >> Julia Lawall <julia.law...@lip6.fr> writes: >> >> > firmare -> firmware >> > >> > --- >> > >> > drivers/media/dvb-frontends/mn88

Re: [PATCH 0/7] fix typo

know in advance what tree you are planning to submit these for. For example, should I take ath6kl and mwifiex patches or someone else? -- Kalle Valo

Re: pull-request: wireless-drivers-next 2016-05-13

Hi Dave, Kalle Valo <kv...@codeaurora.org> writes: > Kalle Valo <kv...@codeaurora.org> writes: > >> Kalle Valo <kv...@codeaurora.org> writes: >> >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.gi

Re: pull-request: wireless-drivers-next 2016-05-13

Kalle Valo <kv...@codeaurora.org> writes: > Kalle Valo <kv...@codeaurora.org> writes: > >> The following changes since commit ede00a5ceb4d903a8c137a52bb77d574baaef8bd: >> >> Merge tag 'wireless-drivers-next-for-davem-2016-05-02' of >> git://git

Re: linux-next: manual merge of the wireless-drivers-next tree with the net-next tree

(uintptr_t)skb_info->driver_data[0]); tx_cmd->life_time = cpu_to_le32(TX_CMD_LIFE_TIME_INFINITE); tx_cmd->sta_id = sta_id; I'm going to propose this to Dave in my pending pull request[1]. But I would appreciate if someone else would double check this. [1] https://patchwork.ozlabs.org/patch/621953/ -- Kalle Valo

Re: pull-request: wireless-drivers-next 2016-05-13

Hi Dave, Kalle Valo <kv...@codeaurora.org> writes: > this is the last pull request to net-next for 4.7. Nothing really out of > ordinary, the signed tag below contains more info. Please let me know if > there are any issues. > > Kalle > > > The

Re: linux-next: manual merge of the wireless-drivers-next tree with the net-next tree

tx_cmd->life_time = cpu_to_le32(TX_CMD_LIFE_TIME_INFINITE); tx_cmd->sta_id = sta_id; I wasn't expecting that skb_info variable is removed. Do we now have merge damage somewhere? Luca, what do you think? -- Kalle Valo

pull-request: wireless-drivers-next 2016-05-13

iwlwifi: pcie: avoid msleep() with short timeout Julia Lawall (1): rtlwifi: rtl818x: constify rtl_intf_ops structures Kalle Valo (2): Merge tag 'iwlwifi-next-for-kalle-2016-05-10' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from ath.git Liad Kaufman (4

Re: [v2] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb inrtl_pci_reset_trx_ring

wang yanqing wrote: > We can't use kfree_skb in irq disable context, because spin_lock_irqsave > make sure we are always in irq disable context, use dev_kfree_skb_irq > instead of kfree_skb is better than dev_kfree_skb_any. > > This patch fix below kernel warning: > [

Re: [v2] rtlwifi: Remove double check for cnt_after_linked

wang yanqing wrote: > rtl_lps_enter does two successive check for cnt_after_linked > to make sure some time has elapsed after linked. The second > check isn't necessary, because if cnt_after_linked is bigger > than 5, it is bigger than 2 of course! > > This patch remove the

Re: rtlwifi: rtl818x: silence uninitialized variable warning

Dan Carpenter wrote: > What about if "rtlphy->pwrgroup_cnt" is 2? In that case we would use an > uninitialized "chnlgroup" variable and probably crash. Maybe that can't > happen for some reason which is not obvious but in that case this patch > is harmless. > >

Re: [v2] rtlwifi: Fix logic error in enter/exit power-save mode

wang yanqing wrote: > In commit a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and > rtl_lps_enter() to use work queue"), the tests for enter/exit > power-save mode were inverted. With this change applied, the > wifi connection becomes much more stable. > > Fixes:

Re: rtlwifi: rtl818x: constify rtl_intf_ops structures

Julia Lawall wrote: > The rtl_intf_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Thanks, 1 patch applied to wireless-drivers-next.git: 1bfcfdcca142 rtlwifi:

Re: linux-next: manual merge of the net-next tree with the wireless-drivers tree

to fix this by merging wireless-drivers to wireless-drivers-next later today and most likely tomorrow send a wireless-drivers-next pull request to Dave. -- Kalle Valo

pull-request: wireless-drivers 2016-05-09

) Emmanuel Grumbach (1): iwlwifi: mvm: don't override the rate with the AMSDU len Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2016-05-04' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes drivers/net/wireless/intel/iwlwifi/mvm

pull-request: wireless-drivers-next 2016-05-02

rtl8723b_channel_to_group() rtl8xxxu: Rename rtl8723bu_simularity_compare() rtl8xxxu: Rename rtl8723au_iqk_phy_iq_bb_reg Jia-Ju Bai (1): rtl818x_pci: Fix a memory leak in rtl8180_init_rx_ring Kalle Valo (14): ath10k: fix checkpatch warnings related to spaces ath10k: prefer kernel

Re: [PATCH] wcn36xx: Set SMD timeout to 10 seconds

gt; > Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> Applied, thanks. -- Kalle Valo

Re: [v3] prism54: isl_38xx: Replace 'struct timeval'

<a...@arndb.de> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [PATCH 1/5] ti: Convert wl1271_ logging macros to dev_ or pr_

vers/net/wireless/ti/wl18xx/event.c Auto-merging drivers/net/wireless/ti/wl18xx/debugfs.c Auto-merging drivers/net/wireless/ti/wl18xx/cmd.c Auto-merging drivers/net/wireless/ti/wl12xx/scan.c Auto-merging drivers/net/wireless/ti/wl12xx/main.c Failed to merge in the changes. -- Kalle Valo

<    2   3   4   5   6   7   8   9   10   >