Re: [PATCH v3 00/18] wcn36xx fixes

ex instead of hard coded > wcn36xx: Clear encrypt_type when deleting bss key > wcn36xx: Track association state > wcn36xx: Implement multicast filtering > wcn36xx: Use correct command struct for EXIT_BMPS_REQ All applied, thanks. -- Kalle Valo

pull-request: wireless-drivers 2016-04-25

Ayala Beker (1): iwlwifi: mvm: avoid to WARN about gscan capabilities Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2016-04-12_2' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes Matti Gottlieb (1): iwlwifi: mvm: fix accessing Null pointer during fw dump

Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval'

macros, SHOW_*, pc_debug, maybe >> more) as well. > > Seems reasonable. > > Maybe we should Cc the maintainer, but I suspect that since the driver > is marked Obsolete anyway Luis won't care either :) I'm planning to apply this patch anyway, the debugging infrastructure removal can be a followup patch. But please let me know if I should drop this instead. -- Kalle Valo

Re: rtl8xxxu: hide unused tables

"rtl8xxxu: Add TX power base values for gen1 parts") > Fixes: 4062b8ffec36 ("rtl8xxxu: Move PHY RF init into device specific > functions") Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [PATCH v2] carl9170: Clarify kconfig text

Christian Lamparter <chunk...@googlemail.com> writes: > On Monday, April 18, 2016 07:42:05 PM Kalle Valo wrote: >> Christian Lamparter <chunk...@googlemail.com> writes: >> >> > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: >> > >> >

Re: [PATCH] ath9k: remove duplicate assignment of variable ah

Colin King <colin.k...@canonical.com> writes: > From: Colin Ian King <colin.k...@canonical.com> > > ah is written twice with the same value, remove one of the > redundant assignments to ah. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Applied, thanks. -- Kalle Valo

Re: [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel()

Replace an explicit initialisation for one local variable at the beginning >> by a conditional assignment. >> >> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> > > This looks sane to me. > > Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Applied, thanks. -- Kalle Valo

Re: [PATCH] rtl8xxxu: hide unused tables

into device specific >> functions") >> --- >> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 >> 1 file changed, 4 insertions(+) > > I'll apply it to my tree! Actually I would prefer to apply this directly to wireless-drivers-next so that the warnings are quickly fixed. -- Kalle Valo

Re: [PATCH v2] carl9170: Clarify kconfig text

Christian Lamparter <chunk...@googlemail.com> writes: > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: >> Lauri Kasanen <c...@gmx.com> writes: >> >> > --- a/drivers/net/wireless/ath/carl9170/Kconfig >> > +++ b/drivers/net/wireless/ath/c

Re: [PATCH v2] carl9170: Clarify kconfig text

s/Drivers/carl9170> Why even mention anything about a "special firmware" as the firmware is already available from linux-firmware.git? That's default location for all firmware images and I think most, if not all, distros should have it available. So wouldn't it be better not to mention anything about firmware at all? -- Kalle Valo

Re: [PATCH 2/2] rtlwifi: Fix reusable codes in core.c

Julian Calaby <julian.cal...@gmail.com> writes: > Hi Kalle, > > On Sat, Apr 16, 2016 at 4:25 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> Byeoungwook Kim <quddnr...@gmail.com> writes: >> >>> rtl_*_delay() functions were reused same co

Re: [PATCH 2/2] rtlwifi: Fix reusable codes in core.c

Patch failed at 0001 rtlwifi: Fix reusable codes in core.c Please rebase and resend. -- Kalle Valo

Re: [PATCH v2 01/15] wcn36xx: Clean up wcn36xx_smd_send_beacon

t; > Have you picked up these patches yet? > > As I was debugging a firmware crash when trying to start hostap on the > DragonBoard410c I found an issue with this patch, would like to know if > I should send an incremental patch or resend this one. I haven't applied these yet, so please resend the whole series as v3. -- Kalle Valo

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

Eliad Peller <el...@wizery.com> writes: > On Thu, Mar 31, 2016 at 11:07 AM, Joe Perches <j...@perches.com> wrote: >> On Thu, 2016-03-31 at 10:39 +0300, Kalle Valo wrote: >>> Joe Perches <j...@perches.com> writes: >>> > On Wed, 2016-03-30 at 14:51

Re: [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel()

.cal...@gmail.com> Before I commit I'll just change the commit title to: ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel() -- Kalle Valo

pull-request: wireless-drivers 2016-04-13

Grumbach (1): iwlwifi: pcie: lower the debug level for RSA semaphore access Jia-Ju Bai (1): b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2016-03-30' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes Matti

pull-request: wireless-drivers-next 2016-04-11

on for compaq c700 laptop Julian Calaby (1): iwl4965: Fix more memory leaks in __il4965_up() Kalle Valo (2): Merge tag 'iwlwifi-next-for-kalle-2016-03-30' of https://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from ath.git Larry Finger (11): rtlwifi: rtl8723be

Re: mwifiex: ie_list is an array, so no need to check if NULL

Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [PATCH] wlcore: spi: add wl18xx support

;, .data = _data}, >> >{ } >> >> Shouldn't you also update bindings/net/wireless/ti,wlcore,spi.txt? Now it >> only >> mentions about ti,wl1271 and not anything about the rest. > > You are right! Will be fixed in v2 Thanks. Also remember to CC devicetree list. -- Kalle Valo

Re: [PATCH] wlcore: spi: add wl18xx support

805", .data = _data}, > + { .compatible = "ti,wl1807", .data = _data}, > + { .compatible = "ti,wl1831", .data = _data}, > + { .compatible = "ti,wl1835", .data = _data}, > + { .compatible = "ti,wl1837", .data = _data}, > { } Shouldn't you also update bindings/net/wireless/ti,wlcore,spi.txt? Now it only mentions about ti,wl1271 and not anything about the rest. Adding devicetree list for further comments. -- Kalle Valo

Re: [PATCH] wlcore: spi: add wl18xx support

rnel.org; >> netdev@vger.kernel.org; linux-ker...@vger.kernel.org >> Cc: Reizer, Eyal >> Subject: [PATCH] wlcore: spi: add wl18xx support Please edit your quotes and don't top most. A oneliner and then followed by almost 400 lines unnecessary text for example makes it harder to use patchwork: https://patchwork.kernel.org/patch/8696181/ -- Kalle Valo

Re: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

"Machani, Yaniv" <yani...@ti.com> writes: > More than that, wl1251 family is not officially supported via the > mainline Linux. I guess you mean not officially supported by TI? Because wl1251 driver has been in mainline for ages and reportedly working. -- Kalle Valo

Re: [v2] mwifiex: advertise low priority scan feature

org> > Tested-by: Wei-Ning Huang <wnhu...@chromium.org> > Acked-by: Amitkumar Karwar <akar...@marvell.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: brcmfmac: sdio: remove unused variable retry_limit

<julian.cal...@gmail.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: wl12xx: remove redundant null check on wl->scan.ssid

> From: Colin Ian King <colin.k...@canonical.com> > > ssid is an array of u8, so it can never be null, so the null check on > wl->scan.ssid is redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: rtlwifi: btcoexist: Convert BTC_PRINTK to btc__dbg

Falling back to patching base and 3-way merge... Auto-merging drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h Auto-merging drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c Auto-merging drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c Kalle Valo

Re: [PATCH] ath5k: Change led pin configuration for compaq c700 laptop

b8d ("ath5k: add led pin > configuration for compaq c700 laptop") > > Signed-off-by: Joseph Salisbury <joseph.salisb...@canonical.com> > Cc: sta...@vger.kernel.org Applied to ath.git, thanks. I just fixed the Fixes line to be one continuous line. -- Kalle Valo

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

Joe Perches <j...@perches.com> writes: > On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote: >> Joe Perches <j...@perches.com> writes: >> > Using the normal kernel logging mechanisms makes this code >> > a bit more like other wireless drivers. >> Pers

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

t and that's I'm not thrilled to take big patches like this for dormant drivers. -- Kalle Valo

Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

7, that introduces this > helper function. Do you want me to resend, or can you apply the patches > out of order? It's better that you resend the whole patchset as v2. -- Kalle Valo

Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

ing Huang <wnhu...@chromium.org> Is this really a proper way to fix the issue? This is the first time I'm hearing about the flag and there isn't even a single user in drivers/net. I would like to get confirmation from others that __GFP_REPEAT is really ok to use in a wireless driver before I can take this. -- Kalle Valo

Re: rtlwifi: fix gcc-6 indentation warning

-off-by: Arnd Bergmann <a...@arndb.de> > Acked-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, applied to wireless-drivers.git. Kalle Valo

Re: b43: Fix memory leaks in b43_bus_dev_ssb_init andb43_bus_dev_bcma_init

; > Thanks Michael for his suggestion. > > Signed-off-by: Jia-Ju Bai <baijiaju1...@163.com> > Acked-by: Michael Büsch <m...@bues.ch> > Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> Thanks, applied to wireless-drivers.git. Kalle Valo

Re: [PATCH 4/5] ath9k: fix misleading indentation

d-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: 499afaccf6f3 ("ath9k: Isolate ath9k_use_chanctx module parameter") > Fixes: eb61f9f623f7 ("ath9k: advertise p2p dev support when chanctx") Dave already applied this so I can skip this. -- Kalle Valo

Re: [PATCH 3/5] ath9k: fix buffer overrun for ar9287

es all three > instances to use that variable. The other two instances were > already correct, but it's more consistent this way. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: 940cd2c12ebf ("ath9k_hw: merge the ar9287 version of > ath9k_hw_get_gain_boundaries_pdadcs") Dave already applies this so I can skip this. -- Kalle Valo

Re: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

, can you help? It's a long time ago but IIRC wl1251 has not ever supported AP mode and wl1271 was the first one to support it. But I might be wrong of course. -- Kalle Valo

Re: [PATCH] mwifiex: advertise low priority scan feature

The From line states that this is written by Amitkumar but there's no Signed-off-By line from him. I can't take this without that, please resend. (Wei-Ning's s-o-b line is correct, I just need also Amitkumar's line.) -- Kalle Valo

Re: [PATCH] rtlwifi: btcoexist: Convert BTC_PRINTK to btc__dbg

this makes the patchwork page for the patch really hard to read: https://patchwork.kernel.org/patch/8615131/ -- Kalle Valo

Re: pull-request: wireless-drivers-next 2016-03-14

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Mon, 14 Mar 2016 10:31:48 +0200 > >> I know I'm late now that merge window was opened yesterday but here's >> one more set of patches I would like to get to 4

pull-request: wireless-drivers-next 2016-03-14

(1): iwlwifi: mvm: don't try to offload AES-CMAC in AP/IBSS modes Kalle Valo (1): Merge tag 'iwlwifi-next-for-kalle-2016-03-09_2' of https://git.kernel.org/.../iwlwifi/iwlwifi-next Luca Coelho (1): iwlwifi: pcie: forbid RTPM on device removal Matti Gottlieb (1): iwlwifi

Re: [PATCH] b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init

bcma_remove and error handling code of b43_bcma_probe. > > Thanks Michael for his suggestion. > > Signed-off-by: Jia-Ju Bai <baijiaju1...@163.com> > Acked-by: Michael Büsch <m...@bues.ch> > Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> If no objections I'm planning to queue this to 4.6-rc2. -- Kalle Valo

Re: libertas: fix an error code in probe

> We accidentally return success instead of a negative error code. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

pull-request: wireless-drivers-next 2016-03-09

b9a9693fd9aea43f50b107dfc8cbaea317f95a79 Author: Kalle Valo <janusz.dzied...@tieto.com> Date: Fri Nov 27 09:37:14 2015 +0100 ath9k: request NOA update when chanctx active Please let me know if you have any problems. Kalle The following changes since commit 00a1f0a93dea3cf1c141df79bfd06e7c9ee54162:

Re: [RFC 5/7] wlcore: avoid fragile snprintf use

t; Signed-off-by: Rasmus Villemoes <li...@rasmusvillemoes.dk> Should I take this or what's the plan? -- Kalle Valo

Re: [10/14] wireless: cw1200: use __maybe_unused to hide pm functions_

n use an IS_ENABLED() check > to avoid defining the structure when CONFIG_PM is not set without > the #ifdef. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [V3] mt7601u: do not free dma_buf when ivp allocation fails

a fields are free'd. Fix this by not free'ing the > dma_buf if the ivp allocation fails. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: rt2x00: add new rt2800usb device Buffalo WLI-UC-G450

> Add USB ID 0411:01fd for Buffalo WLI-UC-G450 wireless adapter, > RT chipset 3593 > > Signed-off-by: Anthony Wong <anthony.w...@ubuntu.com> > Cc: sta...@vger.kernel.org > Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [V2] rtlwifi: pass struct rtl_stats by reference as it is moreefficient

change just affects just the rx_command_packet calls. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Acked-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: mwifiex: Use to_delayed_work()

iner_of(a, struct delayed_work, work) > + to_delayed_work(a) > // > > Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> > Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

pull-request: wireless-drivers 2016-03-04

(1): ssb: host_soc depends on sprom Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2016-02-25' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes Liad Kaufman (1): iwlwifi: mvm: inc pending frames counter also when txing non-sta Matti Gottlieb (1): iwlwifi: mvm: Fix paging

Re: pull-request: wireless-drivers 2016-02-18

(Adding Larry) Geert Uytterhoeven <ge...@linux-m68k.org> writes: > On Thu, Feb 18, 2016 at 4:28 PM, Kalle Valo <kv...@codeaurora.org> wrote: > >> rtlwifi >> >> * fix broken VHT (802.11ac) support, reported by Linus > > That's commit d76d65fd269514

Re: [PATCH RFC/RFT 1/2] ath9k: rename struct ath_txq to struct ath_hwq

to both patches in case someone else wants to work with these. -- Kalle Valo

Re: [PATCH] b43: fix memory leak

end] b43: Fix memory leaks in b43_bus_dev_ssb_init and > b43_bus_dev_bcma_init > > Please test that patch instead, so we can finally apply it. > > It needs to be tested on both ssb and bcma. Come on. This isn't too > hard. :) Please somebody with any hardware test it. (I currently don't > have any b43 hardware) And the patch can be downloaded from patchwork: https://patchwork.kernel.org/patch/8049041/ -- Kalle Valo

pull-request: wireless-drivers 2016-02-18

: fix erroneous return value Emil Goode (1): wlcore: Fix regression in wlcore_set_partition() Emmanuel Grumbach (2): iwlwifi: dvm: remove a wrong dependency on m iwlwifi: pcie: fix RF-Kill vs. firmware load race Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2016-02-15

Re: wlcore: Fix regression in wlcore_set_partition()

Ross Green <rgker...@gmail.com> writes: > On Fri, Feb 12, 2016 at 8:45 PM, Kalle Valo <kv...@codeaurora.org> wrote: >> >>> The commit 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") introduced a >>> regression causing the wlcore to time out and

Re: wlcore: Fix regression in wlcore_set_partition()

Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") > Reported-by: Ross Green <rgker...@gmail.com> > Signed-off-by: Emil Goode <emil@goode.io> > [kv...@codeaurora.org: improved commit log] Thanks, applied to wireless-drivers.git. Kalle Valo

pull-request: wireless-drivers-next 2016-02-12

iwlwifi: mvm: fix debugfs signedness warning iwlwifi: mvm: track low-latency sources separately iwlwifi: mvm: support setting minimum quota from debugfs iwlwifi: treat iwl_parse_nvm_data() MAC addr as little endian Kalle Valo (1): Merge tag 'iwlwifi-next-for-kalle-2016-01

Re: [PATCH] wlcore: Fix regression in wlcore_set_partition()

regarding write of the last partition size > brings the module back to it's functional state. > > Reported-by: Ross Green <rgker...@gmail.com> > Signed-off-by: Emil Goode <emil@goode.io> A proper "Fixes:" line is good to have, but I can add it. I'm planning to queue this to 4.5. -- Kalle Valo

Re: [2/3] net: wireless: rt2x00: Pointer issue

> Code Style: pointer is declared wrong > > Signed-off-by: Paul McQuade > Acked-by: Helmut Schaa This patch didn't apply, so please resend. Kalle

Re: [1/3] net: wireless: rt2x00: Space issue

451715e94d net: wireless: rt2x00: Space Required 1 patches skipped: [2/3] net: wireless: rt2x00: Pointer issue Kalle Valo

Re: net: wireless: rt2x00: Fixed Spacing issues

> Removed empty spaces before/after parenthesis > > Signed-off-by: Paul McQuade <paulmcq...@gmail.com> > Acked-by: Helmut Schaa <helmut.sc...@googlemail.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [v2] hostap: avoid uninitialized variable use in hfa384x_get_rid

.len) == 0) { > > This restructures the function as suggested by Russell King, to > make it more readable and get more reliable error handling, by > handling each failure mode using a goto. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: brcmfmac: sdio: Increase the default timeouts a bit

cal...@gmail.com> > Acked-by: Arend van Spriel <ar...@broadcom.com> > Reviewed-by: Douglas Anderson <diand...@chromium.org> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [PATCH] mac80211: fix memory leak

i sent reached all the list subscriber from a different > server than our designated server, and as a result it is marked as spam > in many places and I have already received a few complaints regarding > that." You can add a separate "From:" line to the beginning of the commit log and git will use it then commiting the patch. I didn't find any documention but it's easy to do and should solve this. -- Kalle Valo

pull-request: wireless-drivers 2016-01-29

: add missing include ath9k_hw: ignore eeprom magic mismatch on flash based devices Gregory Greenman (1): iwlwifi: mvm: rs: fix TPC statistics handling Hante Meuleman (1): brcmfmac: fix sdio sg table alloc crash Kalle Valo (2): Merge ath-current from ath.git Merge tag

Re: wlcore: fix error handling in wlcore_event_fw_logger

.linux.kernel/2120705 > > Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") > Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [PATCH] ath9k: Drop useless const on chanctx_event_delta() return type

Geert Uytterhoeven <ge...@linux-m68k.org> writes: > drivers/net/wireless/ath/ath9k/channel.c:230: warning: type qualifiers > ignored on function return type > > Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> Applied to ath.git, thanks. -- Kalle Valo

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

What I suggest is that you add this yourself to cfg80211 and mac80211. It's not that hard and I think you could use NL80211_CMD_SET_POWER_SAVE as an example. -- Kalle Valo

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

guration has to go through cfg80211. Instead of waiting two years you could have added it yourself. -- Kalle Valo

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

oex from within the driver itself. >> >> This aint no debugging feature. > > Right, bt-coex is not for debugging purpose, but for normal usage, when > user want to use together bluetooth and wifi or just one of those. I think most of other drivers have a debugfs interface for btcoex, I guess mostly for testing purposes. But this really should be added to cfg80211. -- Kalle Valo

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

Pali Rohár <pali.ro...@gmail.com> writes: > On Thursday 21 January 2016 15:48:14 Kalle Valo wrote: >> Pali Rohár <pali.ro...@gmail.com> writes: >> >> > On Thursday 14 January 2016 10:16:54 Pavel Machek wrote: >> >> On Wed 2016-01-13 23:32:47, Are

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

single variable on a non-critical path? > > Most of the kernel code is not performance critical at the level of a > single if test. So the goal should be for the code to be easy to > understand and robust to change. The code that is performance critical, > you should probably not touch, ever. The people who wrote it knew what > was important and what was not. Very well said! Only optimise something you can measure. I'm dropping this patch. -- Kalle Valo

Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues

the whole code style cleanup series? Actually git should be manage that automatically, it's so awesome :) I can also fix the title and remove the unnecessary "net: wireless:" prefix. -- Kalle Valo

Re: [v2] mwifiex: correctly handling kzalloc

> Since kzalloc can be failed in memory pressure, > it needs to be handled, otherwise NULL dereference could be happened > > Signed-off-by: Insu Yun <wuni...@gmail.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line &

Re: iwlegacy: 4965-mac: constify il_sensitivity_ranges structure

> The il_sensitivity_ranges is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> > Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> Thanks, applied to wireless-drivers-next.git.

pull-request: wireless-drivers-next 2016-01-05

brcm80211: fix compare_const_fl.cocci warnings mwifiex: fix semicolon.cocci warnings prism54: fix compare_const_fl.cocci warnings iwlwifi: dvm: fix compare_const_fl.cocci warnings Kalle Valo (2): Merge ath-next from ath.git Merge tag 'iwlwifi-next-for-kalle-2015-12-

Re: [PATCH 5/9] ipw2x00: sdhci-pci: use to_pci_dev()

ing to submit these. I only saw this patch 5, not rest of the patches, so I have no clue what's going to happen with this patchset. Please resend. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More

Re: wlcore/wl12xx: spi: fix NULL pointer dereference (Oops)

+0x14/0x3c) > [ 23.719357] Code: bad PC value > [ 23.722760] ---[ end trace 981be8510db9b3a9 ]--- > > Prevent oops by validationg power() pointer value before > calling the function. > > Signed-off-by: Uri Mashiach <uri.mashi...@compulab.co.il> > Cc: sta...@vger.ke

Re: prism54: fix checks for dma mapping errors

lied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate

ci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 > > Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Applied to ath.git, thanks. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to major

Re: [PATCH] mwifiex: correctly handling kzalloc

.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] wlcore/wl12xx: spi: fix NULL pointer dereference (Oops)

i.mashi...@compulab.co.il> > Cc: sta...@vger.kernel.org > Acked-by: Igor Grinberg <grinb...@compulab.co.il> Please always provide a changelog when you resend patches, I lost track what I'm supposed to do with this. Should I apply or drop? -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: rsi: consolidate kmalloc/memset 0 calls to kzalloc

> This is an API consolidation only. The use of kmalloc + memset to 0 > is equivalent to kzalloc. > > Signed-off-by: Nicholas Mc Guire <hof...@osadl.org> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscr

Re: rsi: bool tests do not need comparison

> This is an API consolidation only. Bool initializations should > use true and false thus bool tests don't need an explicit comparison. > > Signed-off-by: Nicholas Mc Guire <hof...@osadl.org> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe fr

pull-request: wireless-drivers 2015-12-28

Johannes Berg (2): iwlwifi: separate firmware version for 7260 devices iwlwifi: mvm: protect RCU dereference in iwl_mvm_get_key_sta_id Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2015-12-16' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes drivers/net/wireless/iwlwifi/iwl

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

>> >> My original problem was that kmemdup (which uses kmalloc) could not >> allocate enough memory > > If kmemdump ( which uses kmalloc) could not allocate memory then > using kmalloc again can lead to same problem. > I guess it will be correct to use > *

Re: [v2] wlcore/wl12xx: spi: fix oops on firmware load

3018 (e5942008) > [ 295.021544] ---[ end trace 66ed188198f4e24e ]--- > > Signed-off-by: Uri Mashiach <uri.mashi...@compulab.co.il> > Acked-by: Igor Grinberg <grinb...@compulab.co.il> > Cc: sta...@vger.kernel.org Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: prism54: fix compare_const_fl.cocci warnings

> Move constants to the right of binary operators. > > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci > > Signed-off-by: Fengguang Wu <fengguang...@intel.com> > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Thanks, applied to wireless

Re: mwifiex: fix semicolon.cocci warnings

> Remove unneeded semicolon. > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > Signed-off-by: Fengguang Wu <fengguang...@intel.com> > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To un

Re: brcm80211: fix compare_const_fl.cocci warnings

> Move constants to the right of binary operators. > > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci > > Signed-off-by: Fengguang Wu <fengguang...@intel.com> > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Thanks, applied to wireless

Re: iwlegacy: mark il_adjust_beacon_interval as noinline

arking the il_adjust_beacon_interval > function as noinline, which convinces gcc to use the unoptimized > do_div() all the time. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Acked-by: Nicolas Pitre <n...@linaro.org> > Acked-by: Stanislaw Gruszka <sgrus...@r

Re: brcmfmac: only lock and unlock fws if fws is not null

gned-off-by: Colin Ian King <colin.k...@canonical.com> > Acked-by: Arend van Spriel <ar...@broadcom.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kerne

Re: [v2] rtlwifi: fix memory leak for USB device

up). > > Cc: sta...@vger.kernel.org > Signed-off-by: Peter Wu <pe...@lekensteyn.nl> > ACKed-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH] ath9k: fix inconsistent indenting on return statement

Colin King <colin.k...@canonical.com> writes: > From: Colin Ian King <colin.k...@canonical.com> > > minor change, indenting is one tab out. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Applied to ath.git, thanks. -- Kalle Valo -- To unsubscr

Re: Fixing full name in patchwork

Sudip Mukherjee <sudipm.mukher...@gmail.com> writes: > On Tue, Dec 08, 2015 at 09:54:41AM +0200, Kalle Valo wrote: >> Sudip Mukherjee <sudipm.mukher...@gmail.com> writes: >> >> > On Mon, Dec 07, 2015 at 08:03:54PM +0200, Kalle Valo wrote: >>

Re: Fixing full name in patchwork

Sudip Mukherjee <sudipm.mukher...@gmail.com> writes: > On Mon, Dec 07, 2015 at 08:03:54PM +0200, Kalle Valo wrote: >> Hi Sudip, >> >> Sudip Mukherjee <sudipm.mukher...@gmail.com> writes: >> >> > We were dereferencing cmd first and checkin

Re: [PATCH] rtlwifi: fix gigantic memleak in rtl_usb

uld be great if somebody could update the documentation. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

pull-request: wireless-drivers-next 2015-12-07

mbine code iwlwifi: print index in api/capa flags parsing message iwlwifi: mvm: add 9000-series RX API Julia Lawall (1): brcmfmac: constify brcmf_bus_ops structures Kalle Valo (8): ath10k: fix otp board id error message ath10k: reorganise hardware and firmware info messages

Fixing full name in patchwork

me in patchwork so that in the future we can use your correct full name? The problem is that I don't know exactly how to do this but it should be possible because I remember someone else having a similar problem and he was able to fix it. -- Kalle Valo -- To unsubscribe from this list: send t

Re: [PATCH v2] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree

Kalle Valo <kv...@qca.qualcomm.com> writes: > Brent Taylor <moto...@gmail.com> writes: > >> Signed-off-by: Brent Taylor <moto...@gmail.com> >> >> ath6kl: Use vmalloc for loading firmware using api1 method and free using >> kvfree >> --- &

<    3   4   5   6   7   8   9   10   >