...@codeaurora.org; Larry Finger
Subject: Re: rtlwifi/rtl8192cu AP mode broken with PS STA
On 08.04.2021 21:04, Maciej S. Szmigiero wrote:
On 08.04.2021 06:42, Pkshih wrote:
-Original Message-
From: Maciej S. Szmigiero [mailto:m...@maciej.szmigiero.name]
Sent: Thursday, April 08, 2021 4:53
On 4/6/21 9:48 PM, Pkshih wrote:
On Tue, 2021-04-06 at 11:25 -0500, Larry Finger wrote:
On 4/6/21 7:06 AM, Maciej S. Szmigiero wrote:
On 06.04.2021 12:00, Kalle Valo wrote:
"Maciej S. Szmigiero" writes:
On 29.03.2021 00:54, Maciej S. Szmigiero wrote:
Hi,
It looks like rtlwifi
On 4/6/21 7:06 AM, Maciej S. Szmigiero wrote:
On 06.04.2021 12:00, Kalle Valo wrote:
"Maciej S. Szmigiero" writes:
On 29.03.2021 00:54, Maciej S. Szmigiero wrote:
Hi,
It looks like rtlwifi/rtl8192cu AP mode is broken when a STA is using PS,
since the driver does not update its beacon to acc
0,7 +2450,6 @@ struct rtl_locks {
spinlock_t waitq_lock;
spinlock_t entry_list_lock;
spinlock_t usb_lock;
- spinlock_t c2hcmd_lock;
spinlock_t scan_list_lock; /* lock for the scan list */
/*FW clock change */
Acked-by: Larry Finger
Thanks,
Larry
table[i] = coef[i];
+ coef[i] = table[i];
else
coef[i] = 0;
}
Acked-by: Larry Finger
Good catch, thanks.
Larry
On 2/2/21 12:29 AM, Kalle Valo wrote:
Kai-Heng Feng writes:
On Wed, Aug 5, 2020 at 7:24 PM Kai-Heng Feng
wrote:
Hi Tony,
On Aug 5, 2020, at 19:18, Tony Chuang wrote:
8821CE with RFE 2 isn't supported:
[ 12.404834] rtw_8821ce :02:00.0: rfe 2 isn't supported
[ 12.404937] rtw_8821
On 1/8/21 9:32 AM, Aditya Srivastava wrote:
There are certain conditional expressions in rtlwifi, where a boolean
variable is compared with true/false, in forms such as (foo == true) or
(false != bar), which does not comply with checkpatch.pl (CHECK:
BOOL_COMPARISON), according to which boolean v
On 1/5/21 5:55 AM, Joe Perches wrote:
On Tue, 2021-01-05 at 17:11 +0530, Bhaskar Chowdhury wrote:
On 22:24 Tue 05 Jan 2021, Julian Calaby wrote:
Hi Bhaskar,
[]
and your change is just making this comment worse.
really??? Not sure about it.
I agree with Julian. I'm fairly sure it's worse.
On 11/17/20 7:53 PM, Jia-Ju Bai wrote:
In rtl88ee_tx_fill_cmddesc(), skb->data is mapped to streaming DMA on
line 677:
dma_addr_t mapping = dma_map_single(..., skb->data, ...);
On line 680, skb->data is assigned to hdr after cast:
struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)(skb->d
quot;David S. Miller"
Cc: Jakub Kicinski
Cc: Larry Finger
Cc: linux-wirel...@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wire
: Larry Finger
Larry
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c
b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c
index d4cd186036fd..bb5a0c4aec93 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c
: Larry Finger
Larry
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c
b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c
index 2deadc7339ce..f849291cc587 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c
(-)
Acked-by: Larry Finger
Larry
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c
b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c
index 3c7ba8214daf..0748aedce2ad 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi
(-)
Acked-by: Larry Finger
Larry
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
index b2e5b9fda669..33ffc24d3675 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi
(-)
Acked-by: Larry Finger
Larry
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c
b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c
index 3061bd81f39e..6312fddd9c00 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi
/phy.c:1839:5-13: WARNING:
Comparison to bool
Signed-off-by: Zheng Bin
---
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Acked-by: Larry Finger
Larry
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
b
: Larry Finger
Larry
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
index d7afb6a186df..2890a495a23e 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu
(+), 1 deletion(-)
Acked-by: Larry Finger
Larry
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c
b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c
index fc6c81291cf5..6a3deca404b9 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c
+++ b
-
.../wireless/realtek/rtlwifi/rtl8723be/trx.c | 13 +-
.../wireless/realtek/rtlwifi/rtl8821ae/hw.c | 9 +-
.../wireless/realtek/rtlwifi/rtl8821ae/trx.c | 13 +-
12 files changed, 115 insertions(+), 132 deletions(-)
Tested-by: Larry Finger for rtl8821ae.
Larry
On 7/27/20 9:52 AM, Joe Perches wrote:
On Mon, 2020-07-27 at 09:04 +, Pkshih wrote:
So, I think you would like to have parenthesis intentionally.
If so,
test1 ? : (test2 ? :)
would be better.
If not,
test1 ? : test2 ? :
may be what you want (without any parenthesis).
Use whatever style y
OK, but the subject is wrong. It should be "[PATCH-next] rtl8187:
Remove "
With that change, ACKed-by: Larry Finger
Larry
On 5/14/19 8:07 AM, Jia-Ju Bai wrote:
In rtl_pci_probe(), when request_irq() in rtl_pci_intr_mode_legacy() in
rtl_pci_intr_mode_decide() fails, a crash occurs.
The crash information is as follows:
[ 108.271155] kasan: CONFIG_KASAN_INLINE enabled
[ 108.271163] kasan: GPF could be caused by NUL
On 3/2/19 12:09 PM, David R. Bergstein wrote:
Larry,
I tried using iw but it gives the same reading for bit rate. In regard
to the firmware, it was not installed via "make install" so I did it
manually.
David,
There was a typo in the Makefile. 'make install' now installs the firmware
correc
On 3/1/19 9:52 PM, David R. Bergstein wrote:
Larry,
Sorry about all these extra replies. Shortly after I sent my last
message my access point started recognizing the connection as 802.11ac
with PHY Rate / Modulation Rate of 866.6 Mbps. What is somewhat
misleading is the information reported by
On 3/1/19 4:26 PM, David R. Bergstein wrote:
Larry,
Thanks for the response and detailed instructions, which allowed me to
build and install the rtw88 kernel module. I cannot however seem to get
my system to actually use the module. Just to recap this is an HP Omen
laptop with secure boot disa
On 2/28/19 8:32 PM, David R. Bergstein wrote:
Tony,
Thanks for your response. Can you advise as to the availability of the
new rtw88 driver? As it appears to be under development, I could not
locate a copy of the code for local compilation.
David,
Use the command 'git clone http://github.co
The file was sent to me by Max Chou .
Signed-off-by: Larry Finger
Cc: Max Chou
---
WHENCE | 2 ++
rtl_bt/rtl8822cu_fw.bin | Bin 22412 -> 41588 bytes
2 files changed, 2 insertions(+)
diff --git a/WHENCE b/WHENCE
index 853990b..351b312 100644
--- a/WHENCE
+++ b/WHE
On 1/17/19 1:29 PM, Joe Perches wrote:
On Thu, 2019-01-17 at 15:28 +, Colin King wrote:
From: Colin Ian King
There is a statement that is indented too deeply. Fix this.
Thanks.
diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c
b/drivers/net/wireless/realtek/rtl818x/rtl81
On 1/8/19 4:49 PM, Bernd Edlinger wrote:
Currently the rtl8723ae driver is broken (since v4.7).
Connection to AP is lost very often, especially when
the signal level is not very good.
The main issue is the power save mode is basically
not working, and seems to trigger a firmware bug.
So I had t
On 1/5/19 12:38 PM, Bernd Edlinger wrote:
Currently the rtl8723ae driver is broken (since v4.7).
Connection to AP is lost very often, especially when
the signal level is not very good.
The main issue is the power save mode is basically
not working, and seems to trigger a firmware bug.
So I had
On 1/5/19 10:30 AM, Bernd Edlinger wrote:
On 1/5/19 5:13 PM, Larry Finger wrote:
but this works:
modprobe rtl8723ae debug_mask=0x debug_level=5 swlps=1 fwlps=0
Yes, I think that is a better thing to do now. If and when Realtek finds a
firmware bug, and when the new firmware is
On 1/5/19 5:31 AM, Bernd Edlinger wrote:
On 1/5/19 3:44 AM, Larry Finger wrote:
On 1/4/19 6:48 AM, Bernd Edlinger wrote:
This appears to trigger a firmware bug and causes severe
problems with rtl8723ae PCI devices.
When the power save mode is activated for longer periods
of time the firmware
On 1/4/19 6:48 AM, Bernd Edlinger wrote:
This appears to trigger a firmware bug and causes severe
problems with rtl8723ae PCI devices.
When the power save mode is activated for longer periods
of time the firmware stops to receive any packets.
This problem was exposed by commit 873ffe154ae0 ("rt
el Straube
Cc: Ivan Safonov
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_security.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c
b/drivers/staging/rtl8188eu/core/rtw_security.c
index 052656a22821..bab96
el Straube
Cc: Ivan Safonov
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c
b/drivers/staging/rtl8188eu/core/rtw_security.c
index f7407632e80b..05265
ll be more intrusive. My original attempt failed, thus I am
delaying that fix.
Cc: Michael Straube
Cc: Ivan Safonov
Signed-off-by: Larry Finger
---
Larry Finger (2):
staging: rtl8188eu: Fix module loading from tasklet for CCMP
encryption
staging: rtl8188eu: Fix module loading from taskl
This entry was missed when the driver was added.
Signed-off-by: Larry Finger
---
Greg,
Because this driver is in staging, I am sending it to you. I hope that is OK.
Larry
---
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f4855974f325
return ret;
Good catch.
ACKed-by: Larry Finger
Thanks,
Larry
ecvframe_attrib().")
Cc: Stable
Cc: youling257
Cc: u.srikant.patn...@gmail.com
Reported-and-tested-by: youling257
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal
When strncpy() is called with source and destination strings the same
length, gcc 8 warns that there may be an unterminated string. Using
strlcpy() rather than strncpy() forces a null at the end and quiets the
warning.
Signed-off-by: Larry Finger
---
v2 - No changes.
---
drivers/staging/rtl8712
When strncpy() is called with source and destination strings the same
length, gcc 8 warns that there may be an unterminated string. This section
is completely reworked to use the known lengths of the strings.
Signed-off-by: Larry Finger
---
v2 - David Laight's comments are implem
When the size argument in a call to strncpy() is the size of the
destimation, gcc8 issues a warning. These patches fix the potential
problem.
Signed-off-by: Larry Finger
v2 - The code is changed to implement the comments of David Laight.
Larry Finger (2):
staging: rtl8192e: Fix compiler
When strncpy() is called with source and destination strings the same
length, gcc 8 warns that there may be an unterminated string. Using
strlcpy() rather than strncpy() forces a null at the end and quiets the
warning.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8712
When strncpy() is called with source and destination strings the same
length, gcc 8 warns that there may be an unterminated string. Using
strlcpy() rather than strncpy() forces a null at the end and quiets the
warning.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8192e/rtllib_softmac.c
When the size argument in a call to strncpy() is the size of the
destimation, gcc8 issues a warning. These patches fix the potential
problem by replacing the strncpy() with strlcpy().
Signed-off-by: Larry Finger
Larry Finger (2):
staging: rtl8192e: Fix compiler warning about strncpy
On 04/03/2018 09:37 PM, João Paulo Rechi Vita wrote:
On Tue, Apr 3, 2018 at 7:28 PM, Larry Finger wrote:
(...)
As the antenna selection code changes affected your first bisection, do you
have one of those HP laptops with only one antenna and the incorrect coding
in the FUSE?
Yes, that is
On 04/03/2018 08:51 PM, João Paulo Rechi Vita wrote:
Hello,
I've been trying to track a performance regression on the RTL8723BE
WiFi adapter, which mainly affects the upload bandwidth (although we
can see a decreased download performance as well, the effect on upload
is more drastic). This was f
: Larry Finger
On 03/11/2018 08:43 PM, Tobin C. Harding wrote:
The kernel would like to have all stack VLA usage removed[1]. rsi uses
a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size
is defined using a magic number. We can use a pre-processor defined
constant and declare the array to m
These devices are new models from Realtek. Updates to driver btrtl will
soon be submitted to the kernel.
These files were provided by the Realtek developer.
Signed-off-by: 陆朱伟
Signed-off-by: Larry Finger
---
WHENCE | 5 +
rtl_bt/rtl8723d_config.bin | Bin 0 ->
(u32)hdr->addr1[4], (u32)hdr->addr1[5]);
- memcpy(IEEE80211_SKB_RXCB(skb), rx_status, sizeof(*rx_status));
ieee80211_rx(hw, skb);
}
Argh. Once again I got tripped up on pointers. Yes, this patch is correct.
Acked-by: Larry Finger
Sorry about the noise.
Larry
On 02/09/2018 07:24 AM, Arnd Bergmann wrote:
gcc-8 points out that source and destination of the memcpy() are
always the same pointer, so the effect of memcpy() is undefined
here (its arguments must not overlap):
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c: In function
'_rtl_rx_process
lete the branch with the self-assignment.
Signed-off-by: Matthias Kaehlcke
---
Changes in v2:
- Delete the 'else if' branch entirely
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c | 3 ---
1 file changed, 3 deletions(-)
Acked-by: Larry Finger
diff --git a/drivers/net/wire
On 02/07/2018 02:26 PM, Matthias Kaehlcke wrote:
In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal
is assigned to itself in an if ... else statement, apparently only to
document that the branch condition is handled and that a previously read
value should be returned unmodified
On 01/08/2018 03:26 PM, Rasmus Villemoes wrote:
Ctrl-V was hit twice when these macros were inserted:
$ sed -n '9,527p' ./drivers/net/wireless/broadcom/b43/radio_2056.h | md5sum
4db53450c59d9939e903d4e4ba6bc9b1 -
$ sed -n '528,1046p' ./drivers/net/wireless/broadcom/b43/radio_2056.h | md5sum
4db
msleep in v1.
Thank Larry for good advice.
---
I agree that a sleep of 2-3 ms should be OK here.
Acked-by: Larry Finger
Larry
drivers/net/wireless/broadcom/b43/phy_n.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/b43/phy_n.c
b
On 01/09/2018 10:43 AM, Colin King wrote:
From: Colin Ian King
Variable fw_ps_state is assigned a value but it is never read, hence
it is redundant and can be removed.
Acked-by: Larry Finger
Thanks,
Larry
Cleans up clang warning:
drivers/net/wireless/realtek/rtlwifi/btcoexist
On 01/08/2018 10:21 AM, Kalle Valo wrote:
Jia-Ju Bai wrote:
b43_radio_2057_init_post is not called in an interrupt handler
nor holding a spinlock.
The function mdelay in it can be replaced with msleep, to reduce busy wait.
Signed-off-by: Jia-Ju Bai
You submitted an identical patch a week e
A driver for the RTL8723DE is nearing submission to staging. This commit
supplies
the firmware for it.
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
---
WHENCE | 9 +
rtlwifi/rtl8723defw.bin | Bin 0 -> 27726 bytes
2 files changed, 9 insertions(+)
create mode 100
On 12/30/2017 05:08 AM, Jia-Ju Bai wrote:
b43_radio_2057_init_post is not called in an interrupt handler
nor holding a spinlock.
The function mdelay in it can be replaced with msleep, to reduce busy wait.
Signed-off-by: Jia-Ju Bai
checkpatch.pl reports the following warning for this patch:
W
u cfg for btcoexist.")
Signed-off-by: Nicolas Iooss
Looks good. Acked-by: Larry Finger
Thanks,
Larry
---
drivers/net/wireless/realtek/rtlwifi/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c
b/drivers/net/wireless
not a wireless interface
and therefore it fails to work correctly with it thereafter.
This problem was reported and tested at
https://github.com/lwfinger/rtl8188eu/issues/234.
Signed-off-by: Larry Finger
---
v2 - completed missing subject
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 14
not a wireless interface
and therefore it fails to work correctly with it thereafter.
This problem was reported and tested at
https://github.com/lwfinger/rtl8188eu/issues/234.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 14 --
1 file changed, 4
is not all that
important, but it does get used, so we probably want the
patch backported to stable kernels.
Cc: sta...@vger.kernel.org
Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82839
Signed-off-by: Arnd Bergmann
For all three of these patches:
Acked-by: Larry Finger
Thanks,
:1750:22: warning: Value
stored to 'cfg_cmd' during its initialization is never read
Signed-off-by: Colin Ian King
Looks OK to me.
Acked-by: Larry Finger
Thanks,
Larry
---
drivers/net/wireless/realtek/rtlwifi/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The kbuild test robot reports two conditions with no effect (if == else).
These are the result of copy and paste typographical errors.
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
Cc: kbuild-...@01.org
Cc: Julia Lawall
lue[max_level]);
This condition is caused when a loop falls through. The fix is to pin
max_level to be >= 0.
Signed-off-by: Larry Finger
c: kbuild test robot
Fixes: 9ce99b04b5b82fdf11e4c76b60a5f82c1e541297 staging: r8822be: Add phydm
mini driver
---
drivers/staging/rtlwifi/phydm/phydm_dig.
On 09/21/2017 06:37 AM, Zwindl wrote:
Hi, I've reported to archlinux's bugzilla, and finally found out the flag which
caused that issue, it's the `CONFIG_INTEL_IOMMU_DEFAULT_ON=y` flag, I think may
this is a kernel bug, more details at https://bugs.archlinux.org/task/55665
My standard kernel h
On 09/16/2017 06:27 AM, Zwindl wrote:
Hi, I've done the test, and the weird thing happened. The kernel buit with this
config file https://ptpb.pw/HF1g which is from
https://aur.archlinux.org/packages/linux-git/ can run properly, the wifi can
connect, despite which version it is, but, with this
On 09/15/2017 12:12 PM, Zwindl wrote:
Thanks for your patient and advice, I'll keep that in mind.
I do want help, and I got 1 day to build the system, but I can't recall how to
compile it, The last time I compile kernel is 2013, so, maybe I'll ask you so
many stupid questions during the build t
On 09/15/2017 05:10 AM, Zwindl wrote:
Original Message
Subject: Re: RTL8192EE PCIe Wireless Network Adapter crashed with linux-4.13
Local Time: 14 September 2017 6:05 PM
UTC Time: 14 September 2017 18:05
From: larry.fin...@lwfinger.net
To: Zwindl , linux-wirel...@vger.kernel.o
On 09/14/2017 08:30 AM, Zwindl wrote:
Dear developers:
I'm using Arch Linux with testing enabled, the current kernel version and
details are
`Linux zwindl 4.13.2-1-ARCH #1 SMP PREEMPT Thu Sep 14 02:57:34 UTC 2017 x86_64
GNU/Linux`.
The wireless card can't work properly from the kernel 4.13. Her
On 08/30/2017 11:46 AM, Gustavo A. R. Silva wrote:
Function halbtc_get_wifi_rssi always returns rtlpriv->dm.undec_sm_pwdb.
So this function can be removed and the value of
rtlpriv->dm.undec_sm_pwdb assigned to *s32_tmp directly.
This issue was first reported by Coverity as "identical code for di
On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote:
Refactor code in order to avoid identical code for different branches.
This issue was detected with the help of Coccinelle.
Addresses-Coverity-ID: 1226788
Signed-off-by: Gustavo A. R. Silva
---
This issue was reported by Coverity and it was te
On 08/30/2017 12:04 PM, Gustavo A. R. Silva wrote:
Refactor code in order to avoid identical code for different branches.
Addresses-Coverity-ID: 1248728
Signed-off-by: Gustavo A. R. Silva
According to Realtek, this change is OK.
Acked-by: Larry Finger
Thanks,
Larry
---
This issue was
Some useless debugging code from the initial writing of the driver was not
removed before it was submitted. That oversight is now fixed and the
remaining code in routine deinit_priv() is simplified.
Larry
Larry Finger (2):
staging: r8822be: Remove some dead code
staging: r8822be: Simplify
The code found inside an #ifdef CONFIG_RTL_DEBUG ... #endif section
is left over from debugging of the original driver, and should be
deleted.
Reported by: Andreas Ziegler
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
Now that the extraneous debugging code is removed, routine deinit_priv()
clearly contains code that serves no useful purpose.
A null test before a call to kfree() and a spurious cast are also removed.
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc
On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote:
Refactor code in order to avoid identical code for different branches.
This issue was detected with the help of Coccinelle.
Addresses-Coverity-ID: 1226788
Signed-off-by: Gustavo A. R. Silva
---
This issue was reported by Coverity and it was te
On 08/30/2017 02:58 AM, Andreas Ziegler wrote:
Indeed, sorry I missed that as well.
So what should we make of that #ifdef? The code inside it doesn't compile
(anymore? I didn't find any development history for that patch except the
original mail), as there is no definition of struct submit_ctx i
On 08/29/2017 06:30 AM, Andreas Ziegler wrote:
The debugging output in deinit_priv is guarded by an #ifdef using
CONFIG_RTL_DEBUG. This symbol does not exist and should be
CONFIG_RTLWIFI_DEBUG instead.
Signed-off-by: Andreas Ziegler
NACK.
Yes, there is a problem; however, CONFIG_RTLWIFI_DEB
A driver for the RTL8822BE has been added to staging. This commit supplies
the firmware for it.
Signed-off-by: Larry Finger
---
WHENCE | 9 +
rtlwifi/rtl8822befw.bin | Bin 0 -> 127496 bytes
2 files changed, 9 insertions(+)
create mode 100644 rtlwifi/rtl8822befw.
On 08/24/2017 08:54 PM, Andrew Lunn wrote:
netdev frowns upon debugfs. You should try to keep this altogether,
making it easy to throw away before the driver is moved out of
staging.
You might want to look at ethtool -d. That will be accepted.
Andrew,
What is the problem with debugfs?
Please
access btcoex's common status.
2. remove obsolete field bt_exist
Signed-off-by: Ping-Ke Shih
Signed-off-by: Larry Finger
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
---
drivers/staging/rtlwifi/debug.c | 226
1 file changed, 1
On 08/17/2017 04:07 PM, tedheadster wrote:
Larry, you've migrated a bunch of staging code, and tried various
approaches. Do you have any lessons on what has worked and what hasn't
and if there is anything we can do to make the process better?
I am also quite interested in such work. We asked
This commit adds the TODO file and implements some reviewers comments
made against some patches to the wireless tree.
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
---
drivers/staging/rtlwifi/TODO | 8
into a single module r8822be. When this driver is
moved to the wireless tree, halmac, phydm, and rtl8822be will become
new modules.
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
---
drivers/staging/Kconfig
are no changes other than removing all EXPORT
statements, and the fixing of checkpatch messages. The latter will
be backported to the wireless tree.
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
---
drivers/staging/rtlwifi
code into the main wireless tree in small pieces.
To minimize interference between the rtlwifi drivers in the wireless tree
and this new driver, the new one can only be built as a module. In
addition, all code is built into a single module.
Larry Finger
Signed-off-by: Larry Finger
Cc: Ping-Ke
On 08/08/2017 11:05 AM, Arvind Yadav wrote:
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by work with
const usb_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav
---
Acked-by: Larry Finger
Thanks
On 07/18/2017 03:41 PM, Gustavo A. R. Silva wrote:
Remove useless local variables last_read_point and last_txw_point and
the code related.
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 6 --
1 file changed, 6 deletions(-)
Acked-by: Larry
filename
2833945 123790 ece realtek/rtlwifi/rtl8192de/sw.o
File size After adding 'const':
text data bss dec hex filename
2929849 123790 ece realtek/rtlwifi/rtl8192de/sw.o
Signed-off-by: Arvind Yadav
Acked
On 06/19/2017 03:18 PM, Joe Perches wrote:
Joe Perches (5):
rtlwifi: Use temporary ops variable to reduce code size
rtlwifi: Use temporary variable btc_ops for rtlpriv->btcoexist.btc_ops
rtlwifi: Add and use convenience macro rtl_btc
realtek: btcoexist: Make the rtl_btc_ops struct con
On 06/13/2017 03:42 PM, Gustavo A. R. Silva wrote:
Remove unused variable rtlhal.
Addresses-Coverity-ID: 1248810
Signed-off-by: Gustavo A. R. Silva
---
NACK!! That variable is used in file core.c in driver rtlwifi, which is loaded
and used by rtl8821ae.
Please do more than blindly follow C
On 06/01/2017 11:11 AM, Jonathan Corbet wrote:
On Thu, 01 Jun 2017 09:05:07 +0800
Jia-Ju Bai wrote:
I admit my patches are not well tested, and they may not well fix the bugs.
I am looking forward to opinions and suggestions :)
May I politely suggest that sending out untested locking changes
leeping while executing an interrupt.
This removes usage of the irq_lock spinlock, but introduces
a new hardirq_lock, which is _only_ used for the PCI/SSB lowlevel
hard-irq handler. Sleeping busses (SDIO) will use mutex instead.
Signed-off-by: Michael Buesch
Tested-by: Larry
On 05/31/2017 05:29 AM, Jia-Ju Bai wrote:
The driver may sleep under a spin lock, and the function call path is:
b43legacy_attr_interfmode_store (acquire the lock by spin_lock_irqsave)
b43legacy_radio_set_interference_mitigation
b43legacy_radio_interference_mitigation_disable
b43le
On 05/17/2017 04:52 PM, Gustavo A. R. Silva wrote:
Hello everybody,
While looking into Coverity ID 1362263 I ran into the following piece of code at
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1000:
1000void exhalbtc_set_ant_num(struct rtl_priv *rtlpriv, u8 type, u8 ant_num
On 04/16/2017 01:09 PM, rupert THURNER wrote:
On Sun, Apr 16, 2017 at 6:02 PM, Larry Finger wrote:
On 04/16/2017 05:23 AM, rupert THURNER wrote:
On Sat, Apr 15, 2017 at 10:40 PM, Larry Finger
wrote:
On 04/14/2017 03:26 PM, rupert THURNER wrote:
On Thu, Feb 9, 2017 at 9:09 PM, Larry
On 04/16/2017 05:23 AM, rupert THURNER wrote:
On Sat, Apr 15, 2017 at 10:40 PM, Larry Finger
wrote:
On 04/14/2017 03:26 PM, rupert THURNER wrote:
On Thu, Feb 9, 2017 at 9:09 PM, Larry Finger
wrote:
On 02/09/2017 01:43 PM, Bjorn Helgaas wrote:
[+cc rtl8192ce folks in case they've
1 - 100 of 523 matches
Mail list logo
