Re: [PATCH v2 0/7] remove different PHY fixups

Hi Russell, sorry for the noise of this arriving in your inbox twice. Apparently I messed up and replied in private in my last mail. Am Dienstag, dem 13.04.2021 um 11:51 +0100 schrieb Russell King - ARM Linux admin: > On Tue, Apr 13, 2021 at 12:00:45PM +0200, Lucas Stach wrote: > > I a

Re: [PATCH v2 0/7] remove different PHY fixups

ke such a case is to apply this series and look for any fallout. So for what it is worth: Acked-by: Lucas Stach > regards, > Oleksij > > Oleksij Rempel (7): >   ARM: imx6q: remove PHY fixup for KSZ9031 >   ARM: imx6q: remove TX clock delay of ar8031_phy_fixup() >   ARM:

[PATCH] can: m_can_platform: don't call m_can_class_suspend in runtime suspend

04c5743694 (can: m_can_platform: remove unnecessary m_can_class_resume() call) Signed-off-by: Lucas Stach --- drivers/net/can/m_can/m_can_platform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_platfo

[PATCH] can: m_can_platform: don't call m_can_class_suspend in runtime suspend

04c5743694 (can: m_can_platform: remove unnecessary m_can_class_resume() call) Signed-off-by: Lucas Stach --- drivers/net/can/m_can/m_can_platform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_platfo

Re: [PATCH 2/2] ethtool: Add 100BaseT1 and 1000BaseT1 link modes

Am Freitag, den 31.05.2019, 14:30 +0200 schrieb Andrew Lunn: > > That's not just theory. The Broadcom BCM54811 PHY supports both > > 100/1000baseT, as well as 100baseT1. > > Hi Lucus > > There does not appear to be a driver for it, which is why i've not > seen it, nor have we had this conversatio

Re: [PATCH 2/2] ethtool: Add 100BaseT1 and 1000BaseT1 link modes

Am Freitag, den 31.05.2019, 13:59 +0200 schrieb Andrew Lunn: > > > @@ -634,10 +636,14 @@ static void dump_link_caps(const char *prefix, > > > const char *an_prefix, > > > > > >     "100baseT/Half" }, > > > > > >   { 1, ETHTOOL_LINK_MODE_100baseT_Full_BIT, > > > > > >  

Re: [PATCH] net: fec: add necessary defines to work on ARM64

Hi Andy, Am Donnerstag, den 18.01.2018, 01:49 + schrieb Andy Duan: > From: Lucas Stach Sent: Thursday, January > 18, 2018 2:31 AM > > The i.MX8 is a ARMv8 based SoC, that uses the same FEC IP as the > > earlier, > > ARMv7 based, i.MX SoCs. Allow the driver to work o

[PATCH] net: fec: add necessary defines to work on ARM64

The i.MX8 is a ARMv8 based SoC, that uses the same FEC IP as the earlier, ARMv7 based, i.MX SoCs. Allow the driver to work on ARM64. Signed-off-by: Lucas Stach --- drivers/net/ethernet/freescale/fec.h | 5 +++-- drivers/net/ethernet/freescale/fec_main.c | 8 +--- 2 files changed, 8

Re: [PATCH 1/3] net: phy: add support to detect 100BASE-T1 capability

Am Donnerstag, den 14.12.2017, 10:46 +0100 schrieb Andrew Lunn: > > > Hi Lucas > > > > > > Why did you decide to do this, and not add a SUPPORTED_100baseT1? > > > > > > Could a device support both 100-BASE-T and 100-BASE-T1?  If at > > > some > > > point we need to differentiate between them, it

Re: [PATCH 1/3] net: phy: add support to detect 100BASE-T1 capability

Hi Andrew, Am Mittwoch, den 13.12.2017, 21:11 +0100 schrieb Andrew Lunn: > On Wed, Dec 13, 2017 at 06:37:49PM +0100, Lucas Stach wrote: > > 100BASE-T1 is the automotive ethernet standard 802.3bw-2015. > > Currently > > we don't detect any valid modes for PHYs, which only

[PATCH 1/3] net: phy: add support to detect 100BASE-T1 capability

100BASE-T1 is the automotive ethernet standard 802.3bw-2015. Currently we don't detect any valid modes for PHYs, which only support this standard. Add support to detect the common 100Mbit full-duplex mode. Signed-off-by: Lucas Stach --- drivers/net/phy/phy_device.c | 2 ++ include/uapi/

[PATCH 2/3] net: phy: select sensible mode for non-autoneg PHYs on startup

Init speed and duplex to unknown, so phy_lookup_setting() knows that it should select the mode only based on the PHY allowed link modes. Signed-off-by: Lucas Stach --- drivers/net/phy/phy-core.c | 5 + drivers/net/phy/phy_device.c | 2 ++ 2 files changed, 7 insertions(+) diff --git a

[PATCH 3/3] net: phy: sanitize autoneg in phy_start_aneg_priv

-by: Lucas Stach --- drivers/net/phy/phy.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 2b1e67bc1e73..433d859b6955 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -226,10 +226,6 @@ static void

[PATCH 2/2] net: fec: optimize IRQ handler

n this case napi_schedule_prep() will reject the scheduling attempt, but the flow can still be optimized by not trying to schedule if the IRQ doesn't signal RX or TX completion. Signed-off-by: Lucas Stach --- drivers/net/ethernet/freescale/fec_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 de

[PATCH 1/2] net: fec: don't ack masked interrupt events

ently masked, as NAPI relies on the masking to hide the IRQs. The current behavior of just acking all interrupts regardless of their mask status opens the driver up the "rotting packet" race-window, as described in the original NAPI-HOWTO, which has been observed in the wild. Signed-off-

Re: [PATCH net-next 1/4] ixgbe: sparc: rename the ARCH_WANT_RELAX_ORDER to IXGBE_ALLOW_RELAXED_ORDER

Am Donnerstag, den 27.04.2017, 12:19 -0500 schrieb Bjorn Helgaas: > [+cc Casey] > > On Wed, Apr 26, 2017 at 09:18:33AM -0700, Alexander Duyck wrote: > > On Wed, Apr 26, 2017 at 2:26 AM, Ding Tianhong > > wrote: > > > Hi Amir: > > > > > > It is really glad to hear that the mlx5 will support RO mo

Re: [PATCH 2/2] ARM: dts: imx6: tag boards that have the HW workaround for ERR006687

Am Dienstag, den 07.06.2016, 12:46 -0700 schrieb Joshua Clayton: > On Thu, 02 Jun 2016 10:25:06 +0200 > Lucas Stach wrote: > > > Am Mittwoch, den 01.06.2016, 17:17 +0100 schrieb Russell King - ARM > > Linux: > > > On Wed, Jun 01, 2016 at 05:29:43PM +0200, Lucas S

Re: [PATCH v2 1/2] ARM: imx6: disable deeper idle states when FEC is active w/o HW workaround

Hi Fugang, Am Montag, den 06.06.2016, 02:00 + schrieb Fugang Duan: > From: Lucas Stach Sent: Saturday, June 04, > 2016 12:31 AM > > > > To: Shawn Guo ; Fugang Duan > om> > > Cc: devicet...@vger.kernel.org; patchwork-...@pengutronix.de; > >

[PATCH v2 2/2] ARM: dts: imx6: tag boards that have the HW workaround for ERR006687

Add the DT property to all boards that have the hardware workaround for erratum ERR006687 present. This allows the CPUidle driver to use the deep idle states, even if the FEC is active. Signed-off-by: Lucas Stach --- v2: Spell out "workaround" to avoid confusion. --- arch/arm/boot/

[PATCH v2 1/2] ARM: imx6: disable deeper idle states when FEC is active w/o HW workaround

safely run a kernel with CPUidle enabled on all i.MX6 boards. Signed-off-by: Lucas Stach Acked-by: David S. Miller (for network changes) --- v2: Spell out "workaround" to avoid confusion. --- Documentation/devicetree/bindings/net/fsl-fec.txt | 3 +++ arch/arm/mach-imx/cpuidle-imx6q.c

Re: [PATCH 2/2] ARM: dts: imx6: tag boards that have the HW workaround for ERR006687

Am Mittwoch, den 01.06.2016, 17:17 +0100 schrieb Russell King - ARM Linux: > On Wed, Jun 01, 2016 at 05:29:43PM +0200, Lucas Stach wrote: > > @@ -97,6 +97,7 @@ > > phy-reset-gpios = <&gpio3 31 0>; > > interrupts-extended

[PATCH 1/2] ARM: imx6: disable deeper idle states when FEC is active w/o HW workaround

safely run a kernel with CPUidle enabled on all i.MX6 boards. Signed-off-by: Lucas Stach --- Documentation/devicetree/bindings/net/fsl-fec.txt | 3 +++ arch/arm/mach-imx/cpuidle-imx6q.c | 16 +++ drivers/net/ethernet/freescale/fec.h | 2 ++ drivers/ne

[PATCH 2/2] ARM: dts: imx6: tag boards that have the HW workaround for ERR006687

Add the DT property to all boards that have the hardware workaround for erratum ERR006687 present. This allows the CPUidle driver to use the deep idle states, even if the FEC is active. Signed-off-by: Lucas Stach --- arch/arm/boot/dts/imx6dl-riotboard.dts | 1 + arch/arm/boot/dts/imx6q

[PATCH 0/2] Software workaround for i.MX6Q/DL ERR006687

interface isn't active. I would prefer if this series gets merged through the imx achitecture tree with acks for the FEC changes from the network people. Regards, Lucas Lucas Stach (2): ARM: imx6: disable deeper idle states when FEC is active w/o HW workaround ARM: dts: imx6: tag board

Re: [PATCH] net: fec: only clear a queue's work bit if the queue was emptied

xt napi > turn and so packets were delayed or lost. > > The obvious fix is to only clear a queue's bit when the queue was > emptied. > > Fixes: 4d494cdc92b3 ("net: fec: change data structure to support multiqueue") > Signed-off-by: Uwe Kleine-König Reviewed-by

Re: [PATCH RFC] b43: stop hardcoding LED behavior

Am Montag, den 25.04.2016, 17:53 +0200 schrieb Michael Büsch: > On Mon, 25 Apr 2016 09:40:51 +0200 > Lucas Stach wrote: > > > > > On my system the SPROM correctly defines the only wired LED (radio) > > but > > skips all others, leading to the hardcode to

[PATCH RFC] b43: stop hardcoding LED behavior

ering only for individual systems that need it. Signed-off-by: Lucas Stach --- drivers/net/wireless/broadcom/b43/leds.c | 26 ++ 1 file changed, 2 insertions(+), 24 deletions(-) diff --git a/drivers/net/wireless/broadcom/b43/leds.c b/drivers/net/wireless/broadcom/b43/l

net: fec: stable queue request

https://bugzilla.kernel.org/show_bug.cgi?id=106171 Thanks, Lucas -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: [PATCH net-next 1/1] net: fec: add netif status check before set mac address

his deserves a comment in the code as to why it is needed and how it still works. Regards, Lucas > + > writel(ndev->dev_addr[3] | (ndev->dev_addr[2] << 8) | > (ndev->dev_addr[1] << 16) | (ndev->dev_addr[0] << 24), >

Re: [PATCH 1/1] Revert "net: fec: Ensure clocks are enabled while using mdio bus"

Am Freitag, den 14.08.2015, 16:14 +0800 schrieb Peter Chen: > On Fri, Aug 14, 2015 at 10:27:33AM +0200, Lucas Stach wrote: > > Am Freitag, den 14.08.2015, 08:25 + schrieb Peter Chen: > > > > > > > > > > > Am Freitag, den 14.08.2015, 13:47 +0800 s

Re: [PATCH 1/1] Revert "net: fec: Ensure clocks are enabled while using mdio bus"

. > > > > > > This reverts commit 8fff755e9f8d0f70a595e79f248695ce6aef5cc3. > > > > > > Cc: netdev@vger.kernel.org > > > Cc: Fugang Duan > > > Cc: shawn@linaro.org > > > Cc: fabio.este...@freescale.com > > > Cc: tyler.ba...@linaro.org > > > Cc: Lucas

Re: [PATCH 1/1] Revert "net: fec: Ensure clocks are enabled while using mdio bus"

hawn@linaro.org > Cc: fabio.este...@freescale.com > Cc: tyler.ba...@linaro.org > Cc: Lucas Stach > Cc: Andrew Lunn > Signed-off-by: Peter Chen > --- > > According to Fugang Duan, the i.mx series has different clock control > sequence among SoCs, this patch may only

[PATCH] can: flexcan: demote register output to debug level

This message isn't really helpful for the general reader of the kernel logs, so should not be printed with info level. All other register programming outputs in the flexcan driver already use the debug level. Signed-off-by: Lucas Stach --- drivers/net/can/flexcan.c | 2 +- 1 file chang

Re: [PATCH] net: fec: fix initial runtime PM refcount

s > > Uwe > > > > On Mon, Aug 03, 2015 at 06:15:54PM +0200, Andrew Lunn wrote: > > > On Mon, Aug 03, 2015 at 05:50:11PM +0200, Lucas Stach wrote: > > > > The clocks are initially active and thus the device is marked active. > > > > This still keeps

Re: [PATCH] net: fec: fix initial runtime PM refcount

Am Montag, den 03.08.2015, 18:15 +0200 schrieb Andrew Lunn: > On Mon, Aug 03, 2015 at 05:50:11PM +0200, Lucas Stach wrote: > > The clocks are initially active and thus the device is marked active. > > This still keeps the PM refcount at 0, the pm_runtime_put_autosuspend() > &g

[PATCH] net: fec: fix initial runtime PM refcount

had been called. Fix this by initializing the refcount to be coherent with the initial device status. Fixes: 8fff755e9f8 (net: fec: Ensure clocks are enabled while using mdio bus) Signed-off-by: Lucas Stach --- Please apply this as a fix for 4.2 --- drivers/net/ethernet/freescale/fec_main.c

[Patch v2 resend 2/2] net: fec: introduce fec_ptp_stop and use in probe fail path

This function frees resources and cancels delayed work item that have been initialized in fec_ptp_init(). Use this to do proper error handling if something goes wrong in probe function after fec_ptp_init has been called. Signed-off-by: Lucas Stach Acked-by: Fugang Duan --- drivers/net

[Patch v2 resend 1/2] net: fec: use managed DMA API functions to allocate BD ring

So it gets freed when the device is going away. This fixes a DMA memory leak on driver probe() fail and driver remove(). Signed-off-by: Lucas Stach --- v2: Fix indentation of second line to fix alignment with opening bracket. --- drivers/net/ethernet/freescale/fec_main.c | 4 ++-- 1 file

Re: [PATCH v2 1/2] net: fec: use managed DMA API functions to allocate BD ring

Am Mittwoch, den 22.07.2015, 01:55 + schrieb Duan Andy: > From: Lucas Stach Sent: Tuesday, July 21, 2015 11:11 > PM > > To: David S. Miller > > Cc: Duan Fugang-B38611; Li Frank-B20596; netdev@vger.kernel.org; > > ker...@pengutronix.de; patchwork-...@pengutronix.de &g

[PATCH v2 1/2] net: fec: use managed DMA API functions to allocate BD ring

So it gets freed when the device is going away. This fixes a DMA memory leak on driver probe() fail and driver remove(). Signed-off-by: Lucas Stach --- v2: Fix indentation of second line to fix alignment with opening bracket. --- drivers/net/ethernet/freescale/fec_main.c | 4 ++-- 1 file

[PATCH v2 2/2] net: fec: introduce fec_ptp_stop and use in probe fail path

This function frees resources and cancels delayed work item that have been initialized in fec_ptp_init(). Use this to do proper error handling if something goes wrong in probe function after fec_ptp_init has been called. Signed-off-by: Lucas Stach --- drivers/net/ethernet/freescale/fec.h

Re: [PATCH] net: fec: fix runtime PM when probing MII bus

Am Montag, den 20.07.2015, 15:59 +0200 schrieb Andrew Lunn: > On Mon, Jul 20, 2015 at 03:48:14PM +0200, Lucas Stach wrote: > > In the case where there is no "mdio" bus specified in the devicetree a plain > > mdiobus_register() will be called, which tries to probe the c

[PATCH 2/2] net: fec: introduce fec_ptp_stop and use in probe fail path

This function frees resources and cancels delayed work item that have been initialized in fec_ptp_init(). Use this to do proper error handling if something goes wrong in probe function after fec_ptp_init has been called. Signed-off-by: Lucas Stach --- drivers/net/ethernet/freescale/fec.h

[PATCH 1/2] net: fec: use managed DMA API functions to allocate BD ring

So it gets freed when the device is going away. This fixes a DMA memory leak on driver probe() fail and driver remove(). Signed-off-by: Lucas Stach --- drivers/net/ethernet/freescale/fec_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale

[PATCH] net: fec: fix runtime PM when probing MII bus

at the RPM callbacks aren't invoked several times during the probe function. Signed-off-by: Lucas Stach --- The offending commit got in with v4.2-rc3, so this should be applied as a fix for 4.2. --- drivers/net/ethernet/freescale/fec_main.c | 9 + 1 file changed, 5 insertions(+), 4 del