Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-08 Thread Mandeep Singh Baines
James Chapman ([EMAIL PROTECTED]) wrote: > Hi Mandeep, > > Mandeep Singh Baines wrote: >> Hi James, >> I like the idea of staying in poll longer. >> My comments are similar to what Jamal and Stephen have already >> said. >> A tunable (via sysfs) would be

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-06 Thread Mandeep Singh Baines
Hi James, I like the idea of staying in poll longer. My comments are similar to what Jamal and Stephen have already said. A tunable (via sysfs) would be nice. A timer might be preferred to jiffy polling. Jiffy polling will not increase latency the way a timer would. However, jiffy polling will

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-05 Thread Mandeep Singh Baines
jamal ([EMAIL PROTECTED]) wrote: > On Wed, 2007-05-09 at 14:55 +0100, James Chapman wrote: > > > Thanks Jamal. Yes, I'd already read your paper. I think my idea is > > different to the ideas described in your paper > > I am hoping you can pick from the lessons of what has been tried and > faile

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-05 Thread Mandeep Singh Baines
e slots in the tx ring. Previously, the driver would wake up the transmit queue if there was just a single slot available. This should result in better hysteresis. Attached are my test results and a new patch. Signed-off-by: Mandeep Singh Baines <[EMAIL PROTECTED]> -- diff --git a/drivers/n

[PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-03 Thread Mandeep Singh Baines
Hi Daniele, Attached is a patch for converting the sis900 driver to NAPI. Please take a look at let me know what you think. I'm not 100% sure if I'm handling the rotting packet issue correctly or that I have the locking right in tx_timeout. These might be areas to look at closely. I didn't see m

Re: pktgen terminating condition

2007-08-28 Thread Mandeep Singh Baines
. So I'm thinking that maybe the driver was written to use this interrupt instead of TxOK for this reason. Really just my speculation. Anyway, if I rewrite the driver to use TxOK instead of TxIdle, pktgen works fine. I'm attaching the patch. Signed-off-by: Mandeep Singh Baines <[EMAIL

pktgen terminating condition

2007-08-28 Thread Mandeep Singh Baines
Hi, I am having some trouble using pktgen with certain NICs. When running pktgen on some NICs, the test stalls because the worker thread is waiting for the driver to free the last skb. If a send a few pings out the interface, the worker thread will eventually unblock. Below is the snippet of code