Re: [PATCH v2 0/2] MCAN: Add support for implementing transceiver as a phy

2021-04-16 Thread Marc Kleine-Budde
patch hits mainline. Then I'll merge this into linux-can-next. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hil

Re: [PATCH v2 2/2] can: m_can: Add support for transceiver as phy

2021-04-15 Thread Marc Kleine-Budde
priv->base = addr; > priv->mram_base = mram_addr; > > @@ -108,6 +120,7 @@ static int m_can_plat_probe(struct platform_device *pdev) > mcan_class->pm_clock_support = 1; > mcan_class->can.clock.freq = clk_get_rate(mcan_class->cclk); > mcan_class->dev

Re: [PATCH][next] can: etas_es58x: Fix missing null check on netdev pointer

2021-04-15 Thread Marc Kleine-Budde
On 15.04.2021 20:42:36, Vincent MAILHOL wrote: > On Thu. 15 Apr 2021 at 18:04, Marc Kleine-Budde wrote: > > On 15.04.2021 09:47:23, Colin King wrote: > > > From: Colin Ian King > > > > > > There is an assignment to *netdev tha

Re: [PATCH][next] can: etas_es58x: Fix a couple of spelling mistakes

2021-04-15 Thread Marc Kleine-Budde
On 15.04.2021 12:30:50, Colin King wrote: > From: Colin Ian King > > There are spelling mistakes in netdev_dbg and netdev_dbg messages, > fix these. > > Signed-off-by: Colin Ian King Applied to linux-can-next/testing. Tnx, Marc -- Pengutronix e.K. |

Re: [PATCH v2 3/6] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

2021-04-15 Thread Marc Kleine-Budde
cumentation/devicetree/bindings/phy folder. Also, > scripts/get_maintainer.pl is giving the names of maintainers after > reading the yaml files too. Nice! Clever script. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.p

Re: [PATCH][next] can: etas_es58x: Fix missing null check on netdev pointer

2021-04-15 Thread Marc Kleine-Budde
verity: ("Dereference before null check") > Fixes: 8537257874e9 ("can: etas_es58x: add core support for ETAS ES58X CAN > USB interfaces") > Signed-off-by: Colin Ian King Looks good. Applied to linux-can-next/testing. Tnx, Marc -- Pengutronix e.K.

Re: [PATCH][next] can: etas_es58x: Fix potential null pointer dereference on pointer cf

2021-04-15 Thread Marc Kleine-Budde
net-next/master https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=e2b1e4b532abdd39bfb7313146153815e370d60c Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertr

Re: [PATCH v2 3/6] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

2021-04-15 Thread Marc Kleine-Budde
On 15.04.2021 11:57:20, Aswath Govindraju wrote: > Hi Marc, > > On 14/04/21 9:03 pm, Marc Kleine-Budde wrote: > > On 14.04.2021 19:35:18, Aswath Govindraju wrote: > >> Add binding documentation for TI TCAN104x CAN transceivers. > >> >

[net-next] can: etas_es58x: fix null pointer dereference when handling error frames

2021-04-14 Thread Marc Kleine-Budde
unachalam Santhanam Signed-off-by: Vincent Mailhol Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/etas_es58x/es58x_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.c b/drivers/net/can/usb/etas_es58x/es58x_core.c

pull-request: can-next 2021-04-14

2021-04-14 Thread Marc Kleine-Budde
Hello Jakub, hello David, this is a pull request of a single patch for net-next/master. Vincent Mailhol's patch fixes a NULL pointer dereference when handling error frames in the etas_es58x driver, which has been added in the previous PR. regards, Marc --- The following changes since commit 58

Re: [PATCH v2 0/6] CAN TRANSCEIVER: Add support for CAN transceivers

2021-04-14 Thread Marc Kleine-Budde
t CAN transceivers. > > Patches 5 & 6 add support for implementing the transceiver as a phy of > m_can_platform driver. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretun

Re: [PATCH v2 4/6] phy: phy-can-transceiver: Add support for generic CAN transceiver driver

2021-04-14 Thread Marc Kleine-Budde
\ > broadcom/\ I'm not sure how the phy framework handles this, but I assume it's alphabetically sorted, too. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengu

Re: [PATCH v2 4/6] phy: phy-can-transceiver: Add support for generic CAN transceiver driver

2021-04-14 Thread Marc Kleine-Budde
/devicetree/bindings/net/can/ > F: Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml > +F: drivers/phy/phy-can-transceiver.c > F: drivers/net/can/ please keep this alphabetically sorted Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embed

Re: [PATCH v2 3/6] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

2021-04-14 Thread Marc Kleine-Budde
mpatible = "ti,tcan1043"; > + #phy-cells = <0>; > + max-bitrate = <500>; > + standby-gpios = <&wakeup_gpio1 16 GPIO_ACTIVE_LOW>; > + enable-gpios = <&main_gpio1 67 GPIO_ACTIVE_LOW>; AFAICS the enable gpio is active high

Re: [PATCH v2 6/6] can: m_can: Add support for transceiver as phy

2021-04-14 Thread Marc Kleine-Budde
t; + else > + priv->cdev.can.bitrate_max = transceiver->attrs.max_link_rate; > + > priv->base = addr; > priv->mram_base = mram_addr; > > @@ -108,6 +122,7 @@ static int m_can_plat_probe(struct platform_device *pdev) > mcan_class->pm_cl

Re: [PATCH 0/4] CAN TRANSCEIVER: Add support for CAN transceivers

2021-04-14 Thread Marc Kleine-Budde
add it CAN NETWORK DRIVERS. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-555

Re: [PATCH 2/4] phy: phy-can-transceiver: Add support for generic CAN transceiver driver

2021-04-13 Thread Marc Kleine-Budde
On 14.04.2021 11:54:36, Aswath Govindraju wrote: > Hi Marc, > > On 12/04/21 3:48 pm, Marc Kleine-Budde wrote: > > On 4/9/21 3:40 PM, Aswath Govindraju wrote: > >> The driver adds support for generic CAN transceivers. Currently > >> the modes supported by this dr

Re: [PATCH] can: etas_es58x: fix null pointer dereference when handling error frames

2021-04-13 Thread Marc Kleine-Budde
d. You might either cancel the pull request > and squash this to 8537257874e9 ("can: etas_es58x: add core support > for ETAS ES58X CAN USB interfaces") or send it as a separate patch. > > Please let me know if you need me to do anything. I'll send a follo

Re: [PATCH v3] dt-bindings: net: can: rcar_can: Document r8a77961 support

2021-04-13 Thread Marc Kleine-Budde
Rob Herring > Reviewed-by: Wolfram Sang Added to latest pull request. Tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht

[net-next 04/14] can: etas_es58x: add support for the ETAS ES58X_FD CAN USB interfaces

2021-04-13 Thread Marc Kleine-Budde
Santhanam Signed-off-by: Vincent Mailhol Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/etas_es58x/Makefile | 2 +- drivers/net/can/usb/etas_es58x/es58x_core.c | 19 +- drivers/net/can/usb/etas_es58x/es58x_core.h | 6 +- drivers/net/can/usb/etas_es58x/es58x_fd.c | 562

[net-next 14/14] can: peak_usb: pcan_usb: replace open coded endianness conversion of unaligned data

2021-04-13 Thread Marc Kleine-Budde
This patch replaces the open coded endianness conversion of unaligned data by the appropriate get/put_unaligned_leXX() variants. Link: https://lore.kernel.org/r/20210406111622.1874957-11-...@pengutronix.de Acked-by: Stephane Grosjean Tested-by: Stephane Grosjean Signed-off-by: Marc Kleine-Budde

[net-next 13/14] can: peak_usb: pcan_usb_get_serial(): unconditionally assign serial_number

2021-04-13 Thread Marc Kleine-Budde
The function serial_number is only called from one location with a valid serial_number pointer. Remove not needed NULL pointer check. Link: https://lore.kernel.org/r/20210406111622.1874957-10-...@pengutronix.de Acked-by: Stephane Grosjean Tested-by: Stephane Grosjean Signed-off-by: Marc Kleine

[net-next 11/14] can: peak_usb: pcan_usb_get_serial(): remove error message from error path

2021-04-13 Thread Marc Kleine-Budde
The caller of pcan_usb_get_serial() already prints an error message, so remove this one and return immediately. Link: https://lore.kernel.org/r/20210406111622.1874957-8-...@pengutronix.de Acked-by: Stephane Grosjean Tested-by: Stephane Grosjean Signed-off-by: Marc Kleine-Budde --- drivers/net

[net-next 08/14] can: peak_usb: remove write only variable struct peak_usb_adapter::ts_period

2021-04-13 Thread Marc Kleine-Budde
The variable struct peak_usb_adapter::ts_period is only ever written to. This patch removes it from the driver. Link: https://lore.kernel.org/r/20210406111622.1874957-5-...@pengutronix.de Acked-by: Stephane Grosjean Tested-by: Stephane Grosjean Signed-off-by: Marc Kleine-Budde --- drivers/net

[net-next 09/14] can: peak_usb: peak_usb_probe(): make use of driver_info

2021-04-13 Thread Marc Kleine-Budde
24 - -24 | peak_usb_probe 236 136-100 | Total: Before=25263, After=25139, chg -0.49% Link: https://lore.kernel.org/r/20210406111622.1874957-6-...@pengutronix.de Acked-by: Stephane Grosjean Tested-by: Stephane Grosjean Signed-off-by: Marc Kl

[net-next 12/14] can: peak_usb: pcan_usb_get_serial(): make use of le32_to_cpup()

2021-04-13 Thread Marc Kleine-Budde
This patch replaces the memcpy() + le32_to_cpu() by le32_to_cpup(). Link: https://lore.kernel.org/r/20210406111622.1874957-9-...@pengutronix.de Acked-by: Stephane Grosjean Tested-by: Stephane Grosjean Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/peak_usb/pcan_usb.c | 8 ++-- 1

[net-next 10/14] can: peak_usb: pcan_usb_{,pro}_get_device_id(): remove unneeded check for device_id

2021-04-13 Thread Marc Kleine-Budde
/20210406111622.1874957-7-...@pengutronix.de Acked-by: Stephane Grosjean Tested-by: Stephane Grosjean Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/peak_usb/pcan_usb.c | 4 ++-- drivers/net/can/usb/peak_usb/pcan_usb_pro.c | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a

[net-next 07/14] can: peak_usb: remove unused variables from struct peak_usb_device

2021-04-13 Thread Marc Kleine-Budde
This patch removes the unused variables struct peak_usb_device::echo_skb and struct peak_usb_device::bus_load from the driver. Link: https://lore.kernel.org/r/20210406111622.1874957-4-...@pengutronix.de Acked-by: Stephane Grosjean Tested-by: Stephane Grosjean Signed-off-by: Marc Kleine-Budde

[net-next 05/14] can: peak_usb: fix checkpatch warnings

2021-04-13 Thread Marc Kleine-Budde
This patch cleans several checkpatch warnings in the peak_usb driver. Link: https://lore.kernel.org/r/20210406111622.1874957-2-...@pengutronix.de Acked-by: Stephane Grosjean Tested-by: Stephane Grosjean Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/peak_usb/pcan_usb.c | 4

[net-next 03/14] can: etas_es58x: add support for ETAS ES581.4 CAN USB interface

2021-04-13 Thread Marc Kleine-Budde
Signed-off-by: Vincent Mailhol Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/etas_es58x/Makefile | 2 +- drivers/net/can/usb/etas_es58x/es581_4.c| 507 drivers/net/can/usb/etas_es58x/es581_4.h| 207 drivers/net/can/usb/etas_es58x/es58x_core.c

[net-next 06/14] can: peak_usb: pcan_usb_pro.h: remove double space in indention

2021-04-13 Thread Marc Kleine-Budde
This patch replaces the double space indention after the u8 with a single space in pcan_usb_pro.h. Link: https://lore.kernel.org/r/20210406111622.1874957-3-...@pengutronix.de Acked-by: Stephane Grosjean Tested-by: Stephane Grosjean Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb

[net-next 01/14] dt-bindings: net: can: rcar_can: Document r8a77961 support

2021-04-13 Thread Marc Kleine-Budde
-by: Geert Uytterhoeven Acked-by: Rob Herring Reviewed-by: Wolfram Sang Signed-off-by: Marc Kleine-Budde --- Documentation/devicetree/bindings/net/can/rcar_can.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b

[net-next 02/14] can: etas_es58x: add core support for ETAS ES58X CAN USB interfaces

2021-04-13 Thread Marc Kleine-Budde
...@wanadoo.fr Co-developed-by: Arunachalam Santhanam Signed-off-by: Arunachalam Santhanam Signed-off-by: Vincent Mailhol Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/Kconfig | 10 + drivers/net/can/usb/Makefile|1 + drivers/net/can/usb/etas_es58x

pull-request: can-next 2021-04-13

2021-04-13 Thread Marc Kleine-Budde
) linux-can-next-for-5.13-20210413 Marc Kleine-Budde (10): can: peak_usb: fix checkpatch warnings can: peak_usb: pcan_usb_pro.h: remove double space in indention can: peak_usb: remove unused

Re: [PATCH 1/4] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

2021-04-13 Thread Marc Kleine-Budde
On 12.04.2021 12:49:56, Rob Herring wrote: > On Mon, Apr 12, 2021 at 12:19:30PM +0200, Marc Kleine-Budde wrote: > > On 4/9/21 3:40 PM, Aswath Govindraju wrote: > > > Add binding documentation for TI TCAN104x CAN transceivers. > > > > > &

Re: [PATCH 4/4] can: m_can_platform: Add support for transceiver as phy

2021-04-12 Thread Marc Kleine-Budde
itrate_max = (transceiver->attrs.max_link_rate) * 100; > + if (!bitrate_max) > + dev_warn(&pdev->dev, "Invalid value for transceiver max > bitrate. Ignoring bitrate limit\n"); Please move this check to the generic transce

Re: [PATCH 1/4] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

2021-04-12 Thread Marc Kleine-Budde
in bps > +minimum: 1 > + > +required: > + - compatible > + - '#phy-cells' > + > +additionalProperties: false > + > +examples: > + - | > +#include > + > +transceiver1: tcan104x-phy { > + compatible = "ti,tcan1043"; > + #phy-cel

Re: [PATCH 2/4] phy: phy-can-transceiver: Add support for generic CAN transceiver driver

2021-04-12 Thread Marc Kleine-Budde
phy_set_drvdata(can_transceiver_phy->generic_phy, can_transceiver_phy); > + > + phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); > + > + return PTR_ERR_OR_ZERO(phy_provider); > +} > + > +static struct platform_driver can_transceiver_phy_driver = { > + .probe = can_transceiver_phy_probe, > + .driver = { > + .name = "can-transceiver-phy", > + .of_match_table = can_transceiver_phy_ids, > + }, > +}; > + > +module_platform_driver(can_transceiver_phy_driver); > + > +MODULE_AUTHOR("Faiz Abbas "); > +MODULE_AUTHOR("Aswath Govindraju "); > +MODULE_DESCRIPTION("CAN TRANSCEIVER PHY driver"); > +MODULE_LICENSE("GPL v2"); > marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: OpenPGP digital signature

Re: [PATCH v15 0/3] Introducing ETAS ES58X CAN USB interfaces

2021-04-12 Thread Marc Kleine-Budde
x_urb_cmd *urb_cmd) I have applied to linux-can-next/testing with the above spell fix. Thanks for the steady work on this and all the other features. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertre

Re: flexcan introduced a DIV/0 in kernel

2021-04-09 Thread Marc Kleine-Budde
On 09.04.2021 14:55:59, Koen Vandeputte wrote: > > On 09.04.21 13:21, Marc Kleine-Budde wrote: > > On 4/9/21 12:18 PM, Koen Vandeputte wrote: > > > Hi All, > > > > > > I just updated kernel 4.14 within OpenWRT from 4.14.224 to 4.14.229 > > >

Re: flexcan introduced a DIV/0 in kernel

2021-04-09 Thread Marc Kleine-Budde
chip_freeze(): fix chip freeze for missing bitrate Greg, can you pick this up for v4.14? regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-92

[net-next 6/6] can: mcp251xfd: mcp251xfd_regmap_crc_read(): work around broken CRC on TBC register

2021-04-07 Thread Marc Kleine-Budde
org/r/20210406110617.1865592-5-...@pengutronix.de Cc: Manivannan Sadhasivam Cc: Thomas Kopp Signed-off-by: Marc Kleine-Budde --- .../net/can/spi/mcp251xfd/mcp251xfd-regmap.c | 34 +++ 1 file changed, 34 insertions(+) diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c b/drivers/net/ca

[net-next 4/6] can: mcp251xfd: add BQL support

2021-04-07 Thread Marc Kleine-Budde
This patch re-adds BQL support to the driver. Support for netdev_xmit_more() will be added in a separate patch series. Link: https://lore.kernel.org/r/20210406110617.1865592-3-...@pengutronix.de Cc: Manivannan Sadhasivam Cc: Thomas Kopp Signed-off-by: Marc Kleine-Budde --- .../net/can/spi

[net-next 2/6] can: m_can: m_can_receive_skb(): add missing error handling to can_rx_offload_queue_sorted() call

2021-04-07 Thread Marc Kleine-Budde
context") Link: https://lore.kernel.org/r/20210401084515.1455013-1-...@pengutronix.de Reported-by: coverity-bot Addresses-Coverity-ID: 1503583 ("Error handling issues") Reviewed-by: Kees Cook Cc: Torin Cooper-Bennun Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/m_ca

[net-next 5/6] can: mcp251xfd: mcp251xfd_regmap_crc_read_one(): Factor out crc check into separate function

2021-04-07 Thread Marc Kleine-Budde
This patch factors out the crc check into a separate function. This is preparation for the next patch. Link: https://lore.kernel.org/r/20210406110617.1865592-4-...@pengutronix.de Cc: Manivannan Sadhasivam Cc: Thomas Kopp Signed-off-by: Marc Kleine-Budde --- .../net/can/spi/mcp251xfd/mcp251xfd

[net-next 3/6] can: c_can: remove unused enum BOSCH_C_CAN_PLATFORM

2021-04-07 Thread Marc Kleine-Budde
This patch removes the unused enum BOSCH_C_CAN_PLATFORM. Link: https://lore.kernel.org/r/20210406110617.1865592-2-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/can/c_can/c_can.h b/drivers/net

pull-request: can-next 2021-04-07

2021-04-07 Thread Marc Kleine-Budde
-next-for-5.13-20210407 Marc Kleine-Budde (6): can: skb: alloc_can{,fd}_skb(): set "cf" to NULL if skb allocation fails can: m_can: m_can_receive_skb(): add missing error handling to can_rx_offload_queue_sorted()

[net-next 1/6] can: skb: alloc_can{,fd}_skb(): set "cf" to NULL if skb allocation fails

2021-04-07 Thread Marc Kleine-Budde
r/20210402102245.1512583-1-...@pengutronix.de Suggested-by: Vincent MAILHOL Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev/skb.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/dev/skb.c b/drivers/net/can/dev/skb.c index 387c0bc0fb9c..61660248

pull-request: can 2021-04-06

2021-04-06 Thread Marc Kleine-Budde
85f04: can: mcp251x: fix support for half duplex SPI host controllers (2021-04-06 12:31:21 +0200) linux-can-fixes-for-5.12-20210406 ---- Marc Kleine-Budde (1): can:

[net] can: mcp251x: fix support for half duplex SPI host controllers

2021-04-06 Thread Marc Kleine-Budde
ey Tested-By: Tim Harvey Reported-by: Gerhard Bertelsmann Signed-off-by: Marc Kleine-Budde --- drivers/net/can/spi/mcp251x.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c index f6

Re: [PATCH net-next v1 2/3] net: phy: at803x: AR8085: add loopback support

2021-03-30 Thread Marc Kleine-Budde
> + * Documentation says nothing about it, so I take time which seems to > + * work on AR8085. > + */ /* Keep in mind the net multi line comment * style. */ Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | h

Re: [PATCH net-next v1 1/3] net: phy: micrel: KSZ8081: add loopback support

2021-03-30 Thread Marc Kleine-Budde
| Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: OpenPGP digital signature

[net-next 36/39] can: c_can: add a comment about IF_RX interface's use

2021-03-30 Thread Marc Kleine-Budde
86-4-dario...@libero.it Signed-off-by: Dario Binacchi Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c index 8212f3d98aa9..980abf6a8609 100644 --- a/drivers/net

[net-next 27/39] can: mcp251xfd: add HW timestamp to RX, TX and error CAN frames

2021-03-30 Thread Marc Kleine-Budde
This patch uses the previously added mcp251xfd_skb_set_timestamp() function to convert the timestamp done by the CAN controller into a proper skb hw timestamp. Link: https://lore.kernel.org/r/20210304161209.2754463-1-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- .../net/can/spi

[net-next 39/39] can: c_can: add support to 64 message objects

2021-03-30 Thread Marc Kleine-Budde
of 32. Two 32-bit read accesses are in fact required, which however remained at 16-bit for configurations with 32 message objects. Link: https://lore.kernel.org/r/20210302215435.18286-7-dario...@libero.it Signed-off-by: Dario Binacchi Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_c

[net-next 38/39] can: c_can: prepare to up the message objects number

2021-03-30 Thread Marc Kleine-Budde
Signed-off-by: Dario Binacchi Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can.c | 50 -- drivers/net/can/c_can/c_can.h | 23 ++-- drivers/net/can/c_can/c_can_pci.c | 2 +- drivers/net/can/c_can/c_can_platform.c | 2 +-

[net-next 34/39] can: c_can: remove unused code

2021-03-30 Thread Marc Kleine-Budde
he removed code also made a comment useless and misleading. Link: https://lore.kernel.org/r/20210302215435.18286-2-dario...@libero.it Signed-off-by: Dario Binacchi Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can.c | 3 +-- drivers/net/can/c_can/c_can.h | 4 2 files change

[net-next 33/39] can: c_can: fix remaining checkpatch warnings

2021-03-30 Thread Marc Kleine-Budde
This patch fixes the remaining checkpatch warnings in the driver. Link: https://lore.kernel.org/r/20210304154240.2747987-7-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can.c | 3 ++- drivers/net/can/c_can/c_can_pci.c | 2 +- 2 files changed, 3 insertions

[net-next 37/39] can: c_can: use 32-bit write to set arbitration register

2021-03-30 Thread Marc Kleine-Budde
From: Dario Binacchi The arbitration register is already set up with 32-bit writes in the other parts of the code except for this point. Link: https://lore.kernel.org/r/20210302215435.18286-5-dario...@libero.it Signed-off-by: Dario Binacchi Signed-off-by: Marc Kleine-Budde --- drivers/net

[net-next 30/39] can: c_can: fix indention

2021-03-30 Thread Marc Kleine-Budde
This patch fixes the indention in the driver. Link: https://lore.kernel.org/r/20210304154240.2747987-4-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can.c | 12 ++-- drivers/net/can/c_can/c_can.h | 10 +- drivers/net/can/c_can

[net-next 35/39] can: c_can: fix indentation

2021-03-30 Thread Marc Kleine-Budde
From: Dario Binacchi Commit 524369e2391f ("can: c_can: remove obsolete STRICT_FRAME_ORDERING Kconfig option") left behind wrong indentation, fix it. Link: https://lore.kernel.org/r/20210302215435.18286-3-dario...@libero.it Signed-off-by: Dario Binacchi Signed-off-by: Marc Kl

[net-next 32/39] can: c_can: replace double assignments by two single ones

2021-03-30 Thread Marc Kleine-Budde
This patch replaces the double assignments by two single ones, to make checkpatch happy. Link: https://lore.kernel.org/r/20210304154240.2747987-6-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions

[net-next 31/39] can: c_can: fix print formating string

2021-03-30 Thread Marc Kleine-Budde
This patch fixes the print format string in the driver, so that it stays in a single line. Link: https://lore.kernel.org/r/20210304154240.2747987-5-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can_pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions

[net-next 29/39] can: c_can: remove unnecessary blank lines and add suggested ones

2021-03-30 Thread Marc Kleine-Budde
This patch removes unnecessary blank lines and add suggested ones, so that checkpatch doesn't complain anymore. Link: https://lore.kernel.org/r/20210304154240.2747987-3-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can.c | 2 -- drivers/net/can/

[net-next 28/39] can: c_can: convert block comments to network style comments

2021-03-30 Thread Marc Kleine-Budde
This patch converts all block comments to network subsystem style block comments. Link: https://lore.kernel.org/r/20210304154240.2747987-2-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can.c | 52 ++- drivers/net/can/c_can

[net-next 21/39] can: tcan4x5x: remove duplicate include of regmap.h

2021-03-30 Thread Marc Kleine-Budde
ned-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/tcan4x5x.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/can/m_can/tcan4x5x.h b/drivers/net/can/m_can/tcan4x5x.h index c66da829b795..e62c030d3e1e 100644 --- a/drivers/net/can/m_can/tcan4x5x.h +++ b/drivers/net/can/m_can/

[net-next 26/39] can: mcp251xfd: add HW timestamp infrastructure

2021-03-30 Thread Marc Kleine-Budde
, timecounter and delayed worker infrastructure (which runs every 45 seconds) to convert the timer into a proper 64 bit based ns timestamp. Link: https://lore.kernel.org/r/20210304160328.2752293-6-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/spi/mcp251xfd/Makefile

[net-next 24/39] can: mcp251xfd: move netdevice.h to mcp251xfd.h

2021-03-30 Thread Marc Kleine-Budde
The netdevice.h header is needed in mcp251xfd.h, so that it can be included without further headers. Link: https://lore.kernel.org/r/20210304160328.2752293-4-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 1 - drivers/net/can/spi

[net-next 25/39] can: mcp251xfd: mcp251xfd_get_timestamp(): move to mcp251xfd.h

2021-03-30 Thread Marc Kleine-Budde
This is a preparation patch, it moves the mcp251xfd_get_timestamp() function into the mcp251xfd.h file. Link: https://lore.kernel.org/r/20210304160328.2752293-5-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 6 -- drivers/net/can/spi

[net-next 20/39] can: m_can: fix periph RX path: use rx-offload to ensure skbs are sent from softirq context

2021-03-30 Thread Marc Kleine-Budde
the correct context, with h/w timestamping to ensure correct ordering. Link: https://lore.kernel.org/r/20210308102427.63916-4-to...@maxiluxsystems.com Signed-off-by: Torin Cooper-Bennun [mkl: m_can_class_register(): update error handling] Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can

[net-next 23/39] can: mcp251xfd: simplify UINC handling

2021-03-30 Thread Marc Kleine-Budde
0. Link: https://lore.kernel.org/r/20210304160328.2752293-3-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- .../net/can/spi/mcp251xfd/mcp251xfd-core.c| 69 ++- 1 file changed, 37 insertions(+), 32 deletions(-) diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd

[net-next 17/39] can: m_can: m_can_class_allocate_dev(): remove impossible error return judgment

2021-03-30 Thread Marc Kleine-Budde
Kleine-Budde --- drivers/net/can/m_can/m_can.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 2ae3da16cbfe..12a75ebe9ce1 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -1787,11 +1787,6

[net-next 22/39] can: mcp251xfd: add dev coredump support

2021-03-30 Thread Marc Kleine-Budde
e TEF-, RX- and TX-FIFOs, it can be analyzed with the mcp251xfd-dump tool of the can-utils: https://github.com/linux-can/can-utils/tree/master/mcp251xfd Link: https://lore.kernel.org/r/20210304160328.2752293-2-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/spi/mcp2

[net-next 18/39] can: m_can: add infrastructure for internal timestamps

2021-03-30 Thread Marc Kleine-Budde
From: Torin Cooper-Bennun Add infrastucture to allow internal timestamps from the M_CAN to be configured and retrieved. Link: https://lore.kernel.org/r/20210308102427.63916-2-to...@maxiluxsystems.com Signed-off-by: Torin Cooper-Bennun Signed-off-by: Marc Kleine-Budde --- drivers/net/can

[net-next 16/39] can: peak_usb: add support of ONE_SHOT mode

2021-03-30 Thread Marc Kleine-Budde
From: Stephane Grosjean This patch adds "ONE-SHOT" mode support to the following CAN-USB PEAK-System GmbH interfaces: - PCAN-USB X6 - PCAN-USB FD - PCAN-USB Pro FD - PCAN-Chip USB - PCAN-USB Pro Signed-off-by: Stephane Grosjean [mkl: split into two patches] Signed-off-by: Marc Kl

[net-next 14/39] can: peak_usb: pcan_usb_pro_encode_msg(): use macros for flags instead of plain integers

2021-03-30 Thread Marc Kleine-Budde
] Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/peak_usb/pcan_usb_pro.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_pro.c b/drivers/net/can/usb/peak_usb/pcan_usb_pro.c index 18fa180ecc81..902900d4f7c1 100644 --- a/drivers/net

[net-next 19/39] can: m_can: m_can_chip_config(): enable and configure internal timestamps

2021-03-30 Thread Marc Kleine-Budde
highest prescalar so that the timestamp wraps every 2^20 bit times, or 209 ms at a bus speed of 5 Mbit/s. Timestamps will have a precision of 16 bit times. Link: https://lore.kernel.org/r/20210308102427.63916-3-to...@maxiluxsystems.com Signed-off-by: Torin Cooper-Bennun Signed-off-by: Marc Kleine

[net-next 15/39] can: peak_usb: add support of ethtool set_phys_id()

2021-03-30 Thread Marc Kleine-Budde
] Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/peak_usb/pcan_usb.c | 47 drivers/net/can/usb/peak_usb/pcan_usb_core.c | 4 ++ drivers/net/can/usb/peak_usb/pcan_usb_core.h | 2 + drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 34 ++ drivers/net/can/usb

[net-next 13/39] can: ucan: fix alignment constraints

2021-03-30 Thread Marc Kleine-Budde
ructure to have the same alignment as the inner one. Link: https://lore.kernel.org/r/20210204162625.3099392-1-a...@kernel.org Signed-off-by: Arnd Bergmann Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/ucan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/n

[net-next 11/39] can: grcan: add missing Kconfig dependency to HAS_IOMEM

2021-03-30 Thread Marc Kleine-Budde
On ARCHs without IOMEM support the grcan driver fails to link due to missing iomem functionality. This patch adds the missing Kconfig dependency to HAS_IOMEM. Link: https://lore.kernel.org/r/20210309140424.3331010-1-...@pengutronix.de Reported-by: kernel test robot Signed-off-by: Marc Kleine

[net-next 12/39] can: xilinx_can: Simplify code by using dev_err_probe()

2021-03-30 Thread Marc Kleine-Budde
rnel.org/r/91af0945ed7397b08f1af0c829450620bd92b804.1612442564.git.michal.si...@xilinx.com Signed-off-by: Michal Simek Signed-off-by: Marc Kleine-Budde --- drivers/net/can/xilinx_can.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index 37

[net-next 10/39] can: bittiming: add CAN_KBPS, CAN_MBPS and CAN_MHZ macros

2021-03-30 Thread Marc Kleine-Budde
-by: Vincent Mailhol Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev/bittiming.c | 4 ++-- include/linux/can/bittiming.h | 8 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/dev/bittiming.c b/drivers/net/can/dev/bittiming.c index 2907e60c9a57

[net-next 09/39] can: bittiming: add calculation for CAN FD Transmitter Delay Compensation (TDC)

2021-03-30 Thread Marc Kleine-Budde
hol Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev/bittiming.c | 24 drivers/net/can/dev/netlink.c | 2 ++ include/linux/can/bittiming.h | 6 ++ 3 files changed, 32 insertions(+) diff --git a/drivers/net/can/dev/bittiming.c b/drivers/net/can/

[net-next 08/39] can: netlink: move '=' operators back to previous line (checkpatch fix)

2021-03-30 Thread Marc Kleine-Budde
/lore.kernel.org/r/20210224002008.4158-4-mailhol.vinc...@wanadoo.fr Signed-off-by: Vincent Mailhol Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev/netlink.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/net/can/dev/netlink

[net-next 05/39] can: dev: can_free_echo_skb(): extend to return can frame length

2021-03-30 Thread Marc Kleine-Budde
this function, too. This patch is the natural extension of commit: | 9420e1d495e2 ("can: dev: can_get_echo_skb(): extend to return can |frame length") Link: https://lore.kernel.org/r/20210319142700.305648-3-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drive

[net-next 06/39] can: add new CAN FD bittiming parameters: Transmitter Delay Compensation (TDC)

2021-03-30 Thread Marc Kleine-Budde
70/V70/V71 Family: https://www.mouser.com/datasheet/2/268/60001527A-1284321.pdf Link: https://lore.kernel.org/r/20210224002008.4158-2-mailhol.vinc...@wanadoo.fr Signed-off-by: Vincent Mailhol Signed-off-by: Marc Kleine-Budde --- include/linux/can/bittiming.h | 65 ++

[net-next 07/39] can: dev: reorder struct can_priv members for better packing

2021-03-30 Thread Marc Kleine-Budde
: 31 */ /* sum members: 426, holes: 2, sum holes: 6 */ /* paddings: 1, sum paddings: 4 */ /* last cacheline: 48 bytes */ }; Link: https://lore.kernel.org/r/20210224002008.4158-3-mailhol.vinc...@wanadoo.fr Signed-off-by: Vincent Mailhol Signed-off-by: Marc Kleine-Budde

pull-request: can-next 2021-03-30

2021-03-30 Thread Marc Kleine-Budde
can: c_can: use 32-bit write to set arbitration register can: c_can: prepare to up the message objects number can: c_can: add support to 64 message objects Marc Kleine-Budde (17): MAINTAINERS: remove Dan Murphy from m_can and tcan4x5x can: dev: always create TX echo skb

[net-next 02/39] MAINTAINERS: Update MCAN MMIO device driver maintainer

2021-03-30 Thread Marc Kleine-Budde
From: Pankaj Sharma Update Chandrasekar Ramakrishnan as maintainer for mcan mmio device driver as I will be moving to a different role. Signed-off-by: Pankaj Sharma Signed-off-by: Marc Kleine-Budde --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[net-next 03/39] can: dev: always create TX echo skb

2021-03-30 Thread Marc Kleine-Budde
-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev/skb.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/dev/skb.c b/drivers/net/can/dev/skb.c index 6a64fe410987..22b0472a5fad 100644 --- a/drivers/net/can/dev/skb.c +++ b/drivers

[net-next 04/39] can: dev: can_free_echo_skb(): don't crash the kernel if can_priv::echo_skb is accessed out of bounds

2021-03-30 Thread Marc Kleine-Budde
echo_skb is accessed out of bounds") Link: https://lore.kernel.org/r/20210319142700.305648-2-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev/skb.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/dev/skb.c b/driver

[net-next 01/39] MAINTAINERS: remove Dan Murphy from m_can and tcan4x5x

2021-03-30 Thread Marc Kleine-Budde
Dan Murphy's email address at ti.com doesn't work anymore, mails bounce with: | 550 Invalid recipient (#5.1.1) For now remove all CAN related entries of Dan from the Maintainers file. Link: https://lore.kernel.org/r/20210228094218.40015-1-...@pengutronix.de Signed-off-by: Marc Kl

[net 3/3] can: uapi: can.h: mark union inside struct can_frame packed

2021-03-29 Thread Marc Kleine-Budde
g/linux-can/2c82ec23-3551-61b5-1bd8-178c3407e...@hartkopp.net/ Link: https://lore.kernel.org/r/20210325125850.1620-3-socket...@hartkopp.net Signed-off-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde --- include/uapi/linux/can.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[net 2/3] can: isotp: fix msg_namelen values depending on CAN_REQUIRED_SIZE

2021-03-29 Thread Marc Kleine-Budde
rger Acked-by: Kurt Van Dijck Link: https://lore.kernel.org/linux-can/1135648123.112255.1616613706554.javamail.zim...@nod.at/T/#t Link: https://lore.kernel.org/r/20210325125850.1620-2-socket...@hartkopp.net Signed-off-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde --- net/can/isotp.c | 11

[net 1/3] can: bcm/raw: fix msg_namelen values depending on CAN_REQUIRED_SIZE

2021-03-29 Thread Marc Kleine-Budde
einberger Tested-by: Richard Weinberger Acked-by: Kurt Van Dijck Link: https://lore.kernel.org/linux-can/1135648123.112255.1616613706554.javamail.zim...@nod.at/T/#t Link: https://lore.kernel.org/r/20210325125850.1620-1-socket...@hartkopp.net Signed-off-by: Oliver Hartkopp Signed-off-by: Marc Kl

pull-request: can 2021-03-29

2021-03-29 Thread Marc Kleine-Budde
) linux-can-fixes-for-5.12-20210329 Marc Kleine-Budde (1): can: uapi: can.h: mark union inside struct can_frame packed Oliver Hartkopp (2): can: bcm/raw: fix

Re: [PATCH] net: can: Remove duplicate include of regmap.h

2021-03-23 Thread Marc Kleine-Budde
On 23.03.2021 10:10:25, Wan Jiabing wrote: > linux/regmap.h has been included at line 13, so remove the > duplicate one at line 14. applied to linux-can-next/testing. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux |

[net 1/2] can: isotp: tx-path: zero initialize outgoing CAN frames

2021-03-20 Thread Marc Kleine-Budde
ot;can: add ISO 15765-2:2016 transport protocol") Cc: Marc Kleine-Budde Link: https://lore.kernel.org/r/20210319100619.10858-1-socket...@hartkopp.net Signed-off-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde --- net/can/isotp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[net 2/2] can: peak_usb: Revert "can: peak_usb: add forgotten supported devices"

2021-03-20 Thread Marc Kleine-Budde
t;) was added to net/master. As this would result in a merge conflict, let's revert this patch. Fixes: 59ec7b89ed3e ("can: peak_usb: add forgotten supported devices") Link: https://lore.kernel.org/r/20210320192649.341832-1-...@pengutronix.de Suggested-by: Leon Romanovsky Cc: Stephane G

pull-request: can 2021-03-20

2021-03-20 Thread Marc Kleine-Budde
03-20 20:28:45 +0100) linux-can-fixes-for-5.12-20210320 -------- Marc Kleine-Budde (1): can: peak_usb: Revert "can: peak_usb: add forgotten supported devices" Oliver Hartkopp (1): can: isotp: tx-path

  1   2   3   4   5   6   7   8   9   10   >