ere is that zero-copy only occurs if the RX-queue number
> match (XDP operating at driver ring level could know), meaning that NIC
> HW filter setup could happen async (but premapping userspace pages
> still have to happen upfront, before starting app/socket).
>
I see, a more sophisti
p?
Wouldn't that be key for massive parallelization either - With having a
queue(producer), a CPU (consumer) - vice versa - per flow at the
extreme? Did this end up in this SMART-NIC thingummy? The latter is
rather trageted at XDP, no?
--
Besten Gruß
Matthias Tafelmeier
0x8ADF34
ssed in one run can overwhelm drivers.
>>
>> This patch therefore introduces an independent configurability via sysctl to
>> userland.
>>
>> Signed-off-by: Matthias Tafelmeier
> Much better, applied, thanks.
>
Excuse me, have you rejected that one in the meantime/af
responses.
It's affordable to have large budget and rx dev_weights for the
requests. But as a side effect having this large a number on TX
processed in one run can overwhelm drivers.
This patch therefore introduces an independent configurability via sysctl to
userland.
Signed-off-by: Matt
> Actually, reverted, you didn't even build test this:
>
> net/core/dev.c:3433:35: error: initializer element is not constant
> int dev_rx_weight __read_mostly = weight_p;
>^~~~
> net/core/dev.c:3434:35: error: initializer element is not constant
> int dev
responses.
It's affordable to have large budget and rx dev_weights for the
requests. But as a side effect having this large a number on TX
processed in one run can overwhelm drivers.
This patch therefore introduces an independent configurability via sysctl to
userland.
Signed-off-by: Matt
Oftenly, introducing side effects on packet processing on the other half
of the stack by adjusting one of TX/RX via sysctl is not desirable.
There are cases of demand for asymmetric, orthogonal configurability.
This holds true especially for nodes where RPS for RFS usage on top is
configured and t
Oftenly, introducing side effects on packet processing on the other half
of the stack by adjusting one of TX/RX via sysctl is not desirable.
There are cases of demand for asymmetric, orthogonal configurability.
This holds true especially for nodes where RPS for RFS usage on top is
configured and t
On 12/27/2016 05:47 PM, Marcelo Ricardo Leitner wrote:
> On Tue, Dec 27, 2016 at 09:25:47AM +0100, Matthias Tafelmeier wrote:
>> Oftenly, introducing side effects on packet processing on the other half
>> of the stack by adjusting one of TX/RX via sysctl is not desirable.
>&g
Oftenly, introducing side effects on packet processing on the other half
of the stack by adjusting one of TX/RX via sysctl is not desirable.
There are cases of demand for asymmetric, orthogonal configurability.
This holds true especially for nodes where RPS for RFS usage on top is
configured and t
Oftenly, introducing side effects on packet processing on the other half
of the stack by adjusting one of TX/RX via sysctl is not desirable.
There are cases of demand for asymmetric, orthogonal configurability.
This holds true especially for nodes where RPS for RFS usage on top is
configured and t
> Your perception is incorrect.
> I am still maintaining iproute2. Phil is just providing lots of feedback
> and new patches.
No offense intendet! I know, Phil has already clarified things in the
other responses. Maybe you overlooked those accidentally.
> The size of the change makes it harder to
> Yeah, sorry for not having looked into this earlier. Also, I neither
> have nor claim any power of veto.
No big issue. Maybe Stephen can clarifiy things. I mean acknowledge no
further objections.
> Apart from that, I'm not against this
> patch series in general, just trying to help raise it's
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA384
> I did not take over maintenance responsibility (whatever that means
> to you precisely). I merely reviewed the patches, focussing on the
> technical aspects of both implementation and patch management.
Ah, I meant the maintenance of iproute2 as a
nts as resolved.
Those resentments were related to the patchsets complexity and size.
Right?
--
Matthias Tafelmeier
signature.asc
Description: OpenPGP digital signature
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA384
On 09/25/2015 12:16 AM, Stephen Hemminger wrote:
> On Thu, 24 Sep 2015 17:43:46 +0000 Matthias Tafelmeier
> wrote:
>
>>> Maybe it is time to rewrite it in a better language ;-)
>>
>> I did not get that. Do you me
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA384
On 09/24/2015 01:26 AM, Stephen Hemminger wrote:
> Having JSON output is going to be a real plus for programatic
> parsing. My understanding of best practice with JSON is that it is
> best to output values in best machine readable form, the format is
- add full JSON support for ss
- Patchset provides a general and easy to use abstraction to extend ss later
- Patchset size is large to minimize daily use ("user" should not deal with
formation (json, human readble) later on)
- Patches 7/10 and 8/10 illustrate how to extend ss for new data
: Matthias Tafelmeier
---
misc/ss_hr_fmt.c | 2 ++
misc/ss_json_fmt.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/misc/ss_hr_fmt.c b/misc/ss_hr_fmt.c
index 2f09838..4046ebf 100644
--- a/misc/ss_hr_fmt.c
+++ b/misc/ss_hr_fmt.c
@@ -82,6 +82,8 @@ static void tcp_stats_hr_fmt(struct tcpstat *s
Exported current_filter as ss_current_filter, because in
the fmt handlers, I need that piece of info to resolve out issues of json.
Signed-off-by: Matthias Tafelmeier
---
misc/ss.c | 154 +++---
1 file changed, 78 insertions(+), 76
This small patch extends the lib json_writer module for formerly
deactivated functionality.
Signed-off-by: Matthias Tafelmeier
---
include/json_writer.h | 1 +
lib/json_writer.c | 7 ---
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/include/json_writer.h b/include
-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 186 +---
misc/ss_types.h | 186
2 files changed, 187 insertions(+), 185 deletions(-)
create mode 100644
much
more worthwile for maintainability and this method does not ensure
correct output fmt extension in a foolproof manner.
Extension Examples:
See according sub patches in these series.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/Makefile | 2 +-
misc
output handlers is used to replace the accustomed output
logic.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 487 ++
1 file changed, 266 insertions(+), 221 deletions(-)
diff --git a/misc/ss.c b/misc
Minor fix to enable json output. Freeing of automatic char array name
which will get freed after function stack cleanup. Another one after
tcp_stats_fmt for freeing automatic tcpstats struct instance.
Signed-off-by: Matthias Tafelmeier
---
misc/ss.c | 6 --
1 file changed, 6 deletions
Minor preparation Patch
Renamed, and exported timer to not have to pass it as a function local
parameter argument.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/misc/ss.c b/misc/ss.c
index
Those functions are obsoleted since the new fmt handler mechanism
subsumes their tasks. Rendundancy would be contradictory to
the new mechanism.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 190
formatter).
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss_hr_fmt.c | 65 --
misc/ss_json_fmt.c | 69 --
misc/ss_out_fmt.c | 10
misc/ss_out_fmt.h | 10
>> +#define STATIC_ASSERT(COND, MSG)\
>> +{ \
>> +char STATIC_ASSERT##MSG[(COND) ? 1 : -1]; \
>> +(void)STATIC_ASSERT##MSG[0];\
>> +}
>
> If you are going to introduce this, please use same convention
>
This small patch extends the lib json_writer module for formerly
deactivated functionality.
Signed-off-by: Matthias Tafelmeier
---
include/json_writer.h | 1 +
lib/json_writer.c | 7 ---
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/include/json_writer.h b/include
Those functions are obsoleted since the new fmt handler mechanism
subsumes their tasks. Rendundancy would be contradictory to
the new mechanism.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 190
output handlers is used to replace the accustomed output
logic.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 487 ++
1 file changed, 266 insertions(+), 221 deletions(-)
diff --git a/misc/ss.c b/misc
formatter).
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss_hr_fmt.c | 61 ++
misc/ss_json_fmt.c | 65 ++
misc/ss_out_fmt.c | 10 +
misc/ss_out_fmt.h | 10
Exported current_filter as ss_current_filter, because in
the fmt handlers, I need that piece of info to resolve out issues of json.
Signed-off-by: Matthias Tafelmeier
---
misc/ss.c | 154 +++---
1 file changed, 78 insertions(+), 76
: Matthias Tafelmeier
---
misc/ss_hr_fmt.c | 2 ++
misc/ss_json_fmt.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/misc/ss_hr_fmt.c b/misc/ss_hr_fmt.c
index 2f09838..4046ebf 100644
--- a/misc/ss_hr_fmt.c
+++ b/misc/ss_hr_fmt.c
@@ -82,6 +82,8 @@ static void tcp_stats_hr_fmt(struct tcpstat *s
much
more worthwile for maintainability and this method does not ensure
correct output fmt extension in a foolproof manner.
Extension Examples:
See according sub patches in these series.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/Makefile | 2 +-
misc
-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 186 +---
misc/ss_types.h | 186
2 files changed, 187 insertions(+), 185 deletions(-)
create mode 100644
- add full JSON support for ss
- Patchset provides a general and easy to use abstraction to extend ss later
- Patchset size is large to minimize daily use ("user" should not deal with
formation (json, human readble) later on)
- Patches 7/10 and 8/10 illustrate how to extend ss for new data
Minor fix to enable json output. Freeing of automatic char array name
which will get freed after function stack cleanup. Another one after
tcp_stats_fmt for freeing automatic tcpstats struct instance.
Signed-off-by: Matthias Tafelmeier
---
misc/ss.c | 6 --
1 file changed, 6 deletions
Minor preparation Patch
Renamed, and exported timer to not have to pass it as a function local
parameter argument.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/misc/ss.c b/misc/ss.c
index
Exported current_filter as ss_current_filter, because in
the fmt handlers, I need that piece of info to resolve out issues of json.
Signed-off-by: Matthias Tafelmeier
---
misc/ss.c | 154 +++---
1 file changed, 78 insertions(+), 76
Minor preparation Patch
Renamed, and exported timer to not have to pass it as a function local
parameter argument.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/misc/ss.c b/misc/ss.c
index
output handlers is used to replace the accustomed output
logic.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 487 ++
1 file changed, 266 insertions(+), 221 deletions(-)
diff --git a/misc/ss.c b/misc
: Matthias Tafelmeier
---
misc/ss_hr_fmt.c | 2 ++
misc/ss_json_fmt.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/misc/ss_hr_fmt.c b/misc/ss_hr_fmt.c
index 2f09838..4046ebf 100644
--- a/misc/ss_hr_fmt.c
+++ b/misc/ss_hr_fmt.c
@@ -82,6 +82,8 @@ static void tcp_stats_hr_fmt(struct tcpstat *s
TLDR:
- add full JSON support for ss
- Patchset provides a general and easy to use abstraction to extend ss later
- Patchset size is large to minimize daily use ("user" should not deal with
formation (json, human readble) later on)
- Patches 7/10 and 8/10 illustrate how to extend ss for ne
much
more worthwile for maintainability and this method does not ensure
correct output fmt extension in a foolproof manner.
Extension Examples:
See according sub patches in these series.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/Makefile | 2 +-
misc
formatter).
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss_hr_fmt.c | 61 ++
misc/ss_json_fmt.c | 65 ++
misc/ss_out_fmt.c | 10 +
misc/ss_out_fmt.h | 10
Those functions are obsoleted since the new fmt handler mechanism
subsumes their tasks. Rendundancy would be contradictory to
the new mechanism.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 190
This small patch extends the lib json_writer module for formerly
deactivated functionality.
Signed-off-by: Matthias Tafelmeier
---
include/json_writer.h | 1 +
lib/json_writer.c | 7 ---
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/include/json_writer.h b/include
-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 186 +---
misc/ss_types.h | 186
2 files changed, 187 insertions(+), 185 deletions(-)
create mode 100644
Minor fix to enable json output. Freeing of automatic char array name
which will get freed after function stack cleanup. Another one after
tcp_stats_fmt for freeing automatic tcpstats struct instance.
Signed-off-by: Matthias Tafelmeier
---
misc/ss.c | 6 --
1 file changed, 6 deletions
Minor fix to enable json output. Freeing of automatic char array name
which will get freed after function stack cleanup. Another one after
tcp_stats_fmt for freeing automatic tcpstats struct instance.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 6
Those functions are obsoleted since the new fmt handler mechanism
subsumes their tasks. Rendundancy would be contradictory to
the new mechanism.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 190
Minor preparation Patch
Renamed, and exported timer to not have to pass it as a function local
parameter argument.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/misc/ss.c b/misc/ss.c
index
formatter).
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss_hr_fmt.c | 61 ++
misc/ss_json_fmt.c | 65 ++
misc/ss_out_fmt.c | 10 +
misc/ss_out_fmt.h | 10
output handlers is used to replace the accustomed output
logic.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 487 ++
1 file changed, 266 insertions(+), 221 deletions(-)
diff --git a/misc/ss.c b/misc
Exported current_filter as ss_current_filter, because in
the fmt handlers, I need that piece of info to resolve out issues of json.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
Conflicts:
misc/ss.c
---
misc/ss.c | 154
This small patch extendedis the lib json_writer module for hex field
which is needed in the json format handler of ss.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
include/json_writer.h | 3 +++
lib/json_writer.c | 16
2 files changed, 19
- add full JSON support for ss
- Patchset provides a general and easy to use abstraction to extend ss later
- Patchset size is large to minimize daily use ("user" should not deal with
formation (json, human readble) later on)
- Patches 7/10 and 8/10 illustrate how to extend ss for new data
-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 186 +---
misc/ss_types.h | 186
2 files changed, 187 insertions(+), 185 deletions(-)
create mode 100644
: Matthias Tafelmeier
---
misc/ss_hr_fmt.c | 2 ++
misc/ss_json_fmt.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/misc/ss_hr_fmt.c b/misc/ss_hr_fmt.c
index 2f09838..4046ebf 100644
--- a/misc/ss_hr_fmt.c
+++ b/misc/ss_hr_fmt.c
@@ -82,6 +82,8 @@ static void tcp_stats_hr_fmt(struct tcpstat *s
much
more worthwile for maintainability and this method does not ensure
correct output fmt extension in a foolproof manner.
You can find extension examples in following subpatches of this patch series.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/Makefile
On 08/23/2015 07:07 PM, Stephen Hemminger wrote:
> On Thu, 20 Aug 2015 22:40:12 +0200
> Matthias Tafelmeier wrote:
>
>> The prospected output formatters and ss do share type declarations like
>> slabstat or tcpstat so that the decision has been made to centralize
>
-BEGIN PGP MESSAGE-
Charset: windows-1252
Version: GnuPG v1
hQQOAweL74a5LMkVEA//azcgajmoTO+UKZPf5wl+V8QAi/r9gCmyyJR0wV6RsH0N
sUpnR2c9uSVNU+J41L206vDsnNk0Huoa6m6miibLFg3mxQ9KTDdzaePmkfk9FwCC
Au7RsDzxo8nq/rpZsPeD2r/EAod6C3XVGRNc6nAMMi84tMCtObjDFDQs+mPcWf5n
nCZwmdovGtzCHpw6moq51K8pql0CmRpFSnM
{first }
>>>>,
{sec}
>>>>,
{third}
.
.
.
}
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 198 --
1 file changed, 155 insertions(+), 43
Minor preparation Patch
Renamed, and exported timer to not have to pass it as a function local
parameter argument.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/misc/ss.c b/misc/ss.c
index
Now, since the fmt (json, hr) handlers are in place, all can be output via these
newly deviced code parts.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 330 +-
1 file changed, 152 insertions
Those functions are obsoleted since the new fmt handler mechanism
subsumes their tasks. Rendundancy would be contradictory to
the new mechanism.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 190
Minor fix to enable json output. Freeing of automatic char array name
which will get freed after function stack cleanup. Another one after
tcp_stats_fmt for freeing automatic tcpstats struct instance.
Signed-off-by: Matthias Tafelmeier
---
misc/ss.c | 6 --
1 file changed, 6 deletions
: Matthias Tafelmeier
---
misc/ss_hr_fmt.c | 2 ++
misc/ss_json_fmt.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/misc/ss_hr_fmt.c b/misc/ss_hr_fmt.c
index 2051ff2..ca73dda 100644
--- a/misc/ss_hr_fmt.c
+++ b/misc/ss_hr_fmt.c
@@ -82,6 +82,8 @@ static void tcp_stats_hr_fmt(struct tcpstat *s
Exported current_filter as ss_current_filter, because in
the fmt handlers, I need that piece of info to resolve out issues of json.
Signed-off-by: Matthias Tafelmeier
Conflicts:
misc/ss.c
---
misc/ss.c | 220 +++---
1 file changed
end ss for new data to support
human readble and json
output.
- Example_Usages: 1. ss -jt to print out all tcp related information formatted
in json
2. ss --json -a to print out all info (also summary)
STATS:
Matthias Tafelmeier (10):
ss: rooted out ss type declar
formatter).
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss_hr_fmt.c | 61 ++
misc/ss_json_fmt.c | 65 ++
misc/ss_out_fmt.c | 10 +
misc/ss_out_fmt.h | 10
-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 186 +---
misc/ss_types.h | 186
2 files changed, 187 insertions(+), 185 deletions(-)
create mode 100644
ecn\": \"true\"", indent1);
}
[...]
-> macro to ensure statically no new tcp_stats info will be forgotten in
-> any of the fmt handlers
CHECK_FMT_ADAPT(s->new_foo_pred, s, error_msg_adapation_issue);
Signed-off-by: Matth
ecn\": \"true\"", indent1);
}
[...]
-> macro to ensure statically no new tcp_stats info will be forgotten in
-> any of the fmt handlers
CHECK_FMT_ADAPT(s->new_foo_pred, s, error_msg_adapation_issue);
Signed-off-by: Matth
{first }
>>>>,
{sec}
>>>>,
{third}
.
.
.
}
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 198 --
1 file changed, 155 insertions(+), 43
-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 186 +---
misc/ss_types.h | 186
2 files changed, 187 insertions(+), 185 deletions(-)
create mode 100644
Minor fix to enable json output. Freeing of automatic char array name
which will get freed after function stack cleanup. Another one after
tcp_stats_fmt for freeing automatic tcpstats struct instance.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 6
This small sized patch shall convey the locations which have to be
changed for a symmetrical output extension. Symmetrical means in this
context all existing semantically related handlers in the diverse
formatters (for hr and json up to now).
Signed-off-by: Matthias Tafelmeier
Suggested-by
Minor preparation Patch
Renamed, and exported timer to not have to pass it as a function local
parameter argument.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/misc/ss.c b/misc/ss.c
index
Exported current_filter as ss_current_filter, because in
the fmt handlers, I need that piece of info to resolve out issues of json.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 218 +++---
1 file
Now, since the fmt (json, hr) handlers are in place, all can be output via these
newly deviced code parts.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 330 +-
1 file changed, 152 insertions
formatter).
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss_hr_fmt.c | 61 ++
misc/ss_json_fmt.c | 65 ++
misc/ss_out_fmt.c | 10 +
misc/ss_out_fmt.h | 10
end ss for new data to support
human readble and json
output.
- Example_Usages: 1. ss -jt to print out all tcp related information formatted
in json
2. ss --json -a to print out all info (also summary)
STATS:
Matthias Tafelmeier (10):
ss: rooted out ss type declar
Those functions are obsoleted since the new fmt handler mechanism
subsumes their tasks. Rendundancy would be contradictory to
the new mechanism.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 190
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA384
>> {} not needed. I guess you haven't run your patches thru
>> scripts/checkpatch.pl?
>>
>
> Yes, although this is missing from iproute2 sources ;)
>
>
Thank you for reviewing so far.
I see there slipped some parts of the patch through accord
Now, since the fmt (json, hr) handlers are in place, all can be output via these
newly deviced code parts.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 332 +-
1 file changed, 153 insertions
This small sized patch shall convey the locations which have to be
changed for a symmetrical output extension. Symmetrical means in this
context all existing semantically related handlers in the diverse
formatters (for hr and json up to now).
Signed-off-by: Matthias Tafelmeier
Suggested-by
ecn\": \"true\"", indent1);
}
[...]
-> macro to ensure statically no new tcp_stats info will be forgotten in
-> any of the fmt handlers
CHECK_FMT_ADAPT(s->new_foo_pred, s, error_msg_adapation_issue);
Signed-off-by: Matth
end ss for new data to support
human readble and json
output.
- Example_Usages: 1. ss -jt to print out all tcp related information formatted
in json
2. ss --json -a to print out all info (also summary)
STATS:
Matthias Tafelmeier (10):
ss: rooted out ss type declar
Those functions are obsoleted since the new fmt handler mechanism
subsumes their tasks. Rendundancy would be contradictory to
the new mechanism.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 190
Minor fix to enable json output. Freeing of automatic char array name
which will get freed after function stack cleanup. Another one after
tcp_stats_fmt for freeing automatic tcpstats struct instance.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 6
Exported current_filter as ss_current_filter, because in
the fmt handlers, I need that piece of info to resolve out issues of json.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 218 +++---
1 file
-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 186 +---
misc/ss_types.h | 186
2 files changed, 187 insertions(+), 185 deletions(-)
create mode 100644
Minor preparation Patch
Renamed, and exported timer to not have to pass it as a function local
parameter argument.
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/misc/ss.c b/misc/ss.c
index
{first }
>>>>,
{sec}
>>>>,
{third}
.
.
.
}
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss.c | 200 --
1 file changed, 157 insertions(+), 43
formatter).
Signed-off-by: Matthias Tafelmeier
Suggested-by: Hagen Paul Pfeifer
---
misc/ss_hr_fmt.c | 61 ++
misc/ss_json_fmt.c | 65 ++
misc/ss_out_fmt.c | 10 +
misc/ss_out_fmt.h | 10
98 matches
Mail list logo
