[PATCH] net: ethoc: enable NAPI before poll may be scheduled

2017-06-05 Thread Max Filippov
at all. Move napi_enable above ethoc_reset in the ethoc_open to fix that. Cc: sta...@vger.kernel.org Signed-off-by: Max Filippov <jcmvb...@gmail.com> --- drivers/net/ethernet/ethoc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ethoc.c b/drive

Re: [PATCH net v2 0/2] net: ethoc: Error path and transmit fixes

2016-07-12 Thread Max Filippov
dev) if (skb_put_padto(skb, ETHOC_ZLEN)) { dev->stats.tx_errors++; - goto out; + return NETDEV_TX_OK; } if (unlikely(skb->len > ETHOC_BUFSIZ)) { Without it the interface becomes non-functional after the first error in s

Re: [PATCH net v2 2/2] net: ethoc: Correctly pad short packets

2016-07-12 Thread Max Filippov
Hi Florian, On Mon, Jul 11, 2016 at 04:35:55PM -0700, Florian Fainelli wrote: > Even though the hardware can be doing zero padding, we want the SKB to > be going out on the wire with the appropriate size. This fixes packet > truncations observed with e.g: ARP packets. > > Signed-off-by: Florian

Re: [PATCH 1/2] net: ethernet: ethoc: use phydev from struct net_device

2016-06-25 Thread Max Filippov
ed in struct net_device. > > Signed-off-by: Philippe Reynes <trem...@gmail.com> > --- Series: Tested-by: Max Filippov <jcmvb...@gmail.com> -- Thanks. -- Max

Re: [PATCH][V2] net/ethoc: fix null dereference on error exit path

2016-06-01 Thread Max Filippov
om> > --- > drivers/net/ethernet/ethoc.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Max Filippov <jcmvb...@gmail.com> -- Thanks. -- Max

Re: [PATCH] net/ethoc: fix null dereference on error exit path

2016-05-22 Thread Max Filippov
Hi Colin, On Sun, May 22, 2016 at 08:08:18PM +0100, Colin King wrote: > From: Colin Ian King > > priv is assigned to NULL however all the error exit paths to label 'free' > dereference priv, causing a null pointer dereference. > > Examination of the code shows that

[PATCH v2] net/ethoc: support big-endian register layout

2015-09-23 Thread Max Filippov
This allows using OpenCores ethernet controller attached to its host in native-endian mode with bi-endian CPUs. Example of such system is Xtensa XTFPGA platform. Signed-off-by: Max Filippov <jcmvb...@gmail.com> --- Changes v1->v2: - expand changelog with motivation for the change. dr

[PATCH] net/ethoc: support big-endian register layout

2015-09-22 Thread Max Filippov
Signed-off-by: Max Filippov <jcmvb...@gmail.com> --- drivers/net/ethernet/ethoc.c | 14 -- include/net/ethoc.h | 1 + 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c index 442410c..17ff9a4