Re: [PATCH 3/4] cpsw_switchdev: add switchdev support files

2018-05-24 Thread Maxim Uvarov
obj); > + struct cpsw_priv *priv = netdev_priv(ndev); > + int err = 0; > + > + switch (obj->id) { > + case SWITCHDEV_OBJ_ID_PORT_VLAN: > + err = cpsw_port_vlans_del(priv, vlan); > + break; > + case SWITCHDEV_OBJ_ID_PORT_MDB: > + err = cpsw_port_mdb_del(priv, SWITCHDEV_OBJ_PORT_MDB(obj)); > + break; > + default: > + err = -EOPNOTSUPP; > + break; > + } > + > + return err; > +} > + > +static const struct switchdev_ops cpsw_port_switchdev_ops = { > + .switchdev_port_attr_set= cpsw_port_attr_set, > + .switchdev_port_attr_get= cpsw_port_attr_get, > + .switchdev_port_obj_add = cpsw_port_obj_add, > + .switchdev_port_obj_del = cpsw_port_obj_del, > +}; > + > +void cpsw_port_switchdev_init(struct net_device *ndev) > +{ > + ndev->switchdev_ops = _port_switchdev_ops; > +} > diff --git a/drivers/net/ethernet/ti/cpsw_switchdev.h > b/drivers/net/ethernet/ti/cpsw_switchdev.h > new file mode 100644 > index 000..4940462 > --- /dev/null > +++ b/drivers/net/ethernet/ti/cpsw_switchdev.h > @@ -0,0 +1,4 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#include > + > +void cpsw_port_switchdev_init(struct net_device *ndev); > -- > 2.7.4 > -- Best regards, Maxim Uvarov

Re: phy: micrel.c: Support ksz9031 energy-detect power-down mode

2018-02-27 Thread Maxim Uvarov
CC netdev 2018-02-27 13:12 GMT+03:00 Maxim Uvarov <muva...@gmail.com>: > It migth be reason to reconsider of unconditionally enable power-down mode. > v1 of patch and code here: > https://lkml.org/lkml/2016/10/3/199 > > I see that 9031 just lock ups with start from -40C j

Re: [PATCH v1 RFC 1/1] Add Microchip KSZ8795 DSA driver

2017-10-09 Thread Maxim Uvarov
Hello Tristram, in previous version I see that transit traffic (ping) goes to cpu, then from cpu back to destination port. I.e. it works but with cpu involving. Is this version supposed to work like that? Thank you, Maxim. 2017-10-06 23:33 GMT+03:00 : > From:

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

2017-09-14 Thread Maxim Uvarov
fine. Your >> code should never do anything different if a debugfs call succeeds or >> fails. > > Thank for your interesting review! I'll cleanup my out-of-tree patches. > > > Vivien -- Best regards, Maxim Uvarov

Re: [PATCH RFC] Update documentation for KSZ DSA drivers so that new drivers can be added

2017-09-11 Thread Maxim Uvarov
2017-09-08 22:48 GMT+03:00 <tristram...@microchip.com>: >> -Original Message----- >> From: Maxim Uvarov [mailto:muva...@gmail.com] >> Sent: Friday, September 08, 2017 12:00 PM >> To: Florian Fainelli >> Cc: Tristram Ha - C24268; Andrew Lunn; Pavel Mach

Re: [PATCH RFC] Update documentation for KSZ DSA drivers so that new drivers can be added

2017-09-08 Thread Maxim Uvarov
>> reg = <4>; >> - >> label = "lan5"; >> - >> }; >> - >> port@5 { >> - >> reg = <5>; >> - >> label = "cpu"; >> - >> ethernet = <>; >> - >> fixed-link { >> - >> speed = <1000>; >> - >> full-duplex; >> - >> }; >> - >> }; >> - }; >> - }; >> - }; >> > > > -- > Florian -- Best regards, Maxim Uvarov

Re: [PATCH RFC] Update documentation for KSZ DSA drivers so that new drivers can be added

2017-09-08 Thread Maxim Uvarov
>> port@5 { >> - >> reg = <5>; >> - >> label = "cpu"; >> - >> ethernet = <>; >> - >> fixed-link { >> - >> speed = <1000>; >> - >> full-duplex; >> - >> }; >> - >> }; >> - }; >> - }; >> - }; > > This part however is a nice cleanup. You can submit this patch as a > separate patch, once netdev has opened again in about 10 days time. > > Andrew -- Best regards, Maxim Uvarov

Re: [PATCH] DSA support for Micrel KSZ8895

2017-09-06 Thread Maxim Uvarov
t; no problem. The KSZ8895 driver will be submitted right after that. You > should have no problem using the driver right away. > Hello Tristram, is there any update for that driver? Maxim. > Tristram Ha > Principal Software Engineer > Microchip Technology Inc. > -- Best regards, Maxim Uvarov

Re: DSA mv88e6xxx RX frame errors and TCP/IP RX failure

2017-08-31 Thread Maxim Uvarov
cores. Use this value also for the maximum receive buffer size. The > driver is already allocating a receive SKB of 2048 bytes, so this > change should not have any significant effects. > > Tested on imx51, imx6, vf610. > > Signed-off-by: Andrew Lunn <and...@lunn.ch> > Signed-off-by: David S. Miller <da...@davemloft.net> > > > However, this is was of an all/nothing problem. All frames with the > full MTU were getting dropped, where as i think you are only seeing a > few dropped? > > Anyway, try cherry picking that patch and see if it helps. > > Andrew -- Best regards, Maxim Uvarov

Re: [PATCH] DSA support for Micrel KSZ8895

2017-08-30 Thread Maxim Uvarov
ink = sw_adjust_link; return phydev; } Where is bus is: bus = mdiobus_alloc(); bus->read = ksz_mii_read; (spi read function) bus->write = ksz_mii_write; Then just generic reads: .config_aneg= genphy_config_aneg, .read_status= genphy_read_status, Maxim. >> >> Pointers would be welcome at this point. >> >> Thanks, >> Pavel >> > > > -- > Florian -- Best regards, Maxim Uvarov

Re: [PATCH] DSA support for Micrel KSZ8895

2017-08-28 Thread Maxim Uvarov
entation->Software library. Both driver and DSA driver. Driver has to work with some minor fixups related to your kernel version. But I think they are don't care about up-streaming that code. So you can take their code as a reference. -- Best regards, Maxim Uvarov

Re: port mirror on dsa switches?

2017-03-16 Thread Maxim Uvarov
2017-03-16 19:47 GMT+03:00 Florian Fainelli <f.faine...@gmail.com>: > Hi, > > On 03/16/2017 03:32 AM, Maxim Uvarov wrote: >> Hello, >> >> Some dsa switches can support port mirror in hardware. Does somebody >> have any idea how to >> work with it fr

port mirror on dsa switches?

2017-03-16 Thread Maxim Uvarov
switch ports. -- Best regards, Maxim Uvarov

Adding vlan to DSA port causes lockdep splat

2017-02-21 Thread Maxim Uvarov
) [ 37.510171] r7:1002 r6: r5:dd4fd800 r4:dc1f3000 [ 37.515856] [] (dsa_slave_set_rx_mode) from [] (__dev_set_rx_mode+0x64/0x9c) -- Best regards, Maxim Uvarov